[PATCH] configure.ac: Allow forcible disabling of Cairo support

2012-10-03 Thread Daniel Stone
We don't want to build libdrm tests with Cairo support under Poky, since they're never used and also cause a build loop from libdrm - cairo - mesa-dri - libdrm. To avoid variance in build results, introduce a --disable-cairo-tests switch. Signed-off-by: Daniel Stone dan...@fooishbar.org

[PATCH v2] configure.ac: Allow forcible disabling of Cairo support

2012-10-03 Thread Daniel Stone
We don't want to build libdrm tests with Cairo support under Poky, since they're never used and also cause a build loop from libdrm - cairo - mesa-dri - libdrm. To avoid variance in build results, introduce a --disable-cairo-tests switch. Signed-off-by: Daniel Stone dan...@fooishbar.org

[PATCH v3] configure.ac: Allow forcible disabling of Cairo support

2012-10-03 Thread Daniel Stone
We don't want to build libdrm tests with Cairo support under Poky, since they're never used and also cause a build loop from libdrm - cairo - mesa-dri - libdrm. To avoid variance in build results, introduce a --disable-cairo-tests switch. Signed-off-by: Daniel Stone dan...@fooishbar.org

Re: [Linaro-mm-sig] [RFC 0/1] drm/pl111: Initial drm/kms driver for pl111

2013-09-15 Thread Daniel Stone
Hi, On Tue, 2013-08-06 at 12:31 +0100, Tom Cooksey wrote: On Fri, Jul 26, 2013 at 11:58 AM, Tom Cooksey tom.cook...@arm.com wrote: that was part of the reason to punt this problem to userspace ;-) In practice, the kernel drivers doesn't usually know too much about the

Re: [PATCH 00/11] drm/msm: A5XX preemption

2017-02-06 Thread Daniel Stone
Hi, On 6 February 2017 at 17:59, Daniel Vetter wrote: > On Mon, Feb 06, 2017 at 10:39:28AM -0700, Jordan Crouse wrote: >> This initial series implements 4 ringbuffers to give sufficient coverage for >> the >> range of priority levels requested by the GLES and compute

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-17 Thread Daniel Stone
Hi, On 17 February 2017 at 14:56, Ville Syrjälä wrote: > On Fri, Feb 17, 2017 at 02:42:26PM +, Lionel Landwerlin wrote: >> If we're talking fixed point reprsentation, ChromeOS is using this : >> >>

Re: [RFC][PATCH 1/2] drm/probe-helper: Add mode_valid check to drm_crtc_helper_funcs

2017-02-14 Thread Daniel Stone
Hi John, On 14 February 2017 at 19:25, John Stultz wrote: > +static enum drm_mode_status > +drm_connector_check_crtc_modes(struct drm_connector *connector, > + struct drm_display_mode *mode) > +{ > + struct drm_device *dev =

Re: [PATCH v2] drm/color: Document CTM eqations

2017-02-15 Thread Daniel Stone
Hi, On 15 February 2017 at 11:39, Ville Syrjälä wrote: > On Tue, Jan 31, 2017 at 06:46:39PM +0100, Daniel Vetter wrote: >> On Tue, Jan 31, 2017 at 6:22 PM, Ville Syrjälä >> wrote: >> > Hmm. Two's complement is what I was thinking it

Re: [PATCH v2 1/2] drm/cma-helper: Add multi buffer support for cma fbdev

2017-02-13 Thread Daniel Stone
Hi Maxime, On 13 February 2017 at 10:54, Maxime Ripard wrote: > On Sun, Feb 12, 2017 at 02:28:11PM +0200, Laurent Pinchart wrote: >> On Thursday 02 Feb 2017 11:31:56 Maxime Ripard wrote: >> > This patch add a config to support to create multi buffer for cma

Re: [PATCH v2 2/2] drm/fb_helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-09 Thread Daniel Stone
Hi, On 9 February 2017 at 17:01, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 11:31:57AM +0100, Maxime Ripard wrote: >> +int drm_fb_helper_ioctl(struct fb_info *info, unsigned int cmd, unsigned >> long arg) >> +{ >> + struct drm_fb_helper *fb_helper = info->par; >> +

[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Daniel Stone
Hi, On 29 September 2016 at 16:20, Daniel Vetter wrote: > + * 1. Driver commits new hardware state into vblank-synchronized registes. > + * 2. A vblank happes, committing the hardware state. Also the corresponding > + *vblank interrupt is fired off and fully processed by the interrupt > + *

[PATCH] drm: Document caveats around atomic event handling

2016-09-30 Thread Daniel Stone
On 30 September 2016 at 11:55, Daniel Stone wrote: > Hi, > > [...] ... and with that, Reviewed-by: Daniel Stone Cheers, Daniel, off to find more coffee

[PATCH 2/2] [media] v4l: Add 10-bits per channel YUV pixel formats

2017-01-03 Thread Daniel Stone
Hi all, On 2 January 2017 at 13:03, ayaka wrote: > On 01/02/2017 07:07 PM, Sakari Ailus wrote: >> On Mon, Jan 02, 2017 at 06:53:16PM +0800, ayaka wrote: >>> On 01/02/2017 05:10 PM, Sakari Ailus wrote: If the format resembles the existing formats but on a different bit depth, it

[PATCH 1/2] drm_fourcc: Add new P010 video format

2017-01-03 Thread Daniel Stone
Hi Randy, On 2 January 2017 at 09:50, Randy Li wrote: > P010 is a planar 4:2:0 YUV with interleaved UV plane, 10 bits > per channel video format. Rockchip's vop support this > video format(little endian only) as the input video format. > > Signed-off-by: Randy Li > --- >

Unix Device Memory Allocation project

2017-01-04 Thread Daniel Stone
Hi Marek, On 3 January 2017 at 23:38, Marek Olšák wrote: > I've been thinking about it, and it looks like we're gonna continue > using immutable per-BO metadata (buffer layout, tiling description, > compression flags). The reasons are that everything else is less > economical, and the current

Unix Device Memory Allocation project

2017-01-04 Thread Daniel Stone
Hi Christian, On 4 January 2017 at 16:02, Christian König wrote: > Am 04.01.2017 um 16:47 schrieb Rob Clark: >> If the position of the different parts of the buffer are somewhere >> required to be a function of w/h/bpp/etc then I'm not sure if there is >> a strong advantage to treating them as

[PATCH v2 1/2] drm_fourcc: Add new P010, P016 video format

2017-01-04 Thread Daniel Stone
Hi Randy, On 4 January 2017 at 16:29, Randy Li wrote: > index 90d2cc8..23c8e99 100644 > --- a/drivers/gpu/drm/drm_fourcc.c > +++ b/drivers/gpu/drm/drm_fourcc.c > @@ -165,6 +165,9 @@ const struct drm_format_info *__drm_format_info(u32 > format) > { .format = DRM_FORMAT_UYVY,

[PATCH] drm/i915/dp: Stop enabling limited color ranges for everything

2017-01-05 Thread Daniel Stone
Hi, On 5 January 2017 at 08:52, Daniel Vetter wrote: > On Thu, Jan 05, 2017 at 10:41:07AM +0200, Jani Nikula wrote: >> No matter what we do here, the question remains what to do with >> Chamelium. Changing the color range is really a workaround for >> Chamelium, not a fix. Using CEA range is

Re: [RFC] [GPU][DRM][PROPERTY] -Added a new ioctl in Linux DRM KMS driver.

2017-01-20 Thread Daniel Stone
Hi Satendra, On 20 January 2017 at 08:12, Satendra Singh Thakur wrote: > -Added a new ioctl in Linux DRM KMS driver. > This ioctl allows user to set the values of an object’s multiple > properties in one go. > -In the absence of such ioctl, User would be calling one

Re: [maintainers-tools] dim: Clarify how to proceed when adding drm-xxx remotes

2017-02-28 Thread Daniel Stone
, rather than specifying it in the remote URL, you can modify ~/.ssh/config: $ printf '\nHost git.freedesktop.org\n\tUser ' >> ~/.ssh/config with that, it's: Reviewed-by: Daniel Stone <dani...@collabora.com> Cheers, Daniel __

[RFC v2 5/8] drm/fence: add in-fences support

2016-04-27 Thread Daniel Stone
Hi, On 26 April 2016 at 21:48, Greg Hackmann wrote: > On 04/26/2016 01:05 PM, Daniel Vetter wrote: >> On Tue, Apr 26, 2016 at 09:55:06PM +0300, Ville Syrjälä wrote: >>> What are they doing that can't stuff the fences into an array >>> instead of props? >> >> The hw composer interface is one

[Intel-gfx] [PATCH 3/5] drm/crtc: take references to connectors used in a modeset.

2016-04-27 Thread Daniel Stone
Hi, On 27 April 2016 at 03:03, Dave Airlie wrote: > diff --git a/drivers/gpu/drm/drm_crtc_helper.c > b/drivers/gpu/drm/drm_crtc_helper.c > index 66ca313..29b7835 100644 > --- a/drivers/gpu/drm/drm_crtc_helper.c > +++ b/drivers/gpu/drm/drm_crtc_helper.c > @@ -456,6 +456,9 @@

[Intel-gfx] [PATCH 4/5] drm/atomic: use connector references

2016-04-27 Thread Daniel Stone
Hi, On 27 April 2016 at 03:03, Dave Airlie wrote: > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 9d5e3c8..d899dac 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -1179,6 +1179,15 @@ drm_atomic_set_crtc_for_connector(struct

[Intel-gfx] [PATCH 4/5] drm/atomic: use connector references

2016-04-27 Thread Daniel Stone
Hi, On 27 April 2016 at 03:03, Dave Airlie wrote: > diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c > index 9d5e3c8..d899dac 100644 > --- a/drivers/gpu/drm/drm_atomic.c > +++ b/drivers/gpu/drm/drm_atomic.c > @@ -1179,6 +1179,15 @@ drm_atomic_set_crtc_for_connector(struct

[RFC v2 7/8] drm/fence: add fence timeline to drm_crtc

2016-04-27 Thread Daniel Stone
Hi, On 26 April 2016 at 00:33, Gustavo Padovan wrote: > +static inline struct drm_crtc *fence_to_crtc(struct fence *fence) > +{ > + if (fence->ops != _crtc_fence_ops) > + return NULL; Since this is (currently) only used before unconditional dereferences, maybe turn this into

[RFC v2 5/8] drm/fence: add in-fences support

2016-04-29 Thread Daniel Stone
Hi, On 28 April 2016 at 23:28, Rob Clark wrote: > On Wed, Apr 27, 2016 at 2:39 AM, Daniel Vetter wrote: >> On Tue, Apr 26, 2016 at 01:48:02PM -0700, Greg Hackmann wrote: >>> A (per-CRTC?) array of fences would be more flexible. And even in the cases >>> where you could make a 1-to-1 mapping

[PATCH 0/6] drm: Explicit target vblank seqno for page flips

2016-08-04 Thread Daniel Stone
Hi, On 4 August 2016 at 04:39, Michel Dänzer wrote: > Patch 6 extends the ioctl with new flags, which allow userspace to > explicitly specify the target vblank seqno. This can also avoid delaying > flips in some cases where we are already in the target vertical blank > period when the ioctl is

RFC: hardware accelerated bitblt using dma engine

2016-08-04 Thread Daniel Stone
Hi, On 4 August 2016 at 08:50, Daniel Vetter wrote: > One problem with 2d blitters is that there's no common userspace > interface, but many: Xrender, hwc, old X drawing api, various attempts by > khronos to standardize something, cairo, ... It's probably worse than > video decoding even, and

[PATCH 0/6] drm: Explicit target vblank seqno for page flips

2016-08-04 Thread Daniel Stone
On 4 August 2016 at 11:01, Michel Dänzer wrote: > On 04.08.2016 18:51, Daniel Stone wrote: >> On 4 August 2016 at 04:39, Michel Dänzer wrote: >>> Patch 6 extends the ioctl with new flags, which allow userspace to >>> explicitly specify the target vblank seqno. T

[PATCH v3 2/3] drm: Add API for capturing frame CRCs

2016-08-06 Thread Daniel Stone
Hi Tomeu, On 22 July 2016 at 15:10, Tomeu Vizoso wrote: > +/** > + * DOC: CRC ABI > + * > + * DRM device drivers can provide to userspace CRC information of each frame > as > + * it reached a given hardware component (a "source"). > + * > + * Userspace can control generation of CRCs in a given

[PATCH 1/2] drm/hisilicon: Allow compile-testing on arm

2016-08-17 Thread Daniel Stone
On 17 August 2016 at 11:17, Daniel Vetter wrote: > diff --git a/Documentation/gpu/drm-kms.rst b/Documentation/gpu/drm-kms.rst > index d5ad60d3cf06..6544c74d250a 100644 > --- a/Documentation/gpu/drm-kms.rst > +++ b/Documentation/gpu/drm-kms.rst > @@ -389,6 +389,15 @@ connector and plane objects by

[RFC][PATCH] drm: Nuke modifier[1-3]

2016-11-16 Thread Daniel Stone
any increase in complexity. It does affect advertisement and negotiation though. I'll prepare some clarifying wording for the EGL spec, to clarify that the modifier must be equal for all planes. Acked-by: Daniel Stone Cheers, Daniel

[PATCH] drm/vc4: Fix race between page flip completion event and clean-up

2016-11-29 Thread Daniel Stone
iewed-by: Eric Anholt Reviewed-by: Daniel Stone

[PATCH 1/3] RFC: drm: Restrict vblank ioctl to master

2016-06-21 Thread Daniel Stone
Hi Rainer, On 17 June 2016 at 22:00, Rainer Hochecker wrote: > I agree. GLX_OML_sync_control fulfils all our requirements apart from being > available for EGL. It would be great to have it available for EGL. In regard > to Wayland this is really important. For the time being Kodi stopped >

[PATCH 1/3] RFC: drm: Restrict vblank ioctl to master

2016-06-21 Thread Daniel Stone
Hi, On 21 June 2016 at 04:24, Rainer Hochecker wrote: > Thanks a lot. > Would you know if/when Wayland will support OpenGL? Er, it always has ... ? It will never support GLX (as the name implies, that's X-specific), but EGL is perfectly capable of creating OpenGL contexts. It works fine.

[PATCH 1/3] RFC: drm: Restrict vblank ioctl to master

2016-06-21 Thread Daniel Stone
Hi, On 21 June 2016 at 14:57, Rainer Hochecker wrote: > Are you saying that this is outdated: > https://wayland.freedesktop.org/faq.html#heading_toc_j_12 > > A more subtle point is that libGL.so includes the GLX symbols, so linking to > that library will pull in all the X dependencies. This

[PATCH 1/3] RFC: drm: Restrict vblank ioctl to master

2016-06-24 Thread Daniel Stone
Hi Rainer, On 24 June 2016 at 05:54, Rainer Hochecker wrote: > I spent some time reading and investigating on this. Bear with me, I am > doing Kodi development in my spare time and may not be up-to-date on all > platforms. Seems Wayland is much better suited to serve as reference > platform as

Whats missing in my new FB DRM driver in ARC... waiting for console_lock to return

2016-01-22 Thread Daniel Stone
Hi, On 21 January 2016 at 18:30, Carlos Palminha wrote: > i just found that its blocking waiting for console_lock... > @vineet, alexey: i think that console_lock is architecture dependent right? > Do you know any issue with console_lock for ARC? Once console_lock is acquired, you will not see

Whats missing in my new FB DRM driver... "No connectors reported connected with modes"?

2016-01-22 Thread Daniel Stone
Hey, On 22 January 2016 at 07:41, Daniel Vetter wrote: > On Thu, Jan 21, 2016 at 7:09 PM, Carlos Palminha > wrote: >> i made some progress in identifying the issue... >> When my driver calls drm_fb_helper_initial_config it seems DRM blocks >> waiting for register_framebuffer to return. >> The

[Intel-gfx] [PATCH 0/6] Pipe level color management

2016-01-22 Thread Daniel Stone
evious set of patches by Shashank Sharma and takes > into account of the comments by Daniel Stone & Daniel Vetter. This is a lot more tractable than previous series, thanks! I think a lot of the confusion I had around this was from the number of hardware-specific features stuffed into t

[Intel-gfx] [PATCH 0/6] Pipe level color management

2016-01-22 Thread Daniel Stone
Hi, On 22 January 2016 at 16:21, Daniel Vetter wrote: > On Fri, Jan 22, 2016 at 04:06:15PM +, Lionel Landwerlin wrote: >> On 22/01/16 15:04, Daniel Stone wrote: >> >Now with everything just using split-gamma mode, I'm much happier with >> >how this is looking.

[Intel-gfx] [PATCH 0/6] Pipe level color management

2016-01-26 Thread Daniel Stone
Hi, On 22 January 2016 at 15:04, Daniel Stone wrote: > On 21 January 2016 at 15:03, Lionel Landwerlin > wrote: >> Hi, >> >> This serie introduces pipe level color management through a set of properties >> attached to the CRTC. It also provides an implementati

Re: [PATCH libdrm] Synchronize drm/drm_fourcc.h with Linux’ version

2016-01-27 Thread Daniel Stone
Hey, On 27 January 2016 at 09:38, Daniel Vetter wrote: > On Tue, Jan 26, 2016 at 09:04:18PM +, Emil Velikov wrote: >> On 11 January 2016 at 19:32, Emmanuel Gil Peyrot >> wrote: >> > This adds R8, RG88 and GR88, as well as the non-subsampled NV24/NV42 >> > formats. >> > >> Err... please

[PATCH 3/3] vc4: Add headers and .pc files for VC4 userspace development.

2016-01-27 Thread Daniel Stone
Hi, On 26 January 2016 at 20:10, Eric Anholt wrote: > Ilia Mirkin writes: >> On Mon, Jan 25, 2016 at 2:27 PM, Eric Anholt wrote: >>> The headers were originally written in Mesa, imported to the kernel, >>> and improved upon in vc4-gpu-tools. These come from the v-g-t copies >>> and will

Re: [PATCH libdrm] Synchronize drm/drm_fourcc.h with Linux’ version

2016-01-27 Thread Daniel Stone
Hi, On 27 January 2016 at 13:28, Emil Velikov wrote: > On 27 January 2016 at 11:42, Daniel Stone wrote: >> On 27 January 2016 at 09:38, Daniel Vetter wrote: >>> On Tue, Jan 26, 2016 at 09:04:18PM +, Emil Velikov wrote: >>>> I've been procrastinating^Wwa

[PATCH 3/3] vc4: Add headers and .pc files for VC4 userspace development.

2016-01-27 Thread Daniel Stone
Hi, On 27 January 2016 at 14:16, Emil Velikov wrote: > On 27 January 2016 at 11:45, Daniel Stone wrote: >> The Requires will take care of that, so you can just bin the entire >> 'Libs:' field until you need one: >> > In theory this will be sufficient, but Eric wasn't bu

Re: [PATCH libdrm] Synchronize drm/drm_fourcc.h with Linux’ version

2016-01-27 Thread Daniel Stone
Hey, On 27 January 2016 at 14:23, Emil Velikov wrote: > On 27 January 2016 at 13:31, Daniel Stone wrote: >> On 27 January 2016 at 13:28, Emil Velikov >> wrote: >>> On 27 January 2016 at 11:42, Daniel Stone wrote: >>>> On 27 January 2016 at 09:38, Daniel

[RFC 0/2] New feature: Framebuffer processors

2016-08-23 Thread Daniel Stone
Hi, On 22 August 2016 at 16:23, Rob Clark wrote: > I guess a lot comes down to 'how long before hw designers bolt a CP to > the thing'.. at that point, I think you especially don't want a > per-blit kernel interface. Regardless of whether or not we want it, we already _have_ it, in the form of

linux-next: problems fetching the drm-intel, etc trees

2016-12-01 Thread Daniel Stone
Hi guys, On Nov 30 2016, at 10:49 pm, Rob Clark wrote: > yeah, {cgit,anongit}.fd.o have been having problems all day.. (the ssh git urls for folks who have push access work fine).. although it has worked for me a couple times today, given enough time. > > (not sure if we have

linux-next: problems fetching the drm-intel, etc trees

2016-12-01 Thread Daniel Stone
Hi Stephen, On 1 December 2016 at 20:45, Stephen Rothwell wrote: > On Thu, 01 Dec 2016 11:02:26 +0000 Daniel Stone > wrote: >> Sorry about this, it is quite bad. I think having mirrors for the key DRM >> trees on GitHub is a good idea though, and I can get to setting that u

[RFC] Using DC in amdgpu for upcoming GPU

2016-12-13 Thread Daniel Stone
Hi Harry, I've been loathe to jump in here, not least because both cop roles seem to be taken, but ... On 13 December 2016 at 01:49, Harry Wentland wrote: > On 2016-12-11 09:57 PM, Dave Airlie wrote: >> On 8 December 2016 at 12:02, Harry Wentland >> wrote: >> Sharing code is a laudable goal

[PATCH] drm: Use atomic state for FB in legacy ioctls

2016-12-13 Thread Daniel Stone
If atomic state is available, use this to read the current plane in GetCrtc/GetPlane, rather than the legacy points. Signed-off-by: Daniel Stone Cc: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c | 5 - drivers/gpu/drm/drm_plane.c | 8 ++-- 2 files changed, 10 insertions(+), 3 deletions

[PATCH] drm: Use atomic state for FB in legacy ioctls

2016-12-13 Thread Daniel Stone
Hi, > On 13 Dec 2016, at 6:48 pm, Ville Syrjälä linux.intel.com> wrote: > >> On Tue, Dec 13, 2016 at 06:19:12PM +0000, Daniel Stone wrote: >> @@ -357,7 +357,10 @@ int drm_mode_getcrtc(struct drm_device *dev, >> >>drm_modeset_lock_crtc(crtc, crtc->p

[Intel-gfx] [PATCH 04/13] drm: Drop locking cargo-cult from drm_mode_config_init

2016-12-14 Thread Daniel Stone
On 13 December 2016 at 23:08, Daniel Vetter wrote: > This is single-threaded setup code, no need for locks. And anyway, > all properties need to be set up before the driver is registered > anyway, they can't be hot-added. > > Signed-off-by: Daniel Vetter Reviewed-by: Daniel Stone

[PATCH 1/2] drm: exynos: Perform initialization/cleanup at probe/remove time

2016-12-16 Thread Daniel Stone
o the drm->dev_private assignment. I thought about cleaning this up, but my XU3's eMMC is dead, so testing on Exynos for me has a 5+ minute RTT through LAVA ... so this is: Reviewed-by: Daniel Stone Cheers, Daniel

[PATCH] drm/rockchip: support prime fd import

2016-02-24 Thread Daniel Stone
Hi, On 24 February 2016 at 16:01, Emil Velikov wrote: > On 23 February 2016 at 23:56, Rob Clark wrote: >> On Tue, Feb 23, 2016 at 6:29 PM, Emil Velikov >> wrote: >>> On 2 February 2016 at 23:37, Zach Reizner wrote: The prime fd to handle ioctl was not used with rockchip before. Support

Re: 答复: [RESEND 1/3] drm: fsl-dcu: Fix no fb check bug

2016-01-01 Thread Daniel Stone
Hi, On 30 December 2015 at 07:37, Meng Yi wrote: > I have tested your patch, It seems good to me. > But I think state->fb check is still necessary, because fb is related to crtc > , and panel is related to connector,. When fsl,panel is not valid, it > indicate that connector is not available,

[PATCH] drm/exynos: fix kernel panic issue at drm releasing

2016-01-04 Thread Daniel Stone
Hi Inki, On 4 January 2016 at 12:57, Inki Dae wrote: > 2015년 12월 24일 22:32에 Daniel Stone 이(가) 쓴 글: >> On 24 December 2015 at 09:10, Inki Dae wrote: >>> +void exynos_drm_crtc_cancel_page_flip(struct drm_crtc *crtc) >>> +{ >>> +

[Intel-gfx] [PATCH] drm: Clean up pending events in the core

2016-01-11 Thread Daniel Stone
assert_spin_locked(>event_lock); >> >> + if (!e->file_priv) { > > I don't think this could happen before this patch as e->file_priv is > dereferenced below, and I don't see anything in this patch that makes the > condition possible. > >> + e->destroy(e); >> + return; >> + } ... and now here. This looks good to me, and a good sight better than doing it in every driver. Still drowning in stuff after three weeks off though, so the best I can offer for the series right now is: Acked-by: Daniel Stone Cheers, Daniel

[PATCH v3] drm/exynos: fix kernel panic issue at drm releasing

2016-01-11 Thread Daniel Stone
Hi Inki, On 8 January 2016 at 08:46, Inki Dae wrote: > Changelog v3: > - initialize only device specific things. Each page flip event object > is created by DRM core so DRM core should release the object including > incrementing event space. I'm a bit confused here; we no longer call

[PATCH v3] drm/exynos: fix kernel panic issue at drm releasing

2016-01-12 Thread Daniel Stone
Hi Inki, On 12 January 2016 at 06:25, Inki Dae wrote: > 2016년 01월 12일 04:00에 Daniel Stone 이(가) 쓴 글: >> On 8 January 2016 at 08:46, Inki Dae wrote: >>> Changelog v3: >>> - initialize only device specific things. Each page flip event object >>>

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Daniel Stone
Hi Inki, On 31 March 2016 at 08:45, Inki Dae wrote: > 2016년 03월 29일 22:23에 Rob Clark 이(가) 쓴 글: >> On Mon, Mar 28, 2016 at 10:18 PM, Inki Dae wrote: >>> In addition, I wonder how explicit and implicit fences could coexist >>> together. >>> Rob said, >>> "Implicit sync ofc

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Daniel Stone
Hi Inki, On 31 March 2016 at 11:05, Inki Dae wrote: > 2016년 03월 31일 18:35에 Daniel Stone 이(가) 쓴 글: >> On 31 March 2016 at 08:45, Inki Dae wrote: >>> As of now, it seems that this wouldn't be optional but mandatory if >>> explicit fence support is

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-31 Thread Daniel Stone
Hi Inki, On 31 March 2016 at 12:26, Inki Dae wrote: > 2016-03-31 19:56 GMT+09:00 Daniel Stone : >> On 31 March 2016 at 11:05, Inki Dae wrote: >>> Then, existing drivers would need additional works for explicit fencing >>> support. This wouldn't be really what the

[Intel-gfx] [PATCH 5/6] drm/atomic: use connector references (v2)

2016-05-03 Thread Daniel Stone
wrong, for patches 1-5: Reviewed-by: Daniel Stone Cheers, Daniel

[Intel-gfx] [PATCH] drm/atomic: use connector references (v3)

2016-05-03 Thread Daniel Stone
t's share the embarrassment. What could possibly go wrong? Reviewed-by: Daniel Stone Cheers, Daniel

[PATCH] drm/exynos: fix cancel page flip code

2016-05-04 Thread Daniel Stone
Hi Andrzej, On 24 March 2016 at 10:52, Andrzej Hajda wrote: > @@ -229,24 +229,12 @@ void exynos_drm_crtc_cancel_page_flip(struct drm_crtc > *crtc, > struct drm_file *file) > { > struct exynos_drm_crtc *exynos_crtc = to_exynos_crtc(crtc); > -

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v3

2016-05-24 Thread Daniel Stone
Hi Tomeu, On 5 April 2016 at 16:07, Tomeu Vizoso wrote: > On 4 April 2016 at 17:44, Daniel Stone wrote: >> On 4 April 2016 at 14:55, Tomeu Vizoso wrote: >>> + if (async) { >>> + for_each_crtc_in_state(state, crtc, crtc_state, i) { >>> +

[PATCH] drm/rockchip: Return -EBUSY if there's already a pending flip event v5

2016-05-24 Thread Daniel Stone
urns outdated information. > > v4: Hold dev->event_lock while checking the VOP's event field as > suggested by Daniel Stone. > > v5: Only block if there's outstanding work if it's a blocking call. > > Signed-off-by: Tomeu Vizoso Reviewed-by: Daniel Stone Cheers, Daniel

[PATCH v2] drm: exynos: Perform initialization/cleanup at probe/remove time

2016-12-19 Thread Daniel Stone
it in the probe function and call drm_dev_alloc() and > drm_dev_register() explicitly. > > For consistency inline the .unload() handler in the remove function as > well. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Sean Paul > Reviewed-by: Daniel Vetter > Reviewed-

drm: imx: callback after probe deferral not working

2016-02-09 Thread Daniel Stone
Hi Akshay, On 1 February 2016 at 19:02, Akshay Bhat wrote: > On 02/01/2016 07:11 AM, Liviu Dudau wrote: >> On Fri, Jan 29, 2016 at 05:12:28PM -0500, Akshay Bhat wrote: >>> On 01/28/2016 05:29 PM, Rob Clark wrote: >>> Also from the original log you can see that there are a lot of modules >>> that

drm: imx: callback after probe deferral not working

2016-02-09 Thread Daniel Stone
Hi Akshay, On 9 February 2016 at 22:25, Akshay Bhat wrote: > On 02/09/2016 04:28 PM, Daniel Stone wrote: >> On 1 February 2016 at 19:02, Akshay Bhat wrote: >>> On 02/01/2016 07:11 AM, Liviu Dudau wrote: >>>> On Fri, Jan 29, 2016 at 05:12:28PM -0500, Akshay Bhat wr

[PATCH 00/29] Enabling new DAL display driver for amdgpu on Carrizo and Tonga

2016-02-14 Thread Daniel Stone
Hi Harry, On 13 February 2016 at 00:05, Wentland, Harry wrote: > The goal with DAL is to provide a unified, full featured display stack to > service all of our Linux offerings. This driver will have to support our full > feature set beyond what's supported by amdgpu, e.g. > - synchronzied

[PATCH] component: remove device from master match list on failed add

2016-02-15 Thread Daniel Stone
Russell, On 12 February 2016 at 00:57, Akshay Bhat wrote: > Daniel Stone collabora.com> writes: >> Fixes: ffc30b74fd6d01588bd3fdebc3b1acc0857e6fc8 >> Signed-off-by: Daniel Stone collabora.com> > > Tested-by: Akshay Bhat > > Tested on imx6 processor based boar

[PATCH 0/2] drm/vc4: Fixes for Raspberry Pi 3

2016-03-01 Thread Daniel Stone
ard-hangs - no serial console - after cat /sys/class/drm/card0-HDMI-A-1/edid. On the grounds that the VC4 node isn't yet in upstream DT though, and this _does_ indeed fix HPD: Tested-by: Daniel Stone Cheers, Daniel

[Intel-gfx] [PATCH 0/5] Pipe level color management V10

2016-03-08 Thread Daniel Stone
>> Intel >> platforms. >> > This series is based of a previous set of patches by Shashank Sharma. > > Acked-by: Rob Bradford And for the non-Intel-specific parts (e.g. I haven't checked the exact maths for conversion to/from BDW fixed-point, or CHV at all): Reviewed-by: Daniel Stone Thanks, Daniel

[Intel-gfx] [PATCH] drm: fix blob pointer check

2016-03-10 Thread Daniel Stone
On 10 March 2016 at 12:04, Lionel Landwerlin wrote: > Check properly that the allocated blob's pointer is valid. > > Signed-off-by: Lionel Landwerlin > Reported-by: Dan Carpenter > Cc: Daniel Stone Reviewed-by: Daniel Stone

[PATCH 2/2] drm/virtio: send vblank event on plane atomic update

2016-03-22 Thread Daniel Stone
Hi, On 21 March 2016 at 19:23, Gustavo Padovan wrote: > @@ -96,6 +98,11 @@ static void virtio_gpu_plane_atomic_update(struct > drm_plane *plane, > plane->state->crtc_y, > plane->state->crtc_w, >

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-25 Thread Daniel Stone
Hi all, On 25 March 2016 at 11:58, Rob Clark wrote: > On Thu, Mar 24, 2016 at 7:49 PM, Inki Dae wrote: >> It's definitely different case. This tries to add new user-space interfaces >> to expose fences to user-space. At least, implicit interfaces are embedded >> into drivers. >> So I'd like

[RFC 0/6] drm/fences: add in-fences to DRM

2016-03-28 Thread Daniel Stone
Hi Inki, On 28 March 2016 at 02:26, Inki Dae wrote: > 2016년 03월 25일 21:10에 Daniel Stone 이(가) 쓴 글: >> Second, really. Vulkan avoids implicit sync entirely, and exposes >> fence-like primitives throughout its whole API. These include being >> able to pas

[PATCH 10/13] drm/vgem: Simplify dum_map

2016-03-30 Thread Daniel Stone
On 30 March 2016 at 11:29, Emil Velikov wrote: > On 30 March 2016 at 10:40, Daniel Vetter wrote: >> The offset manager already checks for existing offsets internally, >> while holding suitable locks. We can drop this check. >> >> Signed-off-by: Daniel Vetter > With s/dum_map/dump_map/ in the

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-12 Thread Daniel Stone
Hi, On 12 January 2017 at 18:11, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Thu, Jan 12, 2017 at 05:50:15PM +0000, Daniel Stone wrote: >> struct drm_plane { >> struct { >> uint32_t format; >> uint64_t modifiers[]; >>

Re: [Intel-gfx] [PATCH 1/3] drm: Add new DRM_IOCTL_MODE_GETPLANE2

2017-01-13 Thread Daniel Stone
Hey, On 13 January 2017 at 09:37, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Thu, Jan 12, 2017 at 07:27:03PM +0000, Daniel Stone wrote: >> It would make sense, but then gbm_surface_create_with_modifiers takes >> a fixed pixel format and a list of acceptable m

Re: [bug report] drm: Use atomic state for FB in legacy ioctls

2017-01-13 Thread Daniel Stone
Hi Dan, On 13 January 2017 at 12:56, Dan Carpenter wrote: > drivers/gpu/drm/drm_crtc.c:392 drm_mode_getcrtc() > error: we previously assumed 'crtc->primary->state' could be null > (see line 384) > > drivers/gpu/drm/drm_crtc.c >383 >384 if

[PATCH] intel: make bufmgr_gem shareable from different API

2014-09-11 Thread Daniel Stone
Hi, On 11 September 2014 12:52, Chris Wilson wrote: > On Thu, Sep 11, 2014 at 12:33:41PM +0100, Lionel Landwerlin wrote: > > When using Mesa and LibVA in the same process, one would like to be > > able bind buffers from the output of the decoder to a GL texture > > through an EGLImage. > > > >

[PATCH 1/1] drm/exynos: Fix FIMD buffer size calculation

2015-04-08 Thread Daniel Stone
ze calculation again. Tested on Chromebook Snow / Peach Pit. Fixes: 26b9c2813ede1 ("drm/exynos: remove struct *_win_data abstraction on planes") Signed-off-by: Daniel Stone Tested-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 4 ++-- 1 file changed, 2 inser

Valve games for Mesa/DRI developers

2015-04-09 Thread Daniel Stone
Hi, At Collabora (my lovely dayjob), we've been working with Valve on SteamOS. Valve are keen to give back to the community, and we've been discussing ways they can help do that, including providing free access to Valve games on Steam to Debian developers last year. We're happy to say that this

Valve games for Mesa/DRI developers

2015-04-13 Thread Daniel Stone
Valve saying so. I agree it would be nice though! Cheers, Daniel > Thierry > > On Thu, Apr 09, 2015 at 06:10:42PM +0100, Daniel Stone wrote: >> Hi, >> At Collabora (my lovely dayjob), we've been working with Valve on >> SteamOS. Valve are keen to give back to the

[PATCH] drm/exynos: fimd: fix buffer size calculation

2015-04-13 Thread Daniel Stone
n display buffer. Yes, you're right; sorry about this. It slipped in during a rebase and I definitely should've caught it. This has already been fixed for -next in the commit Inki pointed out, but in the meantime it should definitely be applied to stable as a more minimal fix. Thanks for catching this

[PATCH 0/7] User-created blob properties

2015-04-20 Thread Daniel Stone
Hi, This is the spritual successor to the modes-as-blob-properties patchset. There are some fairly drastic differences though, namely: - the referenced object in this case is the blob property - being just a dumb chunk of data - rather than attempting to refcount modes; meaning that ...

[PATCH 1/7] drm/atomic: Don't open-code CRTC state destroy

2015-04-20 Thread Daniel Stone
One failure path in crtc_helper had an open-coded CRTC state destroy which didn't actually call through to the driver's specified state destroy. Fix that. Signed-off-by: Daniel Stone --- drivers/gpu/drm/drm_crtc_helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 2/7] drm/atomic: Early-exit from CRTC dup state

2015-04-20 Thread Daniel Stone
Just change an if (success) branch to if (fail) return; Signed-off-by: Daniel Stone --- drivers/gpu/drm/drm_atomic_helper.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index d536817

[PATCH 3/7] drm: Don't leak path blob property when updating

2015-04-20 Thread Daniel Stone
Previously, when updating the path blob property, we would leak the existing one. Make this symmetrical with the tile and EDID blob pointers. Signed-off-by: Daniel Stone Cc: Dave Airlie --- drivers/gpu/drm/drm_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm

[PATCH 4/7] drm: Introduce helper for replacing blob properties

2015-04-20 Thread Daniel Stone
Introduce a common helper for the pattern of: - allocate new blob property - potentially free old blob property - replace content of indicative property with new blob ID - change member pointer on modeset object Signed-off-by: Daniel Stone Cc: Dave Airlie --- drivers/gpu/drm/drm_crtc.c

[PATCH 5/7] drm: Introduce blob_lock

2015-04-20 Thread Daniel Stone
Create a new global blob_lock mutex, which protects the blob property list from insertion and/or deletion. Signed-off-by: Daniel Stone --- drivers/gpu/drm/drm_crtc.c | 18 +++--- include/drm/drm_crtc.h | 3 +++ 2 files changed, 18 insertions(+), 3 deletions(-) diff --git

[PATCH 6/7] drm: Add reference counting to blob properties

2015-04-20 Thread Daniel Stone
Reference-count drm_property_blob objects, changing the API to ref/unref. Signed-off-by: Daniel Stone --- drivers/gpu/drm/drm_crtc.c | 164 + include/drm/drm_crtc.h | 17 ++--- 2 files changed, 159 insertions(+), 22 deletions(-) diff --git

[PATCH 7/7] drm/mode: Add user blob-creation ioctl

2015-04-20 Thread Daniel Stone
Add an ioctl which allows users to create blob properties from supplied data. Currently this only supports modes, creating a drm_display_mode from the userspace drm_mode_modeinfo. Signed-off-by: Daniel Stone --- drivers/gpu/drm/drm_crtc.c | 160

[PATCH 0/2] User-created blob properties

2015-04-20 Thread Daniel Stone
This is the userspace counterpart to: http://lists.freedesktop.org/archives/dri-devel/2015-April/081488.html Cheers, Daniel

[PATCH 1/2] Resync header files with kernel

2015-04-20 Thread Daniel Stone
Pull new drm.h and drm_mode.h definitions for client caps and atomic ioctl. Signed-off-by: Daniel Stone --- include/drm/drm.h | 23 ++- include/drm/drm_mode.h | 43 --- 2 files changed, 62 insertions(+), 4 deletions(-) diff --git

[PATCH 2/2] ioctl: Add new blob-property-creation ioctl

2015-04-20 Thread Daniel Stone
Signed-off-by: Daniel Stone --- include/drm/drm.h | 2 ++ include/drm/drm_mode.h | 24 +++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/include/drm/drm.h b/include/drm/drm.h index 44ef685..66028a6 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h

  1   2   3   4   5   >