[PATCH 01/11] drm: don't export drm_sg_alloc

2010-04-29 Thread Daniel Vetter
It's not used internally by any driver, only by some generic ioctls. So don't export it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_scatter.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm

[PATCH 05/11] drm: kill drm_map_ofs callbacks

2010-04-29 Thread Daniel Vetter
All drivers happily copypasted the default implementation without checking whether this callback is used at all. It's not. Sigh. Kill it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_vm.c |7 --- drivers/gpu/drm/i810/i810_drv.c |1

[PATCH 04/11] drm: kill procfs callbacks

2010-04-29 Thread Daniel Vetter
Not used by any driver (rightly so!). Kill them. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_proc.c | 13 - include/drm/drmP.h |2 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu

[PATCH 06/11] drm: kill get_reg_ofs callback

2010-04-29 Thread Daniel Vetter
Every driver used the default implementation. Fold that one into the only callsite and drop the callback. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_vm.c |6 ++ drivers/gpu/drm/i810/i810_drv.c |1 - drivers/gpu/drm/i830/i830_drv.c

[PATCH 03/11] drm: kill dma_ready callbacks

2010-04-29 Thread Daniel Vetter
Not used by any driver. So drop it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_lock.c |3 --- include/drm/drmP.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index

[PATCH 10/11] drm: kill dev-timer

2010-04-29 Thread Daniel Vetter
Totally unused. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_drv.c |2 -- drivers/gpu/drm/drm_stub.c |1 - include/drm/drmP.h |1 - 3 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm

[PATCH 08/11] drm: don't export drm_get_drawable_info

2010-04-29 Thread Daniel Vetter
Not used by any in-tree user. So drop it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_drawable.c |3 +-- include/drm/drmP.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drawable.c b/drivers/gpu/drm

[PATCH 11/11] drm: kill gem_free_object_unlocked driver callback

2010-04-29 Thread Daniel Vetter
Not used by any current driver. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_gem.c |4 +--- include/drm/drmP.h|1 - 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index 33dad3f

[PATCH 09/11] drm: replace drawable ioctl by noops

2010-04-29 Thread Daniel Vetter
' miniglx, does not use the RM_DRAW ioctl. Therefore it's safe to replace these three ioctls with noops and rip out the implementation. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/Makefile |2 +- drivers/gpu/drm/drm_drawable.c | 197

Re: [PATCH 09/11] drm: replace drawable ioctl by noops

2010-04-29 Thread Daniel Vetter
On Thu, Apr 29, 2010 at 11:32:36AM +0200, Michel Dänzer wrote: On Don, 2010-04-29 at 11:14 +0200, Daniel Vetter wrote: The information supplied by userspace through these ioctls is only accessible by dev-drw_idr. But there's no in-tree user of that. Information might also leak via

[PATCH 1/9] list.h: add list_for_each_entry_safe_from_reverse

2010-05-18 Thread Daniel Vetter
i915 needs this. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- include/linux/list.h | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/include/linux/list.h b/include/linux/list.h index 8392884..21cdd99 100644 --- a/include/linux/list.h +++ b/include

[PATCH 2/9] drm: use list_for_each_entry in drm_mm.c

2010-05-18 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 2ac074c..b75eb55 100644 --- a/drivers/gpu/drm/drm_mm.c +++ b/drivers/gpu/drm

[PATCH 3/9] drm: kill drm_mm_node-private

2010-05-18 Thread Daniel Vetter
Only ever assigned, never used. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_gem.c |4 +--- drivers/gpu/drm/ttm/ttm_bo.c |6 -- drivers/gpu/drm/ttm/ttm_bo_util.c |2 -- include/drm/drm_mm.h |1 - 4 files changed, 1

[PATCH 4/9] drm: kill dead code in drm_mm.c

2010-05-18 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 45 - 1 files changed, 0 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index b75eb55..a5a7a16 100644 --- a/drivers

[PATCH 5/9] drm: sane naming for drm_mm.c

2010-05-18 Thread Daniel Vetter
Yeah, I've kinda noticed that fl_entry is the free stack. Still give it (and the memory node list ml_entry) decent names. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 72 ++--- include/drm/drm_mm.h | 11

[PATCH 8/9] drm/i915: prepare for fair lru eviction

2010-05-18 Thread Daniel Vetter
object, so move the unbind call into the helper function that scans for the object to be evicted, too. And adjust its name. No functional changes in this patch, just preparation. Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_gem.c | 65

[PATCH 7/9] drm: implement helper functions for scanning lru list

2010-05-18 Thread Daniel Vetter
approach by i915 (scan the lru for a object large enough to contain the new object). It's also more efficient than the current approach used by ttm (uncoditionally evict objects from the lru until there's enough free space). Signed-Off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm

Re: [PATCH 0/9] [RFC] fair-lru eviction

2010-05-19 Thread Daniel Vetter
On Wed, May 19, 2010 at 09:06:52AM +0100, Chris Wilson wrote: On Tue, 18 May 2010 23:11:42 +0200, Daniel Vetter daniel.vet...@ffwll.ch wrote: Hi all, This patch series implements the fair-lru eviction Chris Wilson already posted with a twist. It's essentially the same idea algorithm

Re: [PATCH 3/9] drm: kill drm_mm_node-private

2010-05-19 Thread Daniel Vetter
On Wed, May 19, 2010 at 11:25:07AM +0200, Jerome Glisse wrote: On Tue, May 18, 2010 at 11:11:45PM +0200, Daniel Vetter wrote: Only ever assigned, never used. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch NAK private was to be use when doing range restricted allocation somehow

[PATCH 01/14] drm: don't export drm_sg_alloc

2010-08-23 Thread Daniel Vetter
It's not used internally by any driver, only by some generic ioctls. So don't export it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_scatter.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_scatter.c b/drivers/gpu/drm

[PATCH 14/14] drm: kill agp indirection mess

2010-08-23 Thread Daniel Vetter
There's no point in jumping through two indirections. So kill one and call the kernels agp functions directly. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_agpsupport.c | 40 +++-- drivers/gpu/drm/drm_memory.c | 12

[PATCH 04/14] drm: kill procfs callbacks

2010-08-23 Thread Daniel Vetter
Not used by any driver (rightly so!). Kill them. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_proc.c | 13 - include/drm/drmP.h |2 -- 2 files changed, 0 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/drm_proc.c b/drivers/gpu

[PATCH 00/14] various drm core cleanups

2010-08-23 Thread Daniel Vetter
Daniel Vetter (14): drm: don't export drm_sg_alloc drm: kill kernel_context_switch callbacks drm: kill dma_ready callbacks drm: kill procfs callbacks drm: kill drm_map_ofs callbacks drm: kill get_reg_ofs callback drm: kill context_ctor callback drm: don't export

[PATCH 03/14] drm: kill dma_ready callbacks

2010-08-23 Thread Daniel Vetter
Not used by any driver. So drop it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_lock.c |3 --- include/drm/drmP.h |1 - 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm/drm_lock.c index

[PATCH 07/14] drm: kill context_ctor callback

2010-08-23 Thread Daniel Vetter
-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_context.c |8 drivers/gpu/drm/sis/sis_drv.c |1 - include/drm/drmP.h|1 - 3 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/drm_context.c b/drivers/gpu/drm/drm_context.c

[PATCH 08/14] drm: don't export drm_get_drawable_info

2010-08-23 Thread Daniel Vetter
Not used by any in-tree user. So drop it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_drawable.c |3 +-- include/drm/drmP.h |2 -- 2 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_drawable.c b/drivers/gpu/drm

[PATCH 13/14] drm: drop return value of drm_free_agp

2010-08-23 Thread Daniel Vetter
No caller (rightly) cares about it, so drop it. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_memory.c |4 ++-- include/drm/drmP.h |2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm

[PATCH 06/14] drm: kill get_reg_ofs callback

2010-08-23 Thread Daniel Vetter
Every driver used the default implementation. Fold that one into the only callsite and drop the callback. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_vm.c |6 ++ drivers/gpu/drm/i810/i810_drv.c |1 - drivers/gpu/drm/i830/i830_drv.c

[PATCH 12/14] drm: don't export dri1 locking functions

2010-08-23 Thread Daniel Vetter
Only used by ioctl, not by any in-tree drivers. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_lock.c | 10 +++--- include/drm/drmP.h |1 - 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_lock.c b/drivers/gpu/drm

[PATCH 09/14] drm: replace drawable ioctl by noops

2010-08-23 Thread Daniel Vetter
and keeps on trying to create a kernel drawable every time somebody creates a dri drawable. But since that's now a noop, who cares. Therefore it's safe to replace these three ioctls with noops and rip out the implementation. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Reviewed-by: Kristian

Re: [PATCH 14/14] drm: kill agp indirection mess

2010-08-24 Thread Daniel Vetter
, if people want this I can certainly prep patches. There's already #define DRM_AGP_MEM struct agp_memory #define DRM_AGP_KERNstruct agp_kern_info so the whole thing can be accomplished without a flag day. Kristian Cheers, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch

[PATCH] drm: mm: fix range restricted allocations

2010-08-26 Thread Daniel Vetter
With the code cleanup in 7a6b2896f261894dde287d3faefa4b432cddca53 is the first bad commit commit 7a6b2896f261894dde287d3faefa4b432cddca53 Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Fri Jul 2 15:02:15 2010 +0100 drm_mm: extract check_free_mm_node I've botched up the range

[PATCH] drm_mm: add support for range-restricted fair-lru scans

2010-09-24 Thread Daniel Vetter
-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 40 +++- include/drm/drm_mm.h |7 +++ 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index a6bfc30

[PATCH] drm_mm: add support for range-restricted fair-lru scans

2010-09-25 Thread Daniel Vetter
-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 40 +++- include/drm/drm_mm.h |7 +++ 2 files changed, 46 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index a6bfc30

[PATCH] drm: readd drm_lock_free in drm_unlock

2010-09-25 Thread Daniel Vetter
I've accidently killed a little bit too much in commit 1da3f87ebb7edb3e0b829ec4bbe5fb3d9d93986f Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Mon Aug 23 22:53:24 2010 +0200 drm: kill kernel_context_switch callbacks Note to self: Next time also test with AIGLX disabled. Reported

[PATCH] drm/radeon: Add early unregister of firmware fb's

2010-10-06 Thread Daniel Vetter
...@kernel.org Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org [danvet: add cc: stable, forward ported and compile-fixed for X86] Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- This patch is required to get the agp rv270 in my ppc Mac Mini working with kms. Also tested

Re: [PATCH] drm/radeon: Add early unregister of firmware fb's

2010-10-06 Thread Daniel Vetter
On Wed, Oct 06, 2010 at 08:20:15PM +0200, Marcin Slusarz wrote: On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: +static void radeon_kick_out_firmware_fb(struct drm_device *ddev) +{ + struct apertures_struct *ap; + bool primary = false; + + ap = alloc_apertures(1

Re: [PATCH] drm/radeon: Add early unregister of firmware fb's

2010-10-31 Thread Daniel Vetter
Hi Dave, This hasn't shown up in one of your branches, yet. Do you want me to change something or was this patch simply lost somewhere? Thanks, Daniel On Wed, Oct 06, 2010 at 06:39:07PM +0200, Daniel Vetter wrote: From: Benjamin Herrenschmidt b...@kernel.crashing.org Without this, we

[PATCH 3/9] drm: mm: extract node insert helper functions

2010-11-12 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 67 - 1 files changed, 42 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 4fa33e1..fecb406 100644 --- a/drivers

[PATCH 2/9] drm: mm: track free areas implicitly

2010-11-12 Thread Daniel Vetter
(which will be much more useful when struct drm_mm_node is embeddable). Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 464 +- include/drm/drm_mm.h | 21 ++- 2 files changed, 225 insertions(+), 260 deletions

[PATCH 4/9] drm: mm: add api for embedding struct drm_mm_node

2010-11-12 Thread Daniel Vetter
of this and add a small helper drm_mm_node_allocated. Also add a function to move allocations between different struct drm_mm_node. v2: Implement suggestions by Chris Wilson. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 93

[PATCH 7/9] drm/i915: kill gtt_list

2010-11-12 Thread Daniel Vetter
Use the list iterator provided by drm_mm instead. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.h |4 drivers/gpu/drm/i915/i915_gem.c |4 drivers/gpu/drm/i915/i915_gem_gtt.c |4 +++- 3 files changed, 3 insertions(+), 9

[PATCH 5/9] drm/i915: embed struct drm_mm_node into struct drm_i915_gem_object

2010-11-12 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_debugfs.c |6 +- drivers/gpu/drm/i915/i915_drv.h |2 +- drivers/gpu/drm/i915/i915_gem.c | 93 ++--- drivers/gpu/drm/i915/i915_gem_evict.c |6 +- drivers/gpu

[PATCH 8/9] drm: mm: add helper to unwind scan state

2010-11-12 Thread Daniel Vetter
With the switch to implicit free space accounting one pointer got unused when scanning. Use it to create a single-linked list to ensure correct unwinding of the scan state. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c |4 include/drm/drm_mm.h

[PATCH 9/9] drm/i915: use drm_mm_for_each_scanned_node_reverse helper

2010-11-12 Thread Daniel Vetter
Doesn't really buy much, but looks nicer. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/i915/i915_gem_evict.c | 31 --- 1 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_evict.c b/drivers/gpu

[PATCH 1/3] drm/radeon: embed struct drm_gem_object

2010-11-13 Thread Daniel Vetter
Unconditionally initialize the drm gem object - it's not worth the trouble not to for the few kernel objects. This patch only changes the place of the drm gem object, access is still done via pointers. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon

[PATCH 0/3] embed drm_gem_object into radeon_bo

2010-11-13 Thread Daniel Vetter
interface (I know, there's some overlap there, but that's not really a new problem). Please review and consider merging for -next. Yours, Daniel Daniel Vetter (3): drm/radeon: embed struct drm_gem_object drm/radeon: introduce gem_to_radeon_bo helper drm/radeon: kill radeon_bo-gobj pointer

[PATCH 3/3] drm/radeon: kill radeon_bo-gobj pointer

2010-11-13 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h|1 - drivers/gpu/drm/radeon/radeon_object.c |9 +++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index

[PATCH 2/3] drm/radeon: introduce gem_to_radeon_bo helper

2010-11-13 Thread Daniel Vetter
... and switch it to container_of upcasting. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/atombios_crtc.c |8 drivers/gpu/drm/radeon/radeon.h |1 + drivers/gpu/drm/radeon/radeon_cs.c |2 +- drivers/gpu/drm/radeon

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-14 Thread Daniel Vetter
://cgit.freedesktop.org/~danvet/drm/log/?h=embed-gtt-space -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-14 Thread Daniel Vetter
series is supposed to be bisectable, so stopping anywhere in between should result in a working kernel. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-14 Thread Daniel Vetter
d935cc61d466f6cc7514032835f4fc379cb7e2ca Author: Daniel Vetter daniel.vet...@ffwll.ch Date: Thu Sep 16 15:13:11 2010 +0200 drm_mm: add support for range-restricted fair-lru scans That one's necessary, too. Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-14 Thread Daniel Vetter
and apply 0008-drm_mm-add-support-for-range-restricted-fair-lru-sca.patch first. I've pushed out a for-sedat-dilek branch to my fdo repo. That one compiles ... Patches simply cherry-picked with git. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

Re: [PATCH 0/3] embed drm_gem_object into radeon_bo

2010-11-15 Thread Daniel Vetter
), I'll intend to simply plow along, hunting for common patterns. Thanks, /Thomas Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-15 Thread Daniel Vetter
to alignment). Thanks a lot for your input on this. Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/9] make struct drm_mm_node embeddable

2010-11-15 Thread Daniel Vetter
over the mark here ;-) As I've said, I don't have any immediate plans to create havoc in ttm. And if I start doing so, I'll do it in (hopefully) incrementally useful steps. Thanks, Thomas Thanks, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48

Re: [PATCH 0/3] embed drm_gem_object into radeon_bo

2010-11-16 Thread Daniel Vetter
with the below listed drm patches. Likely a gem_bo-driver_private access. My patches set this to NULL to catch conversion bugs. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel

[PATCH 0/3] embed drm_gem_object into radeon_bo

2010-11-27 Thread Daniel Vetter
Hi Dave, As promised rebased on top of latest drm-next to resolve a conflict the pageflipping code. Tested on my agp rv570. Please review and consider merging for -next. Thanks, Daniel Daniel Vetter (3): drm/radeon: embed struct drm_gem_object drm/radeon: introduce gem_to_radeon_bo helper

[PATCH 1/3] drm/radeon: embed struct drm_gem_object

2010-11-27 Thread Daniel Vetter
Unconditionally initialize the drm gem object - it's not worth the trouble not to for the few kernel objects. This patch only changes the place of the drm gem object, access is still done via pointers. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon

[PATCH 2/3] drm/radeon: introduce gem_to_radeon_bo helper

2010-11-27 Thread Daniel Vetter
... and switch it to container_of upcasting. v2: converted new pageflip code-paths. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/atombios_crtc.c |8 drivers/gpu/drm/radeon/radeon.h |1 + drivers/gpu/drm/radeon/radeon_cs.c

[PATCH 3/3] drm/radeon: kill radeon_bo-gobj pointer

2010-11-27 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h|1 - drivers/gpu/drm/radeon/radeon_object.c |9 +++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon/radeon.h index

Re: [PATCH] drm: Replace kref with a simple atomic reference count

2010-11-28 Thread Daniel Vetter
dropping the ref to the underlying bo (and taking any necessary locks to do so). I don't see any races nor locking problems, there. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel

Re: [PATCH] drm: Replace kref with a simple atomic reference count

2010-11-28 Thread Daniel Vetter
a very bad idea hiding brittle locking semantics at best, bugs at worst. Cheers, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

[PATCH 0/7] radeon_asic header cleanup, part 2

2010-11-28 Thread Daniel Vetter
highly welcome. Please review and consider merging for -next - I'm hoping this is a convenient for cleanups like this after most in-flight stuff has landed in -next. Cheers, Daniel Daniel Vetter (7): radeon: consolidate asic-specific function decls for pre-r600 radeon: consolidate asic

[PATCH 1/7] radeon: consolidate asic-specific function decls for pre-r600

2010-11-28 Thread Daniel Vetter
Move them to radeon_asic.h together with the other asic specific stuff. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h | 59 -- drivers/gpu/drm/radeon/radeon_asic.h | 53 -- 2 files

[PATCH 2/7] radeon: consolidate asic-specific function decls for r600 later

2010-11-28 Thread Daniel Vetter
Now all the asic specific stuff ist mostly hid in radeon_asic.* Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/r600_audio.c |1 + drivers/gpu/drm/radeon/r600_hdmi.c |1 + drivers/gpu/drm/radeon/radeon.h | 61

[PATCH 3/7] radeon: drop extern from function decls

2010-11-28 Thread Daniel Vetter
Only adds noise. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h |6 +- drivers/gpu/drm/radeon/radeon_asic.h | 150 +- 2 files changed, 77 insertions(+), 79 deletions(-) diff --git a/drivers/gpu/drm/radeon

[PATCH 4/7] radeon: kill decls for inline functions

2010-11-28 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon_asic.h |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_asic.h b/drivers/gpu/drm/radeon/radeon_asic.h index cf7a8f6..c7cbba3 100644 --- a/drivers/gpu

[PATCH 5/7] radeon: move blit functions to radeon_asic.h

2010-11-28 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h | 13 - drivers/gpu/drm/radeon/radeon_asic.h | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon.h b/drivers/gpu/drm/radeon

[PATCH 6/7] radeon: kill r100_io_(r|w)reg

2010-11-28 Thread Daniel Vetter
Used in a macro with only a single call-site for each. IHMO that's a bit too much indirection. Fold them in. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h| 22 -- drivers/gpu/drm/radeon/radeon_device.c | 16

[PATCH 7/7] radeon: kill rdev-pciep_(r|w)reg

2010-11-28 Thread Daniel Vetter
pciep_wreg is totally unused, rreg has only one caller and already checks whether it's an r600 or later chip. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/r300.c|3 ++- drivers/gpu/drm/radeon/r600.c|8 drivers/gpu/drm/radeon

Re: [PATCH 09/10] MCDE: Add build files and bus

2010-12-05 Thread Daniel Vetter
for a given format and size and returns the buffer, strides and offsets for the different planes. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

[PATCH 00/11] [resend] drm core and radeon patches for -next

2011-02-18 Thread Daniel Vetter
header cleanup that I've started a while back. Reviewed by Alex Deucher, I've dropped the 3 small patches he objected. Tested on my usual array of machines (which now also includes an HD5750 and a HD 4350 and a g73 from nvidia ;). Please review and consider merging for next. Thanks, Daniel Daniel

[PATCH 01/11] drm/nouveau: don't munge in drm_mm internals

2011-02-18 Thread Daniel Vetter
Nouveau was checking drm_mm internals on teardown to see whether the memory manager was initialized. Hide these internals in a small inline helper function. Cc: Ben Skeggs bske...@redhat.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/nouveau/nouveau_object.c |2

[PATCH 02/11] drm: mm: track free areas implicitly

2011-02-18 Thread Daniel Vetter
(which will be much more useful when struct drm_mm_node is embeddable). Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 464 +- include/drm/drm_mm.h | 21 ++- 2 files changed, 225 insertions(+), 260 deletions

[PATCH 03/11] drm: mm: extract node insert helper functions

2011-02-18 Thread Daniel Vetter
Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c | 67 - 1 files changed, 42 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c index 4fa33e1..fecb406 100644 --- a/drivers

[PATCH 04/11] drm: mm: add api for embedding struct drm_mm_node

2011-02-18 Thread Daniel Vetter
embedded, we cannot track allocations anymore by checking for a NULL pointer. So keep track of this and add a small helper drm_mm_node_allocated. Also add a function to move allocations between different struct drm_mm_node. v2: Implement suggestions by Chris Wilson. Signed-off-by: Daniel Vetter

[PATCH 05/11] drm: mm: add helper to unwind scan state

2011-02-18 Thread Daniel Vetter
With the switch to implicit free space accounting one pointer got unused when scanning. Use it to create a single-linked list to ensure correct unwinding of the scan state. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/drm_mm.c |4 include/drm/drm_mm.h

[PATCH 07/11] drm/radeon: introduce gem_to_radeon_bo helper

2011-02-18 Thread Daniel Vetter
... and switch it to container_of upcasting. v2: converted new pageflip code-paths. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/atombios_crtc.c |8 drivers/gpu/drm/radeon/radeon.h |1 + drivers/gpu/drm/radeon/radeon_cs.c

[PATCH 09/11] radeon: consolidate asic-specific function decls for r600 later

2011-02-18 Thread Daniel Vetter
Now all the asic specific stuff ist mostly hid in radeon_asic.* Reviewed-by: Alex Deucher alexdeuc...@gmail.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/r600_audio.c |1 + drivers/gpu/drm/radeon/r600_hdmi.c |1 + drivers/gpu/drm/radeon/radeon.h

[PATCH 11/11] radeon: move blit functions to radeon_asic.h

2011-02-18 Thread Daniel Vetter
Reviewed-by: Alex Deucher alexdeuc...@gmail.com Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch --- drivers/gpu/drm/radeon/radeon.h | 13 - drivers/gpu/drm/radeon/radeon_asic.h | 13 + 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers

Re: [BUG] drm/i915 Screen corruption introduced by a00b10c360b35d6431a94cb

2011-02-19 Thread Daniel Vetter
. Greetings, Indan -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index cf4f74c..2e6b532 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_gem.c @@ -1404,6 +1404,8

Re: [BUG] drm/i915 Screen corruption introduced by a00b10c360b35d6431a94cb

2011-02-20 Thread Daniel Vetter
in the original report into the patch by Chris and re-run git bisect on this new branch? Thanks, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman

Re: [PATCH] drm/i915: fix corruptions on i8xx due to relaxed fencing

2011-02-22 Thread Daniel Vetter
Am Mi, 23.02.2011, 07:59 schrieb Indan Zupancic: On Tue, February 22, 2011 18:25, Daniel Vetter wrote: It looks like gen2 has a peculiar interleaved 2-row inter-tile layout. Probably inherited from i81x which had 2kb tiles (which naturally fit an even-number-of-tile-rows scheme to fit onto 4kb

Re: [PATCH] drm/i915: fix corruptions on i8xx due to relaxed fencing

2011-03-10 Thread Daniel Vetter
Am Do, 10.03.2011, 06:06 schrieb Indan Zupancic: This isn't in rc8, can someone make sure it gets into 2.6.38-rc9/2.6.38? The patch unfortunately broke gen4+ (more precisely: the unwritten abi guarantee that userspace can tile buffers that don't have a complete last tile row, as long as it

Re: [PATCH] drm/i915: fix corruptions on i8xx due to relaxed fencing

2011-03-10 Thread Daniel Vetter
Am Do, 10.03.2011, 11:36 schrieb Indan Zupancic: On Thu, March 10, 2011 08:52, Daniel Vetter wrote: [Aside: This only happens if you have new enough userspace that supports relaxed tiling. Old userspace and new kernels are _not_ broken.] Yes, I noticed it got reverted when digging into git

Re: GEM-related desktop sluggishness due to linear-time arch_get_unmapped_area_topdown()

2011-03-29 Thread Daniel Vetter
you're gonna write fits into L1 cache, it's probably a net win. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] Fix typo in include/drm/i915_drm.h

2011-04-12 Thread Daniel Vetter
Indeed, good catch. Luckily never ever used (libdrm takes care of it internally) in the drmCommand(Write|Read) functions. Acked-by: Daniel Vetter daniel.vet...@ffwll.ch On Tue, Apr 12, 2011 at 6:10 AM, Ole Henrik Jahren olehe...@alumni.ntnu.no wrote: Signed-off-by: Ole Henrik Jahren olehe

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-27 Thread Daniel Vetter
(also for other stuff). Perhaps we want to extend the create_dumb_gem_object ioctl for that use case, but I'm not too convinced that this belongs into the kernel. Cheers, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-27 Thread Daniel Vetter
On Wed, Apr 27, 2011 at 3:32 PM, Jerome Glisse j.gli...@gmail.com wrote: On Wed, Apr 27, 2011 at 8:19 AM, Daniel Vetter dan...@ffwll.ch wrote: float scale_x, scale_y; No float in kernel. Would have to use fixed point. Bleh, of course ;-) 32bit with a 16 bit shift should be good enough for all

Re: [RFC] drm: add overlays as first class KMS objects

2011-04-27 Thread Daniel Vetter
On Wed, Apr 27, 2011 at 4:34 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: Or just specify the source size. You already know the output size... Hm, I've thought that x, y are fb offsets, not width/height of the target ... Maybe we need that, too? -Daniel -- Daniel Vetter daniel.vet

[PATCH] drm: mm: fix debug output

2011-05-06 Thread Daniel Vetter
The looping helper didn't do anything due to a superficial semicolon. Furthermore one of the two dump functions suffered from copypaste fail. While staring at the code I've also noticed that the replace helper (currently unused) is a bit broken. Signed-off-by: Daniel Vetter daniel.vet

drm intel maintainership

2011-05-10 Thread Daniel Vetter
Hi Keith and Chris, I'm a bit confused about drm-intel maintainership. Please clarify. And if drm-intel mainterships switches permanently to Keith, please send out a proper announcement and a corresponding patch to MAINTAINERS. Yours, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79

Re: [RFC] drm: add overlays as first class KMS objects

2011-05-13 Thread Daniel Vetter
to splice media controller into kms but nothing clear emerged. So a possible kms integration with media controller is rather far away. Yours, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch ___ dri-devel mailing

Re: [PATCH 14/15] gma500: nuke the PSB debug stuff

2011-06-12 Thread Daniel Vetter
around in drm_mm quite a bit I'd be very interested in your opinion about what's weird in it (and presumably what could be improved). Can you elaborate? Thanks a lot, Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch

Re: [PATCH 14/15] gma500: nuke the PSB debug stuff

2011-06-13 Thread Daniel Vetter
posted is a prime example why). Yours, Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC] Updated plane support v3

2011-06-21 Thread Daniel Vetter
atomic vsync flips across multiple planes and the underlying crtc - that might also require us to change certain properties in the same flip command. -Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch ___ dri

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-26 Thread Daniel Vetter
hazy at the edges and likely broken in tons of corner cases, but still ... This has also the benefit that it won't stall execbuf. - And a nitpick: Why the dev_priv-dev indirection, when dev is already lying around? -Daniel -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 364 57 48 - http

Re: [PATCH 4/5] drm/i915: Delay 250ms before running the hotplug code

2011-07-26 Thread Daniel Vetter
queue_delayed_work? Plays nicer with other workqueue-items. -Daniel PS: Scrap my other mail, just noticed that the merged patched r-b'ed by Jesse uses the mode_config mutex. -- Daniel Vetter daniel.vet...@ffwll.ch - +41 (0) 79 364 57 48 - http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH] drm/i915: Hold struct_mutex during hotplug processing

2011-07-29 Thread Daniel Vetter
for more locking, just in case. -Daniel -- Daniel Vetter Mail: dan...@ffwll.ch Mobile: +41 (0)79 365 57 48 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

  1   2   3   4   5   6   7   8   9   10   >