-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/Makefile| 1 +
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 6 +
drivers/gpu/drm/mediatek/mtk_drm_drv.h | 4 +
drivers/gpu/drm/mediatek/mtk_drm_fb.c| 13 ++
drivers/gpu/drm/mediatek/mtk_drm_fb.h| 3
Tested with mmsys-Patch, but same result, no fbcon, tft is switched on but i
see no kernel-log
after boot is finished, i see X-server, until this point i see only black screen
regards Frank
> Gesendet: Freitag, 18. Januar 2019 um 09:39 Uhr
> Von: "Matthias Brugger"
> may it be the not yet
I have tested same codebase where my FBDev-Patch works (4.20-hdmiv5), only
without it and CK Hu's 2 Patches
does generic fbdev depend on the mmsys-Patch?
regards Frank
> Gesendet: Freitag, 18. Januar 2019 um 09:39 Uhr
> Von: "Matthias Brugger"
> may it be the not yet fixed mmsys compatible
det: Mittwoch, 16. Januar 2019 um 02:39 Uhr
> Von: "CK Hu"
> An: "Philipp Zabel" , "David Airlie"
> , "Daniel Vetter" , "Matthias Brugger"
> , "Noralf Tr�nnes" , "Frank
> Wunderlich"
> Cc: dri-devel@lists.f
Hi,
i got v5-patches working on bpi-r2 (mt7623) with a Patch from Ryder.lee and 2
from Bibby Hsieh on 4.19-rc1
https://github.com/frank-w/BPI-R2-4.14/commits/4.19-hdmiv5
but after i tried to include them on 4.19.2, i got a strange behaviour
(stretched and pink font instead of white/grey)
see
t; Von: "Matthias Brugger"
> An: "Frank Wunderlich" , "CK Hu"
> Cc: mark.rutl...@arm.com, devicet...@vger.kernel.org, sean.w...@kernel.org,
> "Matthias Brugger" , airl...@linux.ie,
> mturque...@baylibre.com, sean.w...@mediatek.com, sb...@
Hi Daniel,
> > Would be good to use the new generic fbdev emulation code here, for even
> > less code. Or at least know why this isn't possible to use for mtk (and
> > maybe address that in the core code). Hand-rolling fbdev code shouldn't be
> > needed anymore.
>
> Back on the mailing list, no
like Daniel guessed, fb-console does not work with this Patch.
i tried your Patch (additional patch for headerfile):
https://github.com/frank-w/BPI-R2-4.14/commits/4.20-fbdev
and R2 hangs (no crash and no further boot)
[5.435075] mediatek-drm 1400.dispsys: bound 14012000.rdma (ops
Hi,
i try to get hdmi running on bananapi-r2 with 5.1 but also without CK Hu's
frambuffer-Patch i get no x-server working
my codebase: https://github.com/frank-w/BPI-R2-4.14/commits/5.1-hdmi
reused some Patches working on 5.0 (here X-server is working, but not fbcon)
WARNING: CPU: 2 PID: 895
This Patch-Series adds missing Patches/Bugfixes to get hdmi working on BPI-R2
first 2 Patches were already posted, but not yet merged into mainline
i found no hint why
- config component output by device node port
https://patchwork.kernel.org/patch/10609007/
- add display subsystem related
From: Bibby Hsieh
We can select output component by decive node port.
Main path default output component is DSI.
External path default output component is DPI.
Signed-off-by: Bibby Hsieh
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 41 ++
From: Ryder Lee
without this patch there is purple stretched font on fbconsole
source: http://forum.banana-pi.org/t/kernel-4-19-rc1-for-testers/6618/52
Signed-off-by: Ryder Lee
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +-
1 file changed, 1 insertion(+), 1
Hi CK Hu,
you mean the problematic patch is fix possible_crtcs (4/4) and the others are
ok?
can you push the first 3 while working on the last one?
regards Frank
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
arch/arm/boot/dts/mt7623.dtsi | 177 ++
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 85 +
arch/arm/boot/dts/mt7623n-rfb-emmc.dts| 85 +
3 files changed, 347 insertions(+)
diff --git a/arch
From: chunhui dai
- 1080 plg in/out with ng/ok
- support other resolutions like 1280x1024
Signed-off-by: chunhui dai
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_hdmi_phy.c| 3 +++
drivers/gpu/drm/mediatek/mtk_hdmi_phy.h| 1
Hi,
as talked to Bibby directly, this Patch seems to create a bug with
touchscreens. Cursor is displayed on old position if changing its position.
e.g. Cursor was on X1,Y1 and i touch to new position X2,Y2 the "click" is
recognized on right position (i try to ), but cursor is displayed on
Hi
Any opinion about DTS Patches? Which maintainer will include it in tree? Is any
ack/review needed?
regards Frank
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
From: Frank Wunderlich
mt7623a has no graphics support so move nodes from generic mt7623.dtsi
to mt7623n.dtsi
Fixes: 1f6ed224594 ("arm: dts: mt7623: add Mali-450 device node")
Suggested-by: David Woodhouse
Signed-off-by: Frank Wunderlich
---
arch/arm/boot/dts/m
From: Frank Wunderlich
This Patch-Series adds missing Patches/Bugfixes to get hdmi working
on BPI-R2
v5->v6:
- drop parts already merged to mediatek-drm-next
- include lima-regulator-patch
- rebase on changes in mediatek-drm-next tree (hdmi/hdmi-phy patches)
- fix compatible of hd
Tested-By: Frank Wunderlich
regards Frank
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
From: Alex Ryabchenko
GPU needs additional regulator, add it to devicetree of bpi-r2
Signed-off-by: Alex Ryabchenko
Signed-off-by: Frank Wunderlich
---
arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm
From: Ryder Lee
Add display subsystem related device nodes for MT7623.
Cc: Chun-Kuang Hu
Signed-off-by: chunhui dai
Signed-off-by: Bibby Hsieh
Signed-off-by: Ryder Lee
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
changed
v5->v6:
change compatible of hdmi-node beca
display
Signed-off-by: chunhui dai
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/phy/mediatek/phy-mtk-hdmi-mt2701.c | 1 +
drivers/phy/mediatek/phy-mtk-hdmi.c| 3 +++
drivers/phy/mediatek/phy-mtk-hdmi.h| 1 +
3 files changed, 5 insertions(+)
diff --git
Hi Matthias,
any opinions about the dts-changes?
maybe series except the tmds-Patch get merged...so i add it only to my own repo
till we find a better way?
currently mainline does not support hdmi at all for the board. the tmds-patch
is only a fix for specific resolutions which have a
Tested full series on bananapi r2 (mt7623/mt2701, 5.9-rc1 + hdmi-patches),
works so far fbcon+x without issues
Tested-by: Frank Wunderlich
regards Frank
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman
:
>Hi, Frank:
>
>Matthias Brugger 於 2020年8月27日 週四 下午10:28寫道：
>>
>>
>>
>> On 27/08/2020 15:41, Frank Wunderlich wrote:
>> > Hi Matthias,
>> >
>> > any opinions about the dts-changes?
>> >
>>
>> they look good to me.
&g
> Gesendet: Mittwoch, 19. August 2020 um 21:04 Uhr
> Von: "Frank Wunderlich"
> Another way to fix it maybe not enabling it (use the flag in
> mtk_hdmi_phy_power_on) there instead of disabling after enabling it.
>
> Maybe this is less hacky than current way (as ck
> diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
> b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
> index 5223498502c4..edadb7a700f1 100644
> --- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
> +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c
> @@ -184,6 +184,9 @@ static int mtk_hdmi_phy_probe(struct
Hsieh
Signed-off-by: Frank Wunderlich
Reviewed-by: Chun-Kuang Hu
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 +
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 +
2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
b/drivers
From: Ryder Lee
Add display subsystem related device nodes for MT7623.
Cc: Chun-Kuang Hu
Signed-off-by: chunhui dai
Signed-off-by: Bibby Hsieh
Signed-off-by: Ryder Lee
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
changed
v4->v5:
add nodes to new mt7623n.dtsi to av
Am 19. August 2020 19:12:29 MESZ schrieb Matthias Brugger
:
>Isn't that worth a Fixes tag?
This could be
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=0fc721b2968e3cadec520c60d2fc63498d865055
(add support for mt2701/mt7623).
It uses existing framework which
From: Frank Wunderlich
mt7623 uses mt2701/mt8173 for drm, but have own compatibles
Signed-off-by: Frank Wunderlich
Acked-by: Rob Herring
Reviewed-by: Chun-Kuang Hu
---
.../devicetree/bindings/display/mediatek/mediatek,disp.txt| 2 +-
.../devicetree/bindings/display/mediatek/mediatek
.
Signed-off-by: Jitao Shi
Signed-off-by: Frank Wunderlich
Reviewed-by: Chun-Kuang Hu
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++-
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
b/drivers/gpu/drm/mediatek
From: Frank Wunderlich
This Patch-Series adds missing Patches/Bugfixes to get hdmi working
on BPI-R2
v4->v5:
- rebased on 5.9-rc1
- move existing display-related dts nodes to new mt7623n.dtsi
because mt7623a does not have gpu
- add new display nodes to this new dtsi
v3->v4:
- fix r
From: Frank Wunderlich
mt7623a has no graphics support so move nodes from generic mt7623.dtsi
to mt7623n.dtsi
Fixes: 1f6ed224594 ("arm: dts: mt7623: add Mali-450 device node")
Suggested-by: David Woodhouse
Signed-off-by: Frank Wunderlich
---
arch/arm/boot/dts/m
From: chunhui dai
disable tmds on phy on mt2701 to support other resolutions like 1280x1024
Signed-off-by: chunhui dai
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_hdmi_phy.c| 3 +++
drivers/gpu/drm/mediatek/mtk_hdmi_phy.h| 1
From: Frank Wunderlich
on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0
using compatible "mt7623-mmsys" already defined in dts
Signed-off-by: Frank Wunderlich
Reviewed-by: Chun-Kuang Hu
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 23 +
Just a gentle ping...any opinions?
regards Frank
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi
> Gesendet: Montag, 03. August 2020 um 01:47 Uhr
> Von: "Chun-Kuang Hu"
> Now I just care about the bls to dpi. So in mediatek,disp.txt, you
> just need to add a Optional properties - port (input and output), and
> modify mediatek,dpi.txt for its input port.
you mean something like this is
Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu :
>But now I have a solution that you need not to modify binding document.
>Because now mt7623 has a different routing than mt2701, and this
>patch's approach is to use different port setting in each device tree.
>My solution is that these
Hi,
> Gesendet: Dienstag, 04. August 2020 um 16:34 Uhr
> Von: "Chun-Kuang Hu"
> > -static const enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = {
> > +static enum mtk_ddp_comp_id mt2712_mtk_ddp_main[] = {
>
> Why do you remove 'const'?
was removed by previous patch and not re-added (revert
sorry, send this accidentally while posting my hdmi series v4 (have not deleted
patch-file)
just ignore this...it's already merged
regards Frank
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
From: chunhui dai
disable tmds on phy on mt2701 to support other resolutions like 1280x1024
Signed-off-by: chunhui dai
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_hdmi_phy.c| 3 +++
drivers/gpu/drm/mediatek/mtk_hdmi_phy.h| 1
From: Frank Wunderlich
on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0
using compatible "mt7623-mmsys" already defined in dts
Signed-off-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 25 -
1 file changed, 24
> Gesendet: Dienstag, 04. August 2020 um 19:24 Uhr
> Von: "David Woodhouse"
> > + mipi_tx0: mipi-dphy@1001 {
> > + compatible = "mediatek,mt7623-mipi-tx",
> > +"mediatek,mt2701-mipi-tx";
> > + reg = <0 0x1001 0 0x90>;
> > + clocks =
From: Frank Wunderlich
This Patch-Series adds missing Patches/Bugfixes to get hdmi working
on BPI-R2
v2->v3:
- use own mmsys-routing for mt7623 instead of code getting different
routing from dts
- remove ddp routing bls -> dpi from bpir2/rfb dts
- updated some commit-Messages as sug
From: Frank Wunderlich
This Patch-Series adds missing Patches/Bugfixes to get hdmi working
on BPI-R2
v3->v4:
- fix removed const in "add ddp routing for mt7623"
- change subjects to "drm/mediatek:..."
- add documentation for mt7623-* compatibles
- dropped redundant
ports")
Fixes: 72579e14a1d3 ("net: dsa: don't fail to probe if we couldn't set the MTU")
Fixes: 7a4c53bee332 ("net: report invalid mtu value via netlink extack")
Signed-off-by: Landen Chao
Signed-off-by: Frank Wunderlich
Reviewed-by: Andrew Lunn
---
v3->v4
- fix commit-mess
.
Signed-off-by: Jitao Shi
Signed-off-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++-
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
b/drivers/gpu/drm/mediatek/mtk_dpi.c
index
From: chunhui dai
disable tmds on phy on mt2701 to support other resolutions like 1280x1024
Signed-off-by: chunhui dai
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_hdmi_phy.c| 3 +++
drivers/gpu/drm/mediatek/mtk_hdmi_phy.h| 1
From: Ryder Lee
Add display subsystem related device nodes for MT7623.
Cc: CK Hu
Signed-off-by: chunhui dai
Signed-off-by: Bibby Hsieh
Signed-off-by: Ryder Lee
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
changed v2->v3:
drop bls to dpi routing
---
arch/arm/boot/
From: Frank Wunderlich
on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0
using compatible "mt7623-mmsys" already defined in dts
Signed-off-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 23 +++
1 file changed, 23
> Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr
> Von: "Chun-Kuang Hu"
> An: "Frank Wunderlich"
> > + mipi_tx0: mipi-dphy@1001 {
> > + compatible = "mediatek,mt7623-mipi-tx",
>
> In mediatek,dsi.txt [1],
From: Ryder Lee
Add display subsystem related device nodes for MT7623.
Cc: CK Hu
Signed-off-by: chunhui dai
Signed-off-by: Bibby Hsieh
Signed-off-by: Ryder Lee
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
changed
v3->v4:
drop display_components which is duplic
CC Rob Herring and devicetree-list
> Gesendet: Dienstag, 04. August 2020 um 18:55 Uhr
> Von: "Frank Wunderlich"
> An: linux-media...@lists.infradead.org
> Cc: "Frank Wunderlich" , "Chun-Kuang Hu"
> , "Philipp Zabel" , "David
>
.
Signed-off-by: Jitao Shi
Signed-off-by: Frank Wunderlich
Reviewed-by: Chun-Kuang Hu
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++-
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c
b/drivers/gpu/drm/mediatek
> Gesendet: Dienstag, 04. August 2020 um 17:00 Uhr
> Von: "Chun-Kuang Hu"
> > + display_components: dispsys@1400 {
> > + compatible = "mediatek,mt7623-mmsys",
> > +"mediatek,mt2701-mmsys";
>
> In mediatek,mmsys.txt [3], this should be:
>
>
From: Frank Wunderlich
mt7623 uses mt2701/mt8173 for drm, but have own compatibles
Signed-off-by: Frank Wunderlich
---
.../devicetree/bindings/display/mediatek/mediatek,disp.txt| 2 +-
.../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 2 +-
.../devicetree/bindings/display
Hsieh
Signed-off-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 +
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 +
2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
b/drivers/gpu/drm/mediatek
Hsieh
Signed-off-by: Frank Wunderlich
Reviewed-by: Chun-Kuang Hu
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 +
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 +
2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
b/drivers
Hi,
i've printed the mtk_comp_id after the modification-loops...
[5.480848] main:
[5.480851] DDP_COMPONENT_OVL0
[5.482776] DDP_COMPONENT_RDMA0
[5.485827] DDP_COMPONENT_COLOR0
[5.488978] DDP_COMPONENT_BLS
[5.492206] DDP_COMPONENT_DPI0
[5.495170] ext:
[5.498233]
> Gesendet: Mittwoch, 05. August 2020 um 10:36 Uhr
> Von: "David Woodhouse"
> > mt7623.dtsi => mt7623n.dtsi => mt7623n-bananapi-bpi-r2.dts
> > mt7623.dtsi => mt7623a.dtsi => mt7623a-unielec-u7623.dts (not existing yet,
> > openwrt seems to use a board-specific dtsi)
>
> Yes, I think we should.
CC Rob Herring + devicetree List + Sean
> Gesendet: Dienstag, 04. August 2020 um 20:02 Uhr
> Von: "David Woodhouse"
> On Tue, 2020-08-04 at 19:40 +0200, Frank Wunderlich wrote:
> > > Gesendet: Dienstag, 04. August 2020 um 19:24 Uhr
> > > Von: "David
Hi David
> Gesendet: Mittwoch, 05. August 2020 um 13:30 Uhr
> Von: "David Woodhouse"
> From: David Woodhouse
>
> The MT7623A doesn't have a GPU; add it only for MT7623N boards.
>
> Fixes: 1f6ed224594 ("arm: dts: mt7623: add Mali-450 device node")
> Signed-off-by: David Woodhouse
> diff --git
Am 2. August 2020 05:07:41 MESZ schrieb Chun-Kuang Hu :
>I would like more information of why do this patch. For example:
>
>For current mediatek dsi encoder, its possible crtc is fixed in crtc
>0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In
>some SoC the possible crtc is
> Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr
> Von: "Chun-Kuang Hu"
> An: "Frank Wunderlich"
> Cc: "Chun-Kuang Hu" , "Philipp Zabel"
> , "David Airlie" , "linux-kernel"
> , "DRI Development"
&
Hi,
Am 2. August 2020 02:08:44 MESZ schrieb Chun-Kuang Hu :
>Hi, Frank:
>> - disable tmds on phy on mt2701
>> - support other resolutions like 1280x1024
>
>If this patch does two things, it should be broken into two patches.
As far as i see,it only disable tmds and so fix specific resolutions
From: chunhui dai
- disable tmds on phy on mt2701
- support other resolutions like 1280x1024
without this Patch i see flickering on my TFT (1280x1024),
so i guess clock is wrong.
Signed-off-by: chunhui dai
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm
From: Stu Hsieh
Test: build pass and run ok
Signed-off-by: Stu Hsieh
---
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 42 +
drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 2 +
2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
This Patch-Series adds missing Patches/Bugfixes to get hdmi working
on BPI-R2
This is v2 of series https://patchwork.kernel.org/cover/10903309/ after
getting mmsys done
v1->v2:
- using get_possible_crtc API instead of hardcoded
- drop unused dts-nodes
- refine commit-messages as far as i can
From: Ryder Lee
Add display subsystem related device nodes for MT7623.
Cc: CK Hu
Signed-off-by: chunhui dai
Signed-off-by: Bibby Hsieh
Signed-off-by: Ryder Lee
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
arch/arm/boot/dts/mt7623.dtsi | 177
+0x1d8/0x258
Signed-off-by: Bibby Hsieh
added small fixes for warnings
Signed-off-by: Frank Wunderlich
Tested-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/mtk_drm_drv.c | 46 ++
drivers/gpu/drm/mediatek/mtk_drm_drv.h | 4 +--
2 files changed, 42 insertions(+), 8
From: Jitao Shi
[Detail]
dpi/dsi get the possible_crtc by
mtk_drm_find_possible_crtc_by_comp(*drm_dev, ddp_comp)
Test: build pass and boot to logo
Signed-off-by: Jitao Shi
---
drivers/gpu/drm/mediatek/mtk_dpi.c | 3 ++-
drivers/gpu/drm/mediatek/mtk_dsi.c | 3 ++-
2 files changed, 4
Hi,
> Gesendet: Mittwoch, 07. Juli 2021 um 17:03 Uhr
> Von: "Chun-Kuang Hu"
> I think you have done many experiment [1] and you bisect between
> 2e4773915223 (good) and be18cd1fcae2 (bad), and you are confused by
> merge commit.
> You may refer to [2] and it may help you to understand git
Hi,
i've noticed that HDMI is broken at least on my board (Bananapi-r2,mt7623) on
5.13.
after some research i noticed that it is working till
commit 2e477391522354e763aa62ee3e281c1ad9e8eb1b
Author: Dafna Hirschfeld
Date: Tue Mar 30 13:09:02 2021 +0200
drm/mediatek: Don't support hdmi
Hi Daniel
> Gesendet: Dienstag, 06. Juli 2021 um 13:20 Uhr
> Von: "Daniel Vetter"
> An: "Frank Wunderlich"
> Cc: "Maarten Lankhorst" , "Maxime Ripard"
> , "Thomas Zimmermann" , "David
> Airlie" , "Daniel Vett
> Gesendet: Donnerstag, 08. Juli 2021 um 09:22 Uhr
> Von: "Dafna Hirschfeld"
> We also encountered that warning on mt8173 device - Acer Chromebook R13. It
> happen after resuming from suspend to ram.
> We could not find a version that works and we were not able to find the fix
> of the bug.
>
ches) and 5.12.14 too
(hdmi is working there), but not 5.12.0!
that means something in drm-patches (mtk/core) breaks watchdog. maybe the
recursion mentioned above?
regards Frank
> Gesendet: Donnerstag, 08. Juli 2021 um 09:22 Uhr
> Von: "Dafna Hirschfeld&quo
> Gesendet: Donnerstag, 08. Juli 2021 um 14:30 Uhr
> Von: "Dafna Hirschfeld"
> > i see both messages, but mtk_crtc_ddp_irq is never called and so the other
> > 2 not.
>
> Yes, In my case the irq isr is also not called after resume which cause the
> warning
> even though "enable_vblank" do get
> Gesendet: Donnerstag, 08. Juli 2021 um 11:35 Uhr
> Von: "Frank Wunderlich"
> i guess not, but is watchdog somehow involved? i ask because i see this on
> reboot/poweroff:
>
> "watchdog: watchdog0: watchdog did not stop!"
>
> i see this with my
Hi,
i've found it :)
hdmi-problem is caused by
commit 440147639ac79f699a4eb9811d0bc39d3cc815f4
Author: CK Hu
Date: Wed Mar 17 19:17:10 2021 +0100
soc: mediatek: mmsys: Use an array for setting the routing registers
but i cannot revert it alone, but after reverting all mmsys-patches
> Gesendet: Freitag, 09. Juli 2021 um 12:24 Uhr
> Von: "Enric Balletbo Serra"
> If this is the offending commit, could you try if the following patch
> fixes the issue for you?
>
>
> Gesendet: Freitag, 09. Juli 2021 um 12:38 Uhr
> Von: "Frank Wunderlich"
> An: "Enric Balletbo Serra"
> Cc: "CK Hu" , "Dafna Hirschfeld"
> , "chunkuang Hu" ,
> "Thomas Zimmermann" , "David Airlie" ,
&
Hi,
HDMI is broken again in 5.14-rc1 (of course i have applied my patch [1])
now i've got a NULL pointer dereference
[ 21.883641] PC is at mtk_dpi_bridge_atomic_check+0x38/0x78
[ 21.889158] LR is at drm_atomic_bridge_chain_check+0x150/0x30c
"dpi" is not set correctly in
> Gesendet: Montag, 12. Juli 2021 um 13:50 Uhr
> Von: "Dafna Hirschfeld"
> An: "Frank Wunderlich" , linux-media...@lists.infradead.org
> Cc: "Frank Wunderlich" , "Matthias Brugger"
> , "CK Hu" ,
> linux-arm-ker...@lists.i
Hi,
it turns out that problem is the read+or of the new value
i reverted my patch and changed
reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val;
writel_relaxed(reg, mmsys->regs + routes[i].addr);
to
writel_relaxed(routes[i].val, mmsys->regs + routes[i].addr);
and it works
From: Frank Wunderlich
HDMI output was broken on mt7623/BPI-R2 in 5.13 because function for
special output selection (mtk_mmsys_ddp_sout_sel) was dropped.
This function wrote 3 registers at one time and so it is not compatible
with the array-approach.
I re-added the old function and call
From: Frank Wunderlich
bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge)
like it's done in bridge_atomic_get_output_bus_fmts
Fixes: ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation")
Signed-off-by: Frank Wunderlich
---
drivers/gpu/drm/mediatek/
Hi
can you please test if your device still work after applying this
https://patchwork.kernel.org/project/linux-mediatek/patch/20210729070549.5514-1-li...@fw-web.de/
and
duplicate value constants in your routes?
e.g. changing
+ DDP_COMPONENT_OVL_2L0, DDP_COMPONENT_RDMA0,
+
Full Series tested on BPI-R2/MT7623
Tested-By: Frank Wunderlich
regards Frank
Hi,
sorry this (or the 2 depency-series) cause a NULL Pointer deref in
iommu_group_remove_device on mt7623/bpi-r2
i wonder why on bootup a cleanup is run, but have no hint about this.
since "dts: mtk-mdp: remove mediatek, vpu property from primary MDP device" all
is good, i guess problem
>On 12.07.21 19:16, Frank Wunderlich wrote:
>> Hi,
>>
>> it turns out that problem is the read+or of the new value
>>
>> i reverted my patch and changed
>>
>> reg = readl_relaxed(mmsys->regs + routes[i].addr) | routes[i].val;
>
Hi
> Gesendet: Montag, 26. Juli 2021 um 02:27 Uhr
> Von: "Chun-Kuang Hu"
> As I've discussed in [1], SOUT has many bits and need to be cleared
> before set new value. Of course, write only could do the clear, but
> for MOUT, it clear the bits that should not be cleared. If you want to
> use the
> Gesendet: Mittwoch, 14. Juli 2021 um 13:18 Uhr
> Von: "Yong Wu"
> Hi Frank,
>
> Thanks for your report. mt7623 use mtk_iommu_v1.c.
>
> I will try to reproduce this locally.
Hi,
as far as i have debugged it dev->iommu_group is NULL, so it crashes on first
access (dev_info)
Hi
> Gesendet: Donnerstag, 17. Februar 2022 um 09:29 Uhr
> Von: "Sascha Hauer"
> --- a/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk356x.dtsi
> @@ -10,7 +10,6 @@
> #include
> #include
> #include
> -#include
why dropping this after adding in part 16?
>
Tested this Series on my rk3568 Bananapi R2 Pro v00
Tested-by: Frank Wunderlich
regards Frank
Hi Sascha
tested full v5 Series + 3 clk-Patches from v4 on 5.17-rc2 on my rk3568 based
Bananapi R2 Pro
1280x720-32@60Hz
1920x1080-32@60Hz
3840x2160-32@60Hz
with fb console
Tested-by: Frank Wunderlich
regards Frank
Hi Sascha
tested full v5 Series + 3 clk-Patches from v4 on 5.17-rc2 on my rk3568 based
Bananapi R2 Pro
1280x720-32@60Hz
1920x1080-32@60Hz
3840x2160-32@60Hz
with fb console
Tested-by: Frank Wunderlich
regards Frank
Hi
> Gesendet: Mittwoch, 26. Januar 2022 um 15:55 Uhr
> Von: "Sascha Hauer"
> Betreff: [PATCH 01/27] drm/encoder: Add of_graph port to struct drm_encoder
Please use "git format-patch -vX ..." when creating your patches to make sure
the version is set in every patch and not only the
Hi Sascha
tested full series on Bananapi r2 Pro V0 prototype (rk3568)
4K@60Hz
1080p@60Hz
both look good
Tested-By: Frank Wunderlich
regards Frank
1 - 100 of 101 matches
Mail list logo
