[PATCH 0/6] drm: qemu hardware patches

2013-10-11 Thread Gerd Hoffmann
issues and are still work-in-progress. I'm posing them for early review nevertheless. git tree with these patches is here: git://git.kraxel.org/linux qemu-drm cheers, Gerd Gerd Hoffmann (6): drm: add drm_set_preferred_mode drm/cirrus: use drm_set_preferred_mode drm/qxl: support 64bit

[PATCH 1/6] drm: add drm_set_preferred_mode

2013-10-11 Thread Gerd Hoffmann
New helper function to set the preferred video mode. Can be called after drm_add_modes_noedid if you don't want the largest supported video mode be used by default. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- drivers/gpu/drm/drm_edid.c | 13 + include/drm/drm_crtc.h | 2

[PATCH 3/6] drm/qxl: support 64bit surface bar

2013-10-11 Thread Gerd Hoffmann
-vga.vram64_size_mb=512 \ $otheroptions Signed-off-by: Gerd Hoffmann kra...@redhat.com --- drivers/gpu/drm/qxl/qxl_kms.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index 9e8da9e

[PATCH 2/6] drm/cirrus: use drm_set_preferred_mode

2013-10-11 Thread Gerd Hoffmann
to call it multiple times with different sizes. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- drivers/gpu/drm/cirrus/cirrus_mode.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index

[PATCH 5/6] [wip] drm/qxl: request regions

2013-10-11 Thread Gerd Hoffmann
So they show up in /proc/{iomem,ioports}. No error checking (yet?). Doesn't make things worse than they are now, but still not nice. Known issue: Doesn't work for qxl-vram (vesafb conflict?). Signed-off-by: Gerd Hoffmann kra...@redhat.com --- drivers/gpu/drm/qxl/qxl_kms.c | 6 ++ 1 file

[PATCH 4/6] drm/qxl: add some surface memory logging

2013-10-11 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- drivers/gpu/drm/qxl/qxl_kms.c | 10 +++--- drivers/gpu/drm/qxl/qxl_ttm.c | 2 ++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c index e0ddd5b..e5ca498 100644

[PATCH 6/6] [wip] drm/bochs: new driver

2013-10-11 Thread Gerd Hoffmann
DRM driver for (virtual) vga cards using the bochs dispi interface, such as the qemu standard vga (qemu -vga std). Don't bother supporting anything but 32bpp for now. Maybe add 16bpp later on. Known issue: mmap(/dev/fb0) doesn't work. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- drivers

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-31 Thread Gerd Hoffmann
Hi, > branches. One part that imo really should stick around is the drm-tip > integration tree rebuilding. That allows us to distribute conflict > handling (e.g. between drm-misc-fixes and drm-misc-next), and with more > people and more drivers in drm-misc I expect more conflicts. Ok, good

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-31 Thread Gerd Hoffmann
Hi, > declare -n introduced in bash 4.3 is needed for alias > support. Workaround at [1]. > > [1] https://lists.freedesktop.org/archives/intel-gfx/2017-January/118474.html Works for me. Thanks. > N.b. dim currently doesn't do all its magic, such as adding Link: tag, > if you apply more than

Re: make fbdev/fbcon switchable per driver?

2017-01-31 Thread Gerd Hoffmann
Hi, > > The VGA arbiter sets up a notifier on the PCI bus and will add any VGA > > class code devices it finds. So even if the driver doesn't > > participate, it'll still be tracked and might be marked as primary. If > > a graphics driver claims a VGA device that does not depend on VGA > >

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-31 Thread Gerd Hoffmann
On Fr, 2017-01-27 at 14:53 +0100, Daniel Vetter wrote: > On Fri, Jan 27, 2017 at 09:20:42AM +0100, Gerd Hoffmann wrote: > > On Do, 2017-01-26 at 23:05 -0200, Gabriel Krisman Bertazi wrote: > > > No longer true since commit 07f8d9bdb235 ("drm/qxl: add support for > 1 >

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-31 Thread Gerd Hoffmann
Hi, > > Does dim detect that a Link: tag is already present and doesn't add > > another one then? > > Nope. Patches welcome. ;) For now I've settled to applying patches with the patches tool, a little shell script to rewrite "Message-id:" lines into patchwork links, and using dim to push

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > I guess I could ask Gerd whether we wants to be part of the experiment to > maintain small drivers in drm-misc, to avoid these kinds of coordination > issues? Sounds reasonable. There isn't much activity, that's why I've grouped all four qemu drivers into a single branch already. The

Re: RFC: drm-misc for small drivers?

2017-01-30 Thread Gerd Hoffmann
Hi, > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-misc.html > https://01.org/linuxgraphics/gfx-docs/maintainer-tools/dim.html apache throws 403. cheers, Gerd ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > drm-misc runs with the committer model, i.e. a few maintainers to do pull > requests and backmerges, a big pile of people directly pushing patches. [ looked at docs too meanwhile ] Sounds good. I guess switching over simplifies things for all of us. We'll avoid issues like the one at

Re: make fbdev/fbcon switchable per driver?

2017-01-30 Thread Gerd Hoffmann
Hi, > The vgaarb code has a concept of a vga_default_device(), it's rather > PCI-centric, but maybe better than nothing. This is typically the > first VGA class code device found with I/O and MMIO enabled. If fbcon > defaulted to running on the vga_default_device(), a user could select >

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-30 Thread Gerd Hoffmann
Hi, > Do you want to merge from drm-misc or should we push this one > directly via drm-misc? Merging through drm-misc is fine with me. cheers, Gerd ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH] virtio-gpu: disable VIRGL with BE kernel

2017-01-27 Thread Gerd Hoffmann
On Di, 2017-01-24 at 14:12 +0100, Laurent Vivier wrote: > VIRTIO_GPU_F_VIRGL is added in features list only > for LE kernel, so we must check for it only on LE kernel, > otherwise virtio_has_feature() calls BUG() and > crashes the kernel. > > Suggested-by: Gerd Hoffmann

Re: [PATCH 1/4] drm: qxl: Drop misleading comment

2017-01-27 Thread Gerd Hoffmann
On Do, 2017-01-26 at 23:05 -0200, Gabriel Krisman Bertazi wrote: > No longer true since commit 07f8d9bdb235 ("drm/qxl: add support for > 1 > output"). qxl_num_crtc defaults to 4 and is configurable as a module > parameter. Picked up patches 1-3 for drm-qemu branch. Patch 4 doesn't apply and

make fbdev/fbcon switchable per driver?

2017-01-27 Thread Gerd Hoffmann
2001 From: Gerd Hoffmann <kra...@redhat.com> Date: Fri, 27 Jan 2017 08:05:40 +0100 Subject: [PATCH] drm i915: add fbdev option Signed-off-by: Gerd Hoffmann <kra...@redhat.com> --- drivers/gpu/drm/i915/intel_fbdev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/

Re: [PATCH] drm/virtio: call drm_plane_cleanup() at destroy phase

2017-02-16 Thread Gerd Hoffmann
On Mi, 2017-02-15 at 16:00 -0200, Gustavo Padovan wrote: > From: Gustavo Padovan > > virtio was missing this call to clean up core plane usage. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/virtio/virtgpu_plane.c |

Re: [PATCH] drm/bochs: Implement nomodeset

2017-01-18 Thread Gerd Hoffmann
On Mi, 2017-01-18 at 19:10 +0100, Max Staudt wrote: > Up until now, the bochsdrm driver didn't handle the nomodeset option > at boot, and didn't provide a "modeset" module option either. > > This patch implements both. > > The new parameter can be used by specifying bochs-drm.modeset=0 > at boot

[PULL] qemu drm driver fixes

2016-09-21 Thread Gerd Hoffmann
to 30b9c96cf7b44d53b9165649c8be34ac234be324: drm/virtio: add real fence context and seqno (2016-09-20 14:25:43 +0200) bugfixes for qemu (bochs, qxl and virtio-gpu) drm drivers Gerd Hoffmann (1

GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Gerd Hoffmann
On Do, 2016-09-22 at 15:11 +0200, SF Markus Elfring wrote: > > Guys, please stop accepting patches from Markus! > > I would appreciate a bit more explanation for this request. For starters make sure the patches land actually on the list. Only the cover letter arrived here. cheers, Gerd

GPU-DRM-QXL: Move three assignments in qxl_device_init()

2016-09-22 Thread Gerd Hoffmann
On Do, 2016-09-22 at 19:16 +0200, SF Markus Elfring wrote: > > For starters make sure the patches land actually on the list. > > How do you think about to take another look at this update suggestion > also by the usual archive interfaces? > > * https://patchwork.kernel.org/patch/9344521/ > > *

Regression: drm: Lobotomize set_busid nonsense for !pci drivers (a325725633c2)

2016-10-04 Thread Gerd Hoffmann
Hi, > diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > index a59d0e309bfc..1fcf739bf509 100644 > --- a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > +++ b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > @@ -68,6 +68,10 @@ int drm_virtio_init(struct

Regression: drm: Lobotomize set_busid nonsense for !pci drivers (a325725633c2)

2016-10-05 Thread Gerd Hoffmann
On Di, 2016-10-04 at 09:43 +0200, Gerd Hoffmann wrote: > Hi, > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > > b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c > > index a59d0e309bfc..1fcf739bf509 100644 > > --- a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c &g

Regression: drm: Lobotomize set_busid nonsense for !pci drivers (a325725633c2)

2016-10-05 Thread Gerd Hoffmann
On Mi, 2016-10-05 at 12:30 +0200, Daniel Vetter wrote: > On Wed, Oct 05, 2016 at 08:34:57AM +0200, Gerd Hoffmann wrote: > > On Di, 2016-10-04 at 09:43 +0200, Gerd Hoffmann wrote: > > > Hi, > > > > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drm

[PATCH] virtio-gpu: fix vblank events

2016-10-13 Thread Gerd Hoffmann
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-26 Thread Gerd Hoffmann
On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote: > -int bochs_connector_get_modes(struct drm_connector *connector) > +static int bochs_connector_get_modes(struct drm_connector *connector) Added to drm-qemu queue. thanks, Gerd

[PATCH] drm/bochs: mark bochs_connector_get_modes() static

2016-09-26 Thread Gerd Hoffmann
On Mo, 2016-09-26 at 11:29 +0200, Daniel Vetter wrote: > On Mon, Sep 26, 2016 at 10:52 AM, Gerd Hoffmann wrote: > > On So, 2016-09-25 at 15:25 +0800, Baoyou Xie wrote: > >> -int bochs_connector_get_modes(struct drm_connector *connector) > >> +static int bochs

[PATCH] drm: remove immutable flag from suggested X/Y connector properties

2017-01-03 Thread Gerd Hoffmann
Hi, > > Makes sense I think, but for merging we need: > > - some driver to implement > > This is where it starts getting tricky. vboxvideo is out of tree. In > theory I could look at getting it merged, but that needs time I am > rather short of (I am the only person maintaining that driver

[PULL] drm-qemu: 4.10 updates

2017-01-10 Thread Gerd Hoffmann
to af3076e67c31ceb3e314933dd61cb68a1d5120cf: drm: flip cirrus driver status to "obsolete". (2017-01-10 14:00:40 +0100) drm-qemu: virtio sparse fix, MAINTAINERS updates. ---

Re: [RESEND PATCH 00/14] QXL atomic modesetting

2017-02-28 Thread Gerd Hoffmann
On Mo, 2017-02-27 at 17:43 -0300, Gabriel Krisman Bertazi wrote: > Hi, > > This is a resend of the qxl atomic modesetting patchset to include the > reviewed-by tags from Gustavo and rebase on top of the tip of drm-misc-next. > > This series implements support for Atomic Modesetting in the QXL

Re: [RESEND PATCH 00/14] QXL atomic modesetting

2017-02-28 Thread Gerd Hoffmann
On Di, 2017-02-28 at 14:29 +0100, Gerd Hoffmann wrote: > On Mo, 2017-02-27 at 17:43 -0300, Gabriel Krisman Bertazi wrote: > > Hi, > > > > This is a resend of the qxl atomic modesetting patchset to include the > > reviewed-by tags from Gustavo and rebase on top

Re: [RESEND PATCH 00/14] QXL atomic modesetting

2017-02-28 Thread Gerd Hoffmann
On Mo, 2017-02-27 at 17:43 -0300, Gabriel Krisman Bertazi wrote: > Hi, > > This is a resend of the qxl atomic modesetting patchset to include the > reviewed-by tags from Gustavo and rebase on top of the tip of drm-misc-next. > > This series implements support for Atomic Modesetting in the QXL

Re: [RESEND PATCH 00/14] QXL atomic modesetting

2017-02-28 Thread Gerd Hoffmann
Hi, > Patches look good, great job. I'll go run some more tests and if all > goes fine I'll push to drm-misc-next. Ok, cool, text console, xorg and wayland all work fine without glitches. Series pushed. thanks, Gerd ___ dri-devel mailing list

[PATCH v3 0/7] drm: Add fbdev deferred io support to helpers

2016-04-29 Thread Gerd Hoffmann
> I have never used qemu so I'm not keen on spending a lot of time on > that. Tested-by: Gerd Hoffmann

[PATCH 0/5] virtio-gpu: atomic fixes

2016-05-31 Thread Gerd Hoffmann
. Patch 4 does everything except the hotspot, an earlier version was on the list already. Patch 5 adds the hotspot location to the framebuffer and Patch 6 makes virtio-gpu pick it up there. please review, Gerd Gerd Hoffmann (5): virtio-gpu: fix output lookup virtio-gpu: add atomic_commit

[PATCH 1/5] virtio-gpu: fix output lookup

2016-05-31 Thread Gerd Hoffmann
Needed for multihead setups where we can have disabled outputs and therefore plane->crtc can be NULL. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c

[PATCH 2/5] virtio-gpu: add atomic_commit function

2016-05-31 Thread Gerd Hoffmann
Do modesets first, then call drm_atomic_helper_commit_planes with active_only = true. That way the outputs doesn't get disabled temporarly on atomic commits. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 22 +- drivers/gpu/drm/virtio

[PATCH 3/5] virtio-gpu: switch to atomic cursor interfaces

2016-05-31 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_display.c | 102 -- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + drivers/gpu/drm/virtio/virtgpu_plane.c | 105 --- 3 files changed, 109 insertions(+), 99 deletions

[PATCH 5/5] virtio-gpu: pick up hotspot from framebuffer

2016-05-31 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 4780354..b7778a7 100644 --- a/drivers/gpu/drm

[PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/drm_crtc.c | 2 ++ include/drm/drm_crtc.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index d2a6d95..ce5a280 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm

[PATCH] virtio-gpu: use src not crtc

2016-05-31 Thread Gerd Hoffmann
Pick up the correct source rectangle from framebuffer. Without this multihead setups are not working correctly. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/drivers

[PATCH 4/5] add cursor hotspot to drm_framebuffer

2016-05-31 Thread Gerd Hoffmann
On Di, 2016-05-31 at 15:36 +0300, Ville Syrjälä wrote: > Why store it in the fb and not eg. the plane state? Well, drm_plane_state is allocated by drm_atomic_helper_update_plane. When sticking the hotspot into the the plane state we have to add hot_x and hot_y parameters to

[PATCH v2] virtio-gpu: fix vblank events

2016-11-03 Thread Gerd Hoffmann
Hi, Dave, that is the only fix needed for for 4.9, can you pick it up directly? Otherwise I can prepare a single-patch pull request with it ... thanks, Gerd On Mi, 2016-11-02 at 16:00 -0600, Gustavo Padovan wrote: > ping > > 2016-10-18 Gustavo Padovan : > > > F

[PATCH v2] virtio-gpu: fix vblank events

2016-11-03 Thread Gerd Hoffmann
On Do, 2016-11-03 at 09:35 +0100, Gerd Hoffmann wrote: > Hi, > > Dave, that is the only fix needed for for 4.9, can you pick it up > directly? Otherwise I can prepare a single-patch pull request with > it ... ok, scratch that, just saw this already is in the -rc4 fixes pu

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-03 Thread Gerd Hoffmann
On Mi, 2016-11-02 at 18:00 +0100, Christophe Fergeau wrote: > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that > the resolutions we are going to present to user-space are going to be > rounded down to a multiple of 8. In the QXL arbitrary resolution case, > this is not

[drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-03 Thread Gerd Hoffmann
On Do, 2016-11-03 at 12:41 +0100, Christophe Fergeau wrote: > On Thu, Nov 03, 2016 at 09:53:48AM +0100, Gerd Hoffmann wrote: > > On Mi, 2016-11-02 at 18:00 +0100, Christophe Fergeau wrote: > > > The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that > &

[Spice-devel] [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8

2016-11-07 Thread Gerd Hoffmann
Hi, > I think we should try it an see, Ok, lets try. I'll go pick them up and prepare a pull with this and some virtio-gpu bits, Gerd

[drm/qxl v3 0/7] qxl: Various cleanups/fixes

2016-11-07 Thread Gerd Hoffmann
On Mo, 2016-11-07 at 09:00 +0100, Christophe Fergeau wrote: > Hey, > > Same series as v2 except that I removed the use of camel case in patch 6/7. > Now it's only using an anonymous enum + int. Can you please not drop the "PATCH" from $subject? thanks, Gerd

BUG: 'list_empty(>free_vbufs)' is true!

2016-11-09 Thread Gerd Hoffmann
On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: > On Mon, Nov 07, 2016 at 09:43:24AM +0100, Jiri Slaby wrote: > > Hi, > > > > I can relatively easily reproduce this bug: How? > > BUG: 'list_empty(>free_vbufs)' is true! > The following might be helpful for debugging - if kernel

BUG: 'list_empty(>free_vbufs)' is true!

2016-11-15 Thread Gerd Hoffmann
On Fr, 2016-11-11 at 17:28 +0100, Jiri Slaby wrote: > On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: > > On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: > >> On Mon, Nov 07, 2016 at 09:43:24AM +0100, Jiri Slaby wrote: > >>> Hi, > >>> > &

BUG: 'list_empty(>free_vbufs)' is true!

2016-11-15 Thread Gerd Hoffmann
On Di, 2016-11-15 at 09:55 +0100, Jiri Slaby wrote: > On 11/15/2016, 09:46 AM, Gerd Hoffmann wrote: > > On Fr, 2016-11-11 at 17:28 +0100, Jiri Slaby wrote: > >> On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: > >>> On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirki

BUG: 'list_empty(>free_vbufs)' is true!

2016-11-16 Thread Gerd Hoffmann
On Fr, 2016-11-11 at 17:28 +0100, Jiri Slaby wrote: > On 11/09/2016, 09:01 AM, Gerd Hoffmann wrote: > > On Di, 2016-11-08 at 22:37 +0200, Michael S. Tsirkin wrote: > >> On Mon, Nov 07, 2016 at 09:43:24AM +0100, Jiri Slaby wrote: > >>> Hi, > >>> > &

[PULL] drm-qemu for 4.10

2016-11-21 Thread Gerd Hoffmann
() return value qxl: Don't notify userspace when monitors config is unchanged qxl: Allow resolution which are not multiple of 8 Gerd Hoffmann (4): drm: re-export drm_dev_set_unique drm/virtio: fix busid regression Revert "drm: virtio: reinstate drm_virtio_set_

RfC: MAINTAINERS update for qemu drm drivers.

2016-11-21 Thread Gerd Hoffmann
Hi, I'm busy updating the MAINTAINERS file for the linux kernel, making sure I'm listed for all qemu drm drivers (cirrus, bochs, qxl, virtio), so patches land in my inbox. While being at it: I'm wondering whenever it makes sense to also include the qemu-devel list there. I think it would be

RfC: MAINTAINERS update for qemu drm drivers.

2016-11-21 Thread Gerd Hoffmann
Hi, > Also I think one shared git repo for all of them would be > good. Yep, I'm doing that (see today's drm-qemu pull req @ dri-devel). But, yes, I can place the git repo link in MAINTAINERS too. cheers, Gerd

[PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

2016-11-22 Thread Gerd Hoffmann
Changes: * add myself as maintainer, so patches land in my inbox. * add qemu-devel mailing list. * add drm-qemu git repo. * flip bochs and qxl status to "Maintained". Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 14 -- 1 file changed, 12 insertions(+), 2 deletion

[PATCH] drm: flip cirrus driver status to "obsolete".

2016-11-22 Thread Gerd Hoffmann
std, default in qemu 2.2+) - qxl (DRM_QXL, qemu -vga qxl, works best with spice) - virtio (VIRTIO_GPU), qemu -vga virtio) Signed-off-by: Gerd Hoffmann --- MAINTAINERS| 3 ++- drivers/gpu/drm/cirrus/Kconfig | 9 + 2 files changed, 11 insertions(+), 1 deletion

[Qemu-devel] [PATCH] drm: update MAINTAINERS for qemu drivers (bochs, cirrus, qxl, virtio-gpu)

2016-11-23 Thread Gerd Hoffmann
Hi, > >> +L:qemu-devel at nongnu.org > > qemu-devel list already has very high traffic - not sure whether it > makes much sense to route even more additional patches here. Maybe > rather create a separate mailing list like qemu-graphics at nongnu.org ? > So you've

virtio gpu sparse warning

2016-11-28 Thread Gerd Hoffmann
On Do, 2016-11-24 at 04:57 +0200, Michael S. Tsirkin wrote: > sparse produces these warnings: > > drivers/gpu/drm/virtio/virtgpu_fb.c:340:27: warning: incorrect type in > assignment (different address spaces) > drivers/gpu/drm/virtio/virtgpu_fb.c:340:27:expected char [noderef] > *screen_base

[PATCH] drm/virtio: fix framebuffer sparse warning

2016-11-28 Thread Gerd Hoffmann
virtio uses normal ram as backing storage for the framebuffer, so we should assign the address to new screen_buffer (added by commit 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base. Reported-by: Michael S. Tsirkin Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio

[PATCH RESEND 06/14] drm/virtio: use drm_crtc_send_vblank_event()

2016-06-07 Thread Gerd Hoffmann
On Mo, 2016-06-06 at 11:41 -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_send_vblank_event() with the new helper function. > > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- > 1 file changed, 1 insertion(+), 1

[PULL] virtio-vga updates

2016-06-07 Thread Gerd Hoffmann
changes up to 0062795e30697b825387a795b9c1791cc28a0a72: virtio-gpu: use src not crtc (2016-06-07 10:37:14 +0200) Gerd Hoffmann (6): virtio-gpu: fix output lookup virtio-gpu: add atomic_commit function virtio-gpu

[PATCH] drm/virtio: Don't reinvent a flipping wheel

2016-06-13 Thread Gerd Hoffmann
atomic implementation of virtio, as it should have been done!). > > > > v2: Rebased on top of > > > > commit e7cf0963f816fa44190caaf51aeffaa614c340c6 > > Author: Gerd Hoffmann > > Date: Tue May 31 08:50:47 2016 +0200 > > > > virtio-gpu: add a

[RESENT PATCH] drm/i915: use #defines for qemu subsystem ids

2016-06-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/i915/i915_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index f313b4d..3099390 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm

[RESENT PATCH] bochs: ignore device if there isn't enougth memory

2016-06-13 Thread Gerd Hoffmann
framebuffer. So skip the device and let vgacon or vesafb+fbcon handle the it. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index b332b4d3..6cf4b18

[PATCH] virtio-gpu: use src not crtc

2016-06-14 Thread Gerd Hoffmann
On Di, 2016-06-14 at 12:13 +0200, Marc-André Lureau wrote: > Hi > > On Tue, May 31, 2016 at 2:52 PM, Gerd Hoffmann wrote: > > Pick up the correct source rectangle from framebuffer. > > Without this multihead setups are not working correctly. > > > > Signed-off

[PATCH] drm/virtio: Don't reinvent a flipping wheel

2016-06-14 Thread Gerd Hoffmann
> >> Gerd, can you pls retest? I think due to your change in the above > >> referenced commit to switch to active_only=true in commit_planes() this is > >> now broken. > > > > Yes, probably it'll break things. > > > > Any branch I can test? Your "stuff" branch seems to not yet have the > > commit

[PATCH] drm/i915: refine qemu south bridge detection

2016-01-25 Thread Gerd Hoffmann
bsystem id to see whenever it *really* is qemu. Reported-by: Bjørn Mork Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/i915/i915_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 3ac616d..9668

[PATCH v2] drm/i915: refine qemu south bridge detection

2016-01-25 Thread Gerd Hoffmann
bsystem id to see whenever it *really* is qemu. [ v2: fix subvendor tyops ] Reported-by: Bjørn Mork Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/i915/i915_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_d

[PATCH] drm/i915: refine qemu south bridge detection

2016-01-25 Thread Gerd Hoffmann
Hi, > 0x1af4 != 0x1a4f Good catch, new patch sent. thanks, Gerd

[PATCH] PCI: QEMU top-level IDs for (sub)vendor & device

2016-01-29 Thread Gerd Hoffmann
On Mo, 2016-01-25 at 08:37 -0800, Robin H. Johnson wrote: > Introduce PCI_VENDOR/PCI_SUBVENDOR/PCI_SUBDEVICE defines to replace the > constants scattered in the kernel already used to detect QEMU. > > They are defined in the QEMU codebase per docs/specs/pci-ids.txt. Reviewed-by: G

[PATCH v2] drm/i915: refine qemu south bridge detection

2016-01-29 Thread Gerd Hoffmann
On Fr, 2016-01-29 at 09:59 +0200, Jani Nikula wrote: > On Mon, 25 Jan 2016, Gerd Hoffmann wrote: > > The test for the qemu q35 south bridge added by commit > > "39bfcd52 drm/i915: more virtual south bridge detection" > > also matches on real hardware. Having th

[PATCH] drm/i915: use #defines for qemu subsystem ids

2016-01-29 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- depends on http://mid.gmane.org/1453739846-3549-1-git-send-email-robbat2 at gentoo.org --- drivers/gpu/drm/i915/i915_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c

[RFC PATCH 0/3] staging: remove fbdev drivers

2016-12-13 Thread Gerd Hoffmann
Hi, > The acceleration that most of the 2D things provide isn't ever that > great, and shadowing is a lot more effective if done properly. That is probably true for anything pci-ish, because those devices are optimized for memory writes and reads are horribly slow. So you surely want avoid

[RFC PATCH 0/3] staging: remove fbdev drivers

2016-12-13 Thread Gerd Hoffmann
Hi, > Well, I had that argument with Dave Airlie which I CCed. The "dumb" ones like > bochsdrmfb, cirrusdrmfb, astdrmfb ... all use shadowing, meaning they use a > lot more memory and cannot do any 2D acceleration for fbcon. Well, at least for cirrusdrmfb using 2d accel is kida pointless as

[RFC 1/5] drm/virtio: add virtio_gpu_alloc_fence()

2016-12-13 Thread Gerd Hoffmann
Hi, > +struct virtio_gpu_fence *virtio_gpu_fence_alloc(struct virtio_gpu_device > *vgdev) > +{ > + struct virtio_gpu_fence_driver *drv = >fence_drv; > + struct virtio_gpu_fence *fence; > + unsigned long irq_flags; > + > + fence = kmalloc(sizeof(struct virtio_gpu_fence),

Passing multi-screen layout to KMS driver

2016-12-14 Thread Gerd Hoffmann
Hi, > So I would be interested to know whether anyone else has thought about > this problem, and possibly even about an interface to let the compositor > pass the information. If not, would people be open to the idea? I > would much rather have something generally agreed on than hack

[PATCH] bochs: ignore device if there isn't enougth memory

2016-05-11 Thread Gerd Hoffmann
framebuffer. So skip the device and let vgacon or vesafb+fbcon handle the it. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_drv.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c b/drivers/gpu/drm/bochs/bochs_drv.c index b332b4d3..6cf4b18

[PATCH] qxl: catch qxlfb_create_pinned_object failures

2016-05-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_fb.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_fb.c b/drivers/gpu/drm/qxl/qxl_fb.c index 7136e52..17c1ef0 100644 --- a/drivers/gpu/drm/qxl/qxl_fb.c +++ b/drivers/gpu/drm/qxl/qxl_fb.c @@ -360,6 +360,9

[PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-27 Thread Gerd Hoffmann
On Mi, 2016-05-25 at 18:37 +0200, Daniel Vetter wrote: > On Fri, Oct 2, 2015 at 1:58 PM, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > So I entirely missed this, but this isn't really how to implement > page_flip for an atomic driver. Working on some stuf

[PATCH] Add virtio gpu driver.

2016-05-27 Thread Gerd Hoffmann
Hi, > I guess I didn't do a good job at looking at your v2: Cursor is still > using legacy interfaces and not a proper plane. Would be awesome if > you could fix that up. Atomic drivers really shouldn't use the legacy > cursor interfaces any more at all. > -Daniel Figured that one for the most

[PATCH] virtio-gpu: fix output lookup

2016-05-30 Thread Gerd Hoffmann
Needed for multihead setups where we can have disabled outputs and therefore plane->crtc can be NULL. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_plane.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c

[PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-30 Thread Gerd Hoffmann
Hi, > > But I'll take you up on the implied offer to help out and test ;-) > > git://people.freedesktop.org/~danvet/drm stuff Tried that branch. > Would be really awesome if you could test this on virtio. Note that the > new nonblocking helpers require that your atomic backend gets the drm >

[PATCH] Add virtio gpu driver.

2016-05-30 Thread Gerd Hoffmann
Hi, > - add a small core function to registerr HOT_X/HOT_Y for a (cursor) plane, > e.g. drm_plane_register_hotspot(). That should allocate the properties > (if they don't exist yet) and then attach those props to the cursor. We > don't want those props everywhere, but only on drivers that

[PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-31 Thread Gerd Hoffmann
Hi, > > https://lists.freedesktop.org/archives/dri-devel/2016-May/108772.html > > Hm, smells more like virtio isn't too happy with the default ordering of > the commit operation. The default is: > > - Disable any crtc/encoders that need to be disabled/change. > - Bash new plane setup into hw.

[PATCH] Add virtio gpu driver.

2016-05-31 Thread Gerd Hoffmann
Hi, > > Why attach the hotspot to the plane? Wouldn't it make more sense to > > make it a framebuffer property? > > We don't have properties on the framebuffer. I guess you /could/ just add > it internally to struct drm_framebuffer, and not bother exposing to > userspace. I guess that would

[PATCH v3 7/7] [wip] virtio-gpu: add page flip support

2016-05-31 Thread Gerd Hoffmann
Hi, > > Right now the virtual outputs are linked to drm_crtc. To apply any > > changes I need to lookup the crtc to figure which virtual output should > > be updated. > > So, setting active_only should make sure I have a valid crtc pointer on > > plane updates, right? It probably also skips

[PATCH] qxl: apply limit to relocs_num in qxl_process_single_command

2016-02-16 Thread Gerd Hoffmann
: gnomes at lxorguk.ukuu.org.uk Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_ioctl.c b/drivers/gpu/drm/qxl/qxl_ioctl.c index 2ae8577..970cb83 100644 --- a/drivers/gpu/drm/qxl/qxl_ioctl.c +++ b/drivers

[PATCH v2] qxl: use kmalloc_array to alloc reloc_info in qxl_process_single_command

2016-02-16 Thread Gerd Hoffmann
This avoids integer overflows on 32bit machines when calculating reloc_info size, as reported by Alan Cox. Cc: stable at vger.kernel.org Cc: gnomes at lxorguk.ukuu.org.uk Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/qxl/qxl_ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion

[PATCH 0/8] drm/bochs: convert bochs to atomic mode-setting

2016-03-02 Thread Gerd Hoffmann
On Mi, 2016-03-02 at 10:13 +, Emil Velikov wrote: > [+Dave, +Gerd] > > Hi all, > > Just noticed that this old(ish) series never hit master. > > On 16 July 2015 at 13:20, John Hunter wrote: > > From: Zhao Junwang > > > > This patch series aim to convert DRM_BOCHS to atomic mode-setting. >

[PATCH 0/8] drm/bochs: convert bochs to atomic mode-setting

2016-03-03 Thread Gerd Hoffmann
Hi, > > Did testing a while back & reported back to John (not sure this was in > > public on the list as we had some ping-ping emails beforehand due to > > some problems of applying the patches). No new version of the series > > since. > > > The only comment that I can see is this one [1]

[PATCH 0/8] drm/bochs: convert bochs to atomic mode-setting

2016-03-07 Thread Gerd Hoffmann
Hi, > > Digged the mails up in the archive. > > > Silly me assumed that the MUA will bring up the the whole thread. If your mbox goes back that far ... I usually have a few months history in my mailbox folders which is enough in the vast majority of the cases where I have to check some past

[PATCH 2/2] bochs: add missing drm_connector_register call

2014-09-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/bochs/bochs_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c index 9d7346b..6b7efcf3 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs

[PATCH 1/2] cirrus: add missing drm_connector_register call

2014-09-19 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/cirrus/cirrus_mode.c b/drivers/gpu/drm/cirrus/cirrus_mode.c index e1c5c32..c7c5a9d 100644 --- a/drivers/gpu/drm/cirrus/cirrus_mode.c +++ b/drivers/gpu/drm

[PATCH 1/2] cirrus: add missing drm_connector_register call

2014-09-19 Thread Gerd Hoffmann
On Fr, 2014-09-19 at 10:37 +0200, David Herrmann wrote: > Hi > > On Fri, Sep 19, 2014 at 10:11 AM, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > drivers/gpu/drm/cirrus/cirrus_mode.c | 1 + > > 1 file changed, 1 insertion(+) > >

[PATCH v2 0/4] Add virtio gpu driver.

2015-04-01 Thread Gerd Hoffmann
, for now the bits just have been splitted into a separate patch so they are easier to spot and don't confuse when reviewing the main parts of the driver. * properly handle page flip. cheers, Gerd Dave Airlie (1): Add virtio gpu driver. Gerd Hoffmann (3): break kconfig dependency loop

  1   2   3   4   5   6   7   8   9   10   >