Re: [RFC v1 PATCH 3/3] driver: update all the code that use soc_device_match

2021-04-19 Thread Guenter Roeck
On 4/18/21 9:27 PM, Alice Guo (OSS) wrote: > From: Alice Guo > > Update all the code that use soc_device_match because add support for > soc_device_match returning -EPROBE_DEFER. > > Signed-off-by: Alice Guo > --- [ ... ] > drivers/watchdog/renesas_wdt.c| 2 +- > 48 files chan

[PATCH] drm/amd/display: Fix build warnings

2021-04-21 Thread Guenter Roeck
other iterators which don't require the unused variables. Fixes: 8ad278062de4e ("drm/amd/display: Disable cursors before disabling planes") Fixes: 29b9ba74f6384 ("drm/amd/display: Recalculate VCPI slots for new DSC connectors") Signed-off-by: Guenter Roeck --- drivers/gpu/

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-08-23 Thread Guenter Roeck
On Tue, Jul 27, 2021 at 02:10:37PM +0200, Daniel Vetter wrote: > The module init code is somewhat misplaced in i915_pci.c, since it > needs to pull in init/exit functions from every part of the driver and > pollutes the include list a lot. > > Extract an i915_module.c file which pulls all the bits

Re: [PATCH v15 10/12] swiotlb: Add restricted DMA pool initialization

2021-08-24 Thread Guenter Roeck
Hi Claire, On Thu, Jun 24, 2021 at 11:55:24PM +0800, Claire Chang wrote: > Add the initialization function to create restricted DMA pools from > matching reserved-memory nodes. > > Regardless of swiotlb setting, the restricted DMA pool is preferred if > available. > > The restricted DMA pools pr

Re: [PATCH v3 4/5] amba: Make the remove callback return void

2021-01-27 Thread Guenter Roeck
rokhov > Acked-by: Krzysztof Kozlowski # for drivers/memory > Acked-by: Mark Brown > Acked-by: Dmitry Torokhov > Acked-by: Linus Walleij > Signed-off-by: Uwe Kleine-König For watchdog: Acked-by: Guenter Roeck Guenter > --- > drivers/amba/bus.c

Re: [PATCH] drm/msm: remove unneeded variable: "rc"

2021-02-03 Thread Guenter Roeck
On Tue, Feb 2, 2021 at 4:32 AM Bernard Zhao wrote: > > remove unneeded variable: "rc". > > Signed-off-by: Bernard Zhao Reviewed-by: Guenter Roeck > > --- > drivers/gpu/drm/msm/dp/dp_panel.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [PATCH v6 2/8] drm/mediatek: add component POSTMASK

2021-02-09 Thread Guenter Roeck
On Tue, Feb 02, 2021 at 04:12:31PM +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add component POSTMASK. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > Reviewed-by: CK Hu > --- [ ... ] > > +void mtk_postmask_config(struct device *dev, unsigned int w, sta

[PATCH] fbmem: Mark proc_fb_seq_ops as __maybe_unused

2021-05-04 Thread Guenter Roeck
With CONFIG_PROC_FS=n and -Werror, 0-day reports: drivers/video/fbdev/core/fbmem.c:736:36: error: 'proc_fb_seq_ops' defined but not used Mark it as __maybe_unused. Reported-by: kernel test robot Signed-off-by: Guenter Roeck --- drivers/video/fbdev/core/fbmem.c | 2 +- 1 fi

[PATCH] drm: Declare drm_send_event_helper static

2021-05-04 Thread Guenter Roeck
0-day reports: drivers/gpu/drm/drm_file.c:789:6: error: no previous prototype for 'drm_send_event_helper' Since drm_send_event_helper() is only used locally, declare it static to fix the problem. Reported-by: kernel test robot Signed-off-by: Guenter Roeck --- drive

Re: [PATCH] fbmem: Correct position of '__maybe_unused' in proc_fb_seq_ops

2021-05-05 Thread Guenter Roeck
q_file.h:31:8: note: previous definition is here > struct seq_operations { > ^ > 1 warning generated. > > The attribute should not split the type 'struct seq_operations'. Move it > before the struct keyword so that it works properly and there is no more >

Re: [git pull] drm fixes round two for 5.13-rc1

2021-05-09 Thread Guenter Roeck
On 5/9/21 2:08 PM, Linus Torvalds wrote: On Sun, May 9, 2021 at 11:16 AM Dave Airlie wrote: Bit later than usual, I queued them all up on Friday then promptly forgot to write the pull request email. This is mainly amdgpu fixes, with some radeon/msm/fbdev and one i915 gvt fix thrown in. Hmm.

Re: [PATCH v2] drm: Declare drm_send_event_helper static.

2021-05-10 Thread Guenter Roeck
On Mon, May 10, 2021 at 06:46:16PM +0530, Rajat Asthana wrote: > Declare drm_send_event_helper as static to fix sparse warning: > > > warning: symbol 'drm_send_event_helper' was not declared. > > Should it be static? > > Signed-off-by: Rajat Asthana > --- > Changes in v2: > Provide full name

Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool

2021-07-01 Thread Guenter Roeck
Hi, On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote: > If a device is not behind an IOMMU, we look up the device node and set > up the restricted DMA when the restricted-dma-pool is presented. > > Signed-off-by: Claire Chang > Tested-by: Stefano Stabellini > Tested-by: Will Deacon

Re: [PATCH v15 12/12] of: Add plumbing for restricted DMA pool

2021-07-02 Thread Guenter Roeck
On 7/2/21 6:18 AM, Will Deacon wrote: On Fri, Jul 02, 2021 at 12:39:41PM +0100, Robin Murphy wrote: On 2021-07-02 04:08, Guenter Roeck wrote: On Thu, Jun 24, 2021 at 11:55:26PM +0800, Claire Chang wrote: If a device is not behind an IOMMU, we look up the device node and set up the restricted

Re: [git pull] drm for 5.18-rc1

2022-03-24 Thread Guenter Roeck
Hi, On Thu, Mar 24, 2022 at 12:30:02PM +1000, Dave Airlie wrote: > Hi Linus, > > This is the main drm pull request for 5.18. > > The summary changelog is below, lots of work all over, > Intel improving DG2 support, amdkfd CRIU support, msm > new hw support, and faster fbdev support. > > Conflic

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Guenter Roeck
Hi, On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: > Improve the performance of cfb_imageblit() by manually unrolling > the inner blitting loop and moving some invariants out. The compiler > failed to do this automatically. This change keeps cfb_imageblit() > in sync with sys_i

Re: [2/2] fbdev: Fix cfb_imageblit() for arbitrary image widths

2022-03-24 Thread Guenter Roeck
> Cc: Javier Martinez Canillas > Cc: Sam Ravnborg > Tested-by: Marek Szyprowski > Acked-by: Daniel Vetter > Reviewed-by: Javier Martinez Canillas Tested-by: Guenter Roeck > --- > drivers/video/fbdev/core/cfbimgblt.c | 28 > 1 file chang

Re: [PATCH v3 4/5] fbdev: Improve performance of cfb_imageblit()

2022-03-24 Thread Guenter Roeck
On 3/24/22 12:18, Thomas Zimmermann wrote: Hi Am 24.03.22 um 20:11 schrieb Guenter Roeck: Hi, On Wed, Feb 23, 2022 at 08:38:03PM +0100, Thomas Zimmermann wrote: Improve the performance of cfb_imageblit() by manually unrolling the inner blitting loop and moving some invariants out. The

Re: [PATCH] drm/selftest: plane_helper: Put test structures in static storage

2022-03-25 Thread Guenter Roeck
igt_check_plane_state to make the > test more robust") > Link: https://github.com/ClangBuiltLinux/linux/issues/1600 > Reported-by: kernel test robot > Suggested-by: Nick Desaulniers > Signed-off-by: Nathan Chancellor > Reviewed-by: Nick Desaulniers Tested-by: Guenter Roeck

Re: [PATCH] device: fix missing check on list iterator

2022-03-26 Thread Guenter Roeck
On 3/26/22 22:31, Xiaomeng Tong wrote: The bug is here: lo = pstate->base.domain[domain->name]; The list iterator 'pstate' will point to a bogus position containing HEAD if the list is empty or no element is found. This case should be checked before any use of the iterator, otherwise it

Re: [PATCH] device: fix missing check on list iterator

2022-03-27 Thread Guenter Roeck
On 3/26/22 23:59, Xiaomeng Tong wrote: On Sat, 26 Mar 2022 22:38:05 -0700, Guenter Roeck wrote: @@ -103,11 +103,16 @@ nvkm_control_mthd_pstate_attr(struct nvkm_control *ctrl, void *data, u32 size) return -EINVAL; if (args->v0.st

Re: [PATCH] drm: Fix no previous prototype error in drm_nomodeset.c

2022-03-02 Thread Guenter Roeck
gt; drm_firmware_drivers_only's declaration. > > Signed-off-by: Aashish Sharma Reviewed-by: Guenter Roeck > --- > drivers/gpu/drm/drm_nomodeset.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/drm_nomodeset.c b/drivers/gpu/drm/drm_nomodeset.c

[PATCH] drm/nouveau/nvkm: Replace -ENOSYS with -ENODEV

2021-09-08 Thread Guenter Roeck
not passed to userspace - it just has to be negative. Fixes: 7238eca4cf18 ("drm/nouveau: expose pstate selection per-power source in sysfs") Signed-off-by: Guenter Roeck --- drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

Re: [PATCH] dt-bindings: More use 'enum' instead of 'oneOf' plus 'const' entries

2021-09-10 Thread Guenter Roeck
On 9/10/21 9:51 AM, Rob Herring wrote: 'enum' is equivalent to 'oneOf' with a list of 'const' entries, but 'enum' is more concise and yields better error messages. Fix a couple more cases which have appeared. Cc: Rob Clark Cc: Sean Paul Cc: Mark Brown

Re: [PATCH 4/9] drm/i915/dmabuf: add paranoid flush-on-acquire

2021-10-26 Thread Guenter Roeck
On Mon, Oct 18, 2021 at 06:45:03PM +0100, Matthew Auld wrote: > As pointed out by Thomas, we likely need to flush the pages here if the > GPU can read the page contents directly from main memory. Underneath we > don't know what the sg_table is pointing to, so just add a > wbinvd_on_all_cpus() here,

Re: [PATCH] drm/amdgpu: fix out of bounds write

2021-10-27 Thread Guenter Roeck
On Wed, Oct 13, 2021 at 04:04:13PM -0400, Thelford Williams wrote: > Size can be any value and is user controlled resulting in overwriting the > 40 byte array wr_buf with an arbitrary length of data from buf. > > Signed-off-by: Thelford Williams > Signed-off-by: Alex Deucher The fix works, but

Re: [PATCH] drm/amdgpu: fix out of bounds write

2021-10-27 Thread Guenter Roeck
On 10/27/21 8:22 AM, Harry Wentland wrote: On 2021-10-27 10:39, Guenter Roeck wrote: On Wed, Oct 13, 2021 at 04:04:13PM -0400, Thelford Williams wrote: Size can be any value and is user controlled resulting in overwriting the 40 byte array wr_buf with an arbitrary length of data from buf

Re: [PATCH] drm/bridge: anx7625: Fix edid_read break case in sp_tx_edid_read()

2021-11-18 Thread Guenter Roeck
On Fri, Nov 12, 2021 at 07:24:33PM +0800, Hsin-Yi Wang wrote: > edid_read() was assumed to return 0 on success. After > 7f16d0f3b8e2("drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()"), > the function can return >= 0 for successful case. Fix the g_edid_break > condition in sp_tx_edid_read

Re: [PATCH v7 2/5] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation

2020-12-16 Thread Guenter Roeck
On Sat, Nov 21, 2020 at 11:49:59PM +, John Stultz wrote: > Since the heap-helpers logic ended up not being as generic as > hoped, move the heap-helpers dma_buf_ops implementations into > the cma_heap directly. > > This will allow us to remove the heap_helpers code in a following > patch. > m

Re: [patch 02/30] genirq: Move status flag checks to core

2020-12-28 Thread Guenter Roeck
On Thu, Dec 10, 2020 at 08:25:38PM +0100, Thomas Gleixner wrote: > These checks are used by modules and prevent the removal of the export of > irq_to_desc(). Move the accessor into the core. > > Signed-off-by: Thomas Gleixner Yes, but that means that irq_check_status_bit() may be called from mod

Re: [RFC 01/32] Kconfig: introduce and depend on LEGACY_PCI

2021-12-27 Thread Guenter Roeck
On 12/27/21 8:42 AM, Niklas Schnelle wrote: Introduce a new LEGACY_PCI Kconfig option which gates support for legacy PCI devices including those attached to a PCI-to-PCI Express bridge and PCI Express devices using legacy I/O spaces. Note that this is different from non PCI uses of I/O ports such

[PATCH] drm/pl111: Initialize clock spinlock early

2019-05-13 Thread Guenter Roeck
clock divider"), the spinlock is not initialized if the clock divider is broken. Initialize it earlier to fix the problem. Fixes: eedd6033b4c8 ("drm/pl111: Support variants with broken clock divider") Cc: Linus Walleij Signed-off-by: Guenter Roeck --- drivers/gpu/drm/pl111/pl111_display

Re: [PATCH] drm/pl111: Initialize clock spinlock early

2019-05-14 Thread Guenter Roeck
On 5/14/19 3:20 PM, Linus Walleij wrote: On Mon, May 13, 2019 at 4:46 PM Guenter Roeck wrote: The following warning is seen on systems with broken clock divider. INFO: trying to register non-static key. the code is fine but needs lockdep annotation. turning off the locking correctness

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2019-01-22 Thread Guenter Roeck
On 1/21/19 7:17 AM, Vincent Guittot wrote: On Fri, 18 Jan 2019 at 13:08, Guenter Roeck wrote: On 1/18/19 3:05 AM, Rafael J. Wysocki wrote: On Fri, Jan 18, 2019 at 11:53 AM Vincent Guittot wrote: On Fri, 18 Jan 2019 at 11:42, Vincent Guittot wrote: Hi Guenter, Le Thursday 17 Jan 2019 à

Re: [PATCH] drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-01-30 Thread Guenter Roeck
; > Reported-by: Matthias Kaehlcke > > > Suggested-by: James Y Knight > > > Suggested-by: Nathan Chancellor > > > Signed-off-by: Nick Desaulniers > > > Tested-by: Guenter Roeck > > > > Reviewed-by: Harry Wentland > > > > and app

Re: [PATCH] qcom-scm: Include header

2019-01-07 Thread Guenter Roeck
header file to fix this problem. > > Reported-by: kernelci.org bot > Fixes: e6f6d63ed14c ("drm/msm: add headless gpu device for imx5") > Signed-off-by: Fabio Estevam > Reviewed-by: Bjorn Andersson Tested-by: Guenter Roeck Still broken upstream, and the commit

Re: [PATCH v5 3/3] PM/runtime:Replace jiffies based accounting with ktime based accounting

2019-01-18 Thread Guenter Roeck
On Fri, Dec 21, 2018 at 11:33:56AM +0100, Vincent Guittot wrote: > From: Thara Gopinath > > This patch replaces jiffies based accounting for runtime_active_time > and runtime_suspended_time with ktime base accounting. This makes the > runtime debug counters inline with genpd and other pm subsytem

Re: [v3 6/7] drm/mediatek: change the dsi phytiming calculate method

2019-06-03 Thread Guenter Roeck
On Sun, May 19, 2019 at 05:25:36PM +0800, Jitao Shi wrote: > Change the method of frame rate calc which can get more accurate > frame rate. > > data rate = pixel_clock * bit_per_pixel / lanes > Adjust hfp_wc to adapt the additional phy_data > > if MIPI_DSI_MODE_VIDEO_BURST > hfp_wc = hfp *

Re: [PATCH 09/11] hwmon: Drop obsolete JZ4740 driver

2019-07-25 Thread Guenter Roeck
On Thu, Jul 25, 2019 at 06:02:13PM -0400, Paul Cercueil wrote: > The JZ4740 boards now use the iio-hwmon driver. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek Acked-by: Guenter Roeck > --- > drivers/hwmon/Kconfig| 10 --- > drivers/hwmon

[PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-18 Thread Guenter Roeck
h lack the selection of hard-float. Fixes: 41b7a347bf14 ("powerpc: Book3S 64-bit outline-only KASAN support") Cc: Michael Ellerman Cc: Daniel Axtens Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/display/dc/dcn31/Makefile | 4 drivers/gpu/drm/amd/display/dc/dcn315/Makefile |

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-21 Thread Guenter Roeck
On Mon, Jun 20, 2022 at 05:51:04PM -0400, Alex Deucher wrote: > On Sat, Jun 18, 2022 at 7:27 PM Guenter Roeck wrote: > > > > ppc:allmodconfig builds fail with the following error. > > > > powerpc64-linux-ld: > > drivers/gpu/drm/amd/amdgpu/../

Re: [PATCH v5] fbdev: fbmem: Fix the implicit type casting

2022-02-02 Thread Guenter Roeck
On 2/2/22 15:33, Yizhuo Zhai wrote: In function do_fb_ioctl(), the "arg" is the type of unsigned long, and in "case FBIOBLANK:" this argument is casted into an int before passig to fb_blank(). In fb_blank(), the comparision if (blank > FB_BLANK_POWERDOWN) would be bypass if the original "arg" is

Re: [PATCH v6] fbdev: fbmem: Fix the implicit type casting

2022-02-02 Thread Guenter Roeck
k > FB_BLANK_POWERDOWN) would be bypass if the original > "arg" is a large number, which is possible because it comes from > the user input. Fix this by adding the check before the function > call. > > Signed-off-by: Yizhuo Zhai Reviewed-by: Guenter Roeck On a side n

Re: [PATCH 09/48] watchdog: sa1100: use platform device registration

2022-04-19 Thread Guenter Roeck
On 4/19/22 09:37, Arnd Bergmann wrote: From: Arnd Bergmann Rather than relying on machine specific headers to pass down the reboot status and the register locations, use resources and platform_data. Aside from this, keep the changes to a minimum. Cc: Wim Van Sebroeck Cc: Guenter Roeck Cc

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-22 Thread Guenter Roeck
On Tue, Apr 19, 2022 at 06:37:22PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > This revisits a series I sent a few years ago: > > https://lore.kernel.org/lkml/20191018154052.1276506-1-a...@arndb.de/ > > All the other ARMv5 conversions are under way now, with > OMAP1 being the only one

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-22 Thread Guenter Roeck
On 4/22/22 12:16, Arnd Bergmann wrote: On Fri, Apr 22, 2022 at 7:05 PM Guenter Roeck wrote: On Tue, Apr 19, 2022 at 06:37:22PM +0200, Arnd Bergmann wrote: From: Arnd Bergmann This revisits a series I sent a few years ago: https://lore.kernel.org/lkml/20191018154052.1276506-1-a...@arndb.de

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-22 Thread Guenter Roeck
On Sat, Apr 23, 2022 at 12:04:31AM +0200, Arnd Bergmann wrote: > On Fri, Apr 22, 2022 at 10:55 PM Guenter Roeck wrote: > > On 4/22/22 12:16, Arnd Bergmann wrote: > > > On Fri, Apr 22, 2022 at 7:05 PM Guenter Roeck wrote: > > > > > > Which machine did you hi

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-22 Thread Guenter Roeck
On Sat, Apr 23, 2022 at 12:04:31AM +0200, Arnd Bergmann wrote: > On Fri, Apr 22, 2022 at 10:55 PM Guenter Roeck wrote: > > On 4/22/22 12:16, Arnd Bergmann wrote: > > > On Fri, Apr 22, 2022 at 7:05 PM Guenter Roeck wrote: > > > > > > Which machine did you hi

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-23 Thread Guenter Roeck
On 4/23/22 12:55, Arnd Bergmann wrote: On Sat, Apr 23, 2022 at 1:41 AM Guenter Roeck wrote: On Sat, Apr 23, 2022 at 12:04:31AM +0200, Arnd Bergmann wrote: On Fri, Apr 22, 2022 at 10:55 PM Guenter Roeck wrote: On 4/22/22 12:16, Arnd Bergmann wrote: On Fri, Apr 22, 2022 at 7:05 PM Guenter

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-24 Thread Guenter Roeck
On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: On 4/23/22 12:55, Arnd Bergmann wrote: On Sat, Apr 23, 2022 at 1:41 AM Guenter Roeck wrote: On Sat, Apr 23, 2022 at 12:04:31AM +0200, Arnd Bergmann wrote: Odd, I can't reproduce this at all. D

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-28 Thread Guenter Roeck
On 4/28/22 06:44, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: into the defconfig file, otherwise the multiplatform

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Guenter Roeck
On 4/28/22 06:44, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: into the defconfig file, otherwise the multiplatform

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Guenter Roeck
On 4/29/22 10:48, Guenter Roeck wrote: On 4/28/22 06:44, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 8:48 PM Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 5:28 PM Guenter Roeck wrote: On 4/24/22 01:52, Arnd Bergmann wrote: On Sun, Apr 24, 2022 at 4:09 AM Guenter Roeck wrote: into the

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-29 Thread Guenter Roeck
On 4/29/22 14:46, Arnd Bergmann wrote: On Fri, Apr 29, 2022 at 10:23 PM Guenter Roeck wrote: On 4/29/22 10:48, Guenter Roeck wrote: I tried the pxa-multiplatform-5.18 branch. Its failures match those in v5.18-rc1. Uuh, wait, the build wasn't complete. There are still some failures.

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-04-30 Thread Guenter Roeck
On 4/30/22 01:04, Arnd Bergmann wrote: On Sat, Apr 30, 2022 at 1:09 AM Guenter Roeck wrote: On 4/29/22 14:46, Arnd Bergmann wrote: On Fri, Apr 29, 2022 at 10:23 PM Guenter Roeck wrote: On 4/29/22 10:48, Guenter Roeck wrote: I tried the pxa-multiplatform-5.18 branch. Its failures match

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Guenter Roeck
On 4/30/22 07:23, Arnd Bergmann wrote: On Sat, Apr 30, 2022 at 3:32 PM Arnd Bergmann wrote: On Sat, Apr 30, 2022 at 2:41 PM Guenter Roeck wrote: On 4/30/22 01:04, Arnd Bergmann wrote: and concluded that it must have done this for a long time. In my own qemu instance, I see a crash from

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Guenter Roeck
On 5/2/22 12:21, Arnd Bergmann wrote: On Mon, May 2, 2022 at 6:26 PM Guenter Roeck wrote: With v5.18-rc1-49-gcb813018b5c1, I still get: [0.797668] RAMDISK: Couldn't find valid RAM disk image starting at 0. [0.805262] /dev/root: Can't open blockdev [0.805487] VFS: Cannot

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-02 Thread Guenter Roeck
On 5/2/22 14:03, Arnd Bergmann wrote: On Mon, May 2, 2022 at 10:35 PM Guenter Roeck wrote: On 5/2/22 12:21, Arnd Bergmann wrote: To boot from initrd: qemu-system-arm -M z2 -kernel \ arch/arm/boot/zImage -no-reboot -initrd \ rootfs-armv5.cpio --append \ "pan

Re: [PATCH v2 00/48] ARM: PXA multiplatform support

2022-05-03 Thread Guenter Roeck
On 5/3/22 00:17, Arnd Bergmann wrote: On Tue, May 3, 2022 at 4:55 AM Guenter Roeck wrote: On 5/2/22 14:03, Arnd Bergmann wrote: On Mon, May 2, 2022 at 10:35 PM Guenter Roeck wrote: On 5/2/22 12:21, Arnd Bergmann wrote: qemu puts initrd in the middle of available memory. With the image

Re: [PATCH v5 7/7] fbdev: Make registered_fb[] private to fbmem.c

2022-05-11 Thread Guenter Roeck
: Sam Ravnborg Cc: Tetsuo Handa Cc: Zhen Lei Cc: Alex Deucher Cc: Xiyu Yang Cc: linux-fb...@vger.kernel.org Cc: Zheyu Ma Cc: Guenter Roeck Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/video/fbdev/core/fbmem.c | 8 ++-- include/linux/fb.h | 7

Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-16 Thread Guenter Roeck
On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > During a patch discussion, Linus brought up the option of changing > the C standard version from gnu89 to gnu99, which allows using variable > declaration inside of a for() loop. While the C99, C11 and later

Re: [greybus-dev] Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-16 Thread Guenter Roeck
On 5/16/22 06:31, Greg KH wrote: On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote: On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: From: Arnd Bergmann During a patch discussion, Linus brought up the option of changing the C standard version from gnu89 to gnu99

Re: [greybus-dev] Re: [PATCH] [v2] Kbuild: move to -std=gnu11

2022-05-18 Thread Guenter Roeck
On 5/18/22 00:46, Arnd Bergmann wrote: On Mon, May 16, 2022 at 3:19 PM Guenter Roeck wrote: On 5/16/22 06:31, Greg KH wrote: On Mon, May 16, 2022 at 06:10:23AM -0700, Guenter Roeck wrote: On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote: From: Arnd Bergmann During a patch

Re: [linux-next:master] BUILD REGRESSION 736ee37e2e8eed7fe48d0a37ee5a709514d478b3

2022-05-18 Thread Guenter Roeck
On 5/18/22 17:55, kernel test robot wrote: tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 736ee37e2e8eed7fe48d0a37ee5a709514d478b3 Add linux-next specific files for 20220518 Error/Warning reports: https://lore.kernel.org/linux-mm/20220429

Re: [PATCH] drm/msm/adreno: Do not propagate void return values

2022-05-20 Thread Guenter Roeck
On 5/20/22 05:53, Geert Uytterhoeven wrote: With sparse ("make C=2"), lots of error: return expression in void function messages are seen. Fix this by removing the return statements to propagate void return values. Signed-off-by: Geert Uytterhoeven Reviewed-by: Gue

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-30 Thread Guenter Roeck
On 6/30/22 14:01, Rodrigo Siqueira Jordao wrote: On 2022-06-18 19:27, Guenter Roeck wrote: ppc:allmodconfig builds fail with the following error. powerpc64-linux-ld: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o     uses hard float, drivers/gpu/drm/amd/amdgpu

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-06-30 Thread Guenter Roeck
On Thu, Jun 30, 2022 at 05:01:01PM -0400, Rodrigo Siqueira Jordao wrote: > > > On 2022-06-18 19:27, Guenter Roeck wrote: > > ppc:allmodconfig builds fail with the following error. > > > > powerpc64-linux-ld: > > drivers/gpu/drm/amd/amdgpu/../

Re: [linux-next:master] BUILD REGRESSION 088b9c375534d905a4d337c78db3b3bfbb52c4a0

2022-07-07 Thread Guenter Roeck
On Thu, Jul 07, 2022 at 10:08:33AM +0200, Greg KH wrote: [ ... ] > > > > Unverified Error/Warning (likely false positive, please contact us if > > interested): > > > > arch/x86/events/core.c:2114 init_hw_perf_events() warn: missing error code > > 'err' > > drivers/android/binder.c:1481:19-23:

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Guenter Roeck
On 9/5/22 04:09, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov wrote: I would like to stop exporting OF-specific devm_gpiod_get_from_of_node() so that gpiolib can be cleaned a bit, so let's switch to the generic fwnode property API. While at it switch the rest of the c

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Guenter Roeck
On 9/5/22 08:21, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 6:13 PM Guenter Roeck wrote: On 9/5/22 04:09, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 9:33 AM Dmitry Torokhov wrote: ... + count = device_property_count_u32(dev->parent, "rohm,hw-timeout-ms"); +

Re: [PATCH v1 04/11] usb: phy: tegra: switch to using devm_gpiod_get()

2022-09-05 Thread Guenter Roeck
On 9/5/22 12:55, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 10:51 PM Dmitry Torokhov wrote: On Mon, Sep 05, 2022 at 10:41:40PM +0300, Andy Shevchenko wrote: On Mon, Sep 5, 2022 at 10:40 PM Dmitry Torokhov wrote: On Mon, Sep 05, 2022 at 01:59:44PM +0300, Andy Shevchenko wrote: On Mon, Sep

Re: [PATCH v1 10/11] watchdog: bd9576_wdt: switch to using devm_fwnode_gpiod_get()

2022-09-05 Thread Guenter Roeck
ce is not critical, but I'm obviously satisfied with how the code looks now, or I would not have sent it. Good point. Reviewed-by: Guenter Roeck

Re: [PATCH 0/7] Add HWMON support

2022-09-26 Thread Guenter Roeck
On 9/26/22 10:52, Badal Nilawar wrote: This series adds the HWMON support for DGFX Test-with: 20220919144408.251981-1-riana.ta...@intel.com v2: - Reorganized series. Created first patch as infrastructure patch followed by feature patches. (Ashutosh) - Fixed review comments (Jani)

[PATCH] drm/amd/display: Enable building new display engine with KCOV enabled

2022-07-12 Thread Guenter Roeck
ay: Don't build DCN1 when kcov is enabled") Cc: Arnd Bergmann Cc: Leo Li Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/display/Kconfig | 2 +- drivers/gpu/drm/amd/display/dc/Makefile | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-13 Thread Guenter Roeck
On 7/13/22 13:57, Alex Deucher wrote: On Thu, Jun 30, 2022 at 5:01 PM Rodrigo Siqueira Jordao wrote: On 2022-06-18 19:27, Guenter Roeck wrote: ppc:allmodconfig builds fail with the following error. powerpc64-linux-ld: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/display_mode_lib.o

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-13 Thread Guenter Roeck
On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: [ ... ] > > The problem is not the FPU operations, but the fact that soft-float > > and hard-float compiled code is linked together. The soft-float and > > hard-float ABIs on powerpc are not compatible, so one ends up with > > an object

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-13 Thread Guenter Roeck
On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: > > > > The problem is not the FPU operations, but the fact that soft-float > > and hard-float compiled code is linked together. The soft-float and > > hard-float ABIs on powerpc are not compatible, so one ends up with > > an object file

Re: [PATCH] drm/amd/display: Enable building new display engine with KCOV enabled

2022-07-14 Thread Guenter Roeck
On 7/14/22 09:29, Alex Deucher wrote: Applied. Thanks! On Wed, Jul 13, 2022 at 4:03 PM Harry Wentland wrote: On 2022-07-12 18:42, Guenter Roeck wrote: The new display engine uses floating point math, which is not supported by KCOV. Commit 9d1d02ff3678 ("drm/amd/display: Don't

Re: [PATCH] drm/amd/display: Add missing hard-float compile flags for PPC64 builds

2022-07-14 Thread Guenter Roeck
On 7/14/22 11:49, Melissa Wen wrote: O 07/13, Alex Deucher wrote: On Wed, Jul 13, 2022 at 7:09 PM Guenter Roeck wrote: On Wed, Jul 13, 2022 at 05:20:40PM -0400, Alex Deucher wrote: The problem is not the FPU operations, but the fact that soft-float and hard-float compiled code is linked

Re: [PATCH v5 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-14 Thread Guenter Roeck
On Fri, Jul 08, 2022 at 05:30:47PM -0300, Maíra Canal wrote: > Considering the current adoption of the KUnit framework, convert the > DRM format selftest to the KUnit API. > > Tested-by: David Gow > Acked-by: Daniel Latypov > Reviewed-by: Javier Martinez Canillas > Signed-off-by: Maíra Canal

Re: [PATCH v5 4/9] drm: selftest: convert drm_format selftest to KUnit

2022-07-14 Thread Guenter Roeck
On Thu, Jul 14, 2022 at 04:51:40PM -0700, Guenter Roeck wrote: > On Fri, Jul 08, 2022 at 05:30:47PM -0300, Maíra Canal wrote: > > Considering the current adoption of the KUnit framework, convert the > > DRM format selftest to the KUnit API. > > > > Tested-by: Davi

Re: [v3] drm/i915/ttm: fix sg_table construction

2022-07-16 Thread Guenter Roeck
On Mon, Jul 11, 2022 at 09:58:59AM +0100, Matthew Auld wrote: > If we encounter some monster sized local-memory page that exceeds the > maximum sg length (UINT32_MAX), ensure that don't end up with some > misaligned address in the entry that follows, leading to fireworks > later. Also ensure we hav

[PATCH] drm/i915: Fix 32-bit build

2022-07-17 Thread Guenter Roeck
__udivdi3' Fix the problem by using DIV_ROUND_UP_ULL() instead of DIV_ROUND_UP(). Fixes: aff1e0b09b54 ("drm/i915/ttm: fix sg_table construction") Cc: Matthew Auld Cc: Nirmoy Das Cc: Rodrigo Vivi Signed-off-by: Guenter Roeck --- I took a stab at the problem. Please ignore the nois

Re: [PATCH] drm/tests: Split up test cases in igt_check_drm_format_min_pitch

2022-07-17 Thread Guenter Roeck
into three smaller functions: one testing single plane formats, one testing multiple planes formats, and the other testing tiled formats. Reported-by: kernel test robot Reported-by: Guenter Roeck Signed-off-by: Maíra Canal I applied the patch to next-20220714 (the fixed file is gone in next-202

Re: [PATCH v6 08/13] usb: typec: tcpci_mt6370: Add MediaTek MT6370 tcpci driver

2022-07-22 Thread Guenter Roeck
iver, a backlight WLED driver, a display bias driver and a general LDO for portable devices. Add support for the Type-C & Power Delivery controller in MediaTek MT6370 IC. Signed-off-by: ChiYuan Huang Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Guenter Roeck --- v6 - Convert

Re: Stack-frame warnings in display_mode_vba_32.c

2022-07-30 Thread Guenter Roeck
On 7/29/22 22:12, Paul E. McKenney wrote: On Fri, Jul 29, 2022 at 11:41:55PM -0300, André Almeida wrote: Hi Paul, Às 23:25 de 29/07/22, Paul E. McKenney escreveu: Hello! I am seeing the following in allmodconfig builds of recent -next on x86: drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn3

Re: [v5,3/3] drm/i915: Add support for integrated privacy screens

2020-01-25 Thread Guenter Roeck
On Fri, Dec 20, 2019 at 12:03:53PM -0800, Rajat Jain wrote: > Certain laptops now come with panels that have integrated privacy > screens on them. This patch adds support for such panels by adding > a privacy-screen property to the intel_connector for the panel, that > the userspace can then use to

Re: [PATCH v2 2/2] drm/bridge: add it6505 driver

2019-09-13 Thread Guenter Roeck
Hi, On Tue, Sep 03, 2019 at 06:51:54PM +0800, allen wrote: > From: Allen Chen > > This adds support for the iTE IT6505. > This device can convert DPI signal to DP output. > > Signed-off-by: Jitao Shi > Signed-off-by: Yilun Lin > Signed-off-by: Allen Chen I tried to provide feedback on this

[PATCH] drm/dp_mst: Fix build on systems with STACKTRACE_SUPPORT=n

2019-12-03 Thread Guenter Roeck
0x11c): undefined reference to `save_stack_trace' Add the missing deendency on STACKTRACE_SUPPORT. Fixes: 12a280c72868 ("drm/dp_mst: Add topology ref history tracking for debugging") Cc: Lyude Paul Cc: Sean Paul Signed-off-by: Guenter Roeck --- drivers/gpu/drm/Kconfig | 1 + 1 file

Re: [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-08-08 Thread Guenter Roeck
On Fri, Jul 26, 2019 at 07:23:13PM +0200, Andrzej Pietrasiewicz wrote: > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz > Reviewed-by: Neil Armstrong This patch results in a crash when running qemu:versatilepb. Unable to handle kernel NULL point

Re: next/master build: 230 builds: 5 failed, 225 passed, 6 errors, 1344 warnings (next-20190805)

2019-08-09 Thread Guenter Roeck
On Mon, Aug 05, 2019 at 12:12:05PM +0100, Mark Brown wrote: > On Mon, Aug 05, 2019 at 02:40:32AM -0700, kernelci.org bot wrote: > > Today's -next fails to build an arm allmodconfig due to: > > > allmodconfig (arm, gcc-8) — FAIL, 2 errors, 16 warnings, 0 section > > mismatches > > > > Errors: >

Re: next/master build: 230 builds: 5 failed, 225 passed, 6 errors, 1344 warnings (next-20190805)

2019-08-09 Thread Guenter Roeck
On 8/8/19 11:53 AM, Alex Deucher wrote: On Thu, Aug 8, 2019 at 2:53 PM Guenter Roeck wrote: On Mon, Aug 05, 2019 at 12:12:05PM +0100, Mark Brown wrote: On Mon, Aug 05, 2019 at 02:40:32AM -0700, kernelci.org bot wrote: Today's -next fails to build an arm allmodconfig due to: allmodc

Re: [PATCH] drm/bridge: dumb-vga-dac: Fix dereferencing -ENODEV DDC channel

2019-08-14 Thread Guenter Roeck
} else { > > dev_err(&pdev->dev, "Couldn't retrieve i2c bus\n"); > > return PTR_ERR(vga->ddc); > > @@ -218,7 +219,7 @@ static int dumb_vga_remove(struct platform_device *pdev) > > > > drm_bridge_remove(&vga->bridge); > > > > - if (!IS_ERR(vga->ddc)) > > + if (vga->ddc) > > i2c_put_adapter(vga->ddc); > > > > return 0; > > > > Looks sane, > > Reviewed-by: Neil Armstrong > > Guenter, can you confirm it also fixes qemu:versatilepb ? > Yes, it does. Tested-by: Guenter Roeck Guenter

[PATCH] drm/amd/amdkfd: Drop unnecessary NULL check after container_of

2021-05-21 Thread Guenter Roeck
. @@ type t; identifier v; statement s; @@ <+... ( t v = container_of(...); | v = container_of(...); ) ... when != v - if (\( !v \| v == NULL \) ) s ...+> Signed-off-by: Guenter Roeck --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drive

[PATCH] drm/i915/gem: Use list_entry to access list members

2021-05-22 Thread Guenter Roeck
Use list_entry() instead of container_of() to access list members. Also drop unnecessary and misleading NULL checks on the result of list_entry(). Signed-off-by: Guenter Roeck --- drivers/gpu/drm/i915/gvt/dmabuf.c | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff

[PATCH v2] drm/i915/gem: Use list_entry to access list members

2021-05-23 Thread Guenter Roeck
Use list_entry() instead of container_of() to access list members. Also drop unnecessary and misleading NULL checks on the result of list_entry(). Signed-off-by: Guenter Roeck --- v2: Checkpatch fixes: - Fix alignment - Replace comparison against NULL with ! drivers/gpu/drm/i915/gvt

[PATCH] drm/msm/dp: Drop unnecessary NULL checks after container_of

2021-05-24 Thread Guenter Roeck
following Coccinelle script. @@ type t; identifier v; statement s; @@ <+... ( t v = container_of(...); | v = container_of(...); ) ... when != v - if (\( !v \| v == NULL \) ) s ...+> While at it, remove unused but assigned variable hpd in dp_display_usbpd_attention_cb(). Signed-off-by: G

[PATCH] drm/msm/disp/dpu1/dpu_encoder: Drop unnecessary NULL checks after container_of

2021-05-25 Thread Guenter Roeck
following Coccinelle script. @@ type t; identifier v; statement s; @@ <+... ( t v = container_of(...); | v = container_of(...); ) ... when != v - if (\( !v \| v == NULL \) ) s ...+> Signed-off-by: Guenter Roeck --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 10 --

Re: [PATCH 3/3] Replace for_each_*_bit_from() with for_each_*_bit() where appropriate

2021-06-21 Thread Guenter Roeck
On Fri, Jun 18, 2021 at 12:57:35PM -0700, Yury Norov wrote: > A couple of kernel functions call for_each_*_bit_from() with start > bit equal to 0. Replace them with for_each_*_bit(). > > No functional changes, but might improve on readability. > > Signed-off-by: Yury Norov > --- > arch/x86/kern

Re: [PATCH 3/3] drm/i915/hwmon: Expose power1_max_enable

2023-02-13 Thread Guenter Roeck
On 2/13/23 21:33, Ashutosh Dixit wrote: On ATSM the PL1 power limit is disabled at power up. The previous uapi assumed that the PL1 limit is always enabled and therefore did not have a notion of a disabled PL1 limit. This results in erroneous PL1 limit values when PL1 limit is disabled. For examp

  1   2   3   4   >