[PATCH v2] drm/rockchip: Replace dev_* with DRM_DEV_*

2017-09-16 Thread Haneen Mohammed
+DRM_DEV_DEBUG ) Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v2: - Change patch title - Remove redundant print messages from DRM_DEV_* drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 26 drivers/gpu/drm/rockchip/cdn-dp-reg.c | 2 +- drivers/gpu/drm/ro

Re: [Outreachy kernel] [RESEND PATCH] drm: Remove obsolete "This is gross" comment

2017-09-22 Thread Haneen Mohammed
On Thu, Sep 21, 2017 at 11:16:44PM +0200, Julia Lawall wrote: > > > On Thu, 21 Sep 2017, Haneen Mohammed wrote: > > > Remove obsolete comment which was initially added in 2008 to annotate > > that idr_find() was used before idr_remove() since idr_remove() didn't &g

[PATCH v2] drm: Remove obsolete "This is gross" comment

2017-09-22 Thread Haneen Mohammed
again"). In addition, remove the todo item about this issue. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v2: - remove todo item regarding this comment Documentation/gpu/todo.rst | 6 -- drivers/gpu/drm/drm_gem.c | 9 - 2 files changed, 15 deletion

[RESEND PATCH] drm: Remove obsolete "This is gross" comment

2017-09-22 Thread Haneen Mohammed
again"). Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/drm_gem.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c index c55f338..b9bddaa 100644 --- a/drivers/gpu/drm/drm_gem.c +++ b/drivers/g

[RESEND PATCH 2/2] drm/armada: Replace drm_framebuffer_reference/unreference() with _get/put()

2017-09-20 Thread Haneen Mohammed
); +drm_framebuffer_get(e); | -drm_framebuffer_unreference(e); +drm_framebuffer_put(e); ) Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/armada/armada_crtc.c| 14 +++--- drivers/gpu/drm/armada/armada_drv.c | 2 +- drivers/gpu/drm/armada/armada_overlay.

[RESEND PATCH 0/2] drm/armada: Replace _reference/unreference() with _get/put()

2017-09-20 Thread Haneen Mohammed
This patchset replace instances of *_reference/unreference() with *_get/put(), because get/put is shorter and consistent with the kernel use of *_get/put suffixes. Haneen Mohammed (2): drm/armada: Replace drm_gem_object_reference/unreference() with _get/put() drm/armada: Replace

[RESEND PATCH 1/2] drm/armada: Replace drm_gem_object_reference/unreference() with _get/put()

2017-09-20 Thread Haneen Mohammed
); +drm_gem_object_get(e); | -drm_gem_object_unreference(e); +drm_gem_object_put(e); | -drm_gem_object_unreference_unlocked(e); +drm_gem_object_put_unlocked(e); ) Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/armada/armada_crtc.c | 8 drivers/gpu/drm/

Re: [PATCH] drm/rockchip: Rely on the default best_encoder() behavior

2017-10-10 Thread Haneen Mohammed
On Wed, Sep 27, 2017 at 04:06:21PM -0400, Sean Paul wrote: > On Wed, Sep 27, 2017 at 12:23:17PM -0600, Haneen Mohammed wrote: > > Since the output has 1:1 relationship between connectors and encoders, > > and the driver is relying on the atomic helpers, remove the custom > > b

Re: [PATCH v2 1/3] drm: Extract drm_debug.[hc]

2017-10-15 Thread Haneen Mohammed
On Thu, Oct 12, 2017 at 11:35:12AM +0100, Chris Wilson wrote: > Quoting Haneen Mohammed (2017-10-12 03:32:53) > > diff --git a/drivers/gpu/drm/drm_debug.c b/drivers/gpu/drm/drm_debug.c > > new file mode 100644 > > index 000..a79593f > > --- /dev/null > >

[PATCH] drm/tinydrm: Remove explicit .best_encoder assignment

2017-10-11 Thread Haneen Mohammed
Since the driver is relying on the atomic helpers, remove the explicit .best_encoder assignment and let the core call drm_atomic_helper_best_encoder(). Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/tinydrm/core/tinydrm-pipe.c | 1 - 1 file changed, 1 de

[PATCH 1/2] drm: Extract drm_debug.[hc]

2017-10-11 Thread Haneen Mohammed
Extract DRM_* debug macros from drmP.h to drm_debug.h and move printting related functions from drm_drv.[hc] to drm_debug.[hc]. Update kerneldoc include directives accordingly. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Documentation/gpu/drm-uapi.rst | 9 ++ drivers/g

[PATCH 2/2] drm: Update old comment style

2017-10-11 Thread Haneen Mohammed
Remove old comment style used by doxygen. And remove comment left from commit 99cdb35e787b ("drm/doc: move printf helpers out of drmP.h") after refactoring drmP.h. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- include/drm/drm_debug.h | 26 +-

[PATCH 0/2] drm: Move debug macros out of drmP.h

2017-10-11 Thread Haneen Mohammed
This patchset move debug macros from drmP.h into drm_debug.h and move printting related functions from drm_drv.[hc] to drm_debug.[hc]. In addition, it fixes old comment style. Haneen Mohammed (2): drm: Extract drm_debug.[hc] drm: Update old comment style Documentation/gpu/drm-uapi.rst | 9

[PATCH v2 1/3] drm: Extract drm_debug.[hc]

2017-10-12 Thread Haneen Mohammed
Extract DRM_* debug macros from drmP.h to drm_debug.h and move printting related functions from drm_drv.[hc] to drm_debug.[hc]. Update kerneldoc include directives accordingly. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v2: - Place kerneldoc include directives

Re: [PATCH 1/2] drm: Extract drm_debug.[hc]

2017-10-12 Thread Haneen Mohammed
On Wed, Oct 11, 2017 at 01:40:47PM +0200, Daniel Vetter wrote: > On Tue, Oct 10, 2017 at 10:13:36PM -0600, Haneen Mohammed wrote: > > Extract DRM_* debug macros from drmP.h to drm_debug.h and move printting > > related functions from drm_drv.[hc] to drm_debug.[hc]. > >

[PATCH v2 0/3] drm: Move debug macros out of drmP.h

2017-10-12 Thread Haneen Mohammed
directives in drm-internals.rst - Fix kerneldoc comments in drm_debug.h - include patch 3 to add kerneldoc comments to exported functions Haneen Mohammed (3): drm: Extract drm_debug.[hc] drm: Update old comment style drm/debug: Add missing kerneldoc comments to exported functions Documentation

[PATCH v2 3/3] drm/debug: Add missing kerneldoc comments to exported functions

2017-10-12 Thread Haneen Mohammed
Add missing documentation for exported functions to avoid kerneldoc warning. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v2: - Include this patch to avoid kerneldoc warning drivers/gpu/drm/drm_debug.c | 17 + 1 file changed, 17 insertions(+)

[PATCH v2 2/3] drm: Update old comment style

2017-10-12 Thread Haneen Mohammed
Remove old comment style used by doxygen. And remove comment left from commit 99cdb35e787b ("drm/doc: move printf helpers out of drmP.h") after refactoring drmP.h. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v2: - Fix kerneldoc comments include/drm/

Re: [PATCH] drm/armada: Remove unused #include

2017-10-01 Thread Haneen Mohammed
On Fri, Sep 29, 2017 at 02:29:31PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 09.25, skrev Daniel Vetter: > >On Wed, Sep 27, 2017 at 01:38:46AM -0600, Haneen Mohammed wrote: > >>Remove drmP.h as it is not needed anymore since nothing it > >>defines is used in th

[PATCH] drm/rockchip: Rely on the default best_encoder() behavior

2017-09-28 Thread Haneen Mohammed
Since the output has 1:1 relationship between connectors and encoders, and the driver is relying on the atomic helpers, remove the custom best_encoder() and let the core call drm_atomic_helper_best_encoder(). Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/ro

[PATCH] drm/doc: Remove todo item about "This is gross" comment

2017-09-27 Thread Haneen Mohammed
This patch remove the todo item "Use new IDR deletion interface to clean up drm_gem_handle_delete()" after it has been resolved with the commit "drm: Remove obsolete "This is gross" comment". Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Docu

[PATCH] drm/armada: Remove unused #include

2017-09-27 Thread Haneen Mohammed
Remove drmP.h as it is not needed anymore since nothing it defines is used in these files. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/armada/armada_510.c | 1 - drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/armada/armada_fb.c| 1 - d

Re: [Outreachy kernel] [RESEND PATCH] drm: Remove obsolete "This is gross" comment

2017-09-27 Thread Haneen Mohammed
On Tue, Sep 26, 2017 at 07:24:38AM +0200, Daniel Vetter wrote: > On Thu, Sep 21, 2017 at 03:04:24PM -0600, Haneen Mohammed wrote: > > Remove obsolete comment which was initially added in 2008 to annotate > > that idr_find() was used before idr_remove() since idr_remove() didn't &g

[PATCH v3 0/2] drm: Move debug macros out of drmP.h

2017-10-18 Thread Haneen Mohammed
drm_debug.[hc]. Haneen Mohammed (2): drm: Move debug macros out of drmP.h drm/print: Update old comment style drivers/gpu/drm/drm_drv.c | 47 -- drivers/gpu/drm/drm_print.c | 47 ++ include/drm/drmP.h | 150

[PATCH v4 1/2] drm: Move debug macros out of drmP.h

2017-10-18 Thread Haneen Mohammed
This patch extract DRM_* debug macros from drmP.h to drm_print.h and move printing related functions used by these macros from drm_drv.[hc] to drm_print.[hc]. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v4: - Move DRM_UT_ debug messaging macros from

[PATCH v4 0/2] drm: Move debug macros out of drmP.h

2017-10-18 Thread Haneen Mohammed
: - Move debug macros and print functions into drm_print.[hc] instead of introducing drm_debug.[hc]. Haneen Mohammed (2): drm: Move debug macros out of drmP.h drm/print: Update old comment style drivers/gpu/drm/drm_drv.c | 47 --- drivers/gpu/drm/drm_print.c | 47 +++ include

[PATCH v3 1/2] drm: Move debug macros out of drmP.h

2017-10-18 Thread Haneen Mohammed
This patch extract DRM_* debug macros from drmP.h to drm_print.h and move printing related functions used by these macros from drm_drv.[hc] to drm_print.[hc]. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v3: - Move debug macros and print functions into drm_pri

Re: [PATCH v3 1/2] drm: Move debug macros out of drmP.h

2017-10-18 Thread Haneen Mohammed
On Tue, Oct 17, 2017 at 03:54:13PM -0400, Sean Paul wrote: > On Tue, Oct 17, 2017 at 02:43:38AM -0600, Haneen Mohammed wrote: > > This patch extract DRM_* debug macros from drmP.h to drm_print.h and > > move printing related functions used by these macros from drm_drv.[hc] >

[PATCH v3 2/2] drm/print: Update old comment style

2017-10-18 Thread Haneen Mohammed
Remove old comment style used by doxygen. And remove comment left from commit 99cdb35e787b ("drm/doc: move printf helpers out of drmP.h") after refactoring drmP.h. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v3: - nothing include/drm/

[PATCH v4 2/2] drm/print: Update old comment style

2017-10-18 Thread Haneen Mohammed
Remove old comment style used by doxygen. And remove comment left from commit 99cdb35e787b ("drm/doc: move printf helpers out of drmP.h") after refactoring drmP.h. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- Changes in v4: - Nothing. include/drm/

[PATCH] drm/vkms: Introduce basic VKMS driver

2018-05-15 Thread Haneen Mohammed
without the need for hardware display capability. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/Kconfig | 6 ++ drivers/gpu/drm/Makefile| 1 + drivers/gpu/drm/vkms/Makefile | 3 + drivers/gpu/drm/vkms/vkms_drv.c

[PATCH] drm: Match sysfs name in link removal to link creation

2018-05-11 Thread Haneen Mohammed
This patch matches the sysfs name used in the unlinking with the linking function. Otherwise, remove_compat_control_link() fails to remove sysfs created by create_compat_control_link() in drm_dev_register(). Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/gpu/drm/drm

Re: [PATCH v2 0/3] Expanding the basic vkms features

2018-05-18 Thread Haneen Mohammed
ms_plane.c > > -- > 2.17.0 with my limited knowledge on DRM, these looks good to me. Reviewed-by: Haneen Mohammed <hamohammed.sa@gmail> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH] drm/vkms: vkms_driver can be static

2018-05-16 Thread Haneen Mohammed
On Tue, May 15, 2018 at 07:30:52PM +0800, kbuild test robot wrote: > > Fixes: 58d8108f080c ("drm/vkms: Introduce basic VKMS driver") > Signed-off-by: Fengguang Wu > --- > vkms_drv.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH V4 0/3] Expanding the basic vkms features

2018-05-23 Thread Haneen Mohammed
te mode 100644 drivers/gpu/drm/vkms/vkms_output.c > create mode 100644 drivers/gpu/drm/vkms/vkms_plane.c > > -- > 2.17.0 > Reviewed-by: Haneen Mohammed <hamohammed...@gmail.com> ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-24 Thread Haneen Mohammed
On Wed, May 23, 2018 at 10:53:33AM +0200, Daniel Vetter wrote: > On Sun, May 20, 2018 at 09:22:31AM +0300, Haneen Mohammed wrote: > > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > > > This commit adds the essential infrastructure for around CRTCs which

Re: [PATCH V3 0/3] Expanding the basic vkms features

2018-05-24 Thread Haneen Mohammed
On Wed, May 23, 2018 at 11:15:18AM +0200, Daniel Vetter wrote: > On Mon, May 21, 2018 at 10:04:23PM -0300, Rodrigo Siqueira wrote: > > This series of patches add a centralized initialization mechanism, a > > single CRTC with a plane, an encoder, and extra module information. > > > > Changes in

[PATCH] drm: Add checks for atomic_[duplicate/destroy]_state with atomic drivers

2018-05-25 Thread Haneen Mohammed
This patch add checks for atomic_[duplicate/destroy]_state of drm_[connector/crtc/plane]_funcs for atomic drivers in the relevant drm_*_init functions since these callback are mandatory for atomic drivers. Update the kerneldoc comments for those callbacks. Signed-off-by: Haneen Mohammed

[PATCH] drm: Add checks for NULL drm_*_helper_funcs

2018-05-25 Thread Haneen Mohammed
This patch add checks for NULL drm_[connector/crtc/plane]_helper_funcs pointers before derefrencing the variable to avoid NULL pointer dereference and make the helper functions as optional as possible. Signed-off-by: Haneen Mohammed <hamohammed...@gmail.com> --- drivers/g

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-21 Thread Haneen Mohammed
On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > This commit adds the essential infrastructure for around CRTCs which > is composed of: a new data struct for output data information, a > function for creating planes, and a simple encoder attached to the > connector. Finally, due

Re: [PATCH v2 2/3] drm/vkms: Add basic CRTC initialization

2018-05-21 Thread Haneen Mohammed
On Sun, May 20, 2018 at 11:28:37AM -0300, Rodrigo Siqueira wrote: > Hi Haneen, > > Thanks for the feedback :) > > On 05/20, Haneen Mohammed wrote: > > On Wed, May 16, 2018 at 08:56:21PM -0300, Rodrigo Siqueira wrote: > > > This commit adds the essential infrast

Re: [PATCH V3 2/3] drm/vkms: Add basic CRTC initialization

2018-05-22 Thread Haneen Mohammed
On Mon, May 21, 2018 at 10:06:40PM -0300, Rodrigo Siqueira wrote: > This commit appends the essential CRTCs infrastructure for VKMS. CRTCs > demands other elements to work correctly, in this sense, this patch adds > a new data struct that centralizes the data structures related to the > output,

Re: [PATCH] drm: Add checks for NULL drm_*_helper_funcs

2018-05-30 Thread Haneen Mohammed
On Tue, May 29, 2018 at 10:03:53AM +0200, Daniel Vetter wrote: > On Fri, May 25, 2018 at 05:20:08AM +0300, Haneen Mohammed wrote: > > This patch add checks for NULL drm_[connector/crtc/plane]_helper_funcs > > pointers before derefrencing the variable to avoid NULL pointer > >

[PATCH v2] drm: Add checks for NULL drm_*_helper_funcs

2018-05-30 Thread Haneen Mohammed
ctor_routing -> drm_connectot_helper_funcs * atomic_commit = drm_atomic_helper_commit a) drm_atomic_helper_prepare_planes -> drm_plane_helper_funcs b) drm_atomic_helper_cleanup_planes -> drm_plane_helper_funcs Signed-off-by: Haneen Mohammed --- Chanes in v2: - add the least amo

[PATCH v3] drm: Add checks for NULL drm_connector_helper_funcs

2018-06-01 Thread Haneen Mohammed
a) drm_atomic_helper_check_modeset a) handle_conflicting_encoders c) update_connector_routing Signed-off-by: Haneen Mohammed --- Changes in v3: - add checks for drm_connector_helper_funcs only since plane/crtc helper funcs are necessary for a functional driver Changes

[PATCH 1/2] drm/vkms: Subclass plane state

2018-07-28 Thread Haneen Mohammed
Subclass plane state struct to enable storing driver's private state. This patch only adds the base drm_plane_state struct and the atomic functions that handle it. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_drv.h | 10 +++ drivers/gpu/drm/vkms/vkms_plane.c | 47

[PATCH 2/2] drm/vkms: Implement CRC debugfs API

2018-07-28 Thread Haneen Mohammed
fb ->vunmap vkms_gem_obj->vaddr 2- @crtc_destroy -> flush work struct 3- @plane_destroy -> a) if (fb refcount) remove reference to fb b) deallocate crc_data Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/Makefile |

[PATCH 0/2] drm/vkms: Add CRC support

2018-07-28 Thread Haneen Mohammed
This patchset implement CRC debugfs API and add functions needed to compute and add CRCs entries. Haneen Mohammed (2): drm/vkms: Subclass plane state drm/vkms: Implement CRC debugfs API drivers/gpu/drm/vkms/Makefile | 2 +- drivers/gpu/drm/vkms/vkms_crc.c | 75

[PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-02 Thread Haneen Mohammed
fb ->vunmap vkms_gem_obj->vaddr 2- @crtc_destroy -> flush work struct 3- @plane_destroy -> a) if (fb refcount) remove reference to fb b) deallocate crc_data Signed-off-by: Haneen Mohammed --- Changes in v2: - remove vkms_crc_data for primary plane from vkms_output

[PATCH] drm/vkms: Fix vmap_count increment position

2018-08-02 Thread Haneen Mohammed
Move vmap_count out of the conditional statement since it needs to be updated for every successful call to vkms_gem_vmap. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b

[PATCH v2 1/2] drm/vkms: Subclass plane state

2018-08-02 Thread Haneen Mohammed
Subclass plane state struct to enable storing driver's private state. This patch only adds the base drm_plane_state struct and the atomic functions that handle it. Signed-off-by: Haneen Mohammed Reviewed-by: Sean Paul --- drivers/gpu/drm/vkms/vkms_drv.h | 11 drivers/gpu/drm/vkms

[PATCH v2 0/2] drm/vkms: Add CRC support

2018-08-02 Thread Haneen Mohammed
This patchset implement CRC debugfs API and add functions needed to compute and add CRCs entries. Haneen Mohammed (2): drm/vkms: Subclass plane state drm/vkms: Implement CRC debugfs API drivers/gpu/drm/vkms/Makefile | 2 +- drivers/gpu/drm/vkms/vkms_crc.c | 95

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-30 Thread Haneen Mohammed
On Wed, Jul 18, 2018 at 02:44:18PM -0400, Sean Paul wrote: > On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote: > > First, just so you have the complete view, this is the missing part in this > > patch: > > -- vkms_crc.c > > static uint32_t _vkms_g

[PATCH 0/2] Compute CRC with cursor plane support

2018-08-06 Thread Haneen Mohammed
This patchset add support for cursor plane and compute CRC for output frame with cursor and primary planes. This currently passes cursor-size-change, onscreen, offscreen, sliding, random, dpms, and rapid-movement igt tests with 64x64 cursor. Haneen Mohammed (2): drm/vkms: Add cursor plane

[PATCH 2/2] drm/vkms: Compute CRC with Cursor Plane

2018-08-06 Thread Haneen Mohammed
This patch compute CRC for output frame with cursor and primary plane. Blend cursor with primary plane and compute CRC on the resulted frame. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_crc.c | 149 +- drivers/gpu/drm/vkms/vkms_drv.h | 5

Re: [PATCH v2 2/2] drm/vkms: Implement CRC debugfs API

2018-08-06 Thread Haneen Mohammed
On Fri, Aug 03, 2018 at 12:53:36PM -0400, Sean Paul wrote: > On Thu, Aug 02, 2018 at 04:10:26AM +0300, Haneen Mohammed wrote: > > This patch implement the necessary functions to compute and add CRCs > > entries: > > > > - Implement the set_crc_source() callback. &g

[PATCH] drm/vkms: Release pages_lock before return

2018-08-06 Thread Haneen Mohammed
Release pages_lock before return when vkms_obj->vaddr is NULL. This patch fixes: 6c234fe37c57 ("drm/vkms: Implement CRC debugfs API"). Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_crc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 1/2] drm/vkms: Add cursor plane support

2018-08-06 Thread Haneen Mohammed
Add cursor plane support and update vkms_plane_atomic_check to enable positioning cursor plane. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_drv.h| 11 +++--- drivers/gpu/drm/vkms/vkms_output.c | 16 --- drivers/gpu/drm/vkms/vkms_plane.c | 33

Re: [PATCH] drm/vkms: Fix vmap_count increment position

2018-08-11 Thread Haneen Mohammed
On Wed, Aug 01, 2018 at 12:08:07PM +0300, Haneen Mohammed wrote: > Move vmap_count out of the conditional statement since it needs > to be updated for every successful call to vkms_gem_vmap. > > Signed-off-by: Haneen Mohammed > --- > drivers/gpu/drm/vkms/vkms_gem.c | 3 +-- &g

Re: [PATCH 2/2] drm/vkms: Compute CRC with Cursor Plane

2018-08-11 Thread Haneen Mohammed
On Tue, Aug 07, 2018 at 06:33:36PM +0200, Daniel Vetter wrote: > On Mon, Aug 06, 2018 at 06:58:29AM +0300, Haneen Mohammed wrote: > > This patch compute CRC for output frame with cursor and primary plane. > > Blend cursor with primary plane and compute CRC on the resulted frame.

Re: [PATCH 2/2] drm/vkms: Compute CRC with Cursor Plane

2018-08-15 Thread Haneen Mohammed
On Tue, Aug 14, 2018 at 10:21:29AM +0200, Daniel Vetter wrote: > On Mon, Aug 13, 2018 at 11:04:11PM +0300, Haneen Mohammed wrote: > > On Wed, Aug 08, 2018 at 10:23:27AM +0200, Daniel Vetter wrote: > > > On Wed, Aug 08, 2018 at 06:53:17AM +0300, Haneen Mohammed wrote: > >

Re: [PATCH 2/2] drm/vkms: Compute CRC with Cursor Plane

2018-08-15 Thread Haneen Mohammed
On Tue, Aug 14, 2018 at 09:52:33PM +0200, Daniel Vetter wrote: > On Tue, Aug 14, 2018 at 9:03 PM, Haneen Mohammed > wrote: > > On Tue, Aug 14, 2018 at 10:21:29AM +0200, Daniel Vetter wrote: > >> On Mon, Aug 13, 2018 at 11:04:11PM +0300, Haneen Mohammed wrote: > >> &

Re: [PATCH 2/2] drm/vkms: Compute CRC with Cursor Plane

2018-08-16 Thread Haneen Mohammed
On Tue, Aug 14, 2018 at 09:52:33PM +0200, Daniel Vetter wrote: > On Tue, Aug 14, 2018 at 9:03 PM, Haneen Mohammed > wrote: > > On Tue, Aug 14, 2018 at 10:21:29AM +0200, Daniel Vetter wrote: > >> On Mon, Aug 13, 2018 at 11:04:11PM +0300, Haneen Mohammed wrote: > >> &

Re: [PATCH 2/2] drm/vkms: Compute CRC with Cursor Plane

2018-08-14 Thread Haneen Mohammed
On Wed, Aug 08, 2018 at 10:23:27AM +0200, Daniel Vetter wrote: > On Wed, Aug 08, 2018 at 06:53:17AM +0300, Haneen Mohammed wrote: > > On Tue, Aug 07, 2018 at 06:33:36PM +0200, Daniel Vetter wrote: > > > On Mon, Aug 06, 2018 at 06:58:29AM +0300, Haneen Mohammed wrote: > > &g

[PATCH] drm/vkms: Fix race condition around accessing frame number

2018-08-24 Thread Haneen Mohammed
, nonblocking-crc-pipe-A, nonblocking-crc-pipe-A-frame-sequence Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_crc.c | 33 ++-- drivers/gpu/drm/vkms/vkms_crtc.c | 13 +++-- drivers/gpu/drm/vkms/vkms_drv.h | 6 -- 3 files changed, 46

[PATCH v2 1/5] drm/vkms: Add functions to map/unmap GEM backing storage

2018-07-15 Thread Haneen Mohammed
This patch add the necessary functions to map/unmap GEM backing memory to the kernel's virtual address space. Signed-off-by: Haneen Mohammed --- Changes in v2: - add vkms_gem_vunmap - use vmap_count to guard against multiple prepare_fb calls on the same fb drivers/gpu/drm/vkms/vkms_drv.h

[PATCH v2 4/5] drm/vkms: subclass CRTC state

2018-07-15 Thread Haneen Mohammed
Subclass CRTC state struct to enable storing driver's private state. This patch only adds the base drm_crtc_state struct and the atomic functions that handle it. Signed-off-by: Haneen Mohammed Reviewed-by: Daniel Vetter --- drivers/gpu/drm/vkms/vkms_crtc.c | 53

[PATCH v2 3/5] drm/vkms: Add atomic_helper_check_plane_state

2018-07-15 Thread Haneen Mohammed
Call atomic_helper_check_plane_state to clip plane coordinates. Signed-off-by: Haneen Mohammed --- Changes in v2: - check for plane_state->visible since we can't handle a disabled primary plane yet. drivers/gpu/drm/vkms/vkms_plane.c | 29 + 1 file changed,

[PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-15 Thread Haneen Mohammed
atomic update, Signed-off-by: Haneen Mohammed --- Changes in v2: - Include this patch in this patchset. drivers/gpu/drm/vkms/Makefile | 2 +- drivers/gpu/drm/vkms/vkms_crtc.c | 60 ++- drivers/gpu/drm/vkms/vkms_drv.c | 1 + drivers/gpu/drm/vkms/vkms_drv.h

[PATCH v2 0/5] Implement CRC and Add necessary infrastructure

2018-07-15 Thread Haneen Mohammed
of the buffer with appropriate synchronization methods. Haneen Mohammed (5): drm/vkms: Add functions to map/unmap GEM backing storage drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks drm/vkms: Add atomic_helper_check_plane_state drm/vkms: subclass CRTC state drm/vkms: Implement

[PATCH v2 2/5] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks

2018-07-15 Thread Haneen Mohammed
This patch map/unmap GEM backing memory to kernel address space in prepare/cleanup_fb respectively and cache the virtual address for later use. Signed-off-by: Haneen Mohammed --- Changes in v2: - use vkms_gem_vunmap drivers/gpu/drm/vkms/vkms_plane.c | 36 ++- 1 file

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-17 Thread Haneen Mohammed
On Mon, Jul 16, 2018 at 02:22:56PM -0400, Sean Paul wrote: > On Sat, Jul 14, 2018 at 03:23:32PM +0300, Haneen Mohammed wrote: > > Implement the set_crc_source() callback. > > Compute CRC using crc32 on the visible part of the framebuffer. > > Use ordered workqueue to compute a

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-19 Thread Haneen Mohammed
out->crc_enabled = true; } else { out->crc_enabled = false; return -EINVAL; } *values_cnt = 1; return 0; } --- end vkms_crc.c On Tue, Jul 17, 2018 at 05:05:03PM -0400, Sean Paul wrote: > On Tue, Jul 17, 2018 at 04:43:16PM -0400, Sean Pa

[PATCH v3 5/5] drm/vkms: Implement CRC debugfs API

2018-07-19 Thread Haneen Mohammed
atomic update, by using spinlock across atomic_begin and atomic_flush to wrap the event handling code completely and match the flip event with the CRC. Signed-off-by: Haneen Mohammed --- Changes in v3: - flush work item instead of workqueue - include missing vkms_crc.c file drivers/gpu/drm/vkms

[PATCH v3 3/5] drm/vkms: Add atomic_helper_check_plane_state

2018-07-19 Thread Haneen Mohammed
Call atomic_helper_check_plane_state to clip plane coordinates. Signed-off-by: Haneen Mohammed Reviewed-by: Sean Paul --- Changes in v2: - check for plane_state->visible since we can't handle a disabled primary plane yet. drivers/gpu/drm/vkms/vkms_plane.c |

[PATCH v3 1/5] drm/vkms: Add functions to map/unmap GEM backing storage

2018-07-19 Thread Haneen Mohammed
This patch add the necessary functions to map/unmap GEM backing memory to the kernel's virtual address space. Signed-off-by: Haneen Mohammed --- Changes in v2: - add vkms_gem_vunmap - use vmap_count to guard against multiple prepare_fb calls on the same fb Changes in v3: - change vkms_gem_vmap

[PATCH v3 2/5] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks

2018-07-19 Thread Haneen Mohammed
This patch map/unmap GEM backing memory to kernel address space in prepare/cleanup_fb respectively and cache the virtual address for later use. Signed-off-by: Haneen Mohammed --- Changes in v2: - use vkms_gem_vunmap Changes in v3: - return error number instead of vkms_obj->vaddr drivers/

Re: [PATCH v2 5/5] drm/vkms: Implement CRC debugfs API

2018-07-19 Thread Haneen Mohammed
On Wed, Jul 18, 2018 at 02:44:18PM -0400, Sean Paul wrote: > On Wed, Jul 18, 2018 at 07:24:34PM +0300, Haneen Mohammed wrote: > > First, just so you have the complete view, this is the missing part in this > > patch: > > -- vkms_crc.c > > static uint32_t _vkms_g

[PATCH v3 4/5] drm/vkms: subclass CRTC state

2018-07-19 Thread Haneen Mohammed
Subclass CRTC state struct to enable storing driver's private state. This patch only adds the base drm_crtc_state struct and the atomic functions that handle it. Signed-off-by: Haneen Mohammed Reviewed-by: Daniel Vetter Reviewed-by: Sean Paul --- drivers/gpu/drm/vkms/vkms_crtc.c | 53

[PATCH v3 0/5] Implement CRC and Add necessary infrastructure

2018-07-19 Thread Haneen Mohammed
of the buffer with appropriate synchronization methods. Haneen Mohammed (5): drm/vkms: Add functions to map/unmap GEM backing storage drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks drm/vkms: Add atomic_helper_check_plane_state drm/vkms: subclass CRTC state drm/vkms: Implement

[PATCH v4 0/4] Add infrastructure needed for CRC support

2018-07-25 Thread Haneen Mohammed
t CRC debugfs API" from this patchset since it needs further work. Haneen Mohammed (4): drm/vkms: Add functions to map/unmap GEM backing storage drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks drm/vkms: Add atomic_helper_check_plane_state drm/vkms: subclass CRTC state drive

[PATCH v4 2/4] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks

2018-07-25 Thread Haneen Mohammed
This patch map/unmap GEM backing memory to kernel address space in prepare/cleanup_fb respectively and cache the virtual address for later use. Signed-off-by: Haneen Mohammed --- Changes in v2: - use vkms_gem_vunmap Changes in v3: - return error number instead of vkms_obj->vaddr Changes in

[PATCH v4 1/4] drm/vkms: Add functions to map/unmap GEM backing storage

2018-07-25 Thread Haneen Mohammed
This patch add the necessary functions to map/unmap GEM backing memory to the kernel's virtual address space. Signed-off-by: Haneen Mohammed --- Changes in v2: - add vkms_gem_vunmap - use vmap_count to guard against multiple prepare_fb calls on the same fb Changes in v3: - change vkms_gem_vmap

[PATCH v4 4/4] drm/vkms: subclass CRTC state

2018-07-25 Thread Haneen Mohammed
Subclass CRTC state struct to enable storing driver's private state. This patch only adds the base drm_crtc_state struct and the atomic functions that handle it. Signed-off-by: Haneen Mohammed Reviewed-by: Daniel Vetter Reviewed-by: Sean Paul --- drivers/gpu/drm/vkms/vkms_crtc.c | 53

[PATCH v4 3/4] drm/vkms: Add atomic_helper_check_plane_state

2018-07-25 Thread Haneen Mohammed
Call atomic_helper_check_plane_state to clip plane coordinates. Signed-off-by: Haneen Mohammed Reviewed-by: Sean Paul --- Changes in v2: - check for plane_state->visible since we can't handle a disabled primary plane yet. drivers/gpu/drm/vkms/vkms_plane.c |

[PATCH v2 2/3] drm/vkms: Compute CRC with Cursor Plane

2018-09-06 Thread Haneen Mohammed
. Signed-off-by: Haneen Mohammed --- v2: - clear alpha channel before computing crc for XRGB drivers/gpu/drm/vkms/vkms_crc.c | 154 +- drivers/gpu/drm/vkms/vkms_drv.h | 5 +- drivers/gpu/drm/vkms/vkms_plane.c | 10 +- 3 files changed, 143 insertions(+), 26 deletions

[PATCH v2 1/3] drm/vkms: Add cursor plane support

2018-09-06 Thread Haneen Mohammed
Add cursor plane support and update vkms_plane_atomic_check to enable positioning cursor plane. Signed-off-by: Haneen Mohammed --- v2: - nothing drivers/gpu/drm/vkms/vkms_drv.h| 11 +++--- drivers/gpu/drm/vkms/vkms_output.c | 16 --- drivers/gpu/drm/vkms/vkms_plane.c | 33

Re: [PATCH v2] drm/vkms: Fix race condition around accessing frame number

2018-09-06 Thread Haneen Mohammed
On Wed, Sep 05, 2018 at 04:03:26PM +0200, Daniel Vetter wrote: > On Tue, Sep 04, 2018 at 12:18:17AM +0300, Haneen Mohammed wrote: > > crtc_state is accessed by both vblank_handle() and the ordered > > work_struct handle vkms_crc_work_handle() to retrieve and or update >

[PATCH v2 0/3] Compute CRC with cursor plane support

2018-09-06 Thread Haneen Mohammed
This patchset adds cursor plane support and compute CRC for output frame with cursor and primary plane. changes in v2: - clear alpha channel before computing crc for XRGB plane format - add module option 'enable_cursor' to enable/disable cursor support Haneen Mohammed (3): drm/vkms: Add cursor

[PATCH v2 3/3] drm/vkms: Enable/Disable cursor support with module option

2018-09-06 Thread Haneen Mohammed
Cursor support is not complete yet. Add module option 'enable_cursor' to enable/disable cursor support which is used for testing currently. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_drv.c| 4 drivers/gpu/drm/vkms/vkms_drv.h| 2 ++ drivers/gpu/drm/vkms

[PATCH] drm/vkms: Add kerneldoc entry

2018-09-10 Thread Haneen Mohammed
Add an initial kerneldoc entry for vkms with a todo list. Signed-off-by: Haneen Mohammed --- Documentation/gpu/drivers.rst | 1 + Documentation/gpu/todo.rst | 12 Documentation/gpu/vkms.rst | 21 + drivers/gpu/drm/vkms/vkms_drv.c | 9 + 4

Re: [PATCH V2 1/5] drm/vkms: Add dumb operations

2018-07-06 Thread Haneen Mohammed
On Thu, Jun 21, 2018 at 09:16:13AM -0300, Rodrigo Siqueira wrote: > VKMS currently does not handle dumb data, and as a consequence, it does > not provide mechanisms for handling gem. This commit adds the necessary > support for gem object/handler and the dumb functions. > > Signed-off-by: Rodrigo

[PATCH 0/4] Add infrastructure needed for CRC support

2018-07-10 Thread Haneen Mohammed
patchset: subject: [PATCH V2 0/5] drm/vkms: Updates to meet basic kms_flip requirements link: https://lists.freedesktop.org/archives/dri-devel/2018-June/180823.html Haneen Mohammed (4): drm/vkms: Add functions to map GEM backing storage drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks

[PATCH 4/4] drm/vkms: subclass CRTC state

2018-07-10 Thread Haneen Mohammed
Subclass CRTC state struct to enable storing driver's private state. This patch only adds the base drm_crtc_state struct and the atomic functions that handle it. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_crtc.c | 55 ++-- drivers/gpu/drm/vkms

[PATCH 2/4] drm/vkms: map/unmap buffers in [prepare/cleanup]_fb hooks

2018-07-10 Thread Haneen Mohammed
This patch map/unmap GEM backing memory to kernel address space in prepare/cleanup_fb respectively and cache the virtual address for later use. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_plane.c | 41 +++ 1 file changed, 41 insertions(+) diff --git

[PATCH 3/4] drm/vkms: Add atomic_helper_check_plane_state

2018-07-10 Thread Haneen Mohammed
Call atomic_helper_check_plane_state to clip plane coordinates. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_plane.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c

[PATCH 1/4] drm/vkms: Add functions to map GEM backing storage

2018-07-10 Thread Haneen Mohammed
This patch add the necessary functions to map GEM backing memory into the kernel's virtual address space. Signed-off-by: Haneen Mohammed --- drivers/gpu/drm/vkms/vkms_drv.c | 2 ++ drivers/gpu/drm/vkms/vkms_drv.h | 5 drivers/gpu/drm/vkms/vkms_gem.c | 50

Re: [PATCH 1/4] drm/vkms: Add functions to map GEM backing storage

2018-07-11 Thread Haneen Mohammed
On Tue, Jul 10, 2018 at 09:12:36AM +0100, Chris Wilson wrote: > Quoting Haneen Mohammed (2018-07-09 16:44:26) > > +struct page **get_pages(struct vkms_gem_object *vkms_obj) > > +{ > > + struct drm_gem_object *gem_obj = _obj->gem; > > + struct

Re: [PATCH 4/4] drm/vkms: subclass CRTC state

2018-07-11 Thread Haneen Mohammed
On Tue, Jul 10, 2018 at 10:10:46AM +0200, Daniel Vetter wrote: > On Mon, Jul 09, 2018 at 06:48:36PM +0300, Haneen Mohammed wrote: > > Subclass CRTC state struct to enable storing driver's private > > state. This patch only adds the base drm_crtc_state struct and > >

Re: [PATCH] drm/vkms: Add kerneldoc entry

2018-09-12 Thread Haneen Mohammed
On Tue, Sep 11, 2018 at 08:06:31PM +0200, Daniel Vetter wrote: > On Fri, Sep 07, 2018 at 08:41:36PM +0300, Haneen Mohammed wrote: > > Add an initial kerneldoc entry for vkms with a todo list. > > > > Signed-off-by: Haneen Mohammed > > --- > > Doc

  1   2   >