Re: Call for an EDID parsing library

2021-04-07 Thread Hans Verkuil
Hi Pekka, On 07/04/2021 10:44, Pekka Paalanen wrote: > Hi all, > > with display servers proliferating thanks to Wayland, and the Linux > kernel exposing only a very limited set of information based on EDID > (rightfully so!), the need to interpret EDID blobs is spreading even > more. I would like

Re: Call for an EDID parsing library

2021-04-07 Thread Hans Verkuil
On 07/04/2021 12:31, Jani Nikula wrote: > On Wed, 07 Apr 2021, Hans Verkuil wrote: >> It is the most complete EDID parser I know based on the various standards. > > Does it support pure DisplayID in addition to DisplayID blocks embedded > to EDID extension blocks? I think we&

Re: [PATCH 0/2] drm/bridge: dw-hdmi: disable loading of DW-HDMI CEC sub-driver

2021-04-20 Thread Hans Verkuil
pin is connected is at the hardware level decision, it is not something that software can detect. If the designer of the board didn't connect it, then the only place you can define that is in the device tree. Anyway, for meson I am fine with this solution. At least it prevents creating a

Re: [PATCHv2 1/6] drm: drm_bridge: add connector_attach/detach bridge ops

2021-04-28 Thread Hans Verkuil
On 16/04/2021 09:46, Tomi Valkeinen wrote: > Hi Hans, > > On 02/03/2021 18:23, Hans Verkuil wrote: >> Add bridge connector_attach/detach ops. These ops are called when a >> bridge is attached or detached to a drm_connector. These ops can be >> used to register and unr

[PATCHv3 1/6] drm: drm_bridge: add connector_attach/detach bridge ops

2021-04-28 Thread Hans Verkuil
Add bridge connector_attach/detach ops. These ops are called when a bridge is attached or detached to a drm_connector. These ops can be used to register and unregister an HDMI CEC adapter for a bridge that supports CEC. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/drm_bridge_connector.c | 25

[PATCHv3 2/6] drm/omapdrm/dss/hdmi4: switch to the connector bridge ops

2021-04-28 Thread Hans Verkuil
Implement the new connector_attach/detach bridge ops. This makes it possible to associate a CEC adapter with a drm connector, which helps userspace determine which cec device node belongs to which drm connector. Signed-off-by: Hans Verkuil Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm

[PATCHv3 6/6] drm/omapdrm/dss/hdmi5: add CEC support

2021-04-28 Thread Hans Verkuil
Add HDMI CEC support for OMAP5. Signed-off-by: Hans Verkuil Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/Kconfig | 8 + drivers/gpu/drm/omapdrm/Makefile | 1 + drivers/gpu/drm/omapdrm/dss/hdmi.h | 1 + drivers/gpu/drm/omapdrm/dss/hdmi5.c | 64

[PATCHv3 4/6] dt-bindings: display: ti: ti, omap5-dss.txt: add cec clock

2021-04-28 Thread Hans Verkuil
The cec clock is required as well in order to support HDMI CEC, document this. Signed-off-by: Hans Verkuil Reviewed-by: Tomi Valkeinen Acked-by: Rob Herring --- Documentation/devicetree/bindings/display/ti/ti,omap5-dss.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCHv3 3/6] drm/omapdrm/dss/hdmi4: simplify CEC Phys Addr handling

2021-04-28 Thread Hans Verkuil
Switch to using cec_s_phys_addr_from_edid() instead of a two-step process of calling cec_get_edid_phys_addr() followed by cec_s_phys_addr(). Signed-off-by: Hans Verkuil Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 13 ++--- drivers/gpu/drm/omapdrm/dss

[PATCHv3 5/6] dra7.dtsi/omap5.dtsi: add cec clock

2021-04-28 Thread Hans Verkuil
Add cec clock to the dra7 and omap5 device trees. Signed-off-by: Hans Verkuil Acked-by: Tony Lindgren Reviewed-by: Tomi Valkeinen --- arch/arm/boot/dts/dra7.dtsi | 5 +++-- arch/arm/boot/dts/omap5.dtsi | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot

[PATCHv3 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2021-04-28 Thread Hans Verkuil
patch to add the cec clock to ti,omap5-dss.txt - swapped the order of the last two patches - incorporated Tomi's suggestions for the hdmi5 CEC support. Hans Verkuil (6): drm: drm_bridge: add connector_attach/detach bridge ops drm/omapdrm/dss/hdmi4: switch to the connector bridge ops d

[PATCH] drm/bridge: adv7511: fix support for large EDIDs

2021-03-24 Thread Hans Verkuil
the adv7511. Tested with my Koelsch board and with EDIDs of 1, 2, 3 and 4 blocks. Signed-off-by: Hans Verkuil --- Testing on the Renesas board also requires these two adv7604 patches if you want to test with an HDMI cable between the HDMI input and output: https://patchwork.linuxtv.org/project/li

Re: [PATCH] drm/bridge: adv7511: fix support for large EDIDs

2021-03-25 Thread Hans Verkuil
Hi Laurent, Thank you for the review. On 26/03/2021 02:00, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Wed, Mar 24, 2021 at 09:53:32AM +0100, Hans Verkuil wrote: >> While testing support for large (> 256 bytes) EDIDs on the Renesas >> Ko

Re: [PATCH] drm/bridge: adv7511: fix support for large EDIDs

2021-03-25 Thread Hans Verkuil
On 26/03/2021 02:00, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Wed, Mar 24, 2021 at 09:53:32AM +0100, Hans Verkuil wrote: >> While testing support for large (> 256 bytes) EDIDs on the Renesas >> Koelsch board I noticed that the adv75

[PATCHv2] drm/bridge: adv7511: fix support for large EDIDs

2021-03-26 Thread Hans Verkuil
the adv7511. Tested with my Koelsch board and with EDIDs of 1, 2, 3 and 4 blocks. Signed-off-by: Hans Verkuil Tested-by: Niklas Söderlund --- Changes since v2: make current_edid_segment an int (it's set to -1 after all) and use that instead of reading ADV7511_REG_EDID_SEGMENT. Also sprink

Re: [PATCH v2 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2021-01-19 Thread Hans Verkuil
On 12/01/2021 16:24, Hans Verkuil wrote: > Hi Maxime, > > On 11/01/2021 15:22, Maxime Ripard wrote: >> Hi, >> >> Here's a series introducing the CEC support for the BCM2711 found on the >> RaspberryPi4. >> >> The BCM2711 HDMI controller uses a

Re: [PATCH v7 14/17] media/videobuf1|2: Mark follow_pfn usage as unsafe

2021-01-19 Thread Hans Verkuil
ffects > the zerocopy userptr usage enabled in 50ac952d2263 ("[media] > videobuf2-dma-sg: Support io userptr operations on io memory"). > > Acked-by: Tomasz Figa Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe

Re: [PATCH v2 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2021-01-28 Thread Hans Verkuil
On 18/01/2021 14:55, Hans Verkuil wrote: > On 12/01/2021 16:24, Hans Verkuil wrote: >> Hi Maxime, >> >> On 11/01/2021 15:22, Maxime Ripard wrote: >>> Hi, >>> >>> Here's a series introducing the CEC support for the BCM2711 found on the >>

Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2021-02-01 Thread Hans Verkuil
patch). Regards, Hans On 12/01/2021 10:24, Hans Verkuil wrote: > Hi Sam, > > This series still hasn't been merged. It still applies cleanly to v5.11-rc1. > > Daniel, can you merge this series for 5.12? Or Ack this series so I can merge > it? > > The first thre

Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2021-02-03 Thread Hans Verkuil
Hi Sam, Are you able to work on a v4? I haven't heard from you for some time now. I would be willing to take over this series if it wasn't for the fact that I do not have any hardware to test this with. Regards, Hans On 01/02/2021 22:56, Lyude Paul wrote: > On Wed, 2020-09-23 at 12:13

Re: [PATCH v3 2/4] drm_dp_mst_topology: use correct AUX channel

2021-02-04 Thread Hans Verkuil
On 01/02/2021 23:13, Ville Syrjälä wrote: > On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam McNally wrote: >> From: Hans Verkuil >> >> For adapters behind an MST hub use the correct AUX channel. >> >> Signed-off-by: Hans Verkuil >> [sa...@chromium.o

Re: [PATCH v3 4/4] drm_dp_cec: add MST support

2021-02-04 Thread Hans Verkuil
ll MST connectors, ensuring their > drm_dp_aux_cec struct won't be accessed uninitialized. > > Reviewed-by: Hans Verkuil > Signed-off-by: Sam McNally > --- > > Changes in v3: > - Fixed whitespace in drm_dp_cec_mst_irq_work() > - Moved drm_dp_cec_mst_set_edid_work()

Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2021-02-04 Thread Hans Verkuil
he right approach for the other > two though. > > On Wed, 3 Feb 2021 at 20:57, Hans Verkuil <mailto:hverk...@xs4all.nl>> wrote: > > Hi Sam, > > Are you able to work on a v4? > > I haven't heard from you for some time now. I would be willing t

Re: [PATCH v3 2/4] drm_dp_mst_topology: use correct AUX channel

2021-02-05 Thread Hans Verkuil
On 05/02/2021 14:24, Ville Syrjälä wrote: > On Fri, Feb 05, 2021 at 04:17:51PM +1100, Sam McNally wrote: >> On Thu, 4 Feb 2021 at 21:19, Hans Verkuil wrote: >>> >>> On 01/02/2021 23:13, Ville Syrjälä wrote: >>>> On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam

[PATCH 4/5] drm/omap: hdmi5: add CEC support

2021-02-11 Thread Hans Verkuil
Add HDMI CEC support for OMAP5. Many thanks to Tomi for helping out how to enable CEC for omap5. Signed-off-by: Hans Verkuil Thanks-to: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/Kconfig | 8 + drivers/gpu/drm/omapdrm/dss/Makefile | 1 + drivers/gpu/drm/omapdrm/dss/hdmi.h

[PATCH 3/5] drm/omap: hdmi4: simplify CEC Phys Addr handling

2021-02-11 Thread Hans Verkuil
Switch to using cec_s_phys_addr_from_edid() instead of a two-step process of calling cec_get_edid_phys_addr() followed by cec_s_phys_addr(). Signed-off-by: Hans Verkuil --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 13 ++--- drivers/gpu/drm/omapdrm/dss/hdmi4_cec.c | 4 ++-- drivers/gpu

[PATCH 5/5] ARM: dts: dra7/omap5: add cec clock

2021-02-11 Thread Hans Verkuil
Add cec clock to the dra7 and omap5 device trees. Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/dra7.dtsi | 5 +++-- arch/arm/boot/dts/omap5.dtsi | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index

[PATCH 2/5] drm/omap: hdmi4: switch to the cec bridge ops

2021-02-11 Thread Hans Verkuil
Implement the new CEC bridge ops. This makes it possible to associate a CEC adapter with a drm connector, which helps userspace determine with cec device node belongs to which drm connector. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 28

[PATCH 1/5] drm: drm_bridge: add cec_init/exit bridge ops

2021-02-11 Thread Hans Verkuil
Add bridge cec_init/exit ops. These ops will be responsible for creating and destroying the CEC adapter for the bridge that supports CEC. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/drm_bridge_connector.c | 23 +++ include/drm/drm_bridge.h | 31

[PATCH 0/5] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2021-02-11 Thread Hans Verkuil
clock to the dra7 and omap5 device tree. Tested with a Pandaboard and a Beagle X15 board. Regards, Hans Hans Verkuil (5): drm: drm_bridge: add cec_init/exit bridge ops drm/omap: hdmi4: switch to the cec bridge ops drm/omap: hdmi4: simplify CEC Phys Addr handling drm/omap: hdmi5: ad

Re: [PATCH 1/5] drm: drm_bridge: add cec_init/exit bridge ops

2021-03-01 Thread Hans Verkuil
On 19/02/2021 13:02, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Thu, Feb 11, 2021 at 11:36:59AM +0100, Hans Verkuil wrote: >> Add bridge cec_init/exit ops. These ops will be responsible for >> creating and destroying the CEC adapter for the

Re: [PATCH 2/5] drm/omap: hdmi4: switch to the cec bridge ops

2021-03-01 Thread Hans Verkuil
On 19/02/2021 13:07, Laurent Pinchart wrote: > Hi Hans, > > Thank you for the patch. > > On Thu, Feb 11, 2021 at 11:37:00AM +0100, Hans Verkuil wrote: >> Implement the new CEC bridge ops. This makes it possible to associate >> a CEC adapter with a drm connector, whic

Re: [PATCH 4/5] drm/omap: hdmi5: add CEC support

2021-03-01 Thread Hans Verkuil
On 19/02/2021 12:09, Tomi Valkeinen wrote: > Hi Hans, > > On 11/02/2021 12:37, Hans Verkuil wrote: >> Add HDMI CEC support for OMAP5. >> >> Many thanks to Tomi for helping out how to enable CEC for omap5. >> >> Signed-off-by: Hans Verkuil >> Thanks-t

[PATCHv2 2/6] drm/omapdrm/dss/hdmi4: switch to the connector bridge ops

2021-03-02 Thread Hans Verkuil
Implement the new connector_attach/detach bridge ops. This makes it possible to associate a CEC adapter with a drm connector, which helps userspace determine which cec device node belongs to which drm connector. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 27

[PATCHv2 0/6] drm/omap: hdmi: improve hdmi4 CEC, add CEC for hdmi5

2021-03-02 Thread Hans Verkuil
r all bridges. The DRM_BRIDGE_OP_CEC was dropped. - added patch to add the cec clock to ti,omap5-dss.txt - swapped the order of the last two patches - incorporated Tomi's suggestions for the hdmi5 CEC support. Hans Verkuil (6): drm: drm_bridge: add connector_attach/detach bridge ops drm/o

[PATCHv2 1/6] drm: drm_bridge: add connector_attach/detach bridge ops

2021-03-02 Thread Hans Verkuil
Add bridge connector_attach/detach ops. These ops are called when a bridge is attached or detached to a drm_connector. These ops can be used to register and unregister an HDMI CEC adapter for a bridge that supports CEC. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/drm_bridge_connector.c | 9

[PATCHv2 4/6] dt-bindings: display: ti: ti, omap5-dss.txt: add cec clock

2021-03-02 Thread Hans Verkuil
The cec clock is required as well in order to support HDMI CEC, document this. Signed-off-by: Hans Verkuil --- Documentation/devicetree/bindings/display/ti/ti,omap5-dss.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/ti/ti

[PATCHv2 3/6] drm/omapdrm/dss/hdmi4: simplify CEC Phys Addr handling

2021-03-02 Thread Hans Verkuil
Switch to using cec_s_phys_addr_from_edid() instead of a two-step process of calling cec_get_edid_phys_addr() followed by cec_s_phys_addr(). Signed-off-by: Hans Verkuil Reviewed-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/dss/hdmi4.c | 13 ++--- drivers/gpu/drm/omapdrm/dss

[PATCHv2 5/6] dra7.dtsi/omap5.dtsi: add cec clock

2021-03-02 Thread Hans Verkuil
Add cec clock to the dra7 and omap5 device trees. Signed-off-by: Hans Verkuil Acked-by: Tony Lindgren --- arch/arm/boot/dts/dra7.dtsi | 5 +++-- arch/arm/boot/dts/omap5.dtsi | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot

[PATCHv2 6/6] drm/omapdrm/dss/hdmi5: add CEC support

2021-03-02 Thread Hans Verkuil
Add HDMI CEC support for OMAP5. Signed-off-by: Hans Verkuil --- drivers/gpu/drm/omapdrm/Kconfig | 8 + drivers/gpu/drm/omapdrm/Makefile | 1 + drivers/gpu/drm/omapdrm/dss/hdmi.h | 1 + drivers/gpu/drm/omapdrm/dss/hdmi5.c | 63 +-- drivers/gpu/drm/omapdrm

Re: [PATCHv2 6/6] drm/omapdrm/dss/hdmi5: add CEC support

2021-03-02 Thread Hans Verkuil
On 03/03/2021 08:47, Tomi Valkeinen wrote: > On 02/03/2021 18:24, Hans Verkuil wrote: >> Add HDMI CEC support for OMAP5. >> >> Signed-off-by: Hans Verkuil >> --- >> drivers/gpu/drm/omapdrm/Kconfig | 8 + >> drivers/gpu/drm/omapdrm/Makefi

Re: [PATCH 0/7] sunxi: Remove the calls to dma_direct_set_offset

2020-11-12 Thread Hans Verkuil
On 06/11/2020 16:14, Maxime Ripard wrote: > Hi, > > Here's an attempt to removing the dma_direct_set_offset calls we have in > numerous drivers and move all those quirks into a global notifier as suggested > by Robin. For patches 4-7: Acked-by: Hans Verkuil It's fin

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Hans Verkuil
ffects > the zerocopy userptr usage enabled in 50ac952d2263 ("[media] > videobuf2-dma-sg: Support io userptr operations on io memory"). > > Acked-by: Tomasz Figa Acked-by: Hans Verkuil Thanks! Hans > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe >

Re: [PATCH v6 06/17] media: videobuf2: Move frame_vector into media subsystem

2020-11-20 Thread Hans Verkuil
Hubbard > Acked-by: Mauro Carvalho Chehab > Acked-by: Tomasz Figa Acked-by: Hans Verkuil Thanks! Hans > Signed-off-by: Daniel Vetter > Cc: Jason Gunthorpe > Cc: Pawel Osciak > Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Tomasz Figa > Cc: Mauro C

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Hans Verkuil
On 20/11/2020 09:06, Hans Verkuil wrote: > On 19/11/2020 15:41, Daniel Vetter wrote: >> The media model assumes that buffers are all preallocated, so that >> when a media pipeline is running we never miss a deadline because the >> buffers aren't allocated or available.

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Hans Verkuil
On 20/11/2020 10:18, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 9:28 AM Hans Verkuil wrote: >> >> On 20/11/2020 09:06, Hans Verkuil wrote: >>> On 19/11/2020 15:41, Daniel Vetter wrote: >>>> The media model assumes that buffers are all preallocated, s

Re: [PATCH v6 09/17] media/videbuf1|2: Mark follow_pfn usage as unsafe

2020-11-20 Thread Hans Verkuil
On 20/11/2020 11:51, Daniel Vetter wrote: > On Fri, Nov 20, 2020 at 11:39 AM Hans Verkuil wrote: >> >> On 20/11/2020 10:18, Daniel Vetter wrote: >>> On Fri, Nov 20, 2020 at 9:28 AM Hans Verkuil wrote: >>>> >>>> On 20/11/2020 09:06, Hans Verkuil

Re: [PATCH 5/5] spi: make remove callback a void function

2022-02-19 Thread Hans Verkuil
- > drivers/leds/leds-spi-byte.c | 4 +--- > drivers/media/spi/cxd2880-spi.c | 4 +--- > drivers/media/spi/gs1662.c| 4 +--- > drivers/media/tuners/msi001.c | 3 +-- A bit late, but for drivers/media: Acked-by: Hans Verkuil Thanks! Hans

Re: [PATCH v11 24/34] media: staging: tegra-vde: Support generic power domain

2021-09-13 Thread Hans Verkuil
rtser # PAZ00 T20 > Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 > Tested-by: Matt Merhar # Ouya T30 > Signed-off-by: Dmitry Osipenko Acked-by: Hans Verkuil Regards, Hans > --- > drivers/staging/media/tegra-vde/vde.c | 57 +-- >

Re: [PATCH v11 22/34] media: dt: bindings: tegra-vde: Convert to schema

2021-09-13 Thread Hans Verkuil
On 12/09/2021 22:08, Dmitry Osipenko wrote: > Convert NVIDIA Tegra video decoder binding to schema. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Osipenko Acked-by: Hans Verkuil Regards, Hans > --- > .../bindings/media/nvidia,tegra-v

Re: [PATCH v11 23/34] media: dt: bindings: tegra-vde: Document OPP and power domain

2021-09-13 Thread Hans Verkuil
On 12/09/2021 22:08, Dmitry Osipenko wrote: > Document new OPP table and power domain properties of the video decoder > hardware. > > Reviewed-by: Rob Herring > Signed-off-by: Dmitry Osipenko Acked-by: Hans Verkuil Regards, Hans > --- > .../devicetree/bindin

Re: [PATCH v2 2/2] qcom_scm: hide Kconfig symbol

2021-10-11 Thread Hans Verkuil
_SUNXI, drop the 'select RESET_CONTROLLER' statement. >According to my testing this still builds fine, and the QCOM >platform selects this symbol already. Acked-by: Hans Verkuil Thanks, Hans > > Acked-by: Kalle Valo > Acked-by: Alex Elder > Signe

Re: [PATCH v10 00/13] Clean up "mediatek,larb"

2022-01-17 Thread Hans Verkuil
Hi Matthias, On 1/17/22 12:49, Matthias Brugger wrote: > > > On 17/01/2022 11:27, AngeloGioacchino Del Regno wrote: >> Il 17/01/22 08:04, Yong Wu ha scritto: >>> MediaTek IOMMU block diagram always like below: >>> >>> M4U >>>   | >>> smi-common >>>   | >>>    --

Re: [PATCH v9 12/15] media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm

2022-01-21 Thread Hans Verkuil
Hi Matthias, On 1/13/22 17:10, Matthias Brugger wrote: > Hi Hans, > > On 13/01/2022 11:15, Hans Verkuil wrote: >> On 13/01/2022 11:11, AngeloGioacchino Del Regno wrote: >>> Il 11/01/22 11:57, AngeloGioacchino Del Regno ha scritto: >>>> Il 12/11/21 11:55,

Re: [PATCH v10 00/13] Clean up "mediatek,larb"

2022-01-31 Thread Hans Verkuil
On 1/17/22 12:49, Matthias Brugger wrote: > > > On 17/01/2022 11:27, AngeloGioacchino Del Regno wrote: >> Il 17/01/22 08:04, Yong Wu ha scritto: >>> MediaTek IOMMU block diagram always like below: >>> >>> M4U >>>   | >>> smi-common >>>   | >>>    - >>>

[PATCH] drm/nouveau: hdmigv100.c: fix corrupted HDMI Vendor InfoFrame

2021-11-10 Thread Hans Verkuil
gv100_hdmi_ctrl() writes vendor_infoframe.subpack0_high to 0x6f0110, and then overwrites it with 0. Just drop the overwrite with 0, that's clearly a mistake. Because of this issue the HDMI VIC is 0 instead of 1 in the HDMI Vendor InfoFrame when transmitting 4kp30. Signed-off-by: Hans Ve

[PATCH] drm/nouveau: set RGB quantization range to FULL

2021-11-10 Thread Hans Verkuil
e in their EDID will understand that full range is transmitted by the HDMI output. This is consistent to how the Nvidia's driver behaves. Signed-off-by: Hans Verkuil --- diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index d7b9f7f8c9e3..b05c01927fe6

Re: [PATCH v9 00/15] Clean up "mediatek,larb"

2021-12-06 Thread Hans Verkuil
Hi Yong Wu, On 12/11/2021 11:54, Yong Wu wrote: > MediaTek IOMMU block diagram always like below: > > M4U > | > smi-common > | > - > | | ... > | | > larb1 larb2 > | | > vdec venc > > All the consumer connect wit

Re: [PATCH v9 00/15] Clean up "mediatek,larb"

2021-12-06 Thread Hans Verkuil
On 06/12/2021 12:52, Joerg Roedel wrote: > On Fri, Nov 12, 2021 at 06:54:54PM +0800, Yong Wu wrote: >> Yong Wu (14): >> dt-binding: mediatek: Get rid of mediatek, larb for multimedia HW >> iommu/mediatek-v1: Free the existed fwspec if the master dev already >> has >> iommu/mediatek: Retur

Re: [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2020-12-17 Thread Hans Verkuil
Hi Maxime, On 10/12/2020 14:46, Maxime Ripard wrote: > Hi, > > Here's a series introducing the CEC support for the BCM2711 found on the > RaspberryPi4. > > The BCM2711 HDMI controller uses a similar layout for the CEC registers, the > main difference being that the interrupt handling part is now

Re: [PATCH 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2020-12-18 Thread Hans Verkuil
On 17/12/2020 11:49, Maxime Ripard wrote: > Hi Hans, > > On Wed, Dec 16, 2020 at 01:35:43PM +0100, Hans Verkuil wrote: >> Hi Maxime, >> >> On 10/12/2020 14:46, Maxime Ripard wrote: >>> Hi, >>> >>> Here's a series introducing th

Re: [PATCH v3 1/4] dp/dp_mst: Add support for sink event notify messages

2021-01-12 Thread Hans Verkuil
Hi Sam, This series still hasn't been merged. It still applies cleanly to v5.11-rc1. Daniel, can you merge this series for 5.12? Or Ack this series so I can merge it? The first three patches deal with DP MST support, and this needs review from you or David. Regards, Hans On 23/09/202

Re: [PATCH v2 00/15] drm/vc4: hdmi: Add CEC support for the BCM2711

2021-01-13 Thread Hans Verkuil
Hi Maxime, On 11/01/2021 15:22, Maxime Ripard wrote: > Hi, > > Here's a series introducing the CEC support for the BCM2711 found on the > RaspberryPi4. > > The BCM2711 HDMI controller uses a similar layout for the CEC registers, the > main difference being that the interrupt handling part is now

Re: [PATCH v9 12/15] media: mtk-vcodec: enc: Remove mtk_vcodec_release_enc_pm

2022-01-13 Thread Hans Verkuil
On 13/01/2022 11:11, AngeloGioacchino Del Regno wrote: > Il 11/01/22 11:57, AngeloGioacchino Del Regno ha scritto: >> Il 12/11/21 11:55, Yong Wu ha scritto: >>> After this patchset, mtk_vcodec_release_enc_pm has only one line. >>> then remove that function, use pm_runtime_disable instead. >>> >>> m

[PATCHv15 15/15] cec: add ARC and CDC support

2016-04-25 Thread Hans Verkuil
From: Hans Verkuil Preliminary ARC and CDC support. Untested and experimental! Signed-off-by: Hans Verkuil --- .../DocBook/media/v4l/cec-ioc-adap-g-caps.xml | 10 ++ Documentation/DocBook/media/v4l/cec-ioc-g-mode.xml | 36 Documentation/cec.txt | 75

[RFC PATCH 0/3] OMAP4 HDMI CEC support

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil This patch series sits on top of my earlier HDMI CEC framework: http://www.spinics.net/lists/linux-media/msg99847.html It is an RFC patch for now as I want to clean up hdmi_cec a bit more and do a bit more testing. Many thanks to Tomi for finding obscure problems in the

[RFC PATCH 2/3] omap4: add CEC support

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Signed-off-by: Hans Verkuil --- arch/arm/boot/dts/omap4-panda-a4.dts | 2 +- arch/arm/boot/dts/omap4-panda-es.dts | 2 +- arch/arm/boot/dts/omap4.dtsi | 5 +- drivers/gpu/drm/omapdrm/dss/Kconfig| 8 + drivers/gpu/drm/omapdrm/dss/Makefile | 3

[RFC PATCH 1/3] drm/omap: fix OMAP4 hdmi_core_powerdown_disable()

2016-04-29 Thread Hans Verkuil
e, and none of those interrupts are used at the moment. CEC functionality requires core interrupts, and the PD mode needs to be fixed. This patch fixes hdmi_core_powerdown_disable() to actually disable the PD mode. Signed-off-by: Tomi Valkeinen Reported-by: Hans Verkuil --- drivers/gpu/drm/omap

[RFC PATCH 3/3] encoder-tpd12s015: keep the ls_oe_gpio on while the phys_addr is valid

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil As long as there is a valid physical address in the EDID and the omap CEC support is enabled, then we keep ls_oe_gpio on to ensure the CEC signal is passed through the tpd12s015. Signed-off-by: Hans Verkuil Suggested-by: Tomi Valkeinen --- drivers/gpu/drm/omapdrm/displays

[PATCHv16 00/13] HDMI CEC framework

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Hi all, The sixteenth version of this patchset does some final cleanup and I'll post a pull request on the linux-media list for this patch series. At first I didn't want to post a v16 at all, but there were just a bit too many changes, even though each change

[PATCHv16 01/13] input.h: add BUS_CEC type

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Inputs can come in over the HDMI CEC bus, so add a new type for this. Signed-off-by: Hans Verkuil Acked-by: Dmitry Torokhov --- include/uapi/linux/input.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/input.h b/include/uapi/linux/input.h index

[PATCHv16 03/13] rc: Add HDMI CEC protocol handling

2016-04-29 Thread Hans Verkuil
From: Kamil Debski Add handling of remote control events coming from the HDMI CEC bus. This patch includes a new keymap that maps values found in the CEC messages to the keys pressed and released. Also, a new protocol has been added to the core. Signed-off-by: Kamil Debski Signed-off-by: Hans

[PATCHv16 02/13] HID: add HDMI CEC specific keycodes

2016-04-29 Thread Hans Verkuil
From: Kamil Debski Add HDMI CEC specific keycodes to the keycodes definition. Signed-off-by: Kamil Debski Signed-off-by: Hans Verkuil Acked-by: Dmitry Torokhov --- include/uapi/linux/input-event-codes.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a

[PATCHv16 04/13] cec: add HDMI CEC framework

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil The added HDMI CEC framework provides a generic kernel interface for HDMI CEC devices. Besides the cec module itself it also adds a cec-edid module that contains helper functions to find and manipulate the CEC physical address inside an EDID. Even if the CEC support itself is

[PATCHv16 05/13] cec/TODO: add TODO file so we know why this is still in staging

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Explain why cec.c is still in staging. Signed-off-by: Hans Verkuil --- drivers/staging/media/cec/TODO | 13 + 1 file changed, 13 insertions(+) create mode 100644 drivers/staging/media/cec/TODO diff --git a/drivers/staging/media/cec/TODO b/drivers/staging/media

[PATCHv16 06/13] cec: add compat32 ioctl support

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil The CEC ioctls didn't have compat32 support, so they returned -ENOTTY when used in a 32 bit application on a 64 bit kernel. Since all the CEC ioctls are 32-bit compatible adding support for this API is trivial. Signed-off-by: Hans Verkuil --- fs/compat_ioctl.c

[PATCHv16 08/13] DocBook/media: add CEC documentation

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Add DocBook documentation for the CEC API. Signed-off-by: Hans Verkuil [k.debski at samsung.com: add documentation for passthrough mode] [k.debski at samsung.com: minor fixes and change of reserved field sizes] Signed-off-by: Kamil Debski Signed-off-by: Hans Verkuil

[PATCHv16 07/13] cec.txt: add CEC framework documentation

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Document the new HDMI CEC framework. Signed-off-by: Hans Verkuil [k.debski at samsung.com: add DocBook documentation by Hans Verkuil, with Signed-off-by: Kamil Debski Signed-off-by: Hans Verkuil --- Documentation/cec.txt | 267

[PATCHv16 09/13] cec: adv7604: add cec support.

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Add CEC support to the adv7604 driver. Signed-off-by: Hans Verkuil [k.debski at samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] [k.debski at samsung.com: add missing methods cec/io_write_and_or] [k.debski at samsung.com: change adv7604 to adv76xx in

[PATCHv16 10/13] cec: adv7842: add cec support

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Add CEC support to the adv7842 driver. Signed-off-by: Hans Verkuil --- drivers/media/i2c/Kconfig | 9 ++ drivers/media/i2c/adv7842.c | 368 2 files changed, 314 insertions(+), 63 deletions(-) diff --git a/drivers/media/i2c

[PATCHv16 11/13] cec: adv7511: add cec support.

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil Add CEC support to the adv7511 driver. Signed-off-by: Hans Verkuil [k.debski at samsung.com: Merged changes from CEC Updates commit by Hans Verkuil] Signed-off-by: Kamil Debski Signed-off-by: Hans Verkuil --- drivers/media/i2c/Kconfig | 9 + drivers/media/i2c/adv7511

[PATCHv16 12/13] cec: s5p-cec: Add s5p-cec driver

2016-04-29 Thread Hans Verkuil
From: Kamil Debski Add CEC interface driver present in the Samsung Exynos range of SoCs. The following files were based on work by SangPil Moon: - exynos_hdmi_cec.h - exynos_hdmi_cecctl.c Signed-off-by: Kamil Debski Signed-off-by: Hans Verkuil --- .../devicetree/bindings/media/s5p-cec.txt

[PATCHv16 13/13] vivid: add CEC emulation

2016-04-29 Thread Hans Verkuil
From: Hans Verkuil The vivid driver has been extended to provide CEC adapters for the HDMI input and HDMI outputs in order to test CEC applications. This CEC emulation is faithful to the CEC timings (i.e., it all at a snail's pace). Signed-off-by: Hans Verkuil --- Documentation/video4

omap4: how to get the HDMI core IRQ?

2016-03-31 Thread Hans Verkuil
Hi Tomi, On 03/30/2016 03:37 AM, Tomi Valkeinen wrote: > Hi Hans, > > On 24/03/16 23:20, Hans Verkuil wrote: >> Hi Tomi, >> >> I hope you (or someone else on this list) can help me find the problem in >> this code. >> >> I am working on a kernel fr

[PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code

2016-08-12 Thread Hans Verkuil
On 08/12/2016 04:15 PM, Russell King wrote: > Add a CEC driver for the dw-hdmi hardware using Hans Verkil's CEC That's Verkuil :-) BTW, since cec is part of the media subsystem please include linux-media for the next round. Regards, Hans

[PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver

2016-08-12 Thread Hans Verkuil
On 08/12/2016 04:15 PM, Russell King wrote: > Add a CEC driver for the TDA9950, which is a stand-alone I2C CEC device. > The TDA9950 contains a command processor which handles retransmissions > and the low level bus protocol. The driver just has to read and write > the messages, and handle error c

[PATCH RFC 1/5] video: add HDMI state notifier support

2016-08-12 Thread Hans Verkuil
this, so: Acked-by: Hans Verkuil Regards, Hans > Signed-off-by: Russell King > --- > drivers/video/Kconfig | 3 +++ > drivers/video/Makefile| 1 + > drivers/video/hdmi-notifier.c | 61 > +++ &g

[PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver

2016-08-12 Thread Hans Verkuil
On 08/12/2016 05:29 PM, Russell King - ARM Linux wrote: > On Fri, Aug 12, 2016 at 05:16:41PM +0200, Hans Verkuil wrote: >> On 08/12/2016 04:38 PM, Hans Verkuil wrote: >>> On 08/12/2016 04:15 PM, Russell King wrote: >>>> Add a CEC driver for the TDA9950, which i

[PATCH RFC 5/5] drm/i2c: add tda998x/tda9950 CEC driver

2016-08-12 Thread Hans Verkuil
On 08/12/2016 04:38 PM, Hans Verkuil wrote: > On 08/12/2016 04:15 PM, Russell King wrote: >> Add a CEC driver for the TDA9950, which is a stand-alone I2C CEC device. >> The TDA9950 contains a command processor which handles retransmissions >> and the low level bus protocol. T

[ANN] HDMI CEC: added cec-compliance/cec-follower utilities

2016-08-15 Thread Hans Verkuil
Two new CEC utilities have been added to the v4l-utils repository: https://git.linuxtv.org/v4l-utils.git/ The cec-follower utility can emulate a CEC device, implementing the follower functionality needed. The cec-compliance utility can test a remote CEC device and check how compliant it is again

[PATCH for v4.8] cec-edid: check for IEEE identifier

2016-08-18 Thread Hans Verkuil
identifier as well. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/cec-edid.c b/drivers/media/cec-edid.c index 7001824..5719b99 100644 --- a/drivers/media/cec-edid.c +++ b/drivers/media/cec-edid.c @@ -70,7 +70,10 @@ static unsigned int cec_get_edid_spa_location(const u8 *edid, unsigned int

[PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code

2016-08-23 Thread Hans Verkuil
Hi Russell, On 08/12/2016 04:15 PM, Russell King wrote: > Add a CEC driver for the dw-hdmi hardware using Hans Verkil's CEC > implementation. > > Signed-off-by: Russell King > --- > drivers/gpu/drm/bridge/Kconfig| 7 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers

[PATCH RFC 4/5] drm/bridge: add dw-hdmi cec driver using Hans Verkil's CEC code

2016-08-23 Thread Hans Verkuil
Hi Russell, On 08/12/16 16:15, Russell King wrote: > + ret = devm_request_threaded_irq(&pdev->dev, cec->irq, > + dw_hdmi_cec_hardirq, > + dw_hdmi_cec_thread, IRQF_SHARED, > + DEV_NAME, c

Re: [PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-05-02 Thread Hans Verkuil
Hi Maxime, On 4/17/19 9:54 AM, Maxime Ripard wrote: > V4L2 uses different fourcc's than DRM, and has a different set of formats. > For now, let's add the v4l2 fourcc's for the already existing formats. For this lib to be more useful for V4L2, would it be a good idea to add Bayer formats as well?

Re: [PATCH 00/20] drm: Split out the formats API and move it to a common place

2019-05-02 Thread Hans Verkuil
Hi Maxime, Apologies for the late reply, most if this thread happened when I was on vacation, and I missed that I should reply to it. Thank you for reminding me. Please let me know if I should reply to other mails in the discussion of this patch series. On 4/18/19 10:56 PM, Maxime Ripard wrote:

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
Hi Maxime, Some comments below... On 3/19/19 10:57 PM, Maxime Ripard wrote: > V4L2 uses different fourcc's than DRM, and has a different set of formats. > For now, let's add the v4l2 fourcc's for the already existing formats. > > Signed-off-by: Maxime Ripard > --- > include/linux/image-formats

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
On 4/11/19 9:12 AM, Hans Verkuil wrote: > Hi Maxime, > > Some comments below... > > On 3/19/19 10:57 PM, Maxime Ripard wrote: >> V4L2 uses different fourcc's than DRM, and has a different set of formats. >> For now, let's add the v4l2 fourcc's for the

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
On 4/1/19 4:44 PM, Maxime Ripard wrote: > Hi Nicolas, > > On Fri, Mar 22, 2019 at 03:55:19PM -0400, Nicolas Dufresne wrote: >> Le mardi 19 mars 2019 à 22:57 +0100, Maxime Ripard a écrit : >>> V4L2 uses different fourcc's than DRM, and has a different set of formats. >>> For now, let's add the v4l2

Re: [RFC PATCH 18/20] lib: image-formats: Add v4l2 formats support

2019-04-11 Thread Hans Verkuil
On 3/22/19 8:55 PM, Nicolas Dufresne wrote: > Le mardi 19 mars 2019 à 22:57 +0100, Maxime Ripard a écrit : >> V4L2 uses different fourcc's than DRM, and has a different set of formats. >> For now, let's add the v4l2 fourcc's for the already existing formats. > > Hopefully I get the fixup right thi

Re: [PATCH v2 0/2] drm/sun4i: dw-hdmi: Improve CEC support

2019-04-12 Thread Hans Verkuil
Hi Jernej, On 4/1/19 9:15 PM, Jernej Skrabec wrote: > It turns out that additional logic between HDMI CEC controller and > pins on PHY on some Allwinner SoCs prevents proper communication. > It might be possible to fix it, but it's much easier and less error > prone to just directly drive pins usi

  1   2   3   4   5   6   7   8   9   10   >