Yes, that patch won't change any code logic, and just a cleanup.
Thanks,
Ray
-Original Message-
From: Koenig, Christian
Sent: Monday, July 30, 2018 9:31 PM
To: Paul Menzel ; Huang, Ray
; Alex Deucher
Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: Re: Fix
.org; linaro-mm-...@lists.linaro.org; Huang, Ray
> ; Daenzer, Michel
> Cc: Daniel Vetter ; Chris Wilson ;
> Zhang, Jerry
> Subject: Re: [PATCH 1/8] dma-buf: remove shared fence staging in
> reservation object
>
> Ping once more! Adding a few more AMD people.
>
> Any comments
vger.kernel.org; linaro-mm-...@lists.linaro.org; Huang, Ray
> ; Daenzer, Michel
> Cc: Daniel Vetter ; Chris Wilson ;
> Zhang, Jerry
> Subject: Re: [PATCH 1/8] dma-buf: remove shared fence staging in
> reservation object
>
> Ping once more! Adding a few more AMD people.
&g
> -Original Message-
> From: YueHaibing [mailto:yuehaib...@huawei.com]
> Sent: Thursday, November 08, 2018 10:15 AM
> To: Koenig, Christian ; Huang, Ray
> ; Zhang, Jerry ; David Airlie
>
> Cc: YueHaibing ; dri-devel@lists.freedesktop.org;
> linux-ker...@vger.
> -Original Message-
> From: YueHaibing [mailto:yuehaib...@huawei.com]
> Sent: Thursday, November 15, 2018 6:52 PM
> To: Deucher, Alexander ; Koenig, Christian
> ; Zhou, David(ChunMing)
> ; airl...@linux.ie; Liu, Shaoyun
> ; Francis, David ; Huang,
> Ray ; Xu, Fei
> -Original Message-
> From: Kangjie Lu [mailto:k...@umn.edu]
> Sent: Wednesday, December 26, 2018 2:24 PM
> To: k...@umn.edu
> Cc: pakki...@umn.edu; Deucher, Alexander
> ; Koenig, Christian
> ; Zhou, David(ChunMing)
> ; David Airlie ; Daniel Vetter
> ; Zhu,
Also looks for me. Thanks Thomas.
Reviewed-by: Huang Rui
> -Original Message-
> From: Koenig, Christian
> Sent: Friday, January 25, 2019 7:29 PM
> To: Thomas Zimmermann ; Huang, Ray
> ; Zhang, Jerry ;
> airl...@redhat.com; bske...@redhat.com; linux-graphics-
>
> -Original Message-
> From: Julia Lawall [mailto:julia.law...@lip6.fr]
> Sent: Saturday, March 02, 2019 2:51 PM
> To: Gao, Likun
> Cc: Deucher, Alexander ; Wang, Kevin(Yang)
> ; Quan, Evan ; Koenig,
> Christian ; David Airlie ;
> Daniel Vetter
> -Original Message-
> From: Dan Carpenter
> Sent: Wednesday, May 15, 2019 5:52 PM
> To: Deucher, Alexander ; Wang, Kevin(Yang)
>
> Cc: Koenig, Christian ; Zhou, David(ChunMing)
> ; David Airlie ; Daniel Vetter
> ; Huang, Ray ; Gao, Likun
> ; Gui, Jack ; amd-
&
> -Original Message-
> From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
> Sent: Monday, April 08, 2019 9:13 PM
> To: Zhang, Jerry ; Huang, Ray
> ; amd-...@lists.freedesktop.org; dri-
> de...@lists.freedesktop.org
> Subject: [PATCH 2/2] drm/ttm: fix sta
> -Original Message-
> From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com]
> Sent: Monday, April 08, 2019 9:13 PM
> To: Zhang, Jerry ; Huang, Ray
> ; amd-...@lists.freedesktop.org; dri-
> de...@lists.freedesktop.org
> Subject: [PATCH 1/2] drm/ttm: f
On Wed, Sep 11, 2019 at 08:13:19PM +0800, Koenig, Christian wrote:
> Am 11.09.19 um 13:50 schrieb Huang, Ray:
> > From: Alex Deucher
> >
> > If one bo is secure (created with AMDGPU_GEM_CREATE_ENCRYPTED), the TMZ
> > bits of
> > PTEs that belongs that b
Hi all,
These series of patches introduce a feature to support secure buffer object.
The Trusted Memory Zone (TMZ) is a method to protect the contents being written
to and read from memory. We use TMZ hardware memory protection scheme to
implement the secure buffer object support.
TMZ is the
Add a function to check tmz capability with kernel parameter and ASIC type.
v2: use a per device tmz variable instead of global amdgpu_tmz.
v3: refine the comments for the function. (Luben)
v4: add amdgpu_tmz.c/h for future use.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
This patch to add amdgpu_tmz structure which stores all tmz related fields.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_tmz.h | 36 +
2 files changed, 41
This patch is to add a helper to get corresponding buffer object with a pointer
to a struct ttm_mem_reg.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
include/drm/ttm/ttm_bo_driver.h | 13 +
1 file changed, 13 insertions(+)
diff --git a/include/drm/ttm/ttm_bo_driver.h
amdgpu_ttm_tt_pte_flags will be used for updating tmz bits while the bo is
secure, so we need pass the ttm_mem_reg under a buffer object.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 18 ++
1 file changed, 10 insertions(+), 8
From: Alex Deucher
If one bo is secure (created with AMDGPU_GEM_CREATE_ENCRYPTED), the TMZ bits of
PTEs that belongs that bo should be set. Then psp is able to protect the pages
of this bo to avoid the access from an "untrust" domain such as CPU.
v1: design and draft the skeletion of tmz bits
While user mode submit a command with secure context, we should set the command
buffer with trusted mode.
v2: fix the null job pointer while in vmid 0 submission.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 +
This patch expands the context control function to support trusted flag while we
want to set command buffer in trusted mode.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 5 +++--
From: Alex Deucher
Add a flag to the GEM_CREATE ioctl to create encrypted buffers.
Buffers with this flag set will be created with the TMZ bit set
in the PTEs or engines accessing them. This is required in order
to properly access the data from the engines.
Signed-off-by: Alex Deucher
From: Alex Deucher
Add a flag for when allocating a context to flag it as
secure. The kernel driver will use this flag to determine
whether a rendering context is secure or not so that the
engine can be transitioned between secure or unsecure
or the work can be submitted to a secure queue
The is_secure flag will indicate the current conext is protected or not.
v2: while user mode asks to create a context, but if tmz is disabled, it should
return failure.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 19 +++
From: Alex Deucher
Define the TMZ (encryption) bit in the page table entry (PTE) for
Raven and newer asics.
Signed-off-by: Alex Deucher
Reviewed-by: Huang Rui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
This patch adds tmz parameter to enable/disable the feature in the amdgpu kernel
module. Nomally, by default, it should be auto (rely on the hardware
capability).
But right now, it need to set "off" to avoid breaking other developers'
work because it's not totally completed.
Will set "auto" till
This patch adds tmz bit in frame control pm4 packet, and it will used in future.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/nvd.h| 1 +
drivers/gpu/drm/amd/amdgpu/soc15d.h | 1 +
2 files changed, 2 insertions(+)
diff --git
This patch expands the emit_tmz function to support trusted flag while we want
to set command buffer in trusted mode.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 4 ++--
May I know the all firmware version in your system?
Thanks,
Ray
From: Kai-Heng Feng
Sent: Wednesday, August 7, 2019 8:50 PM
To: Huang, Ray
Cc: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); amd-gfx list;
dri-devel@lists.freedesktop.org; LKML
> -Original Message-
> From: Kai-Heng Feng
> Sent: Thursday, August 08, 2019 1:45 AM
> To: Huang, Ray
> Cc: Deucher, Alexander ; Koenig, Christian
> ; Zhou, David(ChunMing)
> ; amd-gfx list ;
> dri-devel@lists.freedesktop.org; LKML ;
> Anthony Wong
>
> -Original Message-
> From: Michel Dänzer
> Sent: Thursday, August 08, 2019 4:10 PM
> To: Huang, Ray ; Kai-Heng Feng
>
> Cc: Zhou, David(ChunMing) ; LKML ker...@vger.kernel.org>; dri-devel@lists.freedesktop.org; Anthony Wong
> ; amd-gfx list g...@lists.f
Mark a job as secure, if and only if the command
submission flag has the secure flag set.
v2: fix the null job pointer while in vmid 0
submission.
v3: Context --> Command submission.
v4: filling cs parser with cs->in.flags
v5: move the job secure flag setting out of amdgpu_cs_submit()
> -Original Message-
> From: Koenig, Christian
> Sent: Thursday, September 12, 2019 7:49 PM
> To: Huang, Ray
> Cc: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org;
> Deucher, Alexander ; Tuikov, Luben
> ; Liu, Aaron
> Subject: Re: [PATCH 14/14]
Ahh.
Reviewed-by: Huang Rui
-Original Message-
From: amd-gfx On Behalf Of Christian
König
Sent: Wednesday, October 2, 2019 4:38 AM
To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/ttm: also export ttm_bo_vm_fault
Just a gentle ping on
Reviewed-by: Huang Rui
-Original Message-
From: amd-gfx On Behalf Of Christian
König
Sent: Friday, September 27, 2019 8:34 AM
To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org
Subject: [PATCH 2/2] drm/radeon: finally fix the racy VMA setup
Finally clean up the VMA
Reviewed-by: Huang Rui
-Original Message-
From: amd-gfx On Behalf Of Christian
König
Sent: Thursday, October 24, 2019 7:17 PM
To: dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Zhou,
David(ChunMing)
Subject: [PATCH] drm/ttm: use the parent resv for ghost objects v3
This patch to add amdgpu_tmz structure which stores all tmz related fields.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_tmz.h | 36 +
2 files changed, 41
From: Alex Deucher
Define the TMZ (encryption) bit in the page table entry (PTE) for
Raven and newer asics.
Signed-off-by: Alex Deucher
Reviewed-by: Huang Rui
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 3 +++
1 file changed, 3 insertions(+)
diff --git
From: Alex Deucher
Add a flag to the GEM_CREATE ioctl to create encrypted buffers.
Buffers with this flag set will be created with the TMZ bit set
in the PTEs or engines accessing them. This is required in order
to properly access the data from the engines.
Signed-off-by: Alex Deucher
This patch adds tmz parameter to enable/disable the feature in the amdgpu kernel
module. Nomally, by default, it should be auto (rely on the hardware
capability).
But right now, it need to set "off" to avoid breaking other developers'
work because it's not totally completed.
Will set "auto" till
From: Luben Tuikov
Add a flag to the command submission IOCTL
structure which when present indicates that this
command submission should be treated as
secure. The kernel driver uses this flag to
determine whether the engine should be
transitioned to secure or unsecure, or the work
can be
Hi all,
These series of patches introduce a feature to support secure buffer object.
The Trusted Memory Zone (TMZ) is a method to protect the contents being written
to and read from memory. We use TMZ hardware memory protection scheme to
implement the secure buffer object support.
TMZ is the
Mark a job as secure, if and only if the command
submission flag has the secure flag set.
v2: fix the null job pointer while in vmid 0
submission.
v3: Context --> Command submission.
v4: filling cs parser with cs->in.flags
Signed-off-by: Huang Rui
Co-developed-by: Luben Tuikov
Signed-off-by:
> -Original Message-
> From: Koenig, Christian
> Sent: Wednesday, September 25, 2019 10:47 PM
> To: Huang, Ray ; amd-...@lists.freedesktop.org; dri-
> de...@lists.freedesktop.org; Deucher, Alexander
>
> Cc: Tuikov, Luben ; Liu, Aaron
>
> Subject: Re: [PATC
This patch adds tmz bit in frame control pm4 packet, and it will used in future.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/nvd.h| 1 +
drivers/gpu/drm/amd/amdgpu/soc15d.h | 1 +
2 files changed, 2 insertions(+)
diff
Add a function to check tmz capability with kernel parameter and ASIC type.
v2: use a per device tmz variable instead of global amdgpu_tmz.
v3: refine the comments for the function. (Luben)
v4: add amdgpu_tmz.c/h for future use.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
---
This patch expands the emit_tmz function to support trusted flag while we want
to set command buffer in trusted mode.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h |
From: Alex Deucher
If a buffer object is secure, i.e. created with
AMDGPU_GEM_CREATE_ENCRYPTED, then the TMZ bit of
the PTEs that belong the buffer object should be
set.
v1: design and draft the skeletion of TMZ bits setting on PTEs (Alex)
v2: return failure once create secure BO on non-TMZ
This patch expands the context control function to support trusted flag while we
want to set command buffer in trusted mode.
Signed-off-by: Huang Rui
Reviewed-by: Alex Deucher
Acked-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
Mark a job as secure, if and only if the command
submission flag has the secure flag set.
v2: fix the null job pointer while in vmid 0
submission.
v3: Context --> Command submission.
Signed-off-by: Huang Rui
Co-developed-by: Luben Tuikov
Signed-off-by: Luben Tuikov
Reviewed-by: Alex Deucher
Looks good for me.
Reviewed-by: Huang Rui
-Original Message-
From: Christian König
Sent: Monday, June 7, 2021 8:52 PM
To: dri-devel@lists.freedesktop.org; Pan, Xinhui ; Das,
Nirmoy ; Huang, Ray
Cc: Thomas Hellström
Subject: Re: [PATCH] drm/ttm: fix deref of bo->ttm without hold
[AMD Official Use Only]
> -Original Message-
> From: Christian König
> Sent: Thursday, October 21, 2021 5:06 PM
> To: Alex Deucher ; Huang, Ray
>
> Cc: Maling list - DRI developers
> Subject: Re: [PATCH] drm/ttm: fix memleak in ttm_transfered_destroy
>
>
[AMD Official Use Only]
> -Original Message-
> From: Koenig, Christian
> Sent: Tuesday, December 14, 2021 5:24 PM
> To: Huang, Ray ; dri-devel@lists.freedesktop.org;
> Daniel Vetter ; Sumit Semwal
>
> Cc: amd-...@lists.freedesktop.org; linux-me...@vger.kernel.org;
[AMD Official Use Only]
> -Original Message-
> From: Koenig, Christian
> Sent: Tuesday, December 14, 2021 4:01 PM
> To: Huang, Ray ; dri-devel@lists.freedesktop.org;
> Daniel Vetter ; Sumit Semwal
>
> Cc: amd-...@lists.freedesktop.org; linux-me...@vger.kernel.org;
[AMD Official Use Only]
> -Original Message-
> From: Koenig, Christian
> Sent: Tuesday, December 14, 2021 4:00 PM
> To: Huang, Ray ; dri-devel@lists.freedesktop.org;
> Daniel Vetter ; Sumit Semwal
>
> Cc: amd-...@lists.freedesktop.org; linux-me...@vger.kernel.org;
[AMD Official Use Only]
> -Original Message-
> From: Koenig, Christian
> Sent: Tuesday, December 14, 2021 8:26 PM
> To: Huang, Ray ; dri-devel@lists.freedesktop.org;
> Daniel Vetter ; Sumit Semwal
>
> Cc: amd-...@lists.freedesktop.org; linux-me...@vger.kernel.org;
To: Huang, Ray ; dri-devel@lists.freedesktop.org; Koenig,
Christian ; Daniel Vetter ;
Sumit Semwal
Cc: Deucher, Alexander ;
amd-...@lists.freedesktop.org; Liu, Monk ;
linux-me...@vger.kernel.org
Subject: Re: [PATCH v2] drm/amdgpu: introduce new amdgpu_fence object to
indicate the job embedded
56 matches
Mail list logo
