NULL derefs after failed suspend (i915, pm, ext4, slub)

2014-11-19 Thread Johan Hovold
On Tue, Oct 28, 2014 at 03:29:10PM +0100, Johan Hovold wrote: > Hi, > > I have had some problems with crashes involving suspend-to-disk after > updating to v3.16. > > Below is a log with 3.16.6 from a failed suspend attempt after which I > get a NULL deref in ext4 code. &

NULL derefs after failed suspend (i915, pm, ext4, slub)

2014-10-28 Thread Johan Hovold
Hi, I have had some problems with crashes involving suspend-to-disk after updating to v3.16. Below is a log with 3.16.6 from a failed suspend attempt after which I get a NULL deref in ext4 code. A couple of weeks ago I got something similar, with backtraces from ext4 (ext4_alloc_inode) and

NULL derefs after failed suspend (i915, pm, ext4, slub)

2014-10-29 Thread Johan Hovold
On Tue, Oct 28, 2014 at 05:06:01PM +0200, Jani Nikula wrote: > On Tue, 28 Oct 2014, Johan Hovold wrote: > > Hi, > > > > I have had some problems with crashes involving suspend-to-disk after > > updating to v3.16. > > > > Below is a log with 3.16.6 from

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-15 Thread Johan Hovold
On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: > On 13/11/17 10:20, Johan Hovold wrote: > > Fix child-node lookup during probe, which ended up searching the whole > > device tree depth-first starting at the parent rather than just matching > > on its child

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-16 Thread Johan Hovold
On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > On 14/11/17 18:05, Johan Hovold wrote: > > On Mon, Nov 13, 2017 at 02:16:09PM +, Daniel Thompson wrote: > >> On 13/11/17 10:20, Johan Hovold wrote: > >>> Fix child-node lookup during probe, whic

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-16 Thread Johan Hovold
On Wed, Nov 15, 2017 at 02:32:11PM +, Lee Jones wrote: > On Wed, 15 Nov 2017, Johan Hovold wrote: > > > On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > > > On 14/11/17 18:05, Johan Hovold wrote: > > > > On Mon, Nov 13, 2017 at 02:16:

[PATCH 3/3] backlight: tps65217_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
n the tree. Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver") Cc: stable <sta...@vger.kernel.org> # 3.7 Cc: Matthias Kaehlcke <matth...@kaehlcke.net> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/tps65217_bl.c | 4 ++-- 1 file

[PATCH] video: fbdev: atmel_lcdfb: fix display-timings lookup

2017-11-13 Thread Johan Hovold
oft.com> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/fbdev/atmel_lcdfb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index e06358da4b99..3dee267d7c75 100644 --- a/drive

[PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
liakhovet...@gmx.de> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/as3711_bl.c | 35 +-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/video/backlight/as3711_bl.c b/drivers/video/backlight/as3711_bl.c inde

[PATCH 2/3] backlight: max8925_bl: fix device-tree node lookup

2017-11-13 Thread Johan Hovold
("mfd: max8925: Support dt for backlight") Cc: stable <sta...@vger.kernel.org> # 3.9 Cc: Qing Xu <qi...@marvell.com> Cc: Haojian Zhuang <haojian.zhu...@gmail.com> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/max8925_bl.c | 4 +++-

[PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup

2017-11-21 Thread Johan Hovold
: add OF support") Cc: stable <sta...@vger.kernel.org> # 3.10 Cc: Guennadi Liakhovetski <g.liakhovet...@gmx.de> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/as3711_bl.c | 33 +++-- 1 file changed, 23 insertions(+),

[PATCH v2 0/4] backlight: fix device-tree node lookups

2017-11-21 Thread Johan Hovold
leaks in as3711_bl instead of marking the leaks using FIXMEs in patch 1/4 Johan Hovold (4): backlight: as3711_bl: fix device-tree node lookup backlight: max8925_bl: fix device-tree node lookup backlight: tps65217_bl: fix device-tree node lookup backlight: as3711_bl: fix device-tree

[PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup

2017-11-21 Thread Johan Hovold
n the tree. Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver") Cc: stable <sta...@vger.kernel.org> # 3.7 Cc: Matthias Kaehlcke <matth...@kaehlcke.net> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/tps65217_bl.c | 4 ++-- 1 file

[PATCH v2 2/4] backlight: max8925_bl: fix device-tree node lookup

2017-11-21 Thread Johan Hovold
("mfd: max8925: Support dt for backlight") Cc: stable <sta...@vger.kernel.org> # 3.9 Cc: Qing Xu <qi...@marvell.com> Cc: Haojian Zhuang <haojian.zhu...@gmail.com> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/max8925_bl.c | 4 +++-

Re: [PATCH 1/3] backlight: as3711_bl: fix device-tree node lookup

2017-11-21 Thread Johan Hovold
On Wed, Nov 15, 2017 at 03:39:09PM +0100, Johan Hovold wrote: > On Wed, Nov 15, 2017 at 02:32:11PM +, Lee Jones wrote: > > On Wed, 15 Nov 2017, Johan Hovold wrote: > > > > > On Tue, Nov 14, 2017 at 07:48:09PM +, Daniel Thompson wrote: > > > > O

[PATCH v2 4/4] backlight: as3711_bl: fix device-tree node leaks

2017-11-21 Thread Johan Hovold
: Guennadi Liakhovetski <g.liakhovet...@gmx.de> Signed-off-by: Johan Hovold <jo...@kernel.org> --- drivers/video/backlight/as3711_bl.c | 12 ++-- include/linux/mfd/as3711.h | 4 ++-- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/video/backlight/

Re: [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup

2017-11-21 Thread Johan Hovold
On Mon, Nov 20, 2017 at 11:34:07AM +, Daniel Thompson wrote: > > > On 20/11/17 10:45, Johan Hovold wrote: > > Fix child-node lookup during probe, which ended up searching the whole > > device tree depth-first starting at the parent rather than just matchin

Re: [PATCH v2 0/4] backlight: fix device-tree node lookups

2018-05-11 Thread Johan Hovold
Hi Lee, On Mon, Nov 20, 2017 at 11:45:43AM +0100, Johan Hovold wrote: > A number of drivers have been using the wrong OF helper when doing child-node > lookups during probe. This meant that they were doing tree-wide searches > rather > than matching on child nodes and that the paren

Re: [PATCH 1/4] drm/msm: fix memleak on release

2019-10-30 Thread Johan Hovold
On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > If a process is interrupted while accessing the "gpu" debugfs file and > the drm device struct_mutex is contended, release() could return early > and fail to free related resources. > > Note that the

Re: [PATCH 1/4] drm/msm: fix memleak on release

2019-11-12 Thread Johan Hovold
On Wed, Oct 30, 2019 at 11:01:46AM +0100, Johan Hovold wrote: > On Thu, Oct 10, 2019 at 03:13:30PM +0200, Johan Hovold wrote: > > If a process is interrupted while accessing the "gpu" debugfs file and > > the drm device struct_mutex is contended, release() could return e

Re: [PATCH 0/4] treewide: fix interrupted release

2019-10-21 Thread Johan Hovold
On Tue, Oct 15, 2019 at 04:07:26PM +0200, Daniel Vetter wrote: > On Mon, Oct 14, 2019 at 06:13:26PM +0200, Johan Hovold wrote: > > On Mon, Oct 14, 2019 at 10:48:47AM +0200, Daniel Vetter wrote: > > > Do you have a legit usecase for interruptible sleeps in fops->release? &

[PATCH 3/4] media: radio: wl1273: fix interrupt masking on release

2019-10-10 Thread Johan Hovold
o: TI WL1273 FM radio driver") Cc: stable # 2.6.38 Cc: Matti Aaltonen Cc: Mauro Carvalho Chehab Signed-off-by: Johan Hovold --- drivers/media/radio/radio-wl1273.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/radio/radio-wl1273.c b/drivers/media/r

[PATCH 0/4] treewide: fix interrupted release

2019-10-10 Thread Johan Hovold
one has not even been built. Johan Johan Hovold (4): drm/msm: fix memleak on release media: bdisp: fix memleak on release media: radio: wl1273: fix interrupt masking on release s390/zcrypt: fix memleak at release drivers/gpu/drm/msm/msm_debugfs.c | 6 +- drivers/media

[PATCH 4/4] s390/zcrypt: fix memleak at release

2019-10-10 Thread Johan Hovold
berger Cc: Martin Schwidefsky Signed-off-by: Johan Hovold --- drivers/s390/crypto/zcrypt_api.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 45bdb47f84c1..9157e728a362 100644 --- a/drivers/s

[PATCH 2/4] media: bdisp: fix memleak on release

2019-10-10 Thread Johan Hovold
using v4l2 mem2mem framework") Cc: stable # 4.2 Cc: Fabien Dessenne Cc: Hans Verkuil Cc: Mauro Carvalho Chehab Signed-off-by: Johan Hovold --- drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform

[PATCH 1/4] drm/msm: fix memleak on release

2019-10-10 Thread Johan Hovold
U show function to use the GPU state") Cc: stable # 4.18 Cc: Jordan Crouse Cc: Rob Clark Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_debugfs.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_debugfs.c b/drivers/gpu/drm/msm

Re: [PATCH 0/4] treewide: fix interrupted release

2019-10-11 Thread Johan Hovold
On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote: > On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > > Two old USB drivers had a bug in them which could lead to memory leaks > > if an interrupted process raced with a disconnect event. > > >

Re: [PATCH 0/4] treewide: fix interrupted release

2019-10-14 Thread Johan Hovold
On Mon, Oct 14, 2019 at 10:48:47AM +0200, Daniel Vetter wrote: > On Fri, Oct 11, 2019 at 11:36:33AM +0200, Johan Hovold wrote: > > On Thu, Oct 10, 2019 at 03:50:43PM +0200, Daniel Vetter wrote: > > > On Thu, Oct 10, 2019 at 03:13:29PM +0200, Johan Hovold wrote: > > >

Re: [PATCH] drm: bridge: cdns-mhdp8546: Fix PM reference leak in cdns_mhdp_probe()

2021-05-18 Thread Johan Hovold
On Mon, May 17, 2021 at 11:27:38AM +0200, Robert Foss wrote: > Hey Yu, > > On Mon, 17 May 2021 at 10:08, Yu Kuai wrote: > > > > pm_runtime_get_sync will increment pm usage counter even it failed. > > Forgetting to putting operation will result in reference leak here. > > Fix it by replacing it

[PATCH] drm/udl: fix control-message timeout

2021-10-25 Thread Johan Hovold
USB control-message timeouts are specified in milliseconds and should specifically not vary with CONFIG_HZ. Fixes: 5320918b9a87 ("drm/udl: initial UDL driver (v4)") Cc: sta...@vger.kernel.org # 3.4 Signed-off-by: Johan Hovold --- drivers/gpu/drm/udl/udl_connector.c | 2 +- 1 fi

Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training

2023-10-13 Thread Johan Hovold
On Tue, Oct 03, 2023 at 11:10:59AM +0200, Johan Hovold wrote: > On Tue, Aug 08, 2023 at 03:19:50PM -0700, Kuogee Hsieh wrote: > > DP PHY re-initialization done using dp_ctrl_reinitialize_mainlink() will > > cause PLL unlocked initially and then PLL gets locked at the end of >

Re: [PATCH] drm/msm/dpu: Add missing safe_lut_tbl in sc8280xp catalog

2023-10-31 Thread Johan Hovold
n itself indeed improves things quite a bit, but there is still some performance that can be gained by using lazy iommu mode. Notably, lazy mode with this patch applied appears to saturate the link in both directions. Tested-by: Johan Hovold Johan

Re: [PATCH v1] drm/msm/dp: do not reinitialize phy unless retry during link training

2023-10-03 Thread Johan Hovold
This fixes the above warning and avoids the unnecessary PHY power-off and power-on during boot of the ThinkPad X13s: Reviewed-by: Johan Hovold Tested-by: Johan Hovold I guess this one should go to stable as well: Cc: sta...@vger.kernel.org # 5.10 Is anyone planning on getting this fixe

[PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-07-11 Thread Johan Hovold
Add an eDP panel entry for AUO B133UAN02.1. Due to lack of documentation, use the delay_200_500_e50 timings like some other AUO entries for now. Signed-off-by: Johan Hovold --- drivers/gpu/drm/panel/panel-edp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/panel/panel

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Johan Hovold
On Tue, Jul 05, 2022 at 09:29:13AM -0700, Kuogee Hsieh wrote: > 0) rebase on > https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git tree > 1) add regulator_set_load() to eDP phy > 2) add regulator_set_load() to DP phy > 3) remove vdda related function out of eDP/DP controller > >

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-21 Thread Johan Hovold
On Thu, Jul 21, 2022 at 12:56:37PM +0100, Mark Brown wrote: > On Thu, Jul 21, 2022 at 12:20:31PM +0100, Mark Brown wrote: > > > You could add a way to specify constant base loads in DT on either a per > > regulator or per consumer basis. > > ...and also note that this is only an issue if the

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-07-29 Thread Johan Hovold
Sorry about the late follow-up on this. Has been one of those constant-preemption weeks. And thanks Doug and Mark for the insightful comments in this and the dt-load RFC thread. On Thu, Jul 21, 2022 at 07:49:55AM -0700, Doug Anderson wrote: > Hi, > > On Thu, Jul 21, 2022 at 6:25 AM Dmitry

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-07-22 Thread Johan Hovold
On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > Add an eDP panel entry for AUO B133UAN02.1. > > Due to lack of documentation, use the delay_200_500_e50 timings like > some other AUO entries for now. > > Signed-off-by: Johan Hovold Any comments to this o

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-08-22 Thread Johan Hovold
On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote: > > Add an eDP panel entry for AUO B133UAN02.1. > > > > Due to lack of documentation, use the delay_200_500_e50 timings like > > som

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:21:36PM +0300, Dmitry Baryshkov wrote: > On 01/09/2022 12:20, Johan Hovold wrote: > > On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > >> Johan Hovold has reported that returning a probe deferral from the > >> msm_dp_mode

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-01 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by

Re: [PATCH] drm/panel-edp: add AUO B133UAN02.1 panel entry

2022-08-23 Thread Johan Hovold
On Mon, Aug 22, 2022 at 10:33:40AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Aug 22, 2022 at 6:35 AM Johan Hovold wrote: > > > > On Fri, Jul 22, 2022 at 11:48:40AM +0200, Johan Hovold wrote: > > > On Mon, Jul 11, 2022 at 09:52:02AM +0200, Johan Hovold wrote:

Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-28 Thread Johan Hovold
On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote: > On 9/27/2022 12:14 AM, Johan Hovold wrote: > > On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > >> On 9/13/2022 1:53 AM, Johan Hovold wrote: > >>> Drop the overly defensive modeset sanity

Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-28 Thread Johan Hovold
On Wed, Sep 28, 2022 at 08:33:52AM -0700, Abhinav Kumar wrote: > On 9/28/2022 5:24 AM, Johan Hovold wrote: > > On Tue, Sep 27, 2022 at 11:42:53AM -0700, Abhinav Kumar wrote: > >> Discussed with Rob on IRC, we will apply everything except the last two > >> patches o

Re: [PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-27 Thread Johan Hovold
On Mon, Sep 26, 2022 at 11:17:20AM -0700, Abhinav Kumar wrote: > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed-by: Dmitr

Re: [Freedreno] [PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

2022-09-27 Thread Johan Hovold
On Mon, Sep 26, 2022 at 11:21:38AM -0700, Abhinav Kumar wrote: > > > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Reviewed

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-10-21 Thread Johan Hovold
On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: > On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > > The MSM DRM driver is currently broken in multiple ways with respect to > > probe deferral. Not only does the driver currently fail to probe again &

Re: [PATCH v3 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances

2022-10-26 Thread Johan Hovold
On Tue, Oct 25, 2022 at 08:26:24PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SA8295P ADP has, among other interfaces, six MiniDP connectors which > are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. > > Enable Display Clock controllers, MDSS instanced, MDPs, DP

Re: [PATCH v3 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks

2022-10-26 Thread Johan Hovold
On Tue, Oct 25, 2022 at 08:26:22PM -0700, Bjorn Andersson wrote: > From: Bjorn Andersson > > Define the display clock controllers, the MDSS instances, the DP phys > and connect these together. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > -

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-10-24 Thread Johan Hovold
On Fri, Oct 21, 2022 at 09:05:52AM -0700, Abhinav Kumar wrote: > Hi Johan > > On 10/20/2022 11:27 PM, Johan Hovold wrote: > > On Tue, Sep 20, 2022 at 11:06:30AM +0200, Johan Hovold wrote: > >> On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > >>

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-20 Thread Johan Hovold
On Tue, Sep 13, 2022 at 10:53:10AM +0200, Johan Hovold wrote: > The MSM DRM driver is currently broken in multiple ways with respect to > probe deferral. Not only does the driver currently fail to probe again > after a late deferral, but due to a related use-after-free bug this also &

Re: [PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-14 Thread Johan Hovold
On Tue, Sep 13, 2022 at 03:23:10PM -0500, Steev Klimaszewski wrote: > Hi Johan, > > On 9/13/22 3:53 AM, Johan Hovold wrote: > > The MSM DRM driver is currently broken in multiple ways with respect to > > probe deferral. Not only does the driver currently fail to probe a

[PATCH 7/7] drm/msm: drop modeset sanity checks

2022-09-12 Thread Johan Hovold
Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +-- drivers/gpu/drm/msm/dsi/dsi.c | 7 +-- 2 files changed, 2 insertions(+), 12

[PATCH 3/7] drm/msm/dp: fix IRQ lifetime

2022-09-12 Thread Johan Hovold
to the DRM device so that it is released when bind fails. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Cc: sta...@vger.kernel.org # 5.10 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 2/7] drm/msm: fix memory corruption with too many bridges

2022-09-12 Thread Johan Hovold
") a689554ba6ed ("drm/msm: Initial add DSI connector support") Fixes: 8a3b4c17f863 ("drm/msm/dp: employ bridge mechanism for display enable and disable") Cc: sta...@vger.kernel.org # 3.12 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++

[PATCH 5/7] drm/msm/dp: fix bridge lifetime

2022-09-12 Thread Johan Hovold
("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_parser.c | 6 +++--- drivers/gpu/drm/msm/dp/dp_parser.h | 5 +++-- 3 files changed, 7 insert

[PATCH 0/7] drm/msm: probe deferral fixes

2022-09-12 Thread Johan Hovold
ter as a cleanup/optimisation. Johan Johan Hovold (7): drm/msm: fix use-after-free on probe deferral drm/msm: fix memory corruption with too many bridges drm/msm/dp: fix IRQ lifetime drm/msm/dp: fix aux-bus EP lifetime drm/msm/dp: fix bridge lifetime drm/msm/hdmi: fix IRQ lifetime

[PATCH 4/7] drm/msm/dp: fix aux-bus EP lifetime

2022-09-12 Thread Johan Hovold
er than DP controller platform device. Fixes: c3bf8e21b38a ("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/bridge/parade-ps8640.c | 2 +- drivers/gpu/drm/display/drm_dp_aux_bus.c | 5 +++-- dr

[PATCH 6/7] drm/msm/hdmi: fix IRQ lifetime

2022-09-12 Thread Johan Hovold
Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index a0ed6aa8e4e1..f28fb21e3891 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi.c +++ b/drivers/gpu/drm/msm/h

[PATCH 1/7] drm/msm: fix use-after-free on probe deferral

2022-09-12 Thread Johan Hovold
the bridge array being corrupted. Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/msm_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/msm/msm_drv.c

Re: [PATCH 1/7] drm/msm: fix use-after-free on probe deferral

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 08:52:44PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > The bridge counter was never reset when tearing down the DRM device so > > that stale pointers to deallocated structures would be accessed on the > > next tear down

Re: [PATCH 2/7] drm/msm: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 08:55:55PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > Add the missing sanity checks on the bridge counter to avoid corrupting > > data beyond the fixed-sized bridge array in case there are ever more > &g

Re: [PATCH 4/7] drm/msm/dp: fix aux-bus EP lifetime

2022-09-13 Thread Johan Hovold
On Tue, Sep 13, 2022 at 07:35:15AM +0100, Doug Anderson wrote: > Hi, > > On Mon, Sep 12, 2022 at 7:10 PM Dmitry Baryshkov > wrote: > > > > On 12/09/2022 18:40, Johan Hovold wrote: > > > Device-managed resources allocated post component bind must be tied to > &

Re: [PATCH 7/7] drm/msm: drop modeset sanity checks

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 09:06:28PM +0300, Dmitry Baryshkov wrote: > On 12/09/2022 18:40, Johan Hovold wrote: > > Drop the overly defensive modeset sanity checks of function parameters > > which have already been checked or used by the callers. > > > > Signed-off-b

Re: [PATCH 4/7] drm/msm/dp: fix aux-bus EP lifetime

2022-09-13 Thread Johan Hovold
On Mon, Sep 12, 2022 at 04:55:58PM -0500, Steev Klimaszewski wrote: > > On 9/12/22 1:10 PM, Dmitry Baryshkov wrote: > > On 12/09/2022 18:40, Johan Hovold wrote: > >> Device-managed resources allocated post component bind must be tied to > >> the lifeti

[PATCH v2 06/10] drm/msm/dp: fix aux-bus EP lifetime

2022-09-13 Thread Johan Hovold
ce. Fixes: c3bf8e21b38a ("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/dp/dp_disp

[PATCH v2 10/10] drm/msm/dsi: drop modeset sanity checks

2022-09-13 Thread Johan Hovold
Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dsi/dsi.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[PATCH v2 09/10] drm/msm/dp: drop modeset sanity checks

2022-09-13 Thread Johan Hovold
Drop the overly defensive modeset sanity checks of function parameters which have already been checked or used by the callers. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff

[PATCH v2 07/10] drm/msm/dp: fix bridge lifetime

2022-09-13 Thread Johan Hovold
("drm/msm/dp: Add eDP support via aux_bus") Cc: sta...@vger.kernel.org # 5.19 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- drivers/gpu/drm/msm/dp/dp_parser.c | 6 +++--- drivers/gpu/drm/msm/dp/dp_parser.h | 5 +++-

[PATCH v2 05/10] drm/msm/dp: fix IRQ lifetime

2022-09-13 Thread Johan Hovold
to the DRM device so that it is released when bind fails. Fixes: c943b4948b58 ("drm/msm/dp: add displayPort driver support") Cc: sta...@vger.kernel.org # 5.10 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 2 +- 1 file change

[PATCH v2 08/10] drm/msm/hdmi: fix IRQ lifetime

2022-09-13 Thread Johan Hovold
by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c b/drivers/gpu/drm/msm/hdmi/hdmi.c index a0ed6aa8e4e1..f28fb21e3891 100644 --- a/drivers/gpu/drm/msm/hdmi/hd

[PATCH v2 00/10] drm/msm: probe deferral fixes

2022-09-13 Thread Johan Hovold
an be done later as a cleanup/optimisation. Johan Changes in v2 - use a custom devres action instead of amending the AUX bus interface (Doug) - split sanity check fixes and cleanups per bridge type (Dmitry) - add another Fixes tag for the missing bridge counter reset (Dmitry) Johan Hovold (10):

[PATCH v2 01/10] drm/msm: fix use-after-free on probe deferral

2022-09-13 Thread Johan Hovold
the bridge array being corrupted. Fixes: d28ea556267c ("drm/msm: properly add and remove internal bridges") Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge") Cc: sta...@vger.kernel.org # 3.12 Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/gpu/d

[PATCH v2 02/10] drm/msm/dp: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
.17 Signed-off-by: Johan Hovold --- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 3e284fed8d30..fbe950edaefe 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drive

[PATCH v2 03/10] drm/msm/dsi: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a689554ba6ed ("drm/msm: Initial add DSI connector support") Cc: sta...@vger.kernel.org # 4.1 Signed-off-by: Jo

[PATCH v2 04/10] drm/msm/hdmi: fix memory corruption with too many bridges

2022-09-13 Thread Johan Hovold
Add the missing sanity check on the bridge counter to avoid corrupting data beyond the fixed-sized bridge array in case there are ever more than eight bridges. Fixes: a3376e3ec81c ("drm/msm: convert to drm_bridge") Cc: sta...@vger.kernel.org # 3.12 Signed-off-by: Johan Hovold --

Re: [RFC PATCH 0/3] drm/msm/dp: several fixes for the IRQ handling

2022-09-13 Thread Johan Hovold
On Thu, Sep 01, 2022 at 12:15:24PM +0300, Dmitry Baryshkov wrote: > Johan Hovold has reported that returning a probe deferral from the > msm_dp_modeset_init() can cause issues because the IRQ is not freed > properly. This (compile-tested only) series tries to fix the issue by

Re: [PATCH v2 08/10] drm/msm/hdmi: fix IRQ lifetime

2022-09-23 Thread Johan Hovold
On Thu, Sep 22, 2022 at 12:55:03PM -0700, Kuogee Hsieh wrote: > > On 9/13/2022 1:53 AM, Johan Hovold wrote: > > Device-managed resources allocated post component bind must be tied to > > the lifetime of the aggregate DRM device or they will not necessarily be > &g

Re: [PATCH v16 0/3] eDP/DP Phy vdda realted function

2022-08-03 Thread Johan Hovold
On Fri, Jul 29, 2022 at 03:07:47PM +0100, Mark Brown wrote: > On Fri, Jul 29, 2022 at 03:35:33PM +0200, Johan Hovold wrote: > > > I guess we just need to drop all those regulator-allow-set-load > > properties for now even if using DT for power-management configuration >

Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b

2023-01-02 Thread Johan Hovold
On Tue, Jan 03, 2023 at 12:36:51AM +0200, Abel Vesa wrote: > On 23-01-02 09:21:40, Johan Hovold wrote: > > On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote: > > > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa wrote: > > > > > >

Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b

2023-01-03 Thread Johan Hovold
On Sat, Dec 31, 2022 at 04:27:20PM +0200, Abel Vesa wrote: > The actual name is R133NW4K-R0. > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry") > Signed-off-by: Abel Vesa Reviewed-by: Johan Hovold

Re: [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry

2023-01-03 Thread Johan Hovold
On Sat, Dec 31, 2022 at 04:27:21PM +0200, Abel Vesa wrote: > Add an eDP panel entry for IVO M133NW4J. > > Due to lack of documentation, use the delay_200_500_p2e100 timings like > some other IVO entries for now. > > Signed-off-by: Abel Vesa > --- Reviewed-by: Johan Hovold

Re: [PATCH 1/2] drm/panel-edp: fix name for IVO product id 854b

2023-01-02 Thread Johan Hovold
On Sun, Jan 01, 2023 at 10:58:42PM -0600, Steev Klimaszewski wrote: > On Sat, Dec 31, 2022 at 8:27 AM Abel Vesa wrote: > > > > The actual name is R133NW4K-R0. > > > > Fixes: 0f9fa5f58c784 ("drm/panel-edp: add IVO M133NW4J-R3 panel entry") > > Signed-off-by: Abel Vesa > > --- > > > > Assuming the

Re: [PATCH 2/2] drm/panel-edp: add IVO M133NW4J panel entry

2023-01-02 Thread Johan Hovold
On Sat, Dec 31, 2022 at 04:27:21PM +0200, Abel Vesa wrote: > Add an eDP panel entry for IVO M133NW4J. > > Due to lack of documentation, use the delay_200_500_p2e100 timings like > some other IVO entries for now. > > Signed-off-by: Abel Vesa > --- > > Assuming the information from here is

Re: [PATCH v5 12/12] arm64: dts: qcom: sa8295-adp: Enable DP instances

2022-12-09 Thread Johan Hovold
On Wed, Dec 07, 2022 at 02:00:12PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SA8295P ADP has, among other interfaces, six MiniDP connectors which > are connected to MDSS0 DP2 and DP3, and MDSS1 DP0 through DP3. > > Enable Display Clock controllers, MDSS instanced, MDPs, DP

Re: [PATCH v5 10/12] arm64: dts: qcom: sc8280xp: Define some of the display blocks

2022-12-09 Thread Johan Hovold
On Wed, Dec 07, 2022 at 02:00:10PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > Define the display clock controllers, the MDSS instances, the DP phys > and connect these together. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > > Changes since v4: > -

Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-09 Thread Johan Hovold
On Wed, Dec 07, 2022 at 02:00:11PM -0800, Bjorn Andersson wrote: > From: Bjorn Andersson > > The SC8280XP CRD has a EDP display on MDSS0 DP3, enable relevant nodes > and link it together with the backlight control. > > Signed-off-by: Bjorn Andersson > Signed-off-by: Bjorn Andersson > --- > >

Re: [PATCH v5 11/12] arm64: dts: qcom: sc8280xp-crd: Enable EDP

2022-12-13 Thread Johan Hovold
On Tue, Dec 13, 2022 at 07:10:14AM -0800, Bjorn Andersson wrote: > On Fri, Dec 09, 2022 at 11:35:23AM +0100, Johan Hovold wrote: > > > + edp_reg_en: edp-reg-en-state { > > > + pins = "gpio25"; > > > + function = "gpio"; >

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-01-17 Thread Johan Hovold
On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: > On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > > On 13/01/2023 06:10, Bjorn Andersson wrote: > > > > Invoking drm_bridge_hpd_notify() on a drm_bridge with a

Re: [PATCH v6 08/10] dt-bindings: msm/dp: Add bindings for HDCP registers

2023-01-18 Thread Johan Hovold
On Wed, Jan 18, 2023 at 07:30:13PM +, Mark Yacoub wrote: > From: Sean Paul > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key >

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-01-24 Thread Johan Hovold
On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: >

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-01-24 Thread Johan Hovold
On Tue, Jan 24, 2023 at 09:09:02AM +0100, Johan Hovold wrote: > On Mon, Jan 23, 2023 at 09:17:49AM -0800, Bjorn Andersson wrote: > > On Mon, Jan 23, 2023 at 05:01:45PM +0100, Johan Hovold wrote: > > > On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > > > &

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-01-23 Thread Johan Hovold
On Tue, Jan 17, 2023 at 09:04:39AM +0100, Johan Hovold wrote: > On Mon, Jan 16, 2023 at 08:51:22PM -0600, Bjorn Andersson wrote: > > On Fri, Jan 13, 2023 at 10:57:18AM +0200, Dmitry Baryshkov wrote: > > > On 13/01/2023 06:23, Dmitry Baryshkov wrote: > > > > On 13/

Re: [PATCH] drm/msm: Initialize mode_config earlier

2023-03-08 Thread Johan Hovold
On Thu, Mar 02, 2023 at 03:17:04PM -0800, Bjorn Andersson wrote: > On Wed, Mar 01, 2023 at 02:58:50PM +0100, Johan Hovold wrote: > > So after debugging this issue a third time, I can conclude that it is > > still very much present in 6.2. > > > > It appears you looked

Re: [PATCH 01/10] Revert "drm/msm: Add missing check and destroy for alloc_ordered_workqueue"

2023-03-07 Thread Johan Hovold
On Wed, Mar 08, 2023 at 10:10:24AM +0800, Jiasheng Jiang wrote: > On Mon, 06 Mar 2023 18:07:13 +0800, Johan Hovold wrote: > > This reverts commit 643b7d0869cc7f1f7a5ac7ca6bd25d88f54e31d0. > > The commit not only adds the allocation sanity check, but also adds the > destroy_wo

Re: [PATCH v3 5/7] drm/msm/hdmi: stop using drm_bridge_connector_en/disable_hpd()

2023-03-08 Thread Johan Hovold
On Wed, Nov 02, 2022 at 09:07:03PM +0300, Dmitry Baryshkov wrote: > The functionality of drm_bridge_connector_enable_hpd() and > drm_bridge_connector_disable_hpd() is provided automatically by the > drm_kms_poll helpers. Stop calling these functions manually. I stumbled over this one when

Re: [PATCH 05/10] drm/msm: fix drm device leak on bind errors

2023-03-22 Thread Johan Hovold
On Tue, Mar 21, 2023 at 04:54:51PM +0200, Dmitry Baryshkov wrote: > On 06/03/2023 12:07, Johan Hovold wrote: > > Make sure to free the DRM device also in case of early errors during > > bind(). > > > > Fixes: 2027e5b3413d ("drm/msm: Initialize MDSS irq do

Re: [PATCH 00/10] drm/msm: fix bind error handling

2023-03-22 Thread Johan Hovold
On Tue, Mar 21, 2023 at 05:21:56PM +0200, Dmitry Baryshkov wrote: > On 21/03/2023 15:02, Johan Hovold wrote: > > On Mon, Mar 06, 2023 at 11:07:12AM +0100, Johan Hovold wrote: > >> I had reasons to look closer at the MSM DRM driver error handling and > >> realised that

Re: [PATCH v2 0/4] drm/msm/adreno: fix runtime PM imbalance at unbind

2023-03-21 Thread Johan Hovold
On Fri, Mar 03, 2023 at 05:48:03PM +0100, Johan Hovold wrote: > As reported by Bjorn, we can end up with an unbalanced runtime PM > disable count if unbind() is called before the DRM device is opened > (e.g. if component bind fails due to the panel driver not having been >

Re: [PATCH] drm/meson: fix missing component unbind on bind errors

2023-03-21 Thread Johan Hovold
On Thu, Mar 09, 2023 at 10:41:18PM +0100, Martin Blumenstingl wrote: > On Mon, Mar 6, 2023 at 11:35 AM Johan Hovold wrote: > [...] > > @@ -325,23 +325,23 @@ static int meson_drv_bind_master(struct device *dev, > > bool has_components) > > > > ret = meson_e

  1   2   3   >