Re: [PATCH v6 2/5] drm: rockchip: add sound support to rk3066 hdmi driver

2021-03-22 Thread Johan Jonker
ping On 12/6/20 2:33 PM, Johan Jonker wrote: > From: Zheng Yang > > Add sound support to the rk3066 HDMI driver. > > The I2S input of the HDMI TX allows transmission of > DVD-Audio and decoded Dolby Digital > to A/V Receivers and high-end displays. > The interface

[PATCH] drm/rockchip: vop_reg: add PX30 version info

2021-02-01 Thread Johan Jonker
To reduce memory various Rockchip VOP versions share common reg structures. However more recent added SoCs not always have to same futures as the old ones. Add PX30 missing version info, so all VOP version checks work correct if needed in the future. Signed-off-by: Johan Jonker --- drivers/gpu

[RFC PATCH] drm/rockchip: vop_reg: add rk3036 hdmi support

2021-02-01 Thread Johan Jonker
A Rockchip Inno HDMI driver was added, but the rk3036 VOP regs with HDMI support in the manufacturer tree never made it to the mainline kernel. This patch adds only hdmi_en and hdmi_dclk_pol. The inno hdmi driver must set hdmi_pin_pol in GRF_SOC_CON2. Signed-off-by: Johan Jonker --- Not tested

[PATCH v6 3/5] ARM: dts: rockchip: rk3066a: add #sound-dai-cells to hdmi node

2020-12-07 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property, so add them to the 'hdmi' node for 'rk3066a.dtsi'. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 1 + 1 file changed, 1 inse

[PATCH v6 2/5] drm: rockchip: add sound support to rk3066 hdmi driver

2020-12-07 Thread Johan Jonker
16bits to 32bits for I2S audio inputs.(This driver 24bit max) There are three I2S input modes supported.(This driver HDMI_I2S only) On RK3066/PX2 the HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig

[PATCH v6 4/5] ARM: dts: rockchip: add hdmi-sound node to rk3066a.dtsi

2020-12-07 Thread Johan Jonker
Add hdmi-sound node to rk3066a.dtsi, so that it can be reused by boards with HDMI support. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi index

[PATCH v6 1/5] dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi

2020-12-07 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property. Add it to rockchip,rk3066-hdmi.yaml to document that the rk3066 HDMI TX also can be used to transmit some audio. Signed-off-by: Johan Jonker --- .../devicetree/bindi

[PATCH v6 0/5] Enable rk3066a HDMI sound

2020-12-07 Thread Johan Jonker
hanged v6: remove patches that are applied to linux-next add platform_device_unregister() restyle Changed v5: removed unused variable fill frame structure Johan Jonker (4): dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi ARM: dts: rockchip: rk3066a: add #

[PATCH v6 5/5] ARM: dts: rockchip: enable hdmi_sound and i2s0 for rk3066a-mk808

2020-12-07 Thread Johan Jonker
Make some noise with mk808. Enable the hdmi_sound node and add i2s0 as sound source for hdmi. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808

[PATCH v4 7/7] ARM: dts: rockchip: enable hdmi_sound and i2s0 for rk3066a-mk808

2020-11-18 Thread Johan Jonker
Make some noise with mk808. Enable the hdmi_sound node and add i2s0 as sound source for hdmi. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808

[PATCH v4 6/7] ARM: dts: rockchip: add hdmi-sound node to rk3066a.dtsi

2020-11-18 Thread Johan Jonker
Add hdmi-sound node to rk3066a.dtsi, so that it can be reused by boards with HDMI support. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi index

[PATCH v4 3/7] dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi

2020-11-18 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property. Add it to rockchip,rk3066-hdmi.yaml to document that the rk3066 HDMI TX also can be used to transmit some audio. Signed-off-by: Johan Jonker --- .../devicetree/bindi

[PATCH v4 0/7] Enable rk3066a HDMI sound

2020-11-18 Thread Johan Jonker
rk3066a.dtsi, because I2S0 and HDMI TX are connected internally. And as last enable rk3066a HDMI sound in the rk3066a-mk808.dts file. Johan Jonker (6): clk: rockchip: add CLK_SET_RATE_PARENT to sclk for rk3066a i2s and uart clocks clk: rockchip: fix i2s gate bits on rk3066 and rk3188 dt

[PATCH v4 1/7] clk: rockchip: add CLK_SET_RATE_PARENT to sclk for rk3066a i2s and uart clocks

2020-11-18 Thread Johan Jonker
Add CLK_SET_RATE_PARENT to sclk for rk3066a i2s and uart clocks, so that the parent COMPOSITE_FRACMUX and COMPOSITE_NOMUX also update. Signed-off-by: Johan Jonker --- drivers/clk/rockchip/clk-rk3188.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH v4 4/7] drm: rockchip: add sound support to rk3066 hdmi driver

2020-11-18 Thread Johan Jonker
16bits to 32bits for I2S audio inputs.(This driver 24bit max) There are three I2S input modes supported.(This driver HDMI_I2S only) On RK3066/PX2 the HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig

[PATCH v4 2/7] clk: rockchip: fix i2s gate bits on rk3066 and rk3188

2020-11-18 Thread Johan Jonker
Signed-off-by: Johan Jonker --- drivers/clk/rockchip/clk-rk3188.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c index db8c58813..0b76ad34d 100644 --- a/drivers/clk/rockchip/clk-rk3188.c +++ b/d

[PATCH v4 5/7] ARM: dts: rockchip: rk3066a: add #sound-dai-cells to hdmi node

2020-11-18 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property, so add them to the 'hdmi' node for 'rk3066a.dtsi'. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 1 + 1 file changed, 1 inse

[PATCH v5 0/7] Enable rk3066a HDMI sound

2020-11-19 Thread Johan Jonker
rk3066a.dtsi, because I2S0 and HDMI TX are connected internally. And as last enable rk3066a HDMI sound in the rk3066a-mk808.dts file. Changed v5: removed unused variable fill frame structure Johan Jonker (6): clk: rockchip: add CLK_SET_RATE_PARENT to sclk for rk3066a i2s and uart clocks

[PATCH v5 6/7] ARM: dts: rockchip: add hdmi-sound node to rk3066a.dtsi

2020-11-19 Thread Johan Jonker
Add hdmi-sound node to rk3066a.dtsi, so that it can be reused by boards with HDMI support. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi index

[PATCH v5 1/7] clk: rockchip: add CLK_SET_RATE_PARENT to sclk for rk3066a i2s and uart clocks

2020-11-19 Thread Johan Jonker
Add CLK_SET_RATE_PARENT to sclk for rk3066a i2s and uart clocks, so that the parent COMPOSITE_FRACMUX and COMPOSITE_NOMUX also update. Signed-off-by: Johan Jonker --- drivers/clk/rockchip/clk-rk3188.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH v5 5/7] ARM: dts: rockchip: rk3066a: add #sound-dai-cells to hdmi node

2020-11-19 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property, so add them to the 'hdmi' node for 'rk3066a.dtsi'. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 1 + 1 file changed, 1 inse

[PATCH v5 2/7] clk: rockchip: fix i2s gate bits on rk3066 and rk3188

2020-11-19 Thread Johan Jonker
Signed-off-by: Johan Jonker --- Changed v3: reword --- drivers/clk/rockchip/clk-rk3188.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c index db8c58813..0b76ad34d 100644 --- a/drivers/clk/rockchip/cl

[PATCH v5 7/7] ARM: dts: rockchip: enable hdmi_sound and i2s0 for rk3066a-mk808

2020-11-19 Thread Johan Jonker
Make some noise with mk808. Enable the hdmi_sound node and add i2s0 as sound source for hdmi. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808

[PATCH v5 3/7] dt-bindings: display: add #sound-dai-cells property to rockchip rk3066 hdmi

2020-11-19 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property. Add it to rockchip,rk3066-hdmi.yaml to document that the rk3066 HDMI TX also can be used to transmit some audio. Signed-off-by: Johan Jonker --- .../devicetree/bindi

[PATCH v5 4/7] drm: rockchip: add sound support to rk3066 hdmi driver

2020-11-19 Thread Johan Jonker
16bits to 32bits for I2S audio inputs.(This driver 24bit max) There are three I2S input modes supported.(This driver HDMI_I2S only) On RK3066/PX2 the HDMI TX audio source is connected to I2S_8CH. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig

Re: [PATCH] arm64: dts: rockchip: enable vop2 and hdmi tx on quartz64a

2021-11-25 Thread Johan Jonker
On 11/17/21 4:44 PM, Michael Riesch wrote: > Enable the RK356x Video Output Processor (VOP) 2 on the Pine64 > Quartz64 Model A. > > Signed-off-by: Michael Riesch > --- > .../boot/dts/rockchip/rk3566-quartz64-a.dts | 24 +++ > 1 file changed, 24 insertions(+) > > diff --git

Re: [PATCH 08/12] arm64: dts: rockchip: rk356x: Add VOP2 nodes

2021-11-25 Thread Johan Jonker
Hi Sascha, On 11/17/21 3:33 PM, Sascha Hauer wrote: > The VOP2 is the display output controller on the RK3568. Add the node > for it to the dtsi file along with the required display-subsystem node > and the iommu node. > > Signed-off-by: Sascha Hauer > --- > arch/arm64/boot/dts/rockchip/rk356x

Re: [PATCH 17/18] drm: rockchip: Add VOP2 driver

2021-12-08 Thread Johan Jonker
Hi, On 12/8/21 4:12 PM, Sascha Hauer wrote: > From: Andy Yan > > The VOP2 unit is found on Rockchip SoCs beginning with rk3566/rk3568. > It replaces the VOP unit found in the older Rockchip SoCs. > > This driver has been derived from the downstream Rockchip Kernel and > heavily modified: > > -

Re: [PATCH 13/18] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2021-12-08 Thread Johan Jonker
Hi, Could add a patch version to the subject? On 12/8/21 4:12 PM, Sascha Hauer wrote: > This enabled the VOP2 display controller along with hdmi and the > required port routes which is enough to get a picture out of the > hdmi port of the board. > > Signed-off-by: Sascha Hauer > --- > .../boot

Re: [PATCH v2 4/7] drm: rockchip: introduce rk3066 hdmi

2019-02-01 Thread Johan Jonker
r (or Sandy) approve the replacement of the GPL text by a SPDX License Identifier for GPL-2.0? Is Heiko's test setup for rk3066 already functional? Thanks 2018-12-29 14:33 GMT+01:00, Johan Jonker : > +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c > @@ -0,0 +1,928 @@ > +/

[PATCH] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-02-01 Thread Johan Jonker
This patch adds a binding that describes the HDMI controller for rk3066. Signed-off-by: Johan Jonker --- .../display/rockchip/rk3066_hdmi-rockchip.txt | 60 ++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/rockchip

Re: [PATCH] dts: rockchip: rk3066: add qos_hdmi and HCLK_HDMI to pmu node

2018-12-18 Thread Johan Jonker
Hi all, Thanks Tomasz for adding all the mailing lists. I prefer to ask first if a qos_hdmi exists before sending it in for public review. All the clocks in the pmu node seem to have a "quality-of-service" (QoS) block. So I added one for hdmi too with the question if it exists and which address i

[PATCH v2 6/7] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-01-01 Thread Johan Jonker
From: Zheng Yang This patch adds the hdmi nodes to rk3066. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot

[PATCH v2 1/7] ARM: dts: rockchip: rk3066: add HCLK_HDMI to pmu node

2019-01-01 Thread Johan Jonker
-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot/dts/rk3066a.dtsi index 30dc8af0b..b6b3a77da 100644 --- a/arch/arm/boot/dts/rk3066a.dtsi +++ b/arch/arm/boot/dts/rk3066a.dtsi @@ -669,6 +669,7

[PATCH v2 2/7] clk: rockchip: rk3188: add CLK_SET_RATE_PARENT for lcdc dclk

2019-01-01 Thread Johan Jonker
From: Finley Xiao Add CLK_SET_RATE_PARENT for lcdc dclk. Signed-off-by: Finley Xiao Signed-off-by: Johan Jonker --- drivers/clk/rockchip/clk-rk3188.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/rockchip/clk-rk3188.c b/drivers/clk/rockchip/clk-rk3188.c

[PATCH v2 7/7] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-01-01 Thread Johan Jonker
This patch enables the vop0 and hdmi nodes for a MK808 with rk3066 processor. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a-mk808.dts index

[PATCH v2 4/7] drm: rockchip: introduce rk3066 hdmi

2019-01-01 Thread Johan Jonker
From: Zheng Yang Introduce rk3066 hdmi. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig| 8 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rk3066_hdmi.c | 928 drivers

[PATCH v2 0/7] Enable rk3066 VOP and HDMI for MK808

2019-01-01 Thread Johan Jonker
ENT for lcdc dclk Johan Jonker (2): ARM: dts: rockchip: rk3066: add HCLK_HDMI to pmu node ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes Mark Yao (2): drm: rockchip: vop: add rk3066 vop definitions ARM: dts: rockchip: add rk3066 vop display nodes Zheng Yang (2): drm: rockchip:

[PATCH v2 3/7] drm: rockchip: vop: add rk3066 vop definitions

2019-01-01 Thread Johan Jonker
input The HDMI TX input can switch between LCDC0 and LCDC1. Signed-off-by: Mark Yao Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip-vop.txt | 1 + drivers/gpu/drm/rockchip/rockchip_vop_reg.c| 110 + drivers/gpu/drm/rockchip/rockchip_vop_

[PATCH v2 5/7] ARM: dts: rockchip: add rk3066 vop display nodes

2019-01-01 Thread Johan Jonker
From: Mark Yao This patch adds the core display subsystem and vop nodes to rk3066. Signed-off-by: Mark Yao Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 47 ++ 1 file changed, 47 insertions(+) diff --git a/arch/arm/boot/dts

Re: [PATCH] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-02-28 Thread Johan Jonker
Thanks for your advice. On 2/25/19 5:59 PM, Rob Herring wrote:> On Fri, Feb 01, 2019 at 01:32:35PM +0100, Johan Jonker wrote: >> This patch adds a binding that describes the HDMI controller for >> rk3066. > > This is not using the DW block like other Rockchip SoCs (IIRC)

[PATCH v3 2/4] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-03-03 Thread Johan Jonker
From: Zheng Yang This patch adds the hdmi nodes to rk3066. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 52 ++ 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot

[PATCH v3 0/4] Enable rk3066 VOP and HDMI for MK808

2019-03-03 Thread Johan Jonker
eabi- cp ./arch/arm/boot/zImage ../zImage-dtb cat ./arch/arm/boot/dts/rk3066a-mk808.dtb >> ../zImage-dtb ../tools/rkcrc -k ../zImage-dtb ../mk808.img sudo ../tools/rkflashtool w 0x4000 0x8000 < ../mk808.img sudo ../tools/rkflashtool b /////// Joh

[PATCH v3 4/4] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-03-03 Thread Johan Jonker
This patch adds a binding that describes the HDMI controller for rk3066. Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rk3066-hdmi.txt | 72 ++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/rockchip

[PATCH v3 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-03 Thread Johan Jonker
From: Zheng Yang Introduce rk3066 hdmi. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig| 8 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rk3066_hdmi.c | 911 drivers

[PATCH v3 3/4] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-03-03 Thread Johan Jonker
This patch enables the vop0 and hdmi nodes for a MK808 with rk3066 processor. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a

Re: [PATCH v3 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-05 Thread Johan Jonker
; Please advise if this is OK? "rockchip_rk3066-hdmi.txt" On 3/3/19 9:23 PM, Sam Ravnborg wrote:> Hi Johan. > > Thanks for this nive driver. > A few review comments follows. > > Sam > > On Sat, Mar 02, 2019 at 11:41:13AM +0100, Johan Jonker wrote: >> Fr

[PATCH v4 4/4] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-03-07 Thread Johan Jonker
This patch adds a binding that describes the HDMI controller for rk3066. Signed-off-by: Johan Jonker --- .../display/rockchip/rockchip,rk3066-hdmi.txt | 72 ++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/rockchip

[PATCH v4 3/4] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-03-07 Thread Johan Jonker
This patch enables the vop0 and hdmi nodes for a MK808 with rk3066 processor. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a

[PATCH v4 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-07 Thread Johan Jonker
switch between LCDC0 and LCDC1. (Sound support is not included in this patch) Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig| 8 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rk3066_hdmi.c | 901

[PATCH v4 2/4] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-03-07 Thread Johan Jonker
From: Zheng Yang This patch adds the hdmi nodes to rk3066. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 52 ++ 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot

[PATCH v4 0/4] Enable rk3066 VOP and HDMI for MK808

2019-03-07 Thread Johan Jonker
../zImage-dtb ../tools/rkcrc -k ../zImage-dtb ../mk808.img sudo ../tools/rkflashtool w 0x4000 0x8000 < ../mk808.img sudo ../tools/rkflashtool b /////// Johan Jonker (2): ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes dt-bindings: disp

[PATCH] drm: rockchip: add shutdown function to poweroff VOP and HDMI TX

2019-03-09 Thread Johan Jonker
tdown function that will unbind both drivers. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rockchip_drm_drv.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_drv.c b/drivers/gpu/drm/rockchip/rockchip_drm_drv.c index 8d7a634c1..66a8e99a3 1

Re: [PATCH] drm: rockchip: add shutdown function to poweroff VOP and HDMI TX

2019-03-12 Thread Johan Jonker
tdown https://patchwork.kernel.org/patch/10556151/ [for-4.20] Revert "drm/rockchip: Allow driver to be shutdown on reboot/kexec" https://patchwork.kernel.org/patch/10714725/ 2019-03-08 19:37 GMT+01:00, Johan Jonker : > When a MK808 TV-stick with RK3066 processor > is given a poweroff

Re: [PATCH v4 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-13 Thread Johan Jonker
Hi, Would like to add some "Tested-by:" tags. Is Rockchip or someone with RK3066 hardware able to test this patch with a HDMI TV or DVI monitor and give a report? Power domain doesn't seem to turn off the vop and hdmi in v5.0-rc8. The bug is due to a patch revert earlier this year. To shutdown MK

Re: [PATCH v3 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-13 Thread Johan Jonker
On 3/4/19 11:48 PM, Johan Jonker wrote: > > With regard to the bugs something between rc1 and rc8 results > in a freeze on poweroff. Power domain doesn't seem to turn off > the vop and hdmi in rc8. The bug is due to a patch revert earlier this year. To shutdown MK808 one can co

[PATCH v5 3/5] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-03-21 Thread Johan Jonker
This patch enables the vop0 and hdmi nodes for a MK808 with rk3066 processor. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a

[PATCH v5 1/5] drm: rockchip: introduce rk3066 hdmi

2019-03-21 Thread Johan Jonker
switch between LCDC0 and LCDC1. (Sound support is not included in this patch) Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig| 8 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rk3066_hdmi.c | 866

[PATCH v5 5/5] drm: rockchip: add fixed screen size DVI-D support for rk3066 hdmi

2019-03-21 Thread Johan Jonker
Add fixed screen size DVI-D support for rk3066 hdmi with an extra patch. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm

[PATCH v5 2/5] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-03-21 Thread Johan Jonker
From: Zheng Yang This patch adds the hdmi nodes to rk3066. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 52 ++ 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot

[PATCH v5 0/5] Enable rk3066 VOP and HDMI for MK808

2019-03-21 Thread Johan Jonker
ux-gnueabi- cp ./arch/arm/boot/zImage ../zImage-dtb cat ./arch/arm/boot/dts/rk3066a-mk808.dtb >> ../zImage-dtb ../tools/rkcrc -k ../zImage-dtb ../mk808.img sudo ../tools/rkflashtool w 0x4000 0x8000 < ../mk808.img sudo ../tools/rkflashtool b /////// Joh

[PATCH v5 4/5] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-03-21 Thread Johan Jonker
This patch adds a binding that describes the HDMI controller for rk3066. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- .../display/rockchip/rockchip,rk3066-hdmi.txt | 72 ++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree

Re: [PATCH v4 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-29 Thread Johan Jonker
Hi, Question for Heiko cs. See below. Let me know if there's a need for V6? On 3/19/19 12:44 PM, Heiko Stübner wrote: > Am Mittwoch, 6. März 2019, 23:41:10 CET schrieb Johan Jonker: >> +static int rk3066_hdmi_connector_get_modes(struct drm_connector *connector) >> +{ >&g

[PATCH v6 4/4] dt-bindings: display: rockchip: add document for rk3066 hdmi

2019-03-31 Thread Johan Jonker
This patch adds a binding that describes the HDMI controller for rk3066. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- .../display/rockchip/rockchip,rk3066-hdmi.txt | 72 ++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v6 2/4] ARM: dts: rockchip: add rk3066 hdmi nodes

2019-03-31 Thread Johan Jonker
From: Zheng Yang This patch adds the hdmi nodes to rk3066. Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 52 ++ 1 file changed, 52 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a.dtsi b/arch/arm/boot

[PATCH v6 0/4] Enable rk3066 VOP and HDMI for MK808

2019-03-31 Thread Johan Jonker
do ../tools/rkflashtool w 0x4000 0x8000 < ../mk808.img sudo ../tools/rkflashtool b /////// Johan Jonker (2): ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes dt-bindings: display: rockchip: add document for rk3066 hdmi Zheng Yang (2): drm: ro

[PATCH v6 3/4] ARM: dts: rockchip: rk3066a-mk808: enable vop0 and hdmi nodes

2019-03-31 Thread Johan Jonker
This patch enables the vop0 and hdmi nodes for a MK808 with rk3066 processor. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a-mk808.dts | 29 + 1 file changed, 29 insertions(+) diff --git a/arch/arm/boot/dts/rk3066a-mk808.dts b/arch/arm/boot/dts/rk3066a

[PATCH v6 1/4] drm: rockchip: introduce rk3066 hdmi

2019-03-31 Thread Johan Jonker
switch between LCDC0 and LCDC1. (Sound support is not included in this patch) Signed-off-by: Zheng Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/Kconfig| 8 + drivers/gpu/drm/rockchip/Makefile | 1 + drivers/gpu/drm/rockchip/rk3066_hdmi.c | 869

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-09 Thread Johan Jonker
Hi Sascha, Something with port and endpoint gives notifications. Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC options were checked/covered (see rk3328 and rk3568). Allow multiple vop: port or port@0 1x vop -> endpoint 2x vop -> endpoint@0 -> endpoint@1 Also all

Re: [PATCH v5 19/23] arm64: dts: rockchip: rk3568-evb: Enable VOP2 and hdmi

2022-02-10 Thread Johan Jonker
On 2/10/22 12:47, Sascha Hauer wrote: > On Thu, Feb 10, 2022 at 01:10:32AM +0100, Johan Jonker wrote: >> Hi Sascha, >> >> Something with port and endpoint gives notifications. >> Somehow with the conversion of rockchip,dw-hdmi.txt to YAML not all SoC >> options

[PATCH] drm: rockchip: rk3066_hdmi: set edid fifo address

2019-12-12 Thread Johan Jonker
From: Nickey Yang Fix edid reading error when edid's block > 2. Signed-off-by: Nickey Yang Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/

[PATCH v1] dt-bindings: display: rockchip: convert rockchip vop bindings to yaml

2020-03-07 Thread Johan Jonker
ckchip,grf Signed-off-by: Johan Jonker --- .../bindings/display/rockchip/rockchip-vop.txt | 74 --- .../bindings/display/rockchip/rockchip-vop.yaml| 141 + 2 files changed, 141 insertions(+), 74 deletions(-) delete mode 100644 Documentation/devicetree/bindin

Re: [PATCH v1] dt-bindings: display: rockchip: convert rockchip vop bindings to yaml

2020-03-09 Thread Johan Jonker
Hi, Question for robh: In the old txt situation we add/describe only properties that are used by the driver/hardware itself. With yaml it also filters things in a node that are used by other drivers like: assigned-clocks: assigned-clock-rates: power-domains: Should we add or not? Kind regards,

[PATCH v2] dt-bindings: display: convert rockchip vop bindings to yaml

2020-03-12 Thread Johan Jonker
Current dts files with 'vop' nodes are manually verified. In order to automate this process rockchip-vop.txt has to be converted to yaml. Signed-off-by: Johan Jonker --- Changes v2: No new properties --- .../bindings/display/rockchip/rockchip-vop.txt | 74 ..

[PATCH v3] dt-bindings: display: convert rockchip vop bindings to yaml

2020-03-12 Thread Johan Jonker
Current dts files with 'vop' nodes are manually verified. In order to automate this process rockchip-vop.txt has to be converted to yaml. Signed-off-by: Johan Jonker --- Changes v3: Change description Changes v2: No new properties --- .../bindings/display/rockchip/rockch

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Johan Jonker
Hi Dafna, You are checking at the wrong platforms. Maintainers incomplete. ">" is missing. Recheck please. Documentation/devicetree/bindings/display/rockchip/rockchip-drm.yaml: ignoring, error in schema: maintainers: 0 make ARCH=arm CROSS_COMPILE=/usr/bin/arm-linux-gnueabi- menuconfig # change i

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Johan Jonker
Hi, On 1/21/20 4:26 PM, Dafna Hirschfeld wrote: > > > On 21.01.20 16:11, Johan Jonker wrote: >> Hi Dafna, >> >> >>> >>> >>> On 21.01.20 15:03, Rob Herring wrote: >>>> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld >>

Re: [PATCH v2] dt-bindings: convert rockchip-drm.txt to rockchip-drm.yaml

2020-01-22 Thread Johan Jonker
Hi Dafna, > > > On 21.01.20 15:03, Rob Herring wrote: >> On Tue, Jan 21, 2020 at 6:35 AM Dafna Hirschfeld >> wrote: >>> >>> convert the binding file rockchip-drm.txt to yaml format. >>> This was tested and verified with: >>> make dt_binding_check >>> DT_SCHEMA_FILES=Documentation/devicetree/b

Re: [PATCH v6 01/17] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2023-02-03 Thread Johan Jonker
On 2/3/23 19:21, Rob Herring wrote: > On Thu, Dec 22, 2022 at 03:22:14PM +0100, Johan Jonker wrote: >> Convert rockchip-lvds.txt to YAML. >> >> Changed: >> Add power-domains property. >> Requirements between PX30 and RK3288 >> >> Signed-off-

[BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
Hi John, Your patch contribution causes a kernel panic on MK808 with Rockchip rk3066a SoC. Would you like to contribute to fix this issue? The assumtion that drm_fbdev_generic_setup() does what rockchip_drm_fbdev_init did is not true! A revert makes it work again. Johan == [7.975906]

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 13:29, Heiko Stuebner wrote: > Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: >> Hi Johan, >> >> On Mon, Oct 17, 2022 at 10:11:32AM +0200, Johan Jonker wrote: >>> Your patch contribution causes a kernel panic on MK808 with Rockchip

Re: [BUG] [PATCH] drm/rockchip: use generic fbdev setup

2022-10-17 Thread Johan Jonker
On 10/17/22 21:00, John Keeping wrote: > On Mon, Oct 17, 2022 at 08:30:23PM +0200, Johan Jonker wrote: >> >> >> On 10/17/22 13:29, Heiko Stuebner wrote: >>> Am Montag, 17. Oktober 2022, 12:05:16 CEST schrieb John Keeping: >>>> Hi Johan, >>>>

[PATCH v1] drm: rockchip: remove rockchip_drm_framebuffer_init() function

2022-10-19 Thread Johan Jonker
. Signed-off-by: Johan Jonker --- drivers/gpu/drm/rockchip/rockchip_drm_fb.c | 43 -- drivers/gpu/drm/rockchip/rockchip_drm_fb.h | 6 --- 2 files changed, 49 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fb.c b/drivers/gpu/drm/rockchip/rockchip_drm_fb.c index

[PATCH v1] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-17 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- .../display/rockchip/rockchip-lvds.txt| 92 -- .../display/rockchip/rockchip-lvds.yaml | 159 ++ 2 files

[PATCH v2] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-17 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V2: Fix title --- .../display/rockchip/rockchip-lvds.txt| 92 -- .../display/rockchip/rockchip-lvds.yaml | 157

[PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per SoC Sort

Re: [PATCH v3] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
On 12/19/22 14:04, Krzysztof Kozlowski wrote: > On 19/12/2022 13:32, Johan Jonker wrote: >> Convert rockchip-lvds.txt to YAML. >> >> Changed: >> Add power-domains property. >> Requirements between PX30 and RK3288 >> >> Signed-off-by: Johan J

[PATCH v4 1/5] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-19 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requirements per SoC Sort

[PATCH v4 2/5] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-19 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker --- .../devicetree/bindings/soc/rockchip/grf.yaml | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v4 3/5] dt-bindings: phy: add port node to phy-rockchip-inno-usb2.yaml

2022-12-19 Thread Johan Jonker
On Rockchip rk3399 a port node with one endpoint can be connected to a USB Type-C connector node. Add a port node to the phy-rockchip-inno-usb2.yaml file. Signed-off-by: Johan Jonker --- .../devicetree/bindings/phy/phy-rockchip-inno-usb2.yaml | 5 + 1 file changed, 5 insertions

[PATCH v4 4/5] ARM: dts: rockchip: rk3288: add lvds_out node

2022-12-19 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index

[PATCH v4 5/5] arm64: dts: rockchip: px30: add lvds_out node

2022-12-19 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- arch/arm64/boot/dts/rockchip/px30.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts

[PATCH v5 01/12] dt-bindings: display: rockchip: convert rockchip-lvds.txt to YAML

2022-12-21 Thread Johan Jonker
Convert rockchip-lvds.txt to YAML. Changed: Add power-domains property. Requirements between PX30 and RK3288 Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V3: Filename matching compatible style Drop "Regulator phandle for " Specify properties and requir

[PATCH v5 02/12] dt-bindings: soc: rockchip: grf: add rockchip,lvds.yaml

2022-12-21 Thread Johan Jonker
Add new converted rockchip,lvds.yaml to grf.yaml file. Prepare for more SoCs with lvds output. Signed-off-by: Johan Jonker Reviewed-by: Rob Herring --- Changed V5: Drop the quotes --- .../devicetree/bindings/soc/rockchip/grf.yaml | 24 +++ 1 file changed, 14 insertions

[PATCH v5 03/12] dt-bindings: display: bridge: snps, dw-mipi-dsi: fix clock properties

2022-12-21 Thread Johan Jonker
Fix clock properties from the common snps,dw-mipi-dsi.yaml file, as they don't match with what is used on the SoCs. Signed-off-by: Johan Jonker --- .../display/bridge/snps,dw-mipi-dsi.yaml | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --g

[PATCH v5 04/12] dt-bindings: display: rockchip: convert dw_mipi_dsi_rockchip.txt to yaml

2022-12-21 Thread Johan Jonker
Convert dw_mipi_dsi_rockchip.txt to yaml. Changed: add clock-master property file name requirements Signed-off-by: Johan Jonker --- .../display/rockchip/dw_mipi_dsi_rockchip.txt | 94 -- .../rockchip/rockchip,dw-mipi-dsi.yaml| 173 ++ 2 files changed, 173

[PATCH v5 05/12] dt-bindings: usb: convert fcs,fusb302.txt to yaml

2022-12-21 Thread Johan Jonker
Convert fcs,fusb302.txt to yaml. Changed: Add vbus-supply property Signed-off-by: Johan Jonker --- .../devicetree/bindings/usb/fcs,fusb302.txt | 34 -- .../devicetree/bindings/usb/fcs,fusb302.yaml | 66 +++ 2 files changed, 66 insertions(+), 34 deletions(-) delete

[PATCH v5 06/12] ARM: dts: rockchip: rk3288: fix dsi node

2022-12-21 Thread Johan Jonker
Use generic node name for rk3288.dtsi dsi node. With the conversion of rockchip,dw-mipi-dsi.yaml a port@1 node is required, so add a node with label mipi_out. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3288.dtsi | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a

[PATCH v5 07/12] ARM: dts: rockchip: rk3288: fix lvds node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Signed-off-by: Johan Jonker --- Changed V5: rename title --- arch/arm/boot/dts/rk3288.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm

[PATCH v5 08/12] arm64: dts: rockchip: px30: fix lvds node

2022-12-21 Thread Johan Jonker
With the conversion of rockchip,lvds.yaml a port@1 node is required, so add a node with label lvds_out. Also add label lvds_in to port@0. Signed-off-by: Johan Jonker --- Changed V5: rename title add label lvds_in --- arch/arm64/boot/dts/rockchip/px30.dtsi | 6 +- 1 file changed, 5

  1   2   >