[PATCH 5/8] drm/vmwgfx: use ida_simple_get for id allocation.

Some messing with error codes to return 0 on out id's and match current situation. Is this necessary? Looks a touch 'interesting'. Signed-off-by: Jonathan Cameron ji...@cam.ac.uk --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 34 ++--- 1 files changed, 8 insertions

[PATCH 0/8] RFC: Introduce ida_simple interfaces and use them.

one driver doing this so please take a close look. Rusty, Tejun. I kept your sign of an ack for the first patch. Could you quickly verify that's fine? Thanks, Jonathan Jonathan Cameron (7): hwmon: convert idr to ida and use ida_simple interface. hwmon: ibmaem: convert idr to ida and use

[PATCH 1/8] ida: Simplified functions for id allocation.

From: Rusty Russell <ru...@rustcorp.com.au> The current hyper-optimized functions are overkill if you simply want to allocate an id for a device. Create versions which use an internal lock. Thanks to Tejun for feedback. Signed-off-by: Rusty Russell Acked-by: Tejun Heo Acked-by: Jo

[PATCH 5/8] drm/vmwgfx: use ida_simple_get for id allocation.

Some messing with error codes to return 0 on out id's and match current situation. Is this necessary? Looks a touch 'interesting'. Signed-off-by: Jonathan Cameron --- drivers/gpu/drm/vmwgfx/vmwgfx_gmrid_manager.c | 34 ++--- 1 files changed, 8 insertions(+), 26 deletions

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

On Thu, 21 Sep 2017 16:15:28 +0200 Wolfram Sang wrote: > > > > +/** > > > > + * i2c_release_dma_safe_msg_buf - release DMA safe buffer and sync > > > > with i2c_msg > > > > + * @msg: the message to be synced with > > > > + * @buf: the buffer obtained from

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

to the message. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> One minor suggestion for wording. Otherwise looks good to me. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> > --- > drivers/i2c/i2c-core-base.c | 45 > ++

Re: [RFC PATCH v5 6/6] i2c: dev: mark RDWR buffers as DMA_SAFE

On Wed, 20 Sep 2017 20:59:56 +0200 Wolfram Sang <wsa+rene...@sang-engineering.com> wrote: > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Makes sense as do the other drivers. Feel free to add Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com> t

Re: [RFC PATCH v5 3/6] i2c: add docs to clarify DMA handling

> > Documentation looks OK on my eyes. So: > > Reviewed-by: Mauro Carvalho Chehab <mche...@s-opensource.com> Really minor suggestion inline. I don't really care either way as what you had is perfectly comprehensible. Reviewed-by: Jonathan Cameron <jonathan.came...@huawei.com&

Re: [RFC PATCH v5 2/6] i2c: add helpers to ease DMA handling

On Thu, 21 Sep 2017 14:59:22 +0100 Jonathan Cameron <jonathan.came...@huawei.com> wrote: > On Wed, 20 Sep 2017 20:59:52 +0200 > Wolfram Sang <wsa+rene...@sang-engineering.com> wrote: > > > One helper checks if DMA is suitable and optionally creates a bounce > > b

Re: [RFC PATCH v4 0/6] i2c: document DMA handling and add helpers for it

On Thu, 17 Aug 2017 16:14:43 +0200 Wolfram Sang wrote: > So, after revisiting old mail threads, taking part in a similar discussion on > the USB list, and implementing a not-convincing solution before, here is what > I > cooked up to document and ease DMA

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

ed all these drivers to ensure that all ioctl arguments > are used as pointers or are ignored, but are not interpreted as integer > values. > > Signed-off-by: Arnd Bergmann > --- For IIO part. Acked-by: Jonathan Cameron Thanks, > diff --git a/drivers/iio/industrialio-

Re: [PATCH 2/2] dt-bindings: Remove cases of 'allOf' containing a '$ref'

everyone copies the simpler syntax. > > Signed-off-by: Rob Herring A few unrelated white space changes in enums in the IIO chunks. Don't suppose they matter but maybe need the description to mention there may be some minor formatting changes as well in some cases. Acked-by: Jonathan Cameron

Re: [PATCH v2] of_device: removed #include that caused a recursion in included headers

Hmm. I guess the chances of this causing merge problems are fairly low so perhaps not worth doing additions of headers via individual subsystems and actually dropping the header include after another cycle. So on that basis Acked-by: Jonathan Cameron #for-iio > --- > v2: add include to of_pla

Re: [PATCH trivial 4/6] iio: Fix misspellings of "Analog Devices"

On Thu, 16 Apr 2020 12:30:56 +0200 Geert Uytterhoeven wrote: > According to https://www.analog.com/, the company name is spelled > "Analog Devices". > > Signed-off-by: Geert Uytterhoeven Applied to the togreg branch of iio.git and pushed out as testing as there are other things in that tree

Re: [PATCH 1/2] dt-bindings: Clean-up schema indentation formatting

pts which do transforms on the schema files. > > Signed-off-by: Rob Herring > --- ... > .../bindings/iio/adc/adi,ad7124.yaml | 4 +- > .../bindings/iio/adc/lltc,ltc2496.yaml| 6 +- Acked-by: Jonathan Cameron #for-iio > .../input/allwinner,sun4i-a10-lradc-key

Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false'

y' that go into > bus child nodes, but aren't defined in the child node's schema. > > So let's stick with the json-schema defined default and add > 'additionalProperties: false' where needed. This will be a continual > review comment and game of wack-a-mole. > > Signed-off-by: R

Re: [PATCH 3/4] dt-bindings: Clean-up schema errors due to missing 'addtionalProperties: false'

l > those occurrences. > > Cc: Stephen Boyd > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: Masahiro Yamada > Cc: Jonathan Cameron > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Cc: Neil Armstrong > Cc: Mauro Carvalho Cheh

Re: [PATCH 1/4] dt-bindings: iio/accel: Drop duplicate adi, adxl345/6 from trivial-devices.yaml

e/bindings/iio/accel/adi,adxl345.yaml > > > > The trivial-devices binding doesn't capture that 'adi,adxl346' has a > > fallback compatible 'adi,adxl345', so let's add it to adi,adxl345.yaml. > > > > Acked-by: Alexandru Ardelean Acked-by: Jonathan Cameron > > > Cc:

Re: [PATCH 2/4] dt-bindings: Use 'additionalProperties' instead of 'unevaluatedProperties'

ng some missing property definitions of > which most are for SPI bus properties. 'unevaluatedProperties' is not going > to work for the SPI bus properties anyways as they are evaluated from the > parent node, not the SPI child node. > > Signed-off-by: Rob Herring Acked-by: Jonathan Cam

Re: [PATCH 4/4] dt-bindings: Explicitly allow additional properties in common schemas

alProperties. > > Signed-off-by: Rob Herring > Documentation/devicetree/bindings/iio/common.yaml| 2 ++ For IIO Acked-by: Jonathan Cameron > ... ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesk

Re: [PATCH] dt-bindings: Another round of adding missing 'additionalProperties'

> Cc: Shawn Guo > Cc: Bjorn Andersson > Cc: Baolin Wang > Cc: Guenter Roeck > Cc: Jonathan Cameron > Cc: Mauro Carvalho Chehab > Cc: Laurent Pinchart > Cc: Lee Jones > Cc: Ulf Hansson > Cc: "David S. Miller" > Cc: Bjorn Helgaas > Cc: Vinod Koul &g

Re: [PATCH v2] MAINTAINERS: add Dan Murphy as TP LP8xxx drivers maintainer

cked-by: Dan Murphy > Not sure who will pick this one up, but Acked-by: Jonathan Cameron ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] dt-bindings: More whitespace clean-ups in schema files

ect.org > Cc: linux-...@vger.kernel.org > Cc: linux-...@lists.infradead.org > Cc: linux-ser...@vger.kernel.org > Cc: linux-...@vger.kernel.org > Signed-off-by: Rob Herring Acked-by: Jonathan Cameron #for-iio > --- > .../display/bridge/toshiba,tc358775.yaml | 18

Re: [PATCH] dt-bindings: Whitespace clean-ups in schema files

> With these points considered: > Acked-by: Sam Ravnborg Replying here as the patch doesn't seem to have made it to linux-iio at least. I'm not sure why... Anyhow, found it in an lkml archive so for the iio changes Acked-by: Jonathan Cameron > > I expect only some (few) of my points to

Re: [PATCH] dt-bindings: Drop unnecessary *-supply schemas properties

On Mon, 21 Dec 2020 16:46:59 -0700 Rob Herring wrote: > *-supply properties are always a single phandle, so binding schemas > don't need a type $ref nor 'maxItems'. > > A meta-schema check for this is pending once these existing cases are > fixed. > > Cc: Jonathan

Re: [PATCH] dt-bindings: Add missing array size constraints

rry Reding > Cc: MyungJoo Ham > Cc: Chanwoo Choi > Cc: Linus Walleij > Cc: Bartosz Golaszewski > Cc: Jonathan Cameron > Cc: Dmitry Torokhov > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Mauro Carvalho Chehab > Cc: Chen-Yu Tsai > Cc: Ulf Hansson > Cc

Re: [PATCH] dt-bindings: Drop redundant minItems/maxItems

etree/bindings/iio/adc/amlogic,meson-saradc.yaml | 1 - For this one, the fact it overrides maxItems elsewhere makes this a little bit odd. I guess we can get used to it being implicit. > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 2 -- Acked-by: Jonathan Cameron

Re: [PATCH 00/25] Rid W=1 warnings from HID

ent-if.h | 8 +++- > 24 files changed, 90 insertions(+), 81 deletions(-) > > Cc: Alexandre Torgue > Cc: Anssi Hannula > Cc: Benjamin Tissoires > Cc: "Bruno Prémont" > Cc: "Christian König" > Cc: Daniel Drubin > Cc: Dario Pagani > Cc:

Re: [PATCH 00/15] iio: buffer-dma: write() and new DMABUF based API

On Mon, 15 Nov 2021 14:19:10 + Paul Cercueil wrote: > Hi Jonathan, > > This patchset introduces a new userspace interface based on DMABUF > objects, to complement the existing fileio based API. > > The advantage of this DMABUF based interface vs. the fileio > interface, is that it avoids

Re: [PATCH 07/15] iio: core: Add new DMABUF interface infrastructure

On Mon, 15 Nov 2021 14:19:17 + Paul Cercueil wrote: > Add the necessary infrastructure to the IIO core to support a new DMABUF > based interface. > > The advantage of this new DMABUF based interface vs. the read() > interface, is that it avoids an extra copy of the data between the > kernel

Re: [PATCH 11/15] iio: buffer-dma: Boost performance using write-combine cache setting

On Mon, 15 Nov 2021 14:19:21 + Paul Cercueil wrote: > We can be certain that the input buffers will only be accessed by > userspace for reading, and output buffers will mostly be accessed by > userspace for writing. Mostly? Perhaps a little more info on why that's not 'only'. > >

Re: [PATCH 04/15] iio: buffer-dma: Enable buffer write support

On Mon, 15 Nov 2021 14:19:14 + Paul Cercueil wrote: > Adding write support to the buffer-dma code is easy - the write() > function basically needs to do the exact same thing as the read() > function: dequeue a block, read or write the data, enqueue the block > when entirely processed. > >

Re: [PATCH 01/15] iio: buffer-dma: Get rid of incoming/outgoing queues

On Mon, 15 Nov 2021 14:19:11 + Paul Cercueil wrote: > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much

Re: [PATCH 15/15] Documentation: iio: Document high-speed DMABUF based API

On Mon, 15 Nov 2021 14:22:43 + Paul Cercueil wrote: > Document the new DMABUF based API. > > Signed-off-by: Paul Cercueil Hi Paul, A few trivial things inline but looks good to me if we do end up using DMABUF anyway. Jonathan > --- > Documentation/driver-api/dma-buf.rst | 2 + >

Re: [PATCH 08/15] iio: buffer-dma: split iio_dma_buffer_fileio_free() function

On Tue, 16 Nov 2021 12:59:30 +0200 Alexandru Ardelean wrote: > On Mon, Nov 15, 2021 at 4:20 PM Paul Cercueil wrote: > > > > From: Alexandru Ardelean > > > > A part of the logic in the iio_dma_buffer_exit() is required for the change > > to add mmap support to IIO buffers. > > This change

Re: [PATCH 03/15] iio: buffer-dma: Use round_down() instead of rounddown()

On Mon, 15 Nov 2021 14:19:13 + Paul Cercueil wrote: > We know that the buffer's alignment will always be a power of two; > therefore, we can use the faster round_down() macro. > > Signed-off-by: Paul Cercueil *groan*. I don't want to know where the naming of these two came from but that

Re: [PATCH 04/15] iio: buffer-dma: Enable buffer write support

On Sun, 21 Nov 2021 17:19:32 + Paul Cercueil wrote: > Hi Jonathan, > > Le dim., nov. 21 2021 at 14:20:49 +, Jonathan Cameron > a écrit : > > On Mon, 15 Nov 2021 14:19:14 + > > Paul Cercueil wrote: > > > >> Adding write support to

Re: [PATCH 11/15] iio: buffer-dma: Boost performance using write-combine cache setting

On Sun, 21 Nov 2021 17:43:20 + Paul Cercueil wrote: > Hi Jonathan, > > Le dim., nov. 21 2021 at 15:00:37 +, Jonathan Cameron > a écrit : > > On Mon, 15 Nov 2021 14:19:21 + > > Paul Cercueil wrote: > > > >> We can be certain that

Re: [PATCH 03/15] iio: buffer-dma: Use round_down() instead of rounddown()

On Mon, 22 Nov 2021 10:00:19 + Paul Cercueil wrote: > Hi Jonathan, > > Le dim., nov. 21 2021 at 14:08:23 +, Jonathan Cameron > a écrit : > > On Mon, 15 Nov 2021 14:19:13 + > > Paul Cercueil wrote: > > > >> We know that the buffer's

Re: [PATCH 11/15] iio: buffer-dma: Boost performance using write-combine cache setting

On Thu, 25 Nov 2021 17:29:58 + Paul Cercueil wrote: > Hi Jonathan, > > Le dim., nov. 21 2021 at 17:43:20 +, Paul Cercueil > a écrit : > > Hi Jonathan, > > > > Le dim., nov. 21 2021 at 15:00:37 +, Jonathan Cameron > > a écrit : > >>

Re: [PATCH v2 00/12] iio: buffer-dma: write() and new DMABUF based API

On Mon, 7 Feb 2022 12:59:21 + Paul Cercueil wrote: > Hi Jonathan, > > This is the V2 of my patchset that introduces a new userspace interface > based on DMABUF objects to complement the fileio API, and adds write() > support to the existing fileio API. Hi Paul, It's been a little while.

Re: [PATCH v2 01/12] iio: buffer-dma: Get rid of outgoing queue

On Mon, 7 Feb 2022 12:59:22 + Paul Cercueil wrote: > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much

Re: [PATCH v8 02/16] clk: Provide new devm_clk helpers for prepared and enabled clocks

On Mon, 14 Mar 2022 15:16:29 +0100 Uwe Kleine-König wrote: > When a driver keeps a clock prepared (or enabled) during the whole > lifetime of the driver, these helpers allow to simplify the drivers. > > Reviewed-by: Jonathan Cameron > Reviewed-by: Alexandru Ardelea

Re: [PATCH v2 02/12] iio: buffer-dma: Enable buffer write support

On Mon, 7 Feb 2022 12:59:23 + Paul Cercueil wrote: > Adding write support to the buffer-dma code is easy - the write() > function basically needs to do the exact same thing as the read() > function: dequeue a block, read or write the data, enqueue the block > when entirely processed. > >

Re: [PATCH v2 04/12] iio: buffer-dmaengine: Enable write support

On Mon, 7 Feb 2022 12:59:25 + Paul Cercueil wrote: > Use the iio_dma_buffer_write() and iio_dma_buffer_space_available() > functions provided by the buffer-dma core, to enable write support in > the buffer-dmaengine code. > > Signed-off-by: Paul Cercueil > Reviewed-by: Alexandru Ardelean

Re: [PATCH v2 07/12] iio: buffer-dma: Use DMABUFs instead of custom solution

On Mon, 7 Feb 2022 12:59:28 + Paul Cercueil wrote: > Enhance the current fileio code by using DMABUF objects instead of > custom buffers. > > This adds more code than it removes, but: > - a lot of the complexity can be dropped, e.g. custom kref and > iio_buffer_block_put_atomic() are not

Re: [PATCH v2 05/12] iio: core: Add new DMABUF interface infrastructure

On Mon, 7 Feb 2022 12:59:26 + Paul Cercueil wrote: > Add the necessary infrastructure to the IIO core to support a new > optional DMABUF based interface. > > The advantage of this new DMABUF based interface vs. the read() > interface, is that it avoids an extra copy of the data between the

Re: [PATCH v2 01/12] iio: buffer-dma: Get rid of outgoing queue

On Mon, 7 Feb 2022 12:59:22 + Paul Cercueil wrote: > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much

Re: [PATCH v2 08/15] mfd: mt6370: Add Mediatek MT6370 support

On Mon, 13 Jun 2022 19:11:39 +0800 ChiaEn Wu wrote: > From: ChiYuan Huang > > Add Mediatek MT6370 MFD support. > > Signed-off-by: ChiYuan Huang Hi. A few trivial things that probably overlap with other reviewer comments. > +static int mt6370_check_vendor_info(struct mt6370_info *info) >

Re: [PATCH v2 11/15] iio: adc: mt6370: Add Mediatek MT6370 support

On Mon, 13 Jun 2022 19:11:42 +0800 ChiaEn Wu wrote: > From: ChiaEn Wu > > Add Mediatek MT6370 ADC support. > > Signed-off-by: ChiaEn Wu Hi ChiaEn Wu, A few comments inline, but mostly looks good to me with the exception of the scales which look far too large. Thanks, Jonathan > --- >

Re: [PATCH v2 07/15] Documentation: ABI: testing: mt6370: Add ADC sysfs guideline

On Mon, 13 Jun 2022 19:11:38 +0800 ChiaEn Wu wrote: > From: ChiaEn Wu > > Add ABI documentation for mt6370 non-standard ADC sysfs interfaces. > > Signed-off-by: ChiaEn Wu > --- > .../ABI/testing/sysfs-bus-iio-adc-mt6370 | 36 +++ > 1 file changed, 36 insertions(+) >

Re: [PATCH v2 07/15] Documentation: ABI: testing: mt6370: Add ADC sysfs guideline

On Mon, 20 Jun 2022 14:00:43 +0800 ChiaEn Wu wrote: > Hi Jonathan, > > Thanks for your helpful comments, and I have some questions want to > ask you below. > > Jonathan Cameron 於 2022年6月18日 週六 晚上11:39寫道： > > > > On Mon, 13 Jun 2022 19:11:38 +0800 > > ChiaEn

Re: [RESEND 10/14] iio: adc: mt6370: Add Mediatek MT6370 support

> > > > > + > > > +#define MT6370_AICR_400MA0x6 > > > +#define MT6370_ICHG_500MA0x4 > > > +#define MT6370_ICHG_900MA0x8 > > > + > > > +#define ADC_CONV_TIME_US 35000 > > > +#define ADC_CONV_POLLING_TIME1000 > > > + > > > +struct

Re: [PATCH] dt-bindings: Drop redundant 'maxItems/minItems' in if/then schemas

hen a 'minItems' or 'maxItems' with the > same size as the list is redundant and can be dropped. Note that is DT > schema specific behavior and not standard json-schema behavior. The tooling > will fixup the final schema adding any unspecified minItems/maxItems. Acked-by: Jonathan Cameron #fo

Re: [PATCH] dt-bindings: Remove "status" from schema examples, again

pending, so hopefully the last time to > fix these. > > Fix the indentation in intel,phy-thunderbay-emmc while we're here. > > Signed-off-by: Rob Herring Acked-by: Jonathan Cameron #for-iio > --- > .../arm/tegra/nvidia,tegra-ccplex-cluster.yaml| 1 - > .../disp

Re: [PATCH v7 09/13] iio: adc: mt6370: Add MediaTek MT6370 support

e-C & Power Delivery controller in > > MediaTek MT6370 IC. > > Reviewed-by: Andy Shevchenko Oops. I just noticed I replied only to Andy due to a misclick. Acked-by: Jonathan Cameron I took a quick glance through, and with Andy's comments now all answered to his satisfaction I'

Re: [PATCH v7 06/13] dt-bindings: mfd: Add MediaTek MT6370

On Tue, 9 Aug 2022 14:14:14 +0100 Lee Jones wrote: > On Fri, 05 Aug 2022, ChiaEn Wu wrote: > > > From: ChiYuan Huang > > > > Add MediaTek MT6370 binding documentation. > > > > Reviewed-by: Krzysztof Kozlowski > > Signed-off-by: ChiYuan Huang > > Signed-off-by: ChiaEn Wu > > --- > >

Re: [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties

and include instead in the SPI controller bindings. The controller > bindings will provide CPHA/CPOL type validation and one place for > description. Each device schema must list the properties if they are > applicable. > > Suggested-by: Jonathan Cameron > Suggested

Re: [PATCH v2 04/13] iio: imu: Replace all spi->chip_select and spi->cs_gpiod references with function call

s_gpiod > members of the spi_device structure would be converted to arrays & the > "idx" parameter of the APIs would be used as array index i.e., > spi->chip_select[idx] & spi->cs_gpiod[idx] respectively. > > Signed-off-by: Amit Kumar Mahapatra Acked-by:

Re: [PATCH v4 0/8] Support ROHM BU27034 ALS sensor

On Fri, 17 Mar 2023 16:40:16 +0200 Matti Vaittinen wrote: > Support ROHM BU27034 ALS sensor Hi Matti, For ease of when this is ready to apply, better to just keep key mailing lists and individuals cc'd on all patches. Mind you cc list is random enough I'm guessing it wasn't deliberate (like

Re: [PATCH v3 03/11] iio: buffer-dma: Get rid of outgoing queue

On Tue, 18 Apr 2023 10:08:21 +0200 Paul Cercueil wrote: > Hi Jonathan, > > Le dimanche 16 avril 2023 à 15:24 +0100, Jonathan Cameron a écrit : > > On Mon,  3 Apr 2023 17:47:52 +0200 > > Paul Cercueil wrote: > > > > > The buffer-dma code was usi

Re: [PATCH v3 03/11] iio: buffer-dma: Get rid of outgoing queue

On Mon, 3 Apr 2023 17:47:52 +0200 Paul Cercueil wrote: > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much

Re: [PATCH v3 06/11] iio: buffer-dmaengine: Enable write support

On Mon, 3 Apr 2023 17:47:55 +0200 Paul Cercueil wrote: > Use the iio_dma_buffer_write() and iio_dma_buffer_space_available() > functions provided by the buffer-dma core, to enable write support in > the buffer-dmaengine code. > > Signed-off-by: Paul Cercueil > Reviewed-by: Alexandru Ardelean

Re: [PATCH v3 05/11] iio: buffer-dmaengine: Support specifying buffer direction

On Mon, 3 Apr 2023 17:47:54 +0200 Paul Cercueil wrote: > Update the devm_iio_dmaengine_buffer_setup() function to support > specifying the buffer direction. > > Update the iio_dmaengine_buffer_submit() function to handle input > buffers as well as output buffers. > > Signed-off-by: Paul

Re: [PATCH v3 10/11] iio: buffer-dmaengine: Support new DMABUF based userspace API

On Mon, 3 Apr 2023 17:49:54 +0200 Paul Cercueil wrote: > Use the functions provided by the buffer-dma core to implement the > DMABUF userspace API in the buffer-dmaengine IIO buffer implementation. > > Since we want to be able to transfer an arbitrary number of bytes and > not necesarily the

Re: [PATCH v3 04/11] iio: buffer-dma: Enable buffer write support

On Mon, 3 Apr 2023 17:47:53 +0200 Paul Cercueil wrote: > Adding write support to the buffer-dma code is easy - the write() > function basically needs to do the exact same thing as the read() > function: dequeue a block, read or write the data, enqueue the block > when entirely processed. > >

Re: [PATCH v3 07/11] iio: core: Add new DMABUF interface infrastructure

On Mon, 3 Apr 2023 17:47:56 +0200 Paul Cercueil wrote: > Add the necessary infrastructure to the IIO core to support a new > optional DMABUF based interface. > > With this new interface, DMABUF objects (externally created) can be > attached to a IIO buffer, and subsequently used for data

Re: [PATCH v3 09/11] iio: buffer-dma: Enable support for DMABUFs

On Mon, 3 Apr 2023 17:47:58 +0200 Paul Cercueil wrote: > Implement iio_dma_buffer_attach_dmabuf(), iio_dma_buffer_detach_dmabuf() > and iio_dma_buffer_transfer_dmabuf(), which can then be used by the IIO > DMA buffer implementations. > > Signed-off-by: Paul Cercueil Hi Paul, A few

Re: [PATCH] dt-bindings: cleanup DTS example whitespaces

On Sun, 2 Jul 2023 20:23:08 +0200 Krzysztof Kozlowski wrote: > The DTS code coding style expects spaces around '=' sign. > > Signed-off-by: Krzysztof Kozlowski > For the IIO one. Acked-by: Jonathan Cameron Thanks for tidying these up. Jonathan > --- > > Rob, > &

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

On Mon, 22 Jan 2024 18:18:22 + Mark Brown wrote: > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > > Note that Jonathan Cameron has already applied patch 3 to his tree, it > > didn't appear in a public tree though yet. I still included it here to &

Re: [PATCH v2 00/33] spi: get rid of some legacy macros

On Mon, 22 Jan 2024 19:23:43 + Jonathan Cameron wrote: > On Mon, 22 Jan 2024 18:18:22 + > Mark Brown wrote: > > > On Mon, Jan 22, 2024 at 07:06:55PM +0100, Uwe Kleine-König wrote: > > > > > Note that Jonathan Cameron has already applied patch 3 to hi

Re: [PATCH v5 7/8] iio: buffer-dmaengine: Support new DMABUF based userspace API

On Fri, 22 Dec 2023 09:58:29 +0100 Nuno Sá wrote: > On Thu, 2023-12-21 at 18:30 +0100, Paul Cercueil wrote: > > Hi Jonathan, > > > > Le jeudi 21 décembre 2023 à 16:12 +0000, Jonathan Cameron a écrit : > > > On Tue, 19 Dec 2023 18:50:08 +0100 > > > Pau

Re: [PATCH v5 6/8] iio: buffer-dma: Enable support for DMABUFs

> > > +struct iio_dma_buffer_block * > > > +iio_dma_buffer_attach_dmabuf(struct iio_buffer *buffer, > > > +    struct dma_buf_attachment *attach) > > > +{ > > > +   struct iio_dma_buffer_queue *queue = iio_buffer_to_queue(buffer); > > > +   struct

Re: [PATCH v5 0/8] iio: new DMABUF based API, v5

On Thu, 21 Dec 2023 18:56:52 +0100 Paul Cercueil wrote: > Hi Jonathan, > > Le jeudi 21 décembre 2023 à 16:30 +, Jonathan Cameron a écrit : > > On Tue, 19 Dec 2023 18:50:01 +0100 > > Paul Cercueil wrote: > > > > > [V4 was: "iio: Add buffer writ

Re: [PATCH v5 6/8] iio: buffer-dma: Enable support for DMABUFs

On Tue, 19 Dec 2023 18:50:07 +0100 Paul Cercueil wrote: > Implement iio_dma_buffer_attach_dmabuf(), iio_dma_buffer_detach_dmabuf() > and iio_dma_buffer_transfer_dmabuf(), which can then be used by the IIO > DMA buffer implementations. > > Signed-off-by: Paul Cercueil > Hi Paul, A few

Re: [PATCH v5 0/8] iio: new DMABUF based API, v5

On Tue, 19 Dec 2023 18:50:01 +0100 Paul Cercueil wrote: > [V4 was: "iio: Add buffer write() support"][1] > > Hi Jonathan, > Hi Paul, > This is a respin of the V3 of my patchset that introduced a new > interface based on DMABUF objects [2]. Great to see this moving forwards. > > The V4 was

Re: [PATCH v5 8/8] Documentation: iio: Document high-speed DMABUF based API

On Tue, 19 Dec 2023 18:50:09 +0100 Paul Cercueil wrote: > Document the new DMABUF based API. > > Signed-off-by: Paul Cercueil One minor comment inline. > > --- > v2: - Explicitly state that the new interface is optional and is > not implemented by all drivers. > - The IOCTLs can

Re: [PATCH v5 7/8] iio: buffer-dmaengine: Support new DMABUF based userspace API

On Tue, 19 Dec 2023 18:50:08 +0100 Paul Cercueil wrote: > Use the functions provided by the buffer-dma core to implement the > DMABUF userspace API in the buffer-dmaengine IIO buffer implementation. > > Since we want to be able to transfer an arbitrary number of bytes and > not necesarily the

Re: [PATCH v5 5/8] iio: core: Add new DMABUF interface infrastructure

On Tue, 19 Dec 2023 18:50:06 +0100 Paul Cercueil wrote: > Add the necessary infrastructure to the IIO core to support a new > optional DMABUF based interface. > > With this new interface, DMABUF objects (externally created) can be > attached to a IIO buffer, and subsequently used for data

Re: [PATCH v5 1/8] iio: buffer-dma: Get rid of outgoing queue

On Tue, 19 Dec 2023 18:50:02 +0100 Paul Cercueil wrote: > The buffer-dma code was using two queues, incoming and outgoing, to > manage the state of the blocks in use. > > While this totally works, it adds some complexity to the code, > especially since the code only manages 2 blocks. It is much

Re: [PATCH v5 2/8] iio: buffer-dma: split iio_dma_buffer_fileio_free() function

On Tue, 19 Dec 2023 18:50:03 +0100 Paul Cercueil wrote: > From: Alexandru Ardelean > > This change splits the logic into a separate function, which will be > re-used later. > > Signed-off-by: Alexandru Ardelean > Cc: Alexandru Ardelean > Signed-off-by: Paul Cercueil Harmless refactor so

Re: [PATCH v5 3/8] dmaengine: Add API function dmaengine_prep_slave_dma_vec()

On Tue, 19 Dec 2023 18:50:04 +0100 Paul Cercueil wrote: > This function can be used to initiate a scatter-gather DMA transfer, > where the address and size of each segment is located in one entry of > the dma_vec array. > > The major difference with dmaengine_prep_slave_sg() is that it supports

Re: [PATCH 10/17] dt-bindings: iio: samsung,exynos-adc: add specific compatibles for existing SoC

n/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozl

Re: [PATCH v5 5/8] iio: core: Add new DMABUF interface infrastructure

> > > + iio_buffer_dmabuf_put(attach); > > > + > > > +out_dmabuf_put: > > > + dma_buf_put(dmabuf); > > As below. Feels like a __free(dma_buf_put) bit of magic would be a > > nice to have. > > I'm working on the patches right now, just one quick question. > > Having a __free(dma_buf_put)

Re: [PATCH v7 0/6] iio: new DMABUF based API

On Fri, 23 Feb 2024 13:13:58 +0100 Nuno Sa wrote: > Hi Jonathan, likely you're wondering why I'm sending v7. Well, to be > honest, we're hoping to get this merged this for the 6.9 merge window. > Main reason is because the USB part is already in (so it would be nice > to get the whole thing in).

Re: [PATCH v7 0/6] iio: new DMABUF based API

On Mon, 04 Mar 2024 08:59:47 +0100 Nuno Sá wrote: > On Sun, 2024-03-03 at 17:42 +0000, Jonathan Cameron wrote: > > On Fri, 23 Feb 2024 13:13:58 +0100 > > Nuno Sa wrote: > > > > > Hi Jonathan, likely you're wondering why I'm sending v7. Well, to be >

Re: [PATCH v8 0/6] iio: new DMABUF based API

On Fri, 8 Mar 2024 18:00:40 +0100 Paul Cercueil wrote: > Hi Jonathan, > > Here's the final(tm) version of the IIO DMABUF patchset. > > This v8 fixes the remaining few issues that Christian reported. > > I also updated the documentation patch as there has been changes to > index.rst. > >

Re: [PATCH v9 0/6] iio: new DMABUF based API

On Sun, 10 Mar 2024 13:48:29 +0100 Paul Cercueil wrote: > Hi Jonathan, > > Here's the final-er version of the IIO DMABUF patchset. > > This v9 fixes the few issues reported by the kernel bot. > > This was based on next-20240308. > > Changelog: > > - [3/6]: > - Select DMA_SHARED_BUFFER

Re: [PATCH] i2c: mux: Remove class argument from i2c_mux_add_adapter()

; > Note: Class-based device instantiation is a legacy mechanism which > shouldn't be used in new code, so we can rule out that this argument > may be needed again in the future. > > Signed-off-by: Heiner Kallweit For iio Acked-by: Jonathan Cameron > --- > driv