[PATCH] drm/panel: simple: Fix bus_format for the Olimex LCD-OLinuXino-4.3TS

The format is RGB888 not RGB666. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/panel/panel-simple.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1..d4aa68e 100644 --- a/drivers/gpu

[PATCH] drm/sun4i: rgb: Enable panel after controller

Hi Maxime, On Thursday, 22 September 2016, Maxime Ripard wrote: > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: > > The panel should be enabled after the controller so that the panel > > prepare/enable delays are properly taken into account. Similarly, the &

[PATCH] drm/sun4i: rgb: Enable panel after controller

glitches. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_rgb.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_rgb.c b/drivers/gpu/drm/sun4i/sun4i_rgb.c index c3ff10f..4e4bea6 100644 --- a/drivers/gpu/drm/sun4i/sun4i_rgb.c

[PATCH] drm/sun4i: rgb: Enable panel after controller

Hi Maxime, On 22 September 2016 at 07:03, Maxime Ripard wrote: > On Wed, Sep 21, 2016 at 11:03:04PM +1000, Jonathan Liu wrote: >> The panel should be enabled after the controller so that the panel >> prepare/enable delays are properly taken into account. Similarly, the

[PATCH] drm/sun4i: rgb: Enable panel after controller

Hi Maxime, On 23 September 2016 at 23:16, Maxime Ripard wrote: > On Thu, Sep 22, 2016 at 08:03:31AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On Thursday, 22 September 2016, Maxime Ripard > free-electrons. >> com> wrote: >> >> > On Wed, Sep

[PATCH][v2] drm/sun4i: rgb: Enable panel after controller

The panel should be enabled after the controller so that we do not have visual glitches on the panel while the controller is setup. Similarly, the panel should be disabled before the controller. Signed-off-by: Jonathan Liu --- Changes in v2: - Changed the commit message to be clearer drivers

[PATCH] drm/sun4i: rgb: add missing calls to drm_panel_{prepare, unprepare}

If the enable-gpios property of a simple panel in device tree is set, the GPIO is not toggled on/off because of missing calls to drm_panel_prepare and drm_panel_unprepare. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/sun4i/sun4i_rgb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[linux-sunxi] [PATCH 11/19] drm: sun4i: Add composite output

On 31 October 2015 at 01:20, Maxime Ripard wrote: > Some Allwinner SoCs have an IP called the TV encoder that is used to output > composite and VGA signals. In such a case, we need to use the second TCON > channel. > > Add support for that TV encoder. > > Signed-off-by: Maxime Ripard > --- >

[PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

The drm_driver lastclose callback is called when the last userspace DRM client has closed. Call drm_fbdev_cma_restore_mode to restore the fbdev console otherwise the fbdev console will stop working. Signed-off-by: Jonathan Liu <net...@gmail.com> --- Changes for v2: - Rename sun4i_drm_las

[PATCH] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

The drm_driver lastclose callback is called when the last userspace DRM client has closed. Call drm_fbdev_cma_restore_mode to restore the fbdev console otherwise the fbdev console will stop working. Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_drv

[PATCH v3] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

kernel.org Signed-off-by: Jonathan Liu <net...@gmail.com> Reviewed-by: Chen-Yu Tsai <w...@csie.org> --- Changes for v3: - Add 'Fixes:' tag - Add CC to stable - Add 'Reviewed-by: Chen-Yu Tsai <w...@csie.org>' Changes for v2: - Rename sun4i_drm_lastclose to sun4i_drv_lastc

Re: [PATCH v2] drm/sun4i: Implement drm_driver lastclose to restore fbdev console

Hi Maxime, On 10 July 2017 at 16:44, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Sun, Jul 09, 2017 at 11:11:07PM +0800, Chen-Yu Tsai wrote: >> On Sun, Jul 9, 2017 at 3:59 PM, Jonathan Liu <net...@gmail.com> wrote: >> > The drm_driver lastclose ca

[PATCH] drm/panel: simple: Fix width and height for Olimex LCD-OLinuXino-4.3TS

The physical size of the panel is 105.5 (W) x 67.2 (H) x 4.05 (D) mm but the active display area is 95.04 (W) x 53.856 (H) mm. The width and height should be set to the active display area. Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/panel/panel-simple.c | 4 ++--

Re: [PATCH v7] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Chen-Yu, On 29 June 2017 at 12:47, Chen-Yu Tsai <w...@csie.org> wrote: > Hi, > > On Wed, Jun 28, 2017 at 6:52 PM, Jonathan Liu <net...@gmail.com> wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 30 June 2017 at 01:56, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Wed, Jun 28, 2017 at 08:39:33PM +1000, Jonathan Liu wrote: >> >> + u32 int_status; >> >> + u32 fifo_status; >> >> + /* Read needs

Re: [PATCH v4] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 27 June 2017 at 05:05, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Sat, Jun 24, 2017 at 04:10:54PM +1000, Jonathan Liu wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the general case

[PATCH v6] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

[PATCH v7] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

[PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 28 June 2017 at 19:20, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Wed, Jun 28, 2017 at 12:36:52AM +1000, Jonathan Liu wrote: >> +#define SUN4I_HDMI_DDC_INT_STATUS_ERROR_MASK ( \ >> + SUN4I_HDMI_DDC_INT_STATUS_I

[PATCH v8] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Chen-Yu and Maxime, On 30 June 2017 at 13:16, Chen-Yu Tsai <w...@csie.org> wrote: > On Fri, Jun 30, 2017 at 6:22 AM, Jonathan Liu <net...@gmail.com> wrote: >> Hi Maxime, >> >> On 30 June 2017 at 01:56, Maxime Ripard >> <maxime.rip...@free-electrons.com

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 30 June 2017 at 19:34, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > Hi, > > On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: >> Hi Maxime, >> >> On 30 June 2017 at 01:56, Maxime Ripard >> <maxime.rip...@free-elect

Re: [PATCH v5] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 30 June 2017 at 19:58, Jonathan Liu <net...@gmail.com> wrote: > Hi Maxime, > > On 30 June 2017 at 19:34, Maxime Ripard > <maxime.rip...@free-electrons.com> wrote: >> Hi, >> >> On Fri, Jun 30, 2017 at 08:22:13AM +1000, Jonathan Liu wrote: &g

[PATCH] drm/panel: simple: Add missing panel_simple_unprepare calls

16+ Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/panel/panel-simple.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 474fa759e06e..234af81fb3d0 100644 --- a/drivers/gpu/drm/pane

Re: [PATCH v3] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 21 June 2017 at 18:51, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Thu, Jun 15, 2017 at 01:29:33AM +1000, Jonathan Liu wrote: >> The documentation for drm_do_get_edid in drivers/gpu/drm/drm_edid.c states: >> "As in the general case

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 21 June 2017 at 18:41, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Tue, Jun 13, 2017 at 09:53:31PM +1000, Jonathan Liu wrote: >> >> --- /dev/null >> >> +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c >> >> @@ -0,0 +1,

[PATCH v4] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

Re: [PATCH v3] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 22 June 2017 at 07:26, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Wed, Jun 21, 2017 at 07:42:47PM +1000, Jonathan Liu wrote: >> >> +static int wait_fifo_flag_unset(struct sun4i_hdmi *hdmi, u32 flag) >> >> +{ >> >> +

[PATCH v3] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

[PATCH] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Exposing the DDC bus as an I2C adapter is more beneficial as it can be used for purposes other than reading the EDID such as modifying the EDID or using the HDMI DDC pins as an I2C bus through the I2C dev interface from userspace (e.g. i2c-tools). Implement this for A10s. Signed-off-by: Jonatha

[PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

The drm_get_edid function should be used instead of drm_do_get_edid by exposing the DDC bus as an I2C adapter. Implement this for A10s. Signed-off-by: Jonathan Liu <net...@gmail.com> --- Changes for v2: - Rebased against Maxime's sunxi-drm/for-next branch - Fix up error paths in sun4i_hdm

Re: [PATCH] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Chen-Yu, On 12 June 2017 at 13:28, Chen-Yu Tsai <w...@csie.org> wrote: > On Mon, Jun 12, 2017 at 10:12 AM, Jonathan Liu <net...@gmail.com> wrote: >> The drm_get_edid function should be used instead of drm_do_get_edid by >> exposing the DDC bus as an I2C adapt

[PATCH] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

The drm_get_edid function should be used instead of drm_do_get_edid by exposing the DDC bus as an I2C adapter. Implement this for A10s. Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/Makefile | 1 + drivers/gpu/drm/sun4i/sun4i_hdmi.h | 11 ++- drive

Re: [PATCH v2] drm/sun4i: hdmi: Implement I2C adapter for A10s DDC bus

Hi Maxime, On 13 June 2017 at 21:15, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Mon, Jun 12, 2017 at 03:52:35PM +1000, Jonathan Liu wrote: >> The drm_get_edid function should be used instead of drm_do_get_edid by >> exposing the DDC bus as an I2C adapter. Im

[PATCH] drm/sun4i: tcon: Add dithering support for RGB565/RGB666 LCD panels

Dithering is supported on TCON channel 0 which is used for LCD panels. Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_tcon.c | 37 + drivers/gpu/drm/sun4i/sun4i_tcon.h | 18 +- 2 files changed, 54 inse

Re: [14/23] drm/sun4i: Create minimal multipliers and dividers

Hi Maxime, On 17 October 2017 at 20:06, Maxime Ripard wrote: > The various outputs the TCON can provide have different constraints on the > dotclock divider. Let's make them configurable by the various mode_set > functions. > > Signed-off-by: Maxime Ripard

Re: [15/23] drm/sun4i: Add LVDS support

Hi Maxime, On 17 October 2017 at 20:06, Maxime Ripard wrote: > The TCON supports the LVDS interface to output to a panel or a bridge. > Let's add support for it. > > Signed-off-by: Maxime Ripard > --- >

Re: [PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

Hi Maxime, On 5 January 2018 at 21:03, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Fri, Jan 05, 2018 at 09:44:39AM +1100, Jonathan Liu wrote: >> On 5 January 2018 at 06:56, Maxime Ripard >> <maxime.rip...@free-electrons.com> wrote: >> > On T

Re: [PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

Hi Maxime, On 5 January 2018 at 06:56, Maxime Ripard <maxime.rip...@free-electrons.com> wrote: > On Tue, Dec 26, 2017 at 10:12:25PM +1100, Jonathan Liu wrote: >> We should check if the best match has been set before comparing it. >> >> Fixes: 9c5681011a0c ("drm/sun

[PATCH v3 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate

best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1

[PATCH v3 0/3] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

commit message for unset best_parent Changes for v2: - Split into separate patches for each issue - Add details to commit message for reproducing issue Jonathan Liu (3): drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate drm/sun4i: hdmi: Fix incorrect assignment

[PATCH v3 3/3] drm/sun4i: hdmi: Add missing rate halving check in sun4i_tmds_determine_rate

sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmd

[PATCH v3 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

never set. This results in req->rate and req->best_parent_rate being assigned 0. To avoid this, we set best_parent to the first calculated rate if it is unset. The sun4i_tmds_calc_divider function already has a similar check. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed

[PATCH v2 3/3] drm/sun4i: hdmi: Add missing rate halving check in sun4i_tmds_determine_rate

sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_tmd

[PATCH v2 1/3] drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate

We should check if the best match has been set before comparing it. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

[PATCH v2 0/3] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

into separate patches for each issue - Add details to commit message for reproducing issue Jonathan Liu (3): drm/sun4i: hdmi: Check for unset best_parent in sun4i_tmds_determine_rate drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate drm/sun4i: hdmi: Add missing rate

[PATCH v2 2/3] drm/sun4i: hdmi: Fix incorrect assignment in sun4i_tmds_determine_rate

best_div is set to i which corresponds to rate halving when it should be set to j which corresponds to the divider. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net...@gmail.com> --- drivers/gpu/drm/sun4i/sun4i_hdmi_tmds_clk.c | 2 +- 1

[PATCH] drm/sun4i: hdmi: Fix sun4i_tmds_determine_rate

the requested rate exactly - sets best_div to i which corresponds to rate halving when it should be set to j which corresponds to the divider Fix these issues. Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support") Signed-off-by: Jonathan Liu <net...@gmail.com> --- drive

[PATCH libdrm] tests/util: Add support for sun4i-drm module

Add support for sun4i DRM driver merged for Linux 4.7. Signed-off-by: Jonathan Liu <net...@gmail.com> --- tests/util/kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/kms.c b/tests/util/kms.c index 8b3e7878..ffae2531 100644 --- a/tests/util/kms.c +++ b/tests/util

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

Hi Giulio, On Wed, 12 Dec 2018 at 04:39, Giulio Benetti wrote: > > Forgot to ask you, > > Il 11/12/2018 18:20, Giulio Benetti ha scritto: > > Hi Jonathan, > > > > Il 11/12/2018 11:49, Jonathan Liu ha scritto: > >> Hi Giulio, > >> > >>

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

Hi Giulio, On Wed, 12 Dec 2018 at 04:20, Giulio Benetti wrote: > > Hi Jonathan, > > Il 11/12/2018 11:49, Jonathan Liu ha scritto: > > Hi Giulio, > > > > On Thu, 6 Dec 2018 at 22:00, Giulio Benetti > > wrote: > >> > >> Hi Jonathan, > >&

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

Hi Giulio, On Thu, 6 Dec 2018 at 22:00, Giulio Benetti wrote: > > Hi Jonathan, > > Il 06/12/2018 08:29, Jonathan Liu ha scritto: > > Hi Giulio, > > > > On Thu, 15 Feb 2018 at 17:54, Giulio Benetti > > wrote: > >> > >> Differently from

Re: [PATCH] drm/sun4i: fix HSYNC and VSYNC polarity

Hi Giulio, On Thu, 15 Feb 2018 at 17:54, Giulio Benetti wrote: > > Differently from other Lcd signals, HSYNC and VSYNC signals > result inverted if their bits are cleared to 0. > > Invert their settings of IO_POL register. > > Signed-off-by: Giulio Benetti > --- >

[PATCH] drm/rockchip: dw_hdmi: fix incorrect clock in vpll clock error message

Error message incorrectly refers to grf clock instead of vpll clock. Signed-off-by: Jonathan Liu --- drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi

Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

t; > On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > > > It has been observed that resetting force in the detect function can > > > > result in the PHY being powered down in response to hot-plug detect > > > > being asserted, even when the HD

Re: [PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

> On Sat, Oct 31, 2020 at 07:17:47PM +1100, Jonathan Liu wrote: > > > > It has been observed that resetting force in the detect function can > > > > result in the PHY being powered down in response to hot-plug detect > > > > being asserted, even when the HDMI

[PATCH] drm: bridge: dw-hdmi: Avoid resetting force in the detect function

drm_helper_hpd_irq_event dw_hdmi_irq irq_thread_fn irq_thread kthread ret_from_fork Fixes: 381f05a7a842 ("drm: bridge/dw_hdmi: add connector mode forcing") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/d

[PATCH] drm/bridge: ti-sn65dsi83: Fix null pointer dereference in remove callback

If attach has not been called, unloading the driver can result in a null pointer dereference in mipi_dsi_detach as ctx->dsi has not been assigned yet. Fixes: ceb515ba29ba6b ("drm/bridge: ti-sn65dsi83: Add TI SN65DSI83 and SN65DSI84 driver") Signed-off-by: Jonathan Liu --- dr

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Jagan, On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote: > > Hi Jonathan, > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote: > > > > Hi Jagan, > > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > > > @@ -1167,6 +1151,20 @@ __d

Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi Jagan, On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote: > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev, > dw_mipi_dsi_debugfs_init(dsi); > pm_runtime_enable(dev); > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0, > +

Re: [PATCH] drm/bridge: ti-sn65dsi83: Fix null pointer dereference in remove callback

Hi Marek, On Fri, 18 Jun 2021 at 00:14, Laurent Pinchart wrote: > > Hi Jonathan, > > Thank you for the patch. > > On Thu, Jun 17, 2021 at 09:19:25PM +1000, Jonathan Liu wrote: > > If attach has not been called, unloading the driver can result in a null > > pointer

Re: [RESEND PATCH] drm/rockchip: dsi: move all lane config except LCDC mux to bind()

ge would appear when initially loading > rockchipdrm. If I kept rockchipdrm loaded and reloaded the panel driver, > it would come on. With this change, the panel successfully turns on > during initial rockchipdrm load as expected. > > Fixes: 2d4f7bdafd70 ("drm/rockchip: dsi: migra

[PATCH v2] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

the clock phase to 0 if DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE is present in bus_flags, otherwise adjust the clock phase to 1/2 as appropriate for DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE. [1] https://github.com/tdjastrzebski/ICN6211-Configurator Signed-off-by: Jonathan Liu --- V2: Use GENMASK and FIELD_PREP

Re: [PATCH v2] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

Hi Marek, On Mon, 23 May 2022 at 23:15, Marek Vasut wrote: > > On 5/23/22 15:01, Jonathan Liu wrote: > > The code from [1] sets SYS_CTRL_1 to different values depending on the > > desired clock phase (0, 1/4, 1/2 or 3/4). A clock phase of 0 aligns the > > po

[PATCH] drm: bridge: icn6211: Adjust clock phase using SYS_CTRL_1

the clock phase to 0 if DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE is present in bus_flags, otherwise adjust the clock phase to 1/2 as appropriate for DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE. [1] https://github.com/tdjastrzebski/ICN6211-Configurator Signed-off-by: Jonathan Liu --- drivers/gpu/drm/bridge/chipone

[PATCH] drm/modes: Fix outdated drm_mode_vrefresh return value documentation

The vrefresh field in drm_display_mode struct was removed so the function no longer checks if it is set before calculating it. Fixes: 0425662fdf05 ("drm: Nuke mode->vrefresh") Signed-off-by: Jonathan Liu --- drivers/gpu/drm/drm_modes.c | 3 +-- 1 file changed, 1 insertion(+)