Re: Future desktop on dumb frame buffers?

2011-03-24 Thread Laurent Pinchart
. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC] drm: add overlays as first class KMS objects

2011-05-17 Thread Laurent Pinchart
of years ago. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC] Standardize YUV support in the fbdev API

2011-05-17 Thread Laurent Pinchart
/Hold_And_Modify [2] http://lwn.net/Articles/440192/ [3] http://www.fourcc.org/ [4] http://lxr.linux.no/linux+v2.6.38/include/linux/videodev2.h#L271 [5] http://en.wikipedia.org/wiki/Rec._601 [6] http://lxr.linux.no/linux+v2.6.38/include/linux/videodev2.h#L175 -- Regards, Laurent Pinchart

Re: [RFC] Standardize YUV support in the fbdev API

2011-05-23 Thread Laurent Pinchart
Hi Florian, On Saturday 21 May 2011 00:33:02 Florian Tobias Schandinat wrote: On 05/17/2011 10:07 PM, Laurent Pinchart wrote: Hi everybody, I need to implement support for a YUV frame buffer in an fbdev driver. As the fbdev API doesn't support this out of the box, I've spent a couple

Re: [PATCH 2/4] drm: add an fb creation ioctl that takes a pixel format

2011-06-21 Thread Laurent Pinchart
accross subsystems also doesn't sound like a very good idea to me. We could create a header that contains V4L2-agnostic FOURCC #define's, and generate a V4L2 header with the V4L2_ prefix, but I'm not sure it would be a good idea either. -- Regards, Laurent Pinchart

[PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-21 Thread Laurent Pinchart
This API will be used to support YUV frame buffer formats in a standard way. Last but not least, create a much needed fbdev API documentation and document the format setting APIs. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/fb/api.txt | 284

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-21 Thread Laurent Pinchart
Hi Geert, On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: +The following types and visuals are supported. + +- FB_TYPE_PACKED_PIXELS + +- FB_TYPE_PLANES You forgot FB_TYPE_INTERLEAVED_PLANES, FB_TYPE_TEXT

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-06-22 Thread Laurent Pinchart
Hi Florian, On Wednesday 22 June 2011 07:45:45 Florian Tobias Schandinat wrote: On 06/21/2011 10:31 PM, Laurent Pinchart wrote: On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: On Tue, Jun 21, 2011 at 17:36, Laurent Pinchart wrote: +The FOURCC-based API replaces format

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-11 Thread Laurent Pinchart
wrote: On 06/21/2011 10:31 PM, Laurent Pinchart wrote: On Tuesday 21 June 2011 22:49:14 Geert Uytterhoeven wrote: As FOURCC values are always 4 ASCII characters (hence all 4 bytes must be non-zero), I don't think there are any conflicts with existing values of nonstd. To make it even safer

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-25 Thread Laurent Pinchart
field to detect FOURCC mode. I believe FB_CAP_FOURCC (or something similar) is needed. Paul, Geert, Florian, what are your opinions ? On Monday 11 July 2011 17:32:51 Laurent Pinchart wrote: On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: On 06/24/2011 06:55 PM, Geert Uytterhoeven

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-28 Thread Laurent Pinchart
Hi Guennadi, Thanks for the review. On Thursday 28 July 2011 10:31:24 Guennadi Liakhovetski wrote: On Mon, 11 Jul 2011, Laurent Pinchart wrote: On Friday 24 June 2011 21:45:57 Florian Tobias Schandinat wrote: On 06/24/2011 06:55 PM, Geert Uytterhoeven wrote: On Fri, Jun 24, 2011 at 08

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Laurent Pinchart
Hi Florian, Thanks for the feedback. On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote: On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: As for struct fb_var_screeninfo fields to support switching to a FOURCC mode, I

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-07-31 Thread Laurent Pinchart
Hi Geert, Thanks for the feedback. On Sunday 31 July 2011 22:32:42 Geert Uytterhoeven wrote: On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: As for struct fb_var_screeninfo fields to support switching to a FOURCC mode, I also prefer an explicit dedicated flag to specify switching

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-08-01 Thread Laurent Pinchart
Hi Florian, On Monday 01 August 2011 01:58:27 Florian Tobias Schandinat wrote: On 07/31/2011 11:28 PM, Laurent Pinchart wrote: On Monday 01 August 2011 00:54:48 Florian Tobias Schandinat wrote: On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: On Thu, Jul 28, 2011 at 12:51, Laurent

Re: [PATCH/RFC] fbdev: Add FOURCC-based format configuration API

2011-08-11 Thread Laurent Pinchart
Hi Geert, On Monday 01 August 2011 11:49:46 Geert Uytterhoeven wrote: On Mon, Aug 1, 2011 at 00:54, Florian Tobias Schandinat wrote: On 07/31/2011 08:32 PM, Geert Uytterhoeven wrote: On Thu, Jul 28, 2011 at 12:51, Laurent Pinchart wrote: As for struct fb_var_screeninfo fields to support

Re: Proposal for a low-level Linux display framework

2011-09-17 Thread Laurent Pinchart
world vision fb would be a legacy layer on top of DRM. DRM would get the silly recovery fail cases fixed, and a kernel console would be attachable to a GEM object of your choice. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel

Re: Proposal for a low-level Linux display framework

2011-09-17 Thread Laurent Pinchart
://www.ideasonboard.org/media/omap3isp.ps -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Proposal for a low-level Linux display framework

2011-09-18 Thread Laurent Pinchart
Hi Rob, (CC'ing linux-media, as I believe this is very on-topic) On Sunday 18 September 2011 18:14:26 Rob Clark wrote: On Sat, Sep 17, 2011 at 6:12 PM, Laurent Pinchart wrote: On Thursday 15 September 2011 20:39:21 Florian Tobias Schandinat wrote: On 09/15/2011 05:52 PM, Alex Deucher wrote

Re: Proposal for a low-level Linux display framework

2011-09-20 Thread Laurent Pinchart
with a dumb frame buffer and an accelerated output both of which are using memory that can be hit by the accelerated card. Classic example being a USB plug in monitor. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel

Re: drm pixel formats update

2011-11-29 Thread Laurent Pinchart
different version numbers. At least we're not yet into two digits numbers ;) -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Linaro-mm-sig] [PATCH 1/3] dma-buf: Introduce dma buffer sharing mechanism

2012-01-20 Thread Laurent Pinchart
); + + mutex_unlock(dmabuf-lock); + return attach; + +err_alloc: + return ERR_PTR(-ENOMEM); +err_attach: + kfree(attach); + mutex_unlock(dmabuf-lock); + return ERR_PTR(ret); +} +EXPORT_SYMBOL_GPL(dma_buf_attach); -- Regards, Laurent Pinchart

Re: [Linaro-mm-sig] [PATCH 1/3] dma-buf: Introduce dma buffer sharing mechanism

2012-01-26 Thread Laurent Pinchart
Hi Sumit, On Wednesday 25 January 2012 14:56:52 Semwal, Sumit wrote: On Fri, Jan 20, 2012 at 6:53 PM, Laurent Pinchart wrote: Hi Summit, Sorry for the late review. I know that this code is now in mainline, but I still have a couple of comments. I'll send patches if you agree with them

Re: [PATCH] dma-buf: add dma_data_direction to unmap dma_buf_op

2012-01-30 Thread Laurent Pinchart
, -struct sg_table *sg) + struct sg_table *sg, enum dma_data_direction write) s/write/dir/ (or direction) ? { return; } -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH] dma-buf: add dma_data_direction to unmap dma_buf_op

2012-01-31 Thread Laurent Pinchart
the buffer several times with different directions ? -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Business proposal

2012-02-16 Thread Laurent Pinchart
not available on our desk phone) Sure. You can call me at +32477410753. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-02-16 Thread Laurent Pinchart
then not be very useful. This could be split to a DRM device without a KMS interface. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-02-17 Thread Laurent Pinchart
Hi Daniel, On Friday 17 February 2012 10:55:54 Daniel Vetter wrote: On Fri, Feb 17, 2012 at 12:25:51AM +0100, Laurent Pinchart wrote: Hello everybody, First of all, I would like to thank all the attendees for their participation in the mini-summit that helped make the meeting a success

Re: Kernel Display and Video API Consolidation mini-summit at ELC 2012 - Notes

2012-02-17 Thread Laurent Pinchart
Hi Sumit, On Friday 17 February 2012 16:37:35 Semwal, Sumit wrote: On Fri, Feb 17, 2012 at 4:55 AM, Laurent Pinchart wrote: Hello everybody, First of all, I would like to thank all the attendees for their participation in the mini-summit that helped make the meeting a success. snip

[PATCH] drm: exynos: Fix fb_videomode - drm_mode_modeinfo conversion

2012-03-08 Thread Laurent Pinchart
the fb_videomode - drm_mode_modeinfo conversion functions accordingly. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) While trying to understand how

Re: [PATCH] drm: exynos: Fix fb_videomode - drm_mode_modeinfo conversion

2012-03-08 Thread Laurent Pinchart
Hi Joonyoung, On Thursday 08 March 2012 22:05:50 Joonyoung Shim wrote: On 03/08/2012 08:34 PM, Laurent Pinchart wrote: The fb_videomode structure stores the front porch and back porch in the right_margin and left_margin fields respectively. right_margin should thus be computed

Re: [PATCH] drm: exynos: Fix fb_videomode - drm_mode_modeinfo conversion

2012-03-08 Thread Laurent Pinchart
:-) -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFCv2 PATCH 1/9] v4l: vb2: fixes for DMABUF support

2012-03-22 Thread Laurent Pinchart
Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Tested-by: Laurent Pinchart laurent.pinch...@ideasonboard.com I suppose this will be squashed with Sumit's [RFCv1 2/4] v4l:vb2: add support for shared buffer (dma_buf) patch. --- drivers/media/video

Re: [RFCv2 PATCH 2/9] v4l: vb2-dma-contig: update and code refactoring

2012-03-22 Thread Laurent Pinchart
to review. I've already split it according to the above (with the MMAP and USERPTR changes kept together as the original patch). I'll post the patches in reply to this mail, with my comments as further replies. -- Regards, Laurent Pinchart ___ dri-devel

[RFCv2 PATCH 2/9 - 1/4] v4l: vb2-dma-contig: Shorten vb2_dma_contig prefix to vb2_dc

2012-03-22 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 36 ++-- 1 files changed, 18 insertions(+), 18 deletions(-) Needless to say, feel free to modify authorship information for these patches based

[RFCv2 PATCH 2/9 - 2/4] v4l: vb2-dma-contig: Reorder functions

2012-03-22 Thread Laurent Pinchart
Group functions by buffer type. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/videobuf2-dma-contig.c | 94 --- 1 files changed, 56 insertions(+), 38 deletions(-) diff --git a/drivers/media/video/videobuf2-dma-contig.c b

[RFCv2 PATCH 2/9 - 3/4] v4l: vb2-dma-contig: Remove unneeded allocation context structure

2012-03-22 Thread Laurent Pinchart
vb2-dma-contig returns a vb2_dc_conf structure instance as the vb2 allocation context. That structure only stores a pointer to the physical device. Remove it and use the device pointer directly as the allocation context. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

[RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-22 Thread Laurent Pinchart
From: Tomasz Stanislawski t.stanisl...@samsung.com This patch combines updates and fixes to dma-contig allocator. Moreover the allocator code was refactored. The most important changes are: - functions were reordered - move compression of scatterlist to separete function - add support for

Re: [Linaro-mm-sig] [RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-22 Thread Laurent Pinchart
Hi Tomasz, Thanks for the patch. On Thursday 22 March 2012 11:02:23 Laurent Pinchart wrote: From: Tomasz Stanislawski t.stanisl...@samsung.com This patch combines updates and fixes to dma-contig allocator. Moreover the allocator code was refactored. The most important changes

Re: [RFCv2 PATCH 3/9] v4l: vb2: Add dma-contig allocator as dma_buf user

2012-03-22 Thread Laurent Pinchart
= vb2_dc_unmap_dmabuf, + .attach_dmabuf = vb2_dc_attach_dmabuf, + .detach_dmabuf = vb2_dc_detach_dmabuf, .num_users = vb2_dc_num_users, }; EXPORT_SYMBOL_GPL(vb2_dma_contig_memops); -- Regards, Laurent Pinchart ___ dri-devel mailing

Re: [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-22 Thread Laurent Pinchart
v4l2_create_buffers *b); -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFCv2 PATCH 5/9] v4l: vb2: add buffer exporting via dmabuf

2012-03-22 Thread Laurent Pinchart
, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFCv2 PATCH 7/9] v4l: vb2-dma-contig: change map/unmap behaviour

2012-03-22 Thread Laurent Pinchart
; } + dma_unmap_sg(buf-dev, sgt-sgl, sgt-nents, buf-dma_dir); dma_buf_unmap_attachment(buf-db_attach, sgt); buf-dma_addr = 0; -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-22 Thread Laurent Pinchart
Hi Subash, On Thursday 22 March 2012 19:27:01 Subash Patel wrote: On 03/22/2012 04:46 PM, Laurent Pinchart wrote: On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: [snip] diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index bb6844e..e71c787 100644

Re: [Linaro-mm-sig] [RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-22 Thread Laurent Pinchart
Hi Tomasz, On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski wrote: Hi Laurent, Thank you very much for your comments and question. They were very useful. You're welcome. Please refer to the comments below. On 03/22/2012 11:50 AM, Laurent Pinchart wrote: On Thursday 22 March 2012

Re: [Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-22 Thread Laurent Pinchart
On Thursday 22 March 2012 15:26:08 Daniel Vetter wrote: On Thu, Mar 22, 2012 at 03:07:18PM +0100, Laurent Pinchart wrote: + * Contains data used for exporting a video buffer as DMABUF file + * descriptor. Uses the same 'cookie' as mmap() syscall. All reserved fields + * must

Re: [Linaro-mm-sig] [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-22 Thread Laurent Pinchart
Hi Subash, On Thursday 22 March 2012 20:29:57 Subash Patel wrote: On 03/22/2012 07:37 PM, Laurent Pinchart wrote: On Thursday 22 March 2012 19:27:01 Subash Patel wrote: On 03/22/2012 04:46 PM, Laurent Pinchart wrote: On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: [snip

Re: [RFCv2 PATCH 4/9] v4l: add buffer exporting via dmabuf

2012-03-27 Thread Laurent Pinchart
Hi Tomasz, On Friday 23 March 2012 12:33:24 Tomasz Stanislawski wrote: On 03/22/2012 12:16 PM, Laurent Pinchart wrote: On Tuesday 13 March 2012 11:17:02 Tomasz Stanislawski wrote: [snip] + case VIDIOC_EXPBUF: + { + struct v4l2_exportbuffer *p = arg; + + if (!ops

Re: [RFCv2 PATCH 7/9] v4l: vb2-dma-contig: change map/unmap behaviour

2012-03-27 Thread Laurent Pinchart
Hi Daniel, On Thursday 22 March 2012 13:25:20 Daniel Vetter wrote: On Thu, Mar 22, 2012 at 13:15, Laurent Pinchart wrote: On Tuesday 13 March 2012 11:17:05 Tomasz Stanislawski wrote: The DMABUF documentation says that the map_dma_buf callback should return scatterlist that is mapped

Re: [Linaro-mm-sig] [RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-27 Thread Laurent Pinchart
Hi Tomasz, On Thursday 22 March 2012 16:58:27 Tomasz Stanislawski wrote: On 03/22/2012 03:42 PM, Laurent Pinchart wrote: On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski wrote: On 03/22/2012 11:50 AM, Laurent Pinchart wrote: On Thursday 22 March 2012 11:02:23 Laurent Pinchart wrote

Re: [Linaro-mm-sig] [RFCv2 PATCH 2/9 - 4/4] v4l: vb2-dma-contig: update and code refactoring

2012-03-27 Thread Laurent Pinchart
Hi Jerome, On Tuesday 27 March 2012 12:45:23 Jerome Glisse wrote: On Tue, Mar 27, 2012 at 11:01 AM, Laurent Pinchart wrote: On Thursday 22 March 2012 16:58:27 Tomasz Stanislawski wrote: On 03/22/2012 03:42 PM, Laurent Pinchart wrote: On Thursday 22 March 2012 14:36:33 Tomasz Stanislawski

Re: [RFCv2 PATCH 3/9] v4l: vb2: Add dma-contig allocator as dma_buf user

2012-03-28 Thread Laurent Pinchart
Hi Tomasz, On Monday 26 March 2012 17:53:09 Tomasz Stanislawski wrote: On 03/22/2012 12:04 PM, Laurent Pinchart wrote: On Tuesday 13 March 2012 11:17:01 Tomasz Stanislawski wrote: [snip] +static void vb2_dc_detach_dmabuf(void *mem_priv) +{ + struct vb2_dc_buf *buf = mem_priv

Re: [PATCH 02/11] Documentation: media: description of DMABUF importing in V4L2

2012-04-06 Thread Laurent Pinchart
/constant or s/ or/,/ +constantV4L2_MEMORY_DMABUF/constant or constantV4L2_MEMORY_USERPTR/constant./entry /row row -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org

Re: [PATCH 03/11] v4l: vb2: add support for shared buffer (dma_buf)

2012-04-06 Thread Laurent Pinchart
); + int (*map_dmabuf)(void *buf_priv); + void(*unmap_dmabuf)(void *buf_priv); + void*(*vaddr)(void *buf_priv); void*(*cookie)(void *buf_priv); -- Regards, Laurent Pinchart ___ dri

Re: [PATCH 09/11] v4l: vb2: add prepare/finish callbacks to allocators

2012-04-06 Thread Laurent Pinchart
*/ + for (plane = 0; plane vb-num_planes; ++plane) + call_memop(q, prepare, vb-planes[plane].mem_priv); + q-ops-buf_queue(vb); } -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-06 Thread Laurent Pinchart
); } /*/ -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 11/11] v4l: vb2: Add dma-contig allocator as dma_buf user

2012-04-06 Thread Laurent Pinchart
(vb2_dma_contig_memops); -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 02/14] Documentation: media: description of DMABUF importing in V4L2

2012-04-16 Thread Laurent Pinchart
/footnote/para /section + section id=dmabuf +titleStreaming I/O (DMA buffer importing)/title This section is very similar to the Streaming I/O (User Pointers) section. Do you think we should merge the two ? I could handle that if you want. -- Regards, Laurent Pinchart

Re: [PATCH v4 11/14] v4l: vb2-dma-contig: add support for dma_buf importing

2012-04-16 Thread Laurent Pinchart
the comment below, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com +static void vb2_dc_detach_dmabuf(void *mem_priv) +{ + struct vb2_dc_buf *buf = mem_priv; + + if (WARN_ON(buf-dma_addr)) + vb2_dc_unmap_dmabuf(buf); This should never happen, and would be a videobuf2

Re: [PATCH v4 09/14] v4l: vb2: add prepare/finish callbacks to allocators

2012-04-16 Thread Laurent Pinchart
Szyprowski m.szyprow...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 06/14] v4l: vb2-dma-contig: Remove unneeded allocation context structure

2012-04-16 Thread Laurent Pinchart
as the allocation context. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [PATCH v4 04/14] v4l: vb: remove warnings about MEMORY_DMABUF

2012-04-16 Thread Laurent Pinchart
Semwal sumit.sem...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v4 01/14] v4l: Add DMABUF as a memory type

2012-04-16 Thread Laurent Pinchart
...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem...@ti.com Signed-off-by: Sumit Semwal sumit.sem...@linaro.org Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart

Re: [PATCH v4 03/14] v4l: vb2: add support for shared buffer (dma_buf)

2012-04-16 Thread Laurent Pinchart
Stanislawski t.stanisl...@samsung.com [original work in the PoC for buffer sharing] Signed-off-by: Sumit Semwal sumit.sem...@ti.com Signed-off-by: Sumit Semwal sumit.sem...@linaro.org Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart

Re: [PATCH v4 12/14] v4l: vb2-dma-contig: change map/unmap behaviour for importers

2012-04-16 Thread Laurent Pinchart
in the Minutes from V4L2 update call thread and reply there to avoid scattering the discussion ? -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC 01/13] v4l: add buffer exporting via dmabuf

2012-04-17 Thread Laurent Pinchart
; + __u32 mem_offset; + __u32 flags; + __u32 reserved[12]; +}; -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC 03/13] v4l: vb2-dma-contig: let mmap method to use dma_mmap_coherent call

2012-04-17 Thread Laurent Pinchart
)buf-dma_addr, vma-vm_start, + buf-size); + + return 0; } /*/ -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org

Re: [RFC 05/13] v4l: vb2-dma-contig: add support for DMABUF exporting

2012-04-17 Thread Laurent Pinchart
, .vaddr = vb2_dc_vaddr, .mmap = vb2_dc_mmap, -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 08/11] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-17 Thread Laurent Pinchart
Hi Marek, On Tuesday 17 April 2012 13:25:56 Marek Szyprowski wrote: On Tuesday, April 17, 2012 2:41 AM Laurent Pinchart wrote: (snipped) +static struct vm_area_struct *vb2_dc_get_user_vma( + unsigned long start, unsigned long size) +{ + struct vm_area_struct *vma

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-04-21 Thread Laurent Pinchart
-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri

Re: [PATCH v4 02/14] Documentation: media: description of DMABUF importing in V4L2

2012-04-21 Thread Laurent Pinchart
as 'obsolete' feature and providing some emulation layer in libv4l2 for legacy applications. Sure. -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] scatterlist: add sg_alloc_table_by_pages function

2012-04-21 Thread Laurent Pinchart
dma_map_sg. The code is based on the patch 'v4l: vb2-dma-contig: add support for scatterlist in userptr mode' and hints from Laurent Pinchart. The patch looks good to me. Just a small comment, what do you think about naming the function sg_alloc_table_from_pages instead of sg_table_alloc_by_pages

Re: [RFC 05/13] v4l: vb2-dma-contig: add support for DMABUF exporting

2012-05-07 Thread Laurent Pinchart
Hi Tomasz, Sorry for the late reply, this one slipped through the cracks. On Thursday 19 April 2012 12:42:12 Tomasz Stanislawski wrote: On 04/17/2012 04:08 PM, Laurent Pinchart wrote: On Tuesday 10 April 2012 15:10:39 Tomasz Stanislawski wrote: This patch adds support for exporting a dma

Re: [PATCHv5 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode

2012-05-08 Thread Laurent Pinchart
; + cur_page = j; + } + + return sgt; +} -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-08 Thread Laurent Pinchart
using dma_map_sg. The code is based on the patch 'v4l: vb2-dma-contig: add support for scatterlist in userptr mode' and hints from Laurent Pinchart. Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Laurent Pinchart

[PATCH] drm: gma500: Kill the GEM glue layer

2012-05-16 Thread Laurent Pinchart
The private gem_create_mmap_offset() function is now implemented in the DRM core as drm_gem_create_mmap_offset(). Use it and kill the private copy. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/gma500/Makefile |2 +- drivers/gpu/drm/gma500/gem.c

[PATCH 0/4] Miscellaneous Exynos DRM patches

2012-05-16 Thread Laurent Pinchart
resulted in any wrong patch. Laurent Pinchart (4): drm: exynos: DRIVER_BUS_PLATFORM is not a driver feature drm: exynos: Remove dummy encoder get_crtc operation implementation drm: exynos: Don't cast GEM object to Exynos GEM object when not needed drm: exynos: Keep a reference to frame

[PATCH 1/4] drm: exynos: DRIVER_BUS_PLATFORM is not a driver feature

2012-05-16 Thread Laurent Pinchart
DRIVER_BUS_PLATFORM is a bus type used internally in the DRM core, not a flag for the drm_driver::driver_features field. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions

[PATCH 3/4] drm: exynos: Don't cast GEM object to Exynos GEM object when not needed

2012-05-16 Thread Laurent Pinchart
The exynos_drm_gem_dumb_map_offset() doesn't need to access any Exynos-specific GEM object fields, don't cast the GEM object. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/exynos/exynos_drm_gem.c |9 +++-- 1 files changed, 3 insertions(+), 6

[PATCH 2/4] drm: exynos: Remove dummy encoder get_crtc operation implementation

2012-05-16 Thread Laurent Pinchart
. As the operation is not mandatory, don't implement it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/exynos/exynos_drm_encoder.c |7 --- 1 files changed, 0 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b

[PATCH 4/4] drm: exynos: Keep a reference to frame buffer GEM objects

2012-05-16 Thread Laurent Pinchart
GEM objects used by frame buffers must be referenced for the whole life of the frame buffer. Release the references in the frame buffer destructor instead of its constructor. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 19

Re: [PATCH 2/4] drm: exynos: Remove dummy encoder get_crtc operation implementation

2012-05-17 Thread Laurent Pinchart
Hi Inki, On Thursday 17 May 2012 17:21:46 Inki Dae wrote: On Thursday, May 17, 2012 12:09 AM Laurent Pinchart wrote: The encoder get_crtc operation is called to retrieve a pointer to the CRTC the encoder is currenctly connected to, right after setting the encoder::crtc field to the new

[PATCH/RFC 0/6] Miscellaneous DRM fixes and cleanups

2012-05-17 Thread Laurent Pinchart
Hello, While studying the DRM core I came across a couple of issues or strange constructs. Here are 6 patches that try to fix them. Criticism is as usual welcome. Please bear with my lack of experience with the DRM core :-) Laurent Pinchart (6): drm: Delete the vblank timer synchronously

[PATCH/RFC 1/6] drm: Delete the vblank timer synchronously at cleanup time

2012-05-17 Thread Laurent Pinchart
A race condition exists in drm_vblank_cleanup() if the vblank disable timer callback runs after freeing the memory that its callback function tries to access. Fix this by deleting the timer synchronously. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm

[PATCH/RFC 3/6] drm: Don't initialize local ret variable when not needed

2012-05-17 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/drm_crtc.c| 12 ++-- drivers/gpu/drm/drm_crtc_helper.c |2 +- drivers/gpu/drm/drm_edid_load.c |8 drivers/gpu/drm/drm_fb_helper.c |5 + drivers/gpu/drm/drm_gem.c

[PATCH/RFC 2/6] drm: Miscellaneous typo fixes and documentation updates

2012-05-17 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/drm_crtc.c|2 +- drivers/gpu/drm/drm_sysfs.c |8 include/drm/drmP.h| 10 +- include/drm/drm_crtc.h| 21 +++-- include/drm/drm_crtc_helper.h

[PATCH/RFC 4/6] drm: Constify gem_vm_ops pointer

2012-05-17 Thread Laurent Pinchart
The GEM vm operations structure is passed to the VM core that stores it in a const field. There vm operations structures can thus be const in DRM as well. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Inki Dae inki@samsung.com Cc: Alan Cox a...@linux.intel.com Cc

[PATCH/RFC 5/6] drm: Constify drm_mode_config_funcs pointer

2012-05-17 Thread Laurent Pinchart
The DRM mode config functions structure declared by drivers and pointed to by the drm_mode_config funcs field is never modified. Make it a const pointer. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Inki Dae inki@samsung.com Cc: Alan Cox a...@linux.intel.com Cc

[PATCH/RFC 6/6] drm: Make the CRTC gamma_set operation optional

2012-05-17 Thread Laurent Pinchart
Drivers for hardware without gamma support should not be forced to implement a no-op gamma set operation. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Rob Clark rob.cl...@linaro.org --- drivers/gpu/drm/drm_crtc.c |5 + drivers/gpu/drm/drm_fb_helper.c

Re: [PATCHv6 01/13] v4l: Add DMABUF as a memory type

2012-05-28 Thread Laurent Pinchart
Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/v4l2-ioctl.c |1 + include/linux/videodev2.h|7 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/media/video/v4l2-ioctl.c b/drivers/media/video/v4l2-ioctl.c index 91be4e8

Re: [PATCHv6 02/13] Documentation: media: description of DMABUF importing in V4L2

2012-05-28 Thread Laurent Pinchart
/constant or constantV4L2_MEMORY_USERPTR/constant. See xref linkend=v4l2-memory/. /entry like in v5 ? -- Regards, Laurent Pinchart ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCHv6 00/13] Integration of videobuf2 with dmabuf

2012-05-28 Thread Laurent Pinchart
=42968 [2] https://lkml.org/lkml/2011/12/26/29 [3] http://thread.gmane.org/gmane.linux.drivers.video-input-infrastructure/3635 4/focus=36355 [4] http://thread.gmane.org/gmane.linux.kernel.cross-arch/12819 Laurent Pinchart (2): v4l: vb2-dma-contig: Shorten vb2_dma_contig prefix to vb2_dc

[PATCH/RFC] drm: Disallow DRM_IOCTL_MODESET_CTL for KMS drivers

2012-05-29 Thread Laurent Pinchart
DRM_IOCTL_MODESET_CTL must only be used for UMS drivers. Make it a no-op for KMS drivers. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/drm_irq.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) My understanding of the DRM framework tells me

[RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-29 Thread Laurent Pinchart
The passed mode must not be modified by the operation, make it const. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- This will break the i915 driver, as it modifies mode-clock in intel_dp_mode_fixup(), hence the RFC state. Is this incorrect behaviour from the i915 driver

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
Hi Daniel, On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: The passed mode must not be modified by the operation, make it const. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Acked-by: Daniel

Re: [RFC/PATCH] drm: Make the .mode_fixup() operations mode argument a const pointer

2012-05-30 Thread Laurent Pinchart
Hi Daniel, On Wednesday 30 May 2012 12:02:19 Daniel Vetter wrote: On Wed, May 30, 2012 at 11:24:50AM +0200, Laurent Pinchart wrote: On Wednesday 30 May 2012 11:18:56 Daniel Vetter wrote: On Wed, May 30, 2012 at 01:01:08AM +0200, Laurent Pinchart wrote: The passed mode must

[PATCH 0/4] Renesas SH Mobile DRM driver

2012-05-30 Thread Laurent Pinchart
driver I'm pretty sure I've made many mistakes. Review will as usual be very appreciated. I've modified the modetest application from the libdrm repository to test this driver, I will submit patches for it right after cleaning them up. Laurent Pinchart (4): fbdev: sh_mobile_meram: Add MERAM

[PATCH 1/4] fbdev: sh_mobile_meram: Add MERAM operations wrappers

2012-05-30 Thread Laurent Pinchart
Remove direct dependency on the MERAM driver implementation by introducing inline wrappers for MERAM operations. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/video/sh_mobile_meram.c | 24 include/video/sh_mobile_meram.h | 28

[PATCH 2/4] fbdev: sh_mobile_lcdc: Use MERAM operations wrappers

2012-05-30 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/video/sh_mobile_lcdcfb.c | 18 +++--- 1 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/video/sh_mobile_lcdcfb.c b/drivers/video/sh_mobile_lcdcfb.c index 7a0b301..671685d 100644

[PATCH 3/4] drm: Add NV24 and NV42 pixel formats

2012-05-30 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/drm/drm_fourcc.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index bdf0152..fac7235 100644 --- a/include/drm/drm_fourcc.h +++ b/include

Re: [PATCH 3/4] drm: Add NV24 and NV42 pixel formats

2012-05-30 Thread Laurent Pinchart
Hi Ville, Thank you for the review. On Wednesday 30 May 2012 16:09:25 Ville Syrjälä wrote: On Wed, May 30, 2012 at 02:32:58PM +0200, Laurent Pinchart wrote: Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/drm/drm_fourcc.h |2 ++ 1 files changed, 2

  1   2   3   4   5   6   7   8   9   10   >