We certainly never used to take 'device ID' or
> > 'version' attributes. I guess something must have changed.
>
> I will try to provide patches for code and bindings rework this week.
Wonderful.. Thanks Arnaud.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
->clks[i]);
> > +err:
> > + rproc_put(rproc);
> > + return ERR_PTR(err);
> > +}
> > +EXPORT_SYMBOL(st_slim_rproc_alloc);
> > +
> > +/**
> > + * st_slim_rproc_put() - put slim rproc resources
> > + * @slim_rproc: Pointer to the st_slim_rproc struct
> > + *
> > + * Function for calling respective _put() functions on slim_rproc
> > resources.
> > + *
> > + */
> > +void st_slim_rproc_put(struct st_slim_rproc *slim_rproc)
> > +{
> > + int clk;
> > +
> > + if (!slim_rproc)
> > + return;
> > +
> > + slim_clk_disable(slim_rproc);
> > +
> > + for (clk = 0; clk < ST_SLIM_MAX_CLK && slim_rproc->clks[clk]; clk++)
> > + clk_put(slim_rproc->clks[clk]);
> > +
> > + rproc_del(slim_rproc->rproc);
> > + rproc_put(slim_rproc->rproc);
> > +}
> > +EXPORT_SYMBOL(st_slim_rproc_put);
> > +
> > +MODULE_AUTHOR("Peter Griffin ");
> > +MODULE_DESCRIPTION("STMicroelectronics SLIM core rproc driver");
> > +MODULE_LICENSE("GPL v2");
> > diff --git a/include/linux/remoteproc/st_slim_rproc.h
> > b/include/linux/remoteproc/st_slim_rproc.h
> > new file mode 100644
> > index 000..416
> > --- /dev/null
> > +++ b/include/linux/remoteproc/st_slim_rproc.h
> > @@ -0,0 +1,58 @@
> > +/*
> > + * SLIM core rproc driver header
> > + *
> > + * Copyright (C) 2016 STMicroelectronics
> > + *
> > + * Author: Peter Griffin
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License as published by
> > + * the Free Software Foundation; either version 2 of the License, or
> > + * (at your option) any later version.
> > + */
> > +#ifndef _ST_REMOTEPROC_SLIM_H
> > +#define _ST_REMOTEPROC_SLIM_H
> > +
> > +#define ST_SLIM_MEM_MAX 2
> > +#define ST_SLIM_MAX_CLK 4
> > +
> > +enum {
> > + ST_SLIM_DMEM,
> > + ST_SLIM_IMEM,
> > +};
> > +
> > +/**
> > + * struct st_slim_mem - slim internal memory structure
> > + * @cpu_addr: MPU virtual address of the memory region
> > + * @bus_addr: Bus address used to access the memory region
> > + * @size: Size of the memory region
> > + */
> > +struct st_slim_mem {
> > + void __iomem *cpu_addr;
> > + phys_addr_t bus_addr;
> > + size_t size;
> > +};
> > +
> > +/**
> > + * struct st_slim_rproc - SLIM slim core
> > + * @rproc: rproc handle
> > + * @mem: slim memory information
> > + * @slimcore: slim slimcore regs
> > + * @peri: slim peripheral regs
> > + * @clks: slim clocks
> > + */
> > +struct st_slim_rproc {
> > + struct rproc *rproc;
> > + struct st_slim_mem mem[ST_SLIM_MEM_MAX];
> > + void __iomem *slimcore;
> > + void __iomem *peri;
> > +
> > + /* st_slim_rproc private */
> > + struct clk *clks[ST_SLIM_MAX_CLK];
> > +};
> > +
> > +struct st_slim_rproc *st_slim_rproc_alloc(struct platform_device *pdev,
> > + char *fw_name);
> > +void st_slim_rproc_put(struct st_slim_rproc *slim_rproc);
> > +
> > +#endif
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Since 0b52297f228 ("reset: Add support for shared reset controls") the
new Reset API now demands consumers choose either an *_exclusive or
a *_shared line when requesting reset lines.
Signed-off-by: Lee Jones
---
drivers/gpu/drm/sti/sti_compositor.c | 4 ++--
1 file changed, 2 insert
On Fri, 22 Jul 2016, Sean Paul wrote:
> On Fri, Jul 22, 2016 at 3:22 AM, Lee Jones wrote:
> > Since 0b52297f228 ("reset: Add support for shared reset controls") the
> > new Reset API now demands consumers choose either an *_exclusive or
> > a *_shared l
nformitive WARN(). It implies that one or
more used reset lines are in fact shared. This is why we're using the
*_shared variant.
Signed-off-by: Lee Jones
---
drivers/gpu/drm/sti/sti_compositor.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_compo
On Mon, 25 Jul 2016, Peter Griffin wrote:
> On Mon, 25 Jul 2016, Lee Jones wrote:
>
> > Since 0b52297f228 ("reset: Add support for shared reset controls") the
> > new Reset API now demands consumers choose either an *_exclusive or a
> > *_share
On Fri, 26 Aug 2016, Peter Griffin wrote:
> Use tabs instead of spaces.
>
> Signed-off-by: Peter Griffin
> ---
> drivers/gpu/drm/virtio/Kconfig | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
For my own reference:
Acked-by: Lee Jones
> diff --git a/d
works is
usually helpful here.
> Signed-off-by: Peter Griffin
> ---
> drivers/gpu/drm/virtio/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/Kconfig b/drivers/gpu/drm/virtio/Kconfig
> index e1afc3d..90357d9
by: Peter Griffin
> ---
> arch/arm/boot/dts/stihxxx-b2120.dtsi | 45
>
> 1 file changed, 45 insertions(+)
Acked-by: Lee Jones
> diff --git a/arch/arm/boot/dts/stihxxx-b2120.dtsi
> b/arch/arm/boot/dts/stihxxx-b2120.dtsi
> index 722c
On Tue, 30 Aug 2016, Lee Jones wrote:
> On Fri, 26 Aug 2016, Peter Griffin wrote:
>
> > Use tabs instead of spaces.
> >
> > Signed-off-by: Peter Griffin
> > ---
> > drivers/gpu/drm/virtio/Kconfig | 6 +++---
> > 1 file changed, 3 insertions(+)
reader";
> + status = "disabled";
> + #sound-dai-cells = <0>;
> + st,syscfg = <_core>;
> + reg = <0x8D84000 0x158>;
> + interrupts = ;
> +
compatible = "st,sti-uni-player";
> + status = "disabled";
> + #sound-dai-cells = <0>;
> + st,syscfg = <_core>;
> + clocks = <_s_d0_flexgen CLK_SPDIFF>;
> + assigned-cl
On Tue, 30 Aug 2016, Lee Jones wrote:
> On Fri, 26 Aug 2016, Peter Griffin wrote:
>
> > This patch adds the DT nodes for the uniperif player
> > IP blocks found on STiH407 family silicon.
> >
> > Signed-off-by: Arnaud Pouliquen
> > Signed-off-by: Peter Gri
On Fri, 26 Aug 2016, Peter Griffin wrote:
> This patch adds the dt node for the internal audio
> codec IP.
>
> Signed-off-by: Arnaud Pouliquen
> Signed-off-by: Peter Griffin
> ---
> arch/arm/boot/dts/stih407-family.dtsi | 7 +++
> 1 file changed, 7 insertions
le changed, 8 insertions(+)
Acked-by: Lee Jones
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index 537db7e..598dbab 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/sti
+++
> 1 file changed, 24 insertions(+)
Acked-by: Lee Jones
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index 0fb5c8a..537db7e 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/sti
+++
> 1 file changed, 23 insertions(+)
Acked-by: Lee Jones
> diff --git a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> b/arch/arm/boot/dts/stih407-pinctrl.dtsi
> index a538ae5..0fb5c8a 100644
> --- a/arch/arm/boot/dts/stih407-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/sti
ouliquen at st.com
> Cc: broonie at kernel.org
> ---
> arch/arm/configs/multi_v7_defconfig | 3 +++
> 1 file changed, 3 insertions(+)
Acked-by: Lee Jones
> diff --git a/arch/arm/configs/multi_v7_defconfig
> b/arch/arm/configs/multi_v7_defconfig
> index 998578a..
52 insertions(+)
Acked-by: Lee Jones
> diff --git a/arch/arm/boot/dts/stih407-family.dtsi
> b/arch/arm/boot/dts/stih407-family.dtsi
> index d294e82..45cab30 100644
> --- a/arch/arm/boot/dts/stih407-family.dtsi
> +++ b/arch/arm/boot/dts/stih407-family.dtsi
> @@ -821,5 +821,57
On Fri, 26 Aug 2016, Peter Griffin wrote:
> This patch adds the slim core rproc driver to the STi section
> of the MAINTAINERS file.
>
> Signed-off-by: Peter Griffin
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
Acked-by: Lee Jones
> diff --git a/M
rproc_del(slim_rproc->rproc);
> + rproc_put(slim_rproc->rproc);
> +}
> +EXPORT_SYMBOL(st_slim_rproc_put);
> +
> +MODULE_AUTHOR("Peter Griffin");
Email.
> +MODULE_DESCRIPTION("STMicroelectronics SLIM rproc driver");
Now it's "SLIM"? Make up your mind
On Tue, 30 Aug 2016, Peter Griffin wrote:
> On Tue, 30 Aug 2016, Lee Jones wrote:
> > On Fri, 26 Aug 2016, Peter Griffin wrote:
> >
> > > slim core is used as a basis for many IPs in the STi
> > > chipsets such as fdma and demux. To avoid duplicating
> >
On Tue, 30 Aug 2016, Peter Griffin wrote:
> Thanks for reviewing and your very valuable feedback.
> On Tue, 30 Aug 2016, Lee Jones wrote:
> > On Fri, 26 Aug 2016, Peter Griffin wrote:
> >
> > > This patch adds the DT node for the uniperif reader
> > > IP b
pwm_disable(pb->pwm);
>
> if (pb->enable_gpio)
> - gpiod_set_value(pb->enable_gpio, 0);
> + gpiod_set_value_cansleep(pb->enable_gpio, 0);
>
> regulator_disable(pb->power_supply);
> pb->enabled = false;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
<->
> + *
> + * ///| | ///|
> + * /// | | /////// |
> + * /// |...|/// |
> + *0__
_LIST_HEAD(_dev_list);
> >>mutex_init(_dev_list_mutex);
> >> + BLOCKING_INIT_NOTIFIER_HEAD(_notifier);
> >> +
> >>return 0;
> >> }
> >>
> >> diff --git a/include/linux/backlight.h b/include/linux/backlight.h
> >>
_driver = {
> + .probe = atmel_hlcdc_probe,
> + .remove = atmel_hlcdc_remove,
> + .driver = {
> + .name = "atmel-hlcdc",
> + .owner = THIS_MODULE,
Remove this line, it's not required.
> + .of_match_table = atmel_hlcdc_m
vers over to use the new function.
>
> Once all of those are merged, remove the old function.
>
> That way there are no "flag days" needed, and everyone is happy you
> don't send out emails with 40+ people in the To: and Cc: lines :)
+9
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
On Sun, 01 Jun 2014, Rafael J. Wysocki wrote:
> On Tuesday, May 27, 2014 10:20:33 AM Lee Jones wrote:
> > > On 05/26/2014 01:03 PM, Rafael J. Wysocki wrote:
> > > > On Monday, May 26, 2014 12:03:43 PM Jingoo Han wrote:
> > > >> On Thursday
space after '#define'.
> +#define ATMEL_HLCDC_EN 0x20
> +#define ATMEL_HLCDC_DIS 0x24
> +#define ATMEL_HLCDC_SR 0x28
> +#define ATMEL_HLCDC_IER 0x2c
> +#define ATMEL_HLCDC_IDR 0x30
> +#de
On Mon, 16 Jun 2014, Boris BREZILLON wrote:
> On 16/06/2014 14:50, Lee Jones wrote:
> >> The HLCDC IP available on some Atmel SoCs (i.e. at91sam9n12, at91sam9x5
> >> family or sama5d3 family) exposes 2 subdevices:
> >> - a display controller (controlled by a
> On 05/26/2014 01:03 PM, Rafael J. Wysocki wrote:
> > On Monday, May 26, 2014 12:03:43 PM Jingoo Han wrote:
> >> On Thursday, May 22, 2014 6:02 PM, Lee Jones wrote:
> >>> On Thursday, May 22, 2014 5:45 PM, Hans de Goede wrote:
> >>>> On Thursday,
by Daniel.
Signed-off-by: Lee Jones
---
drivers/gpu/drm/exynos/exynos_ddc.c | 63
drivers/gpu/drm/exynos/exynos_hdmi.h| 23
drivers/gpu/drm/exynos/exynos_hdmiphy.c | 65 -
3 files changed, 151 deletions(-)
delete
le changed, 23 deletions(-)
> delete mode 100644 drivers/gpu/drm/exynos/exynos_hdmi.h
https://lkml.org/lkml/2014/5/29/810
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
> > 1 file changed, 23 deletions(-)
> > delete mode 100644 drivers/gpu/drm/exynos/exynos_hdmi.h
>
> https://lkml.org/lkml/2014/5/29/810
Oh, I see.
Acked-by: Lee Jones
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
leij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Signed-off-by: Shobhit Kumar
> ---
> drivers/mfd/intel_soc_pmic_core.c | 12
> 1 file changed, 12 insertions(+)
How do you expect this set to be managed?
Acked-by: Lee Jones
> diff --git a/drivers/
regmap_irq_get_domain(pmic->irq_chip_data));
> @@ -104,6 +118,9 @@ static int intel_soc_pmic_i2c_remove(struct i2c_client
> *i2c)
>
> regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data);
>
> + /* Remove lookup table for Panel Control from the
hanged, 17 insertions(+)
I have no idea what this stuff is, but it looks plausible.
For my own reference:
Acked-by: Lee Jones
> diff --git a/drivers/mfd/intel_soc_pmic_core.c
> b/drivers/mfd/intel_soc_pmic_core.c
> index 7b50b6b..f3d918e 100644
> --- a/drivers/mfd/intel_soc_pmic_co
1 file changed, 3 insertions(+)
For my own reference:
Acked-by: Lee Jones
> diff --git a/drivers/mfd/intel_soc_pmic_crc.c
> b/drivers/mfd/intel_soc_pmic_crc.c
> index 4cc1b32..8839e25 100644
> --- a/drivers/mfd/intel_soc_pmic_crc.c
> +++ b/drivers/mfd/intel_soc_pmic_crc.c
| 85 ++
> 5 files changed, 265 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt
> create mode 100644 drivers/mfd/atmel-hlcdc.c
> create mode 100644 include/linux/mfd/atmel-hlcdc.h
>
--
Lee Jones
Linaro
and several clocks (those connected
> to this hardware block) to its subdevices.
>
> This way concurrent accesses to the iomem range are handled by the regmap
> framework, and each subdevice can safely access HLCDC registers.
>
> Signed-off-by: Boris Brezillon
> Acked-by:
#address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> +
> + hlcdc_panel_output: endpoint at 0 {
> + reg = <0>;
> + remote-endpoint = &
On Tue, 07 Oct 2014, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 10:59:32AM +0100, Lee Jones wrote:
> > On Tue, 07 Oct 2014, Thierry Reding wrote:
> >
> > > On Tue, Oct 07, 2014 at 10:44:27AM +0100, Lee Jones wrote:
> > > > On Mon
On Tue, 07 Oct 2014, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 10:44:27AM +0100, Lee Jones wrote:
> > On Mon, 06 Oct 2014, Boris Brezillon wrote:
> >
> > > The HLCDC IP available on some Atmel SoCs (i.e. at91sam9n12, at91sam9x5
> > > family or sam
On Tue, 07 Oct 2014, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 11:17:43AM +0100, Lee Jones wrote:
> > On Tue, 07 Oct 2014, Thierry Reding wrote:
> >
> > > On Tue, Oct 07, 2014 at 10:59:32AM +0100, Lee Jones wrote:
> > > > On Tue, 07 Oct 2014, Thierry Red
On Tue, 07 Oct 2014, Boris Brezillon wrote:
> On Tue, 7 Oct 2014 12:38:14 +0100
> Lee Jones wrote:
>
> > On Tue, 07 Oct 2014, Thierry Reding wrote:
> >
> > > On Tue, Oct 07, 2014 at 11:17:43AM +0100, Lee Jones wrote:
> > > > On Tue, 07 Oct 2014, Thier
On Tue, 07 Oct 2014, Lee Jones wrote:
> On Tue, 07 Oct 2014, Boris Brezillon wrote:
>
> > On Tue, 7 Oct 2014 12:38:14 +0100
> > Lee Jones wrote:
> >
> > > On Tue, 07 Oct 2014, Thierry Reding wrote:
> > >
> > > > On Tue, Oct 07, 2014 at 1
On Tue, 07 Oct 2014, Thierry Reding wrote:
> On Tue, Oct 07, 2014 at 01:41:12PM +0200, Boris Brezillon wrote:
> > On Tue, 7 Oct 2014 12:38:14 +0100
> > Lee Jones wrote:
> >
> > > On Tue, 07 Oct 2014, Thierry Reding wrote:
> > >
> > > > On Tue
>
> >> I don't mind either way.
> >
> > I'll go with either of the two suggestions above.
>
> So, Lee and Thierry, you can both take your part in your respective
> trees with the change (1) described above and with my:
>
> Acked-by: Nicolas Ferre
Works for
Add a lookup
> > >entry for the same to be used by the consumer (Intel GFX)
> > >
> > >v2: Remove the lookup table on driver unload (Thierry)
> > >
> > >v3: Correct the subject line (Lee jones)
> >
> > This part should only describe what this is ab
inus Walleij
> Cc: Alexandre Courbot
> Cc: Thierry Reding
> Reviewed-by: Alexandre Courbot
> Reviewed-by: Linus Walleij
> Tested-by: Ville Syrjälä
> Signed-off-by: Shobhit Kumar
> ---
> v2: Ccing maintainers
> v3: Correct the subject line (Lee jones)
Acked-by: Lee
result in multiple entries. Provide
> an option to remove the lookup table on driver unload
>
> v2: Ccing maintainers
> v3: Correct the subject line (Lee jones)
Change logs should go underneth the '---' and above the diffstat found
below.
> Cc: Samuel Ortiz
> Cc: Linus Walleij
On Tue, 05 May 2015, Shobhit Kumar wrote:
> On 04/29/2015 07:54 PM, Lee Jones wrote:
> > On Wed, 29 Apr 2015, Shobhit Kumar wrote:
> >
> >> On some BYT PLatform the PWM is controlled using CRC PMIC. Add a lookup
> >> entry for the same to be used by the consumer
On Tue, 05 May 2015, Daniel Vetter wrote:
> On Tue, May 05, 2015 at 11:45:05AM +0100, Lee Jones wrote:
> > This is not how we submit subsequent patch-sets.
>
> It is unfortunately how we handle patches on dri-devel to be
> able to cope with massive mail load. If everyone who su
changed, 7 insertions(+), 5 deletions(-)
Please ensure this patch makes its way into v4.12. Without it, large
monitors will be artificially clipped, which negatively affects the
user experience.
Acked-by: Lee Jones <lee.jo...@linaro.org>
Tested-by: Lee Jones <lee.jo...@linaro.org&
de/linux/mfd/as3711.h | 4 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Johan Hovold <jo...@kernel.org>
> ---
> drivers/video/backlight/tps65217_bl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook |
.org>
> ---
> drivers/video/backlight/as3711_bl.c | 33 +++--
> 1 file changed, 23 insertions(+), 10 deletions(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_
d-off-by: Johan Hovold <jo...@kernel.org>
> ---
> drivers/video/backlight/max8925_bl.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
ivers/video/backlight/apple_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_
On Mon, 20 Nov 2017, Johan Hovold wrote:
> On Wed, Nov 15, 2017 at 03:39:09PM +0100, Johan Hovold wrote:
> > On Wed, Nov 15, 2017 at 02:32:11PM +0000, Lee Jones wrote:
> > > On Wed, 15 Nov 2017, Johan Hovold wrote:
> > >
> > > > On Tue, Nov 14, 2017 at
n in the first place. ;-)
>
> Heh. Since I was touching those error paths, I at least wanted to record
> somehow there were further issues to be addressed. But feel free to drop
> the FIXMEs if you prefer.
In my experience FIXME's tend not to get addressed:
$ git grep -i fixme | wc -l
3,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg,
> u16 value)
> ret = spi_sync(spi, );
>
> spi_message_init();
> - len = 0;
> tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
> START_RW
y backlight fixes these days, huh? ;)
Ha! To be honest I think those patches are the only 4 -fixes I've
*ever* had for Backlight. :)
I have pulled them into the main branch, so they won't be forgotten
again. Sorry for the delay.
--
Lee Jones [李琼斯]
Linaro Services Technical
es in here.
> +} __packed;
How come these guys have kerneldoc headers?
> struct ec_response_get_next_event {
> uint8_t event_type;
> /* Followed by event data if any */
> union ec_response_get_next_data data;
> } __packed;
>
> +struct ec_response_get_next_even
> include/linux/mfd/cros_ec_commands.h | 81
>
> 1 file changed, 81 insertions(+)
For my own reference:
Acked-for-MFD-by: Lee Jones
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Lin
hes 1+2 can just go to the i915 tree. The i915 driver changes
> often,
> so going through that tree makes sense. The cec-notifier code is unlikely to
> change,
> and I am fine with that patch going through i915.
>
> > for media to merge the mfd branch + patch 7 ?
>
> Patc
On Mon, 25 Jun 2018, Matthias Brugger wrote:
>
>
> On 30/04/18 12:30, Lee Jones wrote:
> > On Fri, 27 Apr 2018, matthias@kernel.org wrote:
> >
> >> From: Matthias Brugger
> >>
> >> Add binding description for the mmsys mfd for some
On Mon, 25 Jun 2018, Matthias Brugger wrote:
> On 30/04/18 12:18, Lee Jones wrote:
> > On Fri, 27 Apr 2018, matthias@kernel.org wrote:
> >
> >> From: Matthias Brugger
> >>
> >> The MMSYS subsystem includes clocks and drm components.
> >>
On Mon, 18 Jun 2018, Neil Armstrong wrote:
> Hi Lee,
>
> On 18/06/2018 09:44, Lee Jones wrote:
> > On Fri, 01 Jun 2018, Neil Armstrong wrote:
> >
> >> Having a 16 byte mkbp event size makes it possible to send CEC
> >> messages from the EC to the AP dire
; backlight power interface.
> >
> > The backlight power interface itself is still a massive mess.
> >
> > Cc: Lee Jones <lee.jo...@linaro.org>
> > Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> > Cc: Jingoo Han <jingooh...@gmail.com>
> > Acked-by: Da
deset api simplified even the uapi to a
> simple bool. And there was never a valid technical reason to have the
> intermediate fbdev power states for backlights (those really only can
> be either off or on).
>
> Cleanup motivated by Meghana's questions about all this.
All appli
Greg, Thomas,
On Wed, 25 Apr 2018, Daniel Vetter wrote:
> Leaking driver internal tracking into the already massively confusing
> backlight power tracking is really confusing.
>
> Luckily we have already a drvdata structure, so fixing this is really
> easy.
>
>
I think you just want to use "simple-mfd" instead.
> +static const struct of_device_id of_match_mmsys[] = {
> + { .compatible = "mediatek,mt2701-mmsys",
> + .data = (void *) MMSYS_MT2701,
> + },
> + { /* sentinel */ },
> +};
> +
> +static
ion/devicetree/bindings/display/mediatek/mediatek,disp.txt
> +
> +Required properties:
> +- compatible: Should be one of:
> + - "mediatek,mt2701-mmsys", "syscon"
> + - "mediatek,mt8173-mmsys", "syscon"
> +- #clock-cells: Must be 1
&g
ntly merged into the DRM repo, OR they are
applied into an immutable branch in the DRM tree and I can pull that
in instead.
Don't really mind which.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_
gt; ---
> drivers/video/backlight/backlight.c | 43
> +
> include/linux/backlight.h | 19 ++++
> 2 files changed, 62 insertions(+)
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
__
ts (those really only can
> > be either off or on).
> >
> > Cleanup motivated by Meghana's questions about all this.
> >
> > Cc: Lee Jones <lee.jo...@linaro.org>
> > Cc: Daniel Thompson <daniel.thomp...@linaro.org>
> > Cc: Jingoo Han <j
On Mon, 29 Jan 2018, Sean Paul wrote:
> On Mon, Jan 29, 2018 at 4:11 AM, Lee Jones <lee.jo...@linaro.org> wrote:
> > On Fri, 26 Jan 2018, Randy Dunlap wrote:
> >
> >> On 01/26/2018 01:48 AM, Lee Jones wrote:
> >> > On Wed, 24 Jan 2018, Meghana Madhyastha w
On Fri, 26 Jan 2018, Randy Dunlap wrote:
> On 01/26/2018 01:48 AM, Lee Jones wrote:
> > On Wed, 24 Jan 2018, Meghana Madhyastha wrote:
> >
> >> Add of_find_backlight, a helper function which is a generic version
> >> of tinydrm_of_find_backlight that can
d-off-by: Robert Jarzmik <robert.jarz...@free.fr>
> Acked-by: Daniel Thompson <daniel.thomp...@linaro.org>
> ---
> Since v1: added 2 other panels
> Since v2: added Daniel's ack
> ---
> drivers/video/backlight/corgi_lcd.c | 2 +-
> drivers/video/backlight/tdo24m.c
to the HLCD one. This would have been easier to
> understand and use one SoC or another one from the AT91 product line
Yes, that is true. They are very similar drivers. Would it make
sense to use the same driver for both devices?
> Anyway, I'd wait for Boris' feedback for makin
access the registers.
> The mfd device also support the clock used by the
> LCDC IP + a bus clock that in some cases are required.
>
> The driver is based on the atmel-hlcdc driver.
>
> The Atmel SOC's are at91sam9261, at91sam9263 etc.
>
> Signed-off-by: Sam Ravnborg
> Cc: Le
On Fri, 24 Aug 2018, Boris Brezillon wrote:
> Hi Lee,
>
> On Wed, 15 Aug 2018 06:24:35 +0100
> Lee Jones wrote:
>
> > > +static const struct mfd_cell lcdc_cells[] = {
> > > + {
> > > + .name = "atmel-lcdc-pwm&quo
* between two points.
> + */
> if (data->max_brightness < 2) {
> dev_err(dev, "can't interpolate\n");
> return -EINVAL;
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source so
On Wed, 18 Jul 2018, Lee Jones wrote:
> On Mon, 16 Jul 2018, Daniel Thompson wrote:
>
> > Currently, if the DT does not define num-interpolated-steps then
> > num_steps is undefined and the interpolation code will deploy randomly.
> > Fix this.
> >
> > Fix
On Wed, 18 Jul 2018, Marcel Ziswiler wrote:
> On Wed, 2018-07-18 at 09:09 +0100, Lee Jones wrote:
> > On Mon, 16 Jul 2018, Daniel Thompson wrote:
> >
> > > Currently, if the DT does not define num-interpolated-steps then
> > > num_steps is undefined and t
On Wed, 18 Jul 2018, Daniel Thompson wrote:
> On Wed, Jul 18, 2018 at 02:08:53PM +0100, Lee Jones wrote:
> > > > > > No, then we are back to the initial issue of num_steps
> > > > > > potentially not
> > > > > > being initialised. We reall
On Wed, 18 Jul 2018, Daniel Thompson wrote:
> On Wed, Jul 18, 2018 at 04:55:44PM +0100, Lee Jones wrote:
> > On Wed, 18 Jul 2018, Daniel Thompson wrote:
> >
> > > On Wed, Jul 18, 2018 at 02:08:53PM +0100, Lee Jones wrote:
> > > > > > > > No, th
* the brightness-levels table, otherwise we can't
> + * interpolate between two points.
> + */
> if (data->max_brightness < 2) {
> dev_err(dev, "can't interpolate\n");
>
make other similar calls use same
>return code checking approach
> - Tidy up comment formatting and fix pre-existing grammar error
>
> drivers/video/backlight/pwm_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Once the 'Fixes:' line has been repaired
Linear interpolation between
> brightness-levels")
> Reported-by: Marcel Ziswiler
> Signed-off-by: Daniel Thompson
> Tested-by: Marcel Ziswiler
> Reviewed-by: Douglas Anderson
> Acked-by: Lee Jones
> ---
>
> Notes:
> v4:
> - Remove line break from Fix
On Wed, 18 Jul 2018, Marcel Ziswiler wrote:
> On Wed, 2018-07-18 at 11:12 +0100, Daniel Thompson wrote:
> > On Wed, Jul 18, 2018 at 10:53:35AM +0100, Lee Jones wrote:
> > > On Wed, 18 Jul 2018, Marcel Ziswiler wrote:
> > >
> > > > On Wed, 201
er the conversion is not needed.
>
> drivers/video/backlight/pwm_bl.c | 81 +-------
> 1 file changed, 42 insertions(+), 39 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro
On Thu, 05 Jul 2018, Matthias Brugger wrote:
> On 04/07/18 18:45, Lee Jones wrote:
> > On Wed, 04 Jul 2018, Matthias Brugger wrote:
> >> On 03/07/18 09:11, Lee Jones wrote:
> >>> On Mon, 25 Jun 2018, Matthias Brugger wrote:
> >>>> On 30/04/18 12:18,
On Wed, 04 Jul 2018, Daniel Vetter wrote:
> Hi Lee,
>
> On Wed, Jul 4, 2018 at 12:34 PM, Lee Jones wrote:
> > On Wed, 04 Jul 2018, Daniel Vetter wrote:
> >> On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote:
> >> > On Wed, 04 Jul 2018, Lee Jones w
s/mfd/cros_ec_dev.c | 16
> 1 file changed, 16 insertions(+)
For my own reference:
Acked-for-MFD-by: Lee Jones
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
YI, sending patches like this is not a good idea.
I'll clean it up for you this time, but in future please send patches
properly and place any additional comments you may have below the
'---' line.
> Cc: Jani Nikula
> Signed-off-by: Daniel Vetter
> Cc: Lee Jones
> Cc: Daniel Thompson
On Wed, 04 Jul 2018, Daniel Vetter wrote:
> On Wed, Jul 04, 2018 at 10:38:16AM +0100, Lee Jones wrote:
> > On Wed, 04 Jul 2018, Lee Jones wrote:
> >
> > > > Jani spotted this when reviewing my earlier patch to remove the driver
> > > > internal usage o
On Wed, 04 Jul 2018, Lee Jones wrote:
> > Jani spotted this when reviewing my earlier patch to remove the driver
> > internal usage of this field in
> >
> > commit 3cf91adaa594e8933af1727942ac560e5c7bc70e
> > Author: Daniel Vetter
> > Da
1 - 100 of 1645 matches
Mail list logo
