Re: linux-next: Tree for Mar 30

On Thu, 2017-03-30 at 16:55 +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20170329: > > Undropped tree: xen-tip > > The vfs tree gained a conflict against Linus' tree. > > The drm tree gained conflicts against the drm-intel-fixes tree. > > The mailbox tree lost its build failure.

[PATCH] drm/imx: imx-ldb: Accept drm_of_find_panel_or_bridge failure

boards. Link: https://lists.freedesktop.org/archives/dri-devel/2017-May/141233.html Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge") Signed-off-by: Leonard Crestez <leonard.cres...@nxp.com> --- This relies on drm_of_find_panel_or_bridge returning -ENO

[PATCH v2] drm/imx: imx-ldb: Accept drm_of_find_panel_or_bridge failure

. Link: https://lists.freedesktop.org/archives/dri-devel/2017-May/141233.html Fixes: ebc944613567 ("drm: convert drivers to use drm_of_find_panel_or_bridge") Signed-off-by: Leonard Crestez <leonard.cres...@nxp.com> --- This relies on drm_of_find_panel_or_bridge returning -ENO

Re: [PATCH v3 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

On Wed, Mar 22, 2017 at 5:01 PM, Philipp Zabel wrote: > On Wed, 2017-03-22 at 08:26 -0500, Rob Herring wrote: > > > > Similar to the previous commit, convert drivers open coding OF graph > > parsing to use drm_of_find_panel_or_bridge instead. > > > > This changes some

Re: [PATCH v2] drm/imx: imx-ldb: Accept drm_of_find_panel_or_bridge failure

On Wed, 2017-05-10 at 15:55 +0200, Philipp Zabel wrote: > On Wed, 2017-05-10 at 16:17 +0300, Leonard Crestez wrote: > > > > Not having an endpoint bound in DT should not cause a failure here, > > there are fallbacks. So explicitly accept a missing endpoint. > >

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

On Fri, 2018-06-15 at 16:47 -0300, Fabio Estevam wrote: > On Fri, Jun 15, 2018 at 4:43 PM, Leonard Crestez > wrote: > > The FBDEV driver uses the same name and both can't be registered at the > > same time. Fix this by renaming the drm driver to mxsfb-drm > > > >

[PATCH 2/3] fbdev: mxsfb: Return ENODEV on missing display node

When this driver encounters drm-style bindings it returns -ENOENT and this reports a probe error. Make it return -ENODEV to signal an explicit rejection instead. This allows peaceful coexistence between the DRM_MXSFB and FB_MXS config options. Signed-off-by: Leonard Crestez --- drivers/video

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

On Fri, 2018-06-15 at 23:36 +0200, Marek Vasut wrote: > On 06/15/2018 10:58 PM, Leonard Crestez wrote: > > On Fri, 2018-06-15 at 16:47 -0300, Fabio Estevam wrote: > > > On Fri, Jun 15, 2018 at 4:43 PM, Leonard Crestez > > > wrote: > > > > The FBDEV d

[PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

The FBDEV driver uses the same name and both can't be registered at the same time. Fix this by renaming the drm driver to mxsfb-drm Signed-off-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb

[PATCH 0/3] ARM: imx: Make DRM_MXSFB and FB_MXS coexist

NOENT when it fails to find the display node. This makes display on imx6sx-sdb "just work" with both styles of bindings. In order to test the old bindings I locally reverted commit 7caa59e0d40c ("ARM: dts: imx6sx-sdb: Convert from fbdev to drm bindings") Leonard Crestez (3):

[PATCH 3/3] ARM: imx_v6_v7_defconfig: Enable DRM_MXSFB

Multiple boards have drm-style bindings on imx lcdif nodes, enable the driver so that they work by default. Also enable DRM_PANEL_SEIKO_43WVF1G, it is one of the supported display attachments for imx development boards. Signed-off-by: Leonard Crestez --- arch/arm/configs/imx_v6_v7_defconfig

[RFC 2/2] ARM: dts: imx6sl: Convert gpc to new bindings

the newly-defined _disp domain from Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx6sl.dtsi | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) There are erratas regarding dispmix on 6sl so this might be wrong diff --git a/arch/arm/boot/dts/imx6sl.d

[PATCH 1/2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

ona and also calling it from mxsfb_crtc_mode_set_nofb. Also add fields to mxsfb_drv to keep track of enabled/suspended states. Signed-off-by: Robert Chiras Signed-off-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 38 +++- drivers/gpu/drm/mxsfb/mxsfb_drv.c |

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Thu, 2018-08-02 at 13:06 +0200, Stefan Agner wrote: > On 02.08.2018 12:17, Philipp Zabel wrote: > > On Tue, 2018-07-31 at 12:17 +, Leonard Crestez wrote: > > > On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > > > > On Tue, 2018-07-17 at 13:4

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > Adding lcdif nodes to a power domain currently does work, it results in > black/corrupted screens or hangs. While the driver does enable runtime > pm it does not deal correctly with the block being unpowered. > > Ensure p

Re: [PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Tue, 2018-07-31 at 13:54 +0200, Philipp Zabel wrote: > On Tue, 2018-07-17 at 13:48 +0300, Leonard Crestez wrote: > > Adding lcdif nodes to a power domain currently does work, it results in > > black/corrupted screens or hangs. While the driver does enable runtime > >

[PATCH v4 3/5] drm/mxsfb: Add pm_runtime calls to pipe_enable/disable

Adding lcdif nodes to a power domain currently results in black/corrupted screens or hangs because power is not correctly enabled when required. Ensure power is on when display is active by adding pm_runtime_get/put_sync to mxsfb_pipe_enable/disable. Signed-off-by: Leonard Crestez Reviewed

[PATCH v4 1/5] drm/mxsfb: Move axi clk enable/disable to crtc enable/disable

. Signed-off-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c index 0abe77675b76..e4fcbb65b969 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c

[PATCH v4 4/5] drm/mxsfb: Add PM_SLEEP support

Since power to the lcdif block can be lost on suspend implement PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore the current mode. Signed-off-by: Leonard Crestez Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 + 1 file changed

Re: [PATCH v3 4/4] drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

On Tue, 2018-08-07 at 21:01 +0200, Stefan Agner wrote: > On 06.08.2018 21:31, Leonard Crestez wrote: > > The lcdif block is only powered on when display is active so plane > > updates when not enabled are not valid. Writing to an unpowered IP block > > is mostly ignored but c

[PATCH v4 5/5] drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

ensure atomic_plane_update is only called while the crtc is active. This avoids having to keep track of "enabled" bits inside the mxsfb driver. This also requires handling the vblank event for disable from mxsfb_pipe_update. Signed-off-by: Leonard Crestez Suggested-by: Stefan Agner

[PATCH v4 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

AXI clk handling to allow setting fb in crtc_enable * No functional changes Last 3 patches are identical to v3 with review tags attached. Link to v3: https://lkml.org/lkml/2018/8/6/728 Leonard Crestez (5): drm/mxsfb: Move axi clk enable/disable to crtc enable/disable drm/mxsfb: Fix initial

[PATCH v4 2/5] drm/mxsfb: Fix initial corrupt frame when activating display

LCDIF will repeatedly display data from CUR_BUF and set CUR_BUF to NEXT_BUF when done. Since we are only ever writing to NEXT_BUF the display will show an initial corrupt frame. Fix by writing the FB paddr to both CUR_BUF and NEXT_BUF when activating the CRTC. Signed-off-by: Leonard Crestez

Re: [PATCH v4 1/5] drm/mxsfb: Move axi clk enable/disable to crtc enable/disable

On Wed, 2018-08-08 at 20:57 +0200, Stefan Agner wrote: > On 08.08.2018 18:08, Leonard Crestez wrote: > > The main axi clk is disabled at the end of mxsfb_crtc_mode_set_nofb and > > immediately reenabled in mxsfb_enable_controller. > > > > Avoid this by moving the handl

[PATCH v3 0/4] drm/mxsfb: Fix runtime PM for unpowering lcdif block

Adding lcdif nodes to a power domain currently does work, it results in black/corrupted screens or hangs. While the driver does enable runtime pm it does not deal correctly with the block being unpowered. Changes since v2: * Split into multiple commits. * Use #ifdef CONFIG_PM_SLEEP. * Switch

[PATCH v3 1/4] drm/mxsfb: Fix initial corrupt frame when activating display

LCDIF will repeatedly display data from CUR_BUF and set CUR_BUF to NEXT_BUF when done. Since we are only ever writing to NEXT_BUF the display will show an initial corrupt frame. Fix by writing the FB paddr to both CUR_BUF and NEXT_BUF when activating the CRTC. Signed-off-by: Leonard Crestez

[PATCH v3 4/4] drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

ensure atomic_plane_update is only called while the crtc is active. This avoids having to keep track of "enabled" bits inside the mxsfb driver. This also requires handling the vblank event for disable from mxsfb_pipe_update. Signed-off-by: Leonard Crestez Suggested-by: Stefan Agner --

[PATCH v3 3/4] drm/mxsfb: Add PM_SLEEP support

Since power to the lcdif block can be lost on suspend implement PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore the current mode. Signed-off-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 + 1 file changed, 21 insertions(+) diff

[PATCH v3 2/4] drm/mxsfb: Add pm_runtime calls to pipe_enable/disable

Adding lcdif nodes to a power domain currently results in black/corrupted screens or hangs because power is not correctly enabled when required. Ensure power is on when display is active by adding pm_runtime_get/put_sync to mxsfb_pipe_enable/disable. Signed-off-by: Leonard Crestez --- drivers

[RFC] clk: imx6: Mark imx_clk_mux as glitchy by default

is active. Ensuring outputs are gated prior to calling set_parent is up to the clk consumers. The effect of this patch is that drivers which perform unsafe operations which mostly work will receive errors instead, possibly breaking functionality. Signed-off-by: Leonard Crestez --

Re: [RFC] clk: imx6: Mark imx_clk_mux as glitchy by default

On Tue, 2018-08-21 at 19:42 -0300, Fabio Estevam wrote: > Hi Leonard, > > On Tue, Aug 21, 2018 at 4:34 PM, Leonard Crestez > wrote: > > > More concretely on 6qp-sdb blanking the display happens like this: > > * imx_ldb_encoder_disable switches ipu1_d

[RESEND 4/5] drm/mxsfb: Add PM_SLEEP support

Since power to the lcdif block can be lost on suspend implement PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore the current mode. Signed-off-by: Leonard Crestez Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 + 1 file changed

[RESEND 3/5] drm/mxsfb: Add pm_runtime calls to pipe_enable/disable

Adding lcdif nodes to a power domain currently results in black/corrupted screens or hangs because power is not correctly enabled when required. Ensure power is on when display is active by adding pm_runtime_get/put_sync to mxsfb_pipe_enable/disable. Signed-off-by: Leonard Crestez Reviewed

[RESEND 2/5] drm/mxsfb: Fix initial corrupt frame when activating display

LCDIF will repeatedly display data from CUR_BUF and set CUR_BUF to NEXT_BUF when done. Since we are only ever writing to NEXT_BUF the display will show an initial corrupt frame. Fix by writing the FB paddr to both CUR_BUF and NEXT_BUF when activating the CRTC. Signed-off-by: Leonard Crestez

[RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

this today because 4.19 rc1 was released. I'm not sure if this matters for DRM but in some areas unrelated series get lost during the merge window. Marek/Phillip: Is one of you going to pick up these patches? Link to v4: https://lkml.org/lkml/2018/8/8/573 Leonard Crestez (5): drm/mxsfb: Move axi clk

[RESEND 1/5] drm/mxsfb: Move axi clk enable/disable to crtc enable/disable

. Signed-off-by: Leonard Crestez Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c index 0abe77675b76..e4fcbb65b969 100644 --- a/drivers

[RESEND 5/5] drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

ensure atomic_plane_update is only called while the crtc is active. This avoids having to keep track of "enabled" bits inside the mxsfb driver. This also requires handling the vblank event for disable from mxsfb_pipe_disable. Signed-off-by: Leonard Crestez Suggested-by: Stefan Agner

Re: [PATCH] drm/imx: Remove unused field imx_drm_device.pipes

On Tue, 2018-07-17 at 15:21 +0200, Philipp Zabel wrote: > On Tue, 2018-07-17 at 15:11 +0300, Leonard Crestez wrote: > > This has been unused since commit 44b460cfe554 ("drm: imx: remove struct > > imx_drm_crtc and imx_drm_crtc_helper_funcs") > > > > Signed-

Re: [PATCH 1/2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Fri, 2018-07-13 at 12:57 +0200, Stefan Agner wrote: > On 05.06.2018 19:11, Leonard Crestez wrote: > > Adding imx6sl/sx lcdif nodes in a power domain currently does work, it > > results in black/corrupted screens or hangs. While the driver does > > enable runtime pm it do

[PATCH] drm/imx: Remove unused field imx_drm_device.pipes

This has been unused since commit 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs") Signed-off-by: Leonard Crestez --- drivers/gpu/drm/imx/imx-drm-core.c | 1 - 1 file changed, 1 deletion(-) Looking at the imx_drm_device struct it is only us

[PATCH v2] drm/mxsfb: Fix runtime PM for unpowering lcdif block

on unblank until a refresh. Fix this by not writing gem->paddr if the block is not enabled and instead delaying the write until the next mxsfb_crtc_mode_set_nofb call. At that point also update cur_buf to avoid an initial corrupt frame after resume. Signed-off-by: Leonard Crestez --- The purp

[PATCH v2] ARM: dts: imx6sl: Add vivante gpu nodes

The imx6sl soc has gpu_2d and gpu_vg, no 3d support: etnaviv-gpu 220.gpu: model: GC320, revision: 5007 etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 The IP blocks seem to be already supported. Signed-off-by: Leonard Crestez Reviewed-by: Lucas Stach --- arch/arm/boot/dts

Re: [PATCH] drm: mxsfb: fix runtime PM handling

On Fri, 2018-07-13 at 11:12 +0200, Marek Vasut wrote: > On 07/13/2018 11:06 AM, Anson Huang wrote: > [...] > > > > > > On 07/13/2018 10:54 AM, Anson Huang wrote: > > > > As display power domain is combined with lcdif node on some i.MX > > > > platforms like i.MX6SL, when lcdif driver is enabled,

[PATCH] ARM: dts: imx6sl: Add vivante gpu nodes

The imx6sl soc has gpu_2d and gpu_vg, no 3d support: etnaviv-gpu 220.gpu: model: GC320, revision: 5007 etnaviv-gpu 2204000.gpu: model: GC355, revision: 1215 The IP blocks are close enough to supported hardware that they "just work" with etnaviv and x11. Signed-off-by: Leona

Re: [PATCH 1/3] drm: mxsfb: Change driver.name to mxsfb-drm

On Thu, 2018-07-12 at 11:21 +0200, Stefan Agner wrote: > On 10.07.2018 11:11, Marek Vasut wrote: > > On 07/10/2018 11:06 AM, Stefan Agner wrote: > > > This is one of the situation where states quo is kinda the worst > > > situation. > > > > > > Currently imx_v6_v7_defconfig and mxs_defconfig

[PATCH] drm/imx: Remove last traces of struct imx_drm_crtc

When the definition of this struct was removed a forward declaration and an unused struct member were still left around. Remove them because they serve no purpose. Fixes 44b460cfe554 ("drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs") Signed-off-by: Leona

Re: [RFC 2/2] ARM: dts: imx6sl: Convert gpc to new bindings

On Wed, 2018-06-06 at 11:24 +0200, Lucas Stach wrote: > Am Dienstag, den 05.06.2018, 20:11 +0300 schrieb Leonard Crestez: > > With old bindings imx_gpc_onecell_data always sets num_domains to 2 so > > the DISPMIX domain can't actually be referenced. The pd is still defined > &

Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

On 10/31/2018 8:12 AM, Shawn Guo wrote: > On Mon, Oct 08, 2018 at 06:06:23PM +0000, Leonard Crestez wrote: >> This was implemented in the driver but not actually defined and >> referenced in dts. This makes it always on. >> >> From reference manual in section &qu

Re: [PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

On 10/31/2018 5:06 PM, Lorenzo Pieralisi wrote: > On Wed, Oct 31, 2018 at 12:17:50PM +0000, Leonard Crestez wrote: >> On 10/31/2018 8:12 AM, Shawn Guo wrote: >>> On Mon, Oct 08, 2018 at 06:06:23PM +0000, Leonard Crestez wrote: >>>> This was implemented in the d

[PATCH v2 0/4] ARM: dts: imx6sx: Add DISPLAY power domain support

mxsfb thread: https://lkml.org/lkml/2018/9/26/1185 Leonard Crestez (4): soc: imx: gpc: Increase GPC_CLK_MAX to 7 dt-bindings: imx6q-pcie: Add multi-pd bindings for imx6sx PCI: imx: Add multi-pd support ARM: dts: imx6sx: Add DISPLAY power domain support .../bindings/pci/fsl,imx6q-pcie.txt

[PATCH v2 2/4] dt-bindings: imx6q-pcie: Add multi-pd bindings for imx6sx

The PCIE and PCIE_PHY blocks are in different power domains on imx6sx and this needs to be described using multi-pd bindings. This was not required until now because the power-domain of the PCIE block (DISPLAY) was always on. Signed-off-by: Leonard Crestez --- Documentation/devicetree/bindings

[PATCH v2 4/4] ARM: dts: imx6sx: Add DISPLAY power domain support

ied by internal regulator." The current pd_pcie is actually only for PCIE_PHY, the PCIE ip block is actually inside the DISPLAY domain. Handle this by adding the pcie node in both power domains. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx6sx.dtsi | 19 ++- 1 file ch

[PATCH v2 1/4] soc: imx: gpc: Increase GPC_CLK_MAX to 7

The DISPLAY power domain on imx6sx has 7 clocks. Signed-off-by: Leonard Crestez --- drivers/soc/imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c index aa3729ecaa9e..7d14a4b4e82a 100644 --- a/drivers/soc/imx/gpc.c +++ b

[PATCH v2 3/4] PCI: imx: Add multi-pd support

requires a way for pcie to keep it active or it will break when displays are off. The power-domains on imx6sx are meant to look like this: power-domains = <_disp>, <_pci>; power-domain-names = "pcie", "pcie_phy"; Signed-off-by: Leonard Crestez Review

[PATCH 3/3] ARM: dts: imx6sx: Add DISPLAY power domain support

ied by internal regulator." The current pd_pcie is actually only for PCIE_PHY, the PCIE ip block is actually inside the DISPLAY domain. Handle this by adding the pcie node in both power domains. Signed-off-by: Leonard Crestez --- arch/arm/boot/dts/imx6sx.dtsi | 19 ++- 1 file ch

[PATCH 2/3] PCI: imx: Add multi-pd support

requires a way for pcie to keep it active or it will break when displays are off. The power-domains on imx6sx are meant to look like this: power-domains = <_disp>, <_pci>; power-domain-names = "pcie", "pcie_phy"; Signed-off-by: Leonard Crestez Reviewed-by

[PATCH 1/3] soc: imx: gpc: Increase GPC_CLK_MAX to 7

The DISPLAY power domain on imx6sx has 7 clocks. Signed-off-by: Leonard Crestez --- drivers/soc/imx/gpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c index c1d0ffdac6dd..51cbfe63ec12 100644 --- a/drivers/soc/imx/gpc.c +++ b

[PATCH 0/3] ARM: dts: imx6sx: Add DISPLAY power domain support

hold back on it until the PCI and mxsfb dependencies get merged (both might take a long time). So you can just review that patch and I will resend it later, perhaps in another cycle. Link to mxsfb thread: https://lkml.org/lkml/2018/9/26/1185 Leonard Crestez (3): soc: imx: gpc: Increase

Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Mon, 2018-08-27 at 14:02 +0200, Philipp Zabel wrote: > Hi Leonard, > > On Mon, 2018-08-27 at 14:10 +0300, Leonard Crestez wrote: > > Adding lcdif nodes to a power domain currently doesn't work, it results > > in black/corrupted screens or hangs. While the driver does

Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Mon, 2018-09-17 at 16:37 -0700, Stefan Agner wrote: > On 17.09.2018 12:16, Sean Paul wrote: > > On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote: > > > Adding lcdif nodes to a power domain currently doesn't work, it results > > > in black/corrup

[RESEND 2/5] drm/mxsfb: Fix initial corrupt frame when activating display

LCDIF will repeatedly display data from CUR_BUF and set CUR_BUF to NEXT_BUF when done. Since we are only ever writing to NEXT_BUF the display will show an initial corrupt frame. Fix by writing the FB paddr to both CUR_BUF and NEXT_BUF when activating the CRTC. Signed-off-by: Leonard Crestez

Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

On Mon, 2018-09-17 at 15:16 -0400, Sean Paul wrote: > On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote: > > Adding lcdif nodes to a power domain currently doesn't work, it results > > in black/corrupted screens or hangs. While the driver does enable > > runtim

[RESEND 3/5] drm/mxsfb: Add pm_runtime calls to pipe_enable/disable

Adding lcdif nodes to a power domain currently results in black/corrupted screens or hangs because power is not correctly enabled when required. Ensure power is on when display is active by adding pm_runtime_get/put_sync to mxsfb_pipe_enable/disable. Signed-off-by: Leonard Crestez Reviewed

[RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

people should feel free to push patches in this area? Right now drm/imx is mostly for IPUv3 but there are other display output paths on imx, such as the LCDIF supported by this driver. This LCDIF block is included on imx8 so still quite relevant. Leonard Crestez (5): drm/mxsfb: Move axi clk enable

[RESEND 1/5] drm/mxsfb: Move axi clk enable/disable to crtc enable/disable

. Signed-off-by: Leonard Crestez Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c index 0abe77675b76..e4fcbb65b969 100644 --- a/drivers

[RESEND 5/5] drm/mxsfb: Switch to drm_atomic_helper_commit_tail_rpm

ensure atomic_plane_update is only called while the crtc is active. This avoids having to keep track of "enabled" bits inside the mxsfb driver. This also requires handling the vblank event for disable from mxsfb_pipe_disable. Signed-off-by: Leonard Crestez Suggested-by: Stefan Agner

[RESEND 4/5] drm/mxsfb: Add PM_SLEEP support

Since power to the lcdif block can be lost on suspend implement PM_SLEEP_OPS using drm_mode_config_helper_suspend/resume to save/restore the current mode. Signed-off-by: Leonard Crestez Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 21 + 1 file changed

[PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27

Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should enable it by default for imx. Restoring the PWM driver fixes an infinite probe loop in 5.1-rc1 on various imx6qdl-sabresd boards. Signed-off-b

Re: [PATCH] ARM: imx_v6_v7_defconfig: Enable CONFIG_PWM_IMX27

On 3/21/2019 11:49 AM, Uwe Kleine-König wrote: > On Wed, Mar 20, 2019 at 01:01:26PM +0000, Leonard Crestez wrote: >> Commit d80f8206905c ("pwm: imx: Split into two drivers") also adds a new >> CONFIG_PWM_IMX27 for the PWM block on recent IMX chips and we should >&g

Re: [PATCH v3 00/15] Improvements and fixes for mxsfb DRM driver

On 26.08.2019 17:35, Stefan Agner wrote: > On 2019-08-26 14:05, Guido Günther wrote: >> Hi, >> On Wed, Aug 21, 2019 at 01:15:40PM +0300, Robert Chiras wrote: >>> This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like 8MQ, 8MM >>> and 8QXP). Following, are the new features added and

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

On 23.07.2019 15:21, Artur Świgoń wrote: > +static int exynos_bus_icc_aggregate(struct icc_node *node, u32 avg_bw, > + u32 peak_bw, u32 *agg_avg, u32 *agg_peak) > +{ > + *agg_peak = *agg_avg = peak_bw; > + > + return 0; > +} The only current provider

Re: [RFC PATCH 09/11] devfreq: exynos-bus: Add interconnect functionality to exynos-bus

On 29.07.2019 04:49, Chanwoo Choi wrote: > On 19. 7. 23. 오후 9:20, Artur Świgoń wrote: >> This patch adds interconnect functionality to the exynos-bus devfreq >> driver. >> >> The devfreq target() callback provided by exynos-bus now selects either the >> frequency calculated by the devfreq governor