Re: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Lukas Wunner
On Mon, Feb 28, 2022 at 04:13:44PM -0600, Bjorn Helgaas wrote: > On Mon, Feb 28, 2022 at 03:33:13PM +, Limonciello, Mario wrote: > > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > > > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external- > > > facing" > > > >

Re: [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-11 Thread Lukas Wunner
On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: > Debugfs APIs returns encoded error on failure so use > debugfs_lookup() instead of checking for NULL. [...] > --- a/drivers/gpu/vga/vga_switcheroo.c > +++ b/drivers/gpu/vga/vga_switcheroo.c > @@ -914,7 +914,7 @@ static void vga_switchero

Re: [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-11 Thread Lukas Wunner
On Mon, Oct 11, 2021 at 10:24:29PM +0200, Lukas Wunner wrote: > On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: > > Debugfs APIs returns encoded error on failure so use > > debugfs_lookup() instead of checking for NULL. > [...] > > --- a/drivers/gpu/vga/vg

Re: [PATCH v2 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-17 Thread Lukas Wunner
ething like: Retry creation of the vga_switcheroo debugfs if a previous invocation of debugfs_create_dir() returned an error code. With that addressed, Reviewed-by: Lukas Wunner Thanks, Lukas > Signed-off-by: Nirmoy Das > --- > drivers/gpu/vga/vga_switcheroo.c | 2 +- > 1 fi

[Intel-gfx] [PATCH 0197/1285] Replace numeric parameter like 0444 with macro

2016-08-02 Thread Lukas Wunner
On Tue, Aug 02, 2016 at 02:37:37PM +0300, Ville Syrjälä wrote: > On Tue, Aug 02, 2016 at 06:48:47PM +0800, Baole Ni wrote: > > I find that the developers often just specified the numeric value > > when calling a macro which is defined with a parameter for access > > permission. > > As we know, t

rst htmldocs on kernel.org

2016-08-11 Thread Lukas Wunner
Hi Jonathan, not sure if this is already on your radar or if you're at all the right person to contact, but I just noticed that the gpu htmldocs are gone from https://www.kernel.org/doc/htmldocs/gpu/ Actually all the rst-formatted docs are missing. It would be great if they could be reinstated so

[PATCH v2 1/2] drm: Introduce DRM_DEV_* log messages

2016-08-12 Thread Lukas Wunner
On Fri, Aug 12, 2016 at 07:39:38PM +0100, Chris Wilson wrote: > On Fri, Aug 12, 2016 at 01:30:00PM -0400, Sean Paul wrote: > > This patch consolidates all the various log functions/macros into > > one uber function, drm_log. It also introduces some new DRM_DEV_* > > variants that print the device n

[PATCH v2 1/2] drm: Introduce DRM_DEV_* log messages

2016-08-12 Thread Lukas Wunner
On Fri, Aug 12, 2016 at 08:44:38PM +0100, Chris Wilson wrote: > On Fri, Aug 12, 2016 at 09:26:32PM +0200, Lukas Wunner wrote: > > On Fri, Aug 12, 2016 at 07:39:38PM +0100, Chris Wilson wrote: > > > On Fri, Aug 12, 2016 at 01:30:00PM -0400, Sean Paul wrote: > > > > T

rst htmldocs on kernel.org

2016-08-16 Thread Lukas Wunner
Hi Jonathan, [+cc Konstantin] On Mon, Aug 15, 2016 at 04:21:15PM -0600, Jonathan Corbet wrote: > On Thu, 11 Aug 2016 21:13:29 +0200 Lukas Wunner wrote: > > not sure if this is already on your radar or if you're at all the > > right person to contact, but I just noticed t

Re: [PATCH 30/33] vgaswitcheroo: call fbcon_remap_all directly

2019-05-20 Thread Lukas Wunner
void fbcon_remap_all(int idx) That comment needs to be removed as well. Not an expert on fbcon code but this looks sane to me, so in case it helps: Acked-by: Lukas Wunner Thanks, Lukas

Re: [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks

2019-04-11 Thread Lukas Wunner
On Thu, Apr 11, 2019 at 06:42:33PM +0200, Noralf Trønnes wrote: > @@ -1299,6 +1299,11 @@ static void __spi_pump_messages(struct spi_controller > *ctlr, bool in_kthread) > > trace_spi_message_start(ctlr->cur_msg); > > + ret = spi_split_transfers_maxsize(ctlr, ctlr->cur_msg, > ctlr->m

Re: [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks

2019-04-12 Thread Lukas Wunner
On Thu, Apr 11, 2019 at 11:02:26PM +0200, Noralf Trønnes wrote: > Den 11.04.2019 20.18, skrev Lukas Wunner: > > On Thu, Apr 11, 2019 at 06:42:33PM +0200, Noralf Trønnes wrote: > >> @@ -1299,6 +1299,11 @@ static void __spi_pump_messages(struct > >> spi_contro

Re: [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks

2019-04-12 Thread Lukas Wunner
On Fri, Apr 12, 2019 at 10:47:21AM +0100, Mark Brown wrote: > On Thu, Apr 11, 2019 at 11:02:26PM +0200, Noralf Trønnes wrote: > > Den 11.04.2019 20.18, skrev Lukas Wunner: > > > On Thu, Apr 11, 2019 at 06:42:33PM +0200, Noralf Trønnes wrote: > > > > @@ -

Re: [PATCH v4 2/4] spi: Split spi message into max_dma_len size chunks

2019-04-12 Thread Lukas Wunner
On Fri, Apr 12, 2019 at 12:09:34PM +0100, Mark Brown wrote: > On Fri, Apr 12, 2019 at 12:54:48PM +0200, Lukas Wunner wrote: > > On Fri, Apr 12, 2019 at 10:47:21AM +0100, Mark Brown wrote: > > > I *think* we managed to fix all the architectures to at least stub out > > &g

Re: [PATCH v5 3/4] spi/spi-bcm2835: Split transfers that exceed DLEN

2019-04-13 Thread Lukas Wunner
ual driver, rather than something that is inflicted on *all* drivers (midlayer fallacy). Of course the performance is suboptimal compared to an approach which transmits the sglist in portions which are < 65535 each, but we can move to that later. In cas

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-23 Thread Lukas Wunner
gt; According to the docs, select should only be used for non-visible > symbols. Furthermore almost all other references to INPUT throughout the > kernel config are depends, not selects. Hence this change. > > CC: Inki Dae > CC: Andrzej Hajda > Signed-off-by: Ronald Tschalär

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-24 Thread Lukas Wunner
On Wed, Jan 23, 2019 at 11:21:25PM -0800, Life is hard, and then you die wrote: > Since the two changes (the change here + the new driver) seem to be > best submitted through different trees, I'm trying to figure out how > best to handle this. I suppose I could temporarily change the driver > Kconf

Re: [PATCH v1 03/11] vga-switcheroo: make PCI dependency explicit

2018-12-21 Thread Lukas Wunner
On Sat, Dec 22, 2018 at 12:14:44AM +, Sinan Kaya wrote: > This driver depends on the PCI infrastructure but the dependency has not > been explicitly called out. > > Signed-off-by: Sinan Kaya Reviewed-by: Lukas Wunner > --- > drivers/gpu/vga/Kconfig | 1 + > 1 file

Re: [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit

2018-12-22 Thread Lukas Wunner
On Sat, Dec 22, 2018 at 09:07:12AM +, Sinan Kaya wrote: > This driver depends on the PCI infrastructure but the dependency has not > been explicitly called out. > > Signed-off-by: Sinan Kaya > Reviewed-by: Lukas Wunner This series doesn't have a cover letter so it

Re: [PATCH v2 03/11] vga-switcheroo: make PCI dependency explicit

2018-12-23 Thread Lukas Wunner
On Sun, Dec 23, 2018 at 02:00:15AM +0300, Sinan Kaya wrote: > On Sat, Dec 22, 2018 at 7:40 PM Lukas Wunner wrote: > > On Sat, Dec 22, 2018 at 09:07:12AM +, Sinan Kaya wrote: > > > This driver depends on the PCI infrastructure but the dependency has not > > >

Re: [PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-13 Thread Lukas Wunner
On Fri, Feb 11, 2022 at 01:32:42PM -0600, Mario Limonciello wrote: > The `is_thunderbolt` attribute is currently a dumping ground for a > variety of things. It's not as arbitrary as it may seem. Quite a bit of thought went into the current design. > Instead use the driver core removable attribu

Re: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-13 Thread Lukas Wunner
On Fri, Feb 11, 2022 at 12:23:51PM +0200, Mika Westerberg wrote: > On Thu, Feb 10, 2022 at 04:43:23PM -0600, Mario Limonciello wrote: > > @@ -2955,7 +2955,7 @@ bool pci_bridge_d3_possible(struct pci_dev *bridge) > > return true; > > > > /* Even the oldest 2010 Thun

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-13 Thread Lukas Wunner
On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: > `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt > controller to indicate that D3 is possible. As this is used solely > for older Apple systems, move it into a quirk that enumerates across > all Intel TBT co

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-13 Thread Lukas Wunner
On Sun, Feb 13, 2022 at 10:19:20AM +0100, Lukas Wunner wrote: > Apple had been using its own scheme to put Thunderbolt controllers > into D3cold when nothing is plugged in, about a decade before Microsoft > defined the ACPI property. I meant to say "half a decade", sorry.

Re: [PATCH v3 05/12] PCI: Detect root port of internal USB4 devices by `usb4-host-interface`

2022-02-14 Thread Lukas Wunner
On Mon, Feb 14, 2022 at 09:34:26AM +0200, Mika Westerberg wrote: > On Fri, Feb 11, 2022 at 03:45:46PM -0600, Bjorn Helgaas wrote: > > My expectation is that "USB" (like "PCI" and "PCIe") tells me > > something about how a device is electrically connected and how > > software can operate it. It doe

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-14 Thread Lukas Wunner
On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- > drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +- > drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +- > drivers/gpu/drm/radeon/radeon_device.c | 4 +- > drivers/gpu/drm/radeon/ra

Re: [PATCH] drm/i915: Switch TGL-H DP-IN to dGFX when it's supported

2022-08-18 Thread Lukas Wunner
On Tue, Aug 16, 2022 at 11:06:18AM +0300, Jani Nikula wrote: > On Tue, 16 Aug 2022, Kai-Heng Feng wrote: > > On mobile workstations like HP ZBook Fury G8, iGFX's DP-IN can switch to > > dGFX so external monitors are routed to dGFX, and more monitors can be > > supported as result. > > > > To switc

Re: [PATCH 2/2] maintainers: Update freedesktop.org IRC channels

2021-05-30 Thread Lukas Wunner
On Sat, May 29, 2021 at 10:16:38AM -0400, Alyssa Rosenzweig wrote: > Like many free software projects, freedesktop.org issued a non-binding > recommendation for projects to migrate from OFTC to Freenode [1]. As ^

Re: [PATCH 2/2] maintainers: Update freedesktop.org IRC channels

2021-05-30 Thread Lukas Wunner
On Sat, May 29, 2021 at 10:16:38AM -0400, Alyssa Rosenzweig wrote: > Like many free software projects, freedesktop.org issued a non-binding > recommendation for projects to migrate from OFTC to Freenode [1]. As > such, freedesktop.org entries in the MAINTAINERS file are out-of-date as > the respect

Re: [PATCH] Revert "fbdev: Remove conflicting devices on PCI bus"

2023-02-04 Thread Lukas Wunner
On Fri, Feb 03, 2023 at 05:09:09PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > This reverts commit 145eed48de278007f646b908fd70ac59d24ed81a. > > Zeno Davatz reported that 145eed48de27 ("fbdev: Remove conflicting devices > on PCI bus") caused a console hang. The machine was actually st

Re: [PATCH v2 3/3] drm: Call vga_switcheroo_process_delayed_switch() in drm_lastclose

2023-01-17 Thread Lukas Wunner
On Thu, Jan 12, 2023 at 09:11:56PM +0100, Thomas Zimmermann wrote: > Several lastclose helpers call vga_switcheroo_process_delayed_switch(). > It's better to call the helper from drm_lastclose() after the kernel > client's screen has been restored. This way, all drivers can benefit > without having

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Lukas Wunner
On Tue, Oct 04, 2016 at 01:25:23PM +0200, Daniel Vetter wrote: > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > > Looks like crtc is a errno in the above case. I see this function is > > called by looping through all the crtc and we never check to see if > > they are valid. Should we? nouve

[PATCH v8 2/4] drm: Add API for capturing frame CRCs

2016-10-04 Thread Lukas Wunner
On Tue, Oct 04, 2016 at 02:23:13PM +0200, Lukas Wunner wrote: > On Tue, Oct 04, 2016 at 01:25:23PM +0200, Daniel Vetter wrote: > > On Tue, Oct 4, 2016 at 12:10 PM, Jon Hunter wrote: > > > Looks like crtc is a errno in the above case. I see this function is > > > called

Re: [PATCH] MAINTAINERS: Add Lukas Wunner as reviewer for vga_switcheroo

2017-03-31 Thread Lukas Wunner
On Tue, Mar 28, 2017 at 08:31:26AM +0200, Daniel Vetter wrote: > On Mon, Mar 27, 2017 at 06:48:24PM +0200, Lukas Wunner wrote: > > I've been contributing to vga_switcheroo for the past two years and by > > now am fairly familiar with it, so danvet suggested that I add my

Re: [PATCH v2 0/5] Thunderbolt GPU fixes

2017-03-31 Thread Lukas Wunner
On Fri, Mar 10, 2017 at 09:23:45PM +0100, Lukas Wunner wrote: > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo, v2: > > Same as v1 but includes all the acks collected and in patch [1/5] > the commit message and a code comment were edited as requested by > Bjorn He

Re: [PATCH v2 0/5] Thunderbolt GPU fixes

2017-04-05 Thread Lukas Wunner
On Fri, Mar 31, 2017 at 06:30:48AM -0700, Bjorn Helgaas wrote: > On Fri, Mar 31, 2017 at 3:11 AM, Lukas Wunner wrote: > > Bjorn, I haven't heard back after my reply to your e-mail of March 10 > > (regarding the "usually soldered to the mainboard" comment). I hope

nvidia vgaarb bug (was: Re: Static inline DRM functions calling into GPL-only code)

2017-04-11 Thread Lukas Wunner
Hi Nikhil, On Tue, Apr 11, 2017 at 09:44:35AM +0530, Nikhil Mahale wrote: > There is not interest in relaxing the export of refcount_inc, and > changing the license of nvidia-drm.ko isn't viable right now. Why not dual-license as MIT+GPL? > * Make these static inline DRM functions EXPORT_SYMBO

Re: [git pull] drm fixes for 4.10-rc6 (just missed rc5 tagging :-)

2017-01-25 Thread Lukas Wunner
On Wed, Jan 25, 2017 at 01:54:32PM +0100, Daniel Vetter wrote: > On Wed, Jan 25, 2017 at 06:10:57PM +0900, Michel Dänzer wrote: > > On 25/01/17 05:33 PM, Markus Trippelsdorf wrote: > > > On 2017.01.23 at 09:38 +1000, Dave Airlie wrote: > > >>

[PATCH 1/5] PCI: Recognize Thunderbolt devices

2017-02-24 Thread Lukas Wunner
t register external GPUs with vga_switcheroo, which necessitates a way to recognize if they're on a Thunderbolt daisy chain. Cc: Andreas Noever Cc: Michael Jamet Cc: Tomas Winkler Cc: Amir Levy Signed-off-by: Lukas Wunner --- drivers/pci/pci.h | 2 ++ drivers/p

[PATCH 0/5] Thunderbolt GPU fixes

2017-02-24 Thread Lukas Wunner
t included in the 4.11 PCI pull for some reason: http://www.spinics.net/lists/linux-pci/msg58123.html I've pushed the present series to GitHub in case anyone prefers reviewing it in a GUI: https://github.com/l1k/linux/commits/thunderbolt_gpu_v1 Thanks, Lukas Lukas Wunner (5): PCI: Reco

[PATCH 3/5] drm/nouveau: Don't register Thunderbolt eGPU with vga_switcheroo

2017-02-24 Thread Lukas Wunner
n a lockup. Cc: Ben Skeggs Signed-off-by: Lukas Wunner --- drivers/gpu/drm/nouveau/nouveau_vga.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c index eef22c6b9665..c2a7fd606c2e 100644 ---

[PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-02-24 Thread Lukas Wunner
n a lockup. Cc: Alex Deucher Signed-off-by: Lukas Wunner --- drivers/gpu/drm/radeon/radeon_device.c | 7 +-- drivers/gpu/drm/radeon/radeon_kms.c| 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeo

[PATCH 5/5] drm/amdgpu: Don't register Thunderbolt eGPU with vga_switcheroo

2017-02-24 Thread Lukas Wunner
n a lockup. Cc: Alex Deucher Signed-off-by: Lukas Wunner --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/

[PATCH 2/5] apple-gmux: Don't switch external DP port on 2011+ MacBook Pros

2017-02-24 Thread Lukas Wunner
implemented by this commit. Signed-off-by: Lukas Wunner --- drivers/platform/x86/apple-gmux.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c index a66be137324c..623d322447a2

Re: [PATCH 1/5] PCI: Recognize Thunderbolt devices

2017-02-24 Thread Lukas Wunner
On Fri, Feb 24, 2017 at 04:17:24PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 24, 2017 at 08:19:45PM +0100, Lukas Wunner wrote: > > --- a/include/linux/pci.h > > +++ b/include/linux/pci.h > > @@ -358,6 +358,7 @@ struct pci_dev { > > unsigned intis_virtfn:1; >

[Nouveau] [PATCH 1/9] drm/nouveau: Don't leak runtime pm ref on driver unload

2016-05-31 Thread Lukas Wunner
On Mon, May 30, 2016 at 07:03:46PM +0200, Peter Wu wrote: > On Sun, May 29, 2016 at 05:50:06PM +0200, Lukas Wunner wrote: > > How exactly did you reach the situation where the root port didn't wake > > up when you tried to load nouveau again? (IRC conversation this week.) >

[Nouveau] [PATCH 4/4] drm/nouveau/acpi: fix lockup with PCIe runtime PM

2016-05-31 Thread Lukas Wunner
On Mon, May 30, 2016 at 06:13:51PM +0200, Peter Wu wrote: > Do you have any suggestions for the case where the pcieport driver > refuses to put the bridge in D3 (because the BIOS is too old)? In that > case the nouveau driver needs to fallback to the DSM method (but not > when runtime PM is deliber

[Nouveau] [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 Thread Lukas Wunner
On Tue, Nov 08, 2016 at 04:52:49PM +0100, Arnd Bergmann wrote: > The underlying problem is that we already have a number of other > symbols that either have "depends on LEDS_CLASS" or > "select LEDS_CLASS". To clean that up properly, we should either > make the symbol itself hidden and only select

[PATCH REBASED 2/2] Do not register interface if Apple GMUX detected

2016-11-14 Thread Lukas Wunner
s it prevents from grepping > it, as pointed out by Lukas Wunner > > Signed-off-by: Pierre Moreau Reviewed-by: Lukas Wunner Thanks, Lukas > --- > drivers/gpu/drm/nouveau/nouveau_backlight.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/gpu/drm/no

[PATCH v3 1/2] nouveau/bl: Assign different names to interfaces

2016-11-14 Thread Lukas Wunner
On Sun, Nov 13, 2016 at 08:57:06PM +0100, Pierre Moreau wrote: > From: Pierre Moreau > > Currently, every backlight interface created by Nouveau uses the same name, > nv_backlight. This leads to a sysfs warning as it tries to create an already > existing folder. This patch adds a incremented numb

[PATCH v3] PCI: create revision file in sysfs

2016-11-17 Thread Lukas Wunner
On Wed, Nov 16, 2016 at 02:58:11PM -0600, Bjorn Helgaas wrote: > On Mon, Nov 14, 2016 at 07:40:03PM +0100, Daniel Vetter wrote: > > On Fri, Nov 11, 2016 at 02:37:23PM +, Emil Velikov wrote: > > > From: Emil Velikov > > > > > > Currently the revision isn't available via sysfs/libudev thus if o

Re: [PATCH 3/5] drm/nouveau: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-04 Thread Lukas Wunner
On Fri, Feb 24, 2017 at 02:59:44PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 24, 2017 at 1:19 PM, Lukas Wunner wrote: > > An external Thunderbolt GPU can neither drive the laptop's panel nor be > > powered off by the platform, so there's no point in registering i

Re: [PATCH 1/5] PCI: Recognize Thunderbolt devices

2017-03-04 Thread Lukas Wunner
On Fri, Feb 24, 2017 at 04:17:24PM -0600, Bjorn Helgaas wrote: > On Fri, Feb 24, 2017 at 08:19:45PM +0100, Lukas Wunner wrote: > > Detect on probe whether a PCI device is part of a Thunderbolt controller. [...] > > * If an external Thunderbolt GPU is connected to a dual GPU lapto

Re: RFC: late drm pull requests and other topics

2017-03-07 Thread Lukas Wunner
On Tue, Mar 07, 2017 at 10:56:49AM -0500, Alex Deucher wrote: > On Mon, Mar 6, 2017 at 7:11 PM, Daniel Vetter wrote: > I've always tried to have all major new features sent to Dave by rc5, > so no problems with the timelines. Dave and Linus have generally been > ok with new asic support at strang

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-07 Thread Lukas Wunner
On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote: > > An external Thunderbolt GPU can neither drive the laptop's panel nor be > > powered off by the platform, so there's no point in registering it with >

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-08 Thread Lukas Wunner
On Wed, Mar 08, 2017 at 11:46:33AM +0100, Peter Wu wrote: > On Wed, Mar 08, 2017 at 06:01:54AM +0100, Lukas Wunner wrote: > > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > > > On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote: > > > > An extern

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-09 Thread Lukas Wunner
On Wed, Mar 08, 2017 at 03:34:47PM -0500, Alex Deucher wrote: > On Wed, Mar 8, 2017 at 12:01 AM, Lukas Wunner wrote: > > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > >> On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote: > >> > An external Thu

Re: [PATCH 0/5] Thunderbolt GPU fixes

2017-03-10 Thread Lukas Wunner
On Thu, Mar 09, 2017 at 04:03:47PM +0100, Daniel Vetter wrote: > On Fri, Feb 24, 2017 at 08:19:45PM +0100, Lukas Wunner wrote: > > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo: > > > > Patch [1/5] ("Recognize Thunderbolt devices") has already been

[PATCH v2 0/5] Thunderbolt GPU fixes

2017-03-10 Thread Lukas Wunner
://lists.freedesktop.org/archives/dri-devel/2017-February/133891.html To review the patches on GitHub, use this URL: https://github.com/l1k/linux/commits/thunderbolt_gpu_v2 Thanks, Lukas Lukas Wunner (5): PCI: Recognize Thunderbolt devices drm/radeon: Don't register Thunderbolt eGPU

[PATCH v2 2/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-10 Thread Lukas Wunner
n a lockup. Moreover AMD's Windows driver special-cases Thunderbolt as well. Acked-by: Alex Deucher Signed-off-by: Lukas Wunner --- drivers/gpu/drm/radeon/radeon_device.c | 7 +-- drivers/gpu/drm/radeon/radeon_kms.c| 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --gi

[PATCH v2 1/5] PCI: Recognize Thunderbolt devices

2017-03-10 Thread Lukas Wunner
e kerneldoc for pci_is_thunderbolt_attached() more precise, drop portion of commit message pertaining to separate series. (Bjorn Helgaas) Cc: Andreas Noever Cc: Michael Jamet Cc: Tomas Winkler Cc: Amir Levy Acked-by: Bjorn Helgaas Signed-off-by: Lukas Wunner --- drivers/pci/pci.h | 2

[PATCH v2 3/5] drm/amdgpu: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-10 Thread Lukas Wunner
n a lockup. Moreover AMD's Windows driver special-cases Thunderbolt as well. Acked-by: Alex Deucher Signed-off-by: Lukas Wunner --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 3 ++- 2 files changed, 7 insertions(+), 3 deletions(-

[PATCH v2 4/5] drm/nouveau: Don't register Thunderbolt eGPU with vga_switcheroo

2017-03-10 Thread Lukas Wunner
n a lockup. Cc: Ben Skeggs Acked-by: Alex Deucher Signed-off-by: Lukas Wunner --- drivers/gpu/drm/nouveau/nouveau_vga.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_vga.c b/drivers/gpu/drm/nouveau/nouveau_vga.c index cc

[PATCH v2 5/5] apple-gmux: Don't switch external DP port on 2011+ MacBook Pros

2017-03-10 Thread Lukas Wunner
implemented by this commit. Acked-by: Andy Shevchenko Signed-off-by: Lukas Wunner --- drivers/platform/x86/apple-gmux.c | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/apple-gmux.c b/drivers/platform/x86/apple-gmux.c index

Re: [PATCH v2 1/5] PCI: Recognize Thunderbolt devices

2017-03-11 Thread Lukas Wunner
On Fri, Mar 10, 2017 at 02:47:04PM -0600, Bjorn Helgaas wrote: > On Fri, Mar 10, 2017 at 2:23 PM, Lukas Wunner wrote: > > +/** > > + * pci_is_thunderbolt_attached - whether device is on a Thunderbolt daisy > > chain > > + * @pdev: PCI device to check > > + * &g

Re: [PATCH v2 0/5] Thunderbolt GPU fixes

2017-03-18 Thread Lukas Wunner
Hi Daniel, On Fri, Mar 10, 2017 at 09:23:45PM +0100, Lukas Wunner wrote: > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo, v2: > > Same as v1 but includes all the acks collected and in patch [1/5] > the commit message and a code comment were edited as requeste

Re: [PATCH v2 0/5] Thunderbolt GPU fixes

2017-03-25 Thread Lukas Wunner
Dear drm-misc maintainers, please consider merging this series: On Sat, Mar 18, 2017 at 08:39:53AM +0100, Lukas Wunner wrote: > Hi Daniel, > > On Fri, Mar 10, 2017 at 09:23:45PM +0100, Lukas Wunner wrote: > > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo, v2: &

Re: [PATCH v2 0/5] Thunderbolt GPU fixes

2017-03-26 Thread Lukas Wunner
On Sat, Mar 25, 2017 at 10:06:03PM +0100, Daniel Vetter wrote: > On Sat, Mar 25, 2017 at 09:05:20AM +0100, Lukas Wunner wrote: > > Dear drm-misc maintainers, > > > > please consider merging this series: > > I think I pinged you in private already, but want to become d

[PATCH] MAINTAINERS: Add Lukas Wunner as reviewer for vga_switcheroo

2017-03-27 Thread Lukas Wunner
s dri-devel@ and the drm-misc maintainers. Suggested-by: Daniel Vetter Signed-off-by: Lukas Wunner --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e03e6bcefac3..d0d9ed8d2459 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4146,6 +4

Re: Notifications about ACPI events in userspace?

2017-05-13 Thread Lukas Wunner
[cc += dri-devel] On Fri, May 12, 2017 at 01:05:21PM +0200, Florian Echtler wrote: > On 12.05.2017 12:06, Lukas Wunner wrote: > > On Fri, May 12, 2017 at 10:37:47AM +0200, Florian Echtler wrote: > >> I'm currently adding support for the iMac's target display mode (TDM)

Re: Notifications about ACPI events in userspace?

2017-05-14 Thread Lukas Wunner
On Sat, May 13, 2017 at 06:47:16PM +0200, Florian Echtler wrote: > On 13.05.2017 14:18, Lukas Wunner wrote: > > > > So to sum it up, the built-in panel on the iMac can be driven by a > > separate machine and we can switch between the two sources via the SMC. > > &g

Re: Notifications about ACPI events in userspace?

2017-05-14 Thread Lukas Wunner
On Sun, May 14, 2017 at 11:25:48AM +0200, Florian Echtler wrote: > On 14.05.2017 10:11, Lukas Wunner wrote: > > On Sat, May 13, 2017 at 06:47:16PM +0200, Florian Echtler wrote: > >> On 13.05.2017 14:18, Lukas Wunner wrote: > >>> Then you could switch back and forth vi

Re: [REGRESSION] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

2017-05-18 Thread Lukas Wunner
On Wed, May 17, 2017 at 11:08:23PM +0200, Nicolai Stange wrote: > I'm experiencing a boot failure on next-20170515: > > BUG: unable to handle kernel NULL pointer dereference at 07cb > IP: radeon_driver_load_kms+0xeb/0x230 [radeon] [snip] > Bisection lead to commit 7ffb0ce31cf9 ("dr

[PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-18 Thread Lukas Wunner
kms+0xeb/0x230 [radeon] RSP: b96f0147b9d0 CR2: 07cb ---[ end trace 89cc4ba7e569c65c ]--- Reported-by: Nicolai Stange Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo") Signed-off-by: Lukas Wunner --- Awaiting a Tested-by: from

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Lukas Wunner
On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > On Thu, May 18 2017, Lukas Wunner wrote: [snip] > > Reported-by: Nicolai Stange > > Fixes: 7ffb0ce31cf9 ("drm/radeon: Don't register Thunderbolt eGPU with > > vga_switcheroo&qu

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-22 Thread Lukas Wunner
On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: > On 22/05/17 11:04 PM, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > >> On Thu, May 18 2017, Lukas Wunner wrote: > > [snip] > >>> Reported-by: Nicolai Sta

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Mon, May 22, 2017 at 03:35:48PM -0400, Sean Paul wrote: > On Mon, May 22, 2017 at 04:04:07PM +0200, Lukas Wunner wrote: > > On Sun, May 21, 2017 at 09:31:09AM +0200, Nicolai Stange wrote: > > > On Thu, May 18 2017, Lukas Wunner wrote: > > [snip] > > &

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Mon, May 22, 2017 at 09:24:34PM +0200, Daniel Vetter wrote: > On Thu, May 18, 2017 at 09:33:44PM +0200, Lukas Wunner wrote: > > Nicolai Stange reports the following oops which is caused by > > dereferencing rdev->pdev before it's subsequently set by > >

Re: [PATCH] drm/radeon: Fix oops upon driver load on PowerXpress laptops

2017-05-23 Thread Lukas Wunner
On Tue, May 23, 2017 at 09:32:38AM +0200, Christian König wrote: > Am 23.05.2017 um 05:55 schrieb Michel Dänzer: > >On 23/05/17 12:50 PM, Lukas Wunner wrote: > >>On Tue, May 23, 2017 at 12:09:49PM +0900, Michel Dänzer wrote: > >>>On 22/05/17 11:04 PM, Lukas Wunner wro

Re: [PATCH] dim: Enforce review requirements

2017-05-24 Thread Lukas Wunner
ighlight that review requirements hold > especially also for bugfixes. > > Cc: Patrik Jakobsson > Cc: Lukas Wunner > Cc: Alex Deucher > Cc: Christian König > Cc: Sean Paul > Signed-off-by: Daniel Vetter Reviewed-by: Lukas Wunner

Re: [PATCH] dim: Enforce review requirements

2017-05-24 Thread Lukas Wunner
On Wed, May 24, 2017 at 11:28:12AM +0200, Daniel Vetter wrote: > We can't check this when applying (since r-b/a-b tags often get added > afterwards), but we can check this when pushing. This only looks at > patches authored by the pusher. BTW, can we also have a rule that large drivers (i.e. with

Re: [PULL] drm-misc-fixes

2017-05-25 Thread Lukas Wunner
On Thu, May 25, 2017 at 01:44:04PM -0400, Sean Paul wrote: > The pull is noisy because it includes -rc2. Looks like I've caused another fine mess by fast-forwarding -fixes. :-( I followed the docs in drm-misc.rst which say: * Fast-forward (when possible) `-fixes` to each released -rc kernel tag,

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-05-26 Thread Lukas Wunner
[cc += dri-devel, amd-gfx] On Fri, May 26, 2017 at 02:13:29PM +0200, Florian Echtler wrote: > I'm running Ubuntu 16.04.2 on a 27" unibody iMac 10,1 from 2009. However, even > with the most recent HWE stack (kernel 4.8), the display stays black after > suspend. I can ssh into the machine, so wakeup

Re: [PULL] drm-misc-fixes

2017-05-28 Thread Lukas Wunner
noise in it." (Dave) Cc: Daniel Vetter Cc: Jani Nikula Cc: Sean Paul Cc: Dave Airlie Signed-off-by: Lukas Wunner --- drm-misc.rst | 8 1 file changed, 8 insertions(+) diff --git a/drm-misc.rst b/drm-misc.rst index d56c3c7..c66ac67 100644 --- a/drm-misc.rst +++ b/drm-misc.rst @

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-05-30 Thread Lukas Wunner
On Tue, May 30, 2017 at 11:34:17AM +0200, Florian Echtler wrote: > On 26.05.2017 23:03, Lukas Wunner wrote: > > On Fri, May 26, 2017 at 02:13:29PM +0200, Florian Echtler wrote: > >> I'm running Ubuntu 16.04.2 on a 27" unibody iMac 10,1 from 2009. However, > >&g

Re: iMac 10,1 with Ubuntu 16.04: black screen after suspend

2017-05-31 Thread Lukas Wunner
On Wed, May 31, 2017 at 10:48:37AM +0200, Florian Echtler wrote: > On 30.05.2017 12:54, Lukas Wunner wrote: > > On Tue, May 30, 2017 at 11:34:17AM +0200, Florian Echtler wrote: > >> On 26.05.2017 23:03, Lukas Wunner wrote: > >>> On Fri, May 26, 2017 at 02:13:29P

[pull] radeon and amdgpu drm-next-4.9

2016-09-16 Thread Lukas Wunner
On Fri, Sep 16, 2016 at 04:42:43PM -0400, Alex Deucher wrote: > drm/amdgpu: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF > drm/radeon: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF Those two are unnecessary, it can't happen that the ->suspend hook is executed with the devi

[pull] radeon and amdgpu drm-next-4.9

2016-09-17 Thread Lukas Wunner
On Fri, Sep 16, 2016 at 06:07:36PM -0400, Alex Deucher wrote: > On Fri, Sep 16, 2016 at 5:38 PM, Lukas Wunner wrote: > > On Fri, Sep 16, 2016 at 04:42:43PM -0400, Alex Deucher wrote: > >> drm/amdgpu: skip suspend/resume on DRM_SWITCH_POWER_DYNAMIC_OFF > >>

[PATCH] drm/amdgpu: disable CRTCs before teardown

2016-09-26 Thread Lukas Wunner
On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote: > Some code called by drm_crtc_force_disable_all() wants to wait for all > fences, so only do fence teardown after CRTCs are disabled. Ugh, how embarrassing, that was added by me. Do you have a BUG splat (e.g. soft lockup) for thi

[PATCH] drm/amdgpu: disable CRTCs before teardown

2016-09-26 Thread Lukas Wunner
On Sun, Sep 25, 2016 at 11:34:48PM +0300, Grazvydas Ignotas wrote: > Some code called by drm_crtc_force_disable_all() wants to wait for all > fences, so only do fence teardown after CRTCs are disabled. > > Signed-off-by: Grazvydas Ignotas Fixes: 84b89bdcedf8 ("drm/amdgpu: Turn off CRTCs on drive

[PATCH v4] vga_switcheroo: Add helper for deferred probing

2016-05-19 Thread Lukas Wunner
ppen after calling this helper. (Daniel Vetter) v4: Rebase on 412c8f7de011 ("drm/radeon: Return -EPROBE_DEFER when amdkfd not loaded") Cc: Daniel Vetter Cc: Ben Skeggs Cc: Alex Deucher Signed-off-by: Lukas Wunner --- drivers/gpu/drm/i915/i915_drv.c | 10 +- dr

[PATCH v5] vga_switcheroo: Add helper for deferred probing

2016-05-21 Thread Lukas Wunner
ppen after calling this helper. (Daniel Vetter) v4: Rebase on 412c8f7de011 ("drm/radeon: Return -EPROBE_DEFER when amdkfd not loaded") v5: Some Optimus GPUs use PCI_CLASS_DISPLAY_3D, make sure those are matched as well. (Emil Velikov) Cc: Daniel Vetter Cc: Ben Skeggs Cc: A

[Nouveau] [PATCH v4] vga_switcheroo: Add helper for deferred probing

2016-05-21 Thread Lukas Wunner
Hi Emil, On Fri, May 20, 2016 at 12:41:04AM +0100, Emil Velikov wrote: > On 19 May 2016 at 15:39, Lukas Wunner wrote: > > +bool vga_switcheroo_client_probe_defer(struct pci_dev *pdev) > > +{ > > + if ((pdev->class >> 8) == PCI_CLASS_DISPLAY_VGA) { > Not

[PATCH 0/9] Fix runtime pm ref leaks

2016-05-24 Thread Lukas Wunner
k if it is needed. Thanks, Lukas Lukas Wunner (9): drm/nouveau: Don't leak runtime pm ref on driver unload drm/nouveau: Forbid runtime pm on driver unload drm/radeon: Don't leak runtime pm ref on driver unload drm/radeon: Don't leak runtime pm ref on driver load drm/radeon:

[PATCH 1/9] drm/nouveau: Don't leak runtime pm ref on driver unload

2016-05-24 Thread Lukas Wunner
is loaded again with runpm=1. Fix by taking the runtime pm ref under the same condition that it was released on driver load. Fixes: 5addcf0a5f0f ("nouveau: add runtime PM support (v0.9)") Cc: Dave Airlie Reported-by: Karol Herbst Tested-by: Karol Herbst Signed-off-by: Lukas Wunner --

[PATCH 3/9] drm/radeon: Don't leak runtime pm ref on driver unload

2016-05-24 Thread Lukas Wunner
suspend after loading radeon again. Fix by taking the runtime pm ref under the same condition that it was released on driver load. Fixes: 10ebc0bc0934 ("drm/radeon: add runtime PM support (v2)") Cc: Dave Airlie Signed-off-by: Lukas Wunner --- drivers/gpu/drm/radeon/radeon_kms.c | 4 ++

[PATCH 5/9] drm/radeon: Forbid runtime pm on driver unload

2016-05-24 Thread Lukas Wunner
he behaviour is correct. If there ever is a third party driver for AMD cards, this commit avoids that it has to clean up behind radeon. Signed-off-by: Lukas Wunner --- drivers/gpu/drm/radeon/radeon_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/radeon/radeon_kms.c b/

[PATCH 8/9] drm/amdgpu: Forbid runtime pm on driver unload

2016-05-24 Thread Lukas Wunner
he behaviour is correct. If there ever is a third party driver for AMD cards, this commit avoids that it has to clean up behind amdgpu. Signed-off-by: Lukas Wunner --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c

[PATCH 2/9] drm/nouveau: Forbid runtime pm on driver unload

2016-05-24 Thread Lukas Wunner
iour is correct. The nvidia blob doesn't use runtime pm, but if it ever does, this commit avoids that it has to clean up behind nouveau. Tested-by: Karol Herbst Signed-off-by: Lukas Wunner --- drivers/gpu/drm/nouveau/nouveau_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dri

[PATCH 4/9] drm/radeon: Don't leak runtime pm ref on driver load

2016-05-24 Thread Lukas Wunner
runtime pm ref in the error path of radeon_device_init(). Fixes: 10ebc0bc0934 ("drm/radeon: add runtime PM support (v2)") Cc: Dave Airlie Signed-off-by: Lukas Wunner --- drivers/gpu/drm/radeon/radeon_device.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/

  1   2   3   4   5   >