On Fri, Feb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote:
> On 01/02/17 22:05, Manasi Navare wrote:
> >On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote:
> >>Jani Nikula <jani.nik...@linux.intel.com> writes:
> >>
> >>>On Tue, 31
On Thu, Jan 26, 2017 at 06:21:20PM +0100, Daniel Vetter wrote:
> On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote:
> > Despite all the careful planing of the kernel, a link may become
> > insufficient to handle the currently-set mode. At this point, the
> > kernel should mark this
Hi,
I am working on a solution for handling link failures during or after
the modeset.
In case of link failure, the max link rate/lane count values
are updated to lower link rate/lane count as per the spec and uevent is
sent to the userspace with link-status BAD. The userspace is expected to
On Thu, Jan 26, 2017 at 02:37:28PM +0200, Martin Peres wrote:
> Despite all the careful planing of the kernel, a link may become
> insufficient to handle the currently-set mode. At this point, the
> kernel should mark this particular configuration as being broken
> and potentially prune the mode
On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote:
> Jani Nikula writes:
>
> > On Tue, 31 Jan 2017, Eric Anholt wrote:
> >> Martin Peres writes:
> >>
> >>> Despite all the careful planing of the kernel, a
(Jani Nikula)
v4:
*Return TEST_NAK on read failures and invalid values (Jani Nikula)
* Address CRC mismatch errors
v3:
* Use the updated properly shifted bit definitions (Jani Nikula)
* Force dithering to be disabled on 18bpp compliance
test request (Manasi Navare)
v2:
* Updated the DPCD Register
(Jani Nikula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
---
drivers/gpu/d
On Tue, Jan 24, 2017 at 06:40:51PM +0200, Jani Nikula wrote:
> On Mon, 23 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote:
> > As far as I know, I have addressed the review comments from previous
> > round and answered the questions/concerns that you had either in
Thanks Jani for reviewing this patch and for your feedback.
Its very useful feedback and below are some of my comments:
On Fri, Jan 20, 2017 at 05:05:03PM +0200, Jani Nikula wrote:
> On Fri, 20 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote:
> > This patch adds su
On Mon, Jan 23, 2017 at 12:50:07PM -0800, Manasi Navare wrote:
> Thanks Jani for reviewing this patch and for your feedback.
> Its very useful feedback and below are some of my comments:
>
> On Fri, Jan 20, 2017 at 05:05:03PM +0200, Jani Nikula wrote:
> > On Fri, 20 Jan 2
:
* Validate the test link rate and lane count as soon as
the request comes (Jani Nikula)
v2:
* Validate the test lane count before using it in
intel_dp_compute_config (Jani Nikula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: D
if it is a 18bpp compliance test request.
Manasi Navare (4):
drm/i915: Add support for DP link training compliance
drm/i915: Fixes to support DP Compliance EDID tests
drm: Add definitions for DP compliance Video pattern tests
drm/i915: Add support for DP Video pattern compliance tests
drivers/gpu
errors
v3:
* Use the updated properly shifted bit definitions (Jani Nikula)
* Force dithering to be disabled on 18bpp compliance
test request (Manasi Navare)
v2:
* Updated the DPCD Register reads based on proper defines in header (Jani
Nikula)
* Squahsed the patch that forced the pipe bpp to compliance
aniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
---
include/drm/drm_dp_helper.h | 57 +
1 file changed, 57 insertions(+)
diff --git a/include/drm/drm_d
d read debugfs data from test_data.edid if its EDID test (Jani NIkula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
---
drive
On Fri, Jan 20, 2017 at 06:27:29PM +0200, Martin Peres wrote:
> On 19/01/17 13:34, Ville Syrjälä wrote:
> >On Wed, Jan 18, 2017 at 11:05:18PM +0200, Martin Peres wrote:
> >>On 16/12/16 15:48, Daniel Vetter wrote:
> >>>On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote:
> The two
Display stream compression is supported on DP 1.4 DP
devices. This patch adds the corersponding DPCD
register definitions for DSC.
v2:
* Rebased on drm-tip
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Paulo Zanoni
eb 03, 2017 at 01:30:14AM +0200, Martin Peres wrote:
> >>>> On 01/02/17 22:05, Manasi Navare wrote:
> >>>>> On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote:
> >>>>>> Jani Nikula <jani.nik...@linux.intel.com> writes:
> >>
n Peres wrote:
> >>>> On 01/02/17 22:05, Manasi Navare wrote:
> >>>>> On Wed, Feb 01, 2017 at 11:58:16AM -0800, Eric Anholt wrote:
> >>>>>> Jani Nikula <jani.nik...@linux.intel.com> writes:
> >>>>>>
> >
Display stream compression is supported on DP 1.4 DP
devices. This patch adds the corersponding DPCD
register definitions for DSC.
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Paulo Zanoni <paulo.r.zan...@intel.com
On Sat, Jan 21, 2017 at 05:16:42PM +0200, Jani Nikula wrote:
> On Sat, 21 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote:
> > This patch series addresses all the review comments from the previous
> > series:
> > https://patchwork.freedesktop.org
On Mon, Jan 23, 2017 at 09:05:02AM -0800, Manasi Navare wrote:
> On Sat, Jan 21, 2017 at 05:16:42PM +0200, Jani Nikula wrote:
> > On Sat, 21 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote:
> > > This patch series addresses all the review comments from th
of interruption from the userspace
app that is polling on that flag.
v2:
* Updated the DPCD Register reads based on proper defines in header (Jani
Nikula)
* Squahsed the patch that forced the pipe bpp to compliance test bpp (Jani
Nikula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc
d read debugfs data from test_data.edid if its EDID test (Jani NIkula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
---
drive
tool, userspace
reads the video pattern values from corresponding debugfs files and fills the
framebuffers and triggers a modeset.
Manasi Navare (4):
drm/i915: Add support for DP link training compliance
drm/i915: Fixes to support DP Compliance EDID tests
drm: Add definitions for DP compliance
v2:
* Add all the other DP Complianec TEST register defs (Jani Nikula)
Cc: dri-devel@lists.freedesktop.org
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
Signed-off-by: Manasi Na
is sent in order
to trigger another modeset during which the pipe is configured
and link is retrained and enabled for link parameters requested
by the test.
v2:
* Validate the test lane count before using it in
intel_dp_compute_config (Jani Nikula)
Signed-off-by: Manasi Navare <manasi.d.
Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic_helper.c | 58 +
include/drm/drm_atomic_helper.h | 1 +
2 files changed, 59 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm
> > On Fri, Oct 21, 2016 at 04:45:39PM -0700, Manasi Navare wrote:
> > > > > This function provides a way for the driver to redo a
> > > > > modeset on the current mode and retry the link training
> > > > > at a lower link rate/lane count/bpp. This
On Mon, Oct 24, 2016 at 08:33:10AM +0200, Daniel Vetter wrote:
> On Sun, Oct 23, 2016 at 11:12:31PM -0700, Manasi Navare wrote:
> > On Mon, Oct 24, 2016 at 08:00:10AM +0200, Daniel Vetter wrote:
> > > On Sat, Oct 22, 2016 at 05:46:30PM +0300, Ville Syrjälä wrote:
> >
.
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
include/drm/drm_connector.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index ac9d7d8..fcf6b97
On Mon, Oct 24, 2016 at 09:12:35AM +0200, Daniel Vetter wrote:
> On Mon, Oct 24, 2016 at 9:00 AM, Manasi Navare
> wrote:
> >> I guess we just need to do some additional work on top to make sure the
> >> vblank ioctl can't see invalid state. Which would then again make u
On Sat, Oct 22, 2016 at 10:48:13AM +0200, Daniel Vetter wrote:
> On Fri, Oct 21, 2016 at 04:45:40PM -0700, Manasi Navare wrote:
> > This work struct will be used to schedule a uevent on a separate
> > thread. This will be scheduled after a link train failure during modeset
On Tue, Oct 25, 2016 at 03:09:39PM +0300, Jani Nikula wrote:
> On Sat, 22 Oct 2016, Manasi Navare wrote:
> > This function provides a way for the driver to redo a
> > modeset on the current mode and retry the link training
> > at a lower link rate/lane count/bpp. This will
.
v2:
* Create a generic work func not i915 specific (Daniel Vetter)
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
include/drm/drm_connector.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/drm
in the mode list
or connector status.
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 32
include/drm/drm_connector.h | 1 +
include
: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 3c2293b..dd0d372 100644
--- a/drivers
in the mode list
or connector status.
v2:
* Make this a default connector property (Daniel Vetter)
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 17
Chris,
Would you be able to make the necessary changes in the suerspace
driver so I can do some testing tomorrow?
Manasi
On Tue, Oct 25, 2016 at 06:16:34PM -0700, Manasi Navare wrote:
> A new optional connector property is added for keeping
> track of whether the link is good (link tr
This defines a helper function to set the property value.
This will be used to set the link status to Bad in case
of link training failures.
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers
at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 17 +
include/drm/drm_connector.h | 4 +++-
include/drm/drm_crtc.h | 5 +
include/uapi/drm/drm_mode.h | 4
Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 11 +++
drivers/gpu/drm/i915/intel_drv.h | 2 ++
2 files changed, 13 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 1063afe..2b6f51c 100644
--- a/drivers/gpu/drm
le Syrjala)
v2:
* Make this a default connector property (Daniel Vetter)
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 17 +
include/drm/drm_c
: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
include/drm/drm_connector.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index ac9d7d8..d499466 100644
--- a/include/drm/drm_connector.h
+++ b
.
In the modeset retry, the modes are validated based on link rate lower than
the failed link rate and link is retrained at lower link rate.
Manasi Navare (7):
drm: Add a link_train_retry field to drm_connector
drm: Define a work struct for scheduling a uevent for modeset retry
drm: Trigger a complete
the pipe at
lower link rate and retrian at lower link rate.
This is also required to pass DP CTS tests 4.3.1.3, 4.3.1.4,
4.3.1.6.
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_ddi.c | 14 ++-
drivers/gpu/drm
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index a60bef8..aae7f82 100644
--- a/drivers/gpu/drm
modeset.
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic_helper.c | 9 +
drivers/gpu/drm/drm_fb_helper.c | 3 ++-
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/drivers
.
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
include/drm/drm_connector.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h
index d499466..9218a24
nctions declared in intel_drv.h (Rodrigo Vivi)
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
Reviewed-by: Mika Kahola
---
drivers/gpu/drm/i915/intel_dp.c | 150
1 file changed, 75 insertions(+), 75 deletions(-)
diff --git a
This is required to return the index of link rate into
common_rates array. This gets used to retry the link
training at lower link rate.
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 15 +++
1 file changed
is sent in order
to trigger another modeset during which the pipe is configured
and link is enabled for link parameters requested by the test.
Signed-off-by: Manasi Navare
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
---
drivers/gpu/drm/i915/intel_dp.c | 72
Manasi
On Tue, Jan 17, 2017 at 02:57:14PM -0800, Manasi Navare wrote:
> v2:
> * Add all the other DP Complianec TEST register defs (Jani Nikula)
> Cc: dri-devel@lists.freedesktop.org
> Cc: Jani Nikula <jani.nik...@linux.intel.com>
> Cc: Daniel Vetter <daniel.vet...@intel.
Hi Jani,
Could you please review this patch?
I have added the lane count checking and other review comments you had.
Is there anything else that is blocking from getting this patch merged?
Regards
Manasi
On Tue, Jan 17, 2017 at 02:57:12PM -0800, Manasi Navare wrote:
> This patch adds supp
Hi Jani,
This is another simple patch that only changed EDID test to
PREFERRED vs STANDARD as per the CTS spec. Is there anything else
that is blocking this patch getting merged?
Regards
Manasi
On Tue, Jan 17, 2017 at 02:57:13PM -0800, Manasi Navare wrote:
> This patch addresses a few iss
Hi Jani,
Could you please review this patch? All your previous review comments
are addressed. Is there anything else that is blocking this patch from getting
merged?
Regards
Manasi
On Tue, Jan 17, 2017 at 02:57:15PM -0800, Manasi Navare wrote:
> The intel_dp_autotest_video_pattern() funct
to be disabled on 18bpp compliance
test request (Manasi Navare)
v2:
* Updated the DPCD Register reads based on proper defines in header (Jani
Nikula)
* Squahsed the patch that forced the pipe bpp to compliance test bpp (Jani
Nikula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani
it in
intel_dp_compute_config (Jani Nikula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
---
drivers/gpu/d
, then we force the dither to be off
so that CRC for the RGB pixels of the rendered video pattern matches the
expected
CRC.
Manasi Navare (4):
drm/i915: Add support for DP link training compliance
drm/i915: Fixes to support DP Compliance EDID tests
drm: Add definitions for DP compliance Video
d read debugfs data from test_data.edid if its EDID test (Jani NIkula)
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
Cc: Jani Nikula <jani.nik...@linux.intel.com>
Cc: Daniel Vetter <daniel.vet...@intel.com>
Cc: Ville Syrjala <ville.syrj...@linux.intel.com>
---
drive
<ville.syrj...@linux.intel.com>
Signed-off-by: Manasi Navare <manasi.d.nav...@intel.com>
---
include/drm/drm_dp_helper.h | 64 +
1 file changed, 64 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 0468135..7ab4
On Fri, Jan 20, 2017 at 05:33:51PM +0200, Jani Nikula wrote:
> On Fri, 20 Jan 2017, Manasi Navare <manasi.d.nav...@intel.com> wrote:
> > v3:
> > * Fix the conventions in bit definitions (Jani Nikula)
> > v2:
> > * Add all the other DP Complianec TEST register def
ing for compliance 18bpp case in
intel_modeset_pipe_config.
Regards
Manasi
On Thu, Jan 19, 2017 at 10:23:38PM -0800, Manasi Navare wrote:
> The intel_dp_autotest_video_pattern() function gets invoked through the
> compliance test handler on a HPD short pulse if the test type is
> set to DP_TEST_V
On Fri, Nov 11, 2016 at 04:08:26PM +0200, Ville Syrjälä wrote:
> On Thu, Nov 10, 2016 at 09:58:31PM +0100, Daniel Vetter wrote:
> > On Wed, Nov 09, 2016 at 08:42:08PM -0800, Manasi Navare wrote:
> > > @@ -5692,6 +5751,39 @@ static bool intel_edp_init_connector(struct
> &
On Fri, Nov 11, 2016 at 11:41:22AM +0200, Jani Nikula wrote:
> On Thu, 10 Nov 2016, Daniel Vetter wrote:
> > On Wed, Nov 09, 2016 at 08:42:08PM -0800, Manasi Navare wrote:
> >> @@ -5692,6 +5751,39 @@ static bool intel_edp_init_connector(struct
> >> intel_dp *int
-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic_helper.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
index 5007796..aeecf2f 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm
status property to BAD. Userspace
should triiger another modeset on a uevent and if link status property
is BAD. This will retrain the link at fallback values.
This is repeated until the link is successfully trained.
This has been validated to pass DP compliance.
Manasi Navare (5):
drm: Add a new
a few patches (Jani Nikula)
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_ddi.c | 21 +-
drivers/gpu/drm/i915/intel_dp.c | 104 +-
drivers/gpu/drm/i915/intel_dp_link_tra
le Syrjala)
v2:
* Make this a default connector property (Daniel Vetter)
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 17 +
include/drm/drm_c
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
Reviewed-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dp.c | 12
drivers/gpu/drm/i915/intel_drv.h | 2 ++
2 files changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i
Nikula)
Cc: Ville Syrjala
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 42
drivers/gpu/drm/i915/intel_drv.h | 6 ++
2 files changed, 48 insertions(+)
diff --git a/drivers/gpu/drm/i915
y
> Cc: Deucher, Alexander ; 'Jani Nikula'
> ; Manasi Navare intel.com>; dri-devel at lists.freedesktop.org; intel-gfx at
> lists.freedesktop.org; Wentland, Harry ; Peres,
> Martin
> Subject: Re: [Intel-gfx] [PATCH 0/5] Handle Link Training Failure during
> modeset
>
> On F
so going to just hide unsupported mode by doing pre-train.
>
> -Original Message-
> From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Monday, November 14, 2016 3:04 AM
> To: Manasi Navare
> Cc: Cheng, Tony ; intel-gfx at lis
anks for the review.
I am already moving Patch 2 set_link_status to the drm core as
per Daniel and Ville's suggestion. I will make those changes
and submit the new patches by EOD today.
Regards
Manasi
> On 2016-11-09 11:42 PM, Manasi Navare wrote:
> >Link training failure is handled by low
le Syrjala)
v2:
* Make this a default connector property (Daniel Vetter)
Reviewed-by: Harry Wentland
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connec
handle link training failures,
but it is not limited to DP or link training. For example, if we
implement asynchronous setcrtc, we can use this to report any failures
in that.
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
d link_status
to indicate same thing (Jani Nikula)
v2:
* Squashed a few patches (Jani Nikula)
Acked-by: Tony Cheng
Acked-by: Harry Wentland
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_ddi.c | 21 +-
drivers
: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic_helper.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
index 5007796..aeecf2f 100644
--- a/drivers/gpu/drm
Nikula)
Acked-by: Tony Cheng
Acked-by: Harry Wentland
Cc: Ville Syrjala
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 42
drivers/gpu/drm/i915/intel_drv.h | 6 ++
2 files changed, 48
ser experience on link
training failures, by avoiding black screens.
Acked-by: Tony Cheng
Acked-by: Harry Wentland
Manasi Navare (5):
drm: Add a new connector property for link status
drm: Set DRM connector link status property
drm/i915: Update CRTC state if connector link status property changed
property.
Manasi
On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote:
> In the usual working scenarios, this property is "Good".
> If something fails during modeset, the DRM driver can
> set the link status to "Bad", prune the mode list based on the
> link
On Tue, Nov 15, 2016 at 08:49:21AM +0100, Daniel Vetter wrote:
> On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote:
> > In the usual working scenarios, this property is "Good".
> > If something fails during modeset, the DRM driver can
> > set the link
On Tue, Nov 15, 2016 at 08:53:27AM +0100, Daniel Vetter wrote:
> On Mon, Nov 14, 2016 at 07:13:20PM -0800, Manasi Navare wrote:
> > In the usual working scenarios, this property is "Good".
> > If something fails during modeset, the DRM driver can
> > set the link
el Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 36
include/drm/drm_connector.h | 2 ++
2 files changed, 38 insertions(+)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
in
Manasi
On Mon, Nov 14, 2016 at 07:13:22PM -0800, Manasi Navare wrote:
> If link training fails, then we need to fallback to lower
> link rate first and if link training fails at RBR, then
> fallback to lower lane count.
> This function finds the next lower link rate/lane count
> v
Jani/Ville could you please review this patch?
This has been ACKed by DRM and is good from DRM point fo view.
But I need r-b from either of you for this to get merged.
Regards
Manasi
On Mon, Nov 14, 2016 at 07:13:23PM -0800, Manasi Navare wrote:
> If link training at a link rate opti
I need to explicitly
add this subsection in Documentation/gpu/drm-kms.rst file?
Other than that looks good.
Manasi
Reviewed-by: Manasi Navare
> Cc: Manasi Navare
> Signed-off-by: Daniel Vetter
> ---
> drivers/gpu/drm/drm_connector.c | 42
> +++
On Thu, Nov 17, 2016 at 02:58:46PM +0200, Jani Nikula wrote:
> On Tue, 15 Nov 2016, Manasi Navare wrote:
> > If link training fails, then we need to fallback to lower
> > link rate first and if link training fails at RBR, then
> > fallback to lower lane count.
> > T
On Thu, Nov 17, 2016 at 02:29:30PM +0200, Jani Nikula wrote:
> On Tue, 15 Nov 2016, Manasi Navare wrote:
> > Submitting new series that adds proper commit messages/cover letter
> > and kernel documentation. It also moved the set_link_status function
> > to drm core so oth
On Thu, Nov 17, 2016 at 02:49:02PM +0200, Jani Nikula wrote:
> On Tue, 15 Nov 2016, Manasi Navare wrote:
> > If link training at a link rate optimal for a particular
> > mode fails during modeset's atomic commit phase, then we
> > let the modeset complete and then retry.
On Thu, Nov 17, 2016 at 06:03:48PM -0800, Dhinakaran Pandiyan wrote:
> The avail_slots member in struct drm_dp_mst_topology_mgr does not really
> track the available time slots in a MTP(Multi-Stream Transport Packet). It
> is assigned an initial value when the topology manager is setup but not
>
>
> I typed this to give Manasi a place to add her new link status
> property documentation.
>
> v2: forgot to git add all the bits (Manasi).
>
> v3: Be more epxlicit about integrated tiled panels (Archit)
>
Reviewed-by: Manasi Navare
> Cc: Manasi Navare
>
: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_atomic_helper.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_helper.c
b/drivers/gpu/drm/drm_atomic_helper.c
index 0b16587..2125fd1 100644
--- a/drivers/gpu/drm
failures
in that.
Finally, while DP CTS compliance is advertized (which is great, and
could be made to work similarly for all drm drivers), this can be used
for the more important goal of improving user experience on link
training failures, by avoiding black screens.
Manasi Navare (5):
drm: Add a new
that using the helper intel_dp_link_rate_index (Jani Nikula)
v2:
Squash the patch that returns the link rate index (Jani Nikula)
Acked-by: Tony Cheng
Acked-by: Harry Wentland
Cc: Ville Syrjala
Cc: Jani Nikula
Cc: Daniel Vetter
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c
ked-by: Harry Wentland
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 63 ++-
drivers/gpu/drm/i915/intel_dp_link_training.c | 28 +++-
drivers/gpu/drm/i915/intel_drv.h
etter)
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/drm_connector.c | 37 +
include/drm/drm_connector.h | 2 ++
2 files changed, 39 insertions(+)
diff --git a/drivers/gpu/drm/drm_c
to store property value locally
(Ville Syrjala)
v2:
* Make this a default connector property (Daniel Vetter)
Reviewed-by: Harry Wentland
Cc: dri-devel at lists.freedesktop.org
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Cc: Chris Wilson
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/d
-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 40
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 44 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 90283ed..4fb89e1 100644
a few patches (Jani Nikula)
Acked-by: Tony Cheng
Acked-by: Harry Wentland
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Ville Syrjala
Signed-off-by: Manasi Navare
---
drivers/gpu/drm/i915/intel_dp.c | 63 ++-
drivers/gpu/drm/i915/intel_dp_link_tr
1 - 100 of 681 matches
Mail list logo