[PATCH v2 1/3] drm: Move EXPORT_SYMBOL so that it immediately follows its function

EXPORT_SYMBOL(foo) should immediately follow its function/variable. This coding style is preferred. Found by checkpath.pl. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/g

[PATCH v3 1/4] drm/agpsupport: Replace "foo * bar" with "foo *bar"

This replaces all instances of foo * bar with foo *bar in drm_agpsupport.c. This is so that it adheres to standard C syntax for pointers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v3: -None drivers/gpu/drm/drm_agpsupport.c | 10 +- 1 file c

[PATCH v3 2/4] drm/agpsupport: Remove assignment in if condition

Move the assignment so that it happens before the if condition. Merged multiple similar conditionals to a single conditional statement. This results in syntax which is easier to read. Found by checkpath.pl Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes

[PATCH v3 0/4] drm/agpsupport: Code cleanup

-Included merging conditionals in "Remove assignment in if condition" in the commit message Meghana Madhyastha (4): drm/agpsupport: Replace "foo * bar" with "foo *bar" drm/agpsupport: Remove assignment in if condition drm/agpsupport: Move EXPORT_SYMBOL so that

[PATCH v3 4/4] drm/agpsupport: Remove extra blank line

Remove extra blank line to adhere to standard coding style. Found by checkpath.pl.. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v3: -This was part of another commit in v2 and v1. Now made this a separate commit drivers/gpu/drm/drm_agpsupport.c |

[PATCH v3 3/4] drm/agpsupport: Move EXPORT_SYMBOL so that it immediately follows its function

EXPORT_SYMBOL(foo) should immediately follow its function/variable. This coding style is preferred. Found by checkpath.pl. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v3: -Split this commit into two commits and made another commit for removing the

[PATCH v2 0/3] drm: Code cleanup

These patches fix the checkpath warnings and errors in drm_agpsupport.c changes in v2: -Changed the commit subject prefix to follow the style used in drm. -Combine multiple redundant if conditions to a single condition in patch 3. Meghana Madhyastha (3): drm: Move EXPORT_SYMBOL so

[PATCH v2 2/3] drm: Replace "foo * bar" with "foo *bar"

This replaces all instances of foo * bar with foo *bar in drm_agpsupport.c. This is so that it adheres to standard C syntax for pointers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 10 +- 1 file changed, 5 insertions

[PATCH v2 3/3] drm: Remove assignment in if condition

Move the assignment so that it happens before the if condition. This results in syntax which is easier to read. Found by checkpath.pl Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/drm_agpsupport.c | 31 ++- 1 file chang

[PATCH] drm/tinydrm: Move backlight helpers to a separate file

Move backlight helpers from tinydrm-helpers.c to tinydrm-backlight.c Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/tinydrm/core/Makefile| 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-backlight.c | 103 +++ drivers/g

[PATCH] drm/amdgpu: Replace ref/unref with get/put

Replace functions with reference/unreference suffix with get/put suffix. Get/put is shorter and more consistent with the kernel function suffixes. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 4 ++-- drivers/gpu/d

[PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v2: -Improved commit message by explaining why the changes were made. drivers/gpu/drm/tinydrm/core/Makefile| 2 +- drivers/gpu/drm/tinydrm/core/tinydrm-backlight.c | 103 +++ drivers/g

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Tue, Oct 03, 2017 at 07:38:29PM +0200, Noralf Trønnes wrote: > > Den 03.10.2017 18.02, skrev Noralf Trønnes: > > > >Den 03.10.2017 16.58, skrev Noralf Trønnes: > >> > >>Den 02.10.2017 10.13, skrev Jani Nikula: > >>>On Mon, 02 Oct 2017, Daniel Vetter wrote: > Also adding

[PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v13: -Add backlight_put to backlight.h in this patch drivers/gpu/drm/tinydrm/core/t

[PATCH v13 3/3] drm/tinydrm: Add devres versions of backlight_get

Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v13: -Add devm_backlight_put to backlight.c drivers/g

[PATCH v8 3/3] drm/tinydrm: Add devres versions of backlight_get

Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v8: -Put the devres version to backlight.c along with backlig

[PATCH v8 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v8: -This patch was not p

[PATCH v8 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v8: -Changed the name of the tinydrm_of_find_backlight to backlight_get and

[PATCH v8 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

. Meghana Madhyastha (3): drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c drm/tinydrm: Add devres versions of backlight_get drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 95 -- drivers

[PATCH v10 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v10: -Change from enable_bac

[PATCH v11 3/3] drm/tinydrm: Add devres versions of backlight_get

Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v11: -None drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- d

[PATCH v10 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

Move drm helper functions from tinydrm-helpers to linux/backlight for ease of use by callers in other drivers. Changes in v10: -Change enable_backlight to backlight_enable Meghana Madhyastha (3): drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h drm/tinydrm: Move

[PATCH v11 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v11: -Move over tinydrm_disable_bac

[PATCH v11 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v11: -None drivers/gpu/drm/tinydrm/core/tinydrm-helpers.

[PATCH v10 3/3] drm/tinydrm: Add devres versions of backlight_get

Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v10: -None drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- d

[PATCH v11 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

Move drm helper functions from tinydrm-helpers to linux/backlight for ease of use by callers in other drivers. Changes in v11: -Move over tinydrm_disable_backlight to backlight_disable in the caller in mipi-dbi.c Meghana Madhyastha (3): drm/tinydrm: Move helper functions from tinydrm-helpers

[PATCH v10 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v10: -None drivers/gpu/drm/tinydrm/core/tinydrm-helpers.

[PATCH v12 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

enabled Meghana Madhyastha (3): drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c drm/tinydrm: Add devres versions of backlight_get drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 95

[PATCH v12 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v12: -None drivers/gpu/drm/tinydr

[PATCH v12 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v12: -Move backlight_put() to the patch 2/3 from patch 3/3. -Remove #if IS_E

[PATCH v12 3/3] drm/tinydrm: Add devres versions of backlight_get

Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v12: -Move backlight_put() to the patch 2/3 from pat

[PATCH v13 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v13: -None drivers/gpu/drm/tinydr

[PATCH v13 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

Move drm helper functions from tinydrm-helpers to linux/backlight for ease of use by callers in other drivers. Changes in v13: -Rebase against drm-misc -Put devm_backlight_put back Meghana Madhyastha (3): drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h drm/tinydrm

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

On Tue, Sep 26, 2017 at 01:32:15PM +0200, Daniel Vetter wrote: > On Tue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: > > On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: > > > > > > Den 25.09.2017 16.56, skrev Noralf

Re: [PATCH v3 2/2] drm/tinydrm: Add devres versions of drm_of_find_backlight

On Fri, Sep 29, 2017 at 02:20:16PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 05.17, skrev Meghana Madhyastha: > >On Thu, Sep 28, 2017 at 06:19:35PM +0200, Noralf Trønnes wrote: > >>Den 28.09.2017 11.15, skrev Meghana Madhyastha: > >>>Add devm_drm_of_fin

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 05.22, skrev Meghana Madhyastha: > >On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: > >>Den 28.09.2017 16.08, skrev Daniel Vetter: > >>>On Thu, Sep 28, 2017 at 02:

[PATCH v5 3/4] drm/tinydrm: Add the dummy versions of drm_of_find_backlight functions

Add the dummy versions (function definition returning -EINVAL) of drm_of_find_backlight and devm_drm_of_find_backlight in the #else part of the conditional directive in drm_of.h. This is needed for drivers where CONFIG_OF is optional. Signed-off-by: Meghana Madhyastha <meghana.madh

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 05:41:04PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 16.13, skrev Meghana Madhyastha: > >On Fri, Sep 29, 2017 at 02:33:12PM +0200, Noralf Trønnes wrote: > >>Den 29.09.2017 14.20, skrev Meghana Madhyastha: > >>>On Fri, Sep 29, 2017 at

[PATCH v6 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v6: -Move function declarations to linux/backlight.h to resolve module dependency issues. drivers/gpu/drm/drm_of.c | 44 ++ d

[PATCH v6 2/2] drm/tinydrm: Add devres versions of drm_of_find_backlight

Add devm_drm_of_find_backlight and the corresponding release function because some drivers such as tinydrm use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v6: - Remove doc

[PATCH v6 0/2] drm/tinydrm: drm_of_find_backlight helper

as it is an internal function. Meghana Madhyastha (2): drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c drm/tinydrm: Add devres versions of drm_of_find_backlight drivers/gpu/drm/drm_of.c | 84 ++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c

[PATCH v5 4/4] drm/tinydrm: select BACKLIGHT_LCD_SUPPORT, BACKLIGHT_CLASS_DEVICE

Add select BACKLIGHT_LCD_SUPPORT, BACKLIGHT_CLASS_DEVICE to the Kconfig of drm. This is required for the successful build of drm_of_find_backlight helpers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v5: -This commit was not present in v4. Sel

[PATCH v5 2/4] drm/tinydrm: Add devres versions of drm_of_find_backlight

Add devm_drm_of_find_backlight and the corresponding release function because some drivers such as tinydrm use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v5: -None drivers/gpu/drm/dr

[PATCH v5 1/4] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v5: -None drivers/gpu/drm/drm_of.c | 44 ++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 --- drive

[PATCH v5 0/4] drm/tinydrm: drm_of_find_backlight helper

This patchset introduces some changes such as move tinydrm_of_find_backlight to drm_of.c and rename it to drm_of_find_backlight for better organizational structure. Changes in v5: -Fix kbuild errors and warnings Meghana Madhyastha (4): drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

Re: [PATCH v6 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Sat, Sep 30, 2017 at 09:04:57PM +0200, Noralf Trønnes wrote: > > Den 30.09.2017 19.12, skrev Meghana Madhyastha: > >Rename tinydrm_of_find_backlight to drm_of_find_backlight > >and move it into drm_of.c from tinydrm-helpers.c. This is > >because other drivers in the

[PATCH v7 2/3] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v7: -Move function declarations back to drm_of.h drivers/gpu/drm/drm_of.c | 45 ++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.

[PATCH v7 3/3] drm/tinydrm: Add devres versions of drm_of_find_backlight

Add devm_drm_of_find_backlight and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v7: -None drivers/gpu/drm/drm_of.c

[PATCH v7 1/3] backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE)

Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) as part of the if directive for the function declaration of of_find_backlight_by_node in order to avoid module dependency errors. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v7: -This patch did not exist

Re: [PATCH v6 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Sun, Oct 01, 2017 at 03:26:36PM +0200, Noralf Trønnes wrote: > > Den 01.10.2017 06.14, skrev Meghana Madhyastha: > >On Sat, Sep 30, 2017 at 09:04:57PM +0200, Noralf Trønnes wrote: > >>Den 30.09.2017 19.12, skrev Meghana Madhyastha: > >>>Rename tinydrm_of_find_b

[PATCH v7 0/3] drm/tinydrm: drm_of_find_backlight helper

errors. Meghana Madhyastha (3): backlight: Add IS_ENABLED(CONFIG_BACKLIGHT_CLASS_DEVICE) drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c drm/tinydrm: Add devres versions of drm_of_find_backlight drivers/gpu/drm/drm_of.c | 85

Re: [PATCH v6 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Sun, Oct 01, 2017 at 04:47:26PM +0200, Noralf Trønnes wrote: > > Den 01.10.2017 15.34, skrev Meghana Madhyastha: > >On Sun, Oct 01, 2017 at 03:26:36PM +0200, Noralf Trønnes wrote: > >>Den 01.10.2017 06.14, skrev Meghana Madhyastha: > >>>On Sat, Sep 30, 2017 at

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Fri, Sep 29, 2017 at 02:33:12PM +0200, Noralf Trønnes wrote: > > Den 29.09.2017 14.20, skrev Meghana Madhyastha: > >On Fri, Sep 29, 2017 at 02:10:31PM +0200, Noralf Trønnes wrote: > >>Den 29.09.2017 05.22, skrev Meghana Madhyastha: > >>>On Thu, Sep 28, 2017 at

[PATCH v4 2/3] drm/tinydrm: Add devres versions of drm_of_find_backlight

Add devm_drm_of_find_backlight and the corresponding release function because some drivers such as tinydrm use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v4: -Made the release function an in

[PATCH v4 3/3] drm/tinydrm: Add the dummy versions of drm_of_find_backlight functions

Add the dummy versions (function definition returning -EINVAL) of drm_of_find_backlight and devm_drm_of_find_backlight in the #else part of the conditional directive in drm_of.h. This is needed for drivers where CONFIG_OF is optional. Signed-off-by: Meghana Madhyastha <meghana.madh

[PATCH v4 0/3] drm/tinydrm: drm_of_find_backlight helper

n internal function. - Add dummy versions of drm_of_backlight functions. Meghana Madhyastha (3): drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c drm/tinydrm: Add devres versions of drm_of_find_backlight drm/tinydrm: Add the dummy versions of drm_of_find_backlight functions drive

[PATCH v4 1/3] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v4: -None drivers/gpu/drm/drm_of.c | 44 ++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 --- drive

Re: [PATCH v3 2/2] drm/tinydrm: Add devres versions of drm_of_find_backlight

On Thu, Sep 28, 2017 at 06:19:35PM +0200, Noralf Trønnes wrote: > > Den 28.09.2017 11.15, skrev Meghana Madhyastha: > >Add devm_drm_of_find_backlight and the corresponding release > >function because some drivers such as tinydrm use devres versions > >of functions for re

Re: [PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Thu, Sep 28, 2017 at 06:02:27PM +0200, Noralf Trønnes wrote: > > Den 28.09.2017 16.08, skrev Daniel Vetter: > >On Thu, Sep 28, 2017 at 02:44:34PM +0530, Meghana Madhyastha wrote: > >>Rename tinydrm_of_find_backlight to drm_of_find_backlight > >>and move it into d

Re: [PATCH] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Thu, Sep 28, 2017 at 11:38:36AM +0200, Daniel Vetter wrote: > On Thu, Sep 28, 2017 at 11:27 AM, Meghana Madhyastha > <meghana.madhyas...@gmail.com> wrote: > > On Thu, Sep 28, 2017 at 09:15:39AM +0200, Daniel Vetter wrote: > >> On Wed, Sep 27, 2017 at 05:08:07PM

[PATCH v2 1/3] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v2: -Added note about it being the callers responsibility to call put_device. drivers/gpu/drm/drm_of.c | 44 ++ drivers/gpu/drm/t

[PATCH v2 2/3] drm/tinydrm: Call drm_of_find_backlight instead of tinydrm_of_find_backlight

Call drm_of_find_backlight from of_drm.c as the function has been renamed and moved. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v2: -Introduce this as a separate patch in a patchset instead of combining it with the previous changes. drivers/gpu/drm/t

[PATCH v2 3/3] drm/tinydrm: Add devres versions of drm_of_find_backlight

Add devm_drm_of_find_backlight and the corresponding release function because some drivers such as tinydrm use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v2: -This was not present in the i

[PATCH v3 1/2] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v3: -Change it back to a single patch from two patches in v2 drivers/gpu/drm/drm_of.c | 44 ++ drivers/gpu/drm/tinydrm/core/t

Re: [PATCH] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

On Thu, Sep 28, 2017 at 09:15:39AM +0200, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 05:08:07PM +0200, Noralf Trønnes wrote: > > > > Den 27.09.2017 15.54, skrev Meghana Madhyastha: > > > Rename tinydrm_of_find_backlight to drm_of_find_backlight > > > and m

[PATCH v3 0/2] drm/tinydrm: drm_of_find_backlight helper

. Meghana Madhyastha (2): drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c drm/tinydrm: Add devres versions of drm_of_find_backlight drivers/gpu/drm/drm_of.c | 92 ++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 --- drivers

[PATCH v3 2/2] drm/tinydrm: Add devres versions of drm_of_find_backlight

Add devm_drm_of_find_backlight and the corresponding release function because some drivers such as tinydrm use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v3: -None drivers/gpu/drm/drm_of.

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: > > Den 25.09.2017 16.56, skrev Noralf Trønnes: > >Hi Meghana, > > > > > >Den 22.09.2017 17.09, skrev Meghana Madhyastha: > >>Move backlight helpers from tinydrm-helpers.c to &

[PATCH v2 0/3] drm/tinydrm: drm_of_find_backlight helper

caller having to call put_device Meghana Madhyastha (3): drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c drm/tinydrm: Call drm_of_find_backlight instead of tinydrm_of_find_backlight drm/tinydrm: Add devres versions of drm_of_find_backlight drivers/gpu/drm/drm_of.c

Re: [PATCH v8 3/3] drm/tinydrm: Add devres versions of backlight_get

On Wed, Oct 11, 2017 at 04:56:25PM +0300, Jani Nikula wrote: > On Wed, 11 Oct 2017, Meghana Madhyastha <meghana.madhyas...@gmail.com> wrote: > > Add devm_backlight_get and the corresponding release > > function because some drivers use devres versions of functions >

[PATCH v9 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

Move drm helper functions from tinydrm-helpers to linux/backlight for ease of use by callers in other drivers. Changes in v9: -Change function name from devm_backlight_get_release to devm_backlight_put because it is more apt name. Meghana Madhyastha (3): drm/tinydrm: Move helper functions from

[PATCH v9 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to backlight_get and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v9: -None drivers/gpu/drm/tinydrm/core/tinydrm-helpers.

[PATCH v9 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v9: -None drivers/gpu/drm/tinydr

[PATCH v9 3/3] drm/tinydrm: Add devres versions of backlight_get

Add devm_backlight_get and the corresponding release function because some drivers use devres versions of functions for requiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v9: -Change function name from devm_backlight_get_r

[PATCH] drm/Documentation: Refine TODO for backlight helpers in tinydrm

Add a summary which resulted from discussions on what should be done to refactor backlight helpers in tinydrm so that they can be used in other drivers as well. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Documentation/gpu/todo.rst | 11 ++- 1 file chang

Re: [PATCH v2] drm/tinydrm: Move backlight helpers to a separate file

ue, Sep 26, 2017 at 04:46:53PM +0530, Meghana Madhyastha wrote: > > > > > On Mon, Sep 25, 2017 at 06:31:58PM +0200, Noralf Trønnes wrote: > > > > > > Den 25.09.2017 16.56, skrev Noralf Trønnes: > > > > > > > Hi Meghana, > > > > >

Re: [PATCH] drm/Documentation: Refine TODO for backlight helpers in tinydrm

On Wed, Sep 27, 2017 at 02:32:16PM +0200, Daniel Vetter wrote: > On Wed, Sep 27, 2017 at 04:21:23PM +0530, Meghana Madhyastha wrote: > > Add a summary which resulted from discussions on what should > > be done to refactor backlight helpers in tinydrm so that > > they can be

[PATCH] drm/tinydrm: Move tinydrm_of_find_backlight into drm_of.c

along with the other _of.c functions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/drm_of.c | 41 ++ drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 40 - drivers/gpu/drm/t

Re: [Outreachy kernel] [PATCH v13 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

On Mon, Oct 16, 2017 at 02:26:00PM -0400, Sean Paul wrote: > On Fri, Oct 13, 2017 at 6:42 PM, Noralf Trønnes <nor...@tronnes.org> wrote: > > > > Den 13.10.2017 22.25, skrev Sean Paul: > >> > >> On Fri, Oct 13, 2017 at 04:11:43PM +0530, Megha

Re: [PATCH v14 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

On Sat, Dec 09, 2017 at 03:09:28PM +0100, Noralf Trønnes wrote: > > Den 21.10.2017 13.55, skrev Meghana Madhyastha: > >Changes in v14: > >- s/backlight_get/of_find_backlight/ in patch 2/3 > >- Change commit message in patch 3/3 from requiring to acquiring > > > &

Re: [PATCH v14 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

On Mon, Dec 11, 2017 at 03:12:06PM +0100, Noralf Trønnes wrote: > > Den 11.12.2017 14.17, skrev Meghana Madhyastha: > >On Sat, Dec 09, 2017 at 03:09:28PM +0100, Noralf Trønnes wrote: > >>Den 21.10.2017 13.55, skrev Meghana Madhyastha: > >>>Changes in v14: > &g

Re: [Outreachy kernel] [PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

On Tue, Oct 24, 2017 at 06:45:34PM +0200, Noralf Trønnes wrote: > > Den 24.10.2017 17.42, skrev Sean Paul: > >On Sat, Oct 21, 2017 at 05:27:33PM +0530, Meghana Madhyastha wrote: > >>Rename tinydrm_of_find_backlight to of_find_backlight and move > >>it to linux/back

[PATCH v14 3/3] drm/tinydrm: Add devres versions of of_find_backlight

Add devm_of_find_backlight and the corresponding release function because some drivers use devres versions of functions for acquiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v14: - s/devm_backlight_get/devm_of_find_backlight/ -

[PATCH v14 2/3] drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c

Rename tinydrm_of_find_backlight to of_find_backlight and move it to linux/backlight.c so that it can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v14: -s/backlight_get/of_find_backlight/ drivers/gpu/drm/tinydrm/core/t

[PATCH v14 1/3] drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h

Move the helper functions enable_backlight and disable_backlight from tinydrm-helpers.c to backlight.h as static inline functions so that they can be used by other drivers. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v14: - None drivers/gpu/drm/tinydr

[PATCH v14 0/3] Move backlight helper functions from tinydrm-helpers to linux/backlight

Changes in v14: - s/backlight_get/of_find_backlight/ in patch 2/3 - Change commit message in patch 3/3 from requiring to acquiring Meghana Madhyastha (3): drm/tinydrm: Move helper functions from tinydrm-helpers to backlight.h drm/tinydrm: Move tinydrm_of_find_backlight to backlight.c drm

[PATCH v16 05/10] video: backlight: Add devres versions of of_find_backlight

Add devm_of_find_backlight and the corresponding release function because some drivers use devres versions of functions for acquiring device resources. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/video/backlight/backlight.

[PATCH v16 04/10] drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight

Remove tinydrm_of_find_backlight from tinydrm-helpers.c. We now have a generic of_find_backlight defined in backlight.c. Let the callers of tinydrm_of_find_backlight call of_find_backlight. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/tinydrm/core/t

[PATCH v16 03/10] video: backlight: Add of_find_backlight helper in backlight.c

Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- Changes in v16: -Add comment about brig

[PATCH v16 07/10] drm/panel: Use backlight_enable/disable helpers

Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/panel/panel-innolux-p079zca.c

[PATCH v16 06/10] drm/tinydrm: Call devres version of of_find_backlight

Call devm_of_find_backlight (the devres version) instead of of_find_backlight. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/d

[PATCH v16 02/10] drm/tinydrm: Convert tinydrm_enable/disable_backlight to backlight_enable/disable

Remove tinydrm_enable/disable_backlight and let the callers call the more generic backlight_enable/disable helpers Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c | 55 -- drivers/gpu/drm/tinydr

[PATCH v16 10/10] drm/omapdrm: Use of_find_backlight helper

Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 10 +++--- 1 file changed, 3 insertions(+), 7 del

[PATCH v16 00/10] Add backlight helper functions

Move drm helper functions from tinydrm-helpers to linux/backlight for ease of use by callers in other drivers. Changes in v16: -Add a comment about setting brightness = max_brightness in of_find_backlight -Add dri-devel and linux-kernel mailing lists Meghana Madhyastha (10): video: backlight

[PATCH v16 01/10] video: backlight: Add helpers to enable and disable backlight

-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- include/linux/backlight.h | 30 ++ 1 file changed, 30 insertions(+) diff --git a/include/linux/backlight.h b/include/linux/backlight.h index af7003548..7b6a9a2a3 100644 --- a/include/linux/backlight.h

[PATCH v16 08/10] drm/omapdrm: Use backlight_enable/disable helpers

Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/omapdrm/displays/panel-dpi.

[PATCH v16 09/10] drm/panel: Use of_find_backlight helper

Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- drivers/gpu/drm/panel/panel-innolux-p079zca.c | 10 +++--- drivers/gpu/drm/panel/panel

[PATCH v17 03/10] video: backlight: Add of_find_backlight helper in backlight.c

Add of_find_backlight, a helper function which is a generic version of tinydrm_of_find_backlight that can be used by other drivers to avoid repetition of code and simplify things. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- changes in v17: -rebase with drm-mis

[PATCH v17 10/10] drm/omapdrm: Use of_find_backlight helper

Replace of_find_backlight_by_node and of the code around it with of_find_backlight helper to avoid repetition of code. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- changes in v17: -remove put_device() to avoid double put as we are using the devm version drivers/g

[PATCH v17 07/10] drm/panel: Use backlight_enable/disable helpers

Use backlight_enable/disable helpers instead of changing the property and calling backlight_update_status for cleaner and simpler code and also to avoid repetitions. Signed-off-by: Meghana Madhyastha <meghana.madhyas...@gmail.com> --- changes in v17: -remove redundant NULL check drivers/g

  1   2   >