Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-05 Thread Michael Nazzareno Trimarchi
0 > > > > [1.920576] sun4i_dclk_recalc_rate: val = 1, rate = 17820 > > > > [1.920597] rate = 17820 > > > > [1.920599] parent_rate = 29700 > > > > [1.920602] reg = 0x90c0 > > > > [1.9

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-11 Thread Michael Nazzareno Trimarchi
Hi On Thu, Jul 11, 2019 at 7:43 PM Michael Nazzareno Trimarchi wrote: > > Hi Maxime > > On Thu, Jul 11, 2019 at 2:23 PM Maxime Ripard > wrote: > > > > On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote: > > > On Wed, Jul 3, 2019 at

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-11 Thread Michael Nazzareno Trimarchi
Hi Maxime On Thu, Jul 11, 2019 at 2:23 PM Maxime Ripard wrote: > > On Fri, Jul 05, 2019 at 07:52:27PM +0200, Michael Nazzareno Trimarchi wrote: > > On Wed, Jul 3, 2019 at 1:49 PM Maxime Ripard > > wrote: > > > > > > On Tue, Jun 25, 2019 at 09:00:36PM +05

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-08-15 Thread Michael Nazzareno Trimarchi
Hi Maxime On Tue, Aug 13, 2019 at 8:05 AM Maxime Ripard wrote: > > On Mon, Jul 29, 2019 at 08:59:04AM +0200, Michael Nazzareno Trimarchi wrote: > > Hi > > > > On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard > > wrote: > > > > > > On Mon, Ju

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-08-28 Thread Michael Nazzareno Trimarchi
Hi Maxime On Wed, Aug 28, 2019 at 3:03 PM Maxime Ripard wrote: > > Hi, > > On Thu, Aug 15, 2019 at 02:25:57PM +0200, Michael Nazzareno Trimarchi wrote: > > On Tue, Aug 13, 2019 at 8:05 AM Maxime Ripard > > wrote: > > > On Mon, Jul 29, 2019 at 08:59:04AM +

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-08-02 Thread Michael Nazzareno Trimarchi
Hi Maxime On Mon, Jul 29, 2019 at 8:59 AM Michael Nazzareno Trimarchi wrote: > > Hi > > On Wed, Jul 24, 2019 at 11:05 AM Maxime Ripard > wrote: > > > > On Mon, Jul 22, 2019 at 03:51:04PM +0530, Jagan Teki wrote: > > > Hi Maxime, > > > > &

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-29 Thread Michael Nazzareno Trimarchi
7PM +0530, Jagan Teki wrote: > > > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard > > > > wrote: > > > > > > > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi > > > > > wrote: > > > > >

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-20 Thread Michael Nazzareno Trimarchi
Hi On Sat, Jul 20, 2019 at 11:32 AM Maxime Ripard wrote: > > On Sat, Jul 20, 2019 at 12:46:27PM +0530, Jagan Teki wrote: > > On Sat, Jul 20, 2019 at 12:28 PM Maxime Ripard > > wrote: > > > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trim

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-20 Thread Michael Nazzareno Trimarchi
Hi On Sat., 20 Jul. 2019, 8:58 am Maxime Ripard, wrote: > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi > wrote: > > > > tcon-pixel clock is the rate that you want to achive on display side > > > > and if you have 4 lanes 32bit or

Re: [PATCH v6 11/22] clk: sunxi-ng: a64: Add minimum rate for PLL_MIPI

2019-07-22 Thread Michael Nazzareno Trimarchi
> > > wrote: > > > > > > > > On Thu, Jul 11, 2019 at 07:43:16PM +0200, Michael Nazzareno Trimarchi > > > > wrote: > > > > > > > tcon-pixel clock is the rate that you want to achive on display > > > > > > > si

Re: [PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-01-21 Thread Michael Nazzareno Trimarchi
On Wed, Jan 20, 2021 at 12:29 PM Jagan Teki wrote: > > On Wed, Jan 20, 2021 at 4:55 PM Michael Nazzareno Trimarchi > wrote: > > > > Hi Jagan > > > > On Wed, Jan 20, 2021 at 12:22 PM Jagan Teki > > wrote: > > > > > > SN65DSI84 is a Sin

Re: [PATCH 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-01-21 Thread Michael Nazzareno Trimarchi
gt;dsi_lanes = len / sizeof(u32); > + if (sn->dsi_lanes < 1 || sn->dsi_lanes > 4) > + return -EINVAL; > + > + sn->host_node = of_graph_get_remote_node(dev->of_node, 0, 0); > + if (!sn->host_node) > + return -ENODEV; > + > +

Re: [PATCH v2 2/2] drm: bridge: Add SN65DSI84 DSI to LVDS bridge

2021-02-04 Thread Michael Nazzareno Trimarchi
return -EINVAL; > + > + sn->host_node = of_graph_get_remote_node(dev->of_node, 0, 0); > + if (!sn->host_node) > + return -ENODEV; > + > + of_node_put(sn->host_node); > + > + return 0; > +} > + > +static int sn65ds

Re: [PATCH] drm/bridge: dw-mipi-dsi: Find the possible DSI devices

2021-10-11 Thread Michael Nazzareno Trimarchi
TR_ERR(bridge); > > + dsi->device_found = true; > > } > > > > - dsi->panel_bridge = bridge; > > - > > - drm_bridge_add(>bridge); > > - > > if (pdata->host_ops && pdata->host_ops->attach) { >

Re: [RFC PATCH] drm/panel: ilitek-ili9881d: add support for Wanchanglong W552946ABA panel

2021-10-16 Thread Michael Nazzareno Trimarchi
de_flags = MIPI_DSI_MODE_VIDEO_SYNC_PULSE; > > + dsi->mode_flags = ctx->desc->mode_flags; > > dsi->format = MIPI_DSI_FMT_RGB888; > > dsi->lanes = 4; > > > > @@ -691,17 +916,28 @@ static const struct ili9881c_desc lhr050h41_de

Re: [PATCH 5/5] drm/bridge: dw-mipi-dsi: Fix dsi registration during drm probing

2021-10-16 Thread Michael Nazzareno Trimarchi
ret = PTR_ERR(dmd); > > The memory pointed to by dmd is allocated in dw_mipi_dsi_probe(), but > the pointer is not saved here. > We rely on the attach operation to save the dmd pointer. > > > In other words - the attach operation must be called before we call > dw_mipi_dsi_rock

Re: [PATCH 5/5] drm/bridge: dw-mipi-dsi: Fix dsi registration during drm probing

2021-10-16 Thread Michael Nazzareno Trimarchi
wn call chains... */ if (dsi->panel_bridge->funcs->post_disable) dsi->panel_bridge->funcs->post_disable(dsi->panel_bridge); Is this comment relevant? Michael On Sat, Oct 16, 2021 at 3:32 PM Michael Nazzareno Trimarchi wrote: > > Hi Sam > &g

Re: [PATCH v5 3/7] drm: sun4i: dsi: Convert to bridge driver

2021-12-06 Thread Michael Nazzareno Trimarchi
> > enable-gpios = < 1 7 GPIO_ACTIVE_HIGH>; /* > > > > > LCD-PWR-EN: PB7 */ > > > > > backlight = <>; > > > > > > > > > > port { > > > > >

Re: [PATCH 0/5] Add support for Wanchanglong panel used in px30-evb v11

2021-11-04 Thread Michael Nazzareno Trimarchi
Hi Sam On Sat, Oct 16, 2021 at 2:27 PM Sam Ravnborg wrote: > > Hi Michael, > > On Sat, Oct 16, 2021 at 10:22:27AM +, Michael Trimarchi wrote: > > This patch series add support for W552946ABA panel. This panel is used > > in px30-evb v11. All the patches can be applied on top of drm-fixes > >

Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

2021-12-09 Thread Michael Nazzareno Trimarchi
Hi Tim On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote: > > On Thu, Dec 9, 2021 at 12:36 AM Michael Nazzareno Trimarchi > wrote: > > > > Hi Tim > > > > On Tue, Oct 5, 2021 at 11:43 PM Tim Harvey wrote: > > > > > > On Sun, Jul 25, 2021 at 10

Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

2021-12-09 Thread Michael Nazzareno Trimarchi
looks > like you've rebased on top of 5.13-rc3 in your 070121-imx8mm-dsim > branch but you've got a lot of things there that are likely not > related to this series? I have a bit of work on those patches and tested on imx8mn. Basically: - add the dsi timing calculation - change few diff

Re: [PATCH] drm/panel: ilitek-ili9881c: Avoid unbalance prepare/unprepare

2021-12-09 Thread Michael Nazzareno Trimarchi
Hi Dave On Thu, Dec 9, 2021 at 6:58 PM Dave Stevenson wrote: > > Hi Michael > > On Thu, 9 Dec 2021 at 16:58, Michael Nazzareno Trimarchi > wrote: > > > > Hi all > > > > On Sat, Oct 16, 2021 at 4:58 PM Michael Trimarchi > > wrote: &g

Re: [PATCH] drm/panel: ilitek-ili9881c: Avoid unbalance prepare/unprepare

2021-12-09 Thread Michael Nazzareno Trimarchi
+ return 0; > + > mipi_dsi_dcs_enter_sleep_mode(ctx->dsi); > regulator_disable(ctx->power); > gpiod_set_value(ctx->reset, 1); > > + ctx->prepared = false; > + > return 0; > } > > -- > 2.25.1 > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [RFC PATCH 00/17] drm: bridge: Samsung MIPI DSIM bridge

2021-12-09 Thread Michael Nazzareno Trimarchi
Hi On Thu, Dec 9, 2021 at 9:24 PM Lucas Stach wrote: > > Am Donnerstag, dem 09.12.2021 um 18:09 +0100 schrieb Michael Nazzareno > Trimarchi: > > Hi Tim > > > > On Thu, Dec 9, 2021 at 5:40 PM Tim Harvey wrote: > > > > > > On Thu, Dec 9, 2021 at 12:3

Re: [PATCH] drm/panel: ilitek-ili9881c: Avoid unbalance prepare/unprepare

2021-12-10 Thread Michael Nazzareno Trimarchi
Hi Dave some questions below On Thu, Dec 9, 2021 at 7:10 PM Michael Nazzareno Trimarchi wrote: > > Hi Dave > > On Thu, Dec 9, 2021 at 6:58 PM Dave Stevenson > wrote: > > > > Hi Michael > > > > On Thu, 9 Dec 2021 at 16:58, Michael Nazzareno T

Re: [PATCH] drm/panel: ilitek-ili9881c: Avoid unbalance prepare/unprepare

2021-12-12 Thread Michael Nazzareno Trimarchi
Hi On Fri, Dec 10, 2021 at 4:48 PM Dave Stevenson wrote: > > Hi Michael > > On Fri, 10 Dec 2021 at 09:05, Michael Nazzareno Trimarchi > wrote: > > > > Hi Dave > > > > some questions below > > > > On Thu, Dec 9, 2021 at 7:10 PM Michael

Re: [PATCH 2/2] drm/tiny: add support for tft displays based on ilitek, ili9488

2022-10-18 Thread Michael Nazzareno Trimarchi
return PTR_ERR(dbidev->backlight); > + > + device_property_read_u32(dev, "rotation", ); > + > + ret = mipi_dbi_spi_init(spi, dbi, dc); > + if (ret) > + return ret; > + > + dbidev->drm.mode_config.preferred_depth = 16;

Re: [PATCH 0/2] drm/tiny: add support tft display based on ilitek, ili9488

2022-10-18 Thread Michael Nazzareno Trimarchi
l | 72 +++ > > drivers/gpu/drm/tiny/Kconfig | 13 + > > drivers/gpu/drm/tiny/Makefile | 1 + > > drivers/gpu/drm/tiny/ili9488.c | 440 ++ > > 4 files changed, 526 insertions(+) > >

Re: [RFC PATCH 0/4] Add RGB ttl connection on rockchip phy

2022-12-19 Thread Michael Nazzareno Trimarchi
+ > .../phy/rockchip/phy-rockchip-inno-dsidphy.c | 72 +++ > include/linux/phy/phy.h | 3 +- > 3 files changed, 92 insertions(+), 1 deletion(-) > > -- > 2.34.1 > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Off

display band (display area vs real visible area)

2023-03-21 Thread Michael Nazzareno Trimarchi
Hi all I would like to know the best approach in the graphics subsystem how deal with panels where the display area is different from the visible area because the display has a band left and right. I have already done the drm driver for the panel but from userspace point of view it's a pain to

Re: display band (display area vs real visible area)

2023-03-21 Thread Michael Nazzareno Trimarchi
Hi On Tue, Mar 21, 2023 at 11:43 AM Jani Nikula wrote: > > On Tue, 21 Mar 2023, Michael Nazzareno Trimarchi > wrote: > > Hi all > > > > I would like to know the best approach in the graphics subsystem how > > deal with panels where the display area is di

Re: display band (display area vs real visible area)

2023-03-21 Thread Michael Nazzareno Trimarchi
Hi Daniel On Tue, Mar 21, 2023 at 1:15 PM Daniel Stone wrote: > > Hi, > > On Tue, 21 Mar 2023 at 12:08, Jani Nikula wrote: > > On Tue, 21 Mar 2023, Daniel Stone wrote: > > > There have been some threads - mostly motivated by MacBooks and the > > > Asahi team - about creating a KMS property to

Re: display band (display area vs real visible area)

2023-03-21 Thread Michael Nazzareno Trimarchi
Hi Daniel On Tue, Mar 21, 2023 at 12:49 PM Daniel Stone wrote: > > Hi, > > On Tue, 21 Mar 2023 at 11:24, Jani Nikula wrote: > > On Tue, 21 Mar 2023, Michael Nazzareno Trimarchi > > wrote: > > > On Tue, Mar 21, 2023 at 11:43 AM Jani Nikula > > >

Re: [PATCH v3 4/4] drm/stm: add an option to change FB bpp

2023-06-13 Thread Michael Nazzareno Trimarchi
Hi On Tue, Jun 13, 2023 at 4:41 PM Philippe CORNU wrote: > > > > On 6/9/23 08:20, Dario Binacchi wrote: > > Boards that use the STM32F{4,7} series have limited amounts of RAM. The > > added parameter allows users to size, within certain limits, the memory > > footprint required by the

Re: [PATCH v4 02/10] drm/bridge: Fix a use case in the bridge disable logic

2023-12-06 Thread Michael Nazzareno Trimarchi
Hi Jagan On Wed, Dec 6, 2023 at 2:31 PM Jagan Teki wrote: > > Hi Dario, > > On Wed, Dec 6, 2023 at 6:57 PM Dario Binacchi > wrote: > > > > Hi Dave and Jagan, > > > > On Tue, Dec 5, 2023 at 4:39 PM Dave Stevenson > > wrote: > > > > > > Hi Dario > > > > > > On Tue, 5 Dec 2023 at 10:54, Dario

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-12-18 Thread Michael Nazzareno Trimarchi
_first and immediately the next assigned to previous > > > > > > Bridge 6 and limit assignments to next Bridge 6 and call post_enable > > > > > > of Bridge 6 even though the next consecutive Bridge 5 is enabled > > > > > > with > > > > > > pre_enable_prev_first. This clearly misses the logic to find the > > > > > > state > > > > > > of next conducive bridge as everytime the next and limit assigns > > > > > > previous bridge if given bridge enabled pre_enable_prev_first. > > > > > > > > > > > > So, the resulting post_disable bridge order would be, > > > > > > - Encoder, Bridge 6, Bridge 5, Bridge 4, Bridge 3, Bridge 2, Bridge > > > > > > 1, > > > > > > Panel. > > > > > > > > > > > > This patch fixes this by assigning next with previou bridge only if > > > > > > the > > > > > > bridge doesn't enable pre_enable_prev_first flag and the next > > > > > > further > > > > > > assign it to limit. This way we can find the bridge that NOT > > > > > > requested > > > > > > prev to disable last. > > > > > > > > > > > > So, the resulting pre_enable bridge order with fix would be, > > > > > > - Encoder, Bridge 4, Bridge 5, Bridge 6, Bridge 2, Bridge 3, Bridge > > > > > > 1, > > > > > > Panel. > > > > > > > > > > > > Validated the bridge init ordering by incorporating dummy bridges in > > > > > > the sun6i-mipi-dsi pipeline > > > > > > > > > > > > Fixes: 4fb912e5e190 ("drm/bridge: Introduce pre_enable_prev_first to > > > > > > alter bridge init order") > > > > > > Signed-off-by: Jagan Teki > > > > > > > > Thanks for investigating and sorting this. > > > > > > > > Reviewed-by: Dave Stevenson > > > > > > > > > > --- > > > > > > Changes for v2: > > > > > > - add missing dri-devel in CC > > > > > > > > > > Would you please look into this issue? > > > > > > These still not been picked it yet, can any one pull these two fixes? > > > > Ping! > Tested-by: Michael Trimarchi > Ping! > > Thanks, > Jagan. > > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __ Amarula Solutions BV Joop Geesinkweg 125, 1114 AB, Amsterdam, NL T. +31 (0)85 111 9172 i...@amarulasolutions.com www.amarulasolutions.com

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2023-11-26 Thread Michael Nazzareno Trimarchi
Hi Jagan On Sun, Nov 26, 2023 at 5:11 PM Jagan Teki wrote: > > On Mon, Nov 13, 2023 at 6:45 PM Jagan Teki wrote: > > > > On Tue, Aug 1, 2023 at 11:50 AM Dave Stevenson > > wrote: > > > > > > Hi Jagan > > > > > > My apologies for dropping the ball on this one, and thanks to Frieder > > > for

Re: [PATCH v5 04/10] drm: bridge: samsung-dsim: complete the CLKLANE_STOP setting

2023-12-08 Thread Michael Nazzareno Trimarchi
Hi Frieder On Thu, Dec 7, 2023 at 5:58 PM Frieder Schrempf wrote: > > On 07.12.23 15:16, Dario Binacchi wrote: > > The patch completes the setting of CLKLANE_STOP for the imx8mn and imx8mp > > platforms (i. e. not exynos). > > This also affects i.MX8MM, so better just mention i.MX in general in

Re: [PATCH v2 1/2] drm/bridge: Fix improper bridge init order with pre_enable_prev_first

2024-03-05 Thread Michael Nazzareno Trimarchi
e: Document bridge init order with pre_enable_prev_first > https://cgit.freedesktop.org/drm/drm-misc/commit/?id=113cc3ad8566 > > > > Rob > > -- Michael Nazzareno Trimarchi Co-Founder & Chief Executive Officer M. +39 347 913 2170 mich...@amarulasolutions.com __