[PATCH 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 130 -- drivers/gpu/drm/arm/malidp_drv.c | 52 +++ drivers/gpu/drm/arm/malidp_drv.h

[PATCH 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 39 +-- drivers/gpu/d

[PATCH] drm: mali-dp: Add CTM support

2017-02-01 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- This patch depends on "[PATCH 2/2

[PATCH v2 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 132 -- drivers/gpu/drm/arm/malidp_

[PATCH v2 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> --- Link to v1: https://lkml.org/lkml/

[PATCH v3 2/2] drm: mali-dp: enable gamma support

2017-02-07 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> Acked-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 130 +

[PATCH v3 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-07 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> Acked-by: Liviu Dudau <liviu.du...@ar

[PATCH 2/2] drm: mali-dp: Check for sufficient address space

2017-01-23 Thread Mihail Atanassov
If the device-tree 'reg' node doesn't reserve enough space for the DP, fail to bind. Reviewed-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_drv.c | 20 drivers/gpu/drm/arm/m

[PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Mihail Atanassov
The reset hook needs to allocate space for a malidp_plane_state, which is larger than drm_plane_state. Otherwise, the hook is identical to the default one. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_planes.c | 23 ++-

[PATCH] drm: mali-dp: add atomic_print_state for planes

2017-02-13 Thread Mihail Atanassov
Print all the extra fields of malidp_plane_state. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_planes.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c

[RFC] drm: Helper macro for drm state duplication

2017-02-09 Thread Mihail Atanassov
red this also applies to the other drm_*_state derivatives, so I concocted a macro helper to do the copy in one chunk (two if you count the __drm_atomic_helper* one). I'd appreciate some comments on whether anyone else might find this macro useful. Thanks! Mihail Atanassov (1): drm: Add helper ma

[PATCH] drm: Add helper macro for duplicating custom drm_*_state

2017-02-09 Thread Mihail Atanassov
ple) is not first in the derived struct, to avoid missing any data before it and corrupting the base's data. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- include/drm/drm_atomic_helper.h | 33 + 1 file changed, 33 insertions(+) diff --git a/in

[PATCH 1/2] drm: mali-dp: Check hw version matches device-tree

2017-01-23 Thread Mihail Atanassov
Refuse to bind if the device-tree compatible string lists a different hardware version. Reviewed-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- A couple of small improvements to driver-to-hardware binding. drivers

[PATCH v2] drm: mali-dp: Add CTM support

2017-02-13 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- Link to v1: https://lkml.org/lkml/20

Re: [PATCH] drm: mali-dp: Uninitialized variable in malidp_se_check_scaling()

2017-12-12 Thread Mihail Atanassov
_scaling(struct malidp_plane *mp, if (mp->layer->id & (DE_SMART | DE_GRAPHICS2)) return -EINVAL; - mc = to_malidp_crtc_state(crtc_state); - mc->scaled_planes_mask |= mp->layer->id; /* Defer scaling requirements calculation to the crtc check. */

[PATCH] drm/komeda: Add support for 'memory-region' DT node property

2019-08-02 Thread Mihail Atanassov
The 'memory-region' property of the komeda display driver DT binding allows the use of a 'reserved-memory' node for buffer allocations. Add the requisite of_reserved_mem_device_{init,release} calls to actually make use of the memory if present. Signed-off-by: Mihail Atanassov --- drivers/gpu

Re: [PATCH v2 2/4] drm/komeda: Introduce komeda_color_manager/state

2019-08-14 Thread Mihail Atanassov
On Wednesday, 14 August 2019 08:52:18 BST james qian wang (Arm Technology China) wrote: > On Tue, Aug 13, 2019 at 09:51:08AM +0000, Mihail Atanassov wrote: > > Hi James, > > > > On Tuesday, 13 August 2019 05:56:07 BST james qian wang (Arm Technology > > China) wrote:

Re: [PATCH v2 2/4] drm/komeda: Introduce komeda_color_manager/state

2019-08-13 Thread Mihail Atanassov
Hi James, On Tuesday, 13 August 2019 05:56:07 BST james qian wang (Arm Technology China) wrote: > Many komeda component support color management like layer and IPS, so > komeda_color_manager/state are introduced to manager gamma, csc and degamma > together for easily share it to multiple

Re: [PATCH v2 4/4] drm/komeda: Enable Layer color management for komeda

2019-08-13 Thread Mihail Atanassov
Hi James, On Tuesday, 13 August 2019 05:56:19 BST james qian wang (Arm Technology China) wrote: > - D71 has 3 global layer gamma table which can be used for all layers as > gamma lookup table, no matter inverse or forward. > - Add komeda_color_manager/state to layer/layer_state for describe

Re: [PATCH v2 2/4] drm/komeda: Introduce komeda_color_manager/state

2019-08-19 Thread Mihail Atanassov
On Monday, 19 August 2019 09:50:55 BST james qian wang (Arm Technology China) wrote: > On Wed, Aug 14, 2019 at 10:47:40AM +0000, Mihail Atanassov wrote: > > On Wednesday, 14 August 2019 08:52:18 BST james qian wang (Arm Technology > > China) wrote: > > > On Tue, Aug 13,

[PATCH] drm/komeda: Add missing of_node_get() call

2019-08-20 Thread Mihail Atanassov
komeda_pipeline_destroy has the matching of_node_put(). Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing") Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/disp

[PATCH] drm/komeda: Add ACLK rate to sysfs

2019-08-28 Thread Mihail Atanassov
Expose node with the name 'aclk_hz' Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index

Re: [PATCH] drm/komeda: Reordered the komeda's de-init functions

2019-08-23 Thread Mihail Atanassov
v->funcs->disable_irq(mdev); > - drm_dev_unregister(drm); > component_unbind_all(mdev->dev, drm); > - komeda_kms_cleanup_private_objs(kms); > drm_mode_config_cleanup(drm); > + komeda_kms_cleanup_private_objs(kms); > drm->dev_private = NULL;

[PATCH] drm/komeda: Remove in-code use of ifdef

2019-09-17 Thread Mihail Atanassov
Provide a dummy static inline function in the header instead. Cc: Daniel Vetter Cc: Lowry Li (Arm Technology China) Cc: james qian wang (Arm Technology China) Fixes: 4d74b25ee395 ("drm/komeda: Adds error event print functionality") Signed-off-by: Mihail Atanassov --- drivers/g

[PATCH v2] drm/komeda: Add support for 'memory-region' DT node property

2019-08-05 Thread Mihail Atanassov
komeda_parse_dt Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index 1ff7f4b2c620..0142ee991957 100644

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-08-02 Thread Mihail Atanassov
1. Refine komeda_sprintf(); > 2. Not using STR_SZ macro for the string size in komeda_print_events(). > > Changes since v1: > 1. Handling the event print by CONFIG_KOMEDA_ERROR_PRINT; > 2. Changing the max string size to 256. > > Signed-off-by: Lowry Li (Arm Technology

[PATCH v2.1] drm/komeda: Add support for 'memory-region' DT node property

2019-08-05 Thread Mihail Atanassov
komeda_parse_dt Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c index 1ff7f4b2c620..0142ee991957 100644

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-08-01 Thread Mihail Atanassov
Hi Lowry, On Thursday, 1 August 2019 12:37:15 BST Lowry Li (Arm Technology China) wrote: > From: "Lowry Li (Arm Technology China)" > > Adds to print the event message when error happens and the same event > will not be printed until next vsync. > > Changes since v1: > 1. Handling the event

Re: [PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable

2019-09-19 Thread Mihail Atanassov
On Thursday, 19 September 2019 14:30:02 BST Mihail Atanassov wrote: > When initially turning a crtc on, drm_reset_vblank_timestamp will > set the vblank timestamp to 0 for any driver that doesn't provide > a ->get_vblank_timestamp() hook. > > Unfortunately, the FLIP_COMP

[PATCH] drm/komeda: Fix FLIP_COMPLETE timestamp on CRTC enable

2019-09-19 Thread Mihail Atanassov
qually valid). Cc: Daniel Vetter Cc: Liviu Dudau Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c

[PATCH v2 RESEND] drm/komeda: Workaround for broken FLIP_COMPLETE timestamps

2019-10-01 Thread Mihail Atanassov
ed-off-by: Mihail Atanassov Reviewed-by: James Qian Wang (Arm Technology China) --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c index 9ca5db

[PATCH v2] drm/komeda: Workaround for broken FLIP_COMPLETE timestamps

2019-09-23 Thread Mihail Atanassov
ed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c index 34bc73ca18bc..d06679afb228 100644 --- a/drivers/gpu/drm/arm/d

Re: [PATCH] drm/komeda: Adds output-color format/depth support

2019-09-20 Thread Mihail Atanassov
Hi Lowry, On Friday, 20 September 2019 10:43:47 BST Lowry Li (Arm Technology China) wrote: > From: "Lowry Li (Arm Technology China)" > > Sets color_depth according to connector->bpc. > Adds a new optional DT attribute "color-format" to represent a I don't see the hunk with the updated doc for

[PATCH v2] drm/komeda: Fix typos in komeda_splitter_validate

2019-09-30 Thread Mihail Atanassov
Fix both the string and the struct member being printed. Changes since v1: - Now with a bonus grammar fix, too. Fixes: 264b9436d23b ("drm/komeda: Enable writeback split support") Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_pipeline_state.c | 4 ++

[PATCH v2 1/5] drm/komeda: Add debugfs node to control error verbosity

2019-11-07 Thread Mihail Atanassov
Named 'err_verbosity', currently with only 1 active bit in that replicates the existing level - print error events once per flip. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 4 drivers/gpu/drm

[PATCH v2 0/5] drm/komeda: Improve IRQ error event prints

2019-11-07 Thread Mihail Atanassov
, but sometimes it's useful to see them all as they come in. These patches are overall quite tiny, and I was considering just squashing them into one, but I opted to keep them separate for an easier review experience; please let me know whether you prefer a single patch. Thanks! Mihail Atanassov (5

[PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity

2019-11-07 Thread Mihail Atanassov
It's possible to get multiple events in a single frame/flip, so add an option to print them all. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- v2: Clean up continuation line warning from checkpatch. drivers/gpu/drm/arm/display/komeda/komeda_dev.h

[PATCH v2 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events

2019-11-07 Thread Mihail Atanassov
Extra detail (normally off) almost never hurts. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 2 files changed, 15

[PATCH v2 3/5] drm/komeda: Optionally dump DRM state on interrupts

2019-11-07 Thread Mihail Atanassov
log. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- v2: Clean up continuation line warning from checkpatch. drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 5 - drivers/gpu/drm/arm/display/komeda/komeda_event.c | 8 +++- 2 files changed,

[PATCH v2 2/5] drm/komeda: Remove CONFIG_KOMEDA_ERROR_PRINT

2019-11-07 Thread Mihail Atanassov
Now that there's a debugfs node to control the same, remove the config option. Reviewed-by: James Qian Wang (Arm Technology China) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/Kconfig | 6 -- drivers/gpu/drm/arm/display/komeda/Makefile | 5 ++--- drivers

Re: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity

2019-11-13 Thread Mihail Atanassov
On Tuesday, 12 November 2019 18:24:16 GMT Daniel Vetter wrote: > On Tue, Nov 12, 2019 at 2:00 PM Mihail Atanassov > wrote: > > > > On Monday, 11 November 2019 15:53:14 GMT Liviu Dudau wrote: > > > On Thu, Nov 07, 2019 at 11:42:44AM +, Mihail Atanassov wrote: &

Re: [PATCH v2 5/5] drm/komeda: add rate limiting disable to err_verbosity

2019-11-12 Thread Mihail Atanassov
On Monday, 11 November 2019 15:53:14 GMT Liviu Dudau wrote: > On Thu, Nov 07, 2019 at 11:42:44AM +0000, Mihail Atanassov wrote: > > It's possible to get multiple events in a single frame/flip, so add an > > option to print them all. > > > > Reviewed-by: James Qian

Re: [PATCH v10 0/4] drm/komeda: Enable CRTC color-mgmt

2019-11-12 Thread Mihail Atanassov
Hi James, On Tuesday, 12 November 2019 11:09:50 GMT james qian wang (Arm Technology China) wrote: > This series actually are regrouped from: > - drm/komeda: Enable layer/plane color-mgmt: > https://patchwork.freedesktop.org/series/60893/ > > - drm/komeda: Enable CRTC color-mgmt >

Re: [PATCH v3 1/6] drm/komeda: Add side by side assembling

2019-11-14 Thread Mihail Atanassov
Hi James, On Thursday, 14 November 2019 08:37:24 GMT james qian wang (Arm Technology China) wrote: > Komeda HW can support side by side, which splits the internal display > processing to two single halves (LEFT/RIGHT) and handle them by two > pipelines separately. > komeda "side by side" is

Re: [PATCH] drm/komeda: Clean warnings: candidate for 'gnu_printf’ format attribute

2019-11-14 Thread Mihail Atanassov
c > @@ -17,6 +17,7 @@ struct komeda_str { > > /* return 0 on success, < 0 on no space. > */ > +__printf(2, 3) > static int komeda_sprintf(struct komeda_str *str, const char *fmt, ...) > { > va_list args; > -- > 2.20.1 > > Reviewed-by: Mihail A

Re: [PATCH v3 2/6] drm/komeda: Add side by side plane_state split

2019-11-14 Thread Mihail Atanassov
On Thursday, 14 November 2019 08:37:31 GMT james qian wang (Arm Technology China) wrote: > On side by side mode, The full display frame will be split into two parts > (Left/Right), and each part will be handled by a single pipeline separately > master pipeline for left part, slave for right. > >

Re: drm/komeda: Use devm_platform_ioremap_resource() in komeda_dev_create()

2019-11-06 Thread Mihail Atanassov
On Wednesday, 9 October 2019 09:57:11 GMT james qian wang (Arm Technology China) wrote: > On Sat, Sep 21, 2019 at 07:50:46PM +0200, Markus Elfring wrote: > > From: Markus Elfring > > Date: Sat, 21 Sep 2019 19:43:51 +0200 > > > > Simplify this function implementation by using a known wrapper

[PATCH v2 07/28] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/megachips-stdp-ge-b850v3-fw.c b/drivers/gpu/drm/bridge/megachips-stdp-ge

[PATCH v2 26/28] drm: rcar-du: lvds: Don't set drm_bridge private pointer

2019-12-04 Thread Mihail Atanassov
No functional change: it's not used anywhere. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index ac1f29bacfcb..168a718cbcbd

[PATCH v2 22/28] drm/i2c: tda998x: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/i2c/tda998x_drv.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index a63790d32d75..f7dfa694aff7 100644 --- a/drivers/gpu

[PATCH v2 25/28] drm: rcar-du: lvds: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/rcar-du/rcar_lvds.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c index 8c6c172bbf2e..ac1f29bacfcb 100644 --- a/drivers

[PATCH v2 17/28] drm/bridge: tc358767: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/tc358767.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 8029478ffebb..7846c1925cbb 100644 --- a/drivers/gpu/drm

[PATCH v2 09/28] drm/bridge: panel: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/panel.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c index f4e293e7cf64..91d68d0337cc 100644 --- a/drivers/gpu/drm

[PATCH v2 19/28] drm/bridge: ti-sn65dsi86: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 43abf01ebd4c..4e236b46f913 100644

[PATCH v2 13/28] drm/bridge: sil_sii8620: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/sil-sii8620.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c index 4c0eef406eb1..482dc2291350 100644 --- a/drivers

[PATCH v2 05/28] drm/bridge: dumb-vga-dac: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index cc33dc411b9e..896f27272e38 100644

[PATCH v2 27/28] drm/sti: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. v2: - Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam, Benjamin) Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/sti/sti_dvo.c | 4 +--- drivers/gpu/drm/sti/sti_hda.c | 3 +-- drivers/gpu/drm/sti/sti_hdmi.c | 3 +-- 3 files changed, 3 insertions

[PATCH v2 18/28] drm/bridge: thc63: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/thc63lvd1024.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/thc63lvd1024.c b/drivers/gpu/drm/bridge/thc63lvd1024.c index 3d74129b2995..abe806db5f4d 100644

[PATCH v2 12/28] gpu: drm: bridge: sii9234: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/sii9234.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index f81f81b7051f..bfd3832baa1a 100644 --- a/drivers/gpu/drm

[PATCH v2 08/28] drm/bridge: nxp-ptn3460: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/nxp-ptn3460.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/nxp-ptn3460.c b/drivers/gpu/drm/bridge/nxp-ptn3460.c index 57ff01339559..2656a188b434 100644

[PATCH v2 28/28] drm/msm: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change: drm_bridge_init() sets bridge->of_node, but that's not used by msm anywhere, and the bridges aren't published with drm_bridge_add() for it to matter. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/msm/dsi/dsi_manager.c | 4 ++-- drivers/gpu/drm/msm/edp/edp_bridg

[PATCH v2 11/28] drm/bridge: sii902x: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/sii902x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/sii902x.c b/drivers/gpu/drm/bridge/sii902x.c index b70e8c5cf2e1..2a9db621484d 100644 --- a/drivers/gpu/drm

[PATCH v2 24/28] drm/mediatek: hdmi: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index f684947c5243..9761a80674d9 100644 --- a/drivers

[PATCH v2 23/28] drm/mcde: dsi: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Acked-by: Linus Walleij Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/mcde/mcde_dsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c index 42fff811653e..d9b9253acccf 100644

[PATCH v2 14/28] drm/bridge/synopsys: dw-hdmi: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index dbe38a54870b..6c71ffc9df5a

[PATCH v2 21/28] drm/exynos: mic: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change: no logic depends on driver_private being NULL, so it's safe to set it earlier in exynos_mic_probe. Acked-by: Inki Dae Tested-by: Inki Dae Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions

[PATCH v2 16/28] drm/bridge: tc358764: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/tc358764.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358764.c b/drivers/gpu/drm/bridge/tc358764.c index db298f550a5a..861d4df687ee 100644 --- a/drivers/gpu/drm

[PATCH v2 10/28] drm/bridge: ps8622: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/parade-ps8622.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c index b7a72dfdcac3..8454dbb238bb 100644

[PATCH v2 20/28] drm/bridge: ti-tfp410: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/ti-tfp410.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index aa3198dc9903..377eca989ff3 100644 --- a/drivers

[PATCH v2 15/28] drm/bridge/synopsys: dsi: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index b6e793bb653c

[PATCH v2 02/28] drm/bridge: adv7511: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index 9e13e466e72c

[PATCH v2 06/28] drm/bridge: lvds-encoder: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/lvds-encoder.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index e2132a8d5106..155406510416 100644

[PATCH v2 01/28] drm: Introduce drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
by Daniel - expand on some kerneldoc comments as suggested by Daniel - update commit message as suggested by Daniel Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/drm_bridge.c | 34 +- include/drm/drm_bridge.h | 15 ++- 2 files changed, 47

[PATCH v2 04/28] drm/bridge: cdns: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/cdns-dsi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/cdns-dsi.c b/drivers/gpu/drm/bridge/cdns-dsi.c index 3a5bd4e7fd1e..58b2aa8b6c24 100644 --- a/drivers/gpu

[PATCH v2 03/28] drm/bridge/analogix: Use drm_bridge_init()

2019-12-04 Thread Mihail Atanassov
No functional change. The setting of bridge->of_node by drm_bridge_init() in analogix_dp_core.c is safe, since ->of_node isn't used directly and the bridge isn't published with drm_bridge_add(). Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/analogix/analogix-anx6345

[PATCH v2 00/28] drm/bridge: Consolidate initialization

2019-12-04 Thread Mihail Atanassov
for its pipe outputs; this isn't a regression in usability any more since device links bring the same automatic remove/reprobe feature as components. Mihail Atanassov (28): drm: Introduce drm_bridge_init() drm/bridge: adv7511: Use drm_bridge_init() drm/bridge/analogix: Use drm_bridge_init

Re: [PATCH v2 2/2] drm/komeda: Enable new product D32 support

2019-12-03 Thread Mihail Atanassov
On Tuesday, 3 December 2019 06:46:06 GMT james qian wang (Arm Technology China) wrote: > On Mon, Dec 02, 2019 at 11:07:52AM +0000, Mihail Atanassov wrote: > > On Thursday, 21 November 2019 08:17:45 GMT james qian wang (Arm Technology > > China) wrote: > > > D32

Re: [PATCH v2 00/28] drm/bridge: Consolidate initialization

2019-12-09 Thread Mihail Atanassov
On Monday, 9 December 2019 10:39:07 GMT Neil Armstrong wrote: > Hi Mihail, Hi Neil, > > On 04/12/2019 12:48, Mihail Atanassov wrote: > > Hi all, > > > > I've dropped the fun parts of this series since they need more work, but > > figured drm_bridge_init() as a

Re: [PATCH] drm: Rename drm_bridge->dev to drm

2019-12-10 Thread Mihail Atanassov
On Tuesday, 10 December 2019 10:12:50 GMT Daniel Vetter wrote: > On Fri, Dec 06, 2019 at 12:59:04PM +0100, Thomas Zimmermann wrote: > > Hi > > > > Am 06.12.19 um 12:25 schrieb Mihail Atanassov: > > > Hallo Thomas, > > > > > > On Thursday, 5 De

[PATCH] drm/bridge: panel: export drm_panel_bridge_connector

2019-12-10 Thread Mihail Atanassov
The function was unexported and was causing link failures for pl111 (and probably the other user tve200) in a module build. Fixes: d383fb5f8add ("drm: get drm_bridge_panel connector via helper") Cc: Sam Ravnborg Cc: Laurent Pinchart Cc: Linux Walleij Signed-off-by: Mihail

Re: [PATCH] drm: remove drm_bridge->dev

2019-12-11 Thread Mihail Atanassov
Hi, On Wednesday, 11 December 2019 07:38:29 GMT Thomas Zimmermann wrote: > Hi > > Am 10.12.19 um 16:11 schrieb Mihail Atanassov: > > As suggested in [1], the 'dev' field is a bit repetitive, since it 1:1 > > follows the setting and NULLing of the 'encoder' field. Therefor

Re: [PATCH v3 04/50] drm/bridge: Add connector-related bridge operations and data

2019-12-11 Thread Mihail Atanassov
Hi Laurent, On Tuesday, 10 December 2019 22:57:04 GMT Laurent Pinchart wrote: > To support implementation of DRM connectors on top of DRM bridges > instead of by bridges, the drm_bridge needs to expose new operations and > data: > > - Output detection, hot-plug notification, mode retrieval and

[PATCH v2] drm: Remove drm_bridge->dev

2019-12-11 Thread Mihail Atanassov
int about unnecessary parentheses in drm_bridge.c. I've left the other two in since they're in the patch context rather than in a touched line. Cc: Daniel Vetter Suggested-by: Thomas Zimmermann Acked-by: Thomas Zimmermann Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/adv7511/adv7

Re: [PATCH] drm/komeda: Correct d71 register block counting

2019-12-11 Thread Mihail Atanassov
425,9 +428,9 @@ static int d71_enum_resources(struct komeda_dev *mdev) > err = d71_probe_block(d71, , blk_base); > if (err) > goto err_cleanup; > - i++; >

Re: [PATCH 1/2] drm/komeda: Add basic support for D77

2019-12-11 Thread Mihail Atanassov
Hi Tiannan, Thanks for the patch. On Wednesday, 11 December 2019 10:30:09 GMT Tiannan Zhu (Arm Technology China) wrote: > Make komeda driver can recongise D77, D77 is arm latest display > product, compare with D71, D77 support some new features: > 1. Crossbar: adjust every plane's zorder > 2.

Re: [PATCH v3 2/2] drm/komeda: Enable new product D32 support

2019-12-11 Thread Mihail Atanassov
patch I would've expected the fix to be a part of this series as 2/3 and this patch as 3/3. Otherwise, this patch is Reviewed-by: Mihail Atanassov > > Signed-off-by: James Qian Wang (Arm Technology China) > > --- > .../drm/arm/display/include/malidp_product.h | 3 +- > .../ar

Re: [PATCH v2 01/28] drm: Introduce drm_bridge_init()

2019-12-05 Thread Mihail Atanassov
Hi Laurent, On Thursday, 5 December 2019 12:40:22 GMT Laurent Pinchart wrote: > Hi Mihail, > > Thank you for the patch. Thanks for the quick reviews :). > > On Wed, Dec 04, 2019 at 11:48:02AM +, Mihail Atanassov wrote: > > A simple convenience function to initialize

Re: [PATCH v2 12/28] gpu: drm: bridge: sii9234: Use drm_bridge_init()

2019-12-05 Thread Mihail Atanassov
Hi Neil, On Thursday, 5 December 2019 12:10:37 GMT Neil Armstrong wrote: > Hi, > > On 04/12/2019 12:48, Mihail Atanassov wrote: > > No functional change. > > > > Why this particular one has "gpu: drm: bridge" unlike the other patches of > the serie ? &g

[PATCH] drm: Rename drm_bridge->dev to drm

2019-12-05 Thread Mihail Atanassov
Cc: Daniel Vetter Cc: Laurent Pinchart Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 +- drivers/gpu/drm/bridge/cdns-dsi.c

Re: [PATCH] drm: Rename drm_bridge->dev to drm

2019-12-06 Thread Mihail Atanassov
Hallo Thomas, On Thursday, 5 December 2019 18:20:06 GMT Thomas Zimmermann wrote: > Hi > > Am 05.12.19 um 17:30 schrieb Mihail Atanassov: > > The 'dev' name causes some confusion with 'struct device' [1][2], so use > > 'drm' instead since this seems to be the preva

Re: [PATCH v2 2/2] drm/komeda: Enable new product D32 support

2019-12-05 Thread Mihail Atanassov
On Thursday, 5 December 2019 08:53:02 GMT james qian wang (Arm Technology China) wrote: > On Tue, Dec 03, 2019 at 09:59:57AM +0000, Mihail Atanassov wrote: > > On Tuesday, 3 December 2019 06:46:06 GMT james qian wang (Arm Technology > > China) wrote: > > > On Mon, De

[PATCH] drm: remove drm_bridge->dev

2019-12-10 Thread Mihail Atanassov
y: Thomas Zimmermann Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 2 +- drivers/gpu/drm/bridge/analogix/analogix-anx6345.c | 2 +- drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c | 2 +- drivers/gpu/drm/bridge/cdns-dsi.c

Re: [PATCH] drm/bridge: panel: export drm_panel_bridge_connector

2019-12-10 Thread Mihail Atanassov
On Tuesday, 10 December 2019 16:26:47 GMT Laurent Pinchart wrote: > Hi Mihail, > > Thank you for the patch. > > On Tue, Dec 10, 2019 at 02:48:49PM +, Mihail Atanassov wrote: > > The function was unexported and was causing link failures for pl111 (and > > pro

Re: [PATCH v5 1/4] drm: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-18 Thread Mihail Atanassov
On Friday, 18 October 2019 08:51:09 BST james qian wang (Arm Technology China) wrote: > On Wed, Oct 16, 2019 at 11:02:03AM +0000, Mihail Atanassov wrote: > > On Wednesday, 16 October 2019 11:34:08 BST james qian wang (Arm Technology > > China) wrote: > > > A

Re: [RFC,3/3] drm/komeda: Allow non-component drm_bridge only endpoints

2019-10-18 Thread Mihail Atanassov
On Friday, 18 October 2019 07:38:59 BST james qian wang (Arm Technology China) wrote: > On Thu, Oct 17, 2019 at 10:48:12AM +, Brian Starkey wrote: > > On Thu, Oct 17, 2019 at 10:21:03AM +, james qian wang (Arm Technology > > China) wrote: > > > On Thu, Oct 17, 2019 at 08:20:56AM +,

Re: [v2] drm/komeda: Fix typos in komeda_splitter_validate

2019-10-21 Thread Mihail Atanassov
On Wednesday, 16 October 2019 09:23:03 BST james qian wang (Arm Technology China) wrote: > On Mon, Sep 30, 2019 at 12:23:07PM +0000, Mihail Atanassov wrote: > > Fix both the string and the struct member being printed. > > > > Changes since v1: > > - Now wi

Re: drm/komeda: Don't flush inactive pipes

2019-10-21 Thread Mihail Atanassov
On Wednesday, 16 October 2019 09:21:24 BST james qian wang (Arm Technology China) wrote: > On Thu, Oct 10, 2019 at 10:30:07AM +0000, Mihail Atanassov wrote: > > HW doesn't allow flushing inactive pipes and raises an MERR interrupt > > if you try to do so. Stop triggering the

Re: drm/komeda: Dump SC_ENH_* registers from scaler block

2019-10-21 Thread Mihail Atanassov
On Wednesday, 16 October 2019 09:17:39 BST james qian wang (Arm Technology China) wrote: > On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote: > > Signed-off-by: Mihail Atanassov > > --- > > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +

[PATCH 4/5] drm/komeda: Add option to print WARN- and INFO-level IRQ events

2019-10-21 Thread Mihail Atanassov
Extra detail (normally off) almost never hurts. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.h | 11 +++ drivers/gpu/drm/arm/display/komeda/komeda_event.c | 4 2 files changed, 15 insertions(+) diff --git a/drivers/gpu/drm/arm/display/komeda

Re: [PATCH 1/2] drm/arm: Factor out generic afbc helpers

2019-10-21 Thread Mihail Atanassov
Hi Andrzej, On Monday, 21 October 2019 14:50:14 BST Ayan Halder wrote: > On Fri, Oct 11, 2019 at 01:18:10PM +0200, Andrzej Pietrasiewicz wrote: > > These are useful for other users of afbc, e.g. rockchip. > > > > Signed-off-by: Andrzej Pietrasiewicz > > Hi Andrzej, > > Thanks a lot for doing

  1   2   3   >