Re: [Intel-gfx] PCH reference clock cleanups

2011-09-28 Thread Paulo Zanoni
2011/9/27 Keith Packard kei...@keithp.com: Here's a patch sequence which cleans up a bunch of PCH refclk related bits. For the series: Tested-by: Paulo Zanoni paulo.r.zan...@intel.com Tested all the patches on Ironlake (LVDS + VGA). Fixes fd.o bug #38750 for me. I also tested the patch you

Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-05 Thread Paulo Zanoni
-- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-16 Thread Paulo Zanoni
the screen is rotated. More information: http://en.wikipedia.org/wiki/Intel_Active_Management_Technology#VNC-based_KVM_remote_control Cheers, Paulo -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org

[PATCH 1/3] drm: add drm_property_change_is_valid

2012-01-16 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Move code from drm_mode_connector_property_set_ioctl to a new function, so we can reuse this code when we add crtc properties. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 41

[PATCH 2/3] drm: add CRTC properties

2012-01-16 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Code based on the connector properties code. Two new ioctls: - DRM_IOCTL_MODE_CRTC_GETPROPERTIES - DRM_IOCTL_MODE_CRTC_SETPROPERTY The i915 driver needs this (for the rotation property). Other drivers might need this too. Signed-off-by: Paulo Zanoni

[PATCH 3/3] drm/i915: add 'rotation' CRTC property

2012-01-16 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com This property is needed by to inform the KVMr feature about our current rotation: whenever we change the rotation, we should change that property so that the KVMr knows that the screen is rotated. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com

Re: [PATCH 2/3] drm: add CRTC properties

2012-01-16 Thread Paulo Zanoni
), +       DRM_IOCTL_DEF(DRM_IOCTL_MODE_CRTC_SETPROPERTY, drm_mode_crtc_set_property_ioctl, DRM_MASTER|DRM_CONTROL_ALLOW|DRM_UNLOCKED) I'm not sure about how we want these flags. I just copied from connector properties ioctls. -- Paulo Zanoni ___ dri-devel mailing list

Re: [Intel-gfx] [RFC] drm: implement DRM_IOCTL_MODE_SETROTATION

2012-01-16 Thread Paulo Zanoni
@) -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/5] drm: add drm_property_change_is_valid

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Move code from drm_mode_connector_property_set_ioctl to a new function, so we can reuse this code when we add crtc properties. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 41

[PATCH 2/5] drm: WARN() when drm_connector_attach_property fails

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Also return void instead of int. We have more than 100 callers and no one checks for the return value. If this function fails the property won't be exposed by the get/set ioctls, but we should probably survive. If this starts happening, the solution

[PATCH 3/5] drm: add CRTC properties

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Code based on the connector properties code. Two new ioctls: - DRM_IOCTL_MODE_CRTC_GETPROPERTIES - DRM_IOCTL_MODE_CRTC_SETPROPERTY The i915 driver needs this for the rotation and overscan compensation properties. Other drivers might need this too. v2

[PATCH 4/5] drm/i915: add 'rotation' CRTC property

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com This property is needed so we can inform the KVMr feature about our current rotation: whenever we change the rotation, we should change that property so that the KVMr knows that the screen is rotated. How to reproduce the problem: - on an AMT machine

[PATCH 5/5] drm/i915: add overscan compensation CRTC properties

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com They're named underscan x and underscan y. The properties accept values from 0 to 100, where 0 is don't compensate and 100 is shrink the screen as much as possible. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915

[PATCH 1/5 libdrm] modetest: fix some compiler warnings

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Use unsigned int instead of int: - modetest.c:89:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] - modetest.c:97:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare

[PATCH 2/5 libdrm] modetest: fix memory leak

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Don't continue without freeing the connector. 192 bytes in 6 blocks are indirectly lost in loss record 6 of 12 at 0x4C2779D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4E30DD8: drmMalloc (xf86drm.c:147) by 0x4E35024

[PATCH 3/5 libdrm] modetest: print more about our properties

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com In the future we'll have more than just connector properties, so create a dump_prop function that can handle any property (instead of the current dump_props function that only handles connector properties). Also, make this function print a lot more

[PATCH 4/5 libdrm] Add support for CRTC properties

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com New library calls: - drmModeCrtcGetProperties - drmModeFreeCrtcProperties - drmModeCrtcSetProperties Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- include/drm/drm.h |2 + include/drm/drm_mode.h | 13 xf86drmMode.c

[PATCH 5/5 libdrm] modetest: print CRTC properties

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- tests/modetest/modetest.c | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 52c81a9..58bb39e 100644

[PATCH 1/3 xf86-video-intel] Avoid duplicated code with intel_output_create_ranged_atom

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Same change for intel_display.c and sna_display.c. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- src/intel_display.c | 104 + src/sna/sna_display.c | 104

[PATCH 2/3 xf86-video-intel] Update the rotation property whenever we change the rotation.

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Don't worry if that fails: only the KVMr feature will be affected. We still need to change the sna/ code. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- src/intel.h |3 ++ src/intel_display.c | 79

[PATCH 3/3 xf86-video-intel] Add underscan properties

2012-03-20 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com In the Kernel side, these are crtc properties (since in the hardware, underscan use the panel fitters, which are attached to the pipes). Ideally we should make these as crtc properties too, but since xrandr doesn't have support for them, we expose

CRTC properties patches

2012-03-20 Thread Paulo Zanoni
the new functions. -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: CRTC properties patches

2012-03-29 Thread Paulo Zanoni
dependency and the sna/ code, so for now these are just for review. 0001: Update the rotation property whenever we change the rotation. 0002: Add underscan properties Cheers, Paulo 2012/3/20 Paulo Zanoni przan...@gmail.com: Hi Some time ago I posted a patch series to implement Kernel CRTC

[PATCH 1/8] drm: add drm_property_change_is_valid

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Move code from drm_mode_connector_property_set_ioctl to a new function, so we can reuse this code when we add crtc properties. v2: use bool instead of int Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 41

[PATCH 3/8] drm: create struct drm_object_properties and use it

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com For now, only connectors have it. In the future, all objects that need properties should use it. Since the strucutre is referenced inside struct drm_mode_object, we will be able to deal with object properties without knowing the real type of the object

[PATCH 4/8] drm: add generic ioctls to get/set properties on any object

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Useless for connector properties (since they already have their own ioctls), but useful when we add properties to CRTCs, planes and other objects. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 180

[PATCH 5/8] drm: make the connector properties code use the object properties code

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 96 +-- 1 files changed, 12 insertions(+), 84 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm

[PATCH 6/8] drm: add CRTC properties

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com The i915 driver needs this for the rotation and overscan compensation properties. Other drivers might need this too. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 20 include/drm

[PATCH RFC 7/8] drm/i915: add 'rotation' CRTC property

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com This property is needed so we can inform the KVMr feature about our current rotation: whenever we change the rotation, we should change that property so that the KVMr knows that the screen is rotated. How to reproduce the problem: - on an AMT machine

[PATCH 8/8] drm/i915: add overscan compensation CRTC properties

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com They're named underscan hborder and underscan vborder. The properties accept values from 0 to 100, where 0 is don't compensate and 100 is shrink the screen as much as possible (not necessarily 100 pixels). V2: Rename to underscan hborder and underscan

[PATCH libdrm 1/5] modetest: fix some compiler warnings

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Use unsigned int instead of int: - modetest.c:89:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] - modetest.c:97:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare

[PATCH libdrm 2/5] modetest: fix memory leak

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Don't continue without freeing the connector. 192 bytes in 6 blocks are indirectly lost in loss record 6 of 12 at 0x4C2779D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4E30DD8: drmMalloc (xf86drm.c:147) by 0x4E35024

[PATCH libdrm 4/5] Add support for generic object properties IOCTLs

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com New library calls: - drmModeObjectGetProperties - drmModeFreeObjectProperties - drmModeObjectSetProperties Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- include/drm/drm.h |2 + include/drm/drm_mode.h | 24

[PATCH libdrm 5/5] modetest: print CRTC properties

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- tests/modetest/modetest.c | 15 +++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c index 02ea579..a6a2a8c

[PATCH RFC xf86-video-intel 1/2] Update the rotation property whenever we change the rotation.

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Don't worry if that fails: only the KVMr feature will be affected. We still need to change the sna/ code. We also need to add the dependency on libdrm. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- src/intel.h |3 ++ src

[PATCH RFC xf86-video-intel 2/2] Add underscan properties

2012-03-29 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com In the Kernel side, these are crtc properties (since in the hardware, underscan use the panel fitters, which are attached to the pipes). Ideally we should make these as crtc properties too, but since xrandr doesn't have support for them, we expose

Re: [PATCH RFC 1/2] drm: add bitmask property type

2012-03-30 Thread Paulo Zanoni
mode underscan underscan hborder underscan vborder vibrant hue - radeon: coherent load detection tmds_pll tv standard underscan underscan hborder underscan vborder Cheers, Paulo -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH RFC 1/2] drm: add bitmask property type

2012-03-30 Thread Paulo Zanoni
2012/3/30 Paulo Zanoni przan...@gmail.com: Can't we try to add some document (or header file) defining the standard properties and add a way to distinguish between? Documentation/drm/properties.txt? After looking at the list names, maybe we should define that standard properties should

[PATCH 1/4] drm: add the VIC number to the CEA EDID modes

2012-04-13 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com The specification defines a VIC (Video Identification Code) for each mode. When we're browsing drm_edid_modes.h, it really helps to have the number available (otherwise we have to count...). These numbers are also used in the EDID data (by the CEA-EXT

[PATCH 2/4] drm: add DRM_MODE_FLAG_DBLCLK to CEA modes requiring it

2012-04-13 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com CEA modes 6, 7, 8, 9, 21, 22, 23, 24, 44, 45, 50, 51, 54, 55, 58 and 59 require sending pixel data 2 times. This doesn't mean the modes will work yet, but now the drivers know they're different. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com

[PATCH 3/4] drm/i915: rename AVI InfoFrame field 'PR' to 'YQ_CN_PR'

2012-04-13 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com To keep the consistency with the other fields. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_drv.h |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b

[PATCH 4/4] drm/i915: make DBLCLK modes work

2012-04-13 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com They require an AVI InfoFrame with a proper Pixel Repetition field. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=45729 Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- I'm still waiting for confirmation on bugzilla, but I have access

Re: [PATCH libdrm 1/5] modetest: fix some compiler warnings

2012-04-21 Thread Paulo Zanoni
this, it should be done in a separate patch. I'm resending this patch with more warning fixes and a rebase. -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH libdrm 3/5] modetest: print more about our properties

2012-04-21 Thread Paulo Zanoni
2012/3/29 Eugeni Dodonov eug...@dodonov.net: On Thu, Mar 29, 2012 at 18:28, Paulo Zanoni przan...@gmail.com wrote: really-small-bikeshedding I don't know if it should go into a separate patch though. But it is aligned to the other formatting patterns you do, and it certainly looks nicer

[PATCH libdrm 1/4] modetest: fix some compiler warnings

2012-04-21 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Use unsigned int instead of int: - modetest.c:90:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] - modetest.c:98:1: warning: comparison between signed and unsigned integer expressions [-Wsign-compare

[PATCH libdrm 2/4] modetest: fix drmModeGetConnector memory leak

2012-04-21 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Don't continue without freeing the connector. 192 bytes in 6 blocks are indirectly lost in loss record 6 of 12 at 0x4C2779D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4E30DD8: drmMalloc (xf86drm.c:147) by 0x4E35024

[PATCH libdrm 3/4] modetest: call drmModeFreePlaneResources

2012-04-21 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com 24 (16 direct, 8 indirect) bytes in 1 blocks are definitely lost in loss record 2 of 7 at 0x402994D: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x4A25950: drmMalloc (xf86drm.c:147) by 0x4A2E26D: drmModeGetPlaneResources

[PATCH libdrm 4/4] modetest: print more about our properties

2012-04-21 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com In the future we'll have more than just connector properties, so create a dump_prop function that can handle any property (instead of the current dump_props function that only handles connector properties). Also, make this function print a lot more

Re: [PATCH 1/2] drm/edid: adjust double-clocked cea modes

2012-05-14 Thread Paulo Zanoni
in which struct to add this kind of information to pass to the drivers... -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/2] drm/edid: adjust double-clocked cea modes

2012-05-14 Thread Paulo Zanoni
2012/5/14 Paulo Zanoni przan...@gmail.com: I haven't bothered to even try to fix them since I couldn't find any TV/Monitor that supports them. Also, I think flag DRM_MODE_FLAG_DBLCLK does not sound correct for them, so we would need to create flags: - DRM_MODE_FLAG_PR_1_to_10

[PATCH 1/8] drm: add drm_property_change_is_valid

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Move code from drm_mode_connector_property_set_ioctl to a new function, so we can reuse this code when we add crtc properties. Reviewed-by: Eugeni Dodonov eugeni.dodo...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu

[PATCH] drm: WARN() when drm_connector_attach_property fails

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Also return void instead of int. We have more than 100 callers and no one checks for the return value. If this function fails the property won't be exposed by the get/set ioctls, but we should probably survive. If this starts happening, the solution

[PATCH] drm: create struct drm_object_properties and use it

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com For now, only connectors have it. In the future, all objects that need properties should use it. Since the structure is referenced inside struct drm_mode_object, we will be able to deal with object properties without knowing the real type of the object

[PATCH] drm: add generic ioctls to get/set properties on any object

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Useless for connector properties (since they already have their own ioctls), but useful when we add properties to CRTCs, planes and other objects. Reviewed-by: Eugeni Dodonov eugeni.dodo...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com

[PATCH] drm: make the connector properties code use the object properties code

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com In the future, we may want to kill the internal functions: - drm_connector_attach_property - drm_connector_property_set_value - drm_connector_property_get_value It seems the IOCTL drm_mode_connector_property_set_ioctl will have to live, but we may

[PATCH] drm: add 'count' to struct drm_object_properties

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com This way, we don't need to count every time, so we're a little bit faster and code is a little bit smaller. Change suggested by Ville Syrjälä. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 64

[PATCH] drm: add CRTC properties

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com The i915 driver needs this for the rotation and overscan compensation properties. Other drivers might need this too. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/drm_crtc.c | 20 include/drm

Re: [PATCH] drm: add CRTC properties

2012-05-15 Thread Paulo Zanoni
2012/5/15 Paulo Zanoni przan...@gmail.com: Patches 0 to 6 are not completely useless: they change the code that's executed when someone changes the Connector properties, and they allow the implementation of other object properties. This patch (0007) is an example of how to add properties

[PATCH libdrm 1/3] Add support for generic object properties IOCTLs

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com New library calls: - drmModeObjectGetProperties - drmModeFreeObjectProperties - drmModeObjectSetProperties Reviewed-by: Eugeni Dodonov eugeni.dodo...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- include/drm/drm.h |2

[PATCH libdrm 2/3] modetest: print CRTC properties

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Reviewed-by: Eugeni Dodonov eugeni.dodo...@intel.com Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- tests/modetest/modetest.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/tests/modetest/modetest.c b/tests/modetest

[PATCH libdrm 3/3] tests: add proptest

2012-05-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com A small program that allows us to see and modify properties. Signed-off-by: Paulo Zanoni paulo.r.zan...@intel.com --- configure.ac |1 + tests/Makefile.am |2 +- tests/proptest/Makefile.am | 11 ++ tests/proptest

Re: [PATCH 2/2] drm: add plane properties

2012-05-16 Thread Paulo Zanoni
/drm_crtc.h documenting the new added fields of drm_plane_funcs and drm_funcs (we already have descriptions of all the other fields). With that: Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com ---  drivers/gpu/drm/drm_crtc.c |   19 +++  include/drm/drm_crtc.h     |    5

Re: [PATCH 1/2] drm: add bitmask property type

2012-05-16 Thread Paulo Zanoni
num_values appears after column 80 in 2 places /Bikeshedding Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com ---  drivers/gpu/drm/drm_crtc.c |   46 +---  include/drm/drm_crtc.h     |    3 +++  include/drm/drm_mode.h     |    1 +  3 files changed, 47

Re: [PATCH libdrm 0/3] Additional drm properties patches

2012-05-16 Thread Paulo Zanoni
for bitmask properties  modetest: support bitmask properties  modetest: support plane properties For the 3 patches: Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com You might want to create patch 0004 adding support for the proptest tool... It might help you test stuff.  include/drm/drm_mode.h

Re: Lots of i915/drm spew on 3.4

2012-05-31 Thread Paulo Zanoni
+#define DRM_OBJECT_MAX_PROPERTY 24 struct drm_object_properties { int count; uint32_t ids[DRM_OBJECT_MAX_PROPERTY]; -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: Lots of i915/drm spew on 3.4

2012-05-31 Thread Paulo Zanoni
connector in the new kernel (and maybe this is also not a bug/regression...). -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] drm: increase DRM_OBJECT_MAX_PROPERTY to 24

2012-06-12 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Before Kernel 3.5, no one was checking for the return value of drm_connector_attach_property, so we never noticed that we were unable to create some properties. Commit drm: WARN() when drm_connector_attach_property fails added a WARN when we fail

Re: [Intel-gfx] [pull] drm-intel-next

2012-09-14 Thread Paulo Zanoni
-intel-next drm/fb helper: don't call drm_helper_connector_dpms directly Jani Nikula (2): drm/i915: only enable sdvo hotplug irq if needed drm/i915: fix sdvo hotplug support check and activation Paulo Zanoni (3): drm/i915: add gen7_render_ring_flush drm

Re: [Intel-gfx] [PATCH 2/4] drm/dp: Update DPCD defines

2012-09-20 Thread Paulo Zanoni
that this will affect patch 4 of this series. Idea for a follow-up patch: maybe we should try to add some comments explaining which bits appeared only in some specific DPCD x.y revision? With the bit 7 problem fixed somehow: Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com +# define

Re: [PATCH 2/2] drm/dp: Make sink count DP 1.2 aware

2012-09-20 Thread Paulo Zanoni
2012/9/20 Adam Jackson a...@redhat.com: Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/intel_dp.c |9 - include/drm/drm_dp_helper.h |3 ++- 2 files changed, 6 insertions(+), 6 deletions(-) diff

Re: [Intel-gfx] [PATCH 0/3] drm/i915: eDP scaling mode change support

2012-10-26 Thread Paulo Zanoni
could check it still does what it says on the box! I have nothing to add or remove. Tested on HSW eDP, used xrandr to alternate the property values. Works fine. Being consistent on the default value between LVDS and eDP is certainly a nice thing. For the 3 patches: Reviewed-by: Paulo Zanoni

[PATCH] drm/i915: set the AVI VIC of the HDMI mode

2012-11-21 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com We currently set 0 as the VIC value of the AVI InfoFrames. According to the specs this should be fine and work for every mode, so to my point of view we can't consider the current behavior as a bug. The problem is that we recently received a bug report

Re: [PATCH] drm/i915: set the AVI VIC of the HDMI mode

2012-11-23 Thread Paulo Zanoni
Hi 2012/11/22 Thierry Reding thierry.red...@avionic-design.de: On Wed, Nov 21, 2012 at 01:39:48PM -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com We currently set 0 as the VIC value of the AVI InfoFrames. According to the specs this should be fine and work for every

[PATCH 1/2] drm: add drm_mode_cea_vic

2012-11-23 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com This function returns the VIC of the mode. This value can be used when creating AVI InfoFrames. Cc: Thierry Reding thierry.red...@avionic-design.de Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=50371 Signed-off-by: Paulo Zanoni paulo.r.zan

[PATCH 2/2] drm/i915: set the VIC of the mode on the AVI InfoFrame

2012-11-23 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com We currently set 0 as the VIC value of the AVI InfoFrames. According to the specs this should be fine and work for every mode, so to my point of view we can't consider the current behavior as a bug. The problem is that we recently received a bug report

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Paulo Zanoni
___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC v2 5/5] drm/i915: Use generic HDMI infoframe helpers

2012-12-06 Thread Paulo Zanoni
Hi 2012/12/6 Paulo Zanoni przan...@gmail.com: Hi 2012/12/5 Thierry Reding thierry.red...@avionic-design.de: Use the generic HDMI infoframe helpers to get rid of the duplicate implementation in the i915 driver. A few comments: - I've compiled your patches and now intel_infoframes -d tells

Re: [RFC v2 2/5] video: Add generic HDMI infoframe helpers

2012-12-07 Thread Paulo Zanoni
___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

[RFC] drm/i915: Use generic HDMI infoframe helpers

2012-12-07 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com Use the generic HDMI infoframe helpers to get rid of the duplicate implementation in the i915 driver. This patch is based on the initial patch by Thierry Reding, but with a different approach. TODO: - The SDVO part is totally untested. I am not sure

Re: [Intel-gfx] [PATCH 3/4] drm/edid: Add drm_rgb_quant_range_selectable()

2013-01-17 Thread Paulo Zanoni
correct (checked against the spec, did not really test). Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com See below for optional bikeshedding: Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/drm_edid.c | 33 + include/drm

Re: [PATCH 4/4] drm/i915: Provide the quantization range in the AVI infoframe

2013-01-17 Thread Paulo Zanoni
DIP_AVI_QUANTIZATION_LIMITED (1 2) #define DIP_AVI_QUANTIZATION_FULL (2 2) bikeshedding optional=true Everything else looks fine. With or without that: Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com Also, these things kinda conflict with Thierry's patches, but I know you're aware because you've

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Fix RGB color range property for PCH platforms

2013-01-17 Thread Paulo Zanoni
patches Things look correct. As you mention, the only problem seems to be the Haswell. I could not find anything on the specs, so I think we should send some emails and maybe consider removing the property on Haswell? If-you-promise-to-find-a-solution-for-the-Haswell-case: Reviewed-by: Paulo Zanoni

Re: [PATCH 2/4] drm/i915: Add Automatic mode for the Broadcast RGB property

2013-01-17 Thread Paulo Zanoni
has weird colors bugs. Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/i915_drv.h|4 +++ drivers/gpu/drm/i915/intel_dp.c| 28 ++--- drivers/gpu/drm/i915/intel_drv.h

Re: [Intel-gfx] [PATCH 2/9] drm/i915: Use cpu_transcoder for HSW_TVIDEO_DIP_* instead of pipe

2013-01-31 Thread Paulo Zanoni
about this patch (besides the sentence above) would be due to using more than 80 columns, both on the commit message and coding :) Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com --- drivers/gpu/drm/i915/i915_reg.h | 16

Re: [PATCH 5/9] drm/i915: Setup EDP PSR AUX Registers

2013-01-31 Thread Paulo Zanoni
intel_connector *attached_connector; }; -- 1.7.11.7 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paulo Zanoni ___ dri-devel mailing list

Re: [PATCH 7/9] drm/i915: Enable/Disable PSR on HSW

2013-01-31 Thread Paulo Zanoni
*/ -- 1.7.11.7 ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

[PATCH] drm: don't add inferred modes for monitors that don't support them

2013-02-15 Thread Paulo Zanoni
From: Paulo Zanoni paulo.r.zan...@intel.com If bit 0 of the features byte (0x18) is set to 0, then, according to the EDID spec, the display is non-continuous frequency (multi-mode) and is only specified to accept the video timing formats that are listed in Base EDID and certain Extension Blocks

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Use cpu_transcoder for HSW_TVIDEO_DIP_* instead of pipe

2013-02-27 Thread Paulo Zanoni
for TRANSCODER_EDP. v2: Adding HSW_TVIDEO_DIP_VSC_DATA to transmit vsc to eDP. Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 18 ++ drivers/gpu/drm/i915/intel_hdmi.c | 13

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Added SDP and VSC structures for handling PSR for eDP

2013-02-27 Thread Paulo Zanoni
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [git pull] drm merge for 3.9-rc1

2013-02-28 Thread Paulo Zanoni
://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 6/8] drm/i915: Enable/Disable PSR

2013-02-28 Thread Paulo Zanoni
-devel -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Enable/Disable PSR

2013-02-28 Thread Paulo Zanoni
___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http

Re: [Intel-gfx] [git pull] drm merge for 3.9-rc1

2013-02-28 Thread Paulo Zanoni
Hi 2013/2/28 Sedat Dilek sedat.di...@gmail.com: On Thu, Feb 28, 2013 at 6:12 PM, Sedat Dilek sedat.di...@gmail.com wrote: On Thu, Feb 28, 2013 at 3:31 PM, Paulo Zanoni przan...@gmail.com wrote: Hi 2013/2/28 Chris Wilson ch...@chris-wilson.co.uk: On Thu, Feb 28, 2013 at 12:06:28AM +0100

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Added debugfs support for PSR Status

2013-02-28 Thread Paulo Zanoni
EDP_PSR_DEBUG_MASK_MEMUP (126) -- 1.8.1.2 ___ Intel-gfx mailing list intel-...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Paulo Zanoni ___ dri-devel mailing list dri

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Hook PSR functionality

2013-02-28 Thread Paulo Zanoni
/listinfo/intel-gfx -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [Intel-gfx] [PATCH 0/8] Enable eDP PSR functionality at HSW - v3

2013-02-28 Thread Paulo Zanoni
-- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/4] drm: Add drm_mode_equal_no_clocks()

2013-04-17 Thread Paulo Zanoni
dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 0/4] drm/edid: Recognize 60Hz and 59.94Hz CEA modes

2013-04-17 Thread Paulo Zanoni
RGB quantization range in automatic mode Everything looks correct, but I really didn't test anything. If you apply my comments from patch 2, then you have Reviewed-by: Paulo Zanoni paulo.r.zan...@intel.com for all the 4 patches. Optional bikeshedding: you could add a follow-up patch fixing

Re: [PATCH 11/11] drm/i915: Hook PSR functionality

2013-06-28 Thread Paulo Zanoni
whenever panel is disabled/enabled. v5: make it last patch to avoid breaking whenever bisecting. So calling for update and force exit came to this patch along with enable/disable calls. CC: Paulo Zanoni paulo.r.zan...@intel.com Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com

Re: [PATCH 2/2] drm/i915: add fast boot support for Haswell

2013-08-20 Thread Paulo Zanoni
://lists.freedesktop.org/mailman/listinfo/dri-devel -- Paulo Zanoni ___ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel

  1   2   3   >