Re: [RFC v2 0/5] Common Display Framework

Hi Thierry, Am Freitag, den 23.11.2012, 20:56 +0100 schrieb Thierry Reding: On Thu, Nov 22, 2012 at 10:45:31PM +0100, Laurent Pinchart wrote: [...] Display entities are accessed by driver using notifiers. Any driver can register a display entity notifier with the CDF, which then calls the

Re: [RFC v2 2/5] video: panel: Add DPI panel support

height; /* Panel height in mm */ + const struct videomode *mode; +}; + +#endif /* __PANEL_DPI_H__ */ From: Philipp Zabel p.za...@pengutronix.de Date: Thu, 29 Nov 2012 19:18:30 +0100 Subject: [PATCH] video: panel: Add device tree support to the DPI panel driver Signed-off

Re: [PATCHv15 3/7] video: add of helper for display timings/videomode

Hi, Am Montag, den 26.11.2012, 18:56 +0200 schrieb Tomi Valkeinen: On 2012-11-26 18:10, Steffen Trumtrar wrote: Hi, On Mon, Nov 26, 2012 at 04:38:36PM +0200, Tomi Valkeinen wrote: +optional properties: + - hsync-active: hsync pulse is active low/high/ignored + - vsync-active:

[PATCH 5/7] staging: drm/imx: ipu-dc: add WCLK/WRG opcodes

Add WRG and WCLK opcodes to the display controller microcode, and allow multi instruction codes. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 39 - 1 file changed, 24 insertions(+), 15 deletions(-) diff --git

[PATCH 4/7] staging: drm/imx: Add support for VGA via TVE on i.MX53

on i.MX53-QSB uses pin7/pin8, and the analog part of the DVI-I connector on MBa53 connects to pin4/pin6. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 15 - drivers/staging/imx-drm/imx-drm.h | 4 +- drivers/staging/imx-drm/ipu-v3/imx

[PATCH 2/7] staging: drm/imx: ipuv3-crtc: use external clock for TV Encoder

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-crtc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index b028b0d..620e571 100644 --- a/drivers/staging/imx-drm/ipuv3-crtc.c

[PATCH 7/7] staging: drm/imx: Add support for Television Encoder (TVEv2)

-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/Kconfig | 7 + drivers/staging/imx-drm/Makefile | 1 + drivers/staging/imx-drm/imx-tve.c | 755 ++ 3 files changed, 763 insertions(+) create mode 100644 drivers/staging/imx-drm/imx-tve.c

[PATCH 6/7] staging: drm/imx: ipu-dc: force black output during blanking

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c index 355b8a2..1cb0631 100644

[PATCH 0/7] i.MX53 IPU + TVE patches

Hi, the following patches allow to use the integrated Television Encoder (TVEv2) on the i.MX53 SoC as VGA output encoder for the IPU. This is useful for the Freescale i.MX53-QSB and TQ MBa53 boards, which have VGA and DVI-I connectors, respectively. regards Philipp ---

[PATCH 3/7] staging: drm/imx: ipu-di: add comments explaining signal generator configuration

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-di.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-di.c b/drivers/staging/imx-drm/ipu-v3/ipu-di.c index ec340da..26534b7 100644

Re: [PATCH 0/7] i.MX53 IPU + TVE patches

Hi Greg, Am Montag, den 08.04.2013, 10:40 -0700 schrieb Greg Kroah-Hartman: On Mon, Apr 08, 2013 at 06:04:31PM +0200, Philipp Zabel wrote: Hi, the following patches allow to use the integrated Television Encoder (TVEv2) on the i.MX53 SoC as VGA output encoder for the IPU

[PATCH 0/2] i.MX53 IPU + TVE patches

Hi, converting the IPU IRQ handling to use irq_domain_add_linear is listed in drivers/staging/imx-drm/TODO as one of the tasks to be done before the IPU driver can be moved out of staging. These patches fix the number IPU_NUM_IRQS and add a linear irq domain. regards Philipp ---

[PATCH 1/2] staging: drm/imx: fix number of IPU IRQs

There are 15 32-bit registers altogether. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-prv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-prv.h b/drivers/staging/imx-drm/ipu-v3/ipu-prv.h

Re: [PATCH 0/2] i.MX53 IPU + TVE patches

Am Freitag, den 21.06.2013, 10:27 +0200 schrieb Philipp Zabel: Hi, Sorry, copy paste error. The correct subject is IPU linear irq domain: converting the IPU IRQ handling to use irq_domain_add_linear is listed in drivers/staging/imx-drm/TODO as one of the tasks to be done before the IPU

[PATCH 3/4] staging: drm/imx: ipuv3-crtc: immediately update crtc-fb in ipu_page_flip

Since commit 8cf1e9811471f2910fa38dc1b28e1789080ba961 (drm: Add consistency check for page-flipping) drm_mode_page_flip_ioctl contains a WARN_ON that triggers if the .page_flip callback didn't update the crtc-fb pointer to the new framebuffer immediately. Signed-off-by: Philipp Zabel p.za

[PATCH 0/4] IPU DMFC bandwidth allocation fix and cleanups

Hi, the following patches remove some unused variables, replace some hard-coded channel numbers with existing descriptive defines, fix the DMFC bandwidth (or rather: FIFO space) allocation, and update ipu_page_flip() to immediately set crtc-fb. regards Philipp ---

[PATCH 1/4] staging: drm/imx: remove unused variables

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 3 --- drivers/staging/imx-drm/ipuv3-crtc.c | 5 - 2 files changed, 8 deletions(-) diff --git a/drivers/staging/imx-drm/imx-drm-core.c b/drivers/staging/imx-drm/imx-drm-core.c index 6455305

[PATCH 2/4] staging: drm/imx: ipu-dmfc: fix bandwidth allocation

The IPU can request up to four pixels per access, which gives four times the bandwidth compared to what the driver currently assumes. After correcting this, we have to increase safety margins for bandwidth requirement calculations. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers

[PATCH 4/4] staging: drm/imx: ipu-dmfc: use defines for ipu channel numbers

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c b/drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c index 1dc9817..2e97c33 100644

[PATCH 1/2] staging: drm/imx: use generic irqchip

This depends on the patch genirq: Generic chip: Add linear irq domain support and removes the custom IPU irq_chip and irq_domain_ops. Instead, the generic irq chip implementation is reused. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 90

[PATCH 2/2] staging: drm/imx: use generic irq chip unused field to block out invalid irqs

This depends on the patch genirq: irqchip: Add mask to block out invalid irqs and masks out reserved bits using the unused interrupt bitfield. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 11 +++ 1 file changed, 11 insertions

[PATCH 0/2] IPU generic irq chip

Hi, with linear domain support in the generic irq chip framework, we can drop the custom irq_chip / irq_domain_ops altogether and use the generic irq chip implementation instead. The following two patches depend on genirq: Generic chip: Add linear irq domain support and genirq: irqchip: Add mask

Re: [PATCH/RFC v3 06/19] video: display: OF support

Hi Laurent, thanks for this update. I'm very happy about the move to the display entity model, given that the i.MX6 IPU has both drm/display and v4l2/capture ports in a single device - this will allow to use a unified device tree binding scheme. I'm still trying to see how this all fits together,

Re: [PATCH 0/3] refactor some ldb related clocks

Am Dienstag, den 20.08.2013, 16:38 +0800 schrieb Liu Ying: The ldb_di[0/1]_ipu_div clock dividers in the CSCMR2 register of i.MX53, i.MX6Q and i.MX6DL SoCs can be configured to a 1/3.5 drivider or a 1/7 divider. The common clock framework cannot deal with the two dividers directly even with

Re: [PATCH/RFC v3 06/19] video: display: OF support

Hi Laurent, Am Mittwoch, den 21.08.2013, 03:02 +0200 schrieb Laurent Pinchart: Hi Philipp, On Tuesday 13 August 2013 16:37:07 Philipp Zabel wrote: Hi Laurent, thanks for this update. I'm very happy about the move to the display entity model, given that the i.MX6 IPU has both drm

Re: [PATCH/RFC v3 06/19] video: display: OF support

Hi Laurent, I have another small issue with the graph helpers below: Am Samstag, den 10.08.2013, 01:03 +0200 schrieb Laurent Pinchart: [...] +/* - * Graph Helpers */ @@ -420,6 +599,161 @@ int

Re: [PATCH/RFC v3 06/19] video: display: OF support

Hi Laurent, Am Samstag, den 10.08.2013, 01:03 +0200 schrieb Laurent Pinchart: Extend the notifier with DT node matching support, and add helper functions to build the notifier and link entities based on a graph representation in DT. Signed-off-by: Laurent Pinchart

Re: [PATCH/RFC v3 06/19] video: display: OF support

Am Mittwoch, den 11.09.2013, 13:33 +0200 schrieb Laurent Pinchart: Hi Philipp, On Wednesday 04 September 2013 16:21:38 Philipp Zabel wrote: Am Samstag, den 10.08.2013, 01:03 +0200 schrieb Laurent Pinchart: Extend the notifier with DT node matching support, and add helper functions

[PATCH 02/11] staging: drm/imx: make struct ipu_rgb format definitions const

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 2 +- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 12 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h b/drivers/staging

[PATCH 0/11] i.MX RGB565, plane and PRIME support

Hi, This series fixes DMFC allocation for small displays and pageflip events during device close, clarifies the RGB memory formats, adds support for the RGB565 format and KMS planes, and enables DRM PRIME using the CMA helpers. In the next step, I would like to move the code from

[PATCH 03/11] staging: drm/imx: fix RGB formats, make ipu_cpmem_set_fmt take a drm_fourcc

internal representation. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 121 +++- 2 files changed, 100 insertions(+), 22 deletions(-) diff --git a/drivers/staging/imx-drm

[PATCH 04/11] staging: drm/imx: add BGR565 format

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-common.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-common.c b/drivers/staging/imx-drm/ipu-v3/ipu-common.c index 54466df..f90bdb4 100644

[PATCH 06/11] staging: drm/imx: make waiting for idle channel optional

-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/imx-ipu-v3.h | 1 + drivers/staging/imx-drm/ipu-v3/ipu-common.c | 23 ++- drivers/staging/imx-drm/ipuv3-crtc.c| 1 + 3 files changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH 07/11] staging: drm-imx: add DRM_FORMAT_BGR888 to ipu crtc driver

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-crtc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index 574633b..f63931b 100644 --- a/drivers/staging/imx-drm/ipuv3

[PATCH 08/11] staging: drm/imx: ipuv3-crtc: remove unused struct ipu_framebuffer

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipuv3-crtc.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/imx-drm/ipuv3-crtc.c b/drivers/staging/imx-drm/ipuv3-crtc.c index f63931b..292abea 100644 --- a/drivers/staging/imx-drm/ipuv3

[PATCH 09/11] staging: drm/imx: fix pageflip events during device close

userspace is killed during a page flip. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 13 + drivers/staging/imx-drm/ipuv3-crtc.c | 9 ++--- 2 files changed, 15 insertions(+), 7

[PATCH 11/11] staging: drm/imx: Enable DRM PRIME support

Lets the IPU driver make use of the PRIME functionality introduced by the drm: GEM CMA: Add DRM PRIME support patch. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/imx-drm-core.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git

[PATCH 05/11] staging: drm/imx: Add 24-bit BGR support to DC

Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/ipu-v3/ipu-dc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dc.c b/drivers/staging/imx-drm/ipu-v3/ipu-dc.c index 21bf1c8..1a6e06d 100644 --- a/drivers/staging/imx

[PATCH 10/11] staging: drm/imx: add drm plane support

-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/staging/imx-drm/Makefile| 2 +- drivers/staging/imx-drm/TODO| 1 - drivers/staging/imx-drm/imx-drm-core.c | 5 + drivers/staging/imx-drm/imx-drm.h | 2 + drivers/staging/imx-drm/ipu-v3/ipu

[PATCH 01/11] staging: drm/imx: also allow to allocate only 2 DMFC slots for DP full plane

Connecting a 320x240 parallel display on i.MX6 resulted in an invalid DRDY signal because the DC would not receive NL/EOL events on every line. Reducing the allocated DMFC space from 4 slots (256 * 128-bit) to 2 slots (128 * 128-bit) solved the problem. Signed-off-by: Philipp Zabel p.za

Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge

On Mon, 2017-02-06 at 10:53 -0600, Rob Herring wrote: > On Mon, Feb 06, 2017 at 11:42:48AM +0100, Philipp Zabel wrote: > > On Fri, 2017-02-03 at 21:36 -0600, Rob Herring wrote: > > > Many drivers have a common pattern of searching the OF graph for either an > > &g

Re: [PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

rm_crtc indirection. > Functions ipu_enable_vblank() and ipu_disable_vblank() are moved around > without changes, only for saving the forward declarations. > > Signed-off-by: Shawn Guo <shawn@linaro.org> > Cc: Philipp Zabel <p.za...@pengutronix.de> Acked

Re: [PATCH v4] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

On Fri, 2017-02-03 at 15:20 +0200, Ville Syrjälä wrote: > On Fri, Feb 03, 2017 at 10:31:39AM +0100, Philipp Zabel wrote: > > Use drm_plane_helper_check_state to clip raw user coordinates to crtc > > bounds. This checks for full plane coverage and scaling already, so > > we

Re: [PATCH v4] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

On Tue, 2017-02-07 at 13:19 +0200, Ville Syrjälä wrote: > On Tue, Feb 07, 2017 at 09:51:50AM +0100, Philipp Zabel wrote: > > On Fri, 2017-02-03 at 15:20 +0200, Ville Syrjälä wrote: > > > On Fri, Feb 03, 2017 at 10:31:39AM +0100, Philipp Zabel wrote: > > > > Use drm_pl

Re: [PATCH] drm/imx: imx-tve: Make the 'dac' regulator optional

On Fri, 2017-02-03 at 10:52 -0200, Fabio Estevam wrote: > Hi Philipp, > > On Tue, Jan 3, 2017 at 5:11 PM, Fabio Estevam wrote: > > From: Fabio Estevam > > > > Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by > >

Re: [PATCH 1/5] of: introduce of_graph_get_remote_node

On Mon, 2017-02-06 at 07:54 -0600, Rob Herring wrote: > On Mon, Feb 6, 2017 at 4:32 AM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > Hi Rob, > > > > thanks for this clean-up series! I was not aware how far the duplication > > has spread over time. > >

Re: [PATCH 1/5] of: introduce of_graph_get_remote_node

; > + if (!endpoint_node) { > + pr_debug("no valid endpoint (%d, %d) for node %s\n", > + port, endpoint, node->full_name); > + return NULL; > + } > + > + remote = of_graph_get_remote_port_parent(endpoint_node); > + of_n

Re: [PATCH 2/5] drm: of: introduce drm_of_find_panel_or_bridge

On Fri, 2017-02-03 at 21:36 -0600, Rob Herring wrote: > Many drivers have a common pattern of searching the OF graph for either an > attached panel or bridge and then finding the DRM struct for the panel > or bridge. Also, most drivers need to handle deferred probing when the > DRM device is not

Re: [PATCH 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

On Fri, 2017-02-03 at 21:36 -0600, Rob Herring wrote: > Similar to the previous commit, convert drivers open coding OF graph > parsing to use drm_of_find_panel_or_bridge instead. > > This changes some error messages to debug messages (in the graph core). > Graph connections are often "no

Re: [PATCH 3/5] drm: convert drivers to use of_graph_get_remote_node

node_put(port); > - > - remote = of_graph_get_remote_port_parent(ep); > - if (!remote) { > - dev_err(dev, "Missing connector/bridge node for endpoint %s\n", > - ep->full_name); > - of_node_put(ep); > - return -EIN

Re: [PATCH] drm/imx: imx-tve: Make the 'dac' regulator optional

On Tue, 2017-02-07 at 18:09 +0100, Lucas Stach wrote: > Am Dienstag, den 07.02.2017, 17:45 +0100 schrieb Philipp Zabel: > > On Fri, 2017-02-03 at 10:52 -0200, Fabio Estevam wrote: > > > Hi Philipp, > > > > > > On Tue, Jan 3, 2017 at 5:11 PM, Fabio Estevam <

Re: [PATCH] drm/imx: imx-tve: Make the 'dac' regulator optional

On Tue, 2017-02-07 at 14:52 -0200, Fabio Estevam wrote: > Hi Philipp, > > On Tue, Feb 7, 2017 at 2:45 PM, Philipp Zabel <p.za...@pengutronix.de> wrote: > > > I've applied this to the fixes branch, since the current device trees > > don't have the regulator set. >

[PATCH v4] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

Use drm_plane_helper_check_state to clip raw user coordinates to crtc bounds. This checks for full plane coverage and scaling already, so we can drop some custom checks. Use the clipped coordinates everywhere. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: P

[PATCH] drm/fourcc: add vivante tiled layout format modifiers

Vivante GC hardware uses simple 4x4 tiled and nested 64x64 supertiled formats as well as so-called split-tiled variants for dual-pipe hardware, where even and odd tiles start at different base addresses. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- include/uapi/drm/drm_fourcc.

Re: [PATCH] drm/fourcc: add vivante tiled layout format modifiers

On Thu, 2017-01-26 at 19:29 +0100, Wladimir J. van der Laan wrote: > Reviewed-By: Wladimir J. van der Laan Thank you. > I do wonder whether we'll need the split formats in practice - > e.g. the GC3000 on the i.MX6qp, for which I suppose this is being done because > of tiled

Re: [PATCH 1/9] gpu: ipu-v3: remove AXI ID setting for IC channel

On Fri, 2017-02-17 at 19:28 +0100, Lucas Stach wrote: > This is a pretty minor optimization for the IC channel to get > out-of-order AXI returns, but clashes with the AXI ID assignment > that needs to be done for the display channels on QuadPlus. > > Signed-off-by: Lucas Stach

Re: imxdrm issue on SABRE Lite

Hi Dan, On Sat, 2017-02-11 at 21:09 +, Dan MacDonald wrote: > Hi Phillipp > > I'm having trouble getting xf86-video-armada working properly on a > Element 14 / Embest SABRE Lite board running Arch Linux with kernel > 4.9.8. I have been in touch with RMK and he's confident the crash > below is

Re: [PATCH v5] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

On Mon, 2017-02-20 at 14:30 +0100, Philipp Zabel wrote: > Use drm_plane_helper_check_state to clip raw user coordinates to crtc > bounds. This checks for full plane coverage and scaling already, so > we can drop some custom checks. Use the clipped coordinates everywhere. > > Sugg

Re: [PATCH 2/9] gpu: ipu-v3: add DT binding for the Prefetch Resolve Engine

On Fri, 2017-02-17 at 19:28 +0100, Lucas Stach wrote: > The Prefetch Resolve Engine is a prefetch and tile resolve engine > which prefetches display data from DRAM to an internal SRAM region. > It has a single clock for configuration register access and the > functional units. A single shared

Re: [PATCH 5/9] gpu: ipu-v3: add driver for Prefetch Resolve Gasket

On Fri, 2017-02-17 at 19:28 +0100, Lucas Stach wrote: > This adds support for the i.MX6 QUadPlus PRG unit. It glues together the > IPU and the PRE units. > > Signed-off-by: Lucas Stach > --- > drivers/gpu/ipu-v3/Makefile | 2 +- > drivers/gpu/ipu-v3/ipu-prg.c | 413 >

[PATCH v5] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

Use drm_plane_helper_check_state to clip raw user coordinates to crtc bounds. This checks for full plane coverage and scaling already, so we can drop some custom checks. Use the clipped coordinates everywhere. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: P

[PATCH v6] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

Use drm_plane_helper_check_state to clip raw user coordinates to crtc bounds. This checks for full plane coverage and scaling already, so we can drop some custom checks. Use the clipped coordinates everywhere. Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: P

Re: [PATCH 3/9] gpu: ipu-v3: add driver for Prefetch Resolve Engine

On Fri, 2017-02-17 at 19:28 +0100, Lucas Stach wrote: > This adds support for the i.MX6 QuadPlus PRE units. Currently only > linear prefetch into SRAM is supported, other modes of operation > like the tiled-to-linear conversion will be added later. > > Signed-off-by: Lucas Stach

[PATCH] drm/imx: lift 64x64 pixel minimum framebuffer size requirement

There is no reason to limit framebuffer size to 64x64 pixels at a minimum on creation. The actual scanout limitations (width >= 13 for the base plane and height >= 2) are checked in atomic_check. Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> --- drivers/gpu/drm/imx/imx-dr

Re: [PATCH v2] drm/imx: imx-tve: Do not set the regulator voltage

On Wed, 2017-02-08 at 10:47 -0200, Fabio Estevam wrote: > Commit deb65870b5d9d ("drm/imx: imx-tve: check the value returned by > regulator_set_voltage()") exposes the following probe issue: > > 63ff.tve supply dac not found, using dummy regulator > imx-drm display-subsystem: failed to bind

[PATCH] gpu: ipu-v3: export ipu_csi_set_downsize

This function will be used by the media drivers and needs to be exported to allow them to be built as modules. Reported-by: Russell King <li...@armlinux.org.uk> Fixes: 867341b95891 ("gpu: ipu-v3: add ipu_csi_set_downsize") Signed-off-by: Philipp Zabel <p.za...@pengutronix.de>

[PATCH] gpu: ipu-v3: Stop overwriting pdev->dev.of_node of child devices

Setting dev->of_node changes the modalias and breaks module autoloading. Since there is an of_node field in the platform data passed to child devices, we don't even need this anymore. Suggested-by: Russell King <li...@armlinux.org.uk> Signed-off-by: Philipp Zabel <p.za...@pe

[GIT PULL] imx-drm: TVE regulator, fb size limit, and ipu-v3 module fixes

t have an OF modalias to fix module autoloading. Fabio Estevam (1): drm/imx: imx-tve: Do not set the regulator voltage Philipp Zabel (3): drm/imx: lift 64x64 pixel minimum framebuffer size requirement gpu: ipu-v3:

[PATCH 10/10] drm/imx: ipuv3-plane: use drm_plane_helper_check_state, clipped coordinates

Am Freitag, den 21.10.2016, 16:49 +0800 schrieb Ying Liu: > On Fri, Oct 21, 2016 at 4:18 PM, Philipp Zabel > wrote: > > Am Freitag, den 21.10.2016, 13:45 +0800 schrieb Ying Liu: > >> On Thu, Oct 20, 2016 at 9:29 PM, Philipp Zabel > >> wrote: > >> >

[GIT PULL] imx-drm fixes for active plane reconfiguration, a build warning, and error handling

/vbo only when we don't need modeset drm/imx: ipuv3-plane: Access old u/vbo properly in ->atomic_check for YU12/YV12 Philipp Zabel (2): drm/imx: ipuv3-plane: make sure x/y offsets are even in case of chroma subsampling drm/imx: ipuv3-plane: disable local alpha for planes with

[PATCH] drm/imx: Fix of_node ref counting

Hi Christophe, Am Sonntag, den 04.09.2016, 08:45 +0200 schrieb Christophe JAILLET: > This code is spurious. > It takes a ref on a node, then call 'of_node_put' on it and then store > this node somewhere. The node pointer is not stored. Note that np is not dereferenced at all, we just compare the

[PATCH] drm/imx: Fix of_node ref counting

Am Montag, den 05.09.2016, 10:01 +0200 schrieb Philipp Zabel: > Hi Christophe, > > Am Sonntag, den 04.09.2016, 08:45 +0200 schrieb Christophe JAILLET: > > This code is spurious. > > It takes a ref on a node, then call 'of_node_put' on it and then store > > this no

[PATCH v4 0/4] IPUv3 prep for i.MX5/6 v4l2 staging drivers, v4

Am Montag, den 05.09.2016, 11:41 -0300 schrieb Fabio Estevam: > Hi Philipp, > > On Thu, Aug 25, 2016 at 11:17 AM, Tim Harvey wrote: > > > Philipp, > > > > Have you had a chance to review this last series of Steve's submitted > > last week? We are down to 4 patches in gpu/ipu-v3 needed in order

[PATCH v4 3/4] gpu: ipu-ic: Add complete image conversion support with tiling

Hi Steve, Am Mittwoch, den 17.08.2016, 17:50 -0700 schrieb Steve Longerbeam: > This patch implements complete image conversion support to ipu-ic, > with tiling to support scaling to and from images up to 4096x4096. > Image rotation is also supported. > > The internal API is subsystem agnostic

[PATCH v4 4/4] gpu: ipu-ic: allow multiple handles to ic

Am Mittwoch, den 17.08.2016, 17:50 -0700 schrieb Steve Longerbeam: > The image converter kernel API supports conversion contexts and > job queues, so we should allow more than one handle to the IC, so > that multiple users can add jobs to the queue. The image converter queue can be shared, but

[PATCH] gpu: Remove depends on RESET_CONTROLLER when not a provider

t; drivers/usb/chipidea/Kconfig:1: symbol USB_CHIPIDEA depends on USB_EHCI_HCD > drivers/usb/host/Kconfig:84:symbol USB_EHCI_HCD depends on USB > > Cc: Arnd Bergmann > Cc: Heiko Stuebner > Cc: Mark Yao > Cc: Philipp Zabel > Cc: Peter Chen > Signed-off-by: Stephen Boyd Acked-by: Philipp Zabel thanks Philipp

[PATCH v4 0/7] drm/imx: Add active plane reconfiguration support

Hi Dave, Am Montag, den 29.08.2016, 17:44 +0200 schrieb Daniel Vetter: > On Mon, Aug 29, 2016 at 4:59 PM, Philipp Zabel > wrote: > > Am Montag, den 29.08.2016, 12:53 +0200 schrieb Philipp Zabel: > >> Am Freitag, den 26.08.2016, 15:30 +0800 schrieb Liu Ying: > >>

[PATCH v4 3/4] gpu: ipu-ic: Add complete image conversion support with tiling

Hi Steve, thanks for the update. Am Mittwoch, den 14.09.2016, 18:45 -0700 schrieb Steve Longerbeam: > Hi Philipp, > > > On 09/06/2016 02:26 AM, Philipp Zabel wrote: > > Hi Steve, > > > > Am Mittwoch, den 17.08.2016, 17:50 -0700 schrieb Steve Longerbeam: >

[PATCH v6] drm: bridge/dw_hdmi: add dw hdmi i2c bus adapter support

t; >> Changes from v3 to v4, thanks to Doug and Philipp for review: > >> * set speed mode after software reset in dw_hdmi_i2c_init() > >> * by default set standard speed mode instead of fast speed mode, on iMX6Q > >> this configures SCL to 100 KHz, which is comp

[PATCH V2] drm/panel: simple: Fix bus flags for ortustech com43h4m85ulc

Hi Thierry, Am Freitag, den 16.09.2016, 17:17 +0200 schrieb Thierry Reding: > On Fri, Aug 26, 2016 at 06:26:00PM +0200, Marek Vasut wrote: > > This display expects DE pin and data lines to be active high, > > add the necessary flags. > > > > Signed-off-by: Marek V

[PATCH v6] drm: bridge/dw_hdmi: add dw hdmi i2c bus adapter support

Am Freitag, den 16.09.2016, 20:38 +0300 schrieb Vladimir Zapolskiy: > Hi Philipp, [...] > >> as far as I know David accepts pull requests from you, can you please > >> create and send a pull request for v4.9 containing these changes? > >> > >> https://patchwork.kernel.org/patch/9284717/ --

[GIT PULL] bridge/dw-hdmi: I2C master controller support

Hi Dave, this tag contains support for the I2C master controller contained in the HDMI TX IP core, for those boards that don't allow to mux their DDC pins to SoC I2C controllers. This will make the dw-hdmi driver register its internal I2C master if the ddc-i2c-bus property is not set on the

[GIT PULL] imx-drm fixes, cleanups, image conversion

drm/imx: fold ipu_plane_disable into ipu_disable_plane drm/imx: add exclusive fence to plane state drm/imx: imx-ldb: detach panel on unbind Philipp Zabel (2): drm/imx: imx-ldb: detach bridge on unbind drm/imx: parallel-display: detach bridge or panel on unbind Steve Long

[GIT PULL] imx-drm fixes, cleanups, image conversion

Am Montag, den 19.09.2016, 17:37 +1000 schrieb Dave Airlie: > On 19 September 2016 at 17:31, Philipp Zabel > wrote: > > Hi Dave, > > > > please consider merging this tag containing the latest active plane > > reconfiguration patches, several fixes and cleanups, an

[PATCH 3/3] drm/imx: ipuv3-plane: Access old u/vbo properly in ->atomic_check for YU12/YV12

Hi Liu, Am Montag, den 10.10.2016, 14:50 +0800 schrieb Liu Ying: > Before accessing the u/v offset(aka, u/vbo for IPUv3) of the old plane state's > relevant fb, we should make sure the fb is in YU12 or YV12 pixel format(which > are the two YUV pixel formats we support only), otherwise, we are

[patch] drm/imx: drm_dev_alloc() returns error pointers

Am Donnerstag, den 13.10.2016, 11:53 +0300 schrieb Dan Carpenter: > We are checking for NULL here, when we should be checking for error > pointers. > > Fixes: 54db5decce17 ("drm/imx: drop deprecated load/unload drm_driver ops") > Signed-off-by: Dan Carpenter > > diff --git

[PATCH -next] gpu: ipu-v3: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

Am Mittwoch, den 21.09.2016, 15:12 + schrieb Wei Yongjun: > From: Wei Yongjun > > Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). > > Generated by: scripts/coccinelle/api/err_cast.cocci > > Signed-off-by: Wei Yongjun > --- > drivers/gpu/ipu-v3/ipu-image-convert.c | 2 +- >

[PATCH 3/3] drm/imx: ipuv3-plane: Access old u/vbo properly in ->atomic_check for YU12/YV12

Am Dienstag, den 18.10.2016, 11:39 +0800 schrieb Liu Ying: [...] > >> @@ -359,7 +359,7 @@ static int ipu_plane_atomic_check(struct drm_plane > >> *plane, > >> if ((ubo > 0xf8) || (vbo > 0xf8)) > >> return -EINVAL; > >> > >> - if (old_fb) { >

[PATCH v2] drm/imx: ipuv3-plane: Access old u/vbo properly in ->atomic_check for YU12/YV12

Am Dienstag, den 18.10.2016, 16:44 +0800 schrieb Liu Ying: > Before accessing the u/v offset(aka, u/vbo for IPUv3) of the old plane state's > relevant fb, we should make sure the fb is in YU12 or YV12 pixel format(which > are the two YUV pixel formats we support only), otherwise, we are likely to

[PATCH 1/9] drm/imx: ipuv3-plane: make sure x/y offsets are even in case of chroma subsampling

Odd x/y offsets are not allowed for chroma subsampled planar YUV formats. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 5c34299..3a03fd8

[PATCH 4/9] drm/imx: ipuv3-plane: merge ipu_plane_atomic_set_base into atomic_update

into ipu_plane_atomic_update, making the actual code flow more obvious as a result. Also remove the duplicate planar format comment, which is already found in ipu_plane_atomic_check. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 97 ++- 1

[PATCH 2/9] drm/imx: ipuv3-plane: disable local alpha for planes without alpha channel

-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 3a03fd8..d4a771c 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -434,6

[PATCH 5/9] drm/imx: ipuv3-plane: let drm_plane_state_to_ubo/vbo handle chroma subsampling other than 4:2:0

To support 4:2:2 or 4:4:4 chroma subsampling, divide the x/y offsets in drm_plane_state_to_ubo/vbo only if necessary for the given pixel format. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions

[PATCH 8/9] drm/imx: ipuv3-plane: add support for YUV 4:2:2 and 4:4:4, NV12, and NV16 formats

Hook up support for DRM_FORMAT_YUV422, DRM_FORMAT_YVU422, DRM_FORMAT_YUV444, DRM_FORMAT_YVU444, DRM_FORMAT_NV12, and DRM_FORMAT_NV16. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 52 +-- 1 file changed, 44 insertions(+), 8 deletions

[PATCH 9/9] gpu: ipu-v3: initially clear all interrupts

If we want to stop resetting the IPU in the future, masking all interrupts before registering the irq handlers will not be enough to avoid spurious interrupts. We also have to clear them. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 5 - 1 file changed, 4 insertions

[PATCH 7/9] gpu: ipu-v3: add YUV 4:4:4 support

The IDMAC does support reading and writing DRM_FORMAT_YUV444 and DRM_FORMAT_YVU444. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-common.c | 2 ++ drivers/gpu/ipu-v3/ipu-cpmem.c | 17 + 2 files changed, 19 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-common.c b

[PATCH 6/9] gpu: ipu-cpmem: Add missing YVU422 case to ipu_cpmem_set_yuv_planar

ipu_cpmem_set_fmt is already prepared to handle DRM_FORMAT_YVU422. Signed-off-by: Philipp Zabel --- drivers/gpu/ipu-v3/ipu-cpmem.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/ipu-v3/ipu-cpmem.c b/drivers/gpu/ipu-v3/ipu-cpmem.c index fcb7dc8..e6b8bae 100644 --- a/drivers

[PATCH 3/9] drm/imx: ipuv3-plane: request modeset if plane offsets changed

If the framebuffer pixel format is planar YUV and unchanged, but the U or V plane offsets change, do not return an error, but request a modeset instead. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH 1/9] drm/imx: ipuv3-plane: make sure x/y offsets are even in case of chroma subsampling

Am Mittwoch, den 19.10.2016, 15:12 +0800 schrieb Ying Liu: > On Wed, Oct 19, 2016 at 12:07 AM, Philipp Zabel > wrote: > > Odd x/y offsets are not allowed for chroma subsampled planar YUV > > formats. > > > > Signed-off-by: Philipp Zabel > > --- > &

[PATCH 7/9] gpu: ipu-v3: add YUV 4:4:4 support

Am Mittwoch, den 19.10.2016, 15:47 +0800 schrieb Ying Liu: > On Wed, Oct 19, 2016 at 12:07 AM, Philipp Zabel > wrote: > > The IDMAC does support reading and writing DRM_FORMAT_YUV444 and > > DRM_FORMAT_YVU444. > > > > Signed-off-by: Philipp Zabel > > ---

  1   2   3   4   5   6   7   8   9   10   >