Re: [PATCH v6 1/7] drm/stm: ltdc: Fix leak of px clk enable in some error paths

2017-07-30 Thread Philippe CORNU
On 07/29/2017 04:32 PM, Archit Taneja wrote: > Hi Philippe, > > On 07/17/2017 01:10 PM, Philippe CORNU wrote: >> The pixel clock gets enabled early during init, since it's required >> in order to read registers. This pixel clock must be disabled if >> er

[PATCH v3 3/3] drm/panel: Add support for otm8009a panel driver

2017-07-17 Thread Philippe CORNU
This patch adds Orise Tech otm8009a 3.97" 480x800 TFT LCD panel driver (MIPI-DSI video mode). The panel backlight is managed through the DSI link. This panel driver is used in several STM32 boards. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Andrzej

[PATCH v3 2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

2017-07-17 Thread Philippe CORNU
The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using a MIPI-DSI video interface. Its backlight is managed through the DSI link. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/panel/orise

[PATCH v3 1/3] dt-bindings: Add vendor prefix for Orise Technology

2017-07-17 Thread Philippe CORNU
Orise Technology is headquartered in Taiwan and specializes in manufacture of Flat Panel Display Driver IC and Flat Panel Display Controller IC. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-

[PATCH v3 0/3] Add support for the otm8009a dsi panel

2017-07-17 Thread Philippe CORNU
the Orise Tech otm8009a 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode). This LCD panel is used in several STM32 boards. Philippe CORNU (3): dt-bindings: Add vendor prefix for Orise Technology dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel drm/panel: Add support

Re: [PATCH v2 3/3] drm/panel: Add support for otm8009a panel driver

2017-07-17 Thread Philippe CORNU
On 07/12/2017 04:12 PM, Andrzej Hajda wrote: > On 10.07.2017 11:02, Philippe CORNU wrote: >> This patch adds Orise Tech otm8009a 3.97" 480x800 TFT LCD >> panel driver (MIPI-DSI video mode). The panel backlight is >> managed through the DSI link. This panel driver i

Re: [PATCH v5 4/7] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-07-17 Thread Philippe CORNU
On 07/12/2017 08:05 AM, Archit Taneja wrote: > > > On 07/03/2017 02:11 PM, Philippe CORNU wrote: >> Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the >> Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. >> > >

[PATCH v6 5/7] dt-bindings: display: stm32: remove st-display-subsystem parent node requirement

2017-07-17 Thread Philippe CORNU
There is no need anymore to have a "st-display-subsystem" parent node in the device tree for the ltdc. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 1 - 1 fi

[PATCH v6 2/7] drm/stm: ltdc: Add panel-bridge support

2017-07-17 Thread Philippe CORNU
Add the panel-bridge support for both panels & bridges (used by DSI host & HDMI/LVDS bridges). Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Archit Taneja <arch...@codeaurora.org> --- drivers/gpu/drm/stm/Kconfig | 2 +- drivers/gpu/d

[PATCH v6 1/7] drm/stm: ltdc: Fix leak of px clk enable in some error paths

2017-07-17 Thread Philippe CORNU
The pixel clock gets enabled early during init, since it's required in order to read registers. This pixel clock must be disabled if errors during this init phase. Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/stm

[PATCH v6 3/7] dt-bindings: display: Add Synopsys DW MIPI DSI host controller

2017-07-17 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- .../bindings/display/bridge/dw_mipi_dsi.txt| 32 ++

Re: [PATCH v5 13/14] drm: stm: remove dead code and pointless local lut storage

2017-07-17 Thread Philippe CORNU
> Acked-by: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Peter Rosin <p...@axentia.se> Acked-by: Philippe Cornu <philippe.co...@st.com> Note: we will update stm32 clut support after your patch. Many thanks. > --- > drivers/gpu/drm/stm/ltdc.c | 12

[PATCH v6 0/7] STM32 DSI HOST

2017-07-17 Thread Philippe CORNU
pi dsi driver (rockchip/dw-mipi-dsi.c) modified for the stm32 family: - replace Rockchip digital & phy specific extensions with stm32's ones. - add a bridge Philippe CORNU (7): drm/stm: ltdc: Fix leak of px clk enable in some error paths drm/stm: ltdc: Add panel-bridge support dt

[PATCH v6 4/7] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-07-17 Thread Philippe CORNU
Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/Kconfig | 6 + drivers/gpu/drm/bridge/synopsy

[PATCH v6 6/7] dt-bindings: display: stm32: Add DSI controller

2017-07-17 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the STM32 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> Acked-by: Rob Herring <

[PATCH v6 7/7] drm/stm: Add STM32 DSI controller driver

2017-07-17 Thread Philippe CORNU
Add the STM32 DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> Reviewed-by: Archit Taneja <arch...@codeaurora.org> --- drivers/g

[PATCH v2 3/3] drm/panel: Add support for otm8009a panel driver

2017-07-10 Thread Philippe CORNU
This patch adds Orise Tech otm8009a 3.97" 480x800 TFT LCD panel driver (MIPI-DSI video mode). The panel backlight is managed through the DSI link. This panel driver is used in several STM32 boards. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/pa

[PATCH v2 2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

2017-07-10 Thread Philippe CORNU
The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using a MIPI-DSI video interface. Its backlight is managed through the DSI link. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- .../bindings/display/panel/orisetech,otm8009a.txt | 21 ++

[PATCH v2 1/3] dt-bindings: Add vendor prefix for Orise Technology

2017-07-10 Thread Philippe CORNU
Orise Technology is headquartered in Taiwan and specializes in manufacture of Flat Panel Display Driver IC and Flat Panel Display Controller IC. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/vendor-

[PATCH v2 0/3] Add support for the otm8009a dsi panel

2017-07-10 Thread Philippe CORNU
(Andrzej Hajda), Add an "Optional Properties" section (Rob Herring). Version 1: - Initial commit The purpose of this patch is to add support for the Orise Tech otm8009a 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode). This LCD panel is used in several STM32 boards. Philippe CORNU (3)

Re: [PATCH v1 2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

2017-07-10 Thread Philippe CORNU
On 07/10/2017 03:12 AM, Rob Herring wrote: > On Tue, Jul 04, 2017 at 06:30:04PM +0200, Philippe CORNU wrote: >> The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using >> a MIPI-DSI video interface. Its backlight is managed through the DSI link. >>

Re: [PATCH v6 0/7] STM32 DSI HOST

2017-07-18 Thread Philippe CORNU
On 07/18/2017 09:57 AM, Archit Taneja wrote: > > Hi, > > On 07/17/2017 01:10 PM, Philippe CORNU wrote: >> Version 6: >> - bridge/synopsys/dw-mipi-dsi.c: drm_bridge_add update (Archit Taneja) > > queued patches #1 to #4 to drm-misc-next. Please let me know

[PATCH v1 1/7] drm/stm: drv: Rename platform driver name

2017-07-18 Thread Philippe CORNU
Rename the platform driver name from "stm" to "stm32-display" for a better readability in /sys/bus/platform/drivers entries. Note: We keep "stm" as drm_driver.name because it is better when using "modetest -M stm ..." (even if recent modetest patch avoids u

[PATCH v1 7/7] drm/stm: dsi: Constify phy ops structure

2017-07-18 Thread Philippe CORNU
Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c index 16ae00e..568c5d0 100644 --- a/drivers/g

[PATCH v1 3/7] drm/stm: ltdc: Lindent and minor cleanups

2017-07-18 Thread Philippe CORNU
Lindent then checkpatch --strict cleanups Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/ltdc.c | 172 ++--- 1 file changed, 85 insertions(+), 87 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/d

[PATCH v1 4/7] drm/stm: ltdc: Constify funcs structures

2017-07-18 Thread Philippe CORNU
Constify drm funcs structures. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/ltdc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index 628825b..92e58ba 100644 --- a/drive

[PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value

2017-07-18 Thread Philippe CORNU
Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/ltdc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c index f4ed21a..8cd1b9b 100644 --- a/drivers/gpu/drm/stm/ltdc.c +++ b/d

[PATCH v1 2/7] drm/stm: ltdc: Cleanup signal polarity defines

2017-07-18 Thread Philippe CORNU
The GCR_PCPOL/DEPOL/VSPOL/HSPOL defines are sufficient to describe the HS, VS, DE & PC signal polarities. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/ltdc.c | 28 ++-- 1 file changed, 10 insertions(+), 18 deletions(-)

[PATCH v1 0/7] drm/stm: Various cleanups

2017-07-18 Thread Philippe CORNU
Version 1: - Initial commit The purpose of this set of patches is to clean up the drm stm driver. Philippe CORNU (7): drm/stm: drv: Rename platform driver name drm/stm: ltdc: Cleanup signal polarity defines drm/stm: ltdc: Lindent and minor cleanups drm/stm: ltdc: Constify funcs

[PATCH v1 5/7] drm/stm: ltdc: add devm_reset_control & platform_get_ressource

2017-07-18 Thread Philippe CORNU
Use devm_reset_control_get to avoid resource leakage. Also use platform_get_resource, which is more usual and consistent with platform_get_irq called later. Signed-off-by: Fabien Dessenne <fabien.desse...@st.com> Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers

[PATCH v1 1/2] drm/bridge/synopsys: dsi: Constify funcs structures

2017-07-18 Thread Philippe CORNU
Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index 36f5ccb..63c7a01

[PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up

2017-07-18 Thread Philippe CORNU
This patch cleans up the Synopsys mipi dsi register list: - remove unused registers - rename registers according to the Synopsys documentation (1.30 & 1.31) - fix typos - re-order registers for a better coherency Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/

[PATCH v1 0/2] drm/bridge/synopsys: dsi: Various cleanups

2017-07-18 Thread Philippe CORNU
Version 1: - Initial commit The purpose of this set of patches is to clean up the mipi dsi dw Synopsys drm bridge. Philippe CORNU (2): drm/bridge/synopsys: dsi: Constify funcs structures drm/bridge/synopsys: dsi: Register list clean up drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 79

[PATCH v2 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

2017-07-20 Thread Philippe CORNU
Constify dw_mipi_dsi_bridge_funcs as these functions are not supposed to change at runtime. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- 1 fil

[PATCH v2 0/7] drm/stm: Various cleanups

2017-07-20 Thread Philippe CORNU
Version 2: - Add devm_reset_control_get_exclusive to follow explicit reset API - Add missing commit messages & reviewed-by. Version 1: - Initial commit The purpose of this set of patches is to clean up the drm stm driver. Philippe CORNU (7): drm/stm: drv: Rename platform driver name drm

[PATCH v2 0/3] drm/bridge/synopsys: dsi: Various cleanups

2017-07-20 Thread Philippe CORNU
idge. Philippe CORNU (3): drm/bridge/synopsys: dsi: Constify funcs structures drm/bridge/synopsys: dsi: Register list clean up drm/bridge/synopsys: dsi: explicitly request exclusive reset control drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 96 --- 1 file changed, 58 insert

[PATCH v2 2/3] drm/bridge/synopsys: dsi: Register list clean up

2017-07-20 Thread Philippe CORNU
This patch cleans up the Synopsys mipi dsi register list: - rename registers according to the Synopsys documentation (1.30 & 1.31) - fix typos - re-order registers for a better coherency Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Laurent Pinchart <

[PATCH v2 1/7] drm/stm: drv: Rename platform driver name

2017-07-20 Thread Philippe CORNU
Rename the platform driver name from "stm" to "stm32-display" for a better readability in /sys/bus/platform/drivers entries. Note: We keep "stm" as drm_driver.name because it is better when using "modetest -M stm ..." (even if recent modetest patch avoids u

[PATCH v2 2/7] drm/stm: ltdc: Cleanup signal polarity defines

2017-07-20 Thread Philippe CORNU
The GCR_PCPOL/DEPOL/VSPOL/HSPOL defines are sufficient to describe the HS, VS, DE & PC signal polarities. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/gpu/drm/stm/ltdc.c | 28 ++--

[PATCH v2 5/7] drm/stm: ltdc: add devm_reset_control & platform_get_ressource

2017-07-20 Thread Philippe CORNU
;fabien.desse...@st.com> Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> Cc: Philipp Zabel <p.za...@pengutronix.de> --- drivers/gpu/drm/stm/ltdc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --

[PATCH v2 4/7] drm/stm: ltdc: Constify funcs structures

2017-07-20 Thread Philippe CORNU
Constify drm funcs structures. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/gpu/drm/stm/ltdc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/stm/ltdc.c b/dri

[PATCH v2 3/7] drm/stm: ltdc: Lindent and minor cleanups

2017-07-20 Thread Philippe CORNU
Lindent then checkpatch --strict cleanups Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/gpu/drm/stm/ltdc.c | 172 ++--- 1 file changed, 85 insertions(+),

[PATCH v2 6/7] drm/stm: ltdc: Cleanup rename returned value

2017-07-20 Thread Philippe CORNU
Rename the returned value from "res" to "ret" as it is more "readable". Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/gpu/drm/stm/ltdc.c | 10 +- 1 file changed, 5

[PATCH v2 7/7] drm/stm: dsi: Constify phy ops structure

2017-07-20 Thread Philippe CORNU
Constify dw_mipi_dsi_stm_phy_ops as these ops are not supposed to change at runtime. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Benjamin Gaignard <benjamin.gaign...@linaro.org> --- drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH v2 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

2017-07-20 Thread Philippe CORNU
shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- dr

Re: [PATCH v5 2/6] drm/bridge: Add a devm_ allocator for panel bridge.

2017-07-19 Thread Philippe CORNU
> Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Reviewed-by: Philippe Cornu <philippe.co...@st.com> Tested-by: Philippe Cornu <philippe.co...@st.com> > --- > drivers/gpu/drm/bridge/panel.c | 30 ++ > include/drm/drm_bridge.h | 3 +++ >

Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up

2017-07-19 Thread Philippe CORNU
On 07/18/2017 03:39 PM, Laurent Pinchart wrote: > Hi Philippe, > > Thank you for the patch. > > On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote: >> This patch cleans up the Synopsys mipi dsi register list: >> - remove unused registers > > Is the documenta

Re: [PATCH 16/41] drm/stm: Use .dumb_map_offset and .dumb_destroy defaults

2017-07-25 Thread Philippe CORNU
On 07/23/2017 09:16 PM, Noralf Trønnes wrote: > This driver can use the drm_driver.dumb_destroy and > drm_driver.dumb_map_offset defaults, so no need to set them. > > Cc: Yannick Fertre <yannick.fer...@st.com> > Cc: Philippe Cornu <philippe.co...@st.com> > Cc: Ben

Re: [PATCH 00/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy

2017-07-25 Thread Philippe CORNU
aults >drm/shmobile: Use .dumb_map_offset and .dumb_destroy defaults >drm/sti: Use .dumb_map_offset and .dumb_destroy defaults >drm/stm: Use .dumb_map_offset and .dumb_destroy defaults for stm Tested-by: Philippe Cornu <philippe.co...@st.com> Many thanks for the cl

Re: [PATCH 4/8] drm: Nuke drm_atomic_helper_crtc_set_property

2017-07-25 Thread Philippe CORNU
pinchart+rene...@ideasonboard.com> > Cc: Alexey Brodkin <abrod...@synopsys.com> > Cc: Shawn Guo <shawn@linaro.org> > Cc: Eric Engestrom <e...@engestrom.ch> > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: "Ville Syrjälä" <ville.syrj...@

Re: [PATCH 5/8] drm: Nuke drm_atomic_helper_plane_set_property

2017-07-25 Thread Philippe CORNU
g.com> > Cc: Kukjin Kim <kg...@kernel.org> > Cc: Krzysztof Kozlowski <k...@kernel.org> > Cc: Ben Skeggs <bske...@redhat.com> > Cc: Tomi Valkeinen <tomi.valkei...@ti.com> > Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Cc: Benjamin Gaignard

Re: [PATCH 7/8] drm: Nuke drm_atomic_helper_connector_dpms

2017-07-25 Thread Philippe CORNU
Vasut <ma...@denx.de> > Cc: Ben Skeggs <bske...@redhat.com> > Cc: Tomi Valkeinen <tomi.valkei...@ti.com> > Cc: Eric Anholt <e...@anholt.net> > Cc: Mark Yao <mark@rock-chips.com> > Cc: Heiko Stuebner <he...@sntech.de> > Cc: Benjamin Gaignard <

Re: [PATCH 0/4] [v2] Blobifiers (FKA GET_PLANE2)

2017-07-25 Thread Philippe CORNU
| 2 +- > drivers/gpu/drm/sti/sti_hqvdp.c | 2 +- > drivers/gpu/drm/stm/ltdc.c | 2 +- for stm, Acked-by: Philippe Cornu <philippe.co...@st.com> Tested-by: Philippe Cornu <philippe.co...@st.com> Many thanks Philippe :-) >

Re: [PATCH] drm/stm: fix warning about multiplication in condition

2017-07-25 Thread Philippe CORNU
ext, > suggest '&&' instead [-Werror=int-in-bool-context] > > The code here is correct, but can be easily rephrased to make > that more obvious. I also swap out the error handling and the normal > code path for clarity. Hi Arnd, And many thanks for this new & much better co

Re: [PATCH v3 0/3] Add support for the otm8009a dsi panel

2017-07-27 Thread Philippe CORNU
lippe :-) On 07/17/2017 03:19 PM, Philippe CORNU wrote: > Version 3: > - panel-orisetech-otm8009a.c: Remove a FIXME (Andrzej Hajda) > - panel/Makefile & Kconfig: Alphabetical order (Andrzej Hajda) > > Version 2: > - panel-orisetech-otm8009a.c: Add Manufacturer Command Se

Re: [PATCH v4 3/6] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-06-29 Thread Philippe CORNU
On 06/28/2017 08:44 AM, Archit Taneja wrote: > > > On 06/19/2017 09:58 PM, Philippe CORNU wrote: >> Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the >> Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. >> >> Signe

[PATCH v1 3/3] drm/panel: Add support for otm8009a panel driver

2017-07-04 Thread Philippe CORNU
This patch adds Orise Tech otm8009a 3.97" 480x800 TFT LCD panel driver (MIPI-DSI video mode). The panel backlight is managed through the DSI link. This panel driver is used in several STM32 boards. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/pa

[PATCH v1 0/3] Add support for the otm8009a dsi panel

2017-07-04 Thread Philippe CORNU
Hi all, The purpose of this patch is to add support for the Orise Tech otm8009a 3.97" 480x800 TFT LCD panel (MIPI-DSI video mode). This LCD panel is used in several STM32 boards. Version 1: - Initial commit Best regards, Philippe Philippe CORNU (3): dt-bindings: Add vendor prefix for

[PATCH v1 2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

2017-07-04 Thread Philippe CORNU
The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using a MIPI-DSI video interface. Its backlight is managed through the DSI link. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- .../bindings/display/panel/orisetech,otm8009a.txt| 20 +

[PATCH v1 1/3] dt-bindings: Add vendor prefix for Orise Technology

2017-07-04 Thread Philippe CORNU
Orise Technology is headquartered in Taiwan and specializes in manufacture of Flat Panel Display Driver IC and Flat Panel Display Controller IC. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 ins

Re: [PATCH v4 3/6] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-07-03 Thread Philippe CORNU
On 07/03/2017 08:31 AM, Archit Taneja wrote: > > > On 06/29/2017 08:13 PM, Philippe CORNU wrote: >> >> >> On 06/28/2017 08:44 AM, Archit Taneja wrote: >>> >>> >>> On 06/19/2017 09:58 PM, Philippe CORNU wrote: >>>>

[PATCH v5 5/7] dt-bindings: display: stm32: remove st-display-subsystem parent node requirement

2017-07-03 Thread Philippe CORNU
There is no need anymore to have a "st-display-subsystem" parent node in the device tree for the ltdc. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 1 - 1 fi

[PATCH v5 1/7] drm/stm: ltdc: Fix leak of px clk enable in some error paths

2017-07-03 Thread Philippe CORNU
The pixel clock gets enabled early during init, since it's required in order to read registers. This pixel clock must be disabled if errors during this init phase. Signed-off-by: Eric Anholt <e...@anholt.net> Acked-by: Philippe Cornu <philippe.co...@st.com> --- drivers/gpu/drm/stm

[PATCH v5 4/7] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-07-03 Thread Philippe CORNU
Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/Kconfig | 6 + drivers/gpu/drm/bridge/synopsy

[PATCH v5 6/7] dt-bindings: display: stm32: Add DSI controller

2017-07-03 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the STM32 DSI controller based on the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> Acked-by: Rob Herring <

[PATCH v5 7/7] drm/stm: Add STM32 DSI controller driver

2017-07-03 Thread Philippe CORNU
Add the STM32 DSI controller driver that uses the Synopsys DesignWare MIPI DSI host controller bridge. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> Reviewed-by: Archit Taneja <arch...@codeaurora.org> --- drivers/g

[PATCH v5 2/7] drm/stm: ltdc: Add panel-bridge support

2017-07-03 Thread Philippe CORNU
Add the panel-bridge support for both panels & bridges (used by DSI host & HDMI/LVDS bridges). Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Archit Taneja <arch...@codeaurora.org> --- drivers/gpu/drm/stm/Kconfig | 2 +- drivers/gpu/d

[PATCH v5 3/7] dt-bindings: display: Add Synopsys DW MIPI DSI host controller

2017-07-03 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the Synopsys DesignWare MIPI DSI host controller. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- .../bindings/display/bridge/dw_mipi_dsi.txt| 32 ++ 1 file changed, 32 insertions(+) creat

[PATCH v5 0/7] STM32 DSI HOST

2017-07-03 Thread Philippe CORNU
ce Rockchip digital & phy specific extensions with stm32's ones. - add a bridge Philippe CORNU (7): drm/stm: ltdc: Fix leak of px clk enable in some error paths drm/stm: ltdc: Add panel-bridge support dt-bindings: display: Add Synopsys DW MIPI DSI host controller drm/bridge/synopsy

Re: [PATCH v1 2/3] dt-bindings: display: panel: Add support for Orise Tech otm8009a dsi panel

2017-07-06 Thread Philippe CORNU
On 07/04/2017 06:30 PM, Philippe CORNU wrote: > The Orise Tech OTM8009A is a 3.97" 480x800 TFT LCD panel connected using > a MIPI-DSI video interface. Its backlight is managed through the DSI link. > > Signed-off-by: Philippe CORNU <philippe.co...@st.com> > --- >

Re: [PATCH v1 3/3] drm/panel: Add support for otm8009a panel driver

2017-07-06 Thread Philippe CORNU
On 07/05/2017 11:28 AM, Andrzej Hajda wrote: > On 04.07.2017 18:30, Philippe CORNU wrote: >> This patch adds Orise Tech otm8009a 3.97" 480x800 TFT LCD >> panel driver (MIPI-DSI video mode). The panel backlight is >> managed through the DSI link. This panel driver i

Re: [PATCH 8/8] drm: Convert atomic drivers from CRTC .disable() to .atomic_disable()

2017-06-29 Thread Philippe CORNU
| 5 +++-- > drivers/gpu/drm/stm/ltdc.c | 5 +++-- For stm, Tested-by: Philippe Cornu <philippe.co...@st.com> Acked-by: Philippe Cornu <philippe.co...@st.com> Many thanks Philippe > drivers/gpu/drm/sun4i/sun4i_crtc.c | 5 +++-- >

Re: [PATCH 7/8] drm: Add old state pointer to CRTC .enable() helper function

2017-06-29 Thread Philippe CORNU
/drm/omapdrm/omap_crtc.c | 5 ++-- > drivers/gpu/drm/qxl/qxl_display.c | 5 ++-- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 ++-- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ++-- > drivers/gpu/drm/sti/sti_crtc.c | 5 ++-- &g

[PATCH v3 1/3] drm/bridge/synopsys: dsi: Constify funcs structures

2017-08-01 Thread Philippe CORNU
Constify dw_mipi_dsi_bridge_funcs as these functions are not supposed to change at runtime. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 2 +- 1 fil

[PATCH v3 2/3] drm/bridge/synopsys: dsi: Register list clean up

2017-08-01 Thread Philippe CORNU
This patch cleans up the Synopsys mipi dsi register list: - rename registers according to the Synopsys documentation (1.30 & 1.31) - fix typos - re-order registers for a better coherency Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Laurent Pinchart <

[PATCH v3 3/3] drm/bridge/synopsys: dsi: explicitly request exclusive reset control

2017-08-01 Thread Philippe CORNU
shared reset control behavior. Convert all drivers requesting exclusive resets to the explicit API call so the temporary transition helpers can be removed. No functional changes. Cc: Philipp Zabel <p.za...@pengutronix.de> Signed-off-by: Philippe CORNU <philippe.co...@st.com&g

[PATCH v3 0/3] drm/bridge/synopsys: dsi: Various cleanups

2017-08-01 Thread Philippe CORNU
pose of this set of patches is to clean up the mipi dsi dw Synopsys drm bridge. Philippe CORNU (3): drm/bridge/synopsys: dsi: Constify funcs structures drm/bridge/synopsys: dsi: Register list clean up drm/bridge/synopsys: dsi: explicitly request exclusive reset control drivers/gpu/drm/bridge/syno

Re: [PATCH v3 0/3] drm/bridge/synopsys: dsi: Various cleanups

2017-08-01 Thread Philippe CORNU
7 03:23 PM, Philippe CORNU wrote: > Version 3: > - Add devm_reset_control_get_optional_exclusive (Philipp Zabel). > > Version 2: > - Put back Synopsys mipi dsi unused registers. > - Add devm_reset_control_get_exclusive to follow explicit reset API. > - Add a missing commit messag

Re: [PATCH v1 3/3] drm/stm: Add STM32 DSI host driver

2017-05-15 Thread Philippe CORNU
ockchip-specific PHY by the STM32. Comments are welcome :-) Many thanks, Philippe On 05/15/2017 10:22 AM, Neil Armstrong wrote: > On 05/12/2017 04:56 PM, Philippe CORNU wrote: >> This mipi dsi host driver is based on the Rockchip version of the >> Synopsys Designware mipi dsi driver (

[PATCH v1 3/3] drm/stm: Add STM32 DSI host driver

2017-05-12 Thread Philippe CORNU
This mipi dsi host driver is based on the Rockchip version of the Synopsys Designware mipi dsi driver (rockchip/dw-mipi-dsi.c) modified for the stm32 family: - replace Rockchip digital & phy specific extensions with stm32's ones. - add a bridge Signed-off-by: Philippe CORNU <philippe.co...

[PATCH v1 1/3] drm/stm: ltdc: Add bridge support

2017-05-12 Thread Philippe CORNU
Add the bridge support, used by DSI host and HDMI/LVDS bridges. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/ltdc.c | 82 +++--- drivers/gpu/drm/stm/ltdc.h | 1 + 2 files changed, 72 insertions(+), 11 deletions(-)

[PATCH v1 2/3] dt-bindings: display: Add STM32 DSI host driver

2017-05-12 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the STM32 DSI host driver based on the Synopsys DW MIPI DSI driver from Rockchip. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- .../devicetree/bindings/display/st,stm32-ltdc.txt | 92 +- 1 file chang

[PATCH v1 0/3] STM32 DSI HOST

2017-05-12 Thread Philippe CORNU
ific extensions with stm32's ones. - add a bridge Philippe CORNU (3): drm/stm: ltdc: Add bridge support dt-bindings: display: Add STM32 DSI host driver drm/stm: Add STM32 DSI host driver .../devicetree/bindings/display/st,stm32-ltdc.txt | 92 +- drivers/gpu/drm/stm/Kco

Re: [PATCH v3 2/6] dt-bindings: display: Add Synopsys DW MIPI DSI DRM bridge driver

2017-06-19 Thread Philippe CORNU
On 06/08/2017 05:40 PM, Rob Herring wrote: > On Fri, Jun 02, 2017 at 04:37:11PM +0200, Philippe CORNU wrote: >> This patch adds documentation of device tree bindings for the >> Synopsys DesignWare MIPI DSI host DRM bridge driver. >> >> Signed-off-by: Philippe C

[PATCH v4 5/6] dt-bindings: display: stm32: Add DSI host driver

2017-06-19 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the STM32 DSI host driver based on the Synopsys DW MIPI DSI bridge driver. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> --- .../devicetree/bindings/display/st,st

[PATCH v4 3/6] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-06-19 Thread Philippe CORNU
Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/Kconfig | 6 + drivers/gpu/drm/bridge/synopsy

[PATCH v4 0/6] STM32 DSI HOST

2017-06-19 Thread Philippe CORNU
s mipi dsi host driver is based on the Rockchip version of the Synopsys Designware mipi dsi driver (rockchip/dw-mipi-dsi.c) modified for the stm32 family: - replace Rockchip digital & phy specific extensions with stm32's ones. - add a bridge Philippe CORNU (6): drm/stm: ltdc: Add panel-brid

[PATCH v4 6/6] drm/stm: Add STM32 DSI host driver

2017-06-19 Thread Philippe CORNU
Add the STM32 DSI host driver that uses the Synopsys DesignWare MIPI DSI DRM bridge. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Reviewed-by: Neil Armstrong <narmstr...@baylibre.com> --- drivers/gpu/drm/stm/Kconfig | 7 + drivers/gpu/drm/stm/Makefile

Re: [PATCH v3 5/6] dt-bindings: display: stm32: Add DSI host driver

2017-06-19 Thread Philippe CORNU
On 06/08/2017 07:12 PM, Rob Herring wrote: > On Fri, Jun 02, 2017 at 04:37:14PM +0200, Philippe CORNU wrote: >> This patch adds documentation of device tree bindings for the STM32 >> DSI host driver based on the Synopsys DW MIPI DSI bridge driver. >> --- >> .../dev

[PATCH v4 2/6] dt-bindings: display: Add Synopsys DW MIPI DSI DRM bridge driver

2017-06-19 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the Synopsys DesignWare MIPI DSI host DRM bridge driver. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- .../bindings/display/bridge/dw_mipi_dsi.txt| 30 ++ 1 file changed, 30 insertions(+)

[PATCH v4 1/6] drm/stm: ltdc: Add panel-bridge support

2017-06-19 Thread Philippe CORNU
Add the panel-bridge support for both panels & bridges (used by DSI host & HDMI/LVDS bridges). Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/stm/Kconfig | 2 +- drivers/gpu/drm/stm/ltdc.c | 211 drive

[PATCH v4 4/6] dt-bindings: display: stm32: remove st-display-subsystem parent node requirement

2017-06-19 Thread Philippe CORNU
There is no need anymore to have a "st-display-subsystem" parent node in the device tree for the ltdc. Signed-off-by: Philippe CORNU <philippe.co...@st.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 1 - 1 fi

Re: [PATCH 1/7] drm/bridge: Support hotplugging panel-bridge.

2017-06-22 Thread Philippe CORNU
On 06/22/2017 10:17 AM, Archit Taneja wrote: > > > On 06/22/2017 01:20 PM, Benjamin Gaignard wrote: >> 2017-06-20 19:31 GMT+02:00 Eric Anholt : >>> Archit Taneja writes: >>> On 06/16/2017 08:13 PM, Eric Anholt wrote: > Archit Taneja

Re: [PATCH v2 13/14] drm: stm: remove dead code and pointless local lut storage

2017-06-22 Thread Philippe CORNU
On 06/22/2017 08:06 AM, Peter Rosin wrote: > The redundant fb helper .load_lut is no longer used, and can not > work right without also providing the fb helpers .gamma_set and > .gamma_get thus rendering the code in this driver suspect. > Hi Peter, STM32 chipsets supports 8-bit CLUT mode but

Re: [PATCH 2/2] drm/stm: Fixup for "drm/stm: ltdc: Add panel-bridge support"

2017-06-23 Thread Philippe CORNU
On 06/22/2017 07:56 PM, Eric Anholt wrote: > Signed-off-by: Eric Anholt > --- > > This fixup would be squashed into patch 1 of your series. Hi Eric, and many thanks for the two patches, I will follow your suggestion for the v5 serie. By the way, do you have more comments on

Re: [PATCH v4 2/6] dt-bindings: display: Add Synopsys DW MIPI DSI DRM bridge driver

2017-06-26 Thread Philippe CORNU
On 06/23/2017 11:25 PM, Rob Herring wrote: > On Mon, Jun 19, 2017 at 06:28:01PM +0200, Philippe CORNU wrote: >> This patch adds documentation of device tree bindings for the >> Synopsys DesignWare MIPI DSI host DRM bridge driver. > > You missed Archit's comment on v3.

[PATCH v2 3/5] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-05-19 Thread Philippe CORNU
Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- drivers/gpu/drm/bridge/synopsys/Kconfig |9 + drivers/gpu/drm/bridge/synopsy

Re: [PATCH v2 3/5] drm/bridge/synopsys: Add MIPI DSI host controller bridge

2017-05-19 Thread Philippe CORNU
On 05/19/2017 05:33 PM, Neil Armstrong wrote: > On 05/19/2017 05:20 PM, Philippe CORNU wrote: >> Add a Synopsys Designware MIPI DSI host DRM bridge driver, based on the >> Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs. >> >> Signed-off-

[PATCH v2 4/5] dt-bindings: display: Add STM32 DSI host driver

2017-05-19 Thread Philippe CORNU
This patch adds documentation of device tree bindings for the STM32 DSI host driver based on the Synopsys DW MIPI DSI driver from Rockchip. Signed-off-by: Philippe CORNU <philippe.co...@st.com> --- .../devicetree/bindings/display/st,stm32-ltdc.txt | 102 - 1 file c

Re: [PATCH v1 2/3] dt-bindings: display: Add STM32 DSI host driver

2017-05-19 Thread Philippe CORNU
On 05/18/2017 11:42 PM, Rob Herring wrote: > On Fri, May 12, 2017 at 04:56:28PM +0200, Philippe CORNU wrote: >> This patch adds documentation of device tree bindings for the STM32 >> DSI host driver based on the Synopsys DW MIPI DSI driver from Rockchip. >> >> Si

  1   2   3   >