Re: [PATCH v2 2/2] dt-bindings: Add Raydium RM67191 panel bindings

2018-05-09 Thread Robert Chiras
On Lu, 2018-05-07 at 11:50 -0500, Rob Herring wrote: > On Thu, May 03, 2018 at 05:26:02PM +0300, Robert Chiras wrote: > > > > Signed-off-by: Robert Chiras <robert.chi...@nxp.com> > > --- > >  .../bindings/display/panel/raydium,rm67191.txt | 38 > > +++

[PATCH v2 0/2] drm/panel: Add Raydium RM67191 driver

2018-05-05 Thread Robert Chiras
doing the DSI init/uninit in enable/disable functions. Robert Chiras (2): drm/panel: Add Raydium RM67191 DSI Panel dt-bindings: Add Raydium RM67191 panel bindings .../bindings/display/panel/raydium,rm67191.txt | 38 ++ drivers/gpu/drm/panel/Kconfig | 9 + drivers

[PATCH v2 1/2] drm/panel: Add Raydium RM67191 DSI Panel

2018-05-05 Thread Robert Chiras
Add support for the OLED display based on MIPI-DSI protocol from Raydium: RM67191. Signed-off-by: Robert Chiras <robert.chi...@nxp.com> Signed-off-by: Mirela Rabulea <mirela.rabu...@nxp.com> --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/pa

[PATCH v2 2/2] dt-bindings: Add Raydium RM67191 panel bindings

2018-05-05 Thread Robert Chiras
Signed-off-by: Robert Chiras <robert.chi...@nxp.com> --- .../bindings/display/panel/raydium,rm67191.txt | 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt diff --git a/Documen

Re: [PATCH 1/2] drm/panel: Add Raydium RM67191 DSI Panel

2018-05-05 Thread Robert Chiras
On Vi, 2018-04-27 at 11:08 +, Thierry Reding wrote: > On Fri, Apr 27, 2018 at 10:37:16AM +0000, Robert Chiras wrote: > > > > > > Hi Thierry, > > > > Thanks a lot for reviewing this. Your suggestions are very > > valuable. > > Please see my d

Re: [PATCH 1/2] drm/panel: Add Raydium RM67191 DSI Panel

2018-04-29 Thread Robert Chiras
Hi Thierry, Thanks a lot for reviewing this. Your suggestions are very valuable. Please see my detailed answers inline. Best regards, Robert From: Thierry Reding <thierry.red...@gmail.com> Sent: Thursday, April 26, 2018 5:54 PM To: Robert Chiras Cc: dl

Re: [PATCH 2/2] drm/panel: rm67191: Add support for new bus formats

2018-04-29 Thread Robert Chiras
From: Thierry Reding <thierry.red...@gmail.com> Sent: Thursday, April 26, 2018 5:56 PM To: Robert Chiras Cc: dl-linux-imx; dri-devel@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/panel: rm67191: Add support for new bus formats On Tue, Apr 03, 2018 at

[PATCH 1/2] drm/panel: Add Raydium RM67191 DSI Panel

2018-04-03 Thread Robert Chiras
Add support for the OLED display based on MIPI-DSI protocol from Raydium: RM67191. Signed-off-by: Robert Chiras <robert.chi...@nxp.com> --- .../bindings/display/panel/raydium,rm67191.txt | 55 ++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Ma

[PATCH 2/2] drm/panel: rm67191: Add support for new bus formats

2018-04-03 Thread Robert Chiras
From: Mirela Rabulea Do not hardcode pixel_format to 0x77 but calculate it from dsi->format. Report all the supported bus formats in get_modes: MEDIA_BUS_FMT_RGB888_1X24 MEDIA_BUS_FMT_RGB666_1X18 MEDIA_BUS_FMT_RGB565_1X16 Change pixelclock from 120

[PATCH 0/2] drm/panel: Add Raydium RM67191 driver

2018-04-03 Thread Robert Chiras
formats Robert Chiras (1): drm/panel: Add Raydium RM67191 DSI Panel .../bindings/display/panel/raydium,rm67191.txt | 55 ++ drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile | 1 + drivers/gpu/drm/panel/panel-raydium-rm67191.c

[PATCH 08/11] drm/mxsfb: Update mxsfb to support LCD reset

2019-01-17 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 10 -- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 1 + 2 files changed, 9

[PATCH 01/11] drm/mxsfb: Update mxsfb to support a bridge

2019-01-17 Thread Robert Chiras
. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 46 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

[PATCH 07/11] drm/mxsfb: Signal mode changed when bpp changed

2019-01-17 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c

[PATCH 11/11] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-01-17 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH 06/11] drm/mxsfb: Add support for new pixel formats in eLCDIF

2019-01-17 Thread Robert Chiras
From: Mirela Rabulea Add support for the following pixel formats: 16 bpp: RG16 ,BG16, XR15, XB15, AR15, AB15 Set the bus format based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, the DSI will use it. Use drm_get_format_name instead of

[PATCH 03/11] drm/mxsfb: Add max-res property for MXSFB

2019-01-17 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum resolution supported by the MXSFB (eLCDIF) driver. This patch add support for a new property which we can use to impose such limitation. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 12 ++-- 1 file

[PATCH 02/11] dt-bindings: display: Add max-res property for mxsfb

2019-01-17 Thread Robert Chiras
Add new optional property 'max-res', to limit the maximum supported resolution by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH 10/11] drm/mxsfb: Improve the axi clock usage

2019-01-17 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

[PATCH 09/11] drm/mxsfb: Move pm_runtime_enable at the end of probe

2019-01-17 Thread Robert Chiras
Move the pm_runtime_enable call at the end of probbe, since it was made too early, causing issues to DRM enable routines. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 04/11] drm/mxsfb: Update mxsfb with additional pixel formats

2019-01-17 Thread Robert Chiras
, the alpha pixel formats were added to the supported pixel formats but it will be ignored. This was necessary since there are systems (like Android) that requires such pixel formats. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 108 - drivers

[PATCH 05/11] drm/mxsfb: Fix the vblank events

2019-01-17 Thread Robert Chiras
Currently, the vblank support is not correctly implemented in MXSFB_DRM driver. The call to drm_vblank_init is made with mode_config.num_crtc which at that time is 0. Because of this, vblank is not activated, so there won't be any vblank event submitted. Signed-off-by: Robert Chiras --- drivers

[PATCH 00/11] Add support for DRM bridge and additional pixel formats

2019-01-17 Thread Robert Chiras
: Add support for new pixel formats in eLCDIF drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (9): drm/mxsfb: Update mxsfb to support a bridge dt-bindings: display: Add max-res property for mxsfb drm/mxsfb: Add max-res property for MXSFB drm/mxsfb: Update mxsfb with additional

Re: [PATCH 09/10] drm/mxsfb: Improve the axi clock usage

2019-01-16 Thread Robert Chiras
On Mi, 2019-01-09 at 18:09 +0100, Stefan Agner wrote: > On 09.01.2019 15:13, Robert Chiras wrote: > > > > Currently, the enable of the axi clock return status is ignored, > > causing > > issues when the enable fails then we try to disable it. Therefore, > > it

[PATCH 09/10] drm/mxsfb: Improve the axi clock usage

2019-01-10 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

[PATCH 10/10] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-01-10 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH 00/10] Add support for DRM bridge and additional pixel formats

2019-01-10 Thread Robert Chiras
of the patches are bug-fixes. Mirela Rabulea (2): drm/mxsfb: Add support for new pixel formats in eLCDIF drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (8): drm/mxsfb: Update mxsfb to support a bridge dt-bindings: display: Add max-res property for mxsfb drm/mxsfb: Add max-res

[PATCH 01/10] drm/mxsfb: Update mxsfb to support a bridge

2019-01-10 Thread Robert Chiras
. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 44 +--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

[PATCH 05/10] drm/mxsfb: Fix the vblank events

2019-01-10 Thread Robert Chiras
Currently, the vblank support is not correctly implemented in MXSFB_DRM driver. The call to drm_vblank_init is made with mode_config.num_crtc which at that time is 0. Because of this, vblank is not activated, so there won't be any vblank event submitted. Signed-off-by: Robert Chiras --- drivers

[PATCH 02/10] dt-bindings: display: Add max-res property for mxsfb

2019-01-10 Thread Robert Chiras
Add new optional property 'max-res', to limit the maximum supported resolution by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH 03/10] drm/mxsfb: Add max-res property for MXSFB

2019-01-10 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum resolution supported by the MXSFB (eLCDIF) driver. This patch add support for a new property which we can use to impose such limitation. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 12 ++-- 1 file

[PATCH 08/10] drm/mxsfb: Update mxsfb to support LCD reset

2019-01-10 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Also, correct the pm_runtime_enable call, since it was made too early in the probe, causing issues to DRM enable routines. Signed-off-by: Robert

[PATCH 04/10] drm/mxsfb: Update mxsfb with additional pixel formats

2019-01-10 Thread Robert Chiras
, the alpha pixel formats were added to the supported pixel formats but it will be ignored. This was necessary since there are systems (like Android) that requires such pixel formats. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 108 - drivers

[PATCH 06/10] drm/mxsfb: Add support for new pixel formats in eLCDIF

2019-01-10 Thread Robert Chiras
From: Mirela Rabulea Add support for the following pixel formats: 16 bpp: RG16 ,BG16, XR15, XB15, AR15, AB15 Set the bus format based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, the DSI will use it. Use drm_get_format_name instead of

[PATCH 07/10] drm/mxsfb: Signal mode changed when bpp changed

2019-01-10 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 48

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-09 Thread Robert Chiras
Hi Guido On Vi, 2019-02-08 at 12:40 +0100, Guido Günther wrote: > Hi Robert, > On Wed, Feb 06, 2019 at 03:28:07PM +, Robert Chiras wrote: > > > > Hi Guido, > > > > Thanks for picking this up. It's interesting to see that a lot has > > changed in the PHY A

Re: [PATCH v2 3/3] phy: Add driver for mixel dphy found on imx8

2019-02-07 Thread Robert Chiras
Hi Guido, Thanks for picking this up. It's interesting to see that a lot has changed in the PHY API and the phy can be now configured through the API instead of exported function as I did in the NXP tree. I was going through your implementation and I noticed you also added the phy_ref clock to

Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-14 Thread Robert Chiras
Hi Fabio, On Vi, 2019-06-14 at 09:27 -0300, Fabio Estevam wrote: > Hi Robert, > > On Fri, Jun 14, 2019 at 8:52 AM Robert Chiras > wrote: > > > > > --- /dev/null > > +++ b/drivers/gpu/drm/panel/panel-raydium-rm67191.c > > @@ -0,0 +1,730 @@ &

[PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-14 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67191.c | 730

[PATCH 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-14 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras --- .../bindings/display/panel/raydium,rm67191.txt | 42 ++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt

[PATCH 0/2] Add DSI panel driver for Raydium RM67191

2019-06-14 Thread Robert Chiras
This patch-set contains the DRM panel driver and dt-bindings documentation for the DSI driven panel: Raydium RM67191. Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel drm/panel: Add support for Raydium RM67191 panel driver .../bindings/display/panel

Re: [EXT] Re: [PATCH 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-14 Thread Robert Chiras
Hi Fabio, On Vi, 2019-06-14 at 09:59 -0300, Fabio Estevam wrote: > On Fri, Jun 14, 2019 at 8:53 AM Robert Chiras > wrote: > > > > > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > > > Signed-off-by: Robert Chiras > > --- > >

Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-18 Thread Robert Chiras
> + if (IS_ERR(panel->reset)) > > + panel->reset = NULL; > > + else > > + gpiod_set_value(panel->reset, 0); > > + > > + memset(_props, 0, sizeof(bl_props)); > > + bl_props.type = BACKLIGHT_RAW; > > + bl_props.bri

[PATCH v4 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-25 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1

[PATCH v4 0/2] Add DSI panel driver for Raydium RM67191

2019-06-25 Thread Robert Chiras
specific color formats (fabio) - Removed unnecessary tests in enable and unprepare (sam) - Removed the unnecessary backlight write in enable (sam) Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel drm/panel: Add support for Raydium RM67191 panel driver

Re: [EXT] Re: [PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-25 Thread Robert Chiras
On Lu, 2019-06-24 at 13:12 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Mon, Jun 24, 2019 at 4:44 AM Robert Chiras > wrote: > > > > > > > > > You did not handle the "power" regulator. > > There is no nee

[PATCH v4 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-25 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- .../bindings/display/panel/raydium,rm67191.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [EXT] Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
On Mi, 2019-06-19 at 10:28 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Tue, Jun 18, 2019 at 10:31 AM Robert Chiras > wrote: > > > > > +static const struct display_timing rad_default_timing = { > > +   .pixelc

Re: [EXT] Re: [PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-20 Thread Robert Chiras
On Mi, 2019-06-19 at 10:21 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Tue, Jun 18, 2019 at 10:33 AM Robert Chiras > wrote: > > > > > +Optional properties: > > +- reset-gpios: a GPIO spec for the RST_B GPIO pin > &g

Re: [EXT] Re: [PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
Hi Sam, On Mi, 2019-06-19 at 15:25 +0200, Sam Ravnborg wrote: > On Tue, Jun 18, 2019 at 04:30:46PM +0300, Robert Chiras wrote: > > > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > > protocol). > > > > Signed-off-by: Robert Chiras > Pl

[PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-20 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- .../bindings/display/panel/raydium,rm67191.txt | 39 ++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-20 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1

[PATCH v3 0/2] Add DSI panel driver for Raydium RM67191

2019-06-20 Thread Robert Chiras
(daniel) - Reordered includes (sam) - Added defines for panel specific color formats (fabio) - Removed unnecessary tests in enable and unprepare (sam) - Removed the unnecessary backlight write in enable (sam) Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel

Re: [EXT] Re: [PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-21 Thread Robert Chiras
Hi Fabio, On Vi, 2019-06-21 at 11:00 -0300, Fabio Estevam wrote: > Hi Robert, > > On Thu, Jun 20, 2019 at 10:32 AM Robert Chiras > wrote: > > > > > > Add dt-bindings documentation for Raydium RM67191 DSI panel. > > > > Signed-off-by: Ro

Re: [EXT] Re: [PATCH v3 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-24 Thread Robert Chiras
On Vi, 2019-06-21 at 12:46 -0300, Fabio Estevam wrote: > Caution: EXT Email > > Hi Robert, > > On Fri, Jun 21, 2019 at 11:16 AM Robert Chiras > wrote: > > > > > From what I've seen in the schematics, the power lines on the DSI > > port > >

Re: [EXT] Re: [PATCH v3 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-24 Thread Robert Chiras
Hi Fabio, Thanks for your feedback. I will handle them all, but for the pm_ops I have some comments. See inline. On Vi, 2019-06-21 at 10:59 -0300, Fabio Estevam wrote: > Hi Robert, > > On Thu, Jun 20, 2019 at 10:31 AM Robert Chiras > wrote: > > > > > +fail:

[PATCH v2 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-18 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras --- .../bindings/display/panel/raydium,rm67191.txt | 43 ++ 1 file changed, 43 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/raydium,rm67191.txt

[PATCH v2 0/2] Add DSI panel driver for Raydium RM67191

2019-06-18 Thread Robert Chiras
copyright statement - Reordered includes - Added defines for panel specific color formats - Removed unnecessary tests in enable and unprepare - Removed the unnecessary backlight write in enable Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel drm/panel: Add support

[PATCH v2 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-18 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras --- drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-raydium-rm67191.c | 709

Re: [EXT] Re: [PATCH v9 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs

2019-05-06 Thread Robert Chiras
. > > So > > instead of adding this to the nwl host driver make it a generic PHY > > driver. > > > > The driver supports the i.MX8MQ. Support for i.MX8QM and i.MX8QXP > > can be > > added once the necessary system controller bits are in via > > mixel_dphy_

[PATCH v5 0/2] Add DSI panel driver for Raydium RM67191

2019-06-26 Thread Robert Chiras
) - Fixed copyright statement (daniel) - Reordered includes (sam) - Added defines for panel specific color formats (fabio) - Removed unnecessary tests in enable and unprepare (sam) - Removed the unnecessary backlight write in enable (sam) Robert Chiras (2): dt-bindings: display: panel: Add support

[PATCH v5 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-26 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- .../bindings/display/panel/raydium,rm67191.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v6 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel

2019-06-26 Thread Robert Chiras
Add dt-bindings documentation for Raydium RM67191 DSI panel. Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg Reviewed-by: Fabio Estevam --- .../bindings/display/panel/raydium,rm67191.txt | 41 ++ 1 file changed, 41 insertions(+) create mode 100644

[PATCH v6 0/2] Add DSI panel driver for Raydium RM67191

2019-06-26 Thread Robert Chiras
in enable (sam) *** SUBJECT HERE *** *** BLURB HERE *** Robert Chiras (2): dt-bindings: display: panel: Add support for Raydium RM67191 panel drm/panel: Add support for Raydium RM67191 panel driver .../bindings/display/panel/raydium,rm67191.txt | 41 ++ MAINTAINERS

[PATCH v6 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-26 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg Reviewed-by: Fabio Estevam --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel

[PATCH v5 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-26 Thread Robert Chiras
This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI protocol). Signed-off-by: Robert Chiras Reviewed-by: Sam Ravnborg --- MAINTAINERS | 6 + drivers/gpu/drm/panel/Kconfig | 9 + drivers/gpu/drm/panel/Makefile| 1

[PATCH 10/10] drm/mxsfb: Add support for horizontal stride

2019-06-26 Thread Robert Chiras
in order to do horizontal crop on the frame buffer processed by the eLCDIF block. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 - drivers/gpu/drm/mxsfb/mxsfb_regs.h | 16

[PATCH 00/10] Improvements and fixes for mxsfb DRM driver

2019-06-26 Thread Robert Chiras
of them at maximum capacity (like it is the case on 8MQ, where there are two display controllers: DCSS and eLCDIF). The rest of the patches are bug-fixes. Mirela Rabulea (1): drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (9): drm/mxsfb: Update mxsfb to support a bridge drm

[PATCH 02/10] drm/mxsfb: Update mxsfb with additional pixel formats

2019-06-26 Thread Robert Chiras
based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, so the bridge can use it. Signed-off-by: Robert Chiras Signed-off-by: Mirela Rabulea --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 158 ++--- drivers/gpu/drm/mx

[PATCH 09/10] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-06-26 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH 03/10] drm/mxsfb: Fix the vblank events

2019-06-26 Thread Robert Chiras
with the '-v' parameter will result in an astronomical refresh rate (1+ Hz), because of that. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb

[PATCH 01/10] drm/mxsfb: Update mxsfb to support a bridge

2019-06-26 Thread Robert Chiras
. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 46 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

[PATCH 07/10] drm/mxsfb: Update mxsfb to support LCD reset

2019-06-26 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 10 -- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 1 + 2 files changed, 9

[PATCH 08/10] drm/mxsfb: Improve the axi clock usage

2019-06-26 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

Re: [EXT] Re: [PATCH v5 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-26 Thread Robert Chiras
Hi Sam, On Mi, 2019-06-26 at 13:33 +0200, Sam Ravnborg wrote: > Hi Robert. > > On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote: > > > > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI > > protocol). > I was about to apply these - but I

Re: [EXT] Re: [PATCH 00/10] Improvements and fixes for mxsfb DRM driver

2019-07-12 Thread Robert Chiras
Hi Guido, On Jo, 2019-07-11 at 17:04 +0200, Guido Günther wrote: > Hi Robert, > On Wed, Jun 26, 2019 at 04:32:08PM +0300, Robert Chiras wrote: > > > > This patch-set improves the use of eLCDIF block on iMX 8 SoCs (like > > 8MQ, 8MM > > and 8QXP). Following, are th

[PATCH 05/10] dt-bindings: display: Add max-res property for mxsfb

2019-06-27 Thread Robert Chiras
Add new optional property 'max-res', to limit the maximum supported resolution by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH 04/10] drm/mxsfb: Signal mode changed when bpp changed

2019-06-27 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c

[PATCH 06/10] drm/mxsfb: Add max-res property for MXSFB

2019-06-27 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum resolution supported by the MXSFB (eLCDIF) driver. This patch add support for a new property which we can use to impose such limitation. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 12 ++-- 1 file

Re: [EXT] Re: [PATCH 2/2] drm/panel: Add support for Raydium RM67191 panel driver

2019-06-16 Thread Robert Chiras
On Vi, 2019-06-14 at 10:39 -0300, Fabio Estevam wrote: > Caution: EXT Email > > On Fri, Jun 14, 2019 at 10:29 AM Robert Chiras > wrote: > > > > > The GPIO is active high, and the above sequence was received from > > the > > panel vendor in the foll

Re: [EXT] Re: [PATCH 05/10] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
On Lu, 2019-07-22 at 11:48 -0600, Rob Herring wrote: > On Wed, Jun 26, 2019 at 04:32:13PM +0300, Robert Chiras wrote: > > > > Add new optional property 'max-res', to limit the maximum supported > > resolution by the MXSFB_DRM driver. > Bindings are for h/w descri

Re: [EXT] Re: [PATCH v2 12/15] drm/mxsfb: Improve the axi clock usage

2019-08-14 Thread Robert Chiras
Hi Stefan, On Mi, 2019-08-14 at 13:06 +0200, Stefan Agner wrote: > On 2019-08-14 12:48, Robert Chiras wrote: > > > > Currently, the enable of the axi clock return status is ignored, > > causing > > issues when the enable fails then we try to disable it. Therefore, &g

Re: [EXT] Re: [PATCH v2 09/15] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
Hi Stefann, On Mi, 2019-08-14 at 13:25 +0200, Stefan Agner wrote: > On 2019-08-14 13:14, Robert Chiras wrote: > > > > Hi Stefan, > > On Mi, 2019-08-14 at 13:03 +0200, Stefan Agner wrote: > > > > > > On 2019-08-14 12:48, Robert Chiras wrote: > > &g

Re: [EXT] Re: [PATCH v2 09/15] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
Hi Stefan, On Mi, 2019-08-14 at 13:03 +0200, Stefan Agner wrote: > On 2019-08-14 12:48, Robert Chiras wrote: > > > > Add new optional property 'max-res', to limit the maximum supported > > resolution by the MXSFB_DRM driver. > I would also mention the reason why we

Re: [EXT] Re: [PATCH v2 04/15] drm/mxsfb: Reset vital register for a proper initialization

2019-08-14 Thread Robert Chiras
Hi Stefan, On Mi, 2019-08-14 at 13:11 +0200, Stefan Agner wrote: > On 2019-08-14 12:48, Robert Chiras wrote: > > > > Some of the regiters need, like LCDC_CTRL and > > CTRL2_OUTSTANDING_REQS > Typo in registers, and there is a need to many. Thanks, will fix this. > &g

[PATCH v2 08/15] drm/mxsfb: Signal mode changed when bpp changed

2019-08-14 Thread Robert Chiras
From: Mirela Rabulea Add mxsfb_atomic_helper_check to signal mode changed when bpp changed. This will trigger the execution of disable/enable on a modeset with different bpp than the current one. Signed-off-by: Mirela Rabulea Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c

[PATCH v2 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-14 Thread Robert Chiras
based on input from the user and panel capabilities. Save the bus format in crtc->mode.private_flags, so the bridge can use it. Signed-off-by: Robert Chiras Signed-off-by: Mirela Rabulea --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 147 ++--- drivers/gpu/drm/mx

[PATCH v2 14/15] drm/mxsfb: Add support for horizontal stride

2019-08-14 Thread Robert Chiras
in order to do horizontal crop on the frame buffer processed by the eLCDIF block. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 79 -- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 26 - drivers/gpu/drm/mxsfb/mxsfb_regs.h | 16

[PATCH v2 12/15] drm/mxsfb: Improve the axi clock usage

2019-08-14 Thread Robert Chiras
the clk API function for enable/disable the clock. Those functions are already checking for NULL clk and returning 0 if that's the case. Signed-off-by: Robert Chiras Acked-by: Leonard Crestez --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 8 drivers/gpu/drm/mxsfb/mxsfb_drv.c | 32

[PATCH v2 15/15] drm/mxsfb: Add support for live pixel format change

2019-08-14 Thread Robert Chiras
This IP requires full stop and re-start when changing display timings, but we can change the pixel format while running. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb

[PATCH v2 02/15] drm/mxsfb: Read bus flags from bridge if present

2019-08-14 Thread Robert Chiras
From: Guido Günther The bridge might have special requirmentes on the input bus. This is e.g. used by the imx-nwl bridge. Signed-off-by: Guido Günther Reviewed-by: Stefan Agner --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 00/15] Improvements and fixes for mxsfb DRM driver

2019-08-14 Thread Robert Chiras
Günther (1): drm/mxsfb: Read bus flags from bridge if present Mirela Rabulea (1): drm/mxsfb: Signal mode changed when bpp changed Robert Chiras (13): drm/mxsfb: Update mxsfb to support a bridge drm/mxsfb: Add defines for the rest of registers drm/mxsfb: Reset vital register for a proper

[PATCH v2 11/15] drm/mxsfb: Update mxsfb to support LCD reset

2019-08-14 Thread Robert Chiras
The eLCDIF controller has control pin for the external LCD reset pin. Add support for it and assert this pin in enable and de-assert it in disable. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 14 ++ drivers/gpu/drm/mxsfb/mxsfb_regs.h | 2 ++ 2 files

[PATCH v2 07/15] drm/mxsfb: Fix the vblank events

2019-08-14 Thread Robert Chiras
with the '-v' parameter will result in an astronomical refresh rate (1+ Hz), because of that. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb

[PATCH v2 13/15] drm/mxsfb: Clear OUTSTANDING_REQS bits

2019-08-14 Thread Robert Chiras
Bit 21 can alter the CTRL2_OUTSTANDING_REQS value right after the eLCDIF is enabled, since it comes up with default value of 1 (this behaviour has been seen on some imx8 platforms). In order to fix this, clear CTRL2_OUTSTANDING_REQS bits before setting its value. Signed-off-by: Robert Chiras

[PATCH v2 03/15] drm/mxsfb: Add defines for the rest of registers

2019-08-14 Thread Robert Chiras
Some of the existing registers in this controller are not defined, but also not used. Add them to the register definitions, so that they can be easily used in future improvements or fixes. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 15 +++ 1 file changed

[PATCH v2 10/15] drm/mxsfb: Add max-res property for MXSFB

2019-08-14 Thread Robert Chiras
Because of stability issues, we may want to limit the maximum resolution supported by the MXSFB (eLCDIF) driver. This patch add support for a new property which we can use to impose such limitation. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 12 ++-- 1 file

[PATCH v2 04/15] drm/mxsfb: Reset vital register for a proper initialization

2019-08-14 Thread Robert Chiras
Some of the regiters need, like LCDC_CTRL and CTRL2_OUTSTANDING_REQS needs to be properly cleared and initialized for a better start and stop routine. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers

[PATCH v2 09/15] dt-bindings: display: Add max-res property for mxsfb

2019-08-14 Thread Robert Chiras
Add new optional property 'max-res', to limit the maximum supported resolution by the MXSFB_DRM driver. Signed-off-by: Robert Chiras --- Documentation/devicetree/bindings/display/mxsfb.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/display

[PATCH v2 01/15] drm/mxsfb: Update mxsfb to support a bridge

2019-08-14 Thread Robert Chiras
. Signed-off-by: Robert Chiras Tested-by: Guido Günther --- drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 17 +++--- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 46 +- drivers/gpu/drm/mxsfb/mxsfb_drv.h | 4 +++- drivers/gpu/drm/mxsfb/mxsfb_out.c | 26

[PATCH v2 05/15] drm/mxsfb: Update register definitions using bit manipulation defines

2019-08-14 Thread Robert Chiras
Use BIT(x) and GEN_MASK(h, l) for better representation the inside of various registers. Signed-off-by: Robert Chiras --- drivers/gpu/drm/mxsfb/mxsfb_regs.h | 151 ++--- 1 file changed, 89 insertions(+), 62 deletions(-) diff --git a/drivers/gpu/drm/mxsfb

  1   2   >