Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_connector.c:199:20:
warning: symbol 'exynos_drm_best_encoder' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |3 ++-
1 files
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Fixes the following sparse warning:
drivers/gpu/drm/drm_info.c:238:5:
warning: symbol 'drm_gem_one_name_info' was not declared. Should it be static?
---
drivers/gpu/drm/drm_info.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 36 ++---
1
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 40 ++
1
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Signed-off-by: Sachin Kamat sachin.ka...@samsung.com
---
drivers/gpu/drm/exynos/exynos_mixer.c | 48 +---
1
Fixes the following sparse warning:
drivers/gpu/drm/drm_proc.c:92:5:
warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
drivers/gpu/drm/drm_proc.c:175:5:
warning: symbol 'drm_proc_remove_files' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
Fixes the following sparse warning:
drivers/gpu/drm/drm_fb_helper.c:239:6: warning:
symbol 'drm_fb_helper_force_kernel_mode' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/drm_fb_helper.c |2 +-
1 files changed, 1 insertions
This series adds devm_* functionality in some drivers and cleans up
some code that remained when the same was added to other drivers earlier.
This series is compile tested against the latest (6 Aug 2012) linux-next code.
Sachin Kamat (5):
drm/exynos: Remove redundant check in exynos_hdmi.c
devm_request_and_ioremap function checks the validity of the
pointer returned by platform_get_resource. Hence an additional check
in the probe function is not necessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_hdmi.c |5 -
1 files changed, 0
devm_request_and_ioremap function checks the validity of the
pointer returned by platform_get_resource. Hence an additional check
in the probe function is not necessary.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |5 -
1 files changed
devm_kzalloc is a device managed function and makes freeing and error
handling simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos
devm_* functions are device managed functions and make error handling
and cleanup cleaner and simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 50 ++
1 files changed, 10 insertions(+), 40 deletions(-)
diff
which has unmet direct
dependencies (USB_SUPPORT USB_ARCH_HAS_HCD)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/Kconfig |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 23120c0..45536db
Select Exynos DRM based G2D only if non-DRM based Exynos G2D driver
is not selected.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/Kconfig |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm
Hi,
Any comments on this series?
Regards
Sachin
On 1 August 2012 17:15, Sachin Kamat sachin.ka...@linaro.org wrote:
Fixes the following sparse warning:
drivers/gpu/drm/drm_proc.c:92:5:
warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
drivers/gpu/drm/drm_proc.c
Hi Dave,
What is your opinion about this patch?
On 15 August 2012 01:27, Sascha Hauer s.ha...@pengutronix.de wrote:
On Tue, Aug 14, 2012 at 05:12:22PM +0530, Sachin Kamat wrote:
In general what you suggested seems to be the right thing to do.
However in this particular case, making
Hi,
Any comments on this series?
On 1 August 2012 17:15, Sachin Kamat sachin.ka...@linaro.org wrote:
Fixes the following sparse warning:
drivers/gpu/drm/drm_proc.c:92:5:
warning: symbol 'drm_proc_create_files' was not declared. Should it be static?
drivers/gpu/drm/drm_proc.c:175:5:
warning
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning:
symbol 'g2d_pm_ops' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
Fixes the following checkpatch warnings:
WARNING: sizeof *res should be sizeof(*res)
WARNING: sizeof res-regul_bulk[0] should be sizeof(res-regul_bulk[0])
WARNING: sizeof *res should be sizeof(*res)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_hdmi.c
Fixes the following checkpatch warnings:
WARNING: sizeof filter_y_horiz_tap8 should be sizeof(filter_y_horiz_tap8)
WARNING: sizeof filter_y_vert_tap4 should be sizeof(filter_y_vert_tap4)
WARNING: sizeof filter_cr_horiz_tap4 should be sizeof(filter_cr_horiz_tap4)
Signed-off-by: Sachin Kamat
drm_mode_create() returns NULL if it fails to create
a new display mode. Check the value returned to avoid NULL
pointer deferencing later.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_connector.c |6 +-
1 files changed, 5 insertions(+), 1
Fixes the following sparse warnings:
drivers/gpu/drm/udl/udl_transfer.c:129:50:
drivers/gpu/drm/udl/udl_transfer.c:130:50:
drivers/gpu/drm/udl/udl_transfer.c:131:45:
drivers/gpu/drm/udl/udl_transfer.c:132:61:
warning: Using plain integer as NULL pointer
Signed-off-by: Sachin Kamat sachin.ka
Fixes the following sparse warnings:
drivers/gpu/drm/udl/udl_fb.c:360:6: warning:
symbol 'udl_crtc_fb_gamma_set' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_fb.c:365:6: warning:
symbol 'udl_crtc_fb_gamma_get' was not declared. Should it be static?
Signed-off-by: Sachin Kamat
Fixes the following sparse warning:
drivers/gpu/drm/udl/udl_encoder.c:19:6: warning:
symbol 'udl_enc_destroy' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/udl/udl_encoder.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
Fixes the following sparse warning:
drivers/gpu/drm/udl/udl_modeset.c:394:5: warning:
symbol 'udl_crtc_init' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/udl/udl_modeset.c |2 +-
1 files changed, 1 insertions(+), 1 deletions
This series fixes some checkpatch warnings and errors in drm_fb_helper.c file.
Build tested using the linux-next tree of 20121114.
Sachin Kamat (3):
drm/fb_helper: Fix checkpatch errors
drm/fb_helper: Convert printk to pr_* and dev_*
drm/drm_fb_helper: Remove unnecessary braces
drivers
= ON - dig; break;
ERROR: trailing statements should be on next line
101: FILE: gpu/drm/drm_fb_helper.c:101:
case DRM_FORCE_ON: s = ON; break;
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/drm_fb_helper.c | 12 +---
1 files changed, 9 insertions(+), 3
Converted printks to pr_* and dev_* to silence checkpatch warnings.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/drm_fb_helper.c | 14 --
1 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm
Remove unnecessary braces to silence the following type of
checkpatch warnings:
WARNING: braces {} are not necessary for single statement blocks
WARNING: braces {} are not necessary for any arm of this statement
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm
/drm/udl/udl_connector.c:106:35: warning:
symbol 'udl_connector_helper_funcs' was not declared. Should it be static?
drivers/gpu/drm/udl/udl_connector.c:112:28: warning:
symbol 'udl_connector_funcs' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:65:25: warning:
symbol 'exynos4_fimd_driver_data' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 files changed, 1
Fixes the following sparse warning:
drivers/gpu/drm/exynos/exynos_drm_fimd.c:69:25: warning:
symbol 'exynos5_fimd_driver_data' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |2 +-
1 files changed, 1
Check overlay_ops is not NULL as checked in the previous 'if' condition.
Fixes the following smatch error:
drivers/gpu/drm/exynos/exynos_drm_encoder.c:509
exynos_drm_encoder_plane_disable()
error: we previously assumed 'overlay_ops' could be null (see line 499)
Signed-off-by: Sachin Kamat
kfree() on a NULL input is a no-op. Hence remove the check.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
This series is build tested on the latest linux-next (20121115).
---
drivers/gpu/drm/drm_crtc.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git
: potential null dereference 'connector-edid_blob_ptr'.
(drm_property_create_blob returns null)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/drm_crtc.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm
/drm_fb_helper.c:1272 drm_setup_crtcs() error:
potential null dereference 'crtcs'. (kcalloc returns null)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Dependent on the following patch series:
http://comments.gmane.org/gmane.comp.video.dri.devel/76605
---
drivers/gpu/drm/drm_fb_helper.c
kfree on a null argument is a no-op.
Silences the following smatch warning:
drivers/gpu/drm/drm_stub.c:496 drm_put_dev() info:
redundant null check on dev-devname calling kfree()
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/drm_stub.c |5 +
1 files changed, 1
Hi Inki,
Thanks for your review. My comments inline.
On 19 November 2012 15:14, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Monday, November 19, 2012 6:21 PM
To: dri-devel@lists.freedesktop.org
Cc: inki
On 19 November 2012 15:15, Inki Dae inki@samsung.com wrote:
Please, combine these patches.
OK. I will re-send.
Thanks,
Inki Dae
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Monday, November 19, 2012 5:38 PM
To: dri-devel@lists.freedesktop.org
?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 130a2b5..e08478f 100644
On 19 November 2012 15:30, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Monday, November 19, 2012 6:56 PM
To: Inki Dae
Cc: dri-devel@lists.freedesktop.org; jy0922.s...@samsung.com;
patc...@linaro.org
Subject: Re
nouveau_ttm.h was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/nouveau/nouveau_drm.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c
b/drivers/gpu/drm/nouveau/nouveau_drm.c
index 0910125
core/device.h was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/nouveau/core/subdev/device/base.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/subdev/device/base.c
b/drivers/gpu/drm/nouveau/core
Hi Dave,
Please ignore this patch.
On 19 November 2012 15:14, Sachin Kamat sachin.ka...@linaro.org wrote:
kfree() on a NULL input is a no-op. Hence remove the check.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
This series is build tested on the latest linux-next (20121115
On 21 November 2012 20:42, Sachin Kamat sachin.ka...@linaro.org wrote:
Hi Dave,
Please ignore this patch.
Please ignore this mail. Sorry for the noise.
--
With warm regards,
Sachin
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http
Hi Inki,
On 19 November 2012 15:32, Sachin Kamat sachin.ka...@linaro.org wrote:
On 19 November 2012 15:30, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Monday, November 19, 2012 6:56 PM
To: Inki Dae
Cc: dri-devel
[snip]
And NULL pointer checking was already done above like below,
if (overlay_ops overlay_ops-disable)
overlay_ops-disable(manager-dev, zpos);
Correct. But that check is applicable only for that one statement
(overlay_ops-disable(manager-dev, zpos);).
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_mixer.c | 20 +---
1 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/exynos
First 4 patches use devm_* APIs for simpler code and cleanup.
Last one fixes a potential bug.
Series is build tested and based on the exynos-drm-next branch of the
following tree:
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git
Sachin Kamat (5):
drm/exynos: Use
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/exynos
devm_gpio_request is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_hdmi.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c
b
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
b
Pointer was being dereferenced after freeing.
Fixes the following error:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:323 g2d_userptr_put_dma_addr() error:
dereferencing freed memory 'g2d_userptr'
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2
On 23 November 2012 12:10, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Friday, November 23, 2012 12:42 PM
To: dri-devel@lists.freedesktop.org
Cc: inki@samsung.com; jy0922.s...@samsung.com; airl...@linux.ie
On 23 November 2012 12:21, Inki Dae inki@samsung.com wrote:
[snip]
With cleanup to hdmi_resources_init, we can remove hdmi_resource_cleanup
function. So could you please re-send updated patches?
OK. I will update and re-send.
You've been submitting patches into too small pieces.
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_mixer.c | 59 +
1 files changed, 16 insertions(+), 43 deletions(-)
diff --git a/drivers/gpu/drm
devm_* functions are device managed and make error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_hdmi.c | 60 +++--
1 files changed, 13 insertions(+), 47 deletions(-)
diff --git a/drivers/gpu
devm_clk_get is device managed and makes error handling and exit code
simpler.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31 ++---
1 files changed, 7 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm
send another one? Sorry for inconvenient. :)
He he.. no problem.. i will send another patch which just contains
removing clk_disable.
Thanks,
Inki Dae
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Friday, November 23, 2012 5:43 PM
To: dri-devel
Also fixes an error related to returning 'ret' without initialising
with error code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 22 +-
1 files changed, 5 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm
devm_clk_get is device managed and makes error handling and exit code
simpler.
Also fixes an error related to returning 'ret' without initialising
with error code.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 31
Ok. Mailed you the combined patch.
On 24 November 2012 11:10, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sachin Kamat [mailto:sachin.ka...@linaro.org]
Sent: Friday, November 23, 2012 7:06 PM
To: dri-devel@lists.freedesktop.org
Cc: inki@samsung.com; sachin.ka
ping
On 20 November 2012 11:23, Sachin Kamat sachin.ka...@linaro.org wrote:
nouveau_ttm.h was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/nouveau/nouveau_drm.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
ping..
On 20 November 2012 11:35, Sachin Kamat sachin.ka...@linaro.org wrote:
core/device.h was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/nouveau/core/subdev/device/base.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git
On 27 November 2012 09:09, Ben Skeggs bske...@redhat.com wrote:
On Tue, 2012-11-27 at 09:04 +0530, Sachin Kamat wrote:
ping
On 20 November 2012 11:23, Sachin Kamat sachin.ka...@linaro.org wrote:
nouveau_ttm.h was included twice.
I've queued it in my tree, thanks!
Thanks Ben. There is also
drm/drm_edid.h was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/i915/intel_modes.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_modes.c
b/drivers/gpu/drm/i915/intel_modes.c
index b00f1c8..49249bb
subdev/bar.h was included twice.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/nouveau/core/engine/disp/nv50.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/core/engine/disp/nv50.c
b/drivers/gpu/drm/nouveau/core/engine
Add CONFIG_OF to compile conditionally. of_match_ptr eliminates having
an #ifdef returning NULL for the case when OF is disabled.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_ddc.c |4 +++-
drivers/gpu/drm/exynos/exynos_hdmi.c|4
This is an unlikely case. However to silence the following smatch error
add a NULL check:
drivers/gpu/drm/exynos/exynos_hdmi.c:2486 hdmi_probe()
error: potential NULL dereference 'match'.
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_hdmi.c |2 ++
1
Compile tested against linux-next tree (20121224).
Sachin Kamat (10):
drm/exynos: Use devm_kzalloc in exynos_drm_ipp.c
drm/exynos: Remove explicit freeing using devm_* APIs in
exynos_drm_fimc.c
drm/exynos: Remove redundant NULL check
drm/exynos: Use devm_clk_get in exynos_drm_fimc.c
devm_kzalloc makes the code simpler by eliminating the need for
explicit freeing.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |9 ++---
1 files changed, 2 insertions(+), 7 deletions(-)
diff
devm_* APIs are device managed and get freed automatically when the
device detaches. Thus explicit freeing is not needed. This saves some
code.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 30
devm_request_and_ioremap API checks for NULL. Hence explicit
NULL check is not necessary. Saves some code.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c |6 --
1 files changed, 0 insertions(+), 6
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 46 ++---
1 files changed, 10
devm_* APIs are device managed and get freed automatically when the
device detaches. Thus explicit freeing is not needed. This saves some
code.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c | 18
devm_request_and_ioremap API checks for NULL. Hence explicit
NULL check is not necessary. Saves some code.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |5 -
1 files changed, 0 insertions
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |4 +---
1 files changed, 1 insertions(+), 3 deletions
devm_* APIs are device managed and get freed automatically when the
device detaches. Thus explicit freeing is not needed. This saves some
code.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 15
devm_request_and_ioremap API checks for NULL. Hence explicit
NULL check is not necessary. Saves some code.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c |6 --
1 files changed, 0 insertions(+), 6
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 13 -
1 files changed, 4 insertions(+), 9
On Wednesday, 26 December 2012, Inki Dae inki@samsung.com wrote:
2012/12/24 Sachin Kamat sachin.ka...@linaro.org
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat
On Wednesday, 26 December 2012, Inki Dae inki@samsung.com wrote:
2012/12/24 Sachin Kamat sachin.ka...@linaro.org
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat
On 27 December 2012 15:43, Inki Dae inki@samsung.com wrote:
2012/12/26 Sachin Kamat sachin.ka...@linaro.org
On Wednesday, 26 December 2012, Inki Dae inki@samsung.com wrote:
2012/12/24 Sachin Kamat sachin.ka...@linaro.org
This eliminates the need for explicit clk_put
This eliminates the need for explicit clk_put and makes the
cleanup and exit path code simpler.
Cc: Eunchul Kim chulspro@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_fimc.c | 45 ++
1 files changed, 9
Hi Vikas,
Some nitpicks inline
Subject: s/Complaint/Compliant
On 2 January 2013 18:47, Vikas C Sajjan vikas.saj...@linaro.org wrote:
From: Vikas Sajjan vikas.saj...@linaro.org
Please add some description about this patch here.
Signed-off-by: Vikas Sajjan vikas.saj...@linaro.org
---
+CC: ALSA mailing list, Mark Brown
On 13 January 2013 18:22, Rahul Sharma rahul.sha...@samsung.com wrote:
This patch registers hdmi-audio codec to the ALSA framework. This is the
second
client to the hdmi panel. Once notified by the CDF Core it proceeds towards
audio setting and audio
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_g2d.c:327:12: warning:
symbol 'g2d_userptr_get_dma_addr' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files changed, 1 insertions
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_ipp.c:872:6: warning:
symbol 'ipp_handle_cmd_work' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c |2 +-
1 files changed, 1 insertions(+), 1
-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_rotator.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c
b/drivers/gpu/drm/exynos/exynos_drm_rotator.c
index e9e83ef..f976e29 100644
--- a/drivers/gpu
Fixes the following warning:
drivers/gpu/drm/exynos/exynos_drm_hdmi.c:111:13: warning:
symbol 'drm_hdmi_get_edid' was not declared. Should it be static?
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
Compile tested on exynos-drm-fixes branch of Inki Dae's tree.
---
drivers/gpu/drm
Fixes the following checkpatch warning:
WARNING: sizeof *sgt should be sizeof(*sgt)
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
b
From: Ajay Kumar ajaykumar...@samsung.com
This patch adds device tree match table for Exynos G2D controller.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++
1 files changed, 10
Hi Vikas,
This patch should be numbered 0/1 as it is not a patch in itself and
the subsequent patch should be 1/1 so as to show that these 2 together
form a series.
Also, your subject line seems to have been truncated.
On 28 January 2013 11:15, Vikas Sajjan vikas.saj...@linaro.org wrote:
This
Hi Vikas,
Changelog mentioning differences between v1 and v2 is generally
preferred as it will help the reviewers.
On 30 January 2013 12:00, Vikas Sajjan vikas.saj...@linaro.org wrote:
This patch adds display-timing node parsing to drm fimd, this depends on
the display helper patchset at
Hi Sylwester.
Thank you for the review.
On 31 January 2013 03:08, Sylwester Nawrocki
sylvester.nawro...@gmail.com wrote:
Hi Sachin,
On 01/25/2013 10:55 AM, Sachin Kamat wrote:
This patch adds device tree based discovery support to G2D driver
Signed-off-by: Sachin Kamatsachin.ka
On 1 February 2013 06:57, Inki Dae inki@samsung.com wrote:
For example,
If compatible = samsung,g2d-3.0 is added to exynos4210.dtsi, it'd be
reasonable. But what if that compatible string is added to exynos4.dtsi?.
This case isn't considered for exynos4412 SoC with v4.1.
In case of
In any case please let me know the final preferred one so that I can
update the code send the revised patches.
The version with SoC name embedded in it seems most reliable and correct
to me.
compatible = samsung,exynos3110-fimg-2d /* for Exynos3110 (S5PC110,
S5PV210),
On 1 February 2013 17:02, Inki Dae inki@samsung.com wrote:
How about using like below?
Compatible = samsung,exynos4x12-fimg-2d /* for Exynos4212,
Exynos4412 */
It looks odd to use samsung,exynos4212-fimg-2d saying that this ip is for
exynos4212 and exynos4412.
AFAIK, compatible
On 1 February 2013 18:28, Inki Dae daei...@gmail.com wrote:
2013. 2. 1. 오후 8:52 Inki Dae inki@samsung.com 작성:
-Original Message-
From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
ow...@vger.kernel.org] On Behalf Of Sachin Kamat
Sent: Friday, February 01, 2013 8
On 5 February 2013 15:03, Sylwester Nawrocki s.nawro...@samsung.com wrote:
On 02/05/2013 04:03 AM, Inki Dae wrote:
[...]
Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same
comptible string will be used for this one too.
And please check if exynos4212 and 4412 SoCs have same
1 - 100 of 388 matches
Mail list logo
