connector - encoder relationship

2011-05-25 Thread Sascha Hauer
Hi All, I'm currently looking into implementing a SoC graphics core with KMS. What I wonder about is the relationship between connectors and encoders. On my board I have a sii9022 HDMI encoder connected via i2c. This chip supports reading edid data, tracks the connection status of the display

Re: connector - encoder relationship

2011-05-27 Thread Sascha Hauer
On Wed, May 25, 2011 at 12:07:33PM -0400, Alex Deucher wrote: On Wed, May 25, 2011 at 4:36 AM, Sascha Hauer s.ha...@pengutronix.de wrote: Hi All, I'm currently looking into implementing a SoC graphics core with KMS. What I wonder about is the relationship between connectors and encoders

[PATCH] drm: fix fbs in DRM_IOCTL_MODE_GETRESOURCES ioctl

2011-06-03 Thread Sascha Hauer
The DRM_IOCTL_MODE_GETRESOURCES ioctl just returns bogus framebuffers. That is because the framebuffers for each file are in the filp_head member of struct drm_framebuffer, not in the head member. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c |2 +- 1

Re: [PATCH] drm: fix fbs in DRM_IOCTL_MODE_GETRESOURCES ioctl

2011-06-07 Thread Sascha Hauer
Hi David, Somehow my Cc got lost. Maybe you missed this. Any comments? Thanks Sascha On Fri, Jun 03, 2011 at 12:54:14PM +0200, Sascha Hauer wrote: The DRM_IOCTL_MODE_GETRESOURCES ioctl just returns bogus framebuffers. That is because the framebuffers for each file are in the filp_head

[PATCH 5/5] DRM: Add i.MX IPUv3 support

2011-06-07 Thread Sascha Hauer
This adds a i.MX51/53 IPU (Image Processing Unit) KMS driver. The driver has been tested on the i.MX51 babbage board and the i.MX53 LOCO board in different clone mode and dual head setups. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/Kconfig|9 + drivers/gpu

[PATCH 4/5] DRM: Add support for the sii902x HDMI/DVI encoder

2011-06-07 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/Kconfig |6 + drivers/gpu/drm/i2c/Makefile |3 + drivers/gpu/drm/i2c/sii902x.c | 334 + 3 files changed, 343 insertions(+), 0 deletions(-) create mode 100644 drivers/gpu

[PATCH 2/5] DRM i.MX IPU: Add support for IPU submodules

2011-06-07 Thread Sascha Hauer
Can be squashed into the last patch, just split up to avoid hitting list limits. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/imx/ipu-v3/Makefile |2 +- drivers/gpu/drm/imx/ipu-v3/ipu-dc.c | 440 ++ drivers/gpu/drm/imx/ipu-v3/ipu-di.c

Re: [RFC PATCH] KMS support for i.MX51/53

2011-06-07 Thread Sascha Hauer
On Tue, Jun 07, 2011 at 12:17:01PM +0100, Alan Cox wrote: Currently I don't use any sophisticated memory allocater like GEM or similar. I helped myself with simple dma_alloc where needed. At GEM is actually pretty sane when you get your head around it a spot. The main thing it took me a

Re: [PATCH 4/5] DRM: Add support for the sii902x HDMI/DVI encoder

2011-07-12 Thread Sascha Hauer
On Fri, Jul 08, 2011 at 11:01:18PM +0200, Michał Mirosław wrote: 2011/6/7 Sascha Hauer s.ha...@pengutronix.de: [...] --- /dev/null +++ b/drivers/gpu/drm/i2c/sii902x.c @@ -0,0 +1,334 @@ [...] +static int sii902x_write(struct i2c_client *client, uint8_t addr, uint8_t val

Re: [PATCH] [RFC PATCH] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-07-29 Thread Sascha Hauer
Hi, On Fri, Jul 29, 2011 at 04:24:35PM +0900, Inki Dae wrote: This patch is a DRM Driver(only including FIMD Driver yet) for Samsung SoC Exynos4210. and as RFC, I am sending only DRM driver part. this patch is based on git repository below:

Re: [PATCH] [RFC PATCH] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-03 Thread Sascha Hauer
On Mon, Aug 01, 2011 at 12:52:37PM +0900, daeinki wrote: Hi, Sascha Hauer. thank you for your comments and below is my answer. Sascha Hauer wrote: Hi, On Fri, Jul 29, 2011 at 04:24:35PM +0900, Inki Dae wrote: This patch is a DRM Driver(only including FIMD Driver yet) for Samsung SoC

Re: [PATCH] [RFC PATCH] DRM: add DRM Driver for Samsung SoC EXYNOS4210.

2011-08-04 Thread Sascha Hauer
-next. It would be nice it was as its also the same as the code being carried in the GEM glue for the gma500 driver so we now have 3 users (plus i915 can use it). I agree with Sascha Hauer that a lot more could be shared with other (particularly future 'dumb') drivers. I think however it would

[PATCH 01/20] drm crtc: use drm_mode_destroy instead of kfree in drm_mode_remove

2012-02-01 Thread Sascha Hauer
Modes are created using drm_mode_create which does a drm_mode_object_get, so use drm_mode_destroy in drm_mode_remove which does a drm_mode_object_put. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions

[PATCH 13/20] drm crtc: Fix locking comments

2012-02-01 Thread Sascha Hauer
Several comments above functions say that the caller must hold the mode_config lock, but the functions take the lock themselves. Fix the comments. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c | 21 +++-- 1 files changed, 15 insertions(+), 6

[PATCH 05/20] drm: add proper return value for drm_mode_crtc_set_gamma_size

2012-02-01 Thread Sascha Hauer
drm_mode_crtc_set_gamma_size returns boolean true for success and false for failure. This is not very kernel conform, so change it to return 0 for success and a propert error code otherwise. Noone checks the return value, so no users have to be fixed. Signed-off-by: Sascha Hauer s.ha

[PATCH 11/20] drm fb helper: add the connectors inside drm_fb_helper_initial_config

2012-02-01 Thread Sascha Hauer
drm_fb_helper_single_add_all_connectors is always called in conjunction with drm_fb_helper_initial_config, so call drm_fb_helper_single_add_all_connectors inside drm_fb_helper_initial_config and make drm_fb_helper_single_add_all_connectors static. Signed-off-by: Sascha Hauer s.ha

[PATCH 12/20] drm crtc_helper: use list_for_each_entry

2012-02-01 Thread Sascha Hauer
list_for_each_entry_safe is for walking a list safe against removal of entries. Here, no entries are removed, so use list_for_each_entry. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc_helper.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions

[PATCH 09/20] drm fb_helper: use lists for crtcs.

2012-02-01 Thread Sascha Hauer
The fb helper uses fixed size arrays for the associated crtcs. This is an unnecessary limitation, so instead use a list to store the crtcs and allocate them dynamically. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_fb_helper.c | 129

[PATCH 03/20] drm drm_edit: drm modes have to be free with drm_mode_destroy

2012-02-01 Thread Sascha Hauer
to add the missing drm_mode_object_put for that mode. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_edid.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c index ece03fc..770d894 100644

[PATCH 06/20] drm fb helper: use drm_helper_connector_dpms to do dpms

2012-02-01 Thread Sascha Hauer
drm_fb_helper_on|off currently manually searches for encoders to turn on/off. Make this simpler by using the helper function. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_fb_helper.c | 80 +-- 1 files changed, 10 insertions

[PATCH 08/20] drm fb helper: remove unused variable crtc_id

2012-02-01 Thread Sascha Hauer
crtc_id is set but never used, so remove it from struct drm_fb_helper_crtc. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_fb_helper.c |1 - include/drm/drm_fb_helper.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 19/20] drm exynos: use drm_fb_helper_set_par directly

2012-02-01 Thread Sascha Hauer
info-fix.visual already is correctly set from drm_fb_helper_fill_fix. info-fix.line_length is also set from drm_fb_helper_fill_fix, so drm_fb_helper_set_par directly instead of a custom exynos_drm_fbdev_set_par. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Inki Dae inki@samsung.com

[PATCH 10/20] drm: remove now unused crtc_count parameter from drm_fb_helper_init

2012-02-01 Thread Sascha Hauer
As the crtcs are now allocated dynamically we don't need the crtc_count parameter anymore. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_fb_helper.c |2 +- drivers/gpu/drm/exynos/exynos_drm_fbdev.c |8 ++-- drivers/gpu/drm/gma500/framebuffer.c

[PATCH 16/20] drm: store connector properties in list

2012-02-01 Thread Sascha Hauer
Storing the properties associated to a connector in a list allows us to drop the current limitation on a maximum number of properties per connector. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c | 109 --- include/drm

[PATCH 15/20] drm: add convenience function to create an range property

2012-02-01 Thread Sascha Hauer
Creating a range property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c| 69 - drivers/gpu/drm/gma500/framebuffer.c

[PATCH 17/20] drm: remove checks for same value in set_prop

2012-02-01 Thread Sascha Hauer
The drivers currently check in set_property whether the property is unchanged. move this check into the core and do not bother the drivers with checking for unchanged properties. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c |5

[PATCH 02/20] drm crtc: add forgotten idr cleanup functions

2012-02-01 Thread Sascha Hauer
drm_mode_config_init initializes the idr with idr_init, so add the missing counterparts in drm_mode_config_cleanup. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
Creating an enum property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c| 100 +--- drivers/gpu/drm/i915/intel_modes.c

[PATCH 18/20] drm: do not call drm_connector_property_set_value from drivers

2012-02-01 Thread Sascha Hauer
If a property has changed successfully the core will call drm_connector_property_set_value, so do not duplicate this call in the drivers. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/gma500/cdv_intel_hdmi.c |4 drivers/gpu/drm/gma500/cdv_intel_lvds.c | 23

[PATCH] drm cleanup patches

2012-02-01 Thread Sascha Hauer
with the nouveau driver and a DELL E6220 Laptop using the intel driver. Please review and consider applying Sascha Sascha Hauer (20): drm crtc: use drm_mode_destroy instead of kfree in drm_mode_remove drm crtc: add forgotten idr cleanup functions drm drm_edit: drm modes have

[PATCH 07/20] drm fb helper: remove unused variable conn_limit

2012-02-01 Thread Sascha Hauer
conn_limit is set but never used. Remove it from struct drm_fb_helper. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_fb_helper.c |2 +- include/drm/drm_fb_helper.h |1 - 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 04/20] drm drm_fb_helper: destroy modes

2012-02-01 Thread Sascha Hauer
drm_setup_crtcs allocated modes using drm_mode_duplicate. Free them in drm_fb_helper_crtc_free. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_fb_helper.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 11:48:53AM +, Chris Wilson wrote: On Wed, 1 Feb 2012 11:38:32 +0100, Sascha Hauer s.ha...@pengutronix.de wrote: Creating an enum property is a common pattern, so create a convenience function for this and use it where appropriate. Similar naming comments

Re: [PATCH 17/20] drm: remove checks for same value in set_prop

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 11:55:44AM +, Chris Wilson wrote: On Wed, 1 Feb 2012 11:38:35 +0100, Sascha Hauer s.ha...@pengutronix.de wrote: The drivers currently check in set_property whether the property is unchanged. move this check into the core and do not bother the drivers

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-01 Thread Sascha Hauer
On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8d593ad..cdbbb40 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -394,7 +394,7 @@ struct drm_crtc { s64 framedur_ns,

[PATCH] drm: cleanup device registration

2012-02-02 Thread Sascha Hauer
devices could give this series a test. Sascha Sascha Hauer (12): drm: remove kdriver union from struct drm_driver drm: remove platformdev and usbdev from struct drm_device drm: remove unused field bus_type from struct drm_bus drm: provide a pci probe function for non

[PATCH 05/12] drm: use drm_get_platform_dev and drop drm_platform_init/exit

2012-02-02 Thread Sascha Hauer
drm_platform_init is modelled after the legacy pci probe support. It initializes a device_list, but this list will only ever have a single entry as it is specific to a single platform device instance. Simplify this by calling drm_get_platform_dev directly from the driver. Signed-off-by: Sascha

[PATCH 12/12] drm usb: use drm_register_device

2012-02-02 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_usb.c | 43 ++- 1 files changed, 2 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/drm_usb.c b/drivers/gpu/drm/drm_usb.c index dd154d4..b741b54 100644 --- a/drivers

[PATCH 10/12] drm pci: use drm_register_device

2012-02-02 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_pci.c | 45 +++-- 1 files changed, 3 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c index c0d47ab..2407a1d 100644 --- a/drivers

[PATCH 09/12] drm: Add drm_register_device function

2012-02-02 Thread Sascha Hauer
pci, usb and platform support all duplicate the same code. Provide a common function for this. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_stub.c | 56 include/drm/drmP.h |2 + 2 files changed, 58

[PATCH 11/12] drm platform: use drm_register_device

2012-02-02 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_platform.c | 51 ++- 1 files changed, 3 insertions(+), 48 deletions(-) diff --git a/drivers/gpu/drm/drm_platform.c b/drivers/gpu/drm/drm_platform.c index 7153508..5d5e388 100644

[PATCH 06/12] drm usb: drop drm_usb_init/exit

2012-02-02 Thread Sascha Hauer
Usb drivers can register themselves and call drm_get_usb_dev in their probe function. We don't need a drm specific wrapper function for this. As there are currently no users, none a touched here. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_usb.c | 26

[PATCH 02/12] drm: remove platformdev and usbdev from struct drm_device

2012-02-02 Thread Sascha Hauer
struct drm_device has a struct usbdevice * and a struct platform_device *. This is unused, so remove it. If the platform_device or usbdevice is needed, we can always get it using to_usb_device or to to_platform_device. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm

[PATCH 08/12] drm vmwgfx: remove unused field vmw_chipset from struct vmw_private

2012-02-02 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c |1 - drivers/gpu/drm/vmwgfx/vmwgfx_drv.h |1 - 2 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index

[PATCH 01/12] drm: remove kdriver union from struct drm_driver

2012-02-02 Thread Sascha Hauer
drm_device-name, so return this name instead and remove the now unnecessary code. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_pci.c | 10 +++--- drivers/gpu/drm/drm_platform.c |1 - drivers/gpu/drm/drm_usb.c |1 - include/drm/drmP.h

[PATCH 03/12] drm: remove unused field bus_type from struct drm_bus

2012-02-02 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_pci.c |1 - drivers/gpu/drm/drm_platform.c |1 - drivers/gpu/drm/drm_usb.c |1 - include/drm/drmP.h |5 - 4 files changed, 0 insertions(+), 8 deletions(-) diff --git a/drivers/gpu

[PATCH 04/12] drm: provide a pci probe function for non modesetting devices

2012-02-02 Thread Sascha Hauer
This way we do not need the legacy handcrafted probe mechanism anymore and can remove it. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_pci.c | 41 +- drivers/gpu/drm/i810/i810_drv.c | 16 + drivers/gpu

Re: [PATCH] drm: cleanup device registration

2012-02-02 Thread Sascha Hauer
On Thu, Feb 02, 2012 at 07:05:00AM -0500, David Airlie wrote: - Original Message - From: Sascha Hauer s.ha...@pengutronix.de To: dri-devel@lists.freedesktop.org Cc: Inki Dae inki@samsung.com, ker...@pengutronix.de Sent: Thursday, 2 February, 2012 11:57:52 AM Subject: [PATCH

Re: [PATCH] drm cleanup patches

2012-02-02 Thread Sascha Hauer
Hi David, On Wed, Feb 01, 2012 at 11:38:18AM +0100, Sascha Hauer wrote: The following patches contain some fixes and cleanups for the drm core. - fix memory holes - make some initialization / deinitialization more symmetric - add convenience functions for creating properties - remove

Re: [PATCH] drm: cleanup device registration

2012-02-02 Thread Sascha Hauer
On Thu, Feb 02, 2012 at 02:27:18PM +, Alan Cox wrote: I see. For example the i810 also has a framebuffer driver. Do you see a way to fix this except writing a kms driver for all legacy devices? Otherwise I would leave the pci part untouched and only keep the platform/USB pieces which

Re: [PATCH 14/20] drm: add convenience function to create an enum property

2012-02-03 Thread Sascha Hauer
On Fri, Feb 03, 2012 at 10:08:12AM +, Dave Airlie wrote: On Wed, Feb 1, 2012 at 1:05 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Wed, Feb 01, 2012 at 07:55:40AM -0500, David Airlie wrote: diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 8d593ad..cdbbb40

Re: [PATCH 09/20] drm fb_helper: use lists for crtcs.

2012-02-04 Thread Sascha Hauer
On Fri, Feb 03, 2012 at 10:04:27AM +, Dave Airlie wrote: On Wed, Feb 1, 2012 at 10:38 AM, Sascha Hauer s.ha...@pengutronix.de wrote: The fb helper uses fixed size arrays for the associated crtcs. This is an unnecessary limitation, so instead use a list to store the crtcs and allocate

[PATCH v2] drm property helper patches

2012-02-06 Thread Sascha Hauer
These are some of the remaining patches from my previous cleanup series with the comments from Chris Wilson integrated. The still remaining patches require some more work and I will send them later. Sascha Sascha Hauer (3): drm: add convenience function to create an enum property drm

[PATCH 1/3] drm: add convenience function to create an enum property

2012-02-06 Thread Sascha Hauer
Creating an enum property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c| 100 +--- drivers/gpu/drm/i915/intel_modes.c

[PATCH 2/3] drm: add convenience function to create an range property

2012-02-06 Thread Sascha Hauer
Creating a range property is a common pattern, so create a convenience function for this and use it where appropriate. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c| 69 - drivers/gpu/drm/gma500/framebuffer.c

[PATCH 3/3] drm: do not set fb_info-pixmap fields

2012-02-06 Thread Sascha Hauer
The drm drivers set the fb_info-pixmap fields without setting fb_info-pixmap.addr. If this is not set the fb core will overwrite these all fb_info-pixmap fields anyway, so there is not much point in setting them in the first place. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers

Re: [PATCH 09/20] drm fb_helper: use lists for crtcs.

2012-02-06 Thread Sascha Hauer
On Sat, Feb 04, 2012 at 11:21:34AM +, Dave Airlie wrote: On Sat, Feb 4, 2012 at 10:47 AM, Sascha Hauer s.ha...@pengutronix.de wrote: On Fri, Feb 03, 2012 at 10:04:27AM +, Dave Airlie wrote: On Wed, Feb 1, 2012 at 10:38 AM, Sascha Hauer s.ha...@pengutronix.de wrote: The fb helper

Re: [PATCH 1/5] drm/usb: add a busid implementation

2012-02-20 Thread Sascha Hauer
Hi Dave, On Mon, Feb 20, 2012 at 04:13:45PM +, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This adds an implementation for the busid callback so userspace can distinguish usb devices better. Is it really worth it to add such an interface from the old days for new drivers?

[PATCH] drm: remove unused code

2012-02-29 Thread Sascha Hauer
remove declared but unused functions from drmP.h, fix the comments where necessary. Also, remove drm_mem_info which is unused. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_irq.c|4 ++-- drivers/gpu/drm/drm_memory.c | 19 --- include/drm

libdrm and platform devices?

2012-03-02 Thread Sascha Hauer
Hi All, I have a drm device on the platform bus, similar to the exynos driver. right now libdrm (at least the tests included in libdrm) refuses to open the device because i915, nouveau, radeon and vmwgfx is all they know about. Looking at the libdrm code it is not obvious how to fix this (except

Re: libdrm and platform devices?

2012-03-02 Thread Sascha Hauer
On Fri, Mar 02, 2012 at 12:02:21PM +, Dave Airlie wrote: I have a drm device on the platform bus, similar to the exynos driver. right now libdrm (at least the tests included in libdrm) refuses to open the device because i915, nouveau, radeon and vmwgfx is all they know about. Looking

[PATCH 1/5] fix if() brackets in Probe function

2012-03-03 Thread Sascha Hauer
in Probe() the indention shows what's meant but there are no brackets. Add them. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- src/driver.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/driver.c b/src/driver.c index d8bb7b5..2004434 100644 --- a/src

xf86-video-modesetting platform patches

2012-03-03 Thread Sascha Hauer
Hi Dave, The following patches are necessary to make the modesetting driver work on !PCI devices. based on 0.2.0. Sascha Sascha Hauer (5): fix if() brackets in Probe function introduce open_hw() function make

[PATCH 4/5] Fix non PCI device probing

2012-03-03 Thread Sascha Hauer
or to the default device. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- src/driver.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/driver.c b/src/driver.c index a9422a5..c7532d3 100644 --- a/src/driver.c +++ b/src/driver.c @@ -416,8 +416,6 @@ PreInit

[PATCH 5/5] do not bail out on non pci devices

2012-03-03 Thread Sascha Hauer
To make the driver work on nin PCI devices we shouldn't bail out in this case. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- src/driver.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/src/driver.c b/src/driver.c index c7532d3..87431ff 100644 --- a/src

[PATCH 2/5] introduce open_hw() function

2012-03-03 Thread Sascha Hauer
probe_hw use it. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- src/driver.c | 19 +-- 1 files changed, 13 insertions(+), 6 deletions(-) diff --git a/src/driver.c b/src/driver.c index 2004434..dc90e04 100644 --- a/src/driver.c +++ b/src/driver.c @@ -174,7 +174,7

Re: [PATCH] drm: exynos: Fix fb_videomode - drm_mode_modeinfo conversion

2012-03-08 Thread Sascha Hauer
On Thu, Mar 08, 2012 at 04:31:51PM +0100, Laurent Pinchart wrote: Hi Joonyoung, On Thursday 08 March 2012 22:05:50 Joonyoung Shim wrote: On 03/08/2012 08:34 PM, Laurent Pinchart wrote: The fb_videomode structure stores the front porch and back porch in the right_margin and left_margin

[PATCH 2/7] drm: make gamma_set optional

2012-04-11 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index b14496e..75f66a5 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c

[PATCH 5/7] DRM: add i.MX kms simple driver

2012-04-11 Thread Sascha Hauer
This adds a sdrm driver for the Freescale i.MX LCDC controller. It is found on i.MX1, i.MX21, i.MX25 and i.MX27. Currently only the base framebuffer is supported, no overlay. This has been tested on an i.MX27 custom board with the xf86 modesetting driver. Signed-off-by: Sascha Hauer s.ha

[PATCH 1/7] drm: remove legacy mode_group handling

2012-04-11 Thread Sascha Hauer
to the components used in a particular control group a better way would be to use a list instead. This would allow to add/remove components to a control group without having to reallocate the array of pointers. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/drm_crtc.c | 158

[PATCH 6/7] ARM i.MX27 pcm038: Add sdrm support

2012-04-11 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- arch/arm/mach-imx/pcm970-baseboard.c | 78 +- 1 file changed, 77 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-imx/pcm970-baseboard.c b/arch/arm/mach-imx/pcm970-baseboard.c index 99afbc3..17758f8

[PATCH 7/7] DRM: add PXA kms simple driver

2012-04-11 Thread Sascha Hauer
adds EOFINT and SOFINT bit definitions for the LDCMD registers. Signed-off-by: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- arch/arm/mach-pxa/include/mach/regs-lcd.h |2 + drivers/gpu/drm/Kconfig |2 + drivers/gpu/drm/Makefile

[RFC] DRM helpers for embedded systems

2012-04-11 Thread Sascha Hauer
/sdrm for you to fetch changes up to fc3d0ff4825de998f1fd902184f7df040248d0de: DRM: add PXA kms simple driver (2012-04-11 17:10:46 +0200) Philipp Zabel (1): DRM: add PXA kms simple driver Sascha Hauer (6): drm: remove

[PATCH 3/7] DRM: add sdrm layer for general embedded system support

2012-04-11 Thread Sascha Hauer
with the exynos_ prefix replaced with a sdrm_ prefix. The 's' in sdrm has no special meaning, depending on what you think about it it can stand for 'Simple', 'Stupid', or 'Saschas' drm. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/Kconfig |2 + drivers/gpu

Re: [PATCH 3/7] DRM: add sdrm layer for general embedded system support

2012-04-12 Thread Sascha Hauer
On Wed, Apr 11, 2012 at 09:22:47PM +0100, Alan Cox wrote: +static int sdrm_suspend(struct drm_device *drm, pm_message_t state) +{ + /* TODO */ + + return 0; +} + +static int sdrm_resume(struct drm_device *drm) +{ + /* TODO */ + + return 0; +} These probably

Re: [RFC 4/4] drm: Add NVIDIA Tegra support

2012-04-12 Thread Sascha Hauer
On Wed, Apr 11, 2012 at 12:12:14PM -0600, Stephen Warren wrote: On 04/11/2012 06:10 AM, Thierry Reding wrote: This commit adds a very basic DRM driver for NVIDIA Tegra SoCs. It currently has rudimentary GEM support and can run a console on the framebuffer as well as X using the

Re: [PATCH 3/7] DRM: add sdrm layer for general embedded system support

2012-04-20 Thread Sascha Hauer
[Added some embedded graphics maintainers to Cc who might be interested in this] On Fri, Apr 20, 2012 at 11:02:02AM +0100, Dave Airlie wrote: On Wed, Apr 11, 2012 at 4:33 PM, Sascha Hauer s.ha...@pengutronix.de wrote: This patch adds support for creating simple drm devices. The basic idea

Re: [PATCH 3/7] DRM: add sdrm layer for general embedded system support

2012-04-20 Thread Sascha Hauer
On Fri, Apr 20, 2012 at 02:38:43PM +0200, Thierry Reding wrote: * Dave Airlie wrote: I get the feeling the drm can just be a virtual platform device of some sort, then it reads the device tree and binds all the information on what crtc/encoders are available, That's pretty much what I've

Re: [PATCH 3/7] DRM: add sdrm layer for general embedded system support

2012-04-20 Thread Sascha Hauer
On Fri, Apr 20, 2012 at 03:25:58PM +0100, Mark Brown wrote: On Fri, Apr 20, 2012 at 02:38:43PM +0200, Thierry Reding wrote: * Dave Airlie wrote: I get the feeling the drm can just be a virtual platform device of some sort, then it reads the device tree and binds all the information on

Re: [PATCH 3/7] DRM: add sdrm layer for general embedded system support

2012-04-21 Thread Sascha Hauer
On Fri, Apr 20, 2012 at 03:33:14PM +0200, Daniel Vetter wrote: On Fri, Apr 20, 2012 at 03:10:05PM +0200, Sascha Hauer wrote: (BTW each driver in drm has this layer somewhere in it. If I had hidden it in imx specific functions I probably wouldn't have raised any questions, but I don't want

[no subject]

2012-05-18 Thread Sascha Hauer
is now devicetree based. For now I took the easy way out and only put an edid blob into the devicetree. I haven't documented the binding yet, I would add that when the rest is considered ok. Comments very welcome. Thanks Sascha Sascha

[PATCH 2/2] pcm038 lcdc support

2012-05-18 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- arch/arm/boot/dts/imx27-phytec-phycore.dts | 39 arch/arm/boot/dts/imx27.dtsi |7 + arch/arm/mach-imx/clock-imx27.c|1 + 3 files changed, 47 insertions(+) diff --git a/arch

Re: [PATCH 2/2] pcm038 lcdc support

2012-05-18 Thread Sascha Hauer
On Fri, May 18, 2012 at 10:03:54AM -0400, Adam Jackson wrote: On Fri, 2012-05-18 at 14:27 +0200, Sascha Hauer wrote: + edid = [00 ff ff ff ff ff ff 00 4c 2d 6c 03 36 32 49 4b + 0f 13 01 03 80 37 22 a0 2a fe 21 a8 53 37 ae 24

Re: [PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Sascha Hauer
Hi Rob, On Tue, May 22, 2012 at 03:28:20PM -0600, Rob Clark wrote: just a few comments from a cursory review.. I need a bit more time for a more in-depth review but that won't be tonight so I thought I'd send what I have so far.. Thanks for this. +++ b/drivers/gpu/drm/imx/Kconfig @@

Re:

2012-05-23 Thread Sascha Hauer
On Tue, May 22, 2012 at 04:06:41PM +0200, Lars-Peter Clausen wrote: On 05/18/2012 02:27 PM, Sascha Hauer wrote: Hi All, The following adds a drm/kms driver for the Freescale i.MX LCDC controller. Most notable change to the last SDRM based version is that the SDRM layer has been removed

Re:

2012-05-24 Thread Sascha Hauer
On Tue, May 22, 2012 at 04:06:41PM +0200, Lars-Peter Clausen wrote: On 05/18/2012 02:27 PM, Sascha Hauer wrote: Hi All, The following adds a drm/kms driver for the Freescale i.MX LCDC controller. Most notable change to the last SDRM based version is that the SDRM layer has been removed

[PATCH] DRM: add drm gem CMA helper

2012-05-29 Thread Sascha Hauer
Many embedded drm devices do not have a IOMMU and no dedicated memory for graphics. These devices use CMA (Contiguous Memory Allocator) backed graphics memory. This patch provides helper functions to be able to share the code. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- Lars-Peter

Re: [PATCH] DRM: add drm gem CMA helper

2012-05-29 Thread Sascha Hauer
Hi Lars, Thanks for your quick comments. On Tue, May 29, 2012 at 04:46:36PM +0200, Lars-Peter Clausen wrote: On 05/29/2012 04:10 PM, Sascha Hauer wrote: diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index e354bc0..f62717e 100644 --- a/drivers/gpu/drm/Kconfig +++ b

Re: [PATCH 1/2] DRM: Add DRM kms/fb cma helper

2012-05-30 Thread Sascha Hauer
On Tue, May 29, 2012 at 08:20:35PM +0200, Lars-Peter Clausen wrote: This patchset introduces a set of helper function for implementing the KMS framebuffer layer for drivers which use the drm gem CMA helper function. I just integrated this into my series. Works great, thanks. Would be great to

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-05-30 Thread Sascha Hauer
Hi Laurent, On Wed, May 30, 2012 at 02:32:59PM +0200, Laurent Pinchart wrote: The SH Mobile LCD controller (LCDC) DRM driver supports the main graphics plane in RGB and YUV formats, as well as the overlay planes (in alpha-blending mode only). Only flat panel outputs using the parallel

Re: [PATCH] DRM: add drm gem CMA helper

2012-05-30 Thread Sascha Hauer
On Wed, May 30, 2012 at 05:40:13PM +0200, Laurent Pinchart wrote: Hi Sascha, Thank you for the patch. I've successfully tested the helper with the new SH Mobile DRM driver. Just a couple of comments below in addition to Lars' comments (this is not a full review, just details that caught my

Re: [PATCH 4/4] drm: Renesas SH Mobile DRM driver

2012-05-30 Thread Sascha Hauer
On Wed, May 30, 2012 at 02:32:59PM +0200, Laurent Pinchart wrote: The SH Mobile LCD controller (LCDC) DRM driver supports the main graphics plane in RGB and YUV formats, as well as the overlay planes (in alpha-blending mode only). Only flat panel outputs using the parallel interface are

[PATCH v2] DRM: add drm gem cma helper

2012-05-31 Thread Sascha Hauer
Many embedded drm devices do not have a IOMMU and no dedicated memory for graphics. These devices use cma (Contiguous Memory Allocator) backed graphics memory. This patch provides helper functions to be able to share the code. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- changes since

Re: [PATCH v2] DRM: Add DRM kms/fb cma helper

2012-05-31 Thread Sascha Hauer
On Wed, May 30, 2012 at 05:30:15PM +0200, Lars-Peter Clausen wrote: This patch introduces a set of helper function for implementing the KMS framebuffer layer for drivers which use the drm gem CMA helper function. Signed-off-by: Lars-Peter Clausen l...@metafoo.de --- Changes since v1:

Re: [PATCH v2] DRM: Add DRM kms/fb cma helper

2012-05-31 Thread Sascha Hauer
On Thu, May 31, 2012 at 11:34:37AM +0200, Lars-Peter Clausen wrote: + drm_helper_mode_fill_fb_struct(fb_cma-fb, mode_cmd); + + for (i = 0; i num_planes; i++) + fb_cma-obj[i] = obj[i]; Check for valid num_planes before this loop? Hm, I think the callers already take

Re: [PATCH v2] DRM: add drm gem cma helper

2012-06-05 Thread Sascha Hauer
On Thu, May 31, 2012 at 11:36:15AM +0200, Laurent Pinchart wrote: Hi Sascha, + depends on DRM + help + Choose this if you need the GEM cma helper functions I would put CMA in uppercase, but that's just nitpicking. BTW this helper is not strictly dedicated to CMA. It uses the

Re: [PATCH v2] DRM: add drm gem cma helper

2012-06-05 Thread Sascha Hauer
On Fri, Jun 01, 2012 at 12:29:47AM +0900, InKi Dae wrote: Hi Sascha, +struct drm_gem_cma_object *drm_gem_cma_create(struct drm_device *drm, +             unsigned int size) +{ +     struct drm_gem_cma_object *cma_obj; +     struct drm_gem_object *gem_obj; +     int ret; + +    

Re: [PATCH v2] DRM: add drm gem cma helper

2012-06-06 Thread Sascha Hauer
On Tue, Jun 05, 2012 at 10:54:10PM +0900, InKi Dae wrote: 2012/6/5 Sascha Hauer s.ha...@pengutronix.de: On Fri, Jun 01, 2012 at 12:29:47AM +0900, InKi Dae wrote: Hi Sascha, +struct drm_gem_cma_object *drm_gem_cma_create(struct drm_device *drm, +             unsigned int size

[RFC] i.MX DRM devicetree binding

2012-06-14 Thread Sascha Hauer
. Comments and suggestions welcome. Sascha 8-- DRM i.MX: Add devicetree binding documentation Signed-off-by: Philipp Zabel p.za...@pengutronix.de Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- .../devicetree/bindings/drm/fsl-imx-drm.txt| 126

[PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-14 Thread Sascha Hauer
Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/gpu/drm/imx/Kconfig|4 + drivers/gpu/drm/imx/Makefile |1 + drivers/gpu/drm/imx/imx-parallel-display.c | 255 3 files changed, 260 insertions(+) create mode 100644

  1   2   3   4   5   6   7   8   9   >