uce fault, page_mkwrite, and pfn_mkwrite to take
> only vmf")
> Signed-off-by: Arnd Bergmann <a...@arndb.de>
Acked-By: Sebastian Reichel <s...@kernel.org>
-- Sebastian
signature.asc
Description: PGP signature
___
dri-devel mail
Hi Tony,
On Tue, Jun 21, 2016 at 04:01:03AM -0700, Tony Lindgren wrote:
> * Tony Lindgren [160412 13:53]:
> > * Sebastian Reichel [160324 17:16]:
> > > On Thu, Mar 24, 2016 at 05:11:15PM +0200, Jani Nikula wrote:
> > > > > I _think_, that your H
Hi,
On Wed, Dec 14, 2016 at 11:14:32AM +0200, Tomi Valkeinen wrote:
> On 14/12/16 11:10, Laurent Pinchart wrote:
> > Hi Tomi,
> >
> > On Wednesday 14 Dec 2016 10:43:18 Tomi Valkeinen wrote:
> >> On 13/12/16 19:35, Laurent Pinchart wrote:
> >>> On Tues
The N950's display requires two regulators.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 57 +++--
1 file changed, 53 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c
b/drivers/gpu/drm
The FIFO thresholds must be configured by omapdrm for
manually updated DSI panels due to a hardware bug.
Signed-off-By: Sebastian Reichel
---
include/video/omapdss.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/include/video/omapdss.h b/include/video/omapdss.h
index 9bde65b79220
Use threaded irq handler for the tearing effect gpio,
since it updates the display content, which requires
too much time for a fastpath irq.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
Save the framedone callback supplied by dss for later
usage.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
b/drivers/gpu/drm/omapdrm/omap_crtc.c
index
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
b/drivers/gpu/drm/omapdrm/omap_crtc.c
index 5ef27664bcfa..78ef9773cca1 100644
--- a/drivers/gpu/drm/omapdrm/omap_crtc.c
+++ b
This is a workaround for a hardware bug occuring
on OMAP3 with manually updated panels.
Signed-off-By: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.h | 1 +
drivers/gpu/drm/omapdrm/omap_plane.c | 23 +++
2 files changed, 24 insertions(+)
diff --git a/drivers
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 31 ++-
drivers/gpu/drm/omapdrm/omap_drv.h | 1 +
2 files changed, 31 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
b/drivers/gpu/drm/omapdrm/omap_crtc.c
Signed-off-By: Sebastian Reichel
---
arch/arm/boot/dts/omap3-n950.dts | 71
1 file changed, 71 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n950.dts b/arch/arm/boot/dts/omap3-n950.dts
index 0885b34d5d7d..41b8fb585272 100644
--- a/arch/arm/boot/dts
Updating the plane may interrupt ongoing display
updates, so wait for any pending operations.
Signed-off-By: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
b/drivers/gpu/drm/omapdrm/omap_drv.c
Add regulator configuration as found in the
board files of Nokia's kernel.
Signed-off-By: Sebastian Reichel
---
arch/arm/boot/dts/omap3-n950-n9.dtsi | 72
1 file changed, 72 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-n950-n9.dtsi
b/arch/arm/boot
Having the pending variable available as atomic bit helps
with the later addition of manually updated display support.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 31 +--
1 file changed, 17 insertions(+), 14 deletions(-)
diff --git
Hi,
On Tue, Mar 08, 2016 at 08:39:08PM +0200, Aaro Koskinen wrote:
> On Tue, Mar 08, 2016 at 05:39:32PM +0100, Sebastian Reichel wrote:
> > This series adds support for the Nokia N950 display.
> > Since the panel is using DSI command mode, it involves
> > adding support
From: Tomi Valkeinen <tomi.valkei...@ti.com>
The Nokia N950's bootloader leaves the DSI module
in a non-working state. Work around this by resetting
the DSI module before using it.
Signed-off-By: Tomi Valkeinen
Reviewed-By: Sebastian Reichel
Tested-By: Sebastian Reichel
---
drivers/g
This sets proper connector type for DSI connected panels.
Signed-off-By: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c
b/drivers/gpu/drm/omapdrm/omap_drv.c
index dfafdb602ad2..a3ff35f5f6cd
The Nokia N950 contains a panel, that is partially
covered, so that not the whole display is visible.
Thus the image must be displayed with an offset.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 21 -
1 file changed, 16 insertions
Generating debug messages during display update results
in lot's of messages, if the display shows the console.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm
DSI hardware IPs seem to be a bit unhappy about
incomplete image transfers, so try to wait for
an update to finish before disabling the panel.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 18 ++
1 file changed, 18 insertions(+)
diff
Introduce a new dss method for reading the stallmode
status from the private lcd config structure.
Signed-off-By: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/dss/output.c | 6 ++
include/video/omapdss.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/drivers/gpu/drm
Provide omapdrm with methods to acquire timings
and check them later, so that it can properly
initialize the display.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 38 +
1 file changed, 38 insertions(+)
diff --git a/drivers/gpu
This reverts commit 5a35876e2830511cb8110667fc426c6a6165a593.
Revert the removal of manual update display support in
preparation for DSI command mode panels.
Signed-off-By: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_connector.c | 12 +++
drivers/gpu/drm/omapdrm/omap_drv.h
Introduce new DT properties, so that it's possible
to use different panels with the driver.
* resolution-x (default: 864)
* resolution-y (default: 480)
* has-dsi-backlight (default: no backlight)
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 17
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_connector.c | 12
drivers/gpu/drm/omapdrm/omap_drv.h | 2 --
drivers/gpu/drm/omapdrm/omap_fb.c| 2 +-
3 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 91 +++--
drivers/gpu/drm/omapdrm/omap_drv.h | 2 +
2 files changed, 90 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
b/drivers/gpu/drm/omapdrm
Due to a hardware bug, FIFOs thresholds must be
configured very carefully for manually updated
displays.
Signed-off-by: Sebastian Reichel
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
b/drivers/gpu/drm
Sebastian Reichel (22):
ARM: dts: n9/n950: regulator configuration
ARM: dts: n950: add display support
drm: omapdrm: add DSI mapping
Revert "drm: omapdrm: Remove manual update display support"
drm: omapdrm: wait for pending operations before updating plane
drm: omapdrm: cr
Hi,
On Wed, Mar 09, 2016 at 09:10:28AM +0200, Tomi Valkeinen wrote:
> Hmm there's only so called DMA rotation, which shouldn't work. It's only
> meant for really small displays, when the framebuffer is in SRAM. So I'm
> a bit baffled as to what rotation you are using and why is it working =).
>
>
Hi Emil,
On Wed, Mar 09, 2016 at 04:19:48PM +, Emil Velikov wrote:
> Hi Sebastian,
>
> On 8 March 2016 at 16:39, Sebastian Reichel wrote:
>
> > arch/arm/boot/dts/omap3-n950-n9.dtsi| 72 +
> > arch/arm/boot/dts/omap3-n950.dts
Hi Laurent,
On Thu, Mar 17, 2016 at 02:14:26PM +0200, Laurent Pinchart wrote:
> [...]
> > +
> > + /* panel is 480x464 with top and bottom 5 lines not visible */
>
> I assume you mean 480x864 ?
Yes, nice catch. Basically the screen is 480x864, but only
480x854 are visible.
> > +
Hi,
On Wed, Mar 23, 2016 at 02:40:53PM +0200, Jani Nikula wrote:
> On Thu, 17 Mar 2016, Sebastian Reichel wrote:
> > On Thu, Mar 17, 2016 at 02:14:26PM +0200, Laurent Pinchart wrote:
> >> [...]
> >> > +
> >> > +/* panel is 480x464 with
Hi,
On Thu, Mar 24, 2016 at 12:03:01PM +0200, Jani Nikula wrote:
> On Wed, 23 Mar 2016, Sebastian Reichel wrote:
> > On Wed, Mar 23, 2016 at 02:40:53PM +0200, Jani Nikula wrote:
> >> On Thu, 17 Mar 2016, Sebastian Reichel wrote:
> >> > On Thu, Mar 17, 2016 at 02:1
Hi,
On Thu, Mar 24, 2016 at 05:11:15PM +0200, Jani Nikula wrote:
> On Thu, 24 Mar 2016, Sebastian Reichel wrote:
> > As I said: I did use 864 initially. That results in missing pixels.
>
> Sorry, I didn't mean to question this. Go with what works, not with some
> ol
Hi Laurent,
On Sat, Mar 26, 2016 at 11:20:00AM +0200, Laurent Pinchart wrote:
> On Tuesday 08 Mar 2016 17:39:38 Sebastian Reichel wrote:
> > Updating the plane may interrupt ongoing display
> > updates, so wait for any pending operations.
>
> There's already an omap_atomi
On Fri, Feb 28, 2014 at 06:12:23PM +0200, Tomi Valkeinen wrote:
> On 28/02/14 17:59, Russell King - ARM Linux wrote:
>
> >> +dvi0: connector at 0 {
> >> + compatible = "dvi-connector";
> >> + label = "dvi";
> >> +
> >> + i2c-bus = <>;
> >> +
> >> + dvi_connector_in: endpoint {
> >> +
Hi,
On Fri, Oct 09, 2015 at 02:27:42PM -0700, Eric Anholt wrote:
> VC4 is the GPU (display and 3D) subsystem present on the 2835 and some
> other Broadcom SoCs.
>
> This binding follows the model of msm, imx, sti, and others, where
> there is a subsystem node for the whole GPU, with nodes for
From: Tony Lindgren <t...@atomide.com>
With manual mode displays we need to flush the panel manually.
Let's add flushing so we get Tomi's fbtest, kmstest, kmstest --flip,
and X and wayland working.
Signed-off-by: Tony Lindgren <t...@atomide.com>
[On Nokia N950]
Tested-By: Sebastia
Save the framedone callback supplied by dss for later
usage.
Signed-off-by: Sebastian Reichel <s...@kernel.org>
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/omapdrm/omap_crtc.c
b/drivers/gpu/drm/o
igured
values
3. We need to implement minimal get_timings() and check_timings()
for the panel to work
With these changes we get panel-dsi-cm to probe with device tree
configuraion. Note that the dsicm_check_timings adapted from an
earlier patch by Sebastian Reichel <s...@kernel.org>.
This reverts commit 5a35876e2830511cb8110667fc426c6a6165a593.
Revert the removal of manual update display support in
preparation for DSI command mode panels.
Signed-off-By: Sebastian Reichel <s...@kernel.org>
[t...@atomide.com: left out unused omap_framebuffer_dirty]
Signed-off-by: Tony Li
ack.
Signed-off-by: Tony Lindgren <t...@atomide.com>
[Drop REVISIT comment for omap3, patch works on N950]
Signed-off-by: Sebastian Reichel <s...@kernel.org>
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 25 +
drivers/gpu/drm/omapdrm/omap_drv.h | 1 +
drivers/gpu/
Signed-off-by: Sebastian Reichel <s...@kernel.org>
[t...@atomide.com: rebased and fixed up to work with droid 4]
Signed-off-by: Tony Lindgren <t...@atomide.com>
---
drivers/gpu/drm/omapdrm/omap_connector.c | 12 --
drivers/gpu/drm/omapdrm/omap_crtc
Add basic panel support for the Nokia N950. It must be tweaked a
little bit later, since the panel was built into the device
upside-down. Also the first 5 and the last 5 pixels are covered
by plastic.
Signed-off-By: Sebastian Reichel <s...@kernel.org>
---
arch/arm/boot/dts/omap3-n950.dt
This is a workaround for a hardware bug occuring on OMAP3
with manually updated panels. Details about the HW bug are
unknown to me, but without this fix the panel refresh does
not work at all on Nokia N950.
Signed-off-By: Sebastian Reichel <s...@kernel.org>
---
drivers/gpu/drm/omapd
was done by Tony (thanks!)
* lots of patches dropped for now
* rebased to current omapdrm interface
* added OMAP4 support
* misc. cleanup
-- Sebastian
Sebastian Reichel (7):
drm: omapdrm: panel-dsi-cm: add regulator support
Revert "drm: omapdrm: Remove manual update display su
The N950's display requires two regulators.
Signed-off-by: Sebastian Reichel <s...@kernel.org>
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 55 +++--
1 file changed, 52 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dsi-c
Signed-off-by: Sebastian Reichel <s...@kernel.org>
[t...@atomide.com: rebased on event_lock changes]
---
drivers/gpu/drm/omapdrm/dss/omapdss.h| 1 +
drivers/gpu/drm/omapdrm/dss/output.c | 6 ++
drivers/gpu/drm/omapdrm/omap_connector.c | 7 +++
drivers/gpu/drm/o
Add support for regulators used by panels found inside
of the Nokia N950, N9 and Motorola Droid 4.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 57 +++--
1 file changed, 53 insertions
().
This is currently being implemented for the kernel
console and for Xorg. Weston currently does not
implement this and is known not to work on manually
updated displays.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/omap_crtc.c
Add support to load physical size information from DT using
the properties defined by the common panel binding.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 19 +++
1 file changed, 19 inse
From: Tony Lindgren <t...@atomide.com>
This adds support for get_timings() and check_timings()
to get the driver working and properly initializes the
timing information from DT.
Signed-off-by: Tony Lindgren <t...@atomide.com>
Signed-off-by: Sebastian Reichel <sebastian.reic...@
This prepares framedone interrupt handling for
manual display update support.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 48 +
drivers/gpu/drm/omapdrm/omap_drv.h | 2 ++
drivers/g
This is a workaround for a hardware bug occuring on OMAP3
with manually updated panels. Details about the HW bug are
unknown to me, but without this fix the panel refresh does
not work at all on Nokia N950.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/g
In preparation for manually updated display support, such as DSI
command mode panels, this adds a simple helper to see if a connector
is manually updated.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/omap_connector.c | 8
drive
Add basic panel support for the Nokia N950. It must be tweaked a
little bit later, since the panel was built into the device
upside-down. Also the first 5 and the last 5 pixels are covered
by plastic.
Signed-off-By: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
arch/arm/bo
a
smaller screen
I plan to look into these issues once basic support
has been merged.
-- Sebastian
Sebastian Reichel (13):
drm/omap: remove unused function defines
drm/omap: drop incorrect comment
drm/omap: plane: update fifo size on ovl setup
drm/omap: add framedone interrupt support
drm/omap
While physical size information is automatically parsed for EDID
based displays, we need to provide it manually for displays providing
one fixed mode.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/dss/omapdss.h| 2 ++
drivers/gpu/drm/o
instead. This is used by
the Nokia N950.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 91 -
1 file changed, 60 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/displays/pan
The wrappers have been removed in commit 5a35876e2830
(drm: omapdrm: Remove manual update display support)
and will not be reintroduced, since the normal sys
functions properly call the dirty callback.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/g
Use the new descriptor based GPIO API instead of
the legacy one, which results in cleaner code
with less lines of code.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c | 74 +
1 file chang
Remove driver (un)register API defines. They do not even exist
anymore.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h
b/drivers/g
This improves LCD support for the Droid 4.
Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
---
arch/arm/boot/dts/omap4-droid4-xt894.dts | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts
b/arch/arm/bo
Hi,
On Fri, Apr 28, 2017 at 08:08:59AM -0700, Tony Lindgren wrote:
> * Tomi Valkeinen [170428 04:15]:
> > On 14/04/17 13:25, Hans Verkuil wrote:
> > > From: Hans Verkuil
> > >
> > > The CEC pin was always pulled up, making it impossible to use it.
Hi,
On Tue, May 09, 2017 at 03:10:40PM +0300, Tomi Valkeinen wrote:
> On 08/05/17 14:32, Laurent Pinchart wrote:
> > Hello,
> >
> > This patch series is a second, extended version of the code previously
> > posted
> > as "[PATCH/RFC 0/7] Remove the omapdrm device from platform code".
>
> As
been probed yet. However they don't need the
> handle until their connect handler is called.
>
> Move retrieval of the source handle to the connect handler to avoid
> probe deferrals.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Revi
<laurent.pinch...@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
> drivers/gpu/drm/omapdrm/omap_drv.h | 2 +-
> drivers/gpu/drm/omapdrm/omap_gem.c | 7 +++
> 3 files changed,
been probed yet. However they don't need the
> handle until their connect handler is called.
>
> Move retrieval of the source handle to the connect handler to avoid
> probe deferrals.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Revi
$(CONFIG_OMAP2_DSS) += omapdss.o
> +
> # Core DSS files
> -omapdss-y := core.o dss.o dispc.o dispc_coefs.o \
> - pll.o video-pll.o
> +omapdss-y := \
> + base.o \
> + display.o \
> + dss-of.o \
> + output.o \
> + core.o \
> + dss.
Hi,
On Fri, Oct 13, 2017 at 05:59:12PM +0300, Laurent Pinchart wrote:
> No panel is instantiated through platform data anymore, there is no
> need to check for OF node presence.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-
Hi,
On Fri, Oct 13, 2017 at 05:59:09PM +0300, Laurent Pinchart wrote:
> The tvc_of_match variable is never referenced before its definition.
> Remove the forward declaration.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-
Hi,
On Fri, Oct 13, 2017 at 05:59:02PM +0300, Laurent Pinchart wrote:
> The function isn't used outside of its compilation unit, make it static.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reic.
Hi,
On Fri, Oct 13, 2017 at 05:59:06PM +0300, Laurent Pinchart wrote:
> The standard kernel integer types are [us]{8,16,32}. Use them instead of
> the u?int{8,16,32}_t types.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-
d. Remove the
> port_initialized field.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 6 +-
> 1 file changed, 1 insertion(+), 5
Hi,
On Fri, Oct 13, 2017 at 05:59:11PM +0300, Laurent Pinchart wrote:
> No encoder is instantiated through platform data anymore, there is no
> need to check for OF node presence.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-
' is used.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/displays/panel-dsi-cm.c| 8 +-
> .../drm/omapdrm/displays/panel-sony-acx56
Hi,
On Fri, Oct 13, 2017 at 05:58:59PM +0300, Laurent Pinchart wrote:
> The omap_dss_find_device() function is unused. Remove it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co
this should be tagged for stable backporting?
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/venc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c
> b/
been probed yet. However they don't need the
> handle until their connect handler is called.
>
> Move retrieval of the source handle to the connect handler to avoid
> probe deferrals.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Revi
oherent mask for the device.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> ---
> drivers/gpu/drm/omapdrm/dss/dss.c | 7 +++
> 1 file changed, 7 insertions(+)
&g
t; the probe function to make it usable without a platform device.
> Similarly, split the cleanup code from the remove function.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk&g
Hi,
On Fri, Oct 13, 2017 at 05:59:10PM +0300, Laurent Pinchart wrote:
> No connector is instantiated through platform data anymore, there is no
> need to check for OF node presence.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-
alid(gpio) || gpio == -ENOENT) {
> ddata->pd_gpio = gpio;
> } else {
> - dev_err(>dev, "failed to parse PD gpio\n");
> + if (gpio != -EPROBE_DEFER)
> + dev_err(>dev, "failed to parse PD gpi
ts will be
> dynamically allocated instead of stored in global variables.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
(One nit-pick in dss.h, see below)
-- Sebastian
> drive
t;
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dss.c | 13 +++--
> drivers/gpu/drm/omapdrm/dss/dss.h | 2 +-
> drivers/gpu/drm/omapdrm/dss/hdmi_pll.c | 4 ++--
> drivers/gpu/drm/omapdrm
Hi,
On Mon, Oct 16, 2017 at 10:47:32AM +0200, Sebastian Reichel wrote:
> Hi Laurent,
>
> On Fri, Oct 13, 2017 at 05:59:20PM +0300, Laurent Pinchart wrote:
> > This removes the need to access the global DSS private data in those
> > functions (both for the current accesse
DSS private data structure. This will be fixed
> in subsequent steps.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dss.c | 385
>
Hi,
On Fri, Oct 13, 2017 at 05:59:25PM +0300, Laurent Pinchart wrote:
> The function is unused, remove it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
&g
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dispc.c | 2 +-
> drivers/gpu/drm/omapdrm/dss/dss.c | 9 +
> d
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dispc.c | 11 +++
> drivers/gpu/drm/omapdrm/dss/dsi.c | 8 +---
> d
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dispc.c | 8
> drivers/gpu/drm/omapdrm/dss/dpi.c | 14 --
> d
DSS
> private structure will be allocated dynamically.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dsi.c | 7
Hi Laurent,
On Fri, Oct 13, 2017 at 05:59:20PM +0300, Laurent Pinchart wrote:
> This removes the need to access the global DSS private data in those
> functions (both for the current accesses and the future ones that will
> be introduced when allocating the DSS device dynamically).
>
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/dpi.c | 12 ---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 18 +-
> d
Hi,
On Fri, Oct 13, 2017 at 05:59:27PM +0300, Laurent Pinchart wrote:
> The omap_hdmi private data structure is currently stored as a global
> variable. While no platform with multiple HDMI4 encoders currently
> exists nor is planned, this doesn't comply with the kernel device model
> and should
; and should thus be fixed.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/hdmi.h | 2 +
> drivers
MI
> + select OMAP2_DSS
As far as I can see "CONFIG_OMAP2_DSS" no longer exists after the merge,
so this can be dropped.
Otherwise:
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> + select OMAP2_DSS_INIT
> + select VIDEOMODE
Hi Tomi & Laurent,
ping?
-- Sebastian
On Mon, Jul 24, 2017 at 07:32:57PM +0200, Sebastian Reichel wrote:
> Hi,
>
> This adds support for command mode DSI panels to
> omapdrm. I tested the patches on Nokia N950 (omap3)
> and Motorola Droid 4 (omap4). This is basically
>
should thus be fixed.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
> drivers/gpu/drm/omapdrm/dss/venc.c | 425
> -
&g
the bit has reached the expected value, it's easier to return a boolean
> status from the function.
>
> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
-- Sebastian
>
1 - 100 of 642 matches
Mail list logo