[PATCH 04/10] drm/exynos: fixed converting between display mode and timing

2011-11-04 Thread Seung-Woo Kim
missing members are added into converting function between timing and display mode and refresh rate of display mode is calculated by drm mode function. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos

[PATCH 01/10] drm/exynos: added padding to be 64-bit align.

2011-11-04 Thread Seung-Woo Kim
From: Inki Dae inki@samsung.com Signed-off-by: Inki Dae inki@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/drm/exynos_drm.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/exynos_drm.h b/include/drm/exynos_drm.h index

[PATCH 07/10] drm/exynos: restored kernel_fb_list when reiniting fb_helper

2011-11-04 Thread Seung-Woo Kim
From: Joonyoung Shim jy0922.s...@samsung.com during recreating exynos_drm_fbdev as a new display device probes, fb_helper is reinitialized but kernel fb is not changed so kernel_fb_list should be restored after fb_helper is reinitialized. Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com

[PATCH 03/10] drm/exynos: fixed connector flag with hpd and interlace scan for hdmi

2011-11-04 Thread Seung-Woo Kim
hdmi display in exynos supports hotplug event and interlace scan mode Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_connector.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH 09/10] drm/exynos: added crtc dpms for disable crtc

2011-11-04 Thread Seung-Woo Kim
crtc dpms is called as destroying attached fb so dpms off sould be processed. crtc dpms also can be called after crtc is detached from encoder so pipe value of manager is used to find display controller for this case Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Inki Dae inki

[PATCH 05/10] drm/exynos: added manager object to connector

2011-11-04 Thread Seung-Woo Kim
From: Inki Dae inki@samsung.com connector contains some contents for display controller so the connector also should be able to access contoroller through manager. Signed-off-by: Inki Dae inki@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park

[PATCH 10/10] drm/exynos: checked for null pointer

2011-11-04 Thread Seung-Woo Kim
Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_encoder.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm

[PATCH 06/10] drm/exynos: changed exynos_drm_display to exynos_drm_display_ops

2011-11-04 Thread Seung-Woo Kim
From: Inki Dae inki@samsung.com exynos_drm_display has function pointes so exynos_drm_display_ops is better to describe. Signed-off-by: Inki Dae inki@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_connector.c | 29

[PATCH 08/10] drm/exynos: removed meaningless parameter from fbdev update

2011-11-04 Thread Seung-Woo Kim
drm_framebuffer already has width and height so they are meaningless as parameters when updating fb_info. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fbdev.c | 14 +- 1 files

[PATCH 02/10] drm/exynos: added kms poll for handling hpd event

2011-11-04 Thread Seung-Woo Kim
this patch adds kms poll infrastructure to handle hotplug detection event Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_drv.c |5 + drivers/gpu/drm/exynos/exynos_drm_fb.c | 12

[PATCH] drm/exynos: enable hdmi audio feature

2012-03-15 Thread Seung-Woo Kim
://www.spinics.net/lists/dri-devel/msg19939.html Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Joonyoung Shim jy0922.s...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 167 +++ drivers/gpu/drm

[PATCH libdrm] libdrm: update drm/drm_fourcc.h from kernel to add multi plane formats

2012-03-29 Thread Seung-Woo Kim
Multi buffer plane pixel formats are added as like kernel header. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- include/drm/drm_fourcc.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 85facb0

[PATCH] drm: add valid pixel formats for fb

2012-03-30 Thread Seung-Woo Kim
This patch adds multi buffer plane pixel formats into valid pixel format list for fb since they are missed from the list. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Inki Dae inki@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm

[PATCH] drm/exynos: add format list of plane

2012-04-04 Thread Seung-Woo Kim
NV12, NV12M and NV12MT are added to format list of plane to use these formats for hdmi vp layer. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Inki Dae inki@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_plane.c

[PATCH 0/5] various patches related with hdmi of exynos drm

2012-04-24 Thread Seung-Woo Kim
://www.spinics.net/lists/dri-devel/msg21739.html http://www.spinics.net/lists/dri-devel/msg21746.html http://www.spinics.net/lists/dri-devel/msg21734.html Seung-Woo Kim (5): drm/exynos: fixed wrong pageflip finish event for interlace mode drm/exynos: enable dvi mode for dvi monitor drm

[PATCH 2/5] drm/exynos: enable dvi mode for dvi monitor

2012-04-24 Thread Seung-Woo Kim
Hdmi monitor and dvi monitor can be distinguished with edid. This patch enables dvi mode if dvi monitor is connected and does not enable audio feature for dvi mode because dvi has no audio feature. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 1/5] drm/exynos: fixed wrong pageflip finish event for interlace mode

2012-04-24 Thread Seung-Woo Kim
Pageflip finish event for interlace mode has bug on checking top field vsync because of comparing between dma address converted by start coordinates and non-converted dma address. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH 3/5] drm/exynos: add additional display mode for hdmi

2012-04-24 Thread Seung-Woo Kim
1080p@30Hz mode is added to hdmi display mode. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.c | 65 ++ 1 files changed, 65 insertions(+), 0 deletions(-) diff

[PATCH 5/5] drm/exynos: added vp scaling feature for hdmi

2012-04-24 Thread Seung-Woo Kim
This patch adds vp scaling feature for exynos hdmi. Scaling ratio between source and destination is used for width and height. Also meaningless variables to set registers are cleaned. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH] drm/exynos: fixed blending for hdmi graphic layer

2012-05-15 Thread Seung-Woo Kim
Blending for graphic layer 0 of hdmi mixer was not set so video layer cannot be showed if graphic layer 0 is enabled. This patch fixes blending values to support blending between graphic layer 0 and video layer. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park

[PATCH] drm/prime: drop reference on imported dma-buf come from gem

2012-09-27 Thread Seung-Woo Kim
() for imported gem come from its own gem into each drivers having prime_import and prime_export capabilities. With this, only gem ref count is increased if importing gem exported from gem of same driver. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin.park kyungmin.p...@samsung.com

[RESEND][PATCH] drm/prime: drop reference on imported dma-buf come from gem

2012-11-14 Thread Seung-Woo Kim
() for imported gem come from its own gem into each drivers having prime_import and prime_export capabilities. With this, only gem ref count is increased if importing gem exported from gem of same driver. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin.park kyungmin.p...@samsung.com

[PATCH 1/2] drm/exynos: fix flags in dma buf exporting

2012-12-19 Thread Seung-Woo Kim
This patch fixes flags passed to dma buf exporting. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin.park kyungmin.p...@samsung.com --- I found exynos drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch. drivers/gpu/drm/exynos

[PATCH 2/2] drm/omap: fix flags in dma buf exporting

2012-12-19 Thread Seung-Woo Kim
This patch fixes flags passed to dma buf exporting. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Cc: Rob Clark rob.cl...@linaro.org --- I found omap drm also sends wrong flag for dma buf exporting. So I send this based on drm-fixes branch. drivers/staging/omapdrm/omap_gem_dmabuf.c |2

[PATCH] drm/exynos: added validation of edid for vidi connection

2013-01-10 Thread Seung-Woo Kim
If edid of vidi from user is invalid, size calculated from a number of cea extensions can be wrong. So, validation should be checked. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin.park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |6

[PATCH] drm/exynos: fix wrong return check for platform_device_register_simple

2013-04-22 Thread Seung-Woo Kim
platform_device_register_simple() never returns NULL, but IS_ERR_OR_NULL macro is used for checking return value in exynos drm driver. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_drv.c |2

[PATCH] exynos/drm: hdmi: cleanup for hdmi common device registration

2013-04-22 Thread Seung-Woo Kim
The hdmi common device registration function does not need extern definition and for error case and unregister case, exynos_drm_hdmi_pdev should be cleared. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- This commit is based on exynos-drm-next and my previous commit drm/exynos: fix wrong

[PATCH] drm/exynos: added ipp device registration to drm driver

2013-04-22 Thread Seung-Woo Kim
This patch added exynos-drm-ipp platform device registration to the exynos drm driver. When DT is enabled, platform devices need to be registered within the driver code. This patch fits the requirement of both DT and Non DT based drm drivers. Signed-off-by: Seung-Woo Kim sw0312@samsung.com

[RFC][PATCH] drm/prime: fixed to allocate sg table considering contiguous pages

2013-04-26 Thread Seung-Woo Kim
Allocating scatter table with sg_alloc_table() does not consider contiguous pages. Because sg_alloc_table_from_pages() merges contigous pages into a signle scatter entry, this patch fixes to allocate scatter table with it from drm_prime_pages_to_sg(). Signed-off-by: Seung-Woo Kim sw0312

[PATCH 2/4] drm/exynos: fix build warnings from ipp fimc

2013-05-22 Thread Seung-Woo Kim
Becuase of order of headers, there are build warnings and they are fixed with this patch. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos

[PATCH 3/4] drm/exynos: remove unnecessary devm_kfree

2013-05-22 Thread Seung-Woo Kim
devm_kfree does not need for fail case of probe function and for remove function. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 -- drivers/gpu/drm/exynos/exynos_drm_rotator.c |2 -- 2 files changed, 0 insertions(+), 4 deletions

[PATCH 0/4] drm/exynos: code cleanups

2013-05-22 Thread Seung-Woo Kim
Build warnings of ipp fimc is fixed and device pointer usage is simplified as directly using dev variable. devm related fixes are also appiled: meaningless devm_kfree is removed and request_threaded_irq is replaced to devm function. Seung-Woo Kim (4): drm/exynos: cleanup device pointer usages

[PATCH 4/4] drm/exynos: replace request_threaded_irq with devm function

2013-05-22 Thread Seung-Woo Kim
devm_request_threaded_irq is used instead of request_threaded_irq and free_irq is removed. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c|8 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c |8 ++-- drivers/gpu/drm/exynos

[PATCH 1/4] drm/exynos: cleanup device pointer usages

2013-05-22 Thread Seung-Woo Kim
Struct device pointer got from platform device pointer is already alsigned as variable, but some functions do not use device pointer. So this patch replaces thoes usages. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +- drivers/gpu/drm

[PATCH] drm/exynos: fix checks for valid mixer window

2013-05-27 Thread Seung-Woo Kim
...@samsung.com Signed-off-by: Hyunhee Kim hyunhee@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c |4 ++-- drivers/gpu/drm/exynos/exynos_mixer.c|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers

[RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Seung-Woo Kim
importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf: add importer private data to attachment drm/prime: find gem object from the reimported dma-buf drivers/base/dma-buf.c | 31

[RFC][PATCH 2/2] drm/prime: find gem object from the reimported dma-buf

2013-05-31 Thread Seung-Woo Kim
be used at reimport time if it is assigned with drm gem object at first import. This can also remove remapping dma address for the hardware having its own iommu. Signed-off-by: Seung-Woo Kim sw0312@samsung.com --- drivers/gpu/drm/drm_prime.c| 19 ++- drivers/gpu

[RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-05-31 Thread Seung-Woo Kim
-by: Seung-Woo Kim sw0312@samsung.com --- drivers/base/dma-buf.c | 31 +++ include/linux/dma-buf.h |4 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 08fe897..a1eaaf2 100644

[PATCH] drm/exynos: remove ignoring return value warning in hdmi

2013-06-04 Thread Seung-Woo Kim
The definition of regulator_bulk_enable is fixed with __must_check and this causes following build warning. warning: ignoring return value of 'regulator_bulk_enable', declared with attribute warn_unused_result This patch fixes to check return value of the function. Signed-off-by: Seung-Woo Kim

[PATCH 0/2] drm/exynos: clean up logs for next tree

2013-06-05 Thread Seung-Woo Kim
This patch set removes tracking logs and function name duplications. This is for the next tree and based on exynos-drm-next branch. YoungJun Cho (2): drm/exynos: Remove tracking log functions drm/exynos: Clean up logs for DRM_ERROR / DRM_DEBUG_KMS drivers/gpu/drm/exynos/exynos_drm_buf.c

[PATCH 2/2] drm/exynos: Clean up logs for DRM_ERROR / DRM_DEBUG_KMS

2013-06-05 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com This patch cleans up logs for DRM_ERROR / DRM_DEBUG_KMS to avoid logging duplicated function name because the macros already contain __func__. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com

[PATCH] drm/prime: fix to check return of dma_map_sg in prime helper

2013-06-24 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com The dma_map_sg(), in map_dma_buf callback operation of prime helper, can return 0 when it fails to map, so it needs to release related resources. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed

[PATCH] drm/prime: replace NULL with error value in drm_prime_pages_to_sg

2013-06-24 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com Instead of NULL, error value is casted with ERR_PTR() for drm_prime_pages_to_sg() and IS_ERR_OR_NULL() macro is replaced with IS_ERR() macro for drm_gem_map_dma_buf(). Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312

[PATCH 0/3] fix error routine of exporting dma_buf

2013-06-25 Thread Seung-Woo Kim
During exporting dma_buf, it can fail after dma_buf is exported. In this case, exported dma_buf should be release with putting. Also dma_buf_fd can be failed to get fd, but failure cases are not handled. Error handling routine is not quite clean, so I send this patch set as RFC. Seung-Woo Kim (1

[PATCH 1/3] drm/prime: fix to put an exported dma_buf for adding handle failure

2013-06-25 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com When drm_prime_add_buf_handle() returns failure for an exported dma_buf, the dma_buf was already allocated and its refcount was increased, so it needs to be put. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312

[PATCH 2/3] drm/prime: reorder drm_prime_add_buf_handle and remove prototype

2013-06-25 Thread Seung-Woo Kim
Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_prime.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff --git

[PATCH 3/3] drm/prime: add return check for dma_buf_fd

2013-06-25 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com The dma_buf_fd() can return error when it fails to prepare fd, so the dma_buf needs to be put. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com

[PATCH] drm/gem: fix not to assign error value to gem name

2013-06-25 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com If idr_alloc() is failed, obj-name can be error value. Also it cleans up duplicated flink processing code. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH] drm/gem: add mutex lock when using drm_gem_mmap_obj

2013-06-25 Thread Seung-Woo Kim
yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com CC: Rob Clark robdcl...@gmail.com --- This patch is based on drm-next branch. drivers/gpu/drm/drm_gem.c

[PATCH v2] drm/gem: add mutex lock when using drm_gem_mmap_obj

2013-06-26 Thread Seung-Woo Kim
Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com CC: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com CC: Rob Clark robdcl...@gmail.com --- This patch is based on drm-next branch. Changes since v1: - Use

[PATCH v2] drm/gem: fix not to assign error value to gem name

2013-06-26 Thread Seung-Woo Kim
2013 -0800 drm: convert to idr_alloc() Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change since v1: - Add a regression commit information in commit msg as Chris commented

[PATCH] drm/exynos: fix not to remain exynos_gem_obj as a leak

2013-06-30 Thread Seung-Woo Kim
-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_gem.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[PATCH 1/2] drm/exynos: remove dead code in vidi_power_on

2013-06-30 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com The type of input parameter enable is bool, so it does not need to check whether true or false. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_vidi.c |3 ---

[PATCH 2/2] drm/exynos: initialize the buf_num in vp_video_buffer

2013-06-30 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com The buf_num in vp_video_buffer() should be 1 or 2, but it is not initialized, and only set to 2 in NV12M or NV12MT cases. So this patch initializes the buf_num with 1 as default. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim

[PATCH] drm/exynos: add error check routine in exynos_drm_open

2013-07-01 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com When the exynos_drm_subdrv_open() returns error, the file_priv should be released and file-driver_priv set to NULL. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH 0/3] drm: minor cleanups

2013-07-01 Thread Seung-Woo Kim
This patch series fixes minor code issues including wrong trace point foramts, meaningless null checking, and possible resource leak in error cases. This is based drm-next branch. Seung-Woo Kim (2): drm: fix print format of sequence in trace point drm: move edid null check to the first part

[PATCH 1/3] drm: fix print format of sequence in trace point

2013-07-01 Thread Seung-Woo Kim
seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_trace.h |6 +++--- 1 files changed, 3

[PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

2013-07-01 Thread Seung-Woo Kim
If raw_edid is null, it will crash, so checking in bad label is meaningless. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_edid.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git

[PATCH 3/3] drm: fix error routines in drm_open_helper

2013-07-01 Thread Seung-Woo Kim
allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_fops.c | 17

Re: [PATCH 1/3] drm: fix print format of sequence in trace point

2013-07-01 Thread Seung-Woo Kim
Hello Chris, Thank you for reviewing. On 2013년 07월 01일 19:23, Chris Wilson wrote: On Mon, Jul 01, 2013 at 07:06:31PM +0900, Seung-Woo Kim wrote: seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u even the format can be not used. I don't understand

[PATCH v2 1/3] drm: fix print format of sequence in trace point

2013-07-01 Thread Seung-Woo Kim
seq of a trace point is unsigned int but print format was %d. So it fixes the format as %u. Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change from v1 - remove wrong commit messageas Chris commented drivers/gpu/drm/drm_trace.h

[PATCH v2 3/3] drm: fix error routines in drm_open_helper

2013-07-01 Thread Seung-Woo Kim
allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change from v1 - replace error value for failure

Re: [PATCH v2 3/3] drm: fix error routines in drm_open_helper

2013-07-01 Thread Seung-Woo Kim
Hello Chris, On 2013년 07월 01일 19:57, Chris Wilson wrote: On Mon, Jul 01, 2013 at 07:49:10PM +0900, Seung-Woo Kim wrote: + +out_close: +if (dev-driver-postclose) +dev-driver-postclose(dev, priv); +out_free: kfree(priv); filp-private_data = NULL; return ret

Re: [PATCH 2/3] drm: move edid null check to the first part of drm_edid_block_valid

2013-07-01 Thread Seung-Woo Kim
Hi Daniel, On 2013년 07월 01일 23:56, Daniel Vetter wrote: On Mon, Jul 1, 2013 at 12:21 PM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, Jul 01, 2013 at 07:06:32PM +0900, Seung-Woo Kim wrote: If raw_edid is null, it will crash, so checking in bad label is meaningless. It would

[PATCH v3 3/3] drm: fix error routines in drm_open_helper

2013-07-01 Thread Seung-Woo Kim
() should be called when error happens after their pair functions are called. If an error occurs after executing dev-driver-open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo

[PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

2013-07-01 Thread Seung-Woo Kim
If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim sw0312

[PATCH v4 3/3] drm: fix error routines in drm_open_helper

2013-07-01 Thread Seung-Woo Kim
() should be called when error happens after their pair functions are called. If an error occurs after executing dev-driver-open() which allocates driver specific per-file private data, then the private data should be released. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo

Re: [PATCH v2 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

2013-07-02 Thread Seung-Woo Kim
Hello Ville, Thanks for comment. On 2013년 07월 02일 17:29, Ville Syrjälä wrote: On Tue, Jul 02, 2013 at 09:52:02AM +0900, Seung-Woo Kim wrote: If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top

[PATCH v3 2/3] drm: add assertion for checking null edid to drm_edid_block_valid

2013-07-02 Thread Seung-Woo Kim
If raw_edid of drm_edid_block_vaild() is null, it will crash, so checking in bad label is removed and instead assertion is added at the top of the function. The type of return for the function is bool, so it fixes to return true and false instead of 1 and 0. Signed-off-by: Seung-Woo Kim sw0312

[PATCH] drm/exynos: fix pages allocation in lowlevel_buffer_allocate

2013-07-02 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com When drm iommu is not supported, buf-pages has to be allocated and assigned to phys_to_page() result, which type is struct page *. So it is sufficient to allocate buf-pages with multiple struct page pointer size. Signed-off-by: YoungJun Cho

[PATCH v2 2/3] drm/exynos: fix pages allocation size in lowlevel_buffer_allocate

2013-07-03 Thread Seung-Woo Kim
@samsung.com Signed-off-by: Seung-Woo Kim sw0312@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- change from v1: - adds precedence patch to fix allocation of array as Ville and Inki commented drivers/gpu/drm/exynos/exynos_drm_buf.c |2 +- 1 files changed, 1

[PATCH 1/3] drm/exynos: use drm_calloc_large when allocates pointer array

2013-07-03 Thread Seung-Woo Kim
From: YoungJun Cho yj44@samsung.com If the type of object is pointer array, the drm_calloc_large() is more suitable than kzalloc() for its allocation function. And uses drm_free_large() instead of kfree() also. Signed-off-by: YoungJun Cho yj44@samsung.com Signed-off-by: Seung-Woo Kim

[PATCH 3/3] drm/exynos: remove duplicated error routine and unnecessary assign

2013-07-03 Thread Seung-Woo Kim
There were duplicated error handling routines during allocating pages in lowlevel_buffer_allocate() and g2d_userptr_get_dma_addr(). Also unnecessary NULL assignments for variable used not any more are removed from g2d_userptr_get_dma_addr() and g2d_userptr_put_dma_addr(). Signed-off-by: Seung-Woo

Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock with pmu reg control

2013-07-30 Thread Seung-Woo Kim
mailto:disc...@lists.ozlabs.org; DRI mailing list; Kukjin Kim; Seung-Woo Kim; Sean Paul; sunil joshi; Kishon Vijay Abraham I; Stephen Warren; grant.lik...@linaro.org mailto:grant.lik...@linaro.org Subject: Re: [RFC 0/2] exynos5250/hdmi: replace dummy hdmiphy clock

[PATCH libdrm] libkms/exynos: fix memory leak in error path

2016-11-14 Thread Seung-Woo Kim
This patch fixes memory leak in error path of exynos_bo_create(). Signed-off-by: Seung-Woo Kim --- libkms/exynos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libkms/exynos.c b/libkms/exynos.c index 5de2e5a..0e97fb5 100644 --- a/libkms/exynos.c +++ b/libkms

[RESEND][PATCH] libkms/exynos: fix memory leak in error path

2016-12-14 Thread Seung-Woo Kim
This patch fixes memory leak in error path of exynos_bo_create(). Signed-off-by: Seung-Woo Kim --- libkms/exynos.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/libkms/exynos.c b/libkms/exynos.c index 5de2e5a..0e97fb5 100644 --- a/libkms/exynos.c +++ b/libkms

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-29 Thread Seung-Woo Kim
uired for drm fimc and drm gsc. Best Regards, - Seung-Woo Kim > > drivers/gpu/drm/exynos/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > -- Seung-Woo Kim Samsung Software R Center --

[PATCH 0/3] drm/exynos: Kconfig dependency fixes

2016-03-29 Thread Seung-Woo Kim
Hello Javier, On 2016년 03월 29일 11:41, Javier Martinez Canillas wrote: > Hello Seung-Woo, > > Thanks a lot for your feedback. > > On 03/28/2016 09:46 PM, Seung-Woo Kim wrote: >> Hi Javier, >> >> On 2016년 03월 29일 10:28, Javier Martin

[Linaro-mm-sig] [PATCH] dma-buf: add meta data attachment

2014-03-25 Thread Seung-Woo Kim
+ INIT_LIST_HEAD(>metas); >>>> >>> I am not sure I understand the relationship of 'meta data' with >>> 'dma-buf', or 'attachments' - do you mean to have a list of some >>> meta-data that is unrelated to the attachments to the dma-buf? I think >

[PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY

2014-05-07 Thread Seung-Woo Kim
t = 0; > + dma_addr = win_data->dma_addr; Basically, you are right and source offset register can be used. But because of limitation of resolution for mixer up to 1920x1080, I considered modified soruce dma address to set one frame buffer, which is bigger than 1920x1080, on to both fimd and hdmi.

[PATCH 2/4] drm/exynos/mixer: use MXR_GRP_SXY_SY

2014-05-08 Thread Seung-Woo Kim
Hello Daniel, On 2014? 05? 07? 23:14, Daniel Kurtz wrote: > On Wed, May 7, 2014 at 1:14 PM, Seung-Woo Kim > wrote: >> Hi Daniel, >> >> On 2014? 05? 05? 00:26, Daniel Kurtz wrote: >>> Mixer hardware supports offsetting dma from start of source buffer u

[PATCH] drm/exynos: hdmi: remove unnecessary dedicated i2c drivers

2014-05-09 Thread Seung-Woo Kim
The i2c drivers for ddc and hdmiphy are already removed from build and instead, i2c clients registered via devicetree are used. So this patch removes the unnecessary i2c drivers. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_ddc.c | 63

[PATCH] drm/exynos: hdmi: add null check for hdmiphy_port

2014-07-28 Thread Seung-Woo Kim
The hdmiphy can be apb and hdmiphy_port can be null. So before accessing hdmiphy_port, it should be checked. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_hdmi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b

[PATCH 2/2] drm/exynos: Fix build after removal of DRM_WAKUP

2014-01-08 Thread Seung-Woo Kim
Yes, at least for exynos-drm-next tree of Inki. Inki sent pull request including my patch yesterday. Best Regards, - Seung-Woo Kim

[PATCH] drm/exynos: enable hdmi audio feature

2012-03-16 Thread Seung-Woo Kim
http://www.spinics.net/lists/dri-devel/msg19939.html Signed-off-by: Seung-Woo Kim Signed-off-by: Joonyoung Shim Signed-off-by: Kyungmin Park --- drivers/gpu/drm/exynos/exynos_hdmi.c | 167 +++ drivers/gpu/drm/exynos/regs-hdmi.h | 182 +++

[PATCH libdrm] libdrm: update drm/drm_fourcc.h from kernel to add multi plane formats

2012-03-30 Thread Seung-Woo Kim
Multi buffer plane pixel formats are added as like kernel header. Signed-off-by: Seung-Woo Kim --- include/drm/drm_fourcc.h |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h index 85facb0..7cfd95a 100644

[PATCH] drm: add valid pixel formats for fb

2012-03-30 Thread Seung-Woo Kim
This patch adds multi buffer plane pixel formats into valid pixel format list for fb since they are missed from the list. Signed-off-by: Seung-Woo Kim Signed-off-by: Inki Dae Signed-off-by: Kyungmin Park --- drivers/gpu/drm/drm_crtc.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions

[PATCH] drm/exynos: fixed blending for hdmi graphic layer

2012-05-15 Thread Seung-Woo Kim
Blending for graphic layer 0 of hdmi mixer was not set so video layer cannot be showed if graphic layer 0 is enabled. This patch fixes blending values to support blending between graphic layer 0 and video layer. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin Park --- This patch is based

[RESEND][PATCH] drm/prime: drop reference on imported dma-buf come from gem

2012-11-15 Thread Seung-Woo Kim
() for imported gem come from its own gem into each drivers having prime_import and prime_export capabilities. With this, only gem ref count is increased if importing gem exported from gem of same driver. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin.park Cc: Inki Dae Cc: Daniel Vetter Cc: Rob Clark

[PATCH 2/4] drm/exynos: fix build warnings from ipp fimc

2013-05-22 Thread Seung-Woo Kim
Becuase of order of headers, there are build warnings and they are fixed with this patch. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu

[PATCH 3/4] drm/exynos: remove unnecessary devm_kfree

2013-05-22 Thread Seung-Woo Kim
devm_kfree does not need for fail case of probe function and for remove function. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_gsc.c |2 -- drivers/gpu/drm/exynos/exynos_drm_rotator.c |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 0/4] drm/exynos: code cleanups

2013-05-22 Thread Seung-Woo Kim
Build warnings of ipp fimc is fixed and device pointer usage is simplified as directly using dev variable. devm related fixes are also appiled: meaningless devm_kfree is removed and request_threaded_irq is replaced to devm function. Seung-Woo Kim (4): drm/exynos: cleanup device pointer usages

[PATCH 4/4] drm/exynos: replace request_threaded_irq with devm function

2013-05-22 Thread Seung-Woo Kim
devm_request_threaded_irq is used instead of request_threaded_irq and free_irq is removed. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c|8 ++-- drivers/gpu/drm/exynos/exynos_drm_gsc.c |8 ++-- drivers/gpu/drm/exynos/exynos_drm_rotator.c

[PATCH 1/4] drm/exynos: cleanup device pointer usages

2013-05-22 Thread Seung-Woo Kim
Struct device pointer got from platform device pointer is already alsigned as variable, but some functions do not use device pointer. So this patch replaces thoes usages. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_fimc.c |2 +- drivers/gpu/drm/exynos

[PATCH] drm/exynos: fix checks for valid mixer window

2013-05-27 Thread Seung-Woo Kim
lowski Signed-off-by: Hyunhee Kim Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/exynos/exynos_drm_hdmi.c |4 ++-- drivers/gpu/drm/exynos/exynos_mixer.c|2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c b/drivers/gpu/drm/

[RFC][PATCH 0/2] dma-buf: add importer private data for reimporting

2013-05-31 Thread Seung-Woo Kim
importer private data in dma-buf attachment can be used by importer to reimport same dma-buf. Seung-Woo Kim (2): dma-buf: add importer private data to attachment drm/prime: find gem object from the reimported dma-buf drivers/base/dma-buf.c | 31

[RFC][PATCH 2/2] drm/prime: find gem object from the reimported dma-buf

2013-05-31 Thread Seung-Woo Kim
be used at reimport time if it is assigned with drm gem object at first import. This can also remove remapping dma address for the hardware having its own iommu. Signed-off-by: Seung-Woo Kim --- drivers/gpu/drm/drm_prime.c| 19 ++- drivers/gpu/drm/exynos

[RFC][PATCH 1/2] dma-buf: add importer private data to attachment

2013-05-31 Thread Seung-Woo Kim
-by: Seung-Woo Kim --- drivers/base/dma-buf.c | 31 +++ include/linux/dma-buf.h |4 2 files changed, 35 insertions(+), 0 deletions(-) diff --git a/drivers/base/dma-buf.c b/drivers/base/dma-buf.c index 08fe897..a1eaaf2 100644 --- a/drivers/base/dma-buf.c

[PATCH] drm/prime: drop reference on imported dma-buf come from gem

2012-09-27 Thread Seung-Woo Kim
() for imported gem come from its own gem into each drivers having prime_import and prime_export capabilities. With this, only gem ref count is increased if importing gem exported from gem of same driver. Signed-off-by: Seung-Woo Kim Signed-off-by: Kyungmin.park Cc: Inki Dae Cc: Daniel Vetter Cc: Rob Clark

[PATCH] drm/exynos: fix wrong return check for platform_device_register_simple

2013-04-22 Thread Seung-Woo Kim
platform_device_register_simple() never returns NULL, but IS_ERR_OR_NULL macro is used for checking return value in exynos drm driver. Signed-off-by: Seung-Woo Kim --- This patch is based on exynos-drm-next branch. drivers/gpu/drm/exynos/exynos_drm_drv.c |2 +- drivers/gpu/drm/exynos

  1   2   >