Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static const struct of_device_id imx_pd_dt_ids[] = { + { .compatible = fsl,imx-parallel-display, .data = NULL, }, Can we use particular soc name to define the compatible string? Also, the .data initialization seems not needed.

Re: [PATCH 1/5] DRM: Add i.MX drm core support

2012-06-21 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:23PM +0200, Sascha Hauer wrote: ... +struct drm_device *imx_drm_device_get(void) +{ + struct imx_drm_device *imxdrm = __imx_drm_device(); + struct imx_drm_encoder *enc; + struct imx_drm_connector *con; + struct imx_drm_crtc *crtc; + +

Re: [PATCH 3/5] DRM i.MX: Add LCDC support

2012-06-21 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:25PM +0200, Sascha Hauer wrote: ... +#include linux/device.h +#include linux/platform_device.h +#include drm/drmP.h +#include drm/drm_fb_helper.h +#include drm/drm_crtc_helper.h +#include drm/drm_gem_cma_helper.h +#include drm/drm_fb_cma_helper.h +#include

Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Shawn Guo
On Thu, Jun 21, 2012 at 01:35:56PM +0800, Shawn Guo wrote: On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static const struct of_device_id imx_pd_dt_ids[] = { + { .compatible = fsl,imx-parallel-display, .data = NULL, }, Can we use particular soc name to define

Re: [PATCH 2/5] DRM i.MX: Add parallel display support

2012-06-21 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:24PM +0200, Sascha Hauer wrote: +static int __devinit imx_pd_probe(struct platform_device *pdev) +{ + struct device_node *np = pdev-dev.of_node; + const u8 *edidp; + struct imx_parallel_display *imxpd; + int ret; + u32 crtcs[2]; It seems

Re: [PATCH 4/5] DRM: add i.MX IPUv3 base driver

2012-06-22 Thread Shawn Guo
On Thu, Jun 14, 2012 at 03:43:26PM +0200, Sascha Hauer wrote: ... +#include linux/module.h +#include linux/export.h +#include linux/types.h +#include linux/init.h +#include linux/platform_device.h +#include linux/err.h +#include linux/spinlock.h +#include linux/delay.h +#include

Re: [PATCH 6/6] staging: drm/imx: Add TODO

2012-09-18 Thread Shawn Guo
On Wed, Sep 12, 2012 at 12:31:14PM +0200, Sascha Hauer wrote: Signed-off-by: Sascha Hauer s.ha...@pengutronix.de --- drivers/staging/imx-drm/TODO | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 drivers/staging/imx-drm/TODO diff --git

Re: [PATCH 7/7] staging: drm/imx: Add support for Television Encoder (TVEv2)

2013-04-09 Thread Shawn Guo
On Mon, Apr 08, 2013 at 06:04:38PM +0200, Philipp Zabel wrote: This driver adds support for the Television Encoder integrated on i.MX53 SoCs (TVEv2). Currently only the VGA output mode is supported, which only uses the TVDAC to generate RGB levels. HSYNC and VSYNC signals are routed

Re: [PATCH 1/3] ARM: imx6q: refactor some ldb related clocks

2013-08-20 Thread Shawn Guo
On Tue, Aug 20, 2013 at 02:18:27PM -0700, Mike Turquette wrote: Quoting Fabio Estevam (2013-08-20 08:40:52) On Tue, Aug 20, 2013 at 5:38 AM, Liu Ying ying@freescale.com wrote: diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt

Re: [PATCH 0/3] refactor some ldb related clocks

2013-08-20 Thread Shawn Guo
Hi Ying, On Tue, Aug 20, 2013 at 06:08:48PM +0800, Liu Ying wrote: While I admit to having introduced the combination of 1/3.5 fixed divider and configurable 1/1,1/2 divder clocks to describe this fractional divider for the reasons you state, I think the correct solution would be to

[PATCH v3 03/23] drm: unexport function drm_vblank_no_hw_counter()

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The function drm_vblank_no_hw_counter() is now only used in core vblank wrapper code. Let's unexport it by making it a static function. Signed-off-by: Shawn Guo <shawn@linaro.org> --- drivers/gpu/drm/dr

[PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Core code already makes drm_driver.get_vblank_counter hook optional by letting drm_vblank_no_hw_counter be the default implementation for the function hook. So the drm_vblank_no_hw_counter assignment in the driver code becomes redundant and can be r

[PATCH v3 00/23] Add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank is mostly CRTC specific and implemented as part of CRTC driver. The first patch adds 3 vblank core<->driver hooks into struct drm_crtc_funcs, and plug them into core by adding wrapper functions for vblank handling code. We effe

[PATCH v3 01/23] drm: add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank is mostly CRTC specific and implemented as part of CRTC driver. Let's keep the vblank hooks struct drm_driver for legacy drivers, and add corresponding hooks in struct drm_crtc_funcs. These hooks take struct drm_crtc pointer as ar

[PATCH v3 04/23] drm: hdlcd: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Ack

[PATCH v3 23/23] drm: zte: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. The functions are moved around to save forward decla

[PATCH v3 20/23] drm: tegra: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, the wrapper functions tegra_drm_xxx get

[PATCH v3 21/23] drm: tilcdc: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. While at it, the 'return' of .disable_vblank is dropped

[PATCH v3 22/23] drm: vc4: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc:

[PATCH v3 16/23] drm: rcar-du: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org>

[PATCH v3 17/23] drm: rockchip: remove struct rockchip_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain struct rockchip_crtc_funcs and the related registration functions. Remove them. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc: Mark Yao <mark@rock-chips.co

[PATCH v3 14/23] drm: meson: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org&

[PATCH v3 18/23] drm: shmobile: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, shmob_drm_crtc_enable_vblank() becomes a

[PATCH v3 19/23] drm: sun4i: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org>

[PATCH v3 15/23] drm: qxl: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc:

[PATCH v3 13/23] drm: mediatek: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> C

Re: [RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
On Tue, Feb 07, 2017 at 08:32:46AM +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 08:55:35AM +0100, Daniel Vetter wrote: > > On Sun, Jan 22, 2017 at 02:09:01PM +0800, Shawn Guo wrote: > > > From: Shawn Guo <shawn@linaro.org> > > > > &g

[PATCH v3 09/23] drm: fsl-dcu: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc:

[PATCH v3 06/23] drm: armada: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, functions armada_drm_crtc_enable[disabl

[PATCH v3 07/23] drm: atmel: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org&g

[PATCH v3 12/23] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain the CRTC specific vblank callbacks with struct imx_drm_crtc_helper_funcs any more. By moving the stuff that we currently do in imx_drm_add_crtc(), like of_node s

[PATCH v3 11/23] drm: kirin: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc:

[PATCH v3 08/23] drm: exynos: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. As the result, exynos_drm_crtc_enable[disable]_vblank()

[PATCH v3 05/23] drm: malidp: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org>

[PATCH v3 10/23] drm: hibmc: use vblank hooks in struct drm_crtc_funcs

2017-02-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc:

Re: [bug report] drm: zte: add overlay plane support

2017-02-08 Thread Shawn Guo
Hi Dan, Thanks for the report. On Wed, Feb 08, 2017 at 09:39:51AM +0300, Dan Carpenter wrote: > Hello Shawn Guo, > > The patch 4e986d3705df: "drm: zte: add overlay plane support" from > Nov 16, 2016, leads to the following static checker warning: > > driver

Re: [GIT PULL] ZTE DRM driver updates for 4.11

2017-02-03 Thread Shawn Guo
On Wed, Feb 01, 2017 at 08:29:51AM +1000, Dave Airlie wrote: > On 29 January 2017 at 15:41, Shawn Guo <shawn...@kernel.org> wrote: > > Hi Dave, > > > > Please consider to pull the following ZTE DRM driver updates for 4.11. > > Thanks. > > Sorry for delay,

Re: [PATCH 4/5] dt: add bindings for ZTE tvenc device

2017-01-22 Thread Shawn Guo
On Thu, Jan 19, 2017 at 06:11:17PM +0100, Lucas Stach wrote: > Am Freitag, den 20.01.2017, 00:24 +0800 schrieb Shawn Guo: > > From: Shawn Guo <shawn@linaro.org> > > > > It adds bindings doc for ZTE VOU TV Encoder device. > > > > Signed-

Re: [PATCH 5/5] drm: zte: add tvenc driver support

2017-01-26 Thread Shawn Guo
On Mon, Jan 23, 2017 at 11:10:34AM -0500, Sean Paul wrote: > > +static const struct zx_tvenc_mode tvenc_modes[] = { > > + { > > + .name = "PAL", > > + .hdisplay = 720, > > + .vdisplay = 576, > > + .hfp = 12, > > + .hbp = 130, > > + .hsw

[PATCH v2 0/5] Add TV Encoder support for ZTE DRM driver

2017-01-26 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The series updates zx_vou driver a bit as the preparation of adding TVENC output device, and then adds the device driver. Changes for v2: - Save the use of variable 'vactive' by checking interlaced case. - Rename mask variable for scan register to

[PATCH v2 1/5] drm: zte: add interlace mode support

2017-01-26 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds interlace mode support in VOU TIMING_CTRL and channel control block, so that VOU driver gets ready to support output device in interlace mode like TV Encoder. Signed-off-by: Shawn Guo <shawn@linaro.org> --- Changes for v2: -

[PATCH v2 2/5] drm: zte: move struct vou_inf into zx_vou driver

2017-01-26 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Although data in struct vou_inf is defined per output device, it doesn't belong to the device itself but VOU control module. All these data can just be defined in VOU driver, and output device driver only needs to invoke VOU driver function with dev

[PATCH v2 3/5] drm: zte: add function to configure vou_ctrl dividers

2017-01-26 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The clock control module (CRM) cannot always provide desired frequency for all VOU output devices. That's why VOU integrates a few dividers to further divide the clocks from CRM. Let's add an interface for configuring these dividers. Signed-off-by:

[PATCH v2 4/5] dt: add bindings for ZTE tvenc device

2017-01-26 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds bindings doc for ZTE VOU TV Encoder device. Signed-off-by: Shawn Guo <shawn@linaro.org> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/display/zte,vou.txt | 15 +++ 1 file chan

[PATCH v2 5/5] drm: zte: add tvenc driver support

2017-01-26 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds the TV Encoder driver to support video output in PAL and NTSC format. The driver uses syscon/regmap interface to configure register bit sitting in SYSCTRL module for DAC power control. Signed-off-by: Shawn Guo <shawn@linaro.org>

Re: [PATCH 1/5] drm: zte: add interlace mode support

2017-01-25 Thread Shawn Guo
Hi Sean, Thanks for reviewing the patches. On Mon, Jan 23, 2017 at 10:19:01AM -0500, Sean Paul wrote: > On Fri, Jan 20, 2017 at 12:24:56AM +0800, Shawn Guo wrote: > > From: Shawn Guo <shawn@linaro.org> > > > > It adds interlace mode support in VOU TIMING_CTRL an

[RFC PATCH v2 2/5] drm: hdlcd: use vblank hooks in struct drm_crtc_funcs

2017-01-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank hooks in struct drm_driver are deprecated and only meant for legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks in struct drm_crtc_funcs should be used instead. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc:

[RFC PATCH v2 1/5] drm: add vblank hooks to struct drm_crtc_funcs

2017-01-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank is mostly CRTC specific and implemented as part of CRTC driver. Let's keep the vblank hooks struct drm_driver for legacy drivers, and add corresponding hooks in struct drm_crtc_funcs. These hooks take struct drm_crtc pointer as ar

[RFC PATCH v2 5/5] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

2017-01-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain the CRTC specific vblank callbacks with struct imx_drm_crtc_helper_funcs any more. By moving the stuff that we currently do in imx_drm_add_crtc(), like of_node s

[RFC PATCH v2 4/5] drm: rockchip: remove struct rockchip_crtc_funcs

2017-01-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain struct rockchip_crtc_funcs and the related registration functions. Remove them. Signed-off-by: Shawn Guo <shawn@linaro.org> Cc: Mark Yao <mark@rock-chips.co

[RFC PATCH v2 3/5] drm: zte: zx_vou_enable[disable]_vblank can be static

2017-01-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we can directly use the drm_crtc pointer passed in as parameter and make the functions static. The functions are moved around to save forward delarations. Signed-off-by: Shawn Guo <shawn@l

[RFC PATCH v2 0/5] Add vblank hooks to struct drm_crtc_funcs

2017-01-21 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank is mostly CRTC specific and implemented as part of CRTC driver. The first patch adds 3 vblank core-driver hooks into struct drm_crtc_funcs, and wraps around core vblank handling code to use the new hooks for modern MODESET drivers and th

[GIT PULL] ZTE DRM driver updates for 4.11

2017-01-28 Thread Shawn Guo
zx_vou driver a bit and then add TV Encoder output device support. Shawn Guo (10): drm: zte: select VIDEOMODE_HELPERS in Kconfig drm: zte: support hdmi audio through spdif drm: zte: make zx_plane accessible from

[PATCH] drm: zte: fix static checker warning on variable 'fmt'

2017-02-20 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Commit 4e986d3705df ("drm: zte: add overlay plane support") introduces the following static checker warning: drivers/gpu/drm/zte/zx_plane.c:170 zx_vl_rsz_setup() warn: always true condition '(fmt >= 0) => (0-u32max >= 0)' Fi

Re: [PATCH v3 00/23] Add vblank hooks to struct drm_crtc_funcs

2017-02-09 Thread Shawn Guo
On Wed, Feb 08, 2017 at 10:49:57AM -0500, Sean Paul wrote: > On Tue, Feb 07, 2017 at 05:16:12PM +0800, Shawn Guo wrote: > > From: Shawn Guo <shawn@linaro.org> > > > > The vblank is mostly CRTC specific and implemented as part of CRTC > > driver. The first

[PATCH v3 2/3] drm: zte: add initial vou drm driver

2016-10-27 Thread Shawn Guo
> On Thu, Oct 20, 2016 at 3:30 AM, Shawn Guo wrote: > > It adds the initial ZTE VOU display controller DRM driver. There are > > still some features to be added, like overlay plane, scaling, and more > > output devices support. But it's already useful with dual CRTCs

[PATCH v3 2/3] drm: zte: add initial vou drm driver

2016-10-28 Thread Shawn Guo
Hi Gustavo, Thanks for looking at the patch. > 2016-10-20 Shawn Guo : > > > It adds the initial ZTE VOU display controller DRM driver. There are > > still some features to be added, like overlay plane, scaling, and more > > output devices support. But it's alread

[PATCH v4 0/3] Add initial ZTE VOU DRM/KMS driver

2016-10-31 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The series adds the initial ZTE VOU display controller DRM/KMS driver. There are still some features to be added, like overlay plane, scaling, and more output devices support. But it's already useful with dual CRTCs and HDMI display working. Changes

[PATCH v4 1/3] dt-bindings: add bindings doc for ZTE VOU display controller

2016-10-31 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds initial bindings doc for ZTE VOU display controller. HDMI is the only supported output device right now. Signed-off-by: Shawn Guo Acked-by: Rob Herring --- .../devicetree/bindings/display/zte,vou.txt| 84 ++

[PATCH v4 3/3] MAINTAINERS: add an entry for ZTE ZX DRM driver

2016-10-31 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Add myself as the maintainer of ZTE ZX DRM driver. Signed-off-by: Shawn Guo --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1cd38a7e0064..907dbd3261c5 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH v4 2/3] drm: zte: add initial vou drm driver

2016-10-31 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds the initial ZTE VOU display controller DRM driver. There are still some features to be added, like overlay plane, scaling, and more output devices support. But it's already useful with dual CRTCs and HDMI monitor working. Signed-off-by: Sha

[PATCH v2 2/2] drm: zte: add initial vou drm driver

2016-09-30 Thread Shawn Guo
Hi Emil, On Fri, Sep 30, 2016 at 01:34:14PM +0100, Emil Velikov wrote: > Hi Shawn, > > A couple of fly-by suggestions, which I hope you'll find useful :-) Thanks for the suggestions. > On 24 September 2016 at 15:26, Shawn Guo wrote: > > > + > > +

[PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller

2016-10-09 Thread Shawn Guo
On Mon, Oct 03, 2016 at 12:44:29PM -0500, Rob Herring wrote: > > +Example: > > + > > +vou: vou at 144 { > > + compatible = "zte,zx296718-vou"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + reg = <0x144 0x1>; > > + ranges; > > You still have overlapping

[PATCH v3 0/3] Add initial ZTE VOU DRM/KMS driver

2016-10-20 Thread Shawn Guo
improvements like defining macro for sub-module address and changing code to save indentation level - Add a MAINTAINERS entry for ZTE ZX DRM driver Changes for v2: - Change device tree bindings to kill the virtual display-subsystem node make VOU the parent node. Shawn Guo (3): dt-bindings: add

[PATCH v3 1/3] dt-bindings: add bindings doc for ZTE VOU display controller

2016-10-20 Thread Shawn Guo
It adds initial bindings doc for ZTE VOU display controller. HDMI is the only supported output device right now. Signed-off-by: Shawn Guo Acked-by: Rob Herring --- .../devicetree/bindings/display/zte,vou.txt| 84 ++ 1 file changed, 84 insertions(+) create mode

[PATCH v3 2/3] drm: zte: add initial vou drm driver

2016-10-20 Thread Shawn Guo
It adds the initial ZTE VOU display controller DRM driver. There are still some features to be added, like overlay plane, scaling, and more output devices support. But it's already useful with dual CRTCs and HDMI monitor working. Signed-off-by: Shawn Guo --- drivers/gpu/drm/Kconfig

[PATCH v3 3/3] MAINTAINERS: add an entry for ZTE ZX DRM driver

2016-10-20 Thread Shawn Guo
Add myself as the maintainer of ZTE ZX DRM driver. Signed-off-by: Shawn Guo --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1cd38a7e0064..907dbd3261c5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4281,6 +4281,13 @@ S: Maintained

[PATCH v2 0/2] Add initial ZTE VOU DRM/KMS driver

2016-09-24 Thread Shawn Guo
the virtual display-subsystem node make VOU the parent node. Shawn Guo (2): dt-bindings: add bindings doc for ZTE VOU display controller drm: zte: add initial vou drm driver .../devicetree/bindings/display/zte,vou.txt| 86 +++ drivers/gpu/drm/Kconfig

[PATCH v2 1/2] dt-bindings: add bindings doc for ZTE VOU display controller

2016-09-24 Thread Shawn Guo
It adds initial bindings doc for ZTE VOU display controller. HDMI is the only supported output device right now. Signed-off-by: Shawn Guo --- .../devicetree/bindings/display/zte,vou.txt| 86 ++ 1 file changed, 86 insertions(+) create mode 100644 Documentation

[PATCH v2 2/2] drm: zte: add initial vou drm driver

2016-09-24 Thread Shawn Guo
driver. Signed-off-by: Shawn Guo --- drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/zte/Kconfig | 8 + drivers/gpu/drm/zte/Makefile | 8 + drivers/gpu/drm/zte/zx_crtc.c| 691 +++ drivers/gpu

[PATCH v2 2/2] drm: zte: add initial vou drm driver

2016-09-29 Thread Shawn Guo
On Sun, Sep 25, 2016 at 10:58:09PM +0200, Daniel Vetter wrote: > On Sat, Sep 24, 2016 at 10:26:25PM +0800, Shawn Guo wrote: > > It adds the initial ZTE VOU display controller DRM driver. There are > > still some features to be added, like overlay plane, scaling, and more >

[PATCH V5 4/4] dts/imx6q-b850v3: Use GE B850v3 LVDS/DP++ Bridge

2016-09-29 Thread Shawn Guo
On Mon, Sep 26, 2016 at 09:27:59AM +0100, Peter Senna Tschudin wrote: > Patch 1/4 is already on linux-next, but what about this one? Ping? Ping me after driver part (patch #3) lands on mainline. Shawn

[PATCH v2 2/2] drm: zte: add initial vou drm driver

2016-09-29 Thread Shawn Guo
Hi Sean, On Tue, Sep 27, 2016 at 11:48:37AM -0400, Sean Paul wrote: > On Sat, Sep 24, 2016 at 10:26 AM, Shawn Guo wrote: > > It adds the initial ZTE VOU display controller DRM driver. There are > > still some features to be added, like overlay plane, scaling, and more > > o

[PATCH] drm: add more document for drm_crtc_from_index()

2017-01-07 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Add a bit more document for function drm_crtc_from_index() to cross link it with drm_crtc_from_index(), and explain that the function is useful in vblank code. While at it, add cross link comment for drm_plane_from_index() as well. Signed-off-by: Sha

[PATCH] drm: zte: select VIDEOMODE_HELPERS in Kconfig

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> ZTE DRM driver uses drm_display_mode_to_videomode() in function zx_crtc_enable(). Select VIDEOMODE_HELPERS in Kconfig to fix the following link error. LD vmlinux.o MODPOST vmlinux.o drivers/built-in.o: In function `zx_crtc_enable': :(.text+0

[PATCH] drm: zte: select VIDEOMODE_HELPERS in Kconfig

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> ZTE DRM driver uses drm_display_mode_to_videomode() in function zx_crtc_enable(). Select VIDEOMODE_HELPERS in Kconfig to fix the following link error. LD vmlinux.o MODPOST vmlinux.o drivers/built-in.o: In function `zx_crtc_enable': :(.text+0

[PATCH 0/3] Add CRTC helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
On Fri, Dec 30, 2016 at 12:16:43PM +0100, Daniel Vetter wrote: > Entire series applied. I suspect that there's more drivers open-coding > something like this in their vblank code, might be worth it to grep for > them all and do a quick audit. I did a round of audit on all drivers vblank code, and

[PATCH 0/6] Use crtc helper drm_crtc_from_index() for more drivers

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> This is a follow-up series for "[PATCH 0/3] Add CRTC helper drm_crtc_from_index()" per Daniel's comment [1]. Basically, it changes some drivers to use helper drm_crtc_from_index() for the vblank code, so that either they do not need to sto

[PATCH 2/6] drm: kirin: use crtc helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Use drm_crtc_from_index() to find drm_crtc for given index, so that we do not need to maintain a pointer array in struct kirin_drm_private. Signed-off-by: Shawn Guo Cc: Xinliang Liu --- drivers/gpu/drm/hisilicon/kirin/kirin_drm_ade.

[PATCH 1/6] drm: exynos: use crtc helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Use drm_crtc_from_index() to find drm_crtc for given index, so that we do not need to maintain a pointer array in struct exynos_drm_private. Signed-off-by: Shawn Guo Cc: Inki Dae --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 6 -- drivers/g

[PATCH 4/6] drm: nouveau: use crtc helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Use drm_crtc_from_index() to find drm_crtc for given index. Signed-off-by: Shawn Guo Cc: Ben Skeggs --- drivers/gpu/drm/nouveau/nouveau_display.c | 33 +-- 1 file changed, 18 insertions(+), 15 deletions(-) diff

[PATCH 3/6] drm: mediatek: use crtc helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Use drm_crtc_from_index() to find drm_crtc for given index, so that we do not need to maintain a pointer array in struct mtk_drm_private. Signed-off-by: Shawn Guo Cc: CK Hu --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 9 - drivers/g

[PATCH 6/6] drm: vc4: use crtc helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Use drm_crtc_from_index() to find drm_crtc for given index, so that we do not need to maintain a pointer array in struct vc4_dev. Signed-off-by: Shawn Guo Cc: Eric Anholt --- drivers/gpu/drm/vc4/vc4_crtc.c | 17 +++-- drivers/gpu/d

[PATCH 5/6] drm: tegra: use crtc helper drm_crtc_from_index()

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Function tegra_crtc_from_pipe() does the exactly same thing as what crtc helper drm_crtc_from_index() provides. Use the helper to save some code. Signed-off-by: Shawn Guo Cc: Thierry Reding --- drivers/gpu/drm/tegra/drm.c | 19 +++-

[PATCH 0/4] Add vblank hooks to struct drm_crtc_funcs

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Although it can help to clean up driver code quite a bit, I'm not sure it's been done in the right way. So the series can be treated as RFC. When I was going through DRM drivers for candidates of using drm_crtc_from_index() helper, I found vblank ha

[PATCH 1/4] drm: add vblank hooks to struct drm_crtc_funcs

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> The vblank is mostly CRTC specific and implemented as part of CRTC driver. So having vblank hooks in struct drm_crtc_funcs should generally help to reduce code from client drivers in implementing drm_driver's vblank callbacks. Signed-off-by: Sha

[PATCH 2/4] drm: zte: zx_vou_enable[disable]_vblank can be static

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we can directly use the drm_crtc pointer passed in as parameter and make the functions static. The functions are moved around to save forward delarations. Signed-off-by: Shawn Guo --- drivers/gpu/d

[PATCH 4/4] drm: imx: remove struct imx_drm_crtc and imx_drm_crtc_helper_funcs

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain the CRTC specific vblank callbacks with struct imx_drm_crtc_helper_funcs any more. By moving the stuff that we currently do in imx_drm_add_crtc(), like of_node s

[PATCH 3/4] drm: rockchip: remove struct rockchip_crtc_funcs

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> With the vblank hooks in struct drm_crtc_funcs, we do not need to maintain struct rockchip_crtc_funcs and the related registration functions. Remove them. Signed-off-by: Shawn Guo Cc: Mark Yao --- drivers/gpu/drm/rockchip/rockchip_drm_drv.

[PATCH v3 3/3] drm: zte: add overlay plane support

2017-01-09 Thread Shawn Guo
On Thu, Jan 05, 2017 at 02:26:30AM -0500, Sean Paul wrote: > > +static u32 zx_vl_get_fmt(uint32_t format) > > +{ > > + u32 val = 0; > > + > > + switch (format) { > > + case DRM_FORMAT_NV12: > > + val = VL_FMT_YUV420; > > + break; > > + case

[PATCH v4 0/3] Add overlay plane support for ZTE drm driver

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Changes for v4: - Instead of using val, return value directly for zx_vl_get_fmt() and zx_vl_rsz_get_fmt(). - Fix typo of 'heigth' - Add 'enabled' in struct zx_plane to track layer enabling state, and check the state in zx_plane_set_update

[PATCH v4 1/3] drm: zte: make zx_plane accessible from zx_vou driver

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Move struct zx_plane from zx_plane.c to zx_plane.h, so that it can be accessed from zx_vou driver, and we can save the use of struct zx_layer_data completely. More importantly, those additional data used by VOU controller to enable/disable graphic and

[PATCH v4 2/3] drm: zte: add .atomic_disable hook to disable graphic layer

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> There are a few hardware bits for each graphic layer to control main/aux channel and clock selection, as well as the layer enabling. These bits sit outside the layer block itself, but in VOU control glue block. We currently set these bits up a

[PATCH v4 3/3] drm: zte: add overlay plane support

2017-01-09 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It enables VOU VL (Video Layer) to support overlay plane with scaling function. VL0 has some quirks on scaling support. We choose to skip it and only adds VL1 and VL2 into DRM core for now. Function zx_plane_atomic_disable() gets moved

[PATCH v4 3/3] drm: zte: add overlay plane support

2017-01-10 Thread Shawn Guo
Hi Sean, On Mon, Jan 09, 2017 at 11:27:44AM -0500, Sean Paul wrote: > > +static inline void zx_osd_int_update(struct zx_crtc *zcrtc) > > +{ > > + struct zx_vou_hw *vou = zcrtc->vou; > > + int i; > > + > > + vou_chn_set_update(zcrtc); > > +

[PATCH v5 0/3] Add overlay plane support for ZTE drm driver

2017-01-10 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Changes for v5: - Use crtc->state->plane_mask to check which planes are active for a given CRTC, so that we can save vou->overlays pointer array. - Use plane->state->crtc to determine if a plane is enabled or not, so that 'enab

[PATCH v5 1/3] drm: zte: make zx_plane accessible from zx_vou driver

2017-01-10 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> Move struct zx_plane from zx_plane.c to zx_plane.h, so that it can be accessed from zx_vou driver, and we can save the use of struct zx_layer_data completely. More importantly, those additional data used by VOU controller to enable/disable graphic and

[PATCH v5 2/3] drm: zte: add .atomic_disable hook to disable graphic layer

2017-01-10 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> There are a few hardware bits for each graphic layer to control main/aux channel and clock selection, as well as the layer enabling. These bits sit outside the layer block itself, but in VOU control glue block. We currently set these bits up a

[PATCH v5 3/3] drm: zte: add overlay plane support

2017-01-10 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It enables VOU VL (Video Layer) to support overlay plane with scaling function. VL0 has some quirks on scaling support. We choose to skip it and only adds VL1 and VL2 into DRM core for now. Function zx_plane_atomic_disable() gets moved

[PATCH 5/5] drm: zte: add tvenc driver support

2017-01-19 Thread Shawn Guo
From: Shawn Guo <shawn@linaro.org> It adds the TV Encoder driver to support video output in PAL and NTSC format. The driver uses syscon/regmap interface to configure register bit sitting in SYSCTRL module for DAC power control. Signed-off-by: Shawn Guo <shawn@linaro.org>

  1   2   3   >