fall
> back to zero like in the vendor driver.
>
> Cc: Stephan Gerhold
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Signed-off-by: Linus Walleij
> ---
> ChangeLog v1->v2:
> - Fix some more comments so we understand what is going
read up to 4 bytes from the
> display.
>
> Tested with a Sony ACX424AKP display: this display now self-
> identifies and can control backlight in command mode.
>
> Reported-by: kbuild test robot
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE"
fall
> back to zero like in the vendor driver.
>
> Cc: Stephan Gerhold
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Signed-off-by: Linus Walleij
> ---
> drivers/gpu/drm/mcde/mcde_dsi.c | 60 ++---
> 1 fi
read up to 4 bytes from the
> display.
>
> Tested with a Sony ACX424AKP display: this display now self-
> identifies and can control backlight in command mode.
>
> Cc: Stephan Gerhold
> Reported-by: kbuild test robot
> Fixes: 5fc537bfd000 ("drm/mcde: Add new d
t; msm_gem_get_and_pin_iova+0xdc/0x168 [msm]
> ...
>
> Fixes the combination of two patches:
>
> Fixes: 0036bc73ccbe ("drm/msm: stop abusing dma_map/unmap for cache")
> Fixes: 449fa54d6815 ("dma-direct: correct the physical addr in
> dma_direct_sync_sg_for_cpu/device")
Thanks for the patch! It fixes the issue on MSM8916/A5U:
Tested-by: Stephan Gerhold
ble() to dsi_mgr_bridge_disable() for similar reasons.
(This is not strictly required for the panel affected above...)
Tested-by: Jasper Korten
Signed-off-by: Stephan Gerhold
---
Since this is a core change I thought it would be better to send this
early. I believe Jasper still wants to finish some other changes bef
On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote:
> On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold wrote:
> >
> > At the moment, the MSM DSI driver calls drm_panel_enable() rather early
> > from the DSI bridge pre_enable() function. At this point, the e
On Fri, Nov 08, 2019 at 08:47:08PM -0700, Jeffrey Hugo wrote:
> On Fri, Nov 8, 2019 at 4:47 PM Stephan Gerhold wrote:
> >
> > On Fri, Nov 08, 2019 at 03:12:28PM -0700, Jeffrey Hugo wrote:
> > > On Fri, Nov 8, 2019 at 2:29 PM Stephan Gerhold
> > > wrote:
>
h above then becomes:
mcde-dsi a0351000.dsi: failed to find panel try bridge (-517)
mcde-dsi a0351000.dsi: no panel or bridge
...
Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_dsi.c | 6 --
sequence from
mode_set() to pre_enable(). Keep most of the video mode setup in
mode_set() since most of the registers are only dependent on the mode
that is set for the panel - there is no need to write them again each
time we re-enable the display.
Signed-off-by: Stephan Gerhold
---
drivers/gpu
, the vblank handling should be working correctly in
all the cases and we can enable it unconditionally.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_display.c | 15 +--
drivers/gpu/drm/mcde/mcde_drv.c | 16
2 files changed, 9 insertions(+), 22
le above.
Therefore we can just remove the connector setup from mcde_dsi.c
and let the DRM core handle all the hard work.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_dsi.c | 52 +
1 file changed, 1 insertion(+), 51 deletions(-)
diff --git a/
://lists.freedesktop.org/archives/dri-devel/2019-October/238175.html
Stephan Gerhold (7):
drm/mcde: Provide vblank handling unconditionally
drm/mcde: Fix frame sync setup for video mode panels
drm/mcde: dsi: Make video mode errors more verbose
drm/mcde: dsi: Delay start of video stream
if there is an vblank event pending when disabling the display,
and clear it by sending a fake vblank event in that case.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_display.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/mcde/mcde_display.c
b
Triggering an error conditions in DSI video mode only results in
a very generic "some video mode error status" error message
at the moment.
Make this more clear by adding separate error messages for each bit.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_dsi.c
necessary changes in that case.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_display.c | 32 -
drivers/gpu/drm/mcde/mcde_drm.h | 1 +
drivers/gpu/drm/mcde/mcde_drv.c | 2 --
drivers/gpu/drm/mcde/mcde_dsi.c | 13 ++--
4 files c
DSI formatter is properly set up and running
(i.e. when mcde_dsi_bridge_enable() is called).
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/mcde/mcde_dsi.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde
On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote:
> Hi,
>
> On Mon, Dec 09, 2019 at 07:32:54PM +0100, Stephan Gerhold wrote:
> > At the moment, video mode parameters like video=540x960,reflect_x,
> > (without rotation set) are silently ignored.
>
o parameters with only reflect option work correctly.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/drm_client_modeset.c | 27 ---
1 file changed, 16 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c
b/drivers/gpu/drm/drm_client_modes
On Fri, Dec 13, 2019 at 10:39:50AM +0100, Maxime Ripard wrote:
> Hi Stephan,
>
> On Wed, Dec 11, 2019 at 08:08:39PM +0100, Stephan Gerhold wrote:
> > On Wed, Dec 11, 2019 at 07:10:46PM +0100, Maxime Ripard wrote:
> > > On Tue, Dec 10, 2019 at 11:42:37AM +010
ation where the code is hard to understand.
> - Set the DSI_VID_VCA_SETTING2 field
> DSI_VID_VCA_SETTING2_MAX_LINE_LIMIT to blkline_pck - 6 as in
> the vendor driver and mask the field properly.
>
> Cc: Stephan Gerhold
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MC
6 as in
> the vendor driver and mask the field properly.
> - Set the DSI_VID_VCA_SETTING1 field
> DSI_VID_VCA_SETTING1_MAX_BURST_LIMIT to blkeol_pck - 6 to
> blkeol_duration - 6 as in the vendor driver.
>
> Cc: Stephan Gerhold
> Fixes: 5fc537bfd000 ("drm/mcde: Add n
On Wed, Dec 11, 2019 at 07:10:46PM +0100, Maxime Ripard wrote:
> Hi Stephan,
>
> On Tue, Dec 10, 2019 at 11:42:37AM +0100, Stephan Gerhold wrote:
> > On Tue, Dec 10, 2019 at 11:20:46AM +0100, Maxime Ripard wrote:
> > > Hi,
> > >
> > > On Mon, Dec 09,
On Mon, Dec 16, 2019 at 07:27:25PM +0200, Ville Syrjälä wrote:
> On Mon, Dec 16, 2019 at 06:10:17PM +0100, Stephan Gerhold wrote:
> > At the moment, video mode parameters like video=540x960,reflect_x,
> > (without rotation set) are not taken into account when applyi
handling (e.g. specific tiling format).
This makes video parameters with only reflect option work correctly.
Signed-off-by: Stephan Gerhold
---
v1: https://lists.freedesktop.org/archives/dri-devel/2019-December/248145.html
Changes in v2:
- Clarified commit message - parameters are parsed correctly
ro like in the vendor driver.
> - Put in lots of clarifying comments and references to the
> documentation where the code is hard to understand.
>
> Cc: Stephan Gerhold
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Signed-off-by: Lin
to program the
registers correctly for LDO mode.
Tested-by: Nikita Travkin # l8150
Signed-off-by: Stephan Gerhold
---
This is needed to make the display work on Longcheer L8150,
which has recently gained mainline support in:
https://git.kernel.org/pub/scm/linux/kernel/git/qcom/linux.git/
On Mon, Oct 21, 2019 at 01:47:19PM -0400, Sean Paul wrote:
> On Mon, Oct 21, 2019 at 06:34:25PM +0200, Stephan Gerhold wrote:
> > The DSI PHY regulator supports two regulator modes: LDO and DCDC.
> > This mode can be selected using the "qcom,dsi-phy-regulator-ldo-mode"
to program the
registers correctly for LDO mode.
Tested-by: Nikita Travkin # l8150
Signed-off-by: Stephan Gerhold
---
Changes in v2: Move DCDC/LDO code into separate methods
v1:
https://lore.kernel.org/linux-arm-msm/20191021163425.83697-1-step...@gerhold.net/
This is needed to make the display work on Longc
command mode
> by using the bool property "dsi-command-mode".
>
> Cc: Stephan Gerhold
> Signed-off-by: Linus Walleij
> ---
> ChangeLog v4->v5:
> - Bindings were iterated separately so a jump in versioning.
> - Add Stephan as reviewer.
> ChangeLog v3->v4:
>
On Fri, Nov 22, 2019 at 08:24:57AM +0100, Linus Walleij wrote:
> The MCDE DSI include file redefines some commands that
> already exist in the common header.
>
> Cc: Stephan Gerhold
> Signed-off-by: Linus Walleij
Reviewed-by: Stephan Gerhold
> ---
> drivers/gp
ates less cognitive stress
> for humans.
>
> Cc: Stephan Gerhold
> Signed-off-by: Linus Walleij
Reviewed-by: Stephan Gerhold
> ---
> drivers/gpu/drm/mcde/mcde_dsi.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/mcde
Hi Maxime,
On Fri, Jan 17, 2020 at 07:51:00PM +0100, Maxime Ripard wrote:
> On Fri, Jan 17, 2020 at 04:34:27PM +0100, Stephan Gerhold wrote:
> > At the moment, video mode parameters like video=540x960,reflect_x,
> > (without rotation set) are not taken into account when applyi
Hi Maxime,
On Mon, Dec 16, 2019 at 07:08:12PM +0100, Stephan Gerhold wrote:
> On Mon, Dec 16, 2019 at 07:27:25PM +0200, Ville Syrjälä wrote:
> > On Mon, Dec 16, 2019 at 06:10:17PM +0100, Stephan Gerhold wrote:
> > > At the moment, video mode parameters like video=540x960,reflect
tion values
v2:
https://lore.kernel.org/dri-devel/20191216171017.173326-1-step...@gerhold.net/
- Clarified commit message - parameters are parsed correctly,
but not taken into account when applying the mode.
v1:
https://lore.kernel.org/dri-devel/20191209183254.211428-1-step...@gerhold.ne
a valid rotation value:
- Set DRM_MODE_ROTATE_0 by default (if no rotate= option is set)
- Validate that there is exactly one rotation angle set
(i.e. specifying the rotate= option multiple times is invalid)
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/drm_modes.c
ation" and should therefore not require
any special handling, so we can just add it to the if condition.
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/drm_client_modeset.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_client_modeset.c
b/drive
gt; the Samsung s6e63m0 panel on the Golden device.
>
> Retry reads and writes alike three times.
>
> Cc: Stephan Gerhold
> Signed-off-by: Linus Walleij
> ---
> ChangeLog v1->v2:
> - Retry three times.
> - Only retry the actual command transmission like the vendor
>
gt; the Samsung s6e63m0 panel on the Golden device.
>
So this fixes reads from the panel for samsung-golden?
> Retry reads and writes alike two times.
>
> Cc: Stephan Gerhold
> Signed-off-by: Linus Walleij
> ---
> drivers/gpu/drm/mcde/mcde_dsi.c | 21 +++--
&g
current
> usage.
>
> Cc: Stephan Gerhold
> Signed-off-by: Linus Walleij
Reviewed-by: Stephan Gerhold
> ---
> drivers/gpu/drm/mcde/mcde_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/mcde/mcde_display.c
>
mand mode: this should only be explicitly
> requested when using BTA, according to the vendor driver.
>
> This has been tested and works fine with the command mode
> displays I have. (All that are supported upstream.)
>
> Reported-by: Stephan Gerhold
> Cc:
ing
> a TE request before every command when sending data to
> a display in command mode: this should only be explicitly
> requested when using BTA, according to the vendor driver.
>
> This has been tested and works fine with the command mode
> displays I have. (All that are su
not call mcde_display_send_one_frame().
>
> This fixes crashes on the Samsung GT-S7710 (Skomer).
>
> Cc: Stephan Gerhold
> Cc: sta...@vger.kernel.org
> Signed-off-by: Linus Walleij
> ---
> drivers/gpu/drm/mcde/mcde_display.c | 11 ---
> 1 file changed, 8 insertions(+), 3 del
On Sun, Aug 09, 2020 at 11:51:02PM +0200, Linus Walleij wrote:
> This makes it possible to use the s6e63m0 panel with a
> DSI host, such as in the Samsung GT-I8190 (Golden) mobile
> phone.
>
> Cc: Stephan Gerhold
> Cc: Paweł Chmiel
> Signed-off-by: Linus Walleij
> ---
ers were not so lucky and got black screens.
>
> Cc: Ville Syrjälä
> Reported-by: Stephan Gerhold
> Fixes: 920dd1b1425b ("drm/mcde: Use mode->clock instead of reverse
> calculating it from the vrefresh")
> Signed-off-by: Linus Walleij
Can confirm this makes things much
was actually initialized earlier.
Fixes: 9bc95570175a ("drm/msm: Devfreq tuning")
Reported-by: Nikita Travkin
Tested-by: Nikita Travkin
Signed-off-by: Stephan Gerhold
---
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/g
On Sun, Aug 08, 2021 at 09:44:57PM +0800, Shawn Guo wrote:
> On Wed, Aug 04, 2021 at 02:09:19PM +0200, Stephan Gerhold wrote:
> > On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote:
> > > + ...
> > > + nt_dcs_write(0xb1, 0x6c, 0x21);
> > > + nt_dcs_writ
Hi Shawn,
Thanks for the patch!
On Wed, Aug 04, 2021 at 04:13:52PM +0800, Shawn Guo wrote:
> It adds a drm driver for Truly NT35521 5.24" 1280x720 DSI panel, which
> can be found on Sony Xperia M4 Aqua phone. The panel backlight is
> managed through DSI link.
>
> Signed-off-by: Shawn Guo
>
On Thu, Jun 30, 2022 at 08:49:03PM +0100, Bryan O'Donoghue wrote:
> On 30/06/2022 20:01, Krzysztof Kozlowski wrote:
> > On 30/06/2022 14:08, Bryan O'Donoghue wrote:
> > > The existing msm8916.dtsi does not depend on nor require power-domains.
> > > Drop from the list of required.
> >
> > That's
[added Dmitry to Cc, since he suggested doing this in [1]]
On Tue, Jun 13, 2023 at 12:36:52AM +0100, Caleb Connolly wrote:
> The commit 007ac0262b0d ("drm/msm/dsi: switch to DRM_PANEL_BRIDGE")
> breaks panels which send DSI commands in their .unprepare callbacks.
> Migrate to using .disable for
On Thu, Jun 15, 2023 at 09:49:27AM +0200, Neil Armstrong wrote:
> On 14/06/2023 22:58, Linus Walleij wrote:
> > On Tue, Jun 13, 2023 at 11:08 PM Stephan Gerhold
> > wrote:
> >
> > > I'm still quite confused about what exactly is supposed to be in
> > >
On Tue, May 30, 2023 at 08:24:17PM +0200, Luca Weiss wrote:
> Add the nodes that describe the mdss so that display can work on
> MSM8226.
>
> Signed-off-by: Luca Weiss
Can you update this to use labels like in [1]? See inline below.
This will allow proper grouping of the labels in the board DT.
52 matches
Mail list logo
