Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread jimqu
utlook client. thanks, Takashi Thanks JimQu 发件人: Takashi Iwai 发送时间: 2018年7月10日 1:09 收件人: Qu, Jim 抄送: Daniel Vetter; Alex Deucher; alsa-de...@alsa-project.org; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Deucher, Alexander 主

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-10 Thread jimqu
On 2018年07月10日 17:50, Takashi Iwai wrote: On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: On 2018年07月10日 16:01, Takashi Iwai wrote: On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
[AMD/ATI] Device [1002:15dd] (rev d1) 06:00.1 Audio device [0403]: Advanced Micro Devices, Inc. [AMD/ATI] Device [1002:15de] Thanks JimQu At best, give the full dmesg output and the lspci -nv output. thanks, Takashi ___ dri-deve

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
On 2018年07月11日 17:04, Takashi Iwai wrote: On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: On 2018年07月11日 15:19, Takashi Iwai wrote: On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: revert the fix of amdgpu suspend issue, audio issue also can be observed. Did you check the

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-11 Thread jimqu
On 2018年07月11日 17:53, Takashi Iwai wrote: On Wed, 11 Jul 2018 11:26:11 +0200, jimqu wrote: On 2018年07月11日 17:04, Takashi Iwai wrote: On Wed, 11 Jul 2018 10:41:38 +0200, jimqu wrote: On 2018年07月11日 15:19, Takashi Iwai wrote: On Tue, 10 Jul 2018 13:21:00 +0200, Takashi Iwai wrote: revert

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
the hda->use_vga_switcheroo is checked at beginning of the function. so the p which pass into vga_switcheroo_register_audio_client() is constant valid value. Thanks JimQu thanks, Takashi ___ dri-devel mailing list dri-devel@lists.freedesktop.or

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
we suppose VGA_SWITCHEROO_UNKNOWN_ID can be only used for gpu client, but now we also use it on audio client. Because of -1 in memory is presented as 0x, so the 0x & ID_BIT_AUDIO = ID_BIT_AUDIO, this will confuse people if it used on gpu client. that a

Re: [alsa-devel] [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
在 2018/7/14 0:38, Takashi Iwai 写道: On Fri, 13 Jul 2018 17:25:39 +0200, jimqu wrote: 在 2018/7/13 16:46, Takashi Iwai 写道: On Fri, 13 Jul 2018 10:06:02 +0200, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-13 Thread jimqu
used for gpu client, and now we also use it on the audio client. if we set VGA_SWITCHEROO_UNKNOWN_ID to gpu clients, client_is_audio(client) will be true, since -1 in memory is presented as 0x(if it is 64bit asic). thanks JimQu Thanks, Lukas __

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

2018-07-14 Thread jimqu
has moved to use DC to support new asics. so there also need a patch for amdgpu in DC code. Thanks JimQu thanks, Takashi ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread jimqu
在 2018/7/16 22:02, Lukas Wunner 写道: On Sat, Jul 14, 2018 at 02:15:24PM +0800, jimqu wrote: ??? 2018/7/13 17:27, Lukas Wunner ??: On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

2018-07-16 Thread jimqu
.4 (kernel is v4.15), ubuntu 18.04(kernel is v4.15), RHEL7.x (kernel is 3.1x). BTW, I believe you will see more and more products with AMD next generation of APUs in the near future. Thanks JimQu Lukas ___ dri-devel mailing list

Re: [V3] vga_switcheroo: set audio client id according to bound GPU id

2018-07-17 Thread jimqu
dio problem and I'd love to merge it for 4.19, I'd prefer taking through sound git tree, unless anyone has objection. Thanks to Takashi and Lukas great help. Please kindly help merge the patch into suitable branch. Thanks JimQu thanks, Takashi

Re: 答复: [PATCH 3/4] drm/radeon: Add audio component support

2018-07-24 Thread jimqu
l state is inquired via get_eld call by HD-audio followed after the notification. thanks, Takashi OK, I got your point. Thanks JimQu ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: 答复: [PATCH 4/4] drm/amdgpu: Add audio component support

2018-07-25 Thread jimqu
r the display which is plugged out, so there is no notify() call on it. Thanks JimQu With None-DC driver, the detect() of connectors will to be preformed in drm_helper_hpd_irq_event() when there is device hotplug. However, amdgpu_connector__detect() maybe need to be modified to fit your c

Re: y4T�TCH 4/4] drm/amdgpu: Add audio component support

2018-07-26 Thread jimqu
On 2018年07月25日 16:20, Takashi Iwai wrote: On Wed, 25 Jul 2018 10:02:34 +0200, jimqu wrote: On 2018年07月25日 13:46, Takashi Iwai wrote: On Wed, 25 Jul 2018 07:38:37 +0200, Qu, Jim wrote: Jim: Just like Alex said, we want driver can get eld info when hotplug in new device. amdgpu