Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

Hi Jingoo Han, Thanks for the response. Thanks, Kiran On 2018-05-04 21:25, Jingoo Han wrote: On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote: If you really want someone to review your patch, please add more detailed explanations. 1. Please add 0th patch. I have already added the 0th

Re: [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic

On 2018-05-14 22:32, Bjorn Andersson wrote: On Wed 09 May 00:14 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 23:40, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: > > [..] > > + > > +#define WLED_AUTO_DETECT_OVP_COUNT 5 > > +#define

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-14 22:27, Pavel Machek wrote: Hi! WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Signed-off-by: Kiran Gunda ---

Re: [PATCH V2 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-08 16:05, Daniel Thompson wrote: On Thu, May 03, 2018 at 03:42:30PM +0530, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event

Re: [PATCH V2 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-08 16:09, Daniel Thompson wrote: On Thu, May 03, 2018 at 03:42:31PM +0530, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-05-08 14:06, Daniel Thompson wrote: On Mon, May 07, 2018 at 11:26:59AM +0530, kgu...@codeaurora.org wrote: Hi Jingoo Han, Thanks for the response. Thanks, Kiran On 2018-05-04 21:25, Jingoo Han wrote: > On Thursday, May 3, 2018 6:12 AM, Kiran Gunda wrote: > > If you really want someone

Re: [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-07 22:36, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event persists.

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Several things are going on in this

Re: [PATCH V2 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-07 22:15, Rob Herring wrote: On Thu, May 03, 2018 at 03:42:29PM +0530, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support for it. Signed-off-by: Kiran Gunda

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-07 22:51, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED peripheral has over voltage protection(OVP) circuitry and the OVP fault is notified through an interrupt. Though this fault condition rising is due to an incorrect hardware configuration is

Re: [PATCH V2 1/5] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-05-07 22:10, Rob Herring wrote: On Thu, May 03, 2018 at 03:42:28PM +0530, Kiran Gunda wrote: pm8941-wled.c driver is supporting the WLED peripheral on pm8941. Rename it to qcom-wled.c so that it can support WLED on multiple PMICs. Signed-off-by: Kiran Gunda ---

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-08 22:49, Bjorn Andersson wrote: On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 22:51, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > @@ -220,7 +255,12 @@ static int wled_module_enable(struct wled > > *wled, int val) >

Re: [PATCH V1 4/5] backlight: qcom-wled: Add support for OVP interrupt handling

On 2018-05-09 10:36, kgu...@codeaurora.org wrote: On 2018-05-08 22:49, Bjorn Andersson wrote: On Tue 08 May 05:26 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 22:51, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > @@ -220,7 +255,12 @@ static int

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-08 22:47, Bjorn Andersson wrote: On Tue 08 May 03:25 PDT 2018, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: > On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] > > +- qcom,ovp > > + Usage:optional > > + Value type: > > +

Re: [PATCH V1 3/5] backlight: qcom-wled: Add support for short circuit handling

On 2018-05-07 13:36, Dan Carpenter wrote: Hi Kiran, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on backlight/for-backlight-next] [also build test WARNING on v4.17-rc3 next-20180504] [if your patch is applied to the wrong git tree, please drop us a note to

Re: [PATCH V1 5/5] backlight: qcom-wled: Add auto string detection logic

On 2018-05-07 23:40, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: [..] + +#define WLED_AUTO_DETECT_OVP_COUNT 5 +#define WLED_AUTO_DETECT_CNT_DLY_USHZ /* 1 second */ +static bool wled_auto_detection_required(struct wled *wled) So

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-17 18:01, Rob Herring wrote: On Thu, May 17, 2018 at 4:47 AM, wrote: On 2018-05-08 15:55, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs

Re: [PATCH V1 2/5] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-05-08 15:55, kgu...@codeaurora.org wrote: On 2018-05-07 21:50, Bjorn Andersson wrote: On Thu 03 May 02:57 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and also configurations are different. Add support

Re: [PATCH V3 5/7] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-06-23 04:39, Bjorn Andersson wrote: On Wed 20 Jun 04:00 PDT 2018, kgu...@codeaurora.org wrote: On 2018-06-20 10:44, Bjorn Andersson wrote: > On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: > > > WLED4 peripheral is present on some PMICs like pmi8998 and > > pm660l. It has a different

Re: [PATCH V3 6/7] backlight: qcom-wled: add support for short circuit handling

On 2018-06-20 11:17, Vinod wrote: On 19-06-18, 16:43, Kiran Gunda wrote: struct wled { const char *name; struct device *dev; struct regmap *regmap; + struct mutex lock; /* Lock to avoid race from ISR */ the comment is wrong as you avoid race with thread

Re: [PATCH V3 7/7] backlight: qcom-wled: Add auto string detection logic

On 2018-06-20 11:52, Bjorn Andersson wrote: On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: The auto string detection algorithm checks if the current WLED sink configuration is valid. It tries enabling every sink and checks if the OVP fault is observed. Based on this information it detects

Re: [PATCH V3 3/7] backlight: qcom-wled: Add new properties for PMI8998

On 2018-06-21 00:35, Rob Herring wrote: > On Tue, Jun 19, 2018 at 04:43:38PM +0530, Kiran Gunda wrote: > >> Update the bindings with the new properties used for >> PMI8998. >> >> Signed-off-by: Kiran Gunda >> --- >> .../bindings/leds/backlight/qcom-wled.txt | 84 >>

Re: [PATCH V3 5/7] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-06-20 10:44, Bjorn Andersson wrote: On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and configurations are also different. Add support for it. Signed-off-by: Kiran Gunda ---

Re: [PATCH V3 1/7] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c

On 2018-06-20 04:24, Bjorn Andersson wrote: On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: pm8941-wled.c driver is supporting the WLED peripheral on pm8941. Rename it to qcom-wled.c so that it can support WLED on multiple PMICs. Signed-off-by: Kiran Gunda Please carry any tags acquired

Re: [PATCH V3 3/7] backlight: qcom-wled: Add new properties for PMI8998

On 2018-06-20 04:33, Bjorn Andersson wrote: On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt [..] - qcom,num-strings Usage:optional

Re: [PATCH V3 4/7] backlight: qcom-wled: Rename PM8941* to WLED3

On 2018-06-20 04:41, Bjorn Andersson wrote: On Tue 19 Jun 04:13 PDT 2018, Kiran Gunda wrote: Rename the PM8941* references as WLED3 to make the driver generic and have WLED support for other PMICs. Looks good, just three minor comments below. Signed-off-by: Kiran Gunda ---

Re: [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver

Hi Bjorn, Can you please help review this patch series ? Pavel, Rob, Daniel reviewed the series except the "auto string detection" patch. Thanks, Kiran On 2018-07-09 15:52, Kiran Gunda wrote: This patch series renames the pm8941-wled.c driver to qcom-wled.c to add the support for multiple

Re: [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3

On 2018-08-07 11:07, Bjorn Andersson wrote: On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote: diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c [..] @@ -365,6 +434,15 @@ static int wled_configure(struct wled *wled, struct device *dev)

Re: [PATCH V4 4/8] backlight: qcom-wled: Rename PM8941* to WLED3

On 2018-08-07 11:11, Bjorn Andersson wrote: On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote: Rename the PM8941* references as WLED3 to make the driver generic and have WLED support for other PMICs. Signed-off-by: Kiran Gunda I agree with Daniel, regarding the mentioning of the variable

Re: [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998

On 2018-08-07 10:53, Bjorn Andersson wrote: On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote: diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt [..] - qcom,num-strings Usage:optional

Re: [PATCH V4 8/8] backlight: qcom-wled: Add auto string detection logic

On 2018-08-07 12:02, Bjorn Andersson wrote: On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote: diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c [..] @@ -189,6 +206,15 @@ static int wled4_set_brightness(struct wled *wled, u16 brightness) return 0;

Re: [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver

On 2018-08-03 13:15, Daniel Thompson wrote: On Fri, Aug 03, 2018 at 12:49:34PM +0530, kgu...@codeaurora.org wrote: Hi Bjorn, Can you please help review this patch series ? Pavel, Rob, Daniel reviewed the series except the "auto string detection" patch. I did take a glance at the last

Re: [PATCH V5 3/8] backlight: qcom-wled: Add new properties for PMI8998

On 2018-08-27 15:31, Pavel Machek wrote: Hi! On Fri 2018-08-24 15:57:42, Kiran Gunda wrote: Update the bindings with the new properties used for PMI8998. Changes from V3: - Removed the default values. Why? As per Bjorn's comment I have removed the default values. Do you want to add

Re: [PATCH V5 5/8] backlight: qcom-wled: Restructure the driver for WLED3

On 2018-08-27 15:39, Pavel Machek wrote: On Fri 2018-08-24 15:57:44, Kiran Gunda wrote: Restructure the driver to add the support for new WLED peripherals. Signed-off-by: Kiran Gunda Acked-by: Daniel Thompson --- Changes from V3: - This is the new patch after splitting the

Re: [PATCH V5 8/8] backlight: qcom-wled: Add auto string detection logic

On 2018-08-27 20:24, Bjorn Andersson wrote: On Fri 24 Aug 03:27 PDT 2018, Kiran Gunda wrote: diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c [..] struct wled { @@ -135,16 +146,22 @@ struct wled { struct regmap *regmap; struct mutex lock;

Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral

On 2018-07-21 02:51, Pavel Machek wrote: Hi! >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx) > } > #define WLED3 3 >+#defineWLED4 4 Are these macros always going to define 3 to be 3 and 4 to be 4. If so we probably don't need them (and they

Re: [PATCH V4 4/8] backlight: qcom-wled: Rename PM8941* to WLED3

On 2018-07-20 18:53, Daniel Thompson wrote: On 09/07/18 11:22, Kiran Gunda wrote: Rename the PM8941* references as WLED3 to make the driver generic and have WLED support for other PMICs. Signed-off-by: Kiran Gunda --- Changes from V3: - Changed the MODULE_DESCRIPTION

Re: [PATCH V4 7/8] backlight: qcom-wled: add support for short circuit handling

On 2018-07-20 19:37, Daniel Thompson wrote: On 09/07/18 11:22, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event persists.

Re: [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998

On 2018-09-04 00:25, Bjorn Andersson wrote: On Wed 15 Aug 22:23 PDT 2018, kgu...@codeaurora.org wrote: On 2018-08-07 10:53, Bjorn Andersson wrote: > On Mon 09 Jul 03:22 PDT 2018, Kiran Gunda wrote: > > diff --git > > a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.txt > >

Re: [PATCH V9 1/6] backlight: qcom-wled: Add new properties for PMI8998.

On 2019-10-31 14:28, Lee Jones wrote: On Wed, 23 Oct 2019, Kiran Gunda wrote: Update the bindings with the new properties used for PMI8998. Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring Acked-by: Daniel Thompson ---

Re: [PATCH V7 6/6] backlight: qcom-wled: Add auto string detection logic

On 2019-10-17 19:09, Daniel Thompson wrote: On Thu, Oct 17, 2019 at 05:47:47PM +0530, kgu...@codeaurora.org wrote: On 2019-10-17 16:59, Daniel Thompson wrote: > On Wed, Oct 16, 2019 at 03:43:46PM +0530, Kiran Gunda wrote: > > The auto string detection algorithm checks if the current WLED > >

Re: [PATCH V7 6/6] backlight: qcom-wled: Add auto string detection logic

On 2019-10-17 19:00, Lee Jones wrote: On Thu, 17 Oct 2019, kgu...@codeaurora.org wrote: On 2019-10-17 17:56, Lee Jones wrote: > On Wed, 16 Oct 2019, Kiran Gunda wrote: > > > The auto string detection algorithm checks if the current WLED > > sink configuration is valid. It tries enabling every

Re: [PATCH V6 3/8] backlight: qcom-wled: Add new properties for PMI8998

On 2019-10-01 20:42, Dan Murphy wrote: Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Update the bindings with the new properties used for PMI8998. Signed-off-by: Kiran Gunda Reviewed-by: Bjorn Andersson Reviewed-by: Rob Herring Acked-by: Daniel Thompson ---

Re: [PATCH V8 6/6] backlight: qcom-wled: Add auto string detection logic

On 2019-10-21 16:01, Daniel Thompson wrote: On Fri, Oct 18, 2019 at 06:03:29PM +0530, Kiran Gunda wrote: The auto string detection algorithm checks if the current WLED sink configuration is valid. It tries enabling every sink and checks if the OVP fault is observed. Based on this information it

Re: [PATCH V8 4/6] backlight: qcom-wled: Add support for WLED4 peripheral.

On 2019-10-21 15:49, Daniel Thompson wrote: On Fri, Oct 18, 2019 at 06:03:27PM +0530, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and configurations are also different. Add support for it. Signed-off-by: Kiran Gunda

Re: [PATCH V7 5/6] backlight: qcom-wled: add support for short circuit handling.

On 2019-10-17 16:39, Daniel Thompson wrote: On Wed, Oct 16, 2019 at 03:43:45PM +0530, Kiran Gunda wrote: Handle the short circuit interrupt and check if the short circuit interrupt is valid. Re-enable the module to check if it goes away. Disable the module altogether if the short circuit event

Re: [PATCH V7 6/6] backlight: qcom-wled: Add auto string detection logic

On 2019-10-17 16:59, Daniel Thompson wrote: On Wed, Oct 16, 2019 at 03:43:46PM +0530, Kiran Gunda wrote: The auto string detection algorithm checks if the current WLED sink configuration is valid. It tries enabling every sink and checks if the OVP fault is observed. Based on this information it

Re: [PATCH V7 6/6] backlight: qcom-wled: Add auto string detection logic

On 2019-10-17 17:56, Lee Jones wrote: On Wed, 16 Oct 2019, Kiran Gunda wrote: The auto string detection algorithm checks if the current WLED sink configuration is valid. It tries enabling every sink and checks if the OVP fault is observed. Based on this information it detects and enables the

Re: [PATCH V7 4/6] backlight: qcom-wled: Add support for WLED4 peripheral.

On 2019-10-17 16:36, Daniel Thompson wrote: On Wed, Oct 16, 2019 at 03:43:44PM +0530, Kiran Gunda wrote: WLED4 peripheral is present on some PMICs like pmi8998 and pm660l. It has a different register map and configurations are also different. Add support for it. There is code buried in this

Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3

On 2019-10-01 20:47, Dan Murphy wrote: Kiran On 9/30/19 1:39 AM, Kiran Gunda wrote: Restructure the driver to add the support for new WLED peripherals. Signed-off-by: Kiran Gunda Acked-by: Daniel Thompson --- drivers/video/backlight/qcom-wled.c | 395 ++--

Re: [PATCH -next v2] backlight: qcom-wled: fix unsigned comparison to zero

On 2020-01-22 16:25, Daniel Thompson wrote: On Wed, Jan 22, 2020 at 09:32:40AM +0800, Chen Zhou wrote: Fixes coccicheck warning: ./drivers/video/backlight/qcom-wled.c:1104:5-15: WARNING: Unsigned expression compared with zero: string_len > 0 The unsigned variable string_len is assigned

Re: [PATCH V3 3/4] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L

On 2020-03-10 21:15, Daniel Thompson wrote: On Mon, Mar 09, 2020 at 06:56:01PM +0530, Kiran Gunda wrote: Add support for WLED5 peripheral that is present on PM8150L PMICs. PM8150L WLED supports the following: - Two modulators and each sink can use any of the modulator - Multiple CABC

Re: [PATCH V3 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

On 2020-03-11 00:01, Rob Herring wrote: On Mon, 9 Mar 2020 18:55:59 +0530, Kiran Gunda wrote: Convert the qcom-wled bindings from .txt to .yaml format. Signed-off-by: Kiran Gunda --- .../bindings/leds/backlight/qcom-wled.txt | 154 -

Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

On 2020-03-10 20:57, Daniel Thompson wrote: On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: Add cabc_config, sync_toggle, wled_ovp_fault_status and wled_ovp_delay callback functions to prepare the driver for adding WLED5 support. Signed-off-by: Kiran Gunda Overall this code

Re: [PATCH V3 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

On 2020-03-10 20:31, Daniel Thompson wrote: On Mon, Mar 09, 2020 at 06:55:59PM +0530, Kiran Gunda wrote: Convert the qcom-wled bindings from .txt to .yaml format. Signed-off-by: Kiran Gunda Acked-by: Daniel Thompson Thanks. --- .../bindings/leds/backlight/qcom-wled.txt | 154

Re: [PATCH V1 2/2] backlight: qcom-wled: Add support for WLED5 peripheral in PM8150L

On 2020-03-09 03:17, Bjorn Andersson wrote: On Mon 02 Mar 04:55 PST 2020, Kiran Gunda wrote: diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c [..] @@ -147,14 +187,39 @@ struct wled { u32 max_brightness; u32 short_count; u32

Re: [PATCH V5 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

On 2020-04-15 20:39, Rob Herring wrote: On Tue, Apr 07, 2020 at 09:17:07PM +0530, Kiran Gunda wrote: Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Acked-by:

Re: [PATCH V5 3/4] backlight: qcom-wled: Add WLED5 bindings

On 2020-04-15 20:42, Rob Herring wrote: On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: Add WLED5 specific bindings. checkpatch.pl complains about some trailing whitespace. The previous patch too. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy ---

Re: [PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

On 2020-04-06 14:20, Lee Jones wrote: On Fri, 03 Apr 2020, Daniel Thompson wrote: On Fri, Apr 03, 2020 at 04:45:49PM +0530, kgu...@codeaurora.org wrote: > On 2020-03-31 23:24, Rob Herring wrote: > > On Mon, Mar 23, 2020 at 11:16:55PM +0530, Kiran Gunda wrote: > > > diff --git > > >

Re: [PATCH V4 3/4] backlight: qcom-wled: Add WLED5 bindings

On 2020-03-31 23:26, Rob Herring wrote: On Mon, Mar 23, 2020 at 11:16:57PM +0530, Kiran Gunda wrote: Add WLED5 specific bindings. More of the same comments here... Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy --- .../bindings/leds/backlight/qcom-wled.yaml

Re: [PATCH V4 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

On 2020-03-31 23:24, Rob Herring wrote: On Mon, Mar 23, 2020 at 11:16:55PM +0530, Kiran Gunda wrote: Convert the qcom-wled bindings from .txt to .yaml format. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Acked-by: Daniel Thompson ---

Re: [PATCH V4 3/4] backlight: qcom-wled: Add WLED5 bindings

On 2020-03-25 21:07, Daniel Thompson wrote: On Mon, Mar 23, 2020 at 11:16:57PM +0530, Kiran Gunda wrote: Add WLED5 specific bindings. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy --- .../bindings/leds/backlight/qcom-wled.yaml | 39 ++ 1

Re: [PATCH V4 2/4] backlight: qcom-wled: Add callback functions

On 2020-03-25 21:00, Daniel Thompson wrote: On Mon, Mar 23, 2020 at 11:16:56PM +0530, Kiran Gunda wrote: Add wled_cabc_config, wled_sync_toggle, wled_ovp_fault_status and wled_ovp_delay callback functions to prepare the driver for adding WLED5 support. wled_cabc_config() ===> Used to configure

Re: [PATCH V3 2/4] backlight: qcom-wled: Add callback functions

On 2020-03-11 16:00, Daniel Thompson wrote: On Wed, Mar 11, 2020 at 12:11:00PM +0530, kgu...@codeaurora.org wrote: On 2020-03-10 20:57, Daniel Thompson wrote: > On Mon, Mar 09, 2020 at 06:56:00PM +0530, Kiran Gunda wrote: > > Add cabc_config, sync_toggle, wled_ovp_fault_status and

Re: [PATCH] backlight: qcom-wled: Use sink_addr for sync toggle

On 2021-03-15 17:51, Daniel Thompson wrote: On Sun, Mar 14, 2021 at 11:11:10AM +0100, Marijn Suijten wrote: From: Obeida Shamoun WLED3_SINK_REG_SYNC is, as the name implies, a sink register offset. Therefore, use the sink address as base instead of the ctrl address. This fixes the sync

Re: [PATCH V2 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

On 2021-02-26 22:56, Daniel Thompson wrote: On Fri, Feb 26, 2021 at 05:42:24PM +0530, Kiran Gunda wrote: As per the current implementation, after FSC (Full Scale Current) and brightness update the sync bits are transitioned from 1 to 0. This still seems to incorrectly describe the current

Re: [PATCH V1 1/2] backlight: qcom-wled: Fix FSC update issue for WLED5

On 2021-02-24 16:45, Daniel Thompson wrote: On Wed, Feb 24, 2021 at 09:20:47AM +0530, Kiran Gunda wrote: Currently, for WLED5, after FSC register update MOD_SYNC_BIT is toggled instead of SYNC_BIT. MOD_SYNC_BIT has to be toggled after the brightness update and SYNC_BIT has to be toggled after

Re: [PATCH V1 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

On 2021-02-24 16:56, Daniel Thompson wrote: On Wed, Feb 24, 2021 at 09:20:48AM +0530, Kiran Gunda wrote: Currently the FSC SYNC_BIT and MOD_SYNC_BIT are toggled from 1 to 0 to update the FSC and brightenss settings. Change this sequence form 0 to 1 as per the hardware team recommendation to

Re: [PATCH V3 2/2] backlight: qcom-wled: Correct the sync_toggle sequence

On 2021-03-01 15:32, Daniel Thompson wrote: On Mon, Mar 01, 2021 at 02:58:36PM +0530, Kiran Gunda wrote: As per the current implementation, after FSC (Full Scale Current) and brightness update the sync bits are transitioned from set-then-clear. This does not makes sense since there are too

Re: [PATCH V1 0/2] Fix WLED FSC Sync and brightness Sync settings

On 2021-02-19 23:38, Pavel Machek wrote: Hi! The FSC (Full scale current) setting is not updated properly due to the wrong register toggling for WLED5. Also the ILED_SYNC toggle and MOD_SYNC toggle sequence is updated as per the hardware team recommendation to fix the FSC update and