Re: [PATCH 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2018-10-08 Thread skolluku
On 2018-10-08 20:09, Jordan Crouse wrote: On Mon, Oct 08, 2018 at 02:57:29PM +0530, Sravanthi Kollukuduru wrote: The interconnect framework is designed to provide a standard kernel interface to control the settings of the interconnects on a SoC. The interconnect API uses a consumer/provider-bas

Re: [PATCH 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling

2018-10-09 Thread skolluku
On 2018-10-08 14:57, Sravanthi Kollukuduru wrote: Since the upstream interconnect bus framework has landed upstream, the existing references of custom bus scaling needs to be cleaned up. Signed-off-by: Sravanthi Kollukuduru --- drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c| 157 ++

Re: [Freedreno] [PATCH v2 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

2018-11-01 Thread skolluku
On 2018-10-24 22:09, Matthias Kaehlcke wrote: Hi Sravanthi, On Wed, Oct 10, 2018 at 02:54:33PM +0530, Sravanthi Kollukuduru wrote: The interconnect framework is designed to provide a standard kernel interface to control the settings of the interconnects on a SoC. The interconnect API uses a co

Re: [PATCH v2 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling

2018-11-15 Thread skolluku
On 2018-11-14 21:19, Sean Paul wrote: On Wed, Oct 10, 2018 at 02:54:32PM +0530, Sravanthi Kollukuduru wrote: Since the upstream interconnect bus framework has landed upstream, the existing references of custom bus scaling needs to be cleaned up. Just a few nits below. Sure, will make the chan

Re: [PATCH] drm/msm/dpu: enable cursor plane on dpu

2018-08-06 Thread skolluku
On 2018-08-03 21:07, Sean Paul wrote: On Thu, Aug 02, 2018 at 04:24:44PM +0530, Sravanthi Kollukuduru wrote: Reserve DMA pipe for cursor plane and attach it to the crtc during the initialization. Signed-off-by: Sravanthi Kollukuduru Hi Sravanthi, Thanks for sending this. I have a few comment

Re: [DPU PATCH] drm/msm: Add pm_runtime_get/put calls to dpu

2018-03-15 Thread skolluku
On 2018-03-14 20:37, Sean Paul wrote: Ensure that pm_runtime is properly referenced/unreferenced when we need it. Signed-off-by: Sean Paul --- Didn't get a response to my suggestion, so wrote the patch anyways. Thoughts? This patch looks fine for now. The plan is to deprecate the downstream

Re: [DPU PATCH] drm/msm: Add pm_runtime_get/put calls to dpu

2018-03-15 Thread skolluku
On 2018-03-15 20:12, skoll...@codeaurora.org wrote: On 2018-03-14 20:37, Sean Paul wrote: Ensure that pm_runtime is properly referenced/unreferenced when we need it. Signed-off-by: Sean Paul Reviewed-by: Sravanthi Kollukuduru --- Didn't get a response to my suggestion, so wrote the patch

Re: [DPU PATCH 1/2] dt-bindings: msm/disp: Remove hw block offset DT entries for SDM845

2018-03-18 Thread skolluku
On 2018-03-18 18:19, Rob Herring wrote: On Wed, Mar 14, 2018 at 11:21:37AM +0530, Sravanthi Kollukuduru wrote: Remove DT entries of hw block offsets and other target specific catalog information for SDM845. That is clear from the diff. The commit msg should answer why? Will update the commi

Re: [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

2018-03-20 Thread skolluku
On 2018-03-19 19:29, Sean Paul wrote: On Wed, Mar 14, 2018 at 11:21:38AM +0530, Sravanthi Kollukuduru wrote: This change adds the hardware catalog information in driver source for SDM845. This removes the current logic of dt based parsing of target catalog information. Signed-off-by: Sravanthi

Re: [Freedreno] [DPU PATCH 2/2] drm/msm: Add hardware catalog file for SDM845

2018-03-21 Thread skolluku
On 2018-03-20 20:47, Sean Paul wrote: On Tue, Mar 20, 2018 at 07:13:38PM +0530, skoll...@codeaurora.org wrote: On 2018-03-19 19:29, Sean Paul wrote: > On Wed, Mar 14, 2018 at 11:21:38AM +0530, Sravanthi Kollukuduru wrote: > > This change adds the hardware catalog information in driver source > >

Re: [DPU PATCH v2 1/2] dt-bindings: msm/disp: Remove hw block offset DT entries for SDM845

2018-04-01 Thread skolluku
On 2018-03-29 20:22, Sean Paul wrote: On Thu, Mar 29, 2018 at 03:59:24PM +0530, Sravanthi Kollukuduru wrote: Currently, the downstream driver depends on the DT file for the hardware block offsets and other target specific catalog information. To align the driver with the upstream DT design, this