[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Gert Wollny  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|REOPENED|RESOLVED

--- Comment #8 from Gert Wollny  ---
This was fixed with ad84689f737edefe.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #7 from xbx  ---
I stumbled upon this bug while testing and debugging a game using the st/nine.

And I made a tentative fix that works for me. 
(caveat: I know nothing about mesa/gallium/graphic cards, but hey..)

Here is the proposed patch:

https://github.com/xxxbxxx/Mesa-3D/commit/0722d721f8e5ec496bf8ce4591a3b8a5bf87745d

or attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #6 from xbx  ---
Created attachment 112920
  --> https://bugs.freedesktop.org/attachment.cgi?id=112920&action=edit
r600g patch to fix dropped abs() modifier on op3 alu operations.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #5 from Vic Lee  2012-03-12 06:34:57 PDT ---
Created attachment 58317
  --> https://bugs.freedesktop.org/attachment.cgi?id=58317
test program to reproduce the bug

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #4 from Vic Lee  2012-03-12 06:33:54 PDT ---
Thanks for concerning this bug. It will be great if this can be fixed at driver
level. I created a smallest possible test program which will be able to test
the shader I am having problem with.

Please see the file header for test info.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #5 from Vic Lee  2012-03-12 06:34:57 PDT ---
Created attachment 58317
  --> https://bugs.freedesktop.org/attachment.cgi?id=58317
test program to reproduce the bug

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #4 from Vic Lee  2012-03-12 06:33:54 PDT ---
Thanks for concerning this bug. It will be great if this can be fixed at driver
level. I created a smallest possible test program which will be able to test
the shader I am having problem with.

Please see the file header for test info.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Tom Stellard  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |

--- Comment #3 from Tom Stellard  2012-03-11 18:07:27 
PDT ---
The is a bug in the r600 driver.  The shader compiler should be lowering this
to the hardware equivalent of this sequence:

ABS TEMP[5], TEMP[1].
CMP TEMP[0].yz, -TEMP[5], TEMP[2]., CONST[0].xyxw

Is there a piglit test or application that is hitting this bug?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Tom Stellard  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTABUG |

--- Comment #3 from Tom Stellard  2012-03-11 18:07:27 PDT 
---
The is a bug in the r600 driver.  The shader compiler should be lowering this
to the hardware equivalent of this sequence:

ABS TEMP[5], TEMP[1].
CMP TEMP[0].yz, -TEMP[5], TEMP[2]., CONST[0].xyxw

Is there a piglit test or application that is hitting this bug?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Vic Lee  changed:

   What|Removed |Added

Summary|TGSI source register with   |Absolute modifier does not
   |absolute negative modifier  |work with 3-source TGSI
   |does not work correctly |instructions

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Vic Lee  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||NOTABUG

--- Comment #2 from Vic Lee  2012-03-11 06:47:32 UTC ---
OK I found the reference info in r600 instruction document and this is a
hardware limitation. So this probably has to be solved in higher level rather
than in driver.

Sorry for the noise.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Vic Lee  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||NOTABUG

--- Comment #2 from Vic Lee  2012-03-11 06:47:32 UTC ---
OK I found the reference info in r600 instruction document and this is a
hardware limitation. So this probably has to be solved in higher level rather
than in driver.

Sorry for the noise.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #1 from Vic Lee  2012-03-11 06:24:37 UTC ---
The issue might be related to r600_bytecode_alu_build() in r600_asm.c. In the
codes below:

if (alu->is_op3) {
// in this code branch it does not use absolute modifier at all.
} else {
...

Looks like whenever is_op3 is true (which is the case of CMP), absolute
modifier is just ignored.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

--- Comment #1 from Vic Lee  2012-03-11 06:24:37 UTC ---
The issue might be related to r600_bytecode_alu_build() in r600_asm.c. In the
codes below:

if (alu->is_op3) {
// in this code branch it does not use absolute modifier at all.
} else {
...

Looks like whenever is_op3 is true (which is the case of CMP), absolute
modifier is just ignored.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.

[Bug 47201] Absolute modifier does not work with 3-source TGSI instructions

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=47201

Vic Lee  changed:

   What|Removed |Added

Summary|TGSI source register with   |Absolute modifier does not
   |absolute negative modifier  |work with 3-source TGSI
   |does not work correctly |instructions

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel