[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

GitLab Migration User  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |MOVED

--- Comment #10 from GitLab Migration User  ---
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been
closed from further activity.

You can subscribe and participate further through the new bug through this link
to our GitLab instance: https://gitlab.freedesktop.org/mesa/mesa/issues/483.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #9 from Fredrik H?glund  ---
(In reply to comment #8)
> I've been running your patches for two weeks now forward porting them to
> current git master.  FlightGear has been perfectly stable with them.
> 
> Unfortunatley I now get compilation errors and since I don't know the code
> base at all they are kind of hard to fix. See any chance you can commit them
> to master?

Yeah, I will rebase them and see about getting them into master.

Thanks for testing!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #8 from nine at detonation.org ---
I've been running your patches for two weeks now forward porting them to
current git master.  FlightGear has been perfectly stable with them.

Unfortunatley I now get compilation errors and since I don't know the code base
at all they are kind of hard to fix. See any chance you can commit them to
master?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #7 from nine at detonation.org ---
Created attachment 94028
  --> https://bugs.freedesktop.org/attachment.cgi?id=94028=edit
consolidated and rebased patches

I ported your patches to current master and with them had a 90 minute flight
without incidents while without them current FlightGear would currently crash
within a minute. Thanks for the work!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #6 from Fredrik H?glund  ---
Created attachment 93419
  --> https://bugs.freedesktop.org/attachment.cgi?id=93419=edit
patch3

Note that this patch will not apply on the master branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #5 from Fredrik H?glund  ---
The first patch might fix segfaults in both functions.
The second patch would only fix a segfault in _save_VertexAttrib4fvARB.

I'm going to attach a third patch that fixes yet another problem with display
lists that might affect FlightGear/openscenegraph.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #4 from nine at detonation.org ---
I did 4 test runs today with the FlightGear version of the day I made the bug
report. The first two runs I did with current Mesa and ended in segfaults in
_save_VertexAttrib4fvARB. The other two were after applying your patches and
were successful.

Can your patches fix segfaults in _save_VertexAttrib4fvARB as well or just in
_save_Normal3fv? If they fix both, I'll conduct more tests to see if the
problem really is fixed. If not, I'll have to re-establish the base line,
meaning I'll have to test until I can reproduce the _save_Normal3fv again.

Please note that I haven't seen any segfaults with a more recent FlightGear
version. There were a couple of commits that might have touched the code
leading to the application problem. If it helps you confirming your suspisions,
I could dig further to identify the exact commit.

All in all things look quite well. Thanks for looking into this!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #3 from Fredrik H?glund  ---
This can be a case of the application passing an invalid pointer to
glNormalPointer(), but it's also possible that it's an issue with
display list compilation in mesa.

Do the patches I attached to the bug report fix the problem?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #2 from Fredrik H?glund  ---
Created attachment 92731
  --> https://bugs.freedesktop.org/attachment.cgi?id=92731=edit
patch2

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: 

[Bug 73504] Segfault in _save_Normal3fv running FlightGear

[bugzilla-dae...@freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=73504

--- Comment #1 from Fredrik H?glund  ---
Created attachment 92730
  --> https://bugs.freedesktop.org/attachment.cgi?id=92730=edit
patch1

-- 
You are receiving this mail because:
You are the assignee for the bug.
-- next part --
An HTML attachment was scrubbed...
URL: