[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Michel Dänzer
On 16/08/16 04:00 PM, Deng, Emily wrote: >> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of >> Michel D?nzer >> Sent: Tuesday, August 16, 2016 2:43 PM >> On 16/08/16 03:28 PM, Deng, Emily wrote: From: Michel Dänzer [mailto:michel at daenzer.net] Sent:

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Michel Dänzer
On 16/08/16 03:28 PM, Deng, Emily wrote: >> From: Michel Dänzer [mailto:michel at daenzer.net] >> Sent: Tuesday, August 16, 2016 12:01 PM >> On 16/08/16 12:49 PM, Deng, Emily wrote: >>> Hi Michel, Thanks, I still couldn't see the issue that use a variable >>> to calculate the vblank count when

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Michel Dänzer
On 16/08/16 12:49 PM, Deng, Emily wrote: > Hi Michel, Thanks, I still couldn't see the issue that use a variable > to calculate the vblank count when vsync timer interrupt occurs. I > just think it only emulates the hardware behavior. And the code > change will only in virtual display files which

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Michel Dänzer
On 15/08/16 03:45 PM, Deng, Emily wrote: >> From: Michel Dänzer [mailto:michel at daenzer.net] >> Sent: Monday, August 15, 2016 9:46 AM >> On 11/08/16 12:46 PM, Emily Deng wrote: >>> The adev->ddev->vblank[crtc].count couldn't be used here, so define >>> another variable to compute the vblank

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Deng, Emily
Hi Michel and Daniel, I just tryed Michel's advice: return 0 in vblank_get_counter, and set dev->max_vblank_count = 0 , and found the adev->ddev->vblank[crtc].count also can increase which makes the 3D app with vsync can work properly as well. But I don't know the principle. Anyway I will

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Daniel Vetter
On Tue, Aug 16, 2016 at 03:43:07PM +0900, Michel Dänzer wrote: > On 16/08/16 03:28 PM, Deng, Emily wrote: > >> From: Michel Dänzer [mailto:michel at daenzer.net] > >> Sent: Tuesday, August 16, 2016 12:01 PM > >> On 16/08/16 12:49 PM, Deng, Emily wrote: > >>> Hi Michel, Thanks, I still couldn't

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Deng, Emily
Hi Michel and Daniel, Return the fake vblank count or return 0 in vblank_get_counter is only the virtual display feature's behavior, and the virtual display feature need to be enabled by set module parameter, so won't affect normal case. And I think the vblank counter will be increased

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Deng, Emily
> -Original Message- > From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf Of > Michel D?nzer > Sent: Tuesday, August 16, 2016 2:43 PM > To: Deng, Emily > Cc: dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: For

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Deng, Emily
> -Original Message- > From: Michel Dänzer [mailto:michel at daenzer.net] > Sent: Tuesday, August 16, 2016 12:01 PM > To: Deng, Emily > Cc: dri-devel at lists.freedesktop.org; amd-gfx at lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: For virtual_display feature, define a >

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-16 Thread Deng, Emily
Hi Michel, Thanks, I still couldn't see the issue that use a variable to calculate the vblank count when vsync timer interrupt occurs. I just think it only emulates the hardware behavior. And the code change will only in virtual display files which won't touch drm layer. I incline to not

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-15 Thread Michel Dänzer
[ Adding the dri-devel list ] On 11/08/16 12:46 PM, Emily Deng wrote: > The adev->ddev->vblank[crtc].count couldn't be used here, so define another > variable to compute the vblank count. > > Signed-off-by: Emily Deng [...] > diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c >

[PATCH] drm/amdgpu: For virtual_display feature, define a variable for vblank count of cpu vsync timer.

2016-08-15 Thread Deng, Emily
> -Original Message- > From: Michel Dänzer [mailto:michel at daenzer.net] > Sent: Monday, August 15, 2016 9:46 AM > To: Deng, Emily > Cc: amd-gfx at lists.freedesktop.org; dri-devel at lists.freedesktop.org > Subject: Re: [PATCH] drm/amdgpu: For virtual_display feature, define a >