Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Neil Armstrong
Hi Hans, On 13/08/2019 13:43, Hans Verkuil wrote: > On 8/13/19 11:32 AM, Hans Verkuil wrote: >> When testing CEC on the AML-S905X-CC board I noticed that the CEC physical >> address was not invalidated when the HDMI cable was unplugged. Some more >> digging showed that meson uses meson_dw_hdmi.c

Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Hans Verkuil
On 8/13/19 11:32 AM, Hans Verkuil wrote: > When testing CEC on the AML-S905X-CC board I noticed that the CEC physical > address was not invalidated when the HDMI cable was unplugged. Some more > digging showed that meson uses meson_dw_hdmi.c to handle the HPD. > > Both dw_hdmi_irq() and

Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Jonas Karlman
On 2019-08-13 13:27, Hans Verkuil wrote: > On 8/13/19 12:18 PM, Jonas Karlman wrote: >> As an alternative I have a patch [1] to submit that moves >> cec_notifier_phys_addr_invalidate() call >> from dw_hdmi_irq() to dw_hdmi_connector_detect() in order to address an >> issue with >> stale CEC phys

Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Hans Verkuil
On 8/13/19 12:18 PM, Jonas Karlman wrote: > As an alternative I have a patch [1] to submit that moves > cec_notifier_phys_addr_invalidate() call > from dw_hdmi_irq() to dw_hdmi_connector_detect() in order to address an issue > with > stale CEC phys addr and stale EDID/ELD data after TV or AVR

Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Hans Verkuil
Hi Jonas, On 8/13/19 12:18 PM, Jonas Karlman wrote: > As an alternative I have a patch [1] to submit that moves > cec_notifier_phys_addr_invalidate() call > from dw_hdmi_irq() to dw_hdmi_connector_detect() in order to address an issue > with > stale CEC phys addr and stale EDID/ELD data after

Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Jonas Karlman
As an alternative I have a patch [1] to submit that moves cec_notifier_phys_addr_invalidate() call from dw_hdmi_irq() to dw_hdmi_connector_detect() in order to address an issue with stale CEC phys addr and stale EDID/ELD data after TV or AVR uses a 100ms HPD pulse to signal EDID has changed,

Re: [PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Hans Verkuil
CC Dariusz as well, since this issue was discovered when testing his CEC patches. Regards, Hans On 8/13/19 11:32 AM, Hans Verkuil wrote: > When testing CEC on the AML-S905X-CC board I noticed that the CEC physical > address was not invalidated when the HDMI cable was unplugged. Some

[PATCH] drm/bridge: dw-hdmi: move cec PA invalidation to dw_hdmi_setup_rx_sense()

2019-08-13 Thread Hans Verkuil
When testing CEC on the AML-S905X-CC board I noticed that the CEC physical address was not invalidated when the HDMI cable was unplugged. Some more digging showed that meson uses meson_dw_hdmi.c to handle the HPD. Both dw_hdmi_irq() and dw_hdmi_top_thread_irq() (in meson_dw_hdmi.c) call the