Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-05-08 Thread Noralf Trønnes
Den 08.05.2019 08.33, skrev Oleksandr Andrushchenko: > On 5/7/19 7:04 PM, Noralf Trønnes wrote: >> Hi, >> >> Could someone please have a look at this one? >> >> Noralf. >> >> Den 26.04.2019 14.47, skrev Noralf Trønnes: >>> The logic for freeing an imported buffer with a virtual address is >>>

Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-05-08 Thread Oleksandr Andrushchenko
On 5/7/19 7:04 PM, Noralf Trønnes wrote: Hi, Could someone please have a look at this one? Noralf. Den 26.04.2019 14.47, skrev Noralf Trønnes: The logic for freeing an imported buffer with a virtual address is broken. It will free the buffer instead of unmapping the dma buf. Fix by reversing

Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-05-07 Thread Noralf Trønnes
Hi, Could someone please have a look at this one? Noralf. Den 26.04.2019 14.47, skrev Noralf Trønnes: > The logic for freeing an imported buffer with a virtual address is > broken. It will free the buffer instead of unmapping the dma buf. > Fix by reversing the if ladder and first check if the

Re: [PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-04-26 Thread Daniel Vetter
On Fri, Apr 26, 2019 at 2:48 PM Noralf Trønnes wrote: > > The logic for freeing an imported buffer with a virtual address is > broken. It will free the buffer instead of unmapping the dma buf. > Fix by reversing the if ladder and first check if the buffer is imported. > > Fixes: b9068cde51ee

[PATCH] drm/cma-helper: Fix drm_gem_cma_free_object()

2019-04-26 Thread Noralf Trønnes
The logic for freeing an imported buffer with a virtual address is broken. It will free the buffer instead of unmapping the dma buf. Fix by reversing the if ladder and first check if the buffer is imported. Fixes: b9068cde51ee ("drm/cma-helper: Add DRM_GEM_CMA_VMAP_DRIVER_OPS") Cc: