Re: [PATCH] drm/todo: Add idr_init_base todo
On Mon, Feb 19, 2018 at 03:57:08PM +0100, Daniel Vetter wrote: > Suggested-by: Chris Wilson > Cc: Chris Wilson > Acked-by: Chris Wilson > Signed-off-by: Daniel Vetter And applied. -Daniel > --- > Documentation/gpu/todo.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 1e593370f64f..1a0a413eeced 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -212,6 +212,16 @@ probably use drm_fb_helper_fbdev_teardown(). > > Contact: Maintainer of the driver you plan to convert > > +idr_init_base() > +--- > + > +DRM core&drivers uses a lot of idr (integer lookup directories) for mapping > +userspace IDs to internal objects, and in most places ID=0 means NULL and > hence > +is never used. Switching to idr_init_base() for these would make the idr more > +efficient. > + > +Contact: Daniel Vetter > + > Core refactorings > = > > -- > 2.15.1 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
Re: [PATCH] drm/todo: Add idr_init_base todo
On Mon, Feb 19, 2018 at 9:57 AM, Daniel Vetter wrote: > Suggested-by: Chris Wilson > Cc: Chris Wilson > Acked-by: Chris Wilson > Signed-off-by: Daniel Vetter Reviewed-by: Alex Deucher > --- > Documentation/gpu/todo.rst | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 1e593370f64f..1a0a413eeced 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -212,6 +212,16 @@ probably use drm_fb_helper_fbdev_teardown(). > > Contact: Maintainer of the driver you plan to convert > > +idr_init_base() > +--- > + > +DRM core&drivers uses a lot of idr (integer lookup directories) for mapping > +userspace IDs to internal objects, and in most places ID=0 means NULL and > hence > +is never used. Switching to idr_init_base() for these would make the idr more > +efficient. > + > +Contact: Daniel Vetter > + > Core refactorings > = > > -- > 2.15.1 > > ___ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
[PATCH] drm/todo: Add idr_init_base todo
Suggested-by: Chris Wilson Cc: Chris Wilson Acked-by: Chris Wilson Signed-off-by: Daniel Vetter --- Documentation/gpu/todo.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index 1e593370f64f..1a0a413eeced 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -212,6 +212,16 @@ probably use drm_fb_helper_fbdev_teardown(). Contact: Maintainer of the driver you plan to convert +idr_init_base() +--- + +DRM core&drivers uses a lot of idr (integer lookup directories) for mapping +userspace IDs to internal objects, and in most places ID=0 means NULL and hence +is never used. Switching to idr_init_base() for these would make the idr more +efficient. + +Contact: Daniel Vetter + Core refactorings = -- 2.15.1 ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
