Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-10 Thread Stefan Wahren
Hi Marek,

Am 02.07.20 um 08:58 schrieb Marek Szyprowski:
> On 01.07.2020 20:49, Stefan Wahren wrote:
>> Am 01.07.20 um 09:39 schrieb Marek Szyprowski:
>>> card->owner is a required property and since commit 81033c6b584b ("ALSA:
>>> core: Warn on empty module") a warning is issued if it is empty. Fix lack
>>> of it. This fixes following warning observed on RaspberryPi 3B board
>>> with ARM 32bit kernel and multi_v7_defconfig:
>>>
>>> [ cut here ]
>>> WARNING: CPU: 1 PID: 210 at sound/core/init.c:207 snd_card_new+0x378/0x398 
>>> [snd]
>>> Modules linked in: vc4(+) snd_soc_core ac97_bus snd_pcm_dmaengine bluetooth 
>>> snd_pcm snd_timer crc32_arm_ce raspberrypi_hwmon snd soundcore ecdh_generic 
>>> ecc bcm2835_thermal phy_generic
>>> CPU: 1 PID: 210 Comm: systemd-udevd Not tainted 
>>> 5.8.0-rc1-00027-g81033c6b584b #1087
>>> Hardware name: BCM2835
>>> [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
>>> [] (show_stack) from [] (dump_stack+0xd4/0xe8)
>>> [] (dump_stack) from [] (__warn+0xdc/0xf4)
>>> [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8)
>>> [] (warn_slowpath_fmt) from [] 
>>> (snd_card_new+0x378/0x398 [snd])
>>> [] (snd_card_new [snd]) from [] 
>>> (snd_soc_bind_card+0x280/0x99c [snd_soc_core])
>>> [] (snd_soc_bind_card [snd_soc_core]) from [] 
>>> (devm_snd_soc_register_card+0x34/0x6c [snd_soc_core])
>>> [] (devm_snd_soc_register_card [snd_soc_core]) from [] 
>>> (vc4_hdmi_bind+0x43c/0x5f4 [vc4])
>>> [] (vc4_hdmi_bind [vc4]) from [] 
>>> (component_bind_all+0xec/0x24c)
>>> [] (component_bind_all) from [] 
>>> (vc4_drm_bind+0xd4/0x174 [vc4])
>>> [] (vc4_drm_bind [vc4]) from [] 
>>> (try_to_bring_up_master+0x160/0x1b0)
>>> [] (try_to_bring_up_master) from [] 
>>> (component_master_add_with_match+0xd0/0x104)
>>> [] (component_master_add_with_match) from [] 
>>> (vc4_platform_drm_probe+0x9c/0xbc [vc4])
>>> [] (vc4_platform_drm_probe [vc4]) from [] 
>>> (platform_drv_probe+0x6c/0xa4)
>>> [] (platform_drv_probe) from [] 
>>> (really_probe+0x210/0x350)
>>> [] (really_probe) from [] 
>>> (driver_probe_device+0x5c/0xb4)
>>> [] (driver_probe_device) from [] 
>>> (device_driver_attach+0x58/0x60)
>>> [] (device_driver_attach) from [] 
>>> (__driver_attach+0x80/0xbc)
>>> [] (__driver_attach) from [] 
>>> (bus_for_each_dev+0x68/0xb4)
>>> [] (bus_for_each_dev) from [] 
>>> (bus_add_driver+0x130/0x1e8)
>>> [] (bus_add_driver) from [] (driver_register+0x78/0x110)
>>> [] (driver_register) from [] 
>>> (do_one_initcall+0x50/0x220)
>>> [] (do_one_initcall) from [] (do_init_module+0x60/0x210)
>>> [] (do_init_module) from [] (load_module+0x1e34/0x2338)
>>> [] (load_module) from [] (sys_finit_module+0xac/0xbc)
>>> [] (sys_finit_module) from [] 
>>> (ret_fast_syscall+0x0/0x54)
>>> Exception stack(0xeded9fa8 to 0xeded9ff0)
>>> ...
>>> ---[ end trace 6414689569c2bc08 ]---
>>>
>>> Suggested-by: Takashi Iwai 
>>> Signed-off-by: Marek Szyprowski 
Tested-by: Stefan Wahren 
>> thanks for this patch. Any chance for a fixes tag here?
> Fixes: bb7d78568814 ("drm/vc4: Add HDMI audio support")
Thanks
>
> Best regards
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-02 Thread Marek Szyprowski
On 01.07.2020 20:49, Stefan Wahren wrote:
> Am 01.07.20 um 09:39 schrieb Marek Szyprowski:
>> card->owner is a required property and since commit 81033c6b584b ("ALSA:
>> core: Warn on empty module") a warning is issued if it is empty. Fix lack
>> of it. This fixes following warning observed on RaspberryPi 3B board
>> with ARM 32bit kernel and multi_v7_defconfig:
>>
>> [ cut here ]
>> WARNING: CPU: 1 PID: 210 at sound/core/init.c:207 snd_card_new+0x378/0x398 
>> [snd]
>> Modules linked in: vc4(+) snd_soc_core ac97_bus snd_pcm_dmaengine bluetooth 
>> snd_pcm snd_timer crc32_arm_ce raspberrypi_hwmon snd soundcore ecdh_generic 
>> ecc bcm2835_thermal phy_generic
>> CPU: 1 PID: 210 Comm: systemd-udevd Not tainted 
>> 5.8.0-rc1-00027-g81033c6b584b #1087
>> Hardware name: BCM2835
>> [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
>> [] (show_stack) from [] (dump_stack+0xd4/0xe8)
>> [] (dump_stack) from [] (__warn+0xdc/0xf4)
>> [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8)
>> [] (warn_slowpath_fmt) from [] (snd_card_new+0x378/0x398 
>> [snd])
>> [] (snd_card_new [snd]) from [] 
>> (snd_soc_bind_card+0x280/0x99c [snd_soc_core])
>> [] (snd_soc_bind_card [snd_soc_core]) from [] 
>> (devm_snd_soc_register_card+0x34/0x6c [snd_soc_core])
>> [] (devm_snd_soc_register_card [snd_soc_core]) from [] 
>> (vc4_hdmi_bind+0x43c/0x5f4 [vc4])
>> [] (vc4_hdmi_bind [vc4]) from [] 
>> (component_bind_all+0xec/0x24c)
>> [] (component_bind_all) from [] (vc4_drm_bind+0xd4/0x174 
>> [vc4])
>> [] (vc4_drm_bind [vc4]) from [] 
>> (try_to_bring_up_master+0x160/0x1b0)
>> [] (try_to_bring_up_master) from [] 
>> (component_master_add_with_match+0xd0/0x104)
>> [] (component_master_add_with_match) from [] 
>> (vc4_platform_drm_probe+0x9c/0xbc [vc4])
>> [] (vc4_platform_drm_probe [vc4]) from [] 
>> (platform_drv_probe+0x6c/0xa4)
>> [] (platform_drv_probe) from [] 
>> (really_probe+0x210/0x350)
>> [] (really_probe) from [] (driver_probe_device+0x5c/0xb4)
>> [] (driver_probe_device) from [] 
>> (device_driver_attach+0x58/0x60)
>> [] (device_driver_attach) from [] 
>> (__driver_attach+0x80/0xbc)
>> [] (__driver_attach) from [] (bus_for_each_dev+0x68/0xb4)
>> [] (bus_for_each_dev) from [] 
>> (bus_add_driver+0x130/0x1e8)
>> [] (bus_add_driver) from [] (driver_register+0x78/0x110)
>> [] (driver_register) from [] (do_one_initcall+0x50/0x220)
>> [] (do_one_initcall) from [] (do_init_module+0x60/0x210)
>> [] (do_init_module) from [] (load_module+0x1e34/0x2338)
>> [] (load_module) from [] (sys_finit_module+0xac/0xbc)
>> [] (sys_finit_module) from [] (ret_fast_syscall+0x0/0x54)
>> Exception stack(0xeded9fa8 to 0xeded9ff0)
>> ...
>> ---[ end trace 6414689569c2bc08 ]---
>>
>> Suggested-by: Takashi Iwai 
>> Signed-off-by: Marek Szyprowski 
> thanks for this patch. Any chance for a fixes tag here?

Fixes: bb7d78568814 ("drm/vc4: Add HDMI audio support")

Best regards
-- 
Marek Szyprowski, PhD
Samsung R Institute Poland

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


Re: [PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-01 Thread Stefan Wahren
Hi Marek,

Am 01.07.20 um 09:39 schrieb Marek Szyprowski:
> card->owner is a required property and since commit 81033c6b584b ("ALSA:
> core: Warn on empty module") a warning is issued if it is empty. Fix lack
> of it. This fixes following warning observed on RaspberryPi 3B board
> with ARM 32bit kernel and multi_v7_defconfig:
>
> [ cut here ]
> WARNING: CPU: 1 PID: 210 at sound/core/init.c:207 snd_card_new+0x378/0x398 
> [snd]
> Modules linked in: vc4(+) snd_soc_core ac97_bus snd_pcm_dmaengine bluetooth 
> snd_pcm snd_timer crc32_arm_ce raspberrypi_hwmon snd soundcore ecdh_generic 
> ecc bcm2835_thermal phy_generic
> CPU: 1 PID: 210 Comm: systemd-udevd Not tainted 5.8.0-rc1-00027-g81033c6b584b 
> #1087
> Hardware name: BCM2835
> [] (unwind_backtrace) from [] (show_stack+0x10/0x14)
> [] (show_stack) from [] (dump_stack+0xd4/0xe8)
> [] (dump_stack) from [] (__warn+0xdc/0xf4)
> [] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8)
> [] (warn_slowpath_fmt) from [] (snd_card_new+0x378/0x398 
> [snd])
> [] (snd_card_new [snd]) from [] 
> (snd_soc_bind_card+0x280/0x99c [snd_soc_core])
> [] (snd_soc_bind_card [snd_soc_core]) from [] 
> (devm_snd_soc_register_card+0x34/0x6c [snd_soc_core])
> [] (devm_snd_soc_register_card [snd_soc_core]) from [] 
> (vc4_hdmi_bind+0x43c/0x5f4 [vc4])
> [] (vc4_hdmi_bind [vc4]) from [] 
> (component_bind_all+0xec/0x24c)
> [] (component_bind_all) from [] (vc4_drm_bind+0xd4/0x174 
> [vc4])
> [] (vc4_drm_bind [vc4]) from [] 
> (try_to_bring_up_master+0x160/0x1b0)
> [] (try_to_bring_up_master) from [] 
> (component_master_add_with_match+0xd0/0x104)
> [] (component_master_add_with_match) from [] 
> (vc4_platform_drm_probe+0x9c/0xbc [vc4])
> [] (vc4_platform_drm_probe [vc4]) from [] 
> (platform_drv_probe+0x6c/0xa4)
> [] (platform_drv_probe) from [] (really_probe+0x210/0x350)
> [] (really_probe) from [] (driver_probe_device+0x5c/0xb4)
> [] (driver_probe_device) from [] 
> (device_driver_attach+0x58/0x60)
> [] (device_driver_attach) from [] 
> (__driver_attach+0x80/0xbc)
> [] (__driver_attach) from [] (bus_for_each_dev+0x68/0xb4)
> [] (bus_for_each_dev) from [] (bus_add_driver+0x130/0x1e8)
> [] (bus_add_driver) from [] (driver_register+0x78/0x110)
> [] (driver_register) from [] (do_one_initcall+0x50/0x220)
> [] (do_one_initcall) from [] (do_init_module+0x60/0x210)
> [] (do_init_module) from [] (load_module+0x1e34/0x2338)
> [] (load_module) from [] (sys_finit_module+0xac/0xbc)
> [] (sys_finit_module) from [] (ret_fast_syscall+0x0/0x54)
> Exception stack(0xeded9fa8 to 0xeded9ff0)
> ...
> ---[ end trace 6414689569c2bc08 ]---
>
> Suggested-by: Takashi Iwai 
> Signed-off-by: Marek Szyprowski 
thanks for this patch. Any chance for a fixes tag here?
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel


[PATCH] drm/vc4/vc4_hdmi: fill ASoC card owner

2020-07-01 Thread Marek Szyprowski
card->owner is a required property and since commit 81033c6b584b ("ALSA:
core: Warn on empty module") a warning is issued if it is empty. Fix lack
of it. This fixes following warning observed on RaspberryPi 3B board
with ARM 32bit kernel and multi_v7_defconfig:

[ cut here ]
WARNING: CPU: 1 PID: 210 at sound/core/init.c:207 snd_card_new+0x378/0x398 [snd]
Modules linked in: vc4(+) snd_soc_core ac97_bus snd_pcm_dmaengine bluetooth 
snd_pcm snd_timer crc32_arm_ce raspberrypi_hwmon snd soundcore ecdh_generic ecc 
bcm2835_thermal phy_generic
CPU: 1 PID: 210 Comm: systemd-udevd Not tainted 5.8.0-rc1-00027-g81033c6b584b 
#1087
Hardware name: BCM2835
[] (unwind_backtrace) from [] (show_stack+0x10/0x14)
[] (show_stack) from [] (dump_stack+0xd4/0xe8)
[] (dump_stack) from [] (__warn+0xdc/0xf4)
[] (__warn) from [] (warn_slowpath_fmt+0xb0/0xb8)
[] (warn_slowpath_fmt) from [] (snd_card_new+0x378/0x398 
[snd])
[] (snd_card_new [snd]) from [] 
(snd_soc_bind_card+0x280/0x99c [snd_soc_core])
[] (snd_soc_bind_card [snd_soc_core]) from [] 
(devm_snd_soc_register_card+0x34/0x6c [snd_soc_core])
[] (devm_snd_soc_register_card [snd_soc_core]) from [] 
(vc4_hdmi_bind+0x43c/0x5f4 [vc4])
[] (vc4_hdmi_bind [vc4]) from [] 
(component_bind_all+0xec/0x24c)
[] (component_bind_all) from [] (vc4_drm_bind+0xd4/0x174 
[vc4])
[] (vc4_drm_bind [vc4]) from [] 
(try_to_bring_up_master+0x160/0x1b0)
[] (try_to_bring_up_master) from [] 
(component_master_add_with_match+0xd0/0x104)
[] (component_master_add_with_match) from [] 
(vc4_platform_drm_probe+0x9c/0xbc [vc4])
[] (vc4_platform_drm_probe [vc4]) from [] 
(platform_drv_probe+0x6c/0xa4)
[] (platform_drv_probe) from [] (really_probe+0x210/0x350)
[] (really_probe) from [] (driver_probe_device+0x5c/0xb4)
[] (driver_probe_device) from [] 
(device_driver_attach+0x58/0x60)
[] (device_driver_attach) from [] 
(__driver_attach+0x80/0xbc)
[] (__driver_attach) from [] (bus_for_each_dev+0x68/0xb4)
[] (bus_for_each_dev) from [] (bus_add_driver+0x130/0x1e8)
[] (bus_add_driver) from [] (driver_register+0x78/0x110)
[] (driver_register) from [] (do_one_initcall+0x50/0x220)
[] (do_one_initcall) from [] (do_init_module+0x60/0x210)
[] (do_init_module) from [] (load_module+0x1e34/0x2338)
[] (load_module) from [] (sys_finit_module+0xac/0xbc)
[] (sys_finit_module) from [] (ret_fast_syscall+0x0/0x54)
Exception stack(0xeded9fa8 to 0xeded9ff0)
...
---[ end trace 6414689569c2bc08 ]---

Suggested-by: Takashi Iwai 
Signed-off-by: Marek Szyprowski 
---
 drivers/gpu/drm/vc4/vc4_hdmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
index 625bfcf52dc4..bdcc54c87d7e 100644
--- a/drivers/gpu/drm/vc4/vc4_hdmi.c
+++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
@@ -1117,6 +1117,7 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *hdmi)
card->num_links = 1;
card->name = "vc4-hdmi";
card->dev = dev;
+   card->owner = THIS_MODULE;
 
/*
 * Be careful, snd_soc_register_card() calls dev_set_drvdata() and
-- 
2.17.1

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel