[PATCH] drm: Reject page_flip for !DRIVER_MODESET

2016-08-20 Thread Daniel Vetter
Somehow this one slipped through, which means drivers without modeset
support can be oopsed (since those also don't call
drm_mode_config_init, which means the crtc lookup will chase an
uninitalized idr).

Reported-by: Alexander Potapenko 
Cc: Alexander Potapenko 
Cc: stable at vger.kernel.org
Signed-off-by: Daniel Vetter 
---
 drivers/gpu/drm/drm_crtc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index 5f470a2b2061..0fad433f4d2d 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1912,6 +1912,9 @@ int drm_mode_page_flip_ioctl(struct drm_device *dev,
struct drm_pending_vblank_event *e = NULL;
int ret = -EINVAL;

+   if (!drm_core_check_feature(dev, DRIVER_MODESET))
+   return -EINVAL;
+
if (page_flip->flags & ~DRM_MODE_PAGE_FLIP_FLAGS ||
page_flip->reserved != 0)
return -EINVAL;
-- 
2.8.1



[PATCH] drm: Reject page_flip for !DRIVER_MODESET

2016-08-20 Thread Chris Wilson
On Sat, Aug 20, 2016 at 12:22:11PM +0200, Daniel Vetter wrote:
> Somehow this one slipped through, which means drivers without modeset
> support can be oopsed (since those also don't call
> drm_mode_config_init, which means the crtc lookup will chase an
> uninitalized idr).
> 
> Reported-by: Alexander Potapenko 
> Cc: Alexander Potapenko 
> Cc: stable at vger.kernel.org
> Signed-off-by: Daniel Vetter 

That explains the oops.

Reviewed-by: Chris Wilson 
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre