[PATCH] video: drm: Add match table for drm platform device

2012-09-19 Thread Paul Menzel 
Dear Leela,


thank you for your patch.


Am Mittwoch, den 19.09.2012, 00:05 +0530 schrieb Leela Krishna Amudala:
> This patch adds match table for drm platform device.

Please drop that line as it is the same as in the subject line.

It would be better,

1. if you explain for what this will be used,
2. if this can be tested somehow,
3. if this fixes a bug,
4. why CONFIG_OF is needed.

> Signed-off-by: Leela Krishna Amudala 
> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.c |9 +
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c 
> b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index d070719..18abdcc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -294,12 +294,21 @@ static int exynos_drm_platform_remove(struct 
> platform_device *pdev)
>   return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id drm_device_dt_match[] = {
> + { .compatible = "samsung,exynos-drm-device"},
> + {},
> +};
> +MODULE_DEVICE_TABLE(of, drm_device_dt_match);
> +#endif
> +
>  static struct platform_driver exynos_drm_platform_driver = {
>   .probe  = exynos_drm_platform_probe,
>   .remove = __devexit_p(exynos_drm_platform_remove),
>   .driver = {
>   .owner  = THIS_MODULE,
>   .name   = "exynos-drm",
> + .of_match_table = of_match_ptr(drm_device_dt_match),
>   },
>  };


Thanks,

Paul
-- next part --
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL:

[PATCH] video: drm: Add match table for drm platform device

2012-09-19 Thread Leela Krishna Amudala 
This patch adds match table for drm platform device.

Signed-off-by: Leela Krishna Amudala 
---
 drivers/gpu/drm/exynos/exynos_drm_drv.c |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c 
b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index d070719..18abdcc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -294,12 +294,21 @@ static int exynos_drm_platform_remove(struct 
platform_device *pdev)
return 0;
 }

+#ifdef CONFIG_OF
+static const struct of_device_id drm_device_dt_match[] = {
+   { .compatible = "samsung,exynos-drm-device"},
+   {},
+};
+MODULE_DEVICE_TABLE(of, drm_device_dt_match);
+#endif
+
 static struct platform_driver exynos_drm_platform_driver = {
.probe  = exynos_drm_platform_probe,
.remove = __devexit_p(exynos_drm_platform_remove),
.driver = {
.owner  = THIS_MODULE,
.name   = "exynos-drm",
+   .of_match_table = of_match_ptr(drm_device_dt_match),
},
 };

-- 
1.7.0.4

Re: [PATCH] video: drm: Add match table for drm platform device

2012-09-19 Thread Paul Menzel 
Dear Leela,


thank you for your patch.


Am Mittwoch, den 19.09.2012, 00:05 +0530 schrieb Leela Krishna Amudala:
 This patch adds match table for drm platform device.

Please drop that line as it is the same as in the subject line.

It would be better,

1. if you explain for what this will be used,
2. if this can be tested somehow,
3. if this fixes a bug,
4. why CONFIG_OF is needed.

 Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
 ---
  drivers/gpu/drm/exynos/exynos_drm_drv.c |9 +
  1 files changed, 9 insertions(+), 0 deletions(-)
 
 diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c 
 b/drivers/gpu/drm/exynos/exynos_drm_drv.c
 index d070719..18abdcc 100644
 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
 +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
 @@ -294,12 +294,21 @@ static int exynos_drm_platform_remove(struct 
 platform_device *pdev)
   return 0;
  }
  
 +#ifdef CONFIG_OF
 +static const struct of_device_id drm_device_dt_match[] = {
 + { .compatible = samsung,exynos-drm-device},
 + {},
 +};
 +MODULE_DEVICE_TABLE(of, drm_device_dt_match);
 +#endif
 +
  static struct platform_driver exynos_drm_platform_driver = {
   .probe  = exynos_drm_platform_probe,
   .remove = __devexit_p(exynos_drm_platform_remove),
   .driver = {
   .owner  = THIS_MODULE,
   .name   = exynos-drm,
 + .of_match_table = of_match_ptr(drm_device_dt_match),
   },
  };


Thanks,

Paul


signature.asc
Description: This is a digitally signed message part
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] video: drm: Add match table for drm platform device

2012-09-18 Thread Leela Krishna Amudala 
This patch adds match table for drm platform device.

Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com
---
 drivers/gpu/drm/exynos/exynos_drm_drv.c |9 +
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c 
b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index d070719..18abdcc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -294,12 +294,21 @@ static int exynos_drm_platform_remove(struct 
platform_device *pdev)
return 0;
 }
 
+#ifdef CONFIG_OF
+static const struct of_device_id drm_device_dt_match[] = {
+   { .compatible = samsung,exynos-drm-device},
+   {},
+};
+MODULE_DEVICE_TABLE(of, drm_device_dt_match);
+#endif
+
 static struct platform_driver exynos_drm_platform_driver = {
.probe  = exynos_drm_platform_probe,
.remove = __devexit_p(exynos_drm_platform_remove),
.driver = {
.owner  = THIS_MODULE,
.name   = exynos-drm,
+   .of_match_table = of_match_ptr(drm_device_dt_match),
},
 };
 
-- 
1.7.0.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel