[PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Daniel Vetter
On Wed, May 23, 2012 at 10:37:58AM +0200, Lars-Peter Clausen wrote: > [...] > >>> + > >>> +static int imx_drm_gem_mmap_buffer(struct file *filp, > >>> + struct vm_area_struct *vma) > >>> +{ > >>> + struct drm_gem_object *obj = filp->private_data; > >>> + struct

[PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Lars-Peter Clausen
[...] >>> + >>> +static int imx_drm_gem_mmap_buffer(struct file *filp, >>> + struct vm_area_struct *vma) >>> +{ >>> + struct drm_gem_object *obj = filp->private_data; >>> + struct imx_drm_gem_obj *imx_drm_gem_obj = to_imx_drm_gem_obj(obj); >>> + struct

[PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Sascha Hauer
Hi Rob, On Tue, May 22, 2012 at 03:28:20PM -0600, Rob Clark wrote: > just a few comments from a cursory review.. I need a bit more time > for a more in-depth review but that won't be tonight so I thought I'd > send what I have so far.. Thanks for this. > > +++ b/drivers/gpu/drm/imx/Kconfig > >

Re: [PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Sascha Hauer
Hi Rob, On Tue, May 22, 2012 at 03:28:20PM -0600, Rob Clark wrote: just a few comments from a cursory review.. I need a bit more time for a more in-depth review but that won't be tonight so I thought I'd send what I have so far.. Thanks for this. +++ b/drivers/gpu/drm/imx/Kconfig @@

Re: [PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Lars-Peter Clausen
[...] + +static int imx_drm_gem_mmap_buffer(struct file *filp, + struct vm_area_struct *vma) +{ + struct drm_gem_object *obj = filp-private_data; + struct imx_drm_gem_obj *imx_drm_gem_obj = to_imx_drm_gem_obj(obj); + struct imx_drm_buf_entry *entry; +

Re: [PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-23 Thread Daniel Vetter
On Wed, May 23, 2012 at 10:37:58AM +0200, Lars-Peter Clausen wrote: [...] + +static int imx_drm_gem_mmap_buffer(struct file *filp, + struct vm_area_struct *vma) +{ + struct drm_gem_object *obj = filp-private_data; + struct imx_drm_gem_obj *imx_drm_gem_obj =

[PATCH 1/2] DRM: add Freescale i.MX LCDC driver

2012-05-22 Thread Rob Clark
just a few comments from a cursory review.. I need a bit more time for a more in-depth review but that won't be tonight so I thought I'd send what I have so far.. On Fri, May 18, 2012 at 6:27 AM, Sascha Hauer wrote: > Signed-off-by: Sascha Hauer > --- > ?drivers/gpu/drm/Kconfig ? ? ? ? ? ? ?