Re: [PATCH 1/2] drm/imx: ipuv3-plane: Make functions static when possible

[Philipp Zabel]

On Tue, 2018-02-13 at 17:11 -0200, Fabio Estevam wrote:
> From: Fabio Estevam 
> 
> ipu_plane_state_reset(), ipu_plane_duplicate_state() and 
> ipu_plane_destroy_state() are only used in this file, so make them static.
> 
> This fixes the following sparse warnings:
> 
> drivers/gpu/drm/imx/ipuv3-plane.c:275:6: warning: symbol 
> 'ipu_plane_state_reset' was not declared. Should it be static?
> drivers/gpu/drm/imx/ipuv3-plane.c:295:24: warning: symbol 
> 'ipu_plane_duplicate_state' was not declared. Should it be static?
> drivers/gpu/drm/imx/ipuv3-plane.c:309:6: warning: symbol 
> 'ipu_plane_destroy_state' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam 

Applied both to imx-drm/fixes, thanks.

regards
Philipp
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/2] drm/imx: ipuv3-plane: Make functions static when possible

[Fabio Estevam]

From: Fabio Estevam 

ipu_plane_state_reset(), ipu_plane_duplicate_state() and 
ipu_plane_destroy_state() are only used in this file, so make them static.

This fixes the following sparse warnings:

drivers/gpu/drm/imx/ipuv3-plane.c:275:6: warning: symbol 
'ipu_plane_state_reset' was not declared. Should it be static?
drivers/gpu/drm/imx/ipuv3-plane.c:295:24: warning: symbol 
'ipu_plane_duplicate_state' was not declared. Should it be static?
drivers/gpu/drm/imx/ipuv3-plane.c:309:6: warning: symbol 
'ipu_plane_destroy_state' was not declared. Should it be static?

Signed-off-by: Fabio Estevam 
---
 drivers/gpu/drm/imx/ipuv3-plane.c | 9 +
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c 
b/drivers/gpu/drm/imx/ipuv3-plane.c
index 57ed56d..d9f0a76 100644
--- a/drivers/gpu/drm/imx/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx/ipuv3-plane.c
@@ -272,7 +272,7 @@ static void ipu_plane_destroy(struct drm_plane *plane)
kfree(ipu_plane);
 }
 
-void ipu_plane_state_reset(struct drm_plane *plane)
+static void ipu_plane_state_reset(struct drm_plane *plane)
 {
struct ipu_plane_state *ipu_state;
 
@@ -292,7 +292,8 @@ void ipu_plane_state_reset(struct drm_plane *plane)
plane->state = _state->base;
 }
 
-struct drm_plane_state *ipu_plane_duplicate_state(struct drm_plane *plane)
+static struct drm_plane_state *
+ipu_plane_duplicate_state(struct drm_plane *plane)
 {
struct ipu_plane_state *state;
 
@@ -306,8 +307,8 @@ struct drm_plane_state *ipu_plane_duplicate_state(struct 
drm_plane *plane)
return >base;
 }
 
-void ipu_plane_destroy_state(struct drm_plane *plane,
-struct drm_plane_state *state)
+static void ipu_plane_destroy_state(struct drm_plane *plane,
+   struct drm_plane_state *state)
 {
struct ipu_plane_state *ipu_state = to_ipu_plane_state(state);
 
-- 
2.7.4

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel