[PATCH 1/2] drm/rcar-du: Don't ignore rcar_du_crtc_create() return value

2013-07-04 Thread Laurent Pinchart
Handle error cases correctly.

Signed-off-by: Laurent Pinchart 
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c 
b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 9c63f39..06cacf6 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -191,8 +191,11 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu)
if (ret < 0)
return ret;

-   for (i = 0; i < ARRAY_SIZE(rcdu->crtcs); ++i)
-   rcar_du_crtc_create(rcdu, i);
+   for (i = 0; i < ARRAY_SIZE(rcdu->crtcs); ++i) {
+   ret = rcar_du_crtc_create(rcdu, i);
+   if (ret < 0)
+   return ret;
+   }

rcdu->used_crtcs = 0;
rcdu->num_crtcs = i;
-- 
1.8.1.5



[PATCH 1/2] drm/rcar-du: Don't ignore rcar_du_crtc_create() return value

2013-07-04 Thread Laurent Pinchart
Handle error cases correctly.

Signed-off-by: Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com
---
 drivers/gpu/drm/rcar-du/rcar_du_kms.c | 7 +--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c 
b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 9c63f39..06cacf6 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -191,8 +191,11 @@ int rcar_du_modeset_init(struct rcar_du_device *rcdu)
if (ret  0)
return ret;
 
-   for (i = 0; i  ARRAY_SIZE(rcdu-crtcs); ++i)
-   rcar_du_crtc_create(rcdu, i);
+   for (i = 0; i  ARRAY_SIZE(rcdu-crtcs); ++i) {
+   ret = rcar_du_crtc_create(rcdu, i);
+   if (ret  0)
+   return ret;
+   }
 
rcdu-used_crtcs = 0;
rcdu-num_crtcs = i;
-- 
1.8.1.5

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel