[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 InKi Dae :
> 2012/8/20 Joonyoung Shim :
>> On 08/20/2012 03:17 PM, InKi Dae wrote:
>>>
>>> 2012/8/20 Joonyoung Shim :
On 08/20/2012 11:29 AM, InKi Dae wrote:
>
> 2012/8/20 Joonyoung Shim :
>>
>> On 08/17/2012 06:50 PM, Inki Dae wrote:
>>>
>>> this patch changes ctx variable name in exynos_drm_hdmi_context
>>> structure to client because the use of ctx variable makes it confused.
>>
>>
>> I don't prefer "client" name. This is not client and server
>> relationship.
>>
> Okay, give me your opinion. which one do you prefer?
Just "data".
>>> It's not clear. "data" is so comprehensive just use "child_ctx". we
>>> already use "parent_ctx" as the context of exynos_drm_hdmi module.
>>
>>
>> Actually, i prefer "data" term than "ctx" term. Anyway i want to focus
>> why this problem is occurred because i think that codes are some ugly. I
>> think we first need to consider to solve this situation using code
>> redesign, structure change and etc.
>>
>
> calm down and focus on the use of term. this is so minor and this is
> not related to design issue.
>
and it's not important whether you prefer this term or not. if the use
of "data" term is logical enough then we will use it otherwise
"child_ctx" so give me your comment why you don't prefer "child_ctx"
term. actually, now hdmi codes use "hdata" term as context's instance
but other use "ctx" term. as I mentioned before, I gave you my opinion
that "data" term is so comprehensive so I DON'T PREFER "data" term.
>> Thanks.
>>
>>
>>>
Thanks.
>>> Signed-off-by: Inki Dae
>>> Signed-off-by: Kyungmin Park
>>> ---
>>> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
>>> +++---
>>> drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
>>> drivers/gpu/drm/exynos/exynos_hdmi.c | 12
>>> drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
>>> 4 files changed, 31 insertions(+), 31 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> index 3fdf0b6..bced38e 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> @@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device
>>> *dev)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->is_connected)
>>> - return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
>>> + return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
>>> return false;
>>> }
>>> @@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->get_edid)
>>> - return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx,
>>> connector,
>>> edid,
>>> - len);
>>> + return hdmi_ops->get_edid(ctx->hdmi_ctx->client,
>>> connector,
>>> + edid, len);
>>> return 0;
>>> }
>>> @@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
>>> void *timing)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->check_timing)
>>> - return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx,
>>> timing);
>>> + return hdmi_ops->check_timing(ctx->hdmi_ctx->client,
>>> timing);
>>> return 0;
>>> }
>>> @@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev,
>>> int
>>> mode)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->power_on)
>>> - return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
>>> + return hdmi_ops->power_on(ctx->hdmi_ctx->client,
>>> mode);
>>> return 0;
>>> }
>>> @@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
>>> *subdrv_dev)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (mixer_ops && mixer_ops->enable_vblank)
>>> - return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
>>> + return
>>> mixer_ops->enable_vblank(ctx->mixer_ctx->client,
>>> manager->pipe);
>>> return 0;
>>> @@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct
>>> device
>>> *subdrv_dev)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (mixer_ops && mixer_ops->disable_vblank)
>>> - return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
>>> + return
>>> mixer_ops->disable_vblank(ctx->mixer_ctx->client);
>>> }
>>>
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 Joonyoung Shim :
> On 08/20/2012 03:17 PM, InKi Dae wrote:
>>
>> 2012/8/20 Joonyoung Shim :
>>>
>>> On 08/20/2012 11:29 AM, InKi Dae wrote:
2012/8/20 Joonyoung Shim :
>
> On 08/17/2012 06:50 PM, Inki Dae wrote:
>>
>> this patch changes ctx variable name in exynos_drm_hdmi_context
>> structure to client because the use of ctx variable makes it confused.
>
>
> I don't prefer "client" name. This is not client and server
> relationship.
>
Okay, give me your opinion. which one do you prefer?
>>>
>>>
>>> Just "data".
>>>
>> It's not clear. "data" is so comprehensive just use "child_ctx". we
>> already use "parent_ctx" as the context of exynos_drm_hdmi module.
>
>
> Actually, i prefer "data" term than "ctx" term. Anyway i want to focus
> why this problem is occurred because i think that codes are some ugly. I
> think we first need to consider to solve this situation using code
> redesign, structure change and etc.
>
calm down and focus on the use of term. this is so minor and this is
not related to design issue.
> Thanks.
>
>
>>
>>> Thanks.
>>>
>>>
>> Signed-off-by: Inki Dae
>> Signed-off-by: Kyungmin Park
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
>> +++---
>> drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
>> drivers/gpu/drm/exynos/exynos_hdmi.c | 12
>> drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
>> 4 files changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> index 3fdf0b6..bced38e 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> @@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device
>> *dev)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->is_connected)
>> - return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
>> + return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
>> return false;
>> }
>> @@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->get_edid)
>> - return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx,
>> connector,
>> edid,
>> - len);
>> + return hdmi_ops->get_edid(ctx->hdmi_ctx->client,
>> connector,
>> + edid, len);
>> return 0;
>> }
>> @@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
>> void *timing)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->check_timing)
>> - return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx,
>> timing);
>> + return hdmi_ops->check_timing(ctx->hdmi_ctx->client,
>> timing);
>> return 0;
>> }
>> @@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev,
>> int
>> mode)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->power_on)
>> - return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
>> + return hdmi_ops->power_on(ctx->hdmi_ctx->client,
>> mode);
>> return 0;
>> }
>> @@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
>> *subdrv_dev)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (mixer_ops && mixer_ops->enable_vblank)
>> - return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
>> + return
>> mixer_ops->enable_vblank(ctx->mixer_ctx->client,
>> manager->pipe);
>> return 0;
>> @@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct
>> device
>> *subdrv_dev)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (mixer_ops && mixer_ops->disable_vblank)
>> - return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
>> + return
>> mixer_ops->disable_vblank(ctx->mixer_ctx->client);
>> }
>> static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
>> struct drm_connector *connector,
>> - const struct drm_display_mode *mode,
>> + struct drm_display_mode *mode,
>> struct drm_display_mode
>> *adjusted_mode)
>> {
>> struct drm_hdmi_context *ctx = to_context(subdrv_dev);
>> @@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
>> *subdrv_dev,
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
On 08/20/2012 03:17 PM, InKi Dae wrote:
> 2012/8/20 Joonyoung Shim :
>> On 08/20/2012 11:29 AM, InKi Dae wrote:
>>> 2012/8/20 Joonyoung Shim :
On 08/17/2012 06:50 PM, Inki Dae wrote:
> this patch changes ctx variable name in exynos_drm_hdmi_context
> structure to client because the use of ctx variable makes it confused.
I don't prefer "client" name. This is not client and server relationship.
>>> Okay, give me your opinion. which one do you prefer?
>>
>> Just "data".
>>
> It's not clear. "data" is so comprehensive just use "child_ctx". we
> already use "parent_ctx" as the context of exynos_drm_hdmi module.
Actually, i prefer "data" term than "ctx" term. Anyway i want to focus
why this problem is occurred because i think that codes are some ugly. I
think we first need to consider to solve this situation using code
redesign, structure change and etc.
Thanks.
>
>> Thanks.
>>
>>
> Signed-off-by: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
> +++---
> drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
> drivers/gpu/drm/exynos/exynos_hdmi.c | 12
> drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
> 4 files changed, 31 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> index 3fdf0b6..bced38e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> @@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (hdmi_ops && hdmi_ops->is_connected)
> - return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
> + return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
> return false;
> }
> @@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (hdmi_ops && hdmi_ops->get_edid)
> - return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx, connector,
> edid,
> - len);
> + return hdmi_ops->get_edid(ctx->hdmi_ctx->client,
> connector,
> + edid, len);
> return 0;
> }
> @@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
> void *timing)
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (hdmi_ops && hdmi_ops->check_timing)
> - return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx,
> timing);
> + return hdmi_ops->check_timing(ctx->hdmi_ctx->client,
> timing);
> return 0;
> }
> @@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
> mode)
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (hdmi_ops && hdmi_ops->power_on)
> - return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
> + return hdmi_ops->power_on(ctx->hdmi_ctx->client, mode);
> return 0;
> }
> @@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
> *subdrv_dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (mixer_ops && mixer_ops->enable_vblank)
> - return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
> + return mixer_ops->enable_vblank(ctx->mixer_ctx->client,
> manager->pipe);
> return 0;
> @@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
> *subdrv_dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (mixer_ops && mixer_ops->disable_vblank)
> - return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
> + return
> mixer_ops->disable_vblank(ctx->mixer_ctx->client);
> }
> static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
> struct drm_connector *connector,
> - const struct drm_display_mode *mode,
> + struct drm_display_mode *mode,
> struct drm_display_mode *adjusted_mode)
> {
> struct drm_hdmi_context *ctx = to_context(subdrv_dev);
> @@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
> *subdrv_dev,
> DRM_DEBUG_KMS("%s\n", __FILE__);
> if (hdmi_ops && hdmi_ops->mode_fixup)
> - hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector,
> mode,
> + hdmi_ops->mode_fixup(ctx->hdmi_ctx->client, connector,
> mode,
>
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 Joonyoung Shim :
> On 08/20/2012 11:29 AM, InKi Dae wrote:
>>
>> 2012/8/20 Joonyoung Shim :
>>>
>>> On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
>>>
>>>
>>> I don't prefer "client" name. This is not client and server relationship.
>>>
>> Okay, give me your opinion. which one do you prefer?
>
>
> Just "data".
>
It's not clear. "data" is so comprehensive just use "child_ctx". we
already use "parent_ctx" as the context of exynos_drm_hdmi module.
> Thanks.
>
>
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->is_connected)
- return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
+ return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->get_edid)
- return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx, connector,
edid,
- len);
+ return hdmi_ops->get_edid(ctx->hdmi_ctx->client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->check_timing)
- return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx,
timing);
+ return hdmi_ops->check_timing(ctx->hdmi_ctx->client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
mode)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->power_on)
- return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
+ return hdmi_ops->power_on(ctx->hdmi_ctx->client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (mixer_ops && mixer_ops->enable_vblank)
- return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
+ return mixer_ops->enable_vblank(ctx->mixer_ctx->client,
manager->pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (mixer_ops && mixer_ops->disable_vblank)
- return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
+ return
mixer_ops->disable_vblank(ctx->mixer_ctx->client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->mode_fixup)
- hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector,
mode,
+ hdmi_ops->mode_fixup(ctx->hdmi_ctx->client, connector,
mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
*subdrv_dev, void *mode)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->mode_set)
- hdmi_ops->mode_set(ctx->hdmi_ctx->ctx, mode);
+ hdmi_ops->mode_set(ctx->hdmi_ctx->client, mode);
}
static void drm_hdmi_get_max_resol(struct device
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
On 08/20/2012 11:29 AM, InKi Dae wrote:
> 2012/8/20 Joonyoung Shim :
>> On 08/17/2012 06:50 PM, Inki Dae wrote:
>>> this patch changes ctx variable name in exynos_drm_hdmi_context
>>> structure to client because the use of ctx variable makes it confused.
>>
>> I don't prefer "client" name. This is not client and server relationship.
>>
> Okay, give me your opinion. which one do you prefer?
Just "data".
Thanks.
>>> Signed-off-by: Inki Dae
>>> Signed-off-by: Kyungmin Park
>>> ---
>>>drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
>>> +++---
>>>drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
>>>drivers/gpu/drm/exynos/exynos_hdmi.c | 12
>>>drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
>>>4 files changed, 31 insertions(+), 31 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> index 3fdf0b6..bced38e 100644
>>> --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>>> @@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->is_connected)
>>> - return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
>>> + return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
>>> return false;
>>>}
>>> @@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->get_edid)
>>> - return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx, connector,
>>> edid,
>>> - len);
>>> + return hdmi_ops->get_edid(ctx->hdmi_ctx->client,
>>> connector,
>>> + edid, len);
>>> return 0;
>>>}
>>> @@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
>>> void *timing)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->check_timing)
>>> - return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx, timing);
>>> + return hdmi_ops->check_timing(ctx->hdmi_ctx->client,
>>> timing);
>>> return 0;
>>>}
>>> @@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
>>> mode)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->power_on)
>>> - return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
>>> + return hdmi_ops->power_on(ctx->hdmi_ctx->client, mode);
>>> return 0;
>>>}
>>> @@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
>>> *subdrv_dev)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (mixer_ops && mixer_ops->enable_vblank)
>>> - return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
>>> + return mixer_ops->enable_vblank(ctx->mixer_ctx->client,
>>> manager->pipe);
>>> return 0;
>>> @@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
>>> *subdrv_dev)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (mixer_ops && mixer_ops->disable_vblank)
>>> - return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
>>> + return mixer_ops->disable_vblank(ctx->mixer_ctx->client);
>>>}
>>> static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
>>> struct drm_connector *connector,
>>> - const struct drm_display_mode *mode,
>>> + struct drm_display_mode *mode,
>>> struct drm_display_mode *adjusted_mode)
>>>{
>>> struct drm_hdmi_context *ctx = to_context(subdrv_dev);
>>> @@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
>>> *subdrv_dev,
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->mode_fixup)
>>> - hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector, mode,
>>> + hdmi_ops->mode_fixup(ctx->hdmi_ctx->client, connector,
>>> mode,
>>> adjusted_mode);
>>>}
>>>@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
>>> *subdrv_dev, void *mode)
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->mode_set)
>>> - hdmi_ops->mode_set(ctx->hdmi_ctx->ctx, mode);
>>> + hdmi_ops->mode_set(ctx->hdmi_ctx->client, mode);
>>>}
>>> static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
>>> @@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
>>> *subdrv_dev,
>>> DRM_DEBUG_KMS("%s\n", __FILE__);
>>> if (hdmi_ops && hdmi_ops->get_max_resol)
>>> - hdmi_ops->get_max_resol(ctx->hdmi_ctx->ctx, width,
>>> height);
>>> +
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 Joonyoung Shim :
> On 08/17/2012 06:50 PM, Inki Dae wrote:
>>
>> this patch changes ctx variable name in exynos_drm_hdmi_context
>> structure to client because the use of ctx variable makes it confused.
>
>
> I don't prefer "client" name. This is not client and server relationship.
>
Okay, give me your opinion. which one do you prefer?
>
>>
>> Signed-off-by: Inki Dae
>> Signed-off-by: Kyungmin Park
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
>> +++---
>> drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
>> drivers/gpu/drm/exynos/exynos_hdmi.c | 12
>> drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
>> 4 files changed, 31 insertions(+), 31 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> index 3fdf0b6..bced38e 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
>> @@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->is_connected)
>> - return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
>> + return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
>> return false;
>> }
>> @@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->get_edid)
>> - return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx, connector,
>> edid,
>> - len);
>> + return hdmi_ops->get_edid(ctx->hdmi_ctx->client,
>> connector,
>> + edid, len);
>> return 0;
>> }
>> @@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
>> void *timing)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->check_timing)
>> - return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx, timing);
>> + return hdmi_ops->check_timing(ctx->hdmi_ctx->client,
>> timing);
>> return 0;
>> }
>> @@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
>> mode)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->power_on)
>> - return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
>> + return hdmi_ops->power_on(ctx->hdmi_ctx->client, mode);
>> return 0;
>> }
>> @@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
>> *subdrv_dev)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (mixer_ops && mixer_ops->enable_vblank)
>> - return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
>> + return mixer_ops->enable_vblank(ctx->mixer_ctx->client,
>> manager->pipe);
>> return 0;
>> @@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
>> *subdrv_dev)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (mixer_ops && mixer_ops->disable_vblank)
>> - return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
>> + return mixer_ops->disable_vblank(ctx->mixer_ctx->client);
>> }
>> static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
>> struct drm_connector *connector,
>> - const struct drm_display_mode *mode,
>> + struct drm_display_mode *mode,
>> struct drm_display_mode *adjusted_mode)
>> {
>> struct drm_hdmi_context *ctx = to_context(subdrv_dev);
>> @@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
>> *subdrv_dev,
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->mode_fixup)
>> - hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector, mode,
>> + hdmi_ops->mode_fixup(ctx->hdmi_ctx->client, connector,
>> mode,
>> adjusted_mode);
>> }
>> @@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
>> *subdrv_dev, void *mode)
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->mode_set)
>> - hdmi_ops->mode_set(ctx->hdmi_ctx->ctx, mode);
>> + hdmi_ops->mode_set(ctx->hdmi_ctx->client, mode);
>> }
>> static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
>> @@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
>> *subdrv_dev,
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> if (hdmi_ops && hdmi_ops->get_max_resol)
>> - hdmi_ops->get_max_resol(ctx->hdmi_ctx->ctx, width,
>> height);
>> + hdmi_ops->get_max_resol(ctx->hdmi_ctx->client, width,
>> height);
>> }
>> static void drm_hdmi_commit(struct device *subdrv_dev)
>> @@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
On 08/17/2012 06:50 PM, Inki Dae wrote:
> this patch changes ctx variable name in exynos_drm_hdmi_context
> structure to client because the use of ctx variable makes it confused.
I don't prefer "client" name. This is not client and server relationship.
>
> Signed-off-by: Inki Dae
> Signed-off-by: Kyungmin Park
> ---
> drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
> +++---
> drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
> drivers/gpu/drm/exynos/exynos_hdmi.c | 12
> drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
> 4 files changed, 31 insertions(+), 31 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> index 3fdf0b6..bced38e 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
> @@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->is_connected)
> - return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
> + return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
>
> return false;
> }
> @@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->get_edid)
> - return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx, connector, edid,
> - len);
> + return hdmi_ops->get_edid(ctx->hdmi_ctx->client, connector,
> + edid, len);
>
> return 0;
> }
> @@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev, void
> *timing)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->check_timing)
> - return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx, timing);
> + return hdmi_ops->check_timing(ctx->hdmi_ctx->client, timing);
>
> return 0;
> }
> @@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int mode)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->power_on)
> - return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
> + return hdmi_ops->power_on(ctx->hdmi_ctx->client, mode);
>
> return 0;
> }
> @@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
> *subdrv_dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (mixer_ops && mixer_ops->enable_vblank)
> - return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
> + return mixer_ops->enable_vblank(ctx->mixer_ctx->client,
> manager->pipe);
>
> return 0;
> @@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
> *subdrv_dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (mixer_ops && mixer_ops->disable_vblank)
> - return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
> + return mixer_ops->disable_vblank(ctx->mixer_ctx->client);
> }
>
> static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
> struct drm_connector *connector,
> - const struct drm_display_mode *mode,
> + struct drm_display_mode *mode,
> struct drm_display_mode *adjusted_mode)
> {
> struct drm_hdmi_context *ctx = to_context(subdrv_dev);
> @@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->mode_fixup)
> - hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector, mode,
> + hdmi_ops->mode_fixup(ctx->hdmi_ctx->client, connector, mode,
>adjusted_mode);
> }
>
> @@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device *subdrv_dev,
> void *mode)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->mode_set)
> - hdmi_ops->mode_set(ctx->hdmi_ctx->ctx, mode);
> + hdmi_ops->mode_set(ctx->hdmi_ctx->client, mode);
> }
>
> static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
> @@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
> *subdrv_dev,
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->get_max_resol)
> - hdmi_ops->get_max_resol(ctx->hdmi_ctx->ctx, width, height);
> + hdmi_ops->get_max_resol(ctx->hdmi_ctx->client, width, height);
> }
>
> static void drm_hdmi_commit(struct device *subdrv_dev)
> @@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device *subdrv_dev)
> DRM_DEBUG_KMS("%s\n", __FILE__);
>
> if (hdmi_ops && hdmi_ops->commit)
> - hdmi_ops->commit(ctx->hdmi_ctx->ctx);
> + hdmi_ops->commit(ctx->hdmi_ctx->client);
> }
>
>
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/20/2012 11:29 AM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server relationship.
Okay, give me your opinion. which one do you prefer?
Just data.
It's not clear. data is so comprehensive just use child_ctx. we
already use parent_ctx as the context of exynos_drm_hdmi module.
Thanks.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx, connector,
edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx,
timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return
mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector,
mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector,
mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
*subdrv_dev, void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+ hdmi_ops-mode_set(ctx-hdmi_ctx-client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_max_resol)
- hdmi_ops-get_max_resol(ctx-hdmi_ctx-ctx, width,
height);
+ hdmi_ops-get_max_resol(ctx-hdmi_ctx-client, width,
height);
}
static void drm_hdmi_commit(struct device *subdrv_dev)
@@ -182,7
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
On 08/20/2012 03:17 PM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/20/2012 11:29 AM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server relationship.
Okay, give me your opinion. which one do you prefer?
Just data.
It's not clear. data is so comprehensive just use child_ctx. we
already use parent_ctx as the context of exynos_drm_hdmi module.
Actually, i prefer data term than ctx term. Anyway i want to focus
why this problem is occurred because i think that codes are some ugly. I
think we first need to consider to solve this situation using code
redesign, structure change and etc.
Thanks.
Thanks.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx, connector,
edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx,
timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return
mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector,
mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector,
mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
*subdrv_dev, void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+ hdmi_ops-mode_set(ctx-hdmi_ctx-client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/20/2012 03:17 PM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/20/2012 11:29 AM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server
relationship.
Okay, give me your opinion. which one do you prefer?
Just data.
It's not clear. data is so comprehensive just use child_ctx. we
already use parent_ctx as the context of exynos_drm_hdmi module.
Actually, i prefer data term than ctx term. Anyway i want to focus
why this problem is occurred because i think that codes are some ugly. I
think we first need to consider to solve this situation using code
redesign, structure change and etc.
calm down and focus on the use of term. this is so minor and this is
not related to design issue.
Thanks.
Thanks.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device
*dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx,
connector,
edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx,
timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev,
int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client,
mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return
mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct
device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return
mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode
*adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector,
mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector,
mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
*subdrv_dev, void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 InKi Dae inki@samsung.com:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/20/2012 03:17 PM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/20/2012 11:29 AM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server
relationship.
Okay, give me your opinion. which one do you prefer?
Just data.
It's not clear. data is so comprehensive just use child_ctx. we
already use parent_ctx as the context of exynos_drm_hdmi module.
Actually, i prefer data term than ctx term. Anyway i want to focus
why this problem is occurred because i think that codes are some ugly. I
think we first need to consider to solve this situation using code
redesign, structure change and etc.
calm down and focus on the use of term. this is so minor and this is
not related to design issue.
and it's not important whether you prefer this term or not. if the use
of data term is logical enough then we will use it otherwise
child_ctx so give me your comment why you don't prefer child_ctx
term. actually, now hdmi codes use hdata term as context's instance
but other use ctx term. as I mentioned before, I gave you my opinion
that data term is so comprehensive so I DON'T PREFER data term.
Thanks.
Thanks.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device
*dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx,
connector,
edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx,
timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev,
int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client,
mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return
mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct
device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return
mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode
*adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
-
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server relationship.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38 +++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx, connector, edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client, connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev, void
*timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx, timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client, timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device *subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector, mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector, mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device *subdrv_dev, void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+ hdmi_ops-mode_set(ctx-hdmi_ctx-client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_max_resol)
- hdmi_ops-get_max_resol(ctx-hdmi_ctx-ctx, width, height);
+ hdmi_ops-get_max_resol(ctx-hdmi_ctx-client, width, height);
}
static void drm_hdmi_commit(struct device *subdrv_dev)
@@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device *subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-commit)
- hdmi_ops-commit(ctx-hdmi_ctx-ctx);
+ hdmi_ops-commit(ctx-hdmi_ctx-client);
}
static void drm_hdmi_dpms(struct device *subdrv_dev, int mode)
@@ -192,10 +192,10 @@ static void drm_hdmi_dpms(struct device *subdrv_dev, int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-dpms)
-
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server relationship.
Okay, give me your opinion. which one do you prefer?
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx, connector,
edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx, timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector, mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector,
mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
*subdrv_dev, void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+ hdmi_ops-mode_set(ctx-hdmi_ctx-client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_max_resol)
- hdmi_ops-get_max_resol(ctx-hdmi_ctx-ctx, width,
height);
+ hdmi_ops-get_max_resol(ctx-hdmi_ctx-client, width,
height);
}
static void drm_hdmi_commit(struct device *subdrv_dev)
@@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device *subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-commit)
- hdmi_ops-commit(ctx-hdmi_ctx-ctx);
+ hdmi_ops-commit(ctx-hdmi_ctx-client);
}
static void drm_hdmi_dpms(struct device
Re: [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
On 08/20/2012 11:29 AM, InKi Dae wrote:
2012/8/20 Joonyoung Shim jy0922.s...@samsung.com:
On 08/17/2012 06:50 PM, Inki Dae wrote:
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
I don't prefer client name. This is not client and server relationship.
Okay, give me your opinion. which one do you prefer?
Just data.
Thanks.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38
+++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx, connector,
edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client,
connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev,
void *timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx, timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client,
timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector, mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector,
mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device
*subdrv_dev, void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+ hdmi_ops-mode_set(ctx-hdmi_ctx-client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_max_resol)
- hdmi_ops-get_max_resol(ctx-hdmi_ctx-ctx, width,
height);
+ hdmi_ops-get_max_resol(ctx-hdmi_ctx-client, width,
height);
}
static void drm_hdmi_commit(struct device *subdrv_dev)
@@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device *subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-commit)
- hdmi_ops-commit(ctx-hdmi_ctx-ctx);
+ hdmi_ops-commit(ctx-hdmi_ctx-client);
}
static void drm_hdmi_dpms(struct
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
Signed-off-by: Inki Dae
Signed-off-by: Kyungmin Park
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38 +++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->is_connected)
- return hdmi_ops->is_connected(ctx->hdmi_ctx->ctx);
+ return hdmi_ops->is_connected(ctx->hdmi_ctx->client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->get_edid)
- return hdmi_ops->get_edid(ctx->hdmi_ctx->ctx, connector, edid,
- len);
+ return hdmi_ops->get_edid(ctx->hdmi_ctx->client, connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev, void
*timing)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->check_timing)
- return hdmi_ops->check_timing(ctx->hdmi_ctx->ctx, timing);
+ return hdmi_ops->check_timing(ctx->hdmi_ctx->client, timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int mode)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->power_on)
- return hdmi_ops->power_on(ctx->hdmi_ctx->ctx, mode);
+ return hdmi_ops->power_on(ctx->hdmi_ctx->client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device *subdrv_dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (mixer_ops && mixer_ops->enable_vblank)
- return mixer_ops->enable_vblank(ctx->mixer_ctx->ctx,
+ return mixer_ops->enable_vblank(ctx->mixer_ctx->client,
manager->pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (mixer_ops && mixer_ops->disable_vblank)
- return mixer_ops->disable_vblank(ctx->mixer_ctx->ctx);
+ return mixer_ops->disable_vblank(ctx->mixer_ctx->client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->mode_fixup)
- hdmi_ops->mode_fixup(ctx->hdmi_ctx->ctx, connector, mode,
+ hdmi_ops->mode_fixup(ctx->hdmi_ctx->client, connector, mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device *subdrv_dev,
void *mode)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->mode_set)
- hdmi_ops->mode_set(ctx->hdmi_ctx->ctx, mode);
+ hdmi_ops->mode_set(ctx->hdmi_ctx->client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->get_max_resol)
- hdmi_ops->get_max_resol(ctx->hdmi_ctx->ctx, width, height);
+ hdmi_ops->get_max_resol(ctx->hdmi_ctx->client, width, height);
}
static void drm_hdmi_commit(struct device *subdrv_dev)
@@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device *subdrv_dev)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (hdmi_ops && hdmi_ops->commit)
- hdmi_ops->commit(ctx->hdmi_ctx->ctx);
+ hdmi_ops->commit(ctx->hdmi_ctx->client);
}
static void drm_hdmi_dpms(struct device *subdrv_dev, int mode)
@@ -192,10 +192,10 @@ static void drm_hdmi_dpms(struct device *subdrv_dev, int
mode)
DRM_DEBUG_KMS("%s\n", __FILE__);
if (mixer_ops && mixer_ops->dpms)
- mixer_ops->dpms(ctx->mixer_ctx->ctx, mode);
+
[PATCH 11/13] drm/exynos: changed context name of hdmi and mixer
this patch changes ctx variable name in exynos_drm_hdmi_context
structure to client because the use of ctx variable makes it confused.
Signed-off-by: Inki Dae inki@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
drivers/gpu/drm/exynos/exynos_drm_hdmi.c | 38 +++---
drivers/gpu/drm/exynos/exynos_drm_hdmi.h |4 +-
drivers/gpu/drm/exynos/exynos_hdmi.c | 12
drivers/gpu/drm/exynos/exynos_mixer.c|8 +++---
4 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
index 3fdf0b6..bced38e 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_hdmi.c
@@ -64,7 +64,7 @@ static bool drm_hdmi_is_connected(struct device *dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-is_connected)
- return hdmi_ops-is_connected(ctx-hdmi_ctx-ctx);
+ return hdmi_ops-is_connected(ctx-hdmi_ctx-client);
return false;
}
@@ -77,8 +77,8 @@ static int drm_hdmi_get_edid(struct device *dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_edid)
- return hdmi_ops-get_edid(ctx-hdmi_ctx-ctx, connector, edid,
- len);
+ return hdmi_ops-get_edid(ctx-hdmi_ctx-client, connector,
+ edid, len);
return 0;
}
@@ -90,7 +90,7 @@ static int drm_hdmi_check_timing(struct device *dev, void
*timing)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-check_timing)
- return hdmi_ops-check_timing(ctx-hdmi_ctx-ctx, timing);
+ return hdmi_ops-check_timing(ctx-hdmi_ctx-client, timing);
return 0;
}
@@ -102,7 +102,7 @@ static int drm_hdmi_power_on(struct device *dev, int mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-power_on)
- return hdmi_ops-power_on(ctx-hdmi_ctx-ctx, mode);
+ return hdmi_ops-power_on(ctx-hdmi_ctx-client, mode);
return 0;
}
@@ -124,7 +124,7 @@ static int drm_hdmi_enable_vblank(struct device *subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-enable_vblank)
- return mixer_ops-enable_vblank(ctx-mixer_ctx-ctx,
+ return mixer_ops-enable_vblank(ctx-mixer_ctx-client,
manager-pipe);
return 0;
@@ -137,12 +137,12 @@ static void drm_hdmi_disable_vblank(struct device
*subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-disable_vblank)
- return mixer_ops-disable_vblank(ctx-mixer_ctx-ctx);
+ return mixer_ops-disable_vblank(ctx-mixer_ctx-client);
}
static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
struct drm_connector *connector,
- const struct drm_display_mode *mode,
+ struct drm_display_mode *mode,
struct drm_display_mode *adjusted_mode)
{
struct drm_hdmi_context *ctx = to_context(subdrv_dev);
@@ -150,7 +150,7 @@ static void drm_hdmi_mode_fixup(struct device *subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_fixup)
- hdmi_ops-mode_fixup(ctx-hdmi_ctx-ctx, connector, mode,
+ hdmi_ops-mode_fixup(ctx-hdmi_ctx-client, connector, mode,
adjusted_mode);
}
@@ -161,7 +161,7 @@ static void drm_hdmi_mode_set(struct device *subdrv_dev,
void *mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-mode_set)
- hdmi_ops-mode_set(ctx-hdmi_ctx-ctx, mode);
+ hdmi_ops-mode_set(ctx-hdmi_ctx-client, mode);
}
static void drm_hdmi_get_max_resol(struct device *subdrv_dev,
@@ -172,7 +172,7 @@ static void drm_hdmi_get_max_resol(struct device
*subdrv_dev,
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-get_max_resol)
- hdmi_ops-get_max_resol(ctx-hdmi_ctx-ctx, width, height);
+ hdmi_ops-get_max_resol(ctx-hdmi_ctx-client, width, height);
}
static void drm_hdmi_commit(struct device *subdrv_dev)
@@ -182,7 +182,7 @@ static void drm_hdmi_commit(struct device *subdrv_dev)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (hdmi_ops hdmi_ops-commit)
- hdmi_ops-commit(ctx-hdmi_ctx-ctx);
+ hdmi_ops-commit(ctx-hdmi_ctx-client);
}
static void drm_hdmi_dpms(struct device *subdrv_dev, int mode)
@@ -192,10 +192,10 @@ static void drm_hdmi_dpms(struct device *subdrv_dev, int
mode)
DRM_DEBUG_KMS(%s\n, __FILE__);
if (mixer_ops mixer_ops-dpms)
- mixer_ops-dpms(ctx-mixer_ctx-ctx, mode);
+ mixer_ops-dpms(ctx-mixer_ctx-client, mode);
