Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Tom St Denis
On 09/02/18 09:56 AM, Christian König wrote: Am 09.02.2018 um 15:51 schrieb Tom St Denis: On 09/02/18 09:12 AM, Christian König wrote: No, there is simply no need to initialize the system domain. What are the values of p->mapping and adev->mman.bdev.dev_mapping when they don't match? Maybe we

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Christian König
Am 09.02.2018 um 15:51 schrieb Tom St Denis: On 09/02/18 09:12 AM, Christian König wrote: No, there is simply no need to initialize the system domain. What are the values of p->mapping and adev->mman.bdev.dev_mapping when they don't match? Maybe we are allocating memory before initializing

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Tom St Denis
On 09/02/18 09:12 AM, Christian König wrote: No, there is simply no need to initialize the system domain. What are the values of p->mapping and adev->mman.bdev.dev_mapping when they don't match? Maybe we are allocating memory before initializing adev->mman.bdev.dev_mapping. In my test setup

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Christian König
Am 09.02.2018 um 15:02 schrieb Tom St Denis: On 09/02/18 08:56 AM, Christian König wrote: Am 09.02.2018 um 14:32 schrieb Tom St Denis: On 02/02/18 02:09 PM, Christian König wrote: [SNIP] +    if (p->mapping != adev->mman.bdev.dev_mapping) +    return -EPERM; This comparison

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Tom St Denis
On 09/02/18 08:56 AM, Christian König wrote: Am 09.02.2018 um 14:32 schrieb Tom St Denis: On 02/02/18 02:09 PM, Christian König wrote: [SNIP] +    if (p->mapping != adev->mman.bdev.dev_mapping) +    return -EPERM; This comparison fails for both IOMMU and non-IOMMU devices in my

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Christian König
Am 09.02.2018 um 14:32 schrieb Tom St Denis: On 02/02/18 02:09 PM, Christian König wrote: [SNIP] +    if (p->mapping != adev->mman.bdev.dev_mapping) +    return -EPERM; This comparison fails for both IOMMU and non-IOMMU devices in my carrizo+polaris10 box. The address being

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-09 Thread Tom St Denis
On 02/02/18 02:09 PM, Christian König wrote: This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 57 - 1 file changed, 35

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-05 Thread Tom St Denis
3, 2018 3:10 AM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König <christian.koe...@amd.com> ---

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-05 Thread Christian König
f Christian K?nig Sent: Saturday, February 03, 2018 3:10 AM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-05 Thread Tom St Denis
bruary 03, 2018 3:10 AM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König <christian.koe...

RE: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-04 Thread He, Roger
2018 3:10 AM To: amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Subject: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König <christian.koe...@amd.com> ---

Re: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-02 Thread StDenis, Tom
.org Subject: [PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König <christian.koe...@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 57 ---

[PATCH 5/5] drm/amdgpu: replace iova debugfs file with iomem

2018-02-02 Thread Christian König
This allows access to pages allocated through the driver with optional IOMMU mapping. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 57 - 1 file changed, 35 insertions(+), 22 deletions(-) diff --git