Re: [PATCH libdrm] tests/util: fix incorrect memset argument order

[David Airlie]

Reviewed-by: Dave Airlie 

On Wed, Jul 3, 2019 at 1:20 PM Ilia Mirkin  wrote:
>
> Make it actually clear the LUT.
>
> Reported-by: Dave Airlie 
> Signed-off-by: Ilia Mirkin 
> ---
>  tests/util/pattern.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/util/pattern.c b/tests/util/pattern.c
> index 42a0e5c7..bf1797d4 100644
> --- a/tests/util/pattern.c
> +++ b/tests/util/pattern.c
> @@ -643,7 +643,7 @@ void util_smpte_c8_gamma(unsigned size, struct 
> drm_color_lut *lut)
> printf("Error: gamma too small: %d < %d\n", size, 7 + 7 + 8);
> return;
> }
> -   memset(lut, size * sizeof(struct drm_color_lut), 0);
> +   memset(lut, 0, size * sizeof(struct drm_color_lut));
>
>  #define FILL_COLOR(idx, r, g, b) \
> lut[idx].red = (r) << 8; \
> --
> 2.21.0
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH libdrm] tests/util: fix incorrect memset argument order

[Ilia Mirkin]

Make it actually clear the LUT.

Reported-by: Dave Airlie 
Signed-off-by: Ilia Mirkin 
---
 tests/util/pattern.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/util/pattern.c b/tests/util/pattern.c
index 42a0e5c7..bf1797d4 100644
--- a/tests/util/pattern.c
+++ b/tests/util/pattern.c
@@ -643,7 +643,7 @@ void util_smpte_c8_gamma(unsigned size, struct 
drm_color_lut *lut)
printf("Error: gamma too small: %d < %d\n", size, 7 + 7 + 8);
return;
}
-   memset(lut, size * sizeof(struct drm_color_lut), 0);
+   memset(lut, 0, size * sizeof(struct drm_color_lut));
 
 #define FILL_COLOR(idx, r, g, b) \
lut[idx].red = (r) << 8; \
-- 
2.21.0

___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel