Re: [EXT] Re: [PATCH v2 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-14 Thread Robert Chiras
Hi Daniel, On Mi, 2019-08-14 at 12:44 +0100, Daniel Stone wrote: > Hi Robert, > > On Wed, 14 Aug 2019 at 11:49, Robert Chiras > wrote: > > > > +   case DRM_FORMAT_BGR565: /* BG16 */ > > +   if (mxsfb->devdata->ipversion < 4) > > +   goto err; > > +   

Re: [PATCH v2 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-14 Thread Daniel Stone
Hi Robert, On Wed, 14 Aug 2019 at 11:49, Robert Chiras wrote: > + case DRM_FORMAT_BGR565: /* BG16 */ > + if (mxsfb->devdata->ipversion < 4) > + goto err; > + writel(CTRL2_ODD_LINE_PATTERN(CTRL2_LINE_PATTERN_BGR) | > + C

[PATCH v2 06/15] drm/mxsfb: Update mxsfb with additional pixel formats

2019-08-14 Thread Robert Chiras
Since version 4 of eLCDIF, there are some registers that can do transformations on the input data, like re-arranging the pixel components. By doing that, we can support more pixel formats. This patch adds support for X/ABGR and RGBX/A. Although, the local alpha is not supported by eLCDIF, the alpha