Re: [PATCH v2 09/60] drm/omap: dss: Remove DSS encoders get_timings operation

[Sebastian Reichel]

Hi,

On Sat, May 26, 2018 at 08:24:27PM +0300, Laurent Pinchart wrote:
> The get_timings operation from DSS encoders (not to be confused with the
> identically named operation in omap_dss_driver) is never called. Remove
> it.
> 
> Signed-off-by: Laurent Pinchart 
> ---

good catch!

Reviewed-by: Sebastian Reichel 

-- Sebastian

>  drivers/gpu/drm/omapdrm/displays/encoder-opa362.c| 11 ---
>  drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c|  9 -
>  drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c |  9 -
>  drivers/gpu/drm/omapdrm/dss/dpi.c| 13 -
>  drivers/gpu/drm/omapdrm/dss/hdmi4.c  |  9 -
>  drivers/gpu/drm/omapdrm/dss/hdmi5.c  |  9 -
>  drivers/gpu/drm/omapdrm/dss/omapdss.h| 10 --
>  drivers/gpu/drm/omapdrm/dss/sdi.c|  9 -
>  drivers/gpu/drm/omapdrm/dss/venc.c   | 13 -
>  9 files changed, 92 deletions(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c 
> b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> index afee1b8b457a..27d63a14efe3 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
> @@ -148,16 +148,6 @@ static void opa362_set_timings(struct omap_dss_device 
> *dssdev,
>   in->ops.atv->set_timings(in, vm);
>  }
>  
> -static void opa362_get_timings(struct omap_dss_device *dssdev,
> -struct videomode *vm)
> -{
> - struct panel_drv_data *ddata = to_panel_data(dssdev);
> -
> - dev_dbg(dssdev->dev, "get_timings\n");
> -
> - *vm = ddata->vm;
> -}
> -
>  static int opa362_check_timings(struct omap_dss_device *dssdev,
>   struct videomode *vm)
>  {
> @@ -178,7 +168,6 @@ static const struct omapdss_atv_ops opa362_atv_ops = {
>  
>   .check_timings  = opa362_check_timings,
>   .set_timings= opa362_set_timings,
> - .get_timings= opa362_get_timings,
>  };
>  
>  static int opa362_probe(struct platform_device *pdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c 
> b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> index ed7ae384c3ed..566c63a3ad59 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
> @@ -142,14 +142,6 @@ static void tfp410_set_timings(struct omap_dss_device 
> *dssdev,
>   in->ops.dpi->set_timings(in, vm);
>  }
>  
> -static void tfp410_get_timings(struct omap_dss_device *dssdev,
> -struct videomode *vm)
> -{
> - struct panel_drv_data *ddata = to_panel_data(dssdev);
> -
> - *vm = ddata->vm;
> -}
> -
>  static int tfp410_check_timings(struct omap_dss_device *dssdev,
>   struct videomode *vm)
>  {
> @@ -170,7 +162,6 @@ static const struct omapdss_dvi_ops tfp410_dvi_ops = {
>  
>   .check_timings  = tfp410_check_timings,
>   .set_timings= tfp410_set_timings,
> - .get_timings= tfp410_get_timings,
>  };
>  
>  static int tfp410_probe_of(struct platform_device *pdev)
> diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c 
> b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
> index d275bf152da5..4753e5455f82 100644
> --- a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
> +++ b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
> @@ -136,14 +136,6 @@ static void tpd_set_timings(struct omap_dss_device 
> *dssdev,
>   in->ops.hdmi->set_timings(in, vm);
>  }
>  
> -static void tpd_get_timings(struct omap_dss_device *dssdev,
> - struct videomode *vm)
> -{
> - struct panel_drv_data *ddata = to_panel_data(dssdev);
> -
> - *vm = ddata->vm;
> -}
> -
>  static int tpd_check_timings(struct omap_dss_device *dssdev,
>struct videomode *vm)
>  {
> @@ -249,7 +241,6 @@ static const struct omapdss_hdmi_ops tpd_hdmi_ops = {
>  
>   .check_timings  = tpd_check_timings,
>   .set_timings= tpd_set_timings,
> - .get_timings= tpd_get_timings,
>  
>   .read_edid  = tpd_read_edid,
>   .detect = tpd_detect,
> diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c 
> b/drivers/gpu/drm/omapdrm/dss/dpi.c
> index 3d662e6805eb..af002c57a41d 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dpi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
> @@ -491,18 +491,6 @@ static void dpi_set_timings(struct omap_dss_device 
> *dssdev,
>   mutex_unlock(>lock);
>  }
>  
> -static void dpi_get_timings(struct omap_dss_device *dssdev,
> - struct videomode *vm)
> -{
> - struct dpi_data *dpi = dpi_get_data_from_dssdev(dssdev);
> -
> - mutex_lock(>lock);
> -
> - *vm = dpi->vm;
> -
> - mutex_unlock(>lock);
> -}
> -
>  static int dpi_check_timings(struct omap_dss_device *dssdev,
>   

[PATCH v2 09/60] drm/omap: dss: Remove DSS encoders get_timings operation

[Laurent Pinchart]

The get_timings operation from DSS encoders (not to be confused with the
identically named operation in omap_dss_driver) is never called. Remove
it.

Signed-off-by: Laurent Pinchart 
---
 drivers/gpu/drm/omapdrm/displays/encoder-opa362.c| 11 ---
 drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c|  9 -
 drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c |  9 -
 drivers/gpu/drm/omapdrm/dss/dpi.c| 13 -
 drivers/gpu/drm/omapdrm/dss/hdmi4.c  |  9 -
 drivers/gpu/drm/omapdrm/dss/hdmi5.c  |  9 -
 drivers/gpu/drm/omapdrm/dss/omapdss.h| 10 --
 drivers/gpu/drm/omapdrm/dss/sdi.c|  9 -
 drivers/gpu/drm/omapdrm/dss/venc.c   | 13 -
 9 files changed, 92 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c 
b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
index afee1b8b457a..27d63a14efe3 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-opa362.c
@@ -148,16 +148,6 @@ static void opa362_set_timings(struct omap_dss_device 
*dssdev,
in->ops.atv->set_timings(in, vm);
 }
 
-static void opa362_get_timings(struct omap_dss_device *dssdev,
-  struct videomode *vm)
-{
-   struct panel_drv_data *ddata = to_panel_data(dssdev);
-
-   dev_dbg(dssdev->dev, "get_timings\n");
-
-   *vm = ddata->vm;
-}
-
 static int opa362_check_timings(struct omap_dss_device *dssdev,
struct videomode *vm)
 {
@@ -178,7 +168,6 @@ static const struct omapdss_atv_ops opa362_atv_ops = {
 
.check_timings  = opa362_check_timings,
.set_timings= opa362_set_timings,
-   .get_timings= opa362_get_timings,
 };
 
 static int opa362_probe(struct platform_device *pdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c 
b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
index ed7ae384c3ed..566c63a3ad59 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tfp410.c
@@ -142,14 +142,6 @@ static void tfp410_set_timings(struct omap_dss_device 
*dssdev,
in->ops.dpi->set_timings(in, vm);
 }
 
-static void tfp410_get_timings(struct omap_dss_device *dssdev,
-  struct videomode *vm)
-{
-   struct panel_drv_data *ddata = to_panel_data(dssdev);
-
-   *vm = ddata->vm;
-}
-
 static int tfp410_check_timings(struct omap_dss_device *dssdev,
struct videomode *vm)
 {
@@ -170,7 +162,6 @@ static const struct omapdss_dvi_ops tfp410_dvi_ops = {
 
.check_timings  = tfp410_check_timings,
.set_timings= tfp410_set_timings,
-   .get_timings= tfp410_get_timings,
 };
 
 static int tfp410_probe_of(struct platform_device *pdev)
diff --git a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c 
b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
index d275bf152da5..4753e5455f82 100644
--- a/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
+++ b/drivers/gpu/drm/omapdrm/displays/encoder-tpd12s015.c
@@ -136,14 +136,6 @@ static void tpd_set_timings(struct omap_dss_device *dssdev,
in->ops.hdmi->set_timings(in, vm);
 }
 
-static void tpd_get_timings(struct omap_dss_device *dssdev,
-   struct videomode *vm)
-{
-   struct panel_drv_data *ddata = to_panel_data(dssdev);
-
-   *vm = ddata->vm;
-}
-
 static int tpd_check_timings(struct omap_dss_device *dssdev,
 struct videomode *vm)
 {
@@ -249,7 +241,6 @@ static const struct omapdss_hdmi_ops tpd_hdmi_ops = {
 
.check_timings  = tpd_check_timings,
.set_timings= tpd_set_timings,
-   .get_timings= tpd_get_timings,
 
.read_edid  = tpd_read_edid,
.detect = tpd_detect,
diff --git a/drivers/gpu/drm/omapdrm/dss/dpi.c 
b/drivers/gpu/drm/omapdrm/dss/dpi.c
index 3d662e6805eb..af002c57a41d 100644
--- a/drivers/gpu/drm/omapdrm/dss/dpi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dpi.c
@@ -491,18 +491,6 @@ static void dpi_set_timings(struct omap_dss_device *dssdev,
mutex_unlock(>lock);
 }
 
-static void dpi_get_timings(struct omap_dss_device *dssdev,
-   struct videomode *vm)
-{
-   struct dpi_data *dpi = dpi_get_data_from_dssdev(dssdev);
-
-   mutex_lock(>lock);
-
-   *vm = dpi->vm;
-
-   mutex_unlock(>lock);
-}
-
 static int dpi_check_timings(struct omap_dss_device *dssdev,
 struct videomode *vm)
 {
@@ -702,7 +690,6 @@ static const struct omapdss_dpi_ops dpi_ops = {
 
.check_timings = dpi_check_timings,
.set_timings = dpi_set_timings,
-   .get_timings = dpi_get_timings,
 };
 
 static void dpi_init_output_port(struct dpi_data *dpi, struct